GNU bug report logs - #70882
30.0.50; [PATCH] Print the real direction in the prompt for '(previous|next)-matching-history-element'

Previous Next

Package: emacs;

Reported by: Jim Porter <jporterbugs <at> gmail.com>

Date: Sat, 11 May 2024 18:54:02 UTC

Severity: normal

Tags: patch

Found in version 30.0.50

Done: Jim Porter <jporterbugs <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#70882: closed (30.0.50; [PATCH] Print the real direction in
 the prompt for '(previous|next)-matching-history-element')
Date: Mon, 20 May 2024 01:37:01 +0000
[Message part 1 (text/plain, inline)]
Your message dated Sun, 19 May 2024 18:35:27 -0700
with message-id <f40cbf1f-d65c-8729-3f7e-4c498ab6b942 <at> gmail.com>
and subject line Re: bug#70882: 30.0.50; [PATCH] Print the real direction in the prompt for '(previous|next)-matching-history-element'
has caused the debbugs.gnu.org bug report #70882,
regarding 30.0.50; [PATCH] Print the real direction in the prompt for '(previous|next)-matching-history-element'
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
70882: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70882
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Jim Porter <jporterbugs <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; [PATCH] Print the real direction in the prompt for
 '(previous|next)-matching-history-element'
Date: Sat, 11 May 2024 11:53:18 -0700
[Message part 3 (text/plain, inline)]
To see the problem, start from "emacs -Q":

  M-x
  M-r      ;; Emacs prompts "Previous element matching regexp:"
  C-g

  M-- M-r  ;; Emacs prompts "Previous element matching regexp:" (?!)

In the last line, the prefix argument is negative, so the search will 
actually be for the *next* matching element. The attached patch fixes 
this so that the prompt message accounts for the prefix arg.

While I was here, I also made 'next-matching-history-element' use 
'format-prompt' like its 'previous-...' sibling.
[0001-Tell-direction-in-prompts-for-previous-next-matching.patch (text/plain, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Jim Porter <jporterbugs <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 70882-done <at> debbugs.gnu.org
Subject: Re: bug#70882: 30.0.50; [PATCH] Print the real direction in the
 prompt for '(previous|next)-matching-history-element'
Date: Sun, 19 May 2024 18:35:27 -0700
On 5/18/2024 2:18 AM, Eli Zaretskii wrote:
> Thanks, LGTM.

Thanks for checking. Merged as 44d1687f1f6, and closing this bug.



This bug report was last modified 1 year and 1 day ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.