GNU bug report logs - #70878
[PATCH 0/4] Reduce download builder duplication.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#70878: closed ([PATCH 0/4] Reduce download builder duplication.)
Date: Tue, 11 Jun 2024 15:56:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 11 Jun 2024 12:05:50 +0100
with message-id <871q53buy9.fsf <at> cbaines.net>
and subject line Re: [bug#70878] [PATCH 0/4] Reduce download builder duplication.
has caused the debbugs.gnu.org bug report #70878,
regarding [PATCH 0/4] Reduce download builder duplication.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
70878: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70878
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/4] Reduce download builder duplication.
Date: Sat, 11 May 2024 17:29:16 +0100

[Message part 3 (text/plain, inline)]

I think we currently have an issue where the builder scripts for several
download approaches are very numerous, svn-multi-download is probably
the extreme example as that's used for the numerous texlive packages.

I noticed this when wondering why bayfront is spending so much time
substituting svn-multi-download files from data.guix.gnu.org, and it's
probably taking up extra space in the data.guix.gnu.org database too.

These commits should address the issue in svn-multi-fetch, svn-fetch,
hg-fetch and git-fetch (although this issue doesn't affect users of
builtin:git-download).  The main change is to pass the hash through to
the builder as an environment variable, rather than generating a
different builder script for each different hash.

I've also restructured the code to try and avoid this problem in the
future.  While there was a comment about the intent to not duplicate the
builder scripts, it's too easy to miss.  By moving the builder to it's
own procedure and moving the comment to the call site, it'll be clearer
when a new source of variation is added.


Christopher Baines (4):
  svn-download: Reduce svn-multi-fetch builder duplication.
  svn-download: Reduce svn-fetch builder duplication.
  hg-download: Reduce builder duplication.
  git-download: Reduce builder duplication.

 guix/git-download.scm | 123 +++++++++++---------
 guix/hg-download.scm  | 127 +++++++++++---------
 guix/svn-download.scm | 264 +++++++++++++++++++++++-------------------
 3 files changed, 291 insertions(+), 223 deletions(-)

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: 70878-done <at> debbugs.gnu.org
Subject: Re: [bug#70878] [PATCH 0/4] Reduce download builder duplication.
Date: Tue, 11 Jun 2024 12:05:50 +0100

[Message part 6 (text/plain, inline)]

Christopher Baines <mail <at> cbaines.net> writes:

> I think we currently have an issue where the builder scripts for several
> download approaches are very numerous, svn-multi-download is probably
> the extreme example as that's used for the numerous texlive packages.
>
> I noticed this when wondering why bayfront is spending so much time
> substituting svn-multi-download files from data.guix.gnu.org, and it's
> probably taking up extra space in the data.guix.gnu.org database too.
>
> These commits should address the issue in svn-multi-fetch, svn-fetch,
> hg-fetch and git-fetch (although this issue doesn't affect users of
> builtin:git-download).  The main change is to pass the hash through to
> the builder as an environment variable, rather than generating a
> different builder script for each different hash.
>
> I've also restructured the code to try and avoid this problem in the
> future.  While there was a comment about the intent to not duplicate the
> builder scripts, it's too easy to miss.  By moving the builder to it's
> own procedure and moving the comment to the call site, it'll be clearer
> when a new source of variation is added.
>
>
> Christopher Baines (4):
>   svn-download: Reduce svn-multi-fetch builder duplication.
>   svn-download: Reduce svn-fetch builder duplication.
>   hg-download: Reduce builder duplication.
>   git-download: Reduce builder duplication.
>
>  guix/git-download.scm | 123 +++++++++++---------
>  guix/hg-download.scm  | 127 +++++++++++---------
>  guix/svn-download.scm | 264 +++++++++++++++++++++++-------------------
>  3 files changed, 291 insertions(+), 223 deletions(-)

I've tweaked the commit messages a little and pushed these patches to
master as 0daa72e34d7fafc927e2d476ef613c582107781d.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.