From unknown Sat Jun 21 03:25:41 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#70871 <70871@debbugs.gnu.org> To: bug#70871 <70871@debbugs.gnu.org> Subject: Status: [PATCH] Show avatars from Libravatar. Reply-To: bug#70871 <70871@debbugs.gnu.org> Date: Sat, 21 Jun 2025 10:25:41 +0000 retitle 70871 [PATCH] Show avatars from Libravatar. reassign 70871 mumi submitter 70871 Felix Lechner severity 70871 normal tag 70871 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri May 10 23:20:37 2024 Received: (at submit) by debbugs.gnu.org; 11 May 2024 03:20:37 +0000 Received: from localhost ([127.0.0.1]:45726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s5dHp-0006EX-6t for submit@debbugs.gnu.org; Fri, 10 May 2024 23:20:37 -0400 Received: from lists.gnu.org ([209.51.188.17]:37430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s5dHm-0006ER-R4 for submit@debbugs.gnu.org; Fri, 10 May 2024 23:20:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s5dHg-0007RZ-ID for bug-mumi@gnu.org; Fri, 10 May 2024 23:20:33 -0400 Received: from sail-ipv4.us-core.com ([208.82.101.137]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1s5dHd-0006JP-Vq for bug-mumi@gnu.org; Fri, 10 May 2024 23:20:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=X9LxgqXX3dNbzIq SeLeQRjv7Y+f9VFcSJBMEvHYV45w=; h=date:subject:cc:to:from; d=lease-up.com; b=CF0nU/sgnfqevCMwh2kKXpmhY5JB8k9F05W+COrkBXntB/vgx9pp qauuDLgqjhPxUv/2sMShkqf7EcArWm086JLdsxHMsiSFdxLil+2E5VjYLFNczkz26iXtdx +AsO52IgTJb5t8c441D33SaTTnur4n9anlaVjLTvP4yAz91xQ= Received: by localhost (OpenSMTPD) with ESMTPA id f2394414 for ; Sat, 11 May 2024 03:20:24 +0000 (UTC) Delivered-To: bug-mumi@patchwise.org DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=X9LxgqXX3dNbzIq SeLeQRjv7Y+f9VFcSJBMEvHYV45w=; h=date:subject:cc:to:from; d=lease-up.com; b=CF0nU/sgnfqevCMwh2kKXpmhY5JB8k9F05W+COrkBXntB/vgx9pp qauuDLgqjhPxUv/2sMShkqf7EcArWm086JLdsxHMsiSFdxLil+2E5VjYLFNczkz26iXtdx +AsO52IgTJb5t8c441D33SaTTnur4n9anlaVjLTvP4yAz91xQ= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 6c0c0bcf (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Sat, 11 May 2024 03:20:24 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id bb2c4433; Sat, 11 May 2024 03:20:23 +0000 (UTC) From: Felix Lechner To: bug-mumi@patchwise.org Subject: [PATCH] Show avatars from Libravatar. Date: Fri, 10 May 2024 20:20:08 -0700 Message-ID: <20240511032008.16270-1-felix.lechner@lease-up.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=208.82.101.137; envelope-from=felix.lechner@us-core.com; helo=sail-ipv4.us-core.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit Cc: Felix Lechner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Requires guile-avatar from here: https://codeberg.org/lechner/guile-avatar The packaging code for guile-avatar can be added to Guix by accepting this patch: https://debbugs.gnu.org/70870 In Guix, the package should then be mentioned as an "input" to mumi, together with an updated commit hash or version for mumi. A live preview of this change is available at: https://patchwise.org/38809 --- mumi/web/view/html.scm | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/mumi/web/view/html.scm b/mumi/web/view/html.scm index 2275799..bd5caec 100644 --- a/mumi/web/view/html.scm +++ b/mumi/web/view/html.scm @@ -19,6 +19,7 @@ ;;; . (define-module (mumi web view html) + #:use-module (avatar url) #:use-module (email email) #:use-module (mumi config) #:use-module (mumi debbugs) @@ -451,12 +452,12 @@ failed to process associated messages.") ,(map (match-lambda ((message-number message) `(li - (div - (@ (class "avatar") - (style ,(string-append "background-color:" - (avatar-color (sender-email message) - (map extract-email parties))))) - ,(string-upcase (string-take (sender-name message) 1))) + (img (@ (class "avatar") + (style ,(string-append "background-color:" + (avatar-color (sender-email message) + (map extract-email parties)))) + (src ,(libravatar-url (sender-email message) #:default "404")) + (alt ,(string-upcase (string-take (sender-name message) 1))))) (span (@ (class "date")) (a (@ (href ,(string-append "#" (number->string message-number)))) @@ -621,12 +622,12 @@ currently disabled.")) (id ,(number->string message-number)))) (a (@ (class "message-anchor") (id ,(format #false "msgid-~a" (msgid-hash (message-id message)))))) - (div - (@ (class "avatar") - (style ,(string-append "background-color:" - (avatar-color (sender-email message) - (map extract-email parties))))) - ,(string-upcase (string-take (sender-name message) 1))) + (img (@ (class "avatar") + (style ,(string-append "background-color:" + (avatar-color (sender-email message) + (map extract-email parties)))) + (src ,(libravatar-url (sender-email message) #:default "404")) + (alt ,(string-upcase (string-take (sender-name message) 1))))) (article (@ (class "message")) (header base-commit: 394c90d4a176756b9f0f4a716a2646ab98d8f167 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Fri May 10 23:23:44 2024 Received: (at control) by debbugs.gnu.org; 11 May 2024 03:23:44 +0000 Received: from localhost ([127.0.0.1]:45744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s5dKp-0006HJ-WB for submit@debbugs.gnu.org; Fri, 10 May 2024 23:23:44 -0400 Received: from sail-ipv4.us-core.com ([208.82.101.137]:43672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s5dKo-0006HD-71 for control@debbugs.gnu.org; Fri, 10 May 2024 23:23:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=1ah53i/fNwRoxD4 Ij/Jqu95xDSnEwcTvZtINLVblHqs=; h=date:cc:to:from; d=lease-up.com; b=Pp UWidB7J2t12XSnV3TOoboItTpNkL0ogGnUsriKlvVavI5wZIB9lEgsMXkrU2NHq5dscRn8 wVHv+3fMUkL9Ew9c1ynYGWD9pF7Sdb6ZgcRQkeiHIdwImnD43wmI2vRFJg7xh4GRiGEUfO XDn6ilm2ZipPbfJ2noIIys0qs4w+k= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 9e603ca4 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO) for ; Sat, 11 May 2024 03:23:42 +0000 (UTC) From: Felix Lechner To: control@debbugs.gnu.org Date: Fri, 10 May 2024 20:23:41 -0700 Message-ID: <875xvlxc8y.fsf@lease-up.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: reassign 70871 mumi thanks Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) reassign 70871 mumi thanks From debbugs-submit-bounces@debbugs.gnu.org Sat May 11 12:53:40 2024 Received: (at 70871) by debbugs.gnu.org; 11 May 2024 16:53:40 +0000 Received: from localhost ([127.0.0.1]:49257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s5pyd-0000nJ-KQ for submit@debbugs.gnu.org; Sat, 11 May 2024 12:53:40 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:43662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s5pya-0000n1-1J for 70871@debbugs.gnu.org; Sat, 11 May 2024 12:53:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=JNztq7KXEiH9LX+fzRKblPDFYEdvBQ2N7bWz1cZgHAM=; b=QzAY2NQgQolMUrqH44QNuDQxt5 2Lua3zU5+jv8oA1ClXGcO2FZeC6y6HO/Z+gpM71Xiw7uq/verp3GKk7EMepO3Oy8yrU5eQPvoKOTZ D0fYfFmlmp5kS4lLnVcnUcZlUmKYFdwPVVqbjs7NMUsWy79GhSyh8LtiGDugfWyiOH3Qqq2nbWmWI pv3elJ4zr/pQ4/6n92hzqK9uER++ruO39TJjZupOFQAcCK+9NaUD0+sIM07wSAtMFJWfF3H3evYsp YkBq3gvFvYTQ8QYJpeODhXoElzx44B2RwwcimNLqfM4DSxRf1eR17Pgmw06D60FhHBttthQArNXH6 I/wYXcwg==; Received: from [192.168.2.1] (port=33640 helo=localhost) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.1) (envelope-from ) id 1s5pvs-0000qX-1e; Sat, 11 May 2024 17:50:49 +0100 From: Arun Isaac To: Felix Lechner Subject: Re: bug#70871: [PATCH] Show avatars from Libravatar. In-Reply-To: <20240511032008.16270-1-felix.lechner@lease-up.com> References: <20240511032008.16270-1-felix.lechner@lease-up.com> Date: Sat, 11 May 2024 17:53:25 +0100 Message-ID: <87plts5lyy.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70871 Cc: 70871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Felix, Libravatar for mumi is a cool idea. I am happy to merge this patch with the suggested changes. There seems to be one more place (a total of three places) in mumi/web/view/html.scm where there is an avatar. Search for "string-upcase" in the code. Could you change that to Libravatar as well? And, while you are at it, would you mind deduplicating these three avatars into a single function or similar? Also, we now need to check for guile-avatar in configure.ac. BTW, what is patchwise.org? Did I miss some conversation about it? I was under the impression that we should be sending to bug-mumi@gnu.org. Thank you for the clarification! Regards, Arun From debbugs-submit-bounces@debbugs.gnu.org Sun May 12 19:52:08 2024 Received: (at 70871) by debbugs.gnu.org; 12 May 2024 23:52:08 +0000 Received: from localhost ([127.0.0.1]:57147 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6IzA-0003Js-Eq for submit@debbugs.gnu.org; Sun, 12 May 2024 19:52:08 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:59994) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6Iz5-0003JT-S3 for 70871@debbugs.gnu.org; Sun, 12 May 2024 19:52:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=+yqI8QOO7fwhdKhOag2P7EfnmONKEOeiZYnGvzEHTkE=; b=kQ3J2dEdvMf8S9569ZVxiJePjW dkav6/WkzAE6pHQTLtUcyB1+oEABMWi0BTFXrPAW7XuOUCkXLWr3T+Ig5CgFqdDl908v9rgIryi0a DrK2CUzuBD7wyq3cgJpUI3qGEAwYBcXxcIQ+pNNQ0Xxc6BvkwUqSFo/0PTh+K2C/by95n/TClyTJM vS+ZWtQvoHyhLJH7YhKBnYpxi2GsMP3SJCpfNyS9OQEWr4esZRDGcf9IRhse2CHiURWEO0a1qjCmg UHyYo7/B6hczByD0CnZX9J1d2rgMehlQcPzcPbrN33ml6LS3orbmVZhWKrTNgQQrqT0FZglzH3vRt XSe1Z75A==; Received: from [192.168.2.1] (port=33968 helo=localhost) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.1) (envelope-from ) id 1s6IwK-0002IG-1G; Mon, 13 May 2024 00:49:13 +0100 From: Arun Isaac To: Felix Lechner Subject: Re: bug#70871: [PATCH] Show avatars from Libravatar. In-Reply-To: <87plts5lyy.fsf@systemreboot.net> References: <20240511032008.16270-1-felix.lechner@lease-up.com> <87plts5lyy.fsf@systemreboot.net> Date: Mon, 13 May 2024 00:51:53 +0100 Message-ID: <87a5ku4mhy.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70871 Cc: 70871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Felix, Could you also make the deduplication and the switch to libravatar two separate patches? Thanks! I also just remembered that the alt attribute of the img tag is meant to be used in place of the image (visually challenged readers using a screen reader, image download failed on a slow connection, etc.). So, we shouldn't use the alt attribute as a fallback for users without avatars. We should do it some other way. Regards, Arun From debbugs-submit-bounces@debbugs.gnu.org Mon May 13 15:30:16 2024 Received: (at 70871) by debbugs.gnu.org; 13 May 2024 19:30:16 +0000 Received: from localhost ([127.0.0.1]:34403 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6bNG-0008J0-AY for submit@debbugs.gnu.org; Mon, 13 May 2024 15:30:16 -0400 Received: from sail-ipv4.us-core.com ([208.82.101.137]:46772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6bN6-0008Hl-TR for 70871@debbugs.gnu.org; Mon, 13 May 2024 15:30:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=sURdS/kvJbJ1MVf NNbi4zH1WN5vIiSOqobFqgzuWKiE=; h=date:references:in-reply-to:subject: cc:to:from; d=lease-up.com; b=oAhDNB9S3UtQlXpVFx45A1qvtI3TAMb8FPHABgtb 2ZS1Il4NuzyUi+NOdv3YCvYZwXEbCeCnTSZiL0zBFsdC7ccPnXnYzyatx3nJ4uXkx4oZi8 nXiG4e3hPXKRsp71dKNx8VMm00t/6OD2cW/nu4rfy2nBLnXSsTbQaEsUSAllg= Received: by localhost (OpenSMTPD) with ESMTPA id b32365ff for <70871@debbugs.gnu.org>; Mon, 13 May 2024 19:30:02 +0000 (UTC) Delivered-To: 70871@patchwise.org DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=sURdS/kvJbJ1MVf NNbi4zH1WN5vIiSOqobFqgzuWKiE=; h=date:references:in-reply-to:subject: cc:to:from; d=lease-up.com; b=oAhDNB9S3UtQlXpVFx45A1qvtI3TAMb8FPHABgtb 2ZS1Il4NuzyUi+NOdv3YCvYZwXEbCeCnTSZiL0zBFsdC7ccPnXnYzyatx3nJ4uXkx4oZi8 nXiG4e3hPXKRsp71dKNx8VMm00t/6OD2cW/nu4rfy2nBLnXSsTbQaEsUSAllg= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id ed2ae530 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Mon, 13 May 2024 19:30:02 +0000 (UTC) From: Felix Lechner To: Arun Isaac Subject: Re: bug#70871: [PATCH] Show avatars from Libravatar. In-Reply-To: <87a5ku4mhy.fsf@systemreboot.net> References: <20240511032008.16270-1-felix.lechner@lease-up.com> <87plts5lyy.fsf@systemreboot.net> <87a5ku4mhy.fsf@systemreboot.net> Date: Mon, 13 May 2024 12:30:02 -0700 Message-ID: <87pltpwlvp.fsf@lease-up.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70871 Cc: 70871@patchwise.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Arun, On Mon, May 13 2024, Arun Isaac wrote: > would you mind deduplicating these three avatars into a single > function or similar? Personally, I do not see the benefit of that abstraction for HTML. For one, the code is a lot easier to parse next to a Web Inspector that shows the same tags. There is also not much to abstract: It's a single 'img' tag. Moreover, the avatars are also in different positions. They do different things on the page. Most significantly, they are subject to different CSS. You'll see why that matters just below. > There seems to be one more place in mumi/web/view/html.scm where there > is an avatar. There is no third avatar. If you haven't yet followed the CSS with a Web Inspector, please look for the 'display: none' for that 'img' tag. It comes from here: https://git.savannah.gnu.org/cgit/guix/mumi.git/tree/assets/mumi.scss#n394 Does the "third" avatar more or less duplicate with the big one in front? Do you plan to use the third avatar? I'd drop it. > I also just remembered that the alt attribute of the img tag is meant to > be used in place of the image (visually challenged readers using a > screen reader, image download failed on a slow connection, etc.). So, we > shouldn't use the alt attribute as a fallback for users without > avatars. Would you please explain that rationale? A blind person who disables the loading of images would still "see" (or perhaps hear) the 'alt' character. How does my code break anything for a blind person, please? > Also, we now need to check for guile-avatar in configure.ac. It is not necessary for my deployment on patchwise.org, which already shows the avatars. For an interpreted language like Guile there is no need to provide prerequisite checks at configure time unless they enable workarounds to build without. The Guile module detections currently found in configure.ac are luxuries. I would remove them. If you prefer to keep them and add guile-avatar for the sake of consistency, please feel free to amend the patch. I do not insist on Git authorship for my contributions. I am sorry, but I am super busy. > what is patchwise.org? Did I miss some conversation about it? That's the domain I hope to use in the near future---and in cooperation with the FSF---to show off my plans for a Debbugs upgrade based on Mumi. FSF declined to upgrade debbugs.gnu.org to the latest Debbugs version (from Debian) because my packaging was based on Guix. FSF wants Trisquel plus Ansible. FSF encouraged me to complete my work elsewhere and demonstrate it when done. It was not my first choice, please believe me. I protested loudly in various places. Either way, Patchwise is licensed under GNU Affero. There are no hidden goals. > I was under the impression that we should be sending to > bug-mumi@gnu.org. I had hoped to open the bug by bouncing the message from patchwise.org to gnu.org. The Patchwise bouncer works in all other cases, such as when amending or controlling bugs (please try it, or look at the headers for this message!) or access to the mailing lists. I'll have to talk to FSF about using the envelope address for submissions, as well. The Patchwise bouncer is essential for the automatic sequencer that will allow folks to submit a patch series in one go. I think your command line tool may do something similar. Also, the patchwise.org effort has not been made public. You are one of the first people to hear about it. I'd be happy to cooperate, if you agree to be less picky about my patches. Kind regards Felix From debbugs-submit-bounces@debbugs.gnu.org Sat May 18 22:50:27 2024 Received: (at 70871) by debbugs.gnu.org; 19 May 2024 02:50:27 +0000 Received: from localhost ([127.0.0.1]:35683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s8Wd0-0006nn-HS for submit@debbugs.gnu.org; Sat, 18 May 2024 22:50:27 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:37428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s8Wcw-0006nb-Py for 70871@debbugs.gnu.org; Sat, 18 May 2024 22:50:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=qoB0qThkKXM5w6ZNZZ0lPeVAC4j4LPtLS8ZNikJ/hvQ=; b=CUk6sHdFrECdmnhsDGgnBmwtkL u7AiGfJ0K0bThmd232EKhEEkxKH8omUQcERPUNjpdKQzvRtU13KZcU+cc/+uV1HO1LaLwpryXrnfX vcjiR4II7ZyaKaCI2zHso0fF38MFSHghvQYokxn+5ykw3pnXIPUJm9XVLcbhK4FOk+GrEzEj28VZ/ LlLdUESUNHThAtz793HCq7/u4soH2nKWr9QNLp0rsKxnJESvjWGX2WO42Q/LG1vCqFCy9XgupOOZE B929NvmD4GJWRxgISQfLWpiMX52Iun7QfWF7+ebws28KEvTAbwN6f2A1v+uMbJxkJkzAXD83UQgxJ 8rs5O5xw==; Received: from [192.168.2.1] (port=58688 helo=localhost) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.1) (envelope-from ) id 1s8WZt-0003DS-2v; Sun, 19 May 2024 03:47:14 +0100 From: Arun Isaac To: Felix Lechner Subject: Re: bug#70871: [PATCH] Show avatars from Libravatar. In-Reply-To: <87pltpwlvp.fsf@lease-up.com> References: <20240511032008.16270-1-felix.lechner@lease-up.com> <87plts5lyy.fsf@systemreboot.net> <87a5ku4mhy.fsf@systemreboot.net> <87pltpwlvp.fsf@lease-up.com> Date: Sun, 19 May 2024 03:50:06 +0100 Message-ID: <87ttiuikgx.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 70871 Cc: 70871@debbugs.gnu.org, 70871@patchwise.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Felix, > There is also not much to abstract: It's a single 'img' tag. Well, it's repeated in three places. So, it's probably worth abstracting out. > There is no third avatar. If you haven't yet followed the CSS with a > Web Inspector, please look for the 'display: none' for that 'img' tag. > It comes from here: I believe the third avatar shows up on smaller screens. Try using the "responsive mode" (Ctrl+Shift+m) in Icecat to simulate a smaller screen. >> I also just remembered that the alt attribute of the img tag is meant to >> be used in place of the image (visually challenged readers using a >> screen reader, image download failed on a slow connection, etc.). So, we >> shouldn't use the alt attribute as a fallback for users without >> avatars. > > Would you please explain that rationale? A blind person who disables > the loading of images would still "see" (or perhaps hear) the 'alt' > character. How does my code break anything for a blind person, > please? See https://accessibility.huit.harvard.edu/describe-content-images An alt text of "A" for "Arun Isaac" would not make sense if read out aloud by a screen reader. It should rather be "Profile picture of Arun Isaac" or similar. Perhaps, it should also be marked up with aria-hidden=true. See https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-hidden I'm not saying the current situation in mumi gets accessibility right. But, while we are changing things, we might as well get things right. > For an interpreted language like Guile there is no need to provide > prerequisite checks at configure time unless they enable workarounds to > build without. The Guile module detections currently found in > configure.ac are luxuries. I would remove them. I agree. But, I'm mainly trying to remain consistent with the existing code base. > If you prefer to keep them and add guile-avatar for the sake of > consistency, please feel free to amend the patch. I am happy to make this change myself. > I am sorry, but I am super busy. Sorry, so am I, and so is everyone else hacking away on Guix and mumi in their spare time. > I'd be happy to cooperate, if you agree to be less picky about my > patches. As a reviewer, it is kinda my job to bring contributions up to shape before they get applied. I am happy to work in good faith towards that goal. And, I don't feel I have been particularly picky in my review. The changes I proposed were pretty reasonable. Regards, Arun From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 02 11:34:18 2024 Received: (at 70871) by debbugs.gnu.org; 2 Nov 2024 15:34:18 +0000 Received: from localhost ([127.0.0.1]:54009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7G8o-00074H-6b for submit@debbugs.gnu.org; Sat, 02 Nov 2024 11:34:18 -0400 Received: from smtp.domeneshop.no ([194.63.252.55]:52049) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7G8k-000742-JS for 70871@debbugs.gnu.org; Sat, 02 Nov 2024 11:34:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xn--no-cja.eu; s=ds202402; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:Subject:Cc:To:From:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=EfcRU1FeLyOeRZb9iCo3qv4cg7Eq2YxvDWczCPQfcMA=; b=ejAByMr/aQISXq5byHUWRDbVWQ FRfHnOkU5VOGBzQhybOn5rTi/RyxQuJAr4f6uTJHepD/hGGq4jxhwSB6CaNlS7DYQ47tK1qPTqmuy PnJVWZsNmgxILXxQ0SngrQ5Sjnckgaa7DfBMoi3PJo5lDKfNucJkOqXAWbYPolf7WakLi50kIUIe+ AzYhc/prwWpegBrFyuaejVIrJRNbjXSxspUV710WOTO4Rbo90ShJS5LSUyUOcEvN4VykMYCyC5IIt Pi3vlYoPhOS8Lkr7QCM93HEQ9tfoA4UXAyg5dlc81B1CjHKV5B15DE8pQiG6S/3qmB/tJ+5BlihbU wLCy5Mvg==; Received: from [2a01:e0a:990:a960:b4f3:8f44:ec4:5af5] (port=49536 helo=localhost.localdomain) by smtp.domeneshop.no with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1t7G8d-008uEQ-E2; Sat, 02 Nov 2024 16:34:07 +0100 From: noe@xn--no-cja.eu To: 70871@debbugs.gnu.org Subject: [PATCH v2 0/2] Show avatars from Libavatar. Date: Sat, 2 Nov 2024 16:34:48 +0100 Message-ID: <20241102153450.958-1-noe@xn--no-cja.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70871 Cc: =?UTF-8?q?No=C3=A9=20Lopez?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: Noé Lopez Hi, Here is an updated version of the patch with the requested changes. I agree with the changes requested because it is that rigor that keeps the code easy to understand and modify. The test data does not have libavatar associated emails, but you can test it by replacing « user » with another email (mine should work): find . -not -path '*/\.git/*' -type f -exec sed -i 's/user@example.com/REPLACEME/g' '{}' \; Good afternoon, Noé Noé Lopez (2): web: Extract user avatars to function. web: Show avatars from Libravatar. configure.ac | 5 +++++ mumi/web/view/html.scm | 36 ++++++++++++++++++------------------ 2 files changed, 23 insertions(+), 18 deletions(-) base-commit: d8ff427dc16f44f4b15684207d3c531301fb0407 -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 02 11:34:19 2024 Received: (at 70871) by debbugs.gnu.org; 2 Nov 2024 15:34:19 +0000 Received: from localhost ([127.0.0.1]:54011 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7G8o-00074J-Iy for submit@debbugs.gnu.org; Sat, 02 Nov 2024 11:34:19 -0400 Received: from smtp.domeneshop.no ([194.63.252.55]:36641) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7G8l-000743-SE for 70871@debbugs.gnu.org; Sat, 02 Nov 2024 11:34:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xn--no-cja.eu; s=ds202402; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=5ddlS/pAdEEHxAcyW+SaDR7GV7f25HUbIIPYbUq2lyM=; b=2 xflX1H8/NyW3kEGgTen08KOiaYeHgw/bWga3dRhY9OpP898aK7HN+dwh83uFR6w6hLj1fcviVkE9P Wm5dnvyBzWcXhB8yi+7iM6u0M/hYGlpyxLI1tEVI0pJdL1eL2dCALEpoTqj9GtQtPQyghd7ZrVFGE Zq7g4NLnIMKmkNEro1E/gZcAXLu3kHVeCnqw/IuTOVnjWu4mhJnZZNDyIjD11goUn/WdrmFqOngUj Cjoak2CJY8EMqnTdxPuNodup5EQId4I4NxJ7Xfo/qtbzwXVIZfXjsDfEvx1bjVwsft0TFUHCj4zoP +4R4bNA7xiX4u+2NgIcGyaFIkutiS7+WQ==; Received: from [2a01:e0a:990:a960:b4f3:8f44:ec4:5af5] (port=49536 helo=localhost.localdomain) by smtp.domeneshop.no with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1t7G8g-008uEQ-6v; Sat, 02 Nov 2024 16:34:10 +0100 From: noe@xn--no-cja.eu To: 70871@debbugs.gnu.org Subject: [PATCH v2 1/2] web: Extract user avatars to function. Date: Sat, 2 Nov 2024 16:34:49 +0100 Message-ID: <20241102153450.958-2-noe@xn--no-cja.eu> In-Reply-To: <20241102153450.958-1-noe@xn--no-cja.eu> References: <20241102153450.958-1-noe@xn--no-cja.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70871 Cc: =?UTF-8?q?No=C3=A9=20Lopez?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: Noé Lopez * mumi/web/view/html.scm (avatar): New function. --- mumi/web/view/html.scm | 31 +++++++++++++------------------ 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/mumi/web/view/html.scm b/mumi/web/view/html.scm index fa19ab4..661f248 100644 --- a/mumi/web/view/html.scm +++ b/mumi/web/view/html.scm @@ -424,6 +424,16 @@ failed to process associated messages.") "Encode PARTS and join them together into an absolute URI path." (string-append "/" (encode-and-join-uri-path parts))) +(define* (avatar sender + #:optional + (participants (list (sender-email sender)))) + `(div (@ (class "avatar") + (style ,(string-append + "background-color:" + (avatar-color (sender-email sender) + participants)))) + ,(string-upcase (string-take (sender-name sender) 1)))) + (define* (issue-page bug #:key flash-message plain?) "Render the conversation for the given BUG." (define id (bug-num bug)) @@ -450,12 +460,7 @@ failed to process associated messages.") ,(map (match-lambda ((message-number message) `(li - (div - (@ (class "avatar") - (style ,(string-append "background-color:" - (avatar-color (sender-email message) - (map extract-email parties))))) - ,(string-upcase (string-take (sender-name message) 1))) + ,(avatar message (map extract-email parties)) (span (@ (class "date")) (a (@ (href ,(string-append "#" (number->string message-number)))) @@ -638,23 +643,13 @@ currently disabled.")) (id ,(number->string message-number)))) (a (@ (class "message-anchor") (id ,(format #false "msgid-~a" (msgid-hash (message-id message)))))) - (div - (@ (class "avatar") - (style ,(string-append "background-color:" - (avatar-color (sender-email message) - (map extract-email parties))))) - ,(string-upcase (string-take (sender-name message) 1))) + ,(avatar message (map extract-email parties)) (article (@ (class "message")) (header (div (@ (class "from")) - (div - (@ (class "avatar") - (style ,(string-append "background-color:" - (avatar-color (sender-email message) - (map extract-email parties))))) - ,(string-upcase (string-take (sender-name message) 1))) + ,(avatar message (map extract-email parties)) (span (@ (class "address")) ,(sender-name message)) " wrote " (span (@ (class "date")) -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 02 11:34:21 2024 Received: (at 70871) by debbugs.gnu.org; 2 Nov 2024 15:34:21 +0000 Received: from localhost ([127.0.0.1]:54014 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7G8r-00074a-2H for submit@debbugs.gnu.org; Sat, 02 Nov 2024 11:34:21 -0400 Received: from smtp.domeneshop.no ([194.63.252.55]:57413) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7G8o-000746-Nx for 70871@debbugs.gnu.org; Sat, 02 Nov 2024 11:34:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xn--no-cja.eu; s=ds202402; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=ZYWTvm1kdCe32wKgT7CoBJzjgTVcYL+9d7JLTjtkLAE=; b=P s7eUgQ+xJeuedvCJnHfwM0XzAxNlvVzTvd0PyBNi0+AIJXZz7e1QSxY+ofaSpNq+j/2jPwqtKV41S PO3zgMYuw4OeEBumKVOyRAqXMNXs/xUr/Kg+aXJa553zLwRaiUY7GuTyy3K3+dcc8c99K2x/1BvAw H+iETn4OpjgNPeDtKH5CLS7iGX1tH7NGkx+RrCBpHNSuZBkt2BNnKLrGEEFZJTWSgal686ZlTgbYr C6zCj3HEUGrYf7UxZ8VV2DXVB8EmPBr0hW8p80ZkqcRR9guMa+0IzuvFAfo3SHeFlJqeGNumVH/Qi /drNEeSUJIm81dsDLVWZ1NRagqkN2Dlaw==; Received: from [2a01:e0a:990:a960:b4f3:8f44:ec4:5af5] (port=49536 helo=localhost.localdomain) by smtp.domeneshop.no with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1t7G8j-008uEQ-2b; Sat, 02 Nov 2024 16:34:13 +0100 From: noe@xn--no-cja.eu To: 70871@debbugs.gnu.org Subject: [PATCH v2 2/2] web: Show avatars from Libravatar. Date: Sat, 2 Nov 2024 16:34:50 +0100 Message-ID: <20241102153450.958-3-noe@xn--no-cja.eu> In-Reply-To: <20241102153450.958-1-noe@xn--no-cja.eu> References: <20241102153450.958-1-noe@xn--no-cja.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70871 Cc: =?UTF-8?q?No=C3=A9=20Lopez?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: Noé Lopez * configure.ac: New dependency. * mumi/web/view/html.scm: Use Libavatar images as avatars. --- configure.ac | 5 +++++ mumi/web/view/html.scm | 11 ++++++++--- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 5981682..ff754b4 100644 --- a/configure.ac +++ b/configure.ac @@ -74,6 +74,11 @@ if test "x$have_kolam" != "xyes"; then AC_MSG_ERROR([Guile kolam is missing; please install it.]) fi +GUILE_MODULE_AVAILABLE([have_avatar], [(avatar url)]) +if test "x$have_avatar" != "xyes"; then + AC_MSG_ERROR([Guile avatar is missing; please install it.]) +fi + guilemoduledir="${datarootdir}/guile/site/${GUILE_EFFECTIVE_VERSION}" AC_SUBST([guilemoduledir]) AC_SUBST([GUILE_EFFECTIVE_VERSION]) diff --git a/mumi/web/view/html.scm b/mumi/web/view/html.scm index 661f248..a037a74 100644 --- a/mumi/web/view/html.scm +++ b/mumi/web/view/html.scm @@ -19,6 +19,7 @@ ;;; . (define-module (mumi web view html) + #:use-module (avatar url) #:use-module (email email) #:use-module (mumi config) #:use-module (mumi debbugs) @@ -427,12 +428,16 @@ failed to process associated messages.") (define* (avatar sender #:optional (participants (list (sender-email sender)))) - `(div (@ (class "avatar") + `(img (@ (class "avatar") (style ,(string-append "background-color:" (avatar-color (sender-email sender) - participants)))) - ,(string-upcase (string-take (sender-name sender) 1)))) + participants))) + (src ,(libravatar-url (sender-email sender) + #:default "404" + #:height 48)) + (alt ,(string-upcase (string-take (sender-name sender) 1))) + (aria-hidden "true")))) (define* (issue-page bug #:key flash-message plain?) "Render the conversation for the given BUG." -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 11 21:31:40 2025 Received: (at 70871-done) by debbugs.gnu.org; 12 Feb 2025 02:31:40 +0000 Received: from localhost ([127.0.0.1]:59820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ti2XM-000410-10 for submit@debbugs.gnu.org; Tue, 11 Feb 2025 21:31:40 -0500 Received: from mugam.systemreboot.net ([139.59.75.54]:47700) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ti2XE-00040e-Bl for 70871-done@debbugs.gnu.org; Tue, 11 Feb 2025 21:31:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=systemreboot.net; s=default; t=1739327482; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WxVoFL63PGwK/4StapGrit4xM+Aprd/yTIAkOVGzxog=; b=gcBrSh1NzOl5vd9mFEaJAe2B7skjjc1GcCZdkAPBcRQqSyaDRiL7llrO0BlgUib0F/U3CC b01OhuKp4tzzvAu+liNB/CgF+ve0JBb3TwGbj7MahhWAWWHc0iTIFjujPQrz/YO2rotRQN SQl2ZGu2AWjzR6vDKX3JitkmQgM4HS5keYjsK9JfTZ2YRCI96qMBXoYtwKDYXR179qrxGS +TK7vMjMBnZ6wQXsYPPNhRSKN0WSWzALzPguJ2zLXTzbVLrwmirmhb/ctr8ksCsvOkyW3/ 8UBYEmdPI0Fi8FLDpNkGcAaE6FxEkfOSn0xS259tMHT7ifZcNtF8M/FSDBKVjA== Received: from localhost ( [192.168.2.1]) by mugam.systemreboot.net (OpenSMTPD) with ESMTPSA id 28712bf4 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 12 Feb 2025 02:31:21 +0000 (UTC) From: Arun Isaac To: noe@xn--no-cja.eu, 70871-done@debbugs.gnu.org Subject: Re: bug#70871: [PATCH v2 0/2] Show avatars from Libavatar. In-Reply-To: <20241102153450.958-1-noe@xn--no-cja.eu> References: <20240511032008.16270-1-felix.lechner@lease-up.com> <20241102153450.958-1-noe@xn--no-cja.eu> Date: Wed, 12 Feb 2025 02:31:12 +0000 Message-ID: <87tt8z3ndb.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70871-done Cc: =?utf-8?Q?No=C3=A9?= Lopez X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi No=C3=A9, Sorry for the long wait! I have pushed the patches with a few modifications. Most significantly, I am defaulting to an identicon instead of a 404. That way, we don't have to use the alt text as a makeshift avatar. And, we get unique identicon avatars even if the first letter of two people's names is the same. With this patchset, we are now dependent on an external service for our avatars. We should probably cache these avatars. But for now, maybe we can just hope that the external service holds up! And, we should ideally implement DNS lookups in guile-avatar to support federation. That's a little project if you're up for it. ;-) Maybe the guile-dns library is useful in this regard. I'll redeploy the mumi instance on issues.guix.gnu.org in a day or so. Thank you for your patience! Arun From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 19 16:08:43 2025 Received: (at 70871) by debbugs.gnu.org; 19 Feb 2025 21:08:43 +0000 Received: from localhost ([127.0.0.1]:53097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tkrJD-0004Oi-DO for submit@debbugs.gnu.org; Wed, 19 Feb 2025 16:08:43 -0500 Received: from mugam.systemreboot.net ([139.59.75.54]:40252) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tkrJ9-0004Nt-La for 70871@debbugs.gnu.org; Wed, 19 Feb 2025 16:08:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=systemreboot.net; s=default; t=1739999312; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to; bh=0MX/pa5c4qmWxi1OwsYTvIw3fyxHcVIpy6jXOX9TrHE=; b=n3yFMGGS9b4uTPgPtfFJZAU09725JqF/+keU3mzJUjFwfK9V9WBH8w/aE8XtsE4xj3pPW7 j/3LetLhdAG0vYhd0v8Cj7x6pKMjMANLsfcekfjIQOLu27UzTRMK5rhStX3Se0spwim8X+ x9lMhgGjb9OIC628hQjy86eHS59ukecFUPeBZrNUZ6yYbCzV1hTAEXUUR4RoRK0NNzOg/K 6kRXd35OKboX5jQloJ0Pr6RZTKk3ZnFaO0k3qCK+xJdVdYNUNWyDkJCXzGsP+9GHvQokXI krRapMqavoMJcbD3xBCmIsSFDUMU7dzcCq1egYXzq14d6dHV4AWnjAYgkOBXaQ== Received: from localhost ( [192.168.2.1]) by mugam.systemreboot.net (OpenSMTPD) with ESMTPSA id bad11a48 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 19 Feb 2025 21:08:31 +0000 (UTC) From: Arun Isaac To: 70871@debbugs.gnu.org Subject: Re: [PATCH] Show avatars from Libravatar. In-Reply-To: <87tt8z3ndb.fsf@systemreboot.net> Date: Wed, 19 Feb 2025 21:08:23 +0000 Message-ID: <87wmdlve0o.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70871 Cc: noe@xn--no-cja.eu, Arun Isaac , Felix Lechner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > I'll redeploy the mumi instance on issues.guix.gnu.org in a day or so. Done, thanks! From unknown Sat Jun 21 03:25:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 20 Mar 2025 11:24:11 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator