GNU bug report logs - #70843
[PATCH] guix-install.sh: Relax check for OpenRC.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#70843: closed ([PATCH] guix-install.sh: Relax check for OpenRC.)
Date: Sun, 02 Jun 2024 09:42:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 02 Jun 2024 11:41:02 +0200
with message-id <87ed9fn0lt.fsf <at> gnu.org>
and subject line Re: [bug#70843] [PATCH] guix-install.sh: Relax check for OpenRC.
has caused the debbugs.gnu.org bug report #70843,
regarding [PATCH] guix-install.sh: Relax check for OpenRC.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
70843: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70843
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Tomas Volf <~@wolfsden.cz>
To: guix-patches <at> gnu.org
Cc: Tomas Volf <~@wolfsden.cz>
Subject: [PATCH] guix-install.sh: Relax check for OpenRC.
Date: Thu,  9 May 2024 12:14:19 +0200

On my virtual private servers running Alpine, the install script failed to
identify the init system.  The virtual server is LXC based, and OpenRC
identifies itself like this:

    # openrc --version
    openrc (OpenRC [LXC]) 0.52.1

The regular expression failed to match it.  After relaxing the check (by
removing the trailing `)' requirement) the installation went fine and I got
functional Guix installation.

* etc/guix-install.sh (chk_init_sys): Drop trailing \) from the regular
expression.

Change-Id: I5f951226341e631fb34cc6c26cfbb87656dab77a
---
 etc/guix-install.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 82accfd5d5..c5a04bb1f4 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -217,7 +217,7 @@ chk_init_sys()
         _msg "${INF}init system is: sysv-init"
         INIT_SYS="sysv-init"
         return 0
-    elif [[ $(openrc --version 2>/dev/null) =~ \(OpenRC\) ]]; then
+    elif [[ $(openrc --version 2>/dev/null) =~ \(OpenRC ]]; then
         _msg "${INF}init system is: OpenRC"
         INIT_SYS="openrc"
         return 0
-- 
2.41.0

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tomas Volf <~@wolfsden.cz>
Cc: 70843-done <at> debbugs.gnu.org
Subject: Re: [bug#70843] [PATCH] guix-install.sh: Relax check for OpenRC.
Date: Sun, 02 Jun 2024 11:41:02 +0200

Tomas Volf <~@wolfsden.cz> skribis:

> On my virtual private servers running Alpine, the install script failed to
> identify the init system.  The virtual server is LXC based, and OpenRC
> identifies itself like this:
>
>     # openrc --version
>     openrc (OpenRC [LXC]) 0.52.1
>
> The regular expression failed to match it.  After relaxing the check (by
> removing the trailing `)' requirement) the installation went fine and I got
> functional Guix installation.
>
> * etc/guix-install.sh (chk_init_sys): Drop trailing \) from the regular
> expression.
>
> Change-Id: I5f951226341e631fb34cc6c26cfbb87656dab77a

Applied, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.