Subject: bug#70843: closed (Re: [bug#70843] [PATCH] guix-install.sh: Relax check for OpenRC.)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 02 Jun 2024 09:42:03 +0000

Your bug report

#70843: [PATCH] guix-install.sh: Relax check for OpenRC.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
70843: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70843
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#70843] [PATCH] guix-install.sh: Relax check for OpenRC.
From: Ludovic Courtès <[email-masked]>
To: Tomas Volf <[email-masked]>
Cc: [email-masked]
Date: Sun, 02 Jun 2024 11:41:02 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Tomas Volf <[email-masked]> skribis:

> On my virtual private servers running Alpine, the install script failed to
> identify the init system.  The virtual server is LXC based, and OpenRC
> identifies itself like this:
>
>     # openrc --version
>     openrc (OpenRC [LXC]) 0.52.1
>
> The regular expression failed to match it.  After relaxing the check (by
> removing the trailing `)' requirement) the installation went fine and I got
> functional Guix installation.
>
> * etc/guix-install.sh (chk_init_sys): Drop trailing \) from the regular
> expression.
>
> Change-Id: I5f951226341e631fb34cc6c26cfbb87656dab77a

Applied, thanks!

Subject: [PATCH] guix-install.sh: Relax check for OpenRC.
From: Tomas Volf <[email-masked]>
To: [email-masked]
Cc: Tomas Volf <[email-masked]>
Date: Thu, 9 May 2024 12:14:19 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

On my virtual private servers running Alpine, the install script failed to
identify the init system.  The virtual server is LXC based, and OpenRC
identifies itself like this:

    # openrc --version
    openrc (OpenRC [LXC]) 0.52.1

The regular expression failed to match it.  After relaxing the check (by
removing the trailing `)' requirement) the installation went fine and I got
functional Guix installation.

* etc/guix-install.sh (chk_init_sys): Drop trailing \) from the regular
expression.

Change-Id: I5f951226341e631fb34cc6c26cfbb87656dab77a
---
 etc/guix-install.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 82accfd5d5..c5a04bb1f4 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -217,7 +217,7 @@ chk_init_sys()
         _msg "${INF}init system is: sysv-init"
         INIT_SYS="sysv-init"
         return 0
-    elif [[ $(openrc --version 2>/dev/null) =~ \(OpenRC\) ]]; then
+    elif [[ $(openrc --version 2>/dev/null) =~ \(OpenRC ]]; then
         _msg "${INF}init system is: OpenRC"
         INIT_SYS="openrc"
         return 0
-- 
2.41.0