From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 21 10:37:59 2010 Received: (at submit) by debbugs.gnu.org; 21 Sep 2010 14:37:59 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oy3yp-00081g-8X for submit@debbugs.gnu.org; Tue, 21 Sep 2010 10:37:59 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oy3ym-00081Z-Kj for submit@debbugs.gnu.org; Tue, 21 Sep 2010 10:37:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oy40v-0006TZ-U4 for submit@debbugs.gnu.org; Tue, 21 Sep 2010 10:40:29 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,T_DKIM_INVALID,T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:36979) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oy40v-0006TU-PG for submit@debbugs.gnu.org; Tue, 21 Sep 2010 10:40:09 -0400 Received: from [140.186.70.92] (port=44693 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oy40j-0002FI-FW for bug-gnu-emacs@gnu.org; Tue, 21 Sep 2010 10:40:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oy40c-0006MZ-B7 for bug-gnu-emacs@gnu.org; Tue, 21 Sep 2010 10:39:57 -0400 Received: from mail-bw0-f41.google.com ([209.85.214.41]:52025) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oy40c-0006M4-6Y for bug-gnu-emacs@gnu.org; Tue, 21 Sep 2010 10:39:50 -0400 Received: by bwz10 with SMTP id 10so7070473bwz.0 for ; Tue, 21 Sep 2010 07:39:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :message-id:mime-version:content-type; bh=l3E/p+g3/+1pXfMj0EyVdbJoc3zfwmMlDy1Wdg3zp2w=; b=oXSdVADPCmchrDwgqi9s4Q3QEqSf1XY0cZesJ6ip/DV7CtMfXv4zWFjErrZULFaMe0 ZAlCVmVBDQQevZu3kK2eWpIQC2/sDbQgmOjB4MTvjvRPiGLfK2kYttmYWwzSWmPGvAEq hCm2Y3C3gvYU+5xOrLLfK9seY1xuD+fhBxOZs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:message-id:mime-version:content-type; b=RHoAk3V7ytkyL04cwXDE5j2qG/J2q7OIwGouBNZz4hwbkG+J2XppDRzdJuwbVYdnq/ GBBamDv7Mtl1nAki0wa7Fsrie4NJlYHce1fJJVWNMDMW0vXDpsYDC1Ii+dn3FCQbrzyW ziuxufM8BPGBD842IBx0fCxyIUzYWIcIrP0OM= Received: by 10.204.126.29 with SMTP id a29mr7934582bks.59.1285079989099; Tue, 21 Sep 2010 07:39:49 -0700 (PDT) Received: from arirop (e82-103-227-224.elisa-laajakaista.fi [82.103.227.224]) by mx.google.com with ESMTPS id s34sm7617142bkk.1.2010.09.21.07.39.37 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 21 Sep 2010 07:39:40 -0700 (PDT) From: Ari Roponen To: bug-gnu-emacs@gnu.org Subject: 24.0.50; Bug in src/doc.c (Fsnarf_documentation) Date: Tue, 21 Sep 2010 17:39:31 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.9 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) Hi, recently compiling Emacs has not worked for me. The compilation always aborts with this error: Loading emacs-lisp/float-sup... Loading vc/vc-hooks... Loading vc/ediff-hook... Loading tooltip... Finding pointers to doc strings... /bin/sh: line 8: 10391 Segmentation fault (core dumped) LC_ALL=C `/bin/pwd`/temacs -batch -l loadup dump make[1]: *** [emacs] Error 1 make[1]: Leaving directory `/usr/local/repos/emacs.git/src' make: *** [src] Error 2 After some debugging, I may have found the cause. I added an assert to Fsnarf_documentation in src/doc.c just before the memcpy and it failed: Assertion `buf + filled < end' failed. This means we should use memmove instead, as it can handle overlapping regions properly. 2010-09-21 Ari Roponen (tiny change) * doc.c (Fsnarf_documentation): Use memmove instead of memcpy as the regions may overlap. diff --git a/src/doc.c b/src/doc.c index f8ab9d0..36f7c0e 100644 --- a/src/doc.c +++ b/src/doc.c @@ -678,7 +678,7 @@ the same file name is found in the `doc-directory'. */) } pos += end - buf; filled -= end - buf; - memcpy (buf, end, filled); + memmove (buf, end, filled); } emacs_close (fd); return Qnil; In GNU Emacs 24.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.90.5) of 2010-09-21 on arirop Windowing system distributor `Fedora Project', version 11.0.10899905 configured using `configure '--with-x-toolkit=gtk3' '--with-imagemagick'' -- Ari Roponen From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 21 15:35:00 2010 Received: (at 7082-done) by debbugs.gnu.org; 21 Sep 2010 19:35:00 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oy8cG-00022f-8O for submit@debbugs.gnu.org; Tue, 21 Sep 2010 15:35:00 -0400 Received: from mail-out.m-online.net ([212.18.0.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oy8cE-00022a-A2 for 7082-done@debbugs.gnu.org; Tue, 21 Sep 2010 15:34:59 -0400 Received: from frontend1.mail.m-online.net (unknown [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id CD5E51C002D2; Tue, 21 Sep 2010 21:37:30 +0200 (CEST) Received: from igel.home (ppp-88-217-120-134.dynamic.mnet-online.de [88.217.120.134]) by mail.mnet-online.de (Postfix) with ESMTP id A48E91C0008E; Tue, 21 Sep 2010 21:37:30 +0200 (CEST) Received: by igel.home (Postfix, from userid 501) id 16737CA298; Tue, 21 Sep 2010 21:37:29 +0200 (CEST) From: Andreas Schwab To: Ari Roponen Subject: Re: bug#7082: 24.0.50; Bug in src/doc.c (Fsnarf_documentation) References: X-Yow: Everywhere I look I see NEGATIVITY and ASPHALT... Date: Tue, 21 Sep 2010 21:37:29 +0200 In-Reply-To: (Ari Roponen's message of "Tue, 21 Sep 2010 17:39:31 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 7082-done Cc: 7082-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Ari Roponen writes: > 2010-09-21 Ari Roponen (tiny change) > > * doc.c (Fsnarf_documentation): Use memmove instead of memcpy as > the regions may overlap. Thanks, installed. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From unknown Fri Aug 15 20:54:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 20 Oct 2010 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator