From unknown Fri Jun 20 19:54:47 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#70797 <70797@debbugs.gnu.org> To: bug#70797 <70797@debbugs.gnu.org> Subject: Status: [PATCH] Make the Compilation mode recognize non-legacy Kotlin/Gradle errors Reply-To: bug#70797 <70797@debbugs.gnu.org> Date: Sat, 21 Jun 2025 02:54:47 +0000 retitle 70797 [PATCH] Make the Compilation mode recognize non-legacy Kotlin= /Gradle errors reassign 70797 emacs submitter 70797 Rudolf Adamkovi=C4=8D severity 70797 normal tag 70797 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon May 06 03:10:39 2024 Received: (at submit) by debbugs.gnu.org; 6 May 2024 07:10:39 +0000 Received: from localhost ([127.0.0.1]:36178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s3sUd-0005Vc-Tm for submit@debbugs.gnu.org; Mon, 06 May 2024 03:10:39 -0400 Received: from lists.gnu.org ([2001:470:142::17]:51398) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s3k84-0008An-3H for submit@debbugs.gnu.org; Sun, 05 May 2024 18:14:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s3k7Z-0007zm-Mb for bug-gnu-emacs@gnu.org; Sun, 05 May 2024 18:14:14 -0400 Received: from wfout4-smtp.messagingengine.com ([64.147.123.147]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s3k7X-0008Ds-EV for bug-gnu-emacs@gnu.org; Sun, 05 May 2024 18:14:13 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfout.west.internal (Postfix) with ESMTP id 538401C0010D for ; Sun, 5 May 2024 18:14:08 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 05 May 2024 18:14:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamkovic.org; h=cc:content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:subject:subject:to:to; s=fm1; t=1714947247; x=1715033647; bh=OOvKICg5qQryx1KnkMdtfMmadQCnwnDD pLRxhzf2X38=; b=d6yrlSJkD6olwL7PsZsAIbaJGOGcttcUAntH87qNxxuvineT 8KKoFHB3Av40br5nYiMyROYInJ3XJ/Uz+uazePSyfG9LixJHA/zpEQVn8kF32lfm JEF8f9/xKvvoEMKcUob8ytvCHk4WoybTm3mrtCU2y32SHzIhiKZNs52vAjTS8uIM +SC3tN7BM7mBc2wvrCJOeLANACJXmp5foSDYedHKV0djD16zFsJjsGaydJVwvPdr EwWavEGqBdY+aZsg0/bW8MnnGPa9uMqDGFhGGMWXGUjyyOcAGnqCfuXfqtDzzZER YqMYhcubuAmu6gZqpRpnbwTrcalKVgUpBX5JCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1714947247; x=1715033647; bh=OOvKICg5qQryx1KnkMdtfMmadQCnwnDDpLR xhzf2X38=; b=PzyC7krUI2Kr2VdEZTHwiFmjkeYdEaqmMw9oVfKFK/2Oo8VoU+M PiQ5x39A+7UvktsUHY2Rf+Zz+HlXr/pwvKtRpY/ENQSF12A4eqUOlOok+ixXOTTA sfqaJu/x0oCmDclTYqS1/x/EA1XrplR/XDh+zM62tMy3bZ9G3oqSrDd/YD6sZ2y2 dQMrENvVoNUafRCqBbojHiaXOY6obUwOLykOJ33+ar/2rRhkojC/Fq7yQWhzZImL eqRSqCEge+eMsVO4jRzdONoGFgwih40EyXg52eE3qX935dnMBTqdGkdqF4DbWUGa gGAS8u9SaxJ7z2c/pcA1OOReHj45wKIsHnA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvddvhedgtdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkgggtsehmtderredttd ejnecuhfhrohhmpeftuhguohhlfhcutegurghmkhhovhhitgcuoehruhguohhlfhesrggu rghmkhhovhhitgdrohhrgheqnecuggftrfgrthhtvghrnhepffekfeeuudeftdekveejje evteffudetjeetgedtffduuedvjeekvdejueeiveffnecuvehluhhsthgvrhfuihiivgep tdenucfrrghrrghmpehmrghilhhfrhhomheprhhuugholhhfsegruggrmhhkohhvihgtrd horhhg X-ME-Proxy: Feedback-ID: i88214938:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Sun, 5 May 2024 18:14:07 -0400 (EDT) From: =?utf-8?Q?Rudolf_Adamkovi=C4=8D?= To: bug-gnu-emacs@gnu.org Subject: [PATCH] Make the Compilation mode recognize non-legacy Kotlin/Gradle errors Date: Mon, 06 May 2024 00:14:04 +0200 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=64.147.123.147; envelope-from=rudolf@adamkovic.org; helo=wfout4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 06 May 2024 03:10:34 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) --=-=-= Content-Type: text/plain Tags: patch --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Make-the-Compilation-mode-recognize-non-legacy-Kotli.patch >From 8ff95a02a321d730e2c3171b18ddb55f3a554d20 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rudolf=20Adamkovi=C4=8D?= Date: Thu, 2 May 2024 19:06:11 +0200 Subject: [PATCH] Make the Compilation mode recognize non-legacy Kotlin/Gradle errors The Compilation mode recognizes Kotlin/Gradle errors but only in the old format. The new format, which has been in wide use for about a year, is not supported. This patch adds support for the new format. * etc/compilation.txt: (symbols): Add a non-legacy Kotlin/Gradle warning and error. * lisp/progmodes/compile.el: (compilation-error-regexp-alist-alist): Rename 'gradle-kotlin' to 'gradle-kotlin-legacy' and add 'grade-kotlin' that matches errors and warnings outputted by non-legacy Kotlin/Gradle. --- etc/compilation.txt | 13 +++++++++++-- lisp/progmodes/compile.el | 20 +++++++++++++++++--- 2 files changed, 28 insertions(+), 5 deletions(-) diff --git a/etc/compilation.txt b/etc/compilation.txt index 05f0829864c..e4e361ecfc7 100644 --- a/etc/compilation.txt +++ b/etc/compilation.txt @@ -186,13 +186,22 @@ Warning near line 10 file arrayclash.f: Module contains no executable Nonportable usage near line 31 col 9 file assign.f: mixed default and explicit -* Gradle with kotlin-gradle-plugin +* Gradle with Kotlin plugin -symbol: gradle-kotlin +symbol: grade-kotlin + +e: file:///src/Test.kt:267:5 foo: bar +w: file:///src/Test.kt:267:5 foo: bar + + +* Gradle with Kotlin plugin (legacy) + +symbol: gradle-kotlin-legacy e: /src/Test.kt: (34, 15): foo: bar w: /src/Test.kt: (34, 15): foo: bar + * Gradle Android resource linking symbol: gradle-android diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index b18eb81fee1..76a89bea4fc 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -258,10 +258,24 @@ compilation-error-regexp-alist-alist "\\(^Warning .*\\)? line[ \n]\\([0-9]+\\)[ \n]\\(?:col \\([0-9]+\\)[ \n]\\)?file \\([^ :;\n]+\\)" 4 2 3 (1)) - ;; Gradle with kotlin-gradle-plugin (see - ;; GradleStyleMessagerRenderer.kt in kotlin sources, see - ;; https://youtrack.jetbrains.com/issue/KT-34683). (gradle-kotlin + ,(rx bol + (| (group "w") ; 1: warning + (group (in "iv")) ; 2: info + "e") ; error + ": " + "file://" + (group ; 3: file + (? (in "A-Za-z") ":") + (+ (not (in "\n:")))) + ":" + (group (+ digit)) ; 4: line + ":" + (group (+ digit)) ; 5: column + " ") + 3 4 5 (1 . 2)) + + (gradle-kotlin-legacy ,(rx bol (| (group "w") ; 1: warning (group (in "iv")) ; 2: info -- 2.39.3 (Apple Git-146) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable --=20 "All you have to do is write one true sentence. Write the truest sentence that you know." --- Ernest Miller Hemingway (1899-1961) Rudolf Adamkovi=C4=8D [he/him] Studenohorsk=C3=A1 25, 84103 Bratislava, Slovakia, European Union --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat May 11 04:56:13 2024 Received: (at 70797) by debbugs.gnu.org; 11 May 2024 08:56:13 +0000 Received: from localhost ([127.0.0.1]:47132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s5iWa-0006ss-TY for submit@debbugs.gnu.org; Sat, 11 May 2024 04:56:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33286) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s5iWZ-0006sm-27 for 70797@debbugs.gnu.org; Sat, 11 May 2024 04:56:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s5iWU-0001y1-Ed; Sat, 11 May 2024 04:56:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=mshnIxk7Ri9KA9pfR5mZ0hzqAJwNhDrFY1ePI3eYE6M=; b=ZRye67SKM8xwrbLaS6Xu InXvU3PWzJYAs+rkRyaJlFHSFM82rG87mc1vE6Hd1tO9uo/kOlTsCDU/Vxxi9jnQxYAK78xV6K6u3 WfEGy0iqjuLW6fM1KOtje1986Ho98W6Z4R4Gu5s/ZVQPzi+lDln2YvBRcnMgMRx8u3HF2ZLt3t/zY 2ZMJj2rlnur8Y5cSQ010sKuFyQj0XAZLUOWfHvNsO6TtJ/OrWfBjOFlb8moQnt9aOgV9lVduVTSjn dw1AjrK6ugyCt45Fui4aoHh0PCIfutb5VRSwWxcTNBA2OLgazhRma36NS/bq6oB3S0mq25MBqkQjN OSpW/Cqugr7AKQ==; Date: Sat, 11 May 2024 11:56:02 +0300 Message-Id: <86jzk03exp.fsf@gnu.org> From: Eli Zaretskii To: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= In-Reply-To: (message from Rudolf =?utf-8?Q?Adamkovi=C4=8D?= on Mon, 06 May 2024 00:14:04 +0200) Subject: Re: bug#70797: [PATCH] Make the Compilation mode recognize non-legacy Kotlin/Gradle errors References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70797 Cc: 70797@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Rudolf Adamkovič > Date: Mon, 06 May 2024 00:14:04 +0200 > > >From 8ff95a02a321d730e2c3171b18ddb55f3a554d20 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Rudolf=20Adamkovi=C4=8D?= > Date: Thu, 2 May 2024 19:06:11 +0200 > Subject: [PATCH] Make the Compilation mode recognize non-legacy Kotlin/Gradle > errors > > The Compilation mode recognizes Kotlin/Gradle errors but only in the old > format. The new format, which has been in wide use for about a year, is > not supported. This patch adds support for the new format. > > * etc/compilation.txt: > (symbols): Add a non-legacy Kotlin/Gradle warning and error. > * lisp/progmodes/compile.el: > (compilation-error-regexp-alist-alist): Rename 'gradle-kotlin' to > 'gradle-kotlin-legacy' and add 'grade-kotlin' that matches errors and > warnings outputted by non-legacy Kotlin/Gradle. > --- > etc/compilation.txt | 13 +++++++++++-- > lisp/progmodes/compile.el | 20 +++++++++++++++++--- > 2 files changed, 28 insertions(+), 5 deletions(-) Thanks, but: . applying this fails compile-tests in the test suite, so I guess some adjustment there is also needed; . you removed the comment with the pointer to kotlin sources, which might be still useful for the legacy format (unless the URL is no longer valid), so please restore that if the pointer can still be useful Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat May 25 03:47:12 2024 Received: (at 70797) by debbugs.gnu.org; 25 May 2024 07:47:12 +0000 Received: from localhost ([127.0.0.1]:41858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAm7T-0006vd-TX for submit@debbugs.gnu.org; Sat, 25 May 2024 03:47:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53128) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAm7S-0006vW-5d for 70797@debbugs.gnu.org; Sat, 25 May 2024 03:47:11 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sAm7F-0007az-Eo; Sat, 25 May 2024 03:46:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=VhJp4i8JYPhl74k2GaUYhlY6ICrQ9u87fJlFcXBwkpU=; b=C4DFtz+1788CGsSVn4sa QoSzHuJ6bP3UeHuwMnNipiBNsPqG8CQOuIK9gUm6wHgo5/iIYT8QIfC+k0TUHUq76QIsiY8Jv8Jk/ 1FOGA8PvpMj8GyC9NQUfMvp3lsKZFZjjNw6XL88hk0UITOkH1z0SgD1ZdGuF39YPNLejqtIEyMN3A QU8fCzUtNI0LttdWo1F6qMXnyKyZ1aS1zBzpYOUBQWx0dBZygvD9GE6VipLe0SbF5rgLgG3yQM4U8 rMA3Y9WMkd3p2PGB9zr8wMgvKnMdKPzD9LwcfDrpclu4gfokhvwx/iDJSH4Xfq3JdzzyToAtRcMj0 ZMhtSKiXnglEZw==; Date: Sat, 25 May 2024 10:46:53 +0300 Message-Id: <864jam1ggi.fsf@gnu.org> From: Eli Zaretskii To: rudolf@adamkovic.org In-Reply-To: <86jzk03exp.fsf@gnu.org> (message from Eli Zaretskii on Sat, 11 May 2024 11:56:02 +0300) Subject: Re: bug#70797: [PATCH] Make the Compilation mode recognize non-legacy Kotlin/Gradle errors References: <86jzk03exp.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70797 Cc: 70797@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ping! Can we please make progress with resolving this issue? > Cc: 70797@debbugs.gnu.org > Date: Sat, 11 May 2024 11:56:02 +0300 > From: Eli Zaretskii > > > From: Rudolf Adamkovič > > Date: Mon, 06 May 2024 00:14:04 +0200 > > > > >From 8ff95a02a321d730e2c3171b18ddb55f3a554d20 Mon Sep 17 00:00:00 2001 > > From: =?UTF-8?q?Rudolf=20Adamkovi=C4=8D?= > > Date: Thu, 2 May 2024 19:06:11 +0200 > > Subject: [PATCH] Make the Compilation mode recognize non-legacy Kotlin/Gradle > > errors > > > > The Compilation mode recognizes Kotlin/Gradle errors but only in the old > > format. The new format, which has been in wide use for about a year, is > > not supported. This patch adds support for the new format. > > > > * etc/compilation.txt: > > (symbols): Add a non-legacy Kotlin/Gradle warning and error. > > * lisp/progmodes/compile.el: > > (compilation-error-regexp-alist-alist): Rename 'gradle-kotlin' to > > 'gradle-kotlin-legacy' and add 'grade-kotlin' that matches errors and > > warnings outputted by non-legacy Kotlin/Gradle. > > --- > > etc/compilation.txt | 13 +++++++++++-- > > lisp/progmodes/compile.el | 20 +++++++++++++++++--- > > 2 files changed, 28 insertions(+), 5 deletions(-) > > Thanks, but: > > . applying this fails compile-tests in the test suite, so I guess > some adjustment there is also needed; > . you removed the comment with the pointer to kotlin sources, which > might be still useful for the legacy format (unless the URL is no > longer valid), so please restore that if the pointer can still be > useful > > Thanks. > > > > From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 08 07:45:01 2024 Received: (at 70797) by debbugs.gnu.org; 8 Jun 2024 11:45:01 +0000 Received: from localhost ([127.0.0.1]:37621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFuVI-0007iB-Mm for submit@debbugs.gnu.org; Sat, 08 Jun 2024 07:45:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42520) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFuVG-0007hl-AO for 70797@debbugs.gnu.org; Sat, 08 Jun 2024 07:44:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sFuUt-0006XX-14; Sat, 08 Jun 2024 07:44:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=7JKMyCm9v+bARrhK/3pv+sDMhLbCU73NaZSTzb0OrgQ=; b=W8KPWvunwQ/D2ffYExlX JY+VTlO+XgYnWPzXzN9UWHWv8rpWYev7AFegxyfVlZazESpvglXUlIjPAWH4CCpL9Nf+6PoPM7OUA Rt+Ep8Ucr2sKBAOnHxPo3JPJkseXGupfd8eukEbrmLxJyceh8rd4z0EY0zv0Rcb00CILBLad7AvlF hcRv2VYEqQmRi9cKK1fOwiu7AkpPkZ4dHFkDdZNaFlaayvZGTq7K8q0QL7Z8S/czzLOZLCIaGDUbc HX0PRQF9wpWQ6yJ7aGGXZKyUix8R0NXtZANZn766a/CHsx/dRahKN7qQTLO0dPN1m6spD+VgqimRL CMOJIkJwpEAaRQ==; Date: Sat, 08 Jun 2024 14:44:31 +0300 Message-Id: <86y17fd5gg.fsf@gnu.org> From: Eli Zaretskii To: rudolf@adamkovic.org In-Reply-To: <864jam1ggi.fsf@gnu.org> (message from Eli Zaretskii on Sat, 25 May 2024 10:46:53 +0300) Subject: Re: bug#70797: [PATCH] Make the Compilation mode recognize non-legacy Kotlin/Gradle errors References: <86jzk03exp.fsf@gnu.org> <864jam1ggi.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70797 Cc: 70797@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ping! Ping! Can we please resolve this issue? > Cc: 70797@debbugs.gnu.org > Date: Sat, 25 May 2024 10:46:53 +0300 > From: Eli Zaretskii > > Ping! Can we please make progress with resolving this issue? > > > Cc: 70797@debbugs.gnu.org > > Date: Sat, 11 May 2024 11:56:02 +0300 > > From: Eli Zaretskii > > > > > From: Rudolf Adamkovič > > > Date: Mon, 06 May 2024 00:14:04 +0200 > > > > > > >From 8ff95a02a321d730e2c3171b18ddb55f3a554d20 Mon Sep 17 00:00:00 2001 > > > From: =?UTF-8?q?Rudolf=20Adamkovi=C4=8D?= > > > Date: Thu, 2 May 2024 19:06:11 +0200 > > > Subject: [PATCH] Make the Compilation mode recognize non-legacy Kotlin/Gradle > > > errors > > > > > > The Compilation mode recognizes Kotlin/Gradle errors but only in the old > > > format. The new format, which has been in wide use for about a year, is > > > not supported. This patch adds support for the new format. > > > > > > * etc/compilation.txt: > > > (symbols): Add a non-legacy Kotlin/Gradle warning and error. > > > * lisp/progmodes/compile.el: > > > (compilation-error-regexp-alist-alist): Rename 'gradle-kotlin' to > > > 'gradle-kotlin-legacy' and add 'grade-kotlin' that matches errors and > > > warnings outputted by non-legacy Kotlin/Gradle. > > > --- > > > etc/compilation.txt | 13 +++++++++++-- > > > lisp/progmodes/compile.el | 20 +++++++++++++++++--- > > > 2 files changed, 28 insertions(+), 5 deletions(-) > > > > Thanks, but: > > > > . applying this fails compile-tests in the test suite, so I guess > > some adjustment there is also needed; > > . you removed the comment with the pointer to kotlin sources, which > > might be still useful for the legacy format (unless the URL is no > > longer valid), so please restore that if the pointer can still be > > useful > > > > Thanks. > > > > > > > > > > > > From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 09 18:25:29 2024 Received: (at 70797) by debbugs.gnu.org; 9 Jun 2024 22:25:29 +0000 Received: from localhost ([127.0.0.1]:36178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGQye-0002Ep-SZ for submit@debbugs.gnu.org; Sun, 09 Jun 2024 18:25:29 -0400 Received: from fhigh7-smtp.messagingengine.com ([103.168.172.158]:42589) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGQps-0001pH-3F for 70797@debbugs.gnu.org; Sun, 09 Jun 2024 18:16:25 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfhigh.nyi.internal (Postfix) with ESMTP id EBBE41140151; Sun, 9 Jun 2024 17:40:43 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 09 Jun 2024 17:40:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamkovic.org; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm2; t=1717969243; x=1718055643; bh=IVdxED1MlY6Y+g5ffmJiHGdA5oEPygYf Ilcl3Sfyf30=; b=C6O1uQpUlORKiacmJKqSdZMbhDXbCC4vUmVXgPv5vJjQ6nkC Qljq5UtEKikHhuO0J924YkCekaGBtvrW5s8g0k6rM3g90MEiVty/E3LrmoOabD/u DG7rwE5qA0qImVIh71cMwYBwmVpDH50od7hFT+xZ/wjSo6Zin7BuA/IT5ROx3VCd FxwRh1fvKPVGhAyU4htgMkxP18JhGQvPh/xk6EZDRpfwDvedMwZZWV8QJW/G3mZw xRZdLorR0S2+QzG+lMXxVAtWx1s+DKHNnvkoEsKpjjz1FCmLXwOClpeTwnKmDMkj MdR73O4sEJC/ACs1oY2LgZB8NPBJqtbsRTOpCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1717969243; x= 1718055643; bh=IVdxED1MlY6Y+g5ffmJiHGdA5oEPygYfIlcl3Sfyf30=; b=W 5vWwTNtp7uaHHN8PQ40vWk81PEmHywlZ5PYuO2/asxprFk58RUltrNI+3zEQeGX/ IY+SOa5ELMK7bM0mLRVkLorryrbC6iLmtGkl0mSLUtTtZKmnVdJIDJexTOr4rM3/ ryp/COXROG30UCpkDyOMIsIZRlmplbRW0ASFPfe2DMKNTMbxrarcfcnf5hLquap2 tqp3RsmikXPwuaj/dCHWJZItBAIEzOu+H/WlQgCPa3jz5LdWlCjZ6gTz2LkQ+apP lrhy4nHqgkRLVpOmTX/NA9fV3SIXUNKdz9Ar8GroLjuk7nVoAPcn6SA4otRp1Rlk MYsgqD4/PVirMEmtEUlHQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfedtkedgtdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkgggtgfesthhqredttddtjeenucfhrhhomheptfhuugho lhhfucetuggrmhhkohhvihgtuceorhhuugholhhfsegruggrmhhkohhvihgtrdhorhhgqe enucggtffrrghtthgvrhhnpeeiueetheffudfghfeggeevheevvddtkefflefhueeludfg tefgffeltdfhudejgeenucffohhmrghinheprggurghmkhhovhhitgdrohhrghenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehruhguohhlfhes rggurghmkhhovhhitgdrohhrgh X-ME-Proxy: Feedback-ID: i88214938:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 9 Jun 2024 17:40:42 -0400 (EDT) From: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= To: Eli Zaretskii Subject: Re: bug#70797: [PATCH] Make the Compilation mode recognize non-legacy Kotlin/Gradle errors In-Reply-To: <86y17fd5gg.fsf@gnu.org> References: <86jzk03exp.fsf@gnu.org> <864jam1ggi.fsf@gnu.org> <86y17fd5gg.fsf@gnu.org> Date: Sun, 09 Jun 2024 23:40:41 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70797 Cc: 70797@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: > Ping! Ping! Can we please resolve this issue? My apologies, I got swamped with life. I plan to get back to working on FLOSS soon. Rudy --=20 "I love deadlines. I love the whooshing noise they make as they go by." --- Douglas Adams, The Salmon of Doubt, 2002 Rudolf Adamkovi=C4=8D [he/him] http://adamkovic.org From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 13 10:44:17 2024 Received: (at 70797) by debbugs.gnu.org; 13 Jun 2024 14:44:17 +0000 Received: from localhost ([127.0.0.1]:57906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHlgW-0003xy-Q8 for submit@debbugs.gnu.org; Thu, 13 Jun 2024 10:44:17 -0400 Received: from fout7-smtp.messagingengine.com ([103.168.172.150]:48381) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHlgU-0003xX-A0 for 70797@debbugs.gnu.org; Thu, 13 Jun 2024 10:44:15 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfout.nyi.internal (Postfix) with ESMTP id 56B8213800DC; Thu, 13 Jun 2024 10:44:09 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 13 Jun 2024 10:44:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamkovic.org; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1718289849; x= 1718376249; bh=Ewi8FPnCde+Osn54B18aQunHgHrnMw/3IptZZJnLa5g=; b=N SJ7ce+E1lfJ+4GAqxYoQ2PvMltRlxsQMAb4L7780UZsVIJjAHv5t7i5vZMuIlENO jO4ehHYK+RnwxulLRRUps5Y2m42T3MmvG4atioDPq+8L/V8SNiCvjRNWMhiMUlhQ 3nbiMPGpALyzrU+OBO9RgPTiTZErxYRb+tC8Qz2NE+yEiKv9vD5HwH76KACn6AZG ij4mlWnQPszJwDYrvL2SBxh1CwjvebVEvMZ4sWjPgs9aXLSsL7PMDwWSEAZWpff0 41qyGi0hBNLHQ8KKEbNwdN3J8IwXzj0PXSJW1GXeQU0qcnWz57GpmfogWNsrRrut jn+sGewSb+wc/7KWKyMEg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1718289849; x=1718376249; bh=Ewi8FPnCde+Osn54B18aQunHgHrn Mw/3IptZZJnLa5g=; b=Wtb0RVRBqkMYXICybyWO3aP+/CVjUUsbVYmFiTzLRi6b +XGDe2f0mB6YIKKnPYLyHgTv+bNaM1/pe9GhWL2UwH+0JCmHGk6uWnk7u8lDncUW bImddMk9rzTEbxPuTUj5bf+dpiOiZ24fcawixKGGUEX9pU2qnVuvPwszs7tnDafx ONp6oHEKtxdcAwISxXWp/CD68CDV6+kZXMFn+f+uA8CrdqkZk26jR7Mw/jjuFqop xDbxhLqJe2xgFd5sbfKbclKzMYHS5WK3SNLq6tCWl4yKBzzA8UJJzsvjT9dMHuid LWmNhZZ07Mm8fd+FqKinBFZLFeikMJjRNDE6dZEnqQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfedujedgjeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkgggtsehmtderredttddtnecuhfhrohhmpeftuhguohhl fhculdftuhguhidmucetuggrmhhkohhvihgtuceorhhuugholhhfsegruggrmhhkohhvih gtrdhorhhgqeenucggtffrrghtthgvrhhnpedtheefhefghfffkeeivdehgfehvdektdfh tddtgeeljeejtefhgeevfeeggeekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpehruhguohhlfhesrggurghmkhhovhhitgdrohhrgh X-ME-Proxy: Feedback-ID: i88214938:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 13 Jun 2024 10:44:07 -0400 (EDT) From: Rudolf (Rudy) Adamkovic To: Eli Zaretskii Subject: Re: bug#70797: [PATCH] Make the Compilation mode recognize non-legacy Kotlin/Gradle errors In-Reply-To: <86jzk03exp.fsf@gnu.org> References: <86jzk03exp.fsf@gnu.org> Date: Thu, 13 Jun 2024 16:44:04 +0200 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70797 Cc: 70797@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: > . applying this fails compile-tests in the test suite, so I guess > some adjustment there is also needed; Oops! In the new patch, attached below, I - adjust the existing legacy Gradle/Kotlin tests and - add new tests for the non-legacy Gradle/Kotlin warnings/errors. I also improved the commit message a bit. > . you removed the comment with the pointer to kotlin sources, which > might be still useful for the legacy format (unless the URL is no > longer valid), so please restore that if the pointer can still be > useful Smart! All right, I did a bit of research, and documented - the first and last Kotlin version that emits the current format, - the last Kotlin version that used the legacy format, - the official Git commit that removed the legacy format, - the public release date of the current format, and - the Kotlin class where the current format is defined. All of it is packed into two short comments. Rudy --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Make-the-Compilation-mode-recognize-non-legacy-Kotli.patch >From d9ab03624d868ee5f6a40390e321544c941cb9d4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rudolf=20Adamkovi=C4=8D?= Date: Thu, 2 May 2024 19:06:11 +0200 Subject: [PATCH] Make the Compilation mode recognize non-legacy Kotlin/Gradle errors The Compilation mode recognizes Kotlin/Gradle errors but only in the now legacy format. The current format, which has been in wide use for about a year, is not supported. This patch adds support for the current format. * etc/compilation.txt: (symbols): Add examples of non-legacy Kotlin/Gradle warnings and errors. * lisp/progmodes/compile.el: (compilation-error-regexp-alist-alist): Rename 'gradle-kotlin' to 'gradle-kotlin-legacy' and add 'grade-kotlin' that matches the errors and warnings outputted by the current (non-legacy) Kotlin/Gradle. * test/lisp/progmodes/compile-tests.el (compile-tests--test-regexps-data): Rename 'gradle-kotlin' to 'gradle-kotlin-legacy' and add two test cases for the newly added, non-legacy Kotlin/Gradle warnings and errors. --- etc/compilation.txt | 13 +++++++++++-- lisp/progmodes/compile.el | 24 +++++++++++++++++++++--- test/lisp/progmodes/compile-tests.el | 20 ++++++++++++-------- 3 files changed, 44 insertions(+), 13 deletions(-) diff --git a/etc/compilation.txt b/etc/compilation.txt index 05f0829864c..e4e361ecfc7 100644 --- a/etc/compilation.txt +++ b/etc/compilation.txt @@ -186,13 +186,22 @@ Warning near line 10 file arrayclash.f: Module contains no executable Nonportable usage near line 31 col 9 file assign.f: mixed default and explicit -* Gradle with kotlin-gradle-plugin +* Gradle with Kotlin plugin -symbol: gradle-kotlin +symbol: grade-kotlin + +e: file:///src/Test.kt:267:5 foo: bar +w: file:///src/Test.kt:267:5 foo: bar + + +* Gradle with Kotlin plugin (legacy) + +symbol: gradle-kotlin-legacy e: /src/Test.kt: (34, 15): foo: bar w: /src/Test.kt: (34, 15): foo: bar + * Gradle Android resource linking symbol: gradle-android diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index e31af774bd0..4d43a715fef 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -263,10 +263,28 @@ compilation-error-regexp-alist-alist "\\(^Warning .*\\)? line[ \n]\\([0-9]+\\)[ \n]\\(?:col \\([0-9]+\\)[ \n]\\)?file \\([^ :;\n]+\\)" 4 2 3 (1)) - ;; Gradle with kotlin-gradle-plugin (see - ;; GradleStyleMessagerRenderer.kt in kotlin sources, see - ;; https://youtrack.jetbrains.com/issue/KT-34683). + ;; Introduced in Kotlin 1.8 and current as of Kotlin 2.0. + ;; Emitted by `GradleStyleMessagerRenderer' in Kotlin sources. (gradle-kotlin + ,(rx bol + (| (group "w") ; 1: warning + (group (in "iv")) ; 2: info + "e") ; error + ": " + "file://" + (group ; 3: file + (? (in "A-Za-z") ":") + (+ (not (in "\n:")))) + ":" + (group (+ digit)) ; 4: line + ":" + (group (+ digit)) ; 5: column + " ") + 3 4 5 (1 . 2)) + + ;; Obsoleted in Kotlin 1.8 Beta, released on Nov 15, 2022. + ;; See commit `93a0cdbf973' in Kotlin Git repository. + (gradle-kotlin-legacy ,(rx bol (| (group "w") ; 1: warning (group (in "iv")) ; 2: info diff --git a/test/lisp/progmodes/compile-tests.el b/test/lisp/progmodes/compile-tests.el index 20beed955d2..b1187426ccf 100644 --- a/test/lisp/progmodes/compile-tests.el +++ b/test/lisp/progmodes/compile-tests.el @@ -270,20 +270,24 @@ compile-tests--test-regexps-data 1 nil 27041 "{standard input}") (gnu "boost/container/detail/flat_tree.hpp:589:25: [ skipping 5 instantiation contexts, use -ftemplate-backtrace-limit=0 to disable ]" 1 25 589 "boost/container/detail/flat_tree.hpp" 0) - ;; gradle-kotlin + ;; Gradle/Kotlin (gradle-kotlin - "e: /src/Test.kt: (34, 15): foo: bar" 4 15 34 "/src/Test.kt" 2) + "e: file:///src/Test.kt:267:5 foo: bar" 4 5 267 "/src/Test.kt" 2) (gradle-kotlin + "w: file:///src/Test.kt:267:5 foo: bar" 4 5 267 "/src/Test.kt" 1) + (gradle-kotlin-legacy + "e: /src/Test.kt: (34, 15): foo: bar" 4 15 34 "/src/Test.kt" 2) + (gradle-kotlin-legacy "w: /src/Test.kt: (11, 98): foo: bar" 4 98 11 "/src/Test.kt" 1) - (gradle-kotlin + (gradle-kotlin-legacy "e: e:/cygwin/src/Test.kt: (34, 15): foo: bar" 4 15 34 "e:/cygwin/src/Test.kt" 2) - (gradle-kotlin + (gradle-kotlin-legacy "w: e:/cygwin/src/Test.kt: (11, 98): foo: bar" 4 98 11 "e:/cygwin/src/Test.kt" 1) - (gradle-kotlin + (gradle-kotlin-legacy "e: e:\\src\\Test.kt: (34, 15): foo: bar" 4 15 34 "e:\\src\\Test.kt" 2) - (gradle-kotlin + (gradle-kotlin-legacy "w: e:\\src\\Test.kt: (11, 98): foo: bar" 4 98 11 "e:\\src\\Test.kt" 1) (gradle-android " ERROR:/Users/salutis/src/AndroidSchemeExperiment/app/build/intermediates/incremental/debug/mergeDebugResources/stripped.dir/layout/item.xml:3: AAPT: error: '16dpw' is incompatible with attribute padding (attr) dimension." @@ -534,8 +538,8 @@ compile-test-error-regexps 1 15 5 "alpha.c"))) (compile--test-error-line test)) - (should (eq compilation-num-errors-found 106)) - (should (eq compilation-num-warnings-found 35)) + (should (eq compilation-num-errors-found 107)) + (should (eq compilation-num-warnings-found 36)) (should (eq compilation-num-infos-found 35))))) (ert-deftest compile-test-grep-regexps () -- 2.39.3 (Apple Git-146) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable --=20 "Mathematics takes us still further from what is human into the region of absolute necessity, to which not only the actual world, but every possible world, must conform." --- Bertrand Russell, 1902 Rudolf Adamkovi=C4=8D [he/him] http://adamkovic.org --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 22 04:34:13 2024 Received: (at 70797-done) by debbugs.gnu.org; 22 Jun 2024 08:34:13 +0000 Received: from localhost ([127.0.0.1]:44304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKwCK-0008Jr-Sl for submit@debbugs.gnu.org; Sat, 22 Jun 2024 04:34:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51840) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKwCI-0008Jd-Jx for 70797-done@debbugs.gnu.org; Sat, 22 Jun 2024 04:34:11 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKwCD-00053k-KN; Sat, 22 Jun 2024 04:34:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=yzS2YskFWXx0FsRnj6e4wxqippPB6eqS8klSXkY+XFQ=; b=rKHWWJ+1hVtb SI7nPaBFPNbzgPTLfQLPkO4S0kVdEXqpT+39iHrh8V3nmQRjfjoVU9zI6tfzx4Xf4qFEheIWSDlSa 1cS/j0YuvFt/ipXFWnJMxmPvGYpB7H//10cgrbF8w5FYQrXl+qkYQMhIJsYov1shktitgYYLETlp5 6kMjogQN1NmQZfeQ207TY/kFHRqj7DhJMIX4UAYXo3rmvNY3rhpBxQy6AdUVFbO5jpySlPwyNEOXE 7tLEbPc3UuzPQpHF1qwetHokMkwY0/8IiEefFbFFowdEaw+Fnq+uI3p7qJ4gq24OjZM+ALahQfj59 3iPjjj7+7uHItglESjMS6g==; Date: Sat, 22 Jun 2024 11:34:02 +0300 Message-Id: <86v821idfp.fsf@gnu.org> From: Eli Zaretskii To: Rudolf (Rudy) Adamkovic In-Reply-To: (rudolf@adamkovic.org) Subject: Re: bug#70797: [PATCH] Make the Compilation mode recognize non-legacy Kotlin/Gradle errors References: <86jzk03exp.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70797-done Cc: 70797-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Rudolf (Rudy) Adamkovic > Cc: 70797@debbugs.gnu.org > Date: Thu, 13 Jun 2024 16:44:04 +0200 > > Eli Zaretskii writes: > > > . applying this fails compile-tests in the test suite, so I guess > > some adjustment there is also needed; > > Oops! In the new patch, attached below, I > > - adjust the existing legacy Gradle/Kotlin tests and > - add new tests for the non-legacy Gradle/Kotlin warnings/errors. > > I also improved the commit message a bit. > > > . you removed the comment with the pointer to kotlin sources, which > > might be still useful for the legacy format (unless the URL is no > > longer valid), so please restore that if the pointer can still be > > useful > > Smart! All right, I did a bit of research, and documented > > - the first and last Kotlin version that emits the current format, > - the last Kotlin version that used the legacy format, > - the official Git commit that removed the legacy format, > - the public release date of the current format, and > - the Kotlin class where the current format is defined. > > All of it is packed into two short comments. Thanks, installed on the master branch, and closing the bug. P.S. Please in the future mention the bug number in the commit log messages, when you know the number. In the initial submission of a patch, the number is usually not known, but if you resubmit, it usually is known already. (I added the bug number when installing the changes.) From unknown Fri Jun 20 19:54:47 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 20 Jul 2024 11:24:17 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator