GNU bug report logs - #70782
[PATCH] Set magit commit summary length in dir-locals

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 70782 in the body.
You can then email your comments to 70782 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Paul Nelson <ultrono <at> gmail.com>
To: bug-auctex <at> gnu.org
Subject: [PATCH] Set magit commit summary length in dir-locals
Date: Sun, 5 May 2024 14:13:45 +0200

[Message part 1 (text/plain, inline)]

This patch uses .dir-locals.el to set the magit commit summary maximum
length to 50.

Thanks, best,

Paul

[Message part 2 (text/html, inline)]

[0001-Set-magit-commit-summary-length-in-dir-locals.patch (application/octet-stream, attachment)]

Message #8 received at 70782 <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Paul Nelson <ultrono <at> gmail.com>
Cc: 70782 <at> debbugs.gnu.org
Subject: Re: bug#70782: [PATCH] Set magit commit summary length in dir-locals
Date: Sun, 05 May 2024 14:50:12 +0200

Hi Paul,

Paul Nelson <ultrono <at> gmail.com> writes:

> This patch uses .dir-locals.el to set the magit commit summary maximum
> length to 50.

I'm not a Magit user, hence the question: Does Magit use a special mode
for writing commit logs, like `log-edit-mode'?  Maybe we can put that
entry somewhere else in .dir-locals.el, next to

  (vc-git-log-edit-summary-target-len . 50)

or something like that.

Best, Arash

Message #11 received at 70782 <at> debbugs.gnu.org (full text, mbox):

From: Paul Nelson <ultrono <at> gmail.com>
To: Arash Esbati <arash <at> gnu.org>
Cc: 70782 <at> debbugs.gnu.org
Subject: Re: bug#70782: [PATCH] Set magit commit summary length in dir-locals
Date: Sun, 5 May 2024 14:56:29 +0200

[Message part 1 (text/plain, inline)]

Hi Arash,

I'm not a Magit user, hence the question: Does Magit use a special mode
> for writing commit logs, like `log-edit-mode'?  Maybe we can put that
> entry somewhere else in .dir-locals.el, next to
>
>
Unfortunately, it uses text-mode (and I don't know of any way to associate
.dir-locals entries with minor modes.)

Thanks, best,

Paul

[Message part 2 (text/html, inline)]

Message #14 received at 70782 <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Paul Nelson <ultrono <at> gmail.com>
Cc: 70782 <at> debbugs.gnu.org
Subject: Re: bug#70782: [PATCH] Set magit commit summary length in dir-locals
Date: Sun, 05 May 2024 15:14:25 +0200

Paul Nelson <ultrono <at> gmail.com> writes:

> Unfortunately, it uses text-mode (and I don't know of any way to
> associate .dir-locals entries with minor modes.)

Thanks.  Your proposal has another side effect for people not having
Magit installed: I get the following when I open a file inside AUCTeX
repo with your change installed:

--8<---------------cut here---------------start------------->8---
The local variables list in /path/to/auctex/
or .dir-locals.el contains values that may not be safe (*).

Do you want to apply it?  You can type
y  -- to apply the local variables list.
n  -- to ignore the local variables list.
!  -- to apply the local variables list, and permanently mark these
      values (*) as safe (in the future, they will be set automatically.)
i  -- to ignore the local variables list, and permanently mark these
      values (*) as ignored
+  -- to apply the local variables list, and trust all directory-local
      variables in this directory
--8<---------------cut here---------------end--------------->8---

Maybe we should skip this and you add that bit to your personal
.dir-locals-2.el file inside AUCTeX repo?

Best, Arash

Message #17 received at 70782 <at> debbugs.gnu.org (full text, mbox):

From: Paul Nelson <ultrono <at> gmail.com>
To: Arash Esbati <arash <at> gnu.org>
Cc: 70782 <at> debbugs.gnu.org
Subject: Re: bug#70782: [PATCH] Set magit commit summary length in dir-locals
Date: Sun, 5 May 2024 15:15:51 +0200

[Message part 1 (text/plain, inline)]

Ah, I see.  OK, what you suggest sounds good, please feel free to close.
Thanks, best,  Paul

On Sun, May 5, 2024 at 3:14 PM Arash Esbati <arash <at> gnu.org> wrote:

> Paul Nelson <ultrono <at> gmail.com> writes:
>
> > Unfortunately, it uses text-mode (and I don't know of any way to
> > associate .dir-locals entries with minor modes.)
>
> Thanks.  Your proposal has another side effect for people not having
> Magit installed: I get the following when I open a file inside AUCTeX
> repo with your change installed:
>
> --8<---------------cut here---------------start------------->8---
> The local variables list in /path/to/auctex/
> or .dir-locals.el contains values that may not be safe (*).
>
> Do you want to apply it?  You can type
> y  -- to apply the local variables list.
> n  -- to ignore the local variables list.
> !  -- to apply the local variables list, and permanently mark these
>       values (*) as safe (in the future, they will be set automatically.)
> i  -- to ignore the local variables list, and permanently mark these
>       values (*) as ignored
> +  -- to apply the local variables list, and trust all directory-local
>       variables in this directory
> --8<---------------cut here---------------end--------------->8---
>
> Maybe we should skip this and you add that bit to your personal
> .dir-locals-2.el file inside AUCTeX repo?
>
> Best, Arash
>

[Message part 2 (text/html, inline)]

Message #20 received at 70782 <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Paul Nelson <ultrono <at> gmail.com>
Cc: 70782 <at> debbugs.gnu.org
Subject: Re: bug#70782: [PATCH] Set magit commit summary length in dir-locals
Date: Sun, 05 May 2024 15:25:22 +0200

tags 70782 wontfix
close 70782
thank

Paul Nelson <ultrono <at> gmail.com> writes:

> Ah, I see.  OK, what you suggest sounds good, please feel free to
> close.

Thanks.  Let me know if Git is annoying you about the new file, I can
add it to our .gitignore.

Best, Arash

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.