From unknown Mon Jun 23 18:32:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#70727: cp doesn't recognize the new --update=none-fail option Resent-From: Attila Fidan Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 03 May 2024 04:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 70727 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 70727@debbugs.gnu.org X-Debbugs-Original-To: bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.171471129414282 (code B ref -1); Fri, 03 May 2024 04:42:02 +0000 Received: (at submit) by debbugs.gnu.org; 3 May 2024 04:41:34 +0000 Received: from localhost ([127.0.0.1]:46115 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2kjl-0003iD-Ih for submit@debbugs.gnu.org; Fri, 03 May 2024 00:41:34 -0400 Received: from lists.gnu.org ([2001:470:142::17]:49314) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2kIQ-0003UD-1S for submit@debbugs.gnu.org; Fri, 03 May 2024 00:13:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2kHx-0005xn-WE for bug-coreutils@gnu.org; Fri, 03 May 2024 00:12:50 -0400 Received: from out-185.mta1.migadu.com ([2001:41d0:203:375::b9]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2kHv-0001kl-Fa for bug-coreutils@gnu.org; Fri, 03 May 2024 00:12:49 -0400 Date: Fri, 3 May 2024 04:12:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=print0.net; s=key1; t=1714709559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=31r1sUUVZn2/FW//Xu4gu+6XlTZnUBZwTokEL1nRFXk=; b=n09rIcR9aasYwlFP66vGvt2XZj2d8dFZD9cKFoSCbqd062jCqTg7DnSiEnKRBET7jDhtKL pt4MJPihf+xoYB4Pdm8f6aHlrHIdqLnXK+i4JsYRNjcabtPOR2fT2wwL3uiq2zCvGggtxi t+pcS1KPX+JfRhbWntQG2Sfd9zVmdKmidyr87AWGApxj3Kt9dUk6kmjxkaQ6ls9vRMoco4 xPcCfJfssh5YUbPv+b0GBKT6z+CqGETV3+A2Y01PlQMf5vlSM0A9TbYOsyqoaHnGmF47uF WF/ITWEnPHeeFHfApTUdY7zrwPDH1t99aQ6t/7MvF6oi6Z+KWawTUvgPMjIrTA== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Attila Fidan Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:203:375::b9; envelope-from=dev@print0.net; helo=out-185.mta1.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Mailman-Approved-At: Fri, 03 May 2024 00:41:26 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) Hi, I wanted to use the new cp --update=none-fail option introduced in 9.5, but it said "invalid argument ‘none-fail’ for ‘--update’". It turns out that the commit (49912bac286eb3c0ef7d1567ae790193ad5eb2e8) adding it forgot to add the new operation to update_type[] and update_type_string[] in cp.c like it did for mv.c. After patching coreutils locally the functionality works as expected. It seems like the test suite didn't catch this because there's no cp/update.sh test like there is for mv. There's a test for if using --backup and --update=none-fail are mutually exclusive by checking if cp returns 1, but an invalid argument also makes cp return 1 :) I didn't include a patch in case a change to the test suite is wanted, but the proposed change is tiny and rather obvious. Thanks! From unknown Mon Jun 23 18:32:57 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Attila Fidan Subject: bug#70727: closed (Re: bug#70727: cp doesn't recognize the new --update=none-fail option) Message-ID: References: X-Gnu-PR-Message: they-closed 70727 X-Gnu-PR-Package: coreutils Reply-To: 70727@debbugs.gnu.org Date: Fri, 03 May 2024 09:28:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1714728482-16310-1" This is a multi-part message in MIME format... ------------=_1714728482-16310-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #70727: cp doesn't recognize the new --update=3Dnone-fail option which was filed against the coreutils package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 70727@debbugs.gnu.org. --=20 70727: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D70727 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1714728482-16310-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 70727-done) by debbugs.gnu.org; 3 May 2024 09:27:14 +0000 Received: from localhost ([127.0.0.1]:46295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2pCD-0004Ej-SX for submit@debbugs.gnu.org; Fri, 03 May 2024 05:27:14 -0400 Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]:56802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2pCB-0004Ed-ET for 70727-done@debbugs.gnu.org; Fri, 03 May 2024 05:27:12 -0400 Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-51f12ccff5eso2317590e87.1 for <70727-done@debbugs.gnu.org>; Fri, 03 May 2024 02:26:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714728403; x=1715333203; darn=debbugs.gnu.org; h=in-reply-to:from:content-language:references:to:subject:user-agent :mime-version:date:message-id:sender:from:to:cc:subject:date :message-id:reply-to; bh=nA270qsnGzVU6nIX+NSuyRbZQkmMEJsjhWTGKMD6tEg=; b=StMQ2SPz99+LG3gxckW3brXmRC4s67AtqT8PPP1DVSi01LxGGp3vYj1qg9jkozOOaB 63uEsq1vj3LkWdEVtkCjmzK79aavkcQZN9co8qL4DdKe+1aAijRKaxfPCwN9nT41e0Ui b8n4s1hg0Xg5JgdzrBstxDH1pl3clsp4DqSvmgMOvTSgAKLGkj0TYTfd2U6NiNRgieqr 14TqKFQO2S9xdIg9IGjna5EslafhA4lmKhiTkE8+kwFyPrfzoSoyiCnOkn6T3FZvP4Up MkrdhBffKblS50ssPAAT23hVFxxBUgFFeuC+efjibdULcVbyB78c4I+7I0RwCtSlkomp a1VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714728403; x=1715333203; h=in-reply-to:from:content-language:references:to:subject:user-agent :mime-version:date:message-id:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nA270qsnGzVU6nIX+NSuyRbZQkmMEJsjhWTGKMD6tEg=; b=NPYn+p/ofgDLuS0JB17/MSuB2fSGlX+eFQ2JesJ4hlGeOu+jPpGRIUpCeWYlz7FX6v Y18R6trfs3kylTrE095sjAaiLDH3VBI2WTxXPI8/FL2GvqhePiPbyXEgLAjHi9eisLWp VGe/YxKFINbhu7B5D8yIi1tjfrDS4CQ2IJiLsxW0V1g/YYEEP+l71626HR/kUjsOSGCR nYazrKUhUeYhsrFJc5+1aJYTQEes6suxYHiycdMmRG8zqhsYtftS16vgp372trEI8B4H OjQz8d+xxlVrvXG4SdzxCB8Ptgkq7vwWItENf3tf2O5jucP+a1v/1eCuRDtlhNgBBV9W 4+/Q== X-Forwarded-Encrypted: i=1; AJvYcCXC+v3+9NnuZmxPbtk0mUEuwPWLnRf1929TvNRni3ttJs4k9yqA74mmC7EJIRNOwA3V4sRtrZqBLXjyTwC+BI7kDP21wUcyJQrKDg== X-Gm-Message-State: AOJu0YyHDnR1cxhL/vFY5VqgmwcP0zR7xd+A6Y2QVLo1EwU1BR84K2L8 9zBnbNCO4ddQs8p1oGzPGs6kKL75RFdCw445XKgjT+t5zy5uL0oB X-Google-Smtp-Source: AGHT+IGid8MgD5QPpDkDi0qLKBxF/UmoVnjEOOsab8QuBDRtqqzuSwd5hzJze94CVP/CEI6udkX3cg== X-Received: by 2002:ac2:5606:0:b0:51d:38ee:ddda with SMTP id v6-20020ac25606000000b0051d38eedddamr1384812lfd.52.1714728402598; Fri, 03 May 2024 02:26:42 -0700 (PDT) Received: from [192.168.1.59] (86-44-211-146-dynamic.agg2.lod.rsl-rtd.eircom.net. [86.44.211.146]) by smtp.googlemail.com with ESMTPSA id hn26-20020a05600ca39a00b0041a68d4fe76sm8166534wmb.0.2024.05.03.02.26.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 May 2024 02:26:42 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------8MR0vW3tifPGJ03f0TaR97qx" Message-ID: Date: Fri, 3 May 2024 10:26:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: bug#70727: cp doesn't recognize the new --update=none-fail option To: Attila Fidan , 70727-done@debbugs.gnu.org References: Content-Language: en-US From: =?UTF-8?Q?P=C3=A1draig_Brady?= In-Reply-To: X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 70727-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) This is a multi-part message in MIME format. --------------8MR0vW3tifPGJ03f0TaR97qx Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 03/05/2024 05:12, Attila Fidan via GNU coreutils Bug Reports wrote: > Hi, > > I wanted to use the new cp --update=none-fail option introduced in 9.5, > but it said "invalid argument ‘none-fail’ for ‘--update’". It turns out > that the commit (49912bac286eb3c0ef7d1567ae790193ad5eb2e8) adding it > forgot to add the new operation to update_type[] and > update_type_string[] in cp.c like it did for mv.c. After patching > coreutils locally the functionality works as expected. > > It seems like the test suite didn't catch this because there's no > cp/update.sh test like there is for mv. There's a test for if using > --backup and --update=none-fail are mutually exclusive by checking if cp > returns 1, but an invalid argument also makes cp return 1 :) > > I didn't include a patch in case a change to the test suite is wanted, > but the proposed change is tiny and rather obvious. Well that's embarrassing. I implemented in cp first, tested that manually, then must have messed up that hunk when rebasing. The attached should fix this. Marking this as done. thanks, Pádraig. --------------8MR0vW3tifPGJ03f0TaR97qx Content-Type: text/x-patch; charset=UTF-8; name="cp--update=none-fail.patch" Content-Disposition: attachment; filename="cp--update=none-fail.patch" Content-Transfer-Encoding: base64 RnJvbSBkZTQ5ZTk5M2VhOGI2ZGNkZjZjYWRhM2MwZjQ0YTYzNzE1MTRmOTUyIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/UD1DMz1BMWRyYWlnPTIwQnJhZHk/ PSA8UEBkcmFpZ0JyYWR5LmNvbT4KRGF0ZTogRnJpLCAzIE1heSAyMDI0IDEwOjE4OjUwICsw MTAwClN1YmplY3Q6IFtQQVRDSF0gY3A6IGFjdHVhbGx5IHN1cHBvcnQgLS11cGRhdGU9bm9u ZS1mYWlsCgoqIHNyYy9jcC5jOiBBZGQgdGhlIGVudHJpZXMgZm9yIHRoZSAtLXVwZGF0ZT1u b25lLWZhaWwgb3B0aW9uLgoqIHRlc3RzL212L3VwZGF0ZS5zaDogQWRkIGEgdGVzdCBjYXNl LgoqIE5FV1M6IE1lbnRpb24gdGhlIGJ1ZyBmaXguCkZpeGVzIGh0dHBzOi8vYnVncy5nbnUu b3JnLzcwNzI3Ci0tLQogTkVXUyAgICAgICAgICAgICAgIHwgIDQgKysrKwogc3JjL2NwLmMg ICAgICAgICAgIHwgIDQgKystLQogdGVzdHMvbXYvdXBkYXRlLnNoIHwgMTEgKysrKysrKysr KysKIDMgZmlsZXMgY2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9ORVdTIGIvTkVXUwppbmRleCAzODlmNzI1MTYuLjdlOGNjYjM0ZiAx MDA2NDQKLS0tIGEvTkVXUworKysgYi9ORVdTCkBAIC00LDYgKzQsMTAgQEAgR05VIGNvcmV1 dGlscyBORVdTICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLSotIG91dGxp bmUgLSotCiAKICoqIEJ1ZyBmaXhlcwogCisgIGNwIGZpeGVzIHN1cHBvcnQgZm9yIC0tdXBk YXRlPW5vbmUtZmFpbCwgd2hpY2ggd291bGQgaGF2ZSBiZWVuCisgIHJlamVjdGVkIGFzIGFu IGludmFsaWQgb3B0aW9uLgorICBbYnVnIGludHJvZHVjZWQgaW4gY29yZXV0aWxzLTkuNV0K KwogICBscyBhbmQgcHJpbnRmIGZpeCBzaGVsbCBxdW90ZWQgb3V0cHV0IGluIHRoZSBlZGdl IGNhc2Ugb2YgZXNjYXBlZAogICBmaXJzdCBhbmQgbGFzdCBjaGFyYWN0ZXJzLCBhbmQgc2lu Z2xlIHF1b3RlcyBpbiB0aGUgc3RyaW5nLgogICBbYnVnIGludHJvZHVjZWQgaW4gY29yZXV0 aWxzLTguMjZdCmRpZmYgLS1naXQgYS9zcmMvY3AuYyBiL3NyYy9jcC5jCmluZGV4IDI4YjAy MTdkYi4uMDZkYmFkMTU1IDEwMDY0NAotLS0gYS9zcmMvY3AuYworKysgYi9zcmMvY3AuYwpA QCAtMTA0LDExICsxMDQsMTEgQEAgQVJHTUFUQ0hfVkVSSUZZIChyZWZsaW5rX3R5cGVfc3Ry aW5nLCByZWZsaW5rX3R5cGUpOwogCiBzdGF0aWMgY2hhciBjb25zdCAqY29uc3QgdXBkYXRl X3R5cGVfc3RyaW5nW10gPQogewotICAiYWxsIiwgIm5vbmUiLCAib2xkZXIiLCBudWxscHRy CisgICJhbGwiLCAibm9uZSIsICJub25lLWZhaWwiLCAib2xkZXIiLCBudWxscHRyCiB9Owog c3RhdGljIGVudW0gVXBkYXRlX3R5cGUgY29uc3QgdXBkYXRlX3R5cGVbXSA9CiB7Ci0gIFVQ REFURV9BTEwsIFVQREFURV9OT05FLCBVUERBVEVfT0xERVIsCisgIFVQREFURV9BTEwsIFVQ REFURV9OT05FLCBVUERBVEVfTk9ORV9GQUlMLCBVUERBVEVfT0xERVIsCiB9OwogQVJHTUFU Q0hfVkVSSUZZICh1cGRhdGVfdHlwZV9zdHJpbmcsIHVwZGF0ZV90eXBlKTsKIApkaWZmIC0t Z2l0IGEvdGVzdHMvbXYvdXBkYXRlLnNoIGIvdGVzdHMvbXYvdXBkYXRlLnNoCmluZGV4IDE2 NDM1NzgwMy4uMzlmZjY3N2I5IDEwMDc1NQotLS0gYS90ZXN0cy9tdi91cGRhdGUuc2gKKysr IGIvdGVzdHMvbXYvdXBkYXRlLnNoCkBAIC0zOCw2ICszOCwxNyBAQCBmb3IgaW50ZXJhY3Rp dmUgaW4gJycgLWk7IGRvCiAgIGRvbmUKIGRvbmUKIAorIyBUaGVzZSBzaG91bGQgYWNjZXB0 IGFsbCBvcHRpb25zCitmb3IgdXBkYXRlX29wdGlvbiBpbiAnLS11cGRhdGUnICctLXVwZGF0 ZT1vbGRlcicgJy0tdXBkYXRlPWFsbCcgXAorICctLXVwZGF0ZT1ub25lJyAnLS11cGRhdGU9 bm9uZS1mYWlsJzsgZG8KKworICB0b3VjaCBmaWxlMSB8fCBmcmFtZXdvcmtfZmFpbHVyZV8K KyAgbXYgJHVwZGF0ZV9vcHRpb24gZmlsZTEgZmlsZTIgfHwgZmFpbD0xCisgIHRlc3QgLWYg ZmlsZTEgJiYgZmFpbD0xCisgIGNwICR1cGRhdGVfb3B0aW9uIGZpbGUyIGZpbGUxIHx8IGZh aWw9MQorICBybSBmaWxlMSBmaWxlMiB8fCBmcmFtZXdvcmtfZmFpbHVyZV8KK2RvbmUKKwog IyBUaGVzZSBzaG91bGQgcGVyZm9ybSB0aGUgcmVuYW1lIC8gY29weQogZm9yIHVwZGF0ZV9v cHRpb24gaW4gJy0tdXBkYXRlJyAnLS11cGRhdGU9b2xkZXInICctLXVwZGF0ZT1hbGwnIFwK ICAnLS11cGRhdGU9bm9uZSAtLXVwZGF0ZT1hbGwnOyBkbwotLSAKMi40NC4wCgo= --------------8MR0vW3tifPGJ03f0TaR97qx-- ------------=_1714728482-16310-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 3 May 2024 04:41:34 +0000 Received: from localhost ([127.0.0.1]:46115 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2kjl-0003iD-Ih for submit@debbugs.gnu.org; Fri, 03 May 2024 00:41:34 -0400 Received: from lists.gnu.org ([2001:470:142::17]:49314) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2kIQ-0003UD-1S for submit@debbugs.gnu.org; Fri, 03 May 2024 00:13:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2kHx-0005xn-WE for bug-coreutils@gnu.org; Fri, 03 May 2024 00:12:50 -0400 Received: from out-185.mta1.migadu.com ([2001:41d0:203:375::b9]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2kHv-0001kl-Fa for bug-coreutils@gnu.org; Fri, 03 May 2024 00:12:49 -0400 Date: Fri, 3 May 2024 04:12:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=print0.net; s=key1; t=1714709559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=31r1sUUVZn2/FW//Xu4gu+6XlTZnUBZwTokEL1nRFXk=; b=n09rIcR9aasYwlFP66vGvt2XZj2d8dFZD9cKFoSCbqd062jCqTg7DnSiEnKRBET7jDhtKL pt4MJPihf+xoYB4Pdm8f6aHlrHIdqLnXK+i4JsYRNjcabtPOR2fT2wwL3uiq2zCvGggtxi t+pcS1KPX+JfRhbWntQG2Sfd9zVmdKmidyr87AWGApxj3Kt9dUk6kmjxkaQ6ls9vRMoco4 xPcCfJfssh5YUbPv+b0GBKT6z+CqGETV3+A2Y01PlQMf5vlSM0A9TbYOsyqoaHnGmF47uF WF/ITWEnPHeeFHfApTUdY7zrwPDH1t99aQ6t/7MvF6oi6Z+KWawTUvgPMjIrTA== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Attila Fidan To: bug-coreutils@gnu.org Subject: cp doesn't recognize the new --update=none-fail option Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:203:375::b9; envelope-from=dev@print0.net; helo=out-185.mta1.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 03 May 2024 00:41:26 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) Hi, I wanted to use the new cp --update=none-fail option introduced in 9.5, but it said "invalid argument ‘none-fail’ for ‘--update’". It turns out that the commit (49912bac286eb3c0ef7d1567ae790193ad5eb2e8) adding it forgot to add the new operation to update_type[] and update_type_string[] in cp.c like it did for mv.c. After patching coreutils locally the functionality works as expected. It seems like the test suite didn't catch this because there's no cp/update.sh test like there is for mv. There's a test for if using --backup and --update=none-fail are mutually exclusive by checking if cp returns 1, but an invalid argument also makes cp return 1 :) I didn't include a patch in case a change to the test suite is wanted, but the proposed change is tiny and rather obvious. Thanks! ------------=_1714728482-16310-1--