GNU bug report logs - #70725
29.3; dired-do-touch completion

Previous Next

Full log

View this message in rfc822 format

From: Thierry Volpiatto <thievol <at> posteo.net>
To: Juri Linkov <juri <at> linkov.net>
Cc: Thierry Volpiatto <thievol <at> posteo.net>, christopher <at> librehacker.com, Eli Zaretskii <eliz <at> gnu.org>, schwab <at> linux-m68k.org, 70725 <at> debbugs.gnu.org
Subject: bug#70725: 29.3; dired-do-touch completion
Date: Tue, 21 May 2024 13:04:21 +0000

[Message part 1 (text/plain, inline)]

Juri Linkov <juri <at> linkov.net> writes:

>>>> > However this doesn't explain why dired-do-touch uses a completing-read
>>>> 
>>>> Indeed, this was an oversight.  Here is the patch
>>>> that replaces 'completing-read' with 'read-string':
>>>
>>> Thierry, is this solution okay with you?
>>
>> This fix one issue,
>
> Thanks, so I pushed the fix.

Thanks.

>> but default is still wrong IMHO:
>>
>> When pressing RET with an empty prompt the value is different than what
>> is inserted in minibuffer with M-n.  Why do we bother setting the
>> timesamp at the exact time when pressing RET instead of when pressing
>> "T", I mean user would consider the timestamp is set once "T" is
>> pressed, with this the behavior would be consistent with RET and M-n and
>> the code much simpler.
>
> There is no need to make the value used by RET and the value inserted by M-n
> consistent in 100% of cases.

Sorry but I disagree on this.

-- 
Thierry

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.