GNU bug report logs - #70725
29.3; dired-do-touch completion

Previous Next

Package: emacs;

Reported by: Christopher Howard <christopher <at> librehacker.com>

Date: Thu, 2 May 2024 19:53:01 UTC

Severity: normal

Found in version 29.3

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #52 received at 70725 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Thierry Volpiatto <thievol <at> posteo.net>
Cc: christopher <at> librehacker.com, Eli Zaretskii <eliz <at> gnu.org>,
 schwab <at> linux-m68k.org, 70725 <at> debbugs.gnu.org
Subject: Re: bug#70725: 29.3; dired-do-touch completion
Date: Tue, 21 May 2024 09:20:08 +0300
>>> > However this doesn't explain why dired-do-touch uses a completing-read
>>> 
>>> Indeed, this was an oversight.  Here is the patch
>>> that replaces 'completing-read' with 'read-string':
>>
>> Thierry, is this solution okay with you?
>
> This fix one issue,

Thanks, so I pushed the fix.

> but default is still wrong IMHO:
>
> When pressing RET with an empty prompt the value is different than what
> is inserted in minibuffer with M-n.  Why do we bother setting the
> timesamp at the exact time when pressing RET instead of when pressing
> "T", I mean user would consider the timestamp is set once "T" is
> pressed, with this the behavior would be consistent with RET and M-n and
> the code much simpler.

There is no need to make the value used by RET and the value inserted by M-n
consistent in 100% of cases.  Some exceptions are required like in this case.




This bug report was last modified 1 year and 1 day ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.