GNU bug report logs - #70725
29.3; dired-do-touch completion

Previous Next

Full log

Message #46 received at 70725 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: thievol <at> posteo.net, Juri Linkov <juri <at> linkov.net>
Cc: christopher <at> librehacker.com, schwab <at> linux-m68k.org, 70725 <at> debbugs.gnu.org
Subject: Re: bug#70725: 29.3; dired-do-touch completion
Date: Sat, 18 May 2024 11:43:14 +0300

> From: Juri Linkov <juri <at> linkov.net>
> Cc: Andreas Schwab <schwab <at> linux-m68k.org>,  christopher <at> librehacker.com,
>   Eli Zaretskii <eliz <at> gnu.org>,  70725 <at> debbugs.gnu.org
> Date: Tue, 07 May 2024 19:48:54 +0300
> 
> > However this doesn't explain why dired-do-touch uses a completing-read
> 
> Indeed, this was an oversight.  Here is the patch
> that replaces 'completing-read' with 'read-string':

Thierry, is this solution okay with you?

> diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el
> index a2ce3083cfe..f3343b9b637 100644
> --- a/lisp/dired-aux.el
> +++ b/lisp/dired-aux.el
> @@ -658,10 +658,13 @@ dired-mark-read-string
>  
>  Optional arg COLLECTION is a collection of possible completions,
>  passed as the second arg to `completing-read'."
> -  (dired-mark-pop-up nil op-symbol files
> -		     'completing-read
> -		     (format prompt (dired-mark-prompt arg files))
> -		     collection nil nil initial nil default-value nil))
> +  (apply #'dired-mark-pop-up
> +         nil op-symbol files
> +         (if (eq op-symbol 'touch) 'read-string 'completing-read)
> +         (format prompt (dired-mark-prompt arg files))
> +         (if (eq op-symbol 'touch)
> +             `(,initial nil ,default-value nil)
> +           `(,collection nil nil ,initial nil ,default-value nil))))
>  
>  
>  ;;; Cleaning a directory: flagging some backups for deletion

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.