GNU bug report logs - #70724
29.2.50; eglot-reconnect errors when the project is deleted

Previous Next

Full log

Message #34 received at 70724 <at> debbugs.gnu.org (full text, mbox):

From: Spencer Baugh <sbaugh <at> janestreet.com>
To: João Távora <joaotavora <at> gmail.com>
Cc: Dmitry Gutov <dmitry <at> gutov.dev>, Eli Zaretskii <eliz <at> gnu.org>,
 app-emacs-dev <at> janestreet.com, 70724 <at> debbugs.gnu.org
Subject: Re: bug#70724: 29.2.50; eglot-reconnect errors when the project is
 deleted
Date: Thu, 21 Nov 2024 14:52:37 -0500

João Távora <joaotavora <at> gmail.com> writes:
> Anyway, this patch is slightly simpler (same idea)
>
> diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
> index e5c27de81fc..1e9a8a36343 100644
> --- a/lisp/progmodes/eglot.el
> +++ b/lisp/progmodes/eglot.el
> @@ -1518,13 +1518,11 @@ eglot--connect
>    "Connect to MANAGED-MODES, LANGUAGE-IDS, PROJECT, CLASS and CONTACT.
>  This docstring appeases checkdoc, that's all."
>    (let* ((default-directory (project-root project))
> -         (nickname (project-name project))
> -         (readable-name
> -          (progn
> -            (unless (file-exists-p default-directory)
> -              ;; could happen because of bug#70724 or just because
> -              (eglot--error "Project '%s' is gone!" nickname))
> -            (format "EGLOT (%s/%s)" nickname managed-modes)))
> +         (nickname (if (file-exists-p default-directory)
> +                       (project-name project)
> +                     ;; could happen because of bug#70724 or just because
> +                     (eglot--error "Project at `%s' is gone!"
> default-directory)))
> +         (readable-name (format "EGLOT (%s/%s)" nickname managed-modes))
>           server-info
>           (contact (if (functionp contact) (funcall contact) contact))
>           (initargs

That looks good to me.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.