GNU bug report logs - #70719
[PATCH] gnu: tla2tools: Add UseParallelGC to Java command in wrapper scripts

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Karl Hallsby <karl <at> hallsby.com>
Subject: bug#70719: closed (Re: [bug#70719] [PATCH] gnu: tla2tools: Add
 UseParallelGC to Java command in wrapper scripts)
Date: Fri, 31 May 2024 11:49:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#70719: [PATCH] gnu: tla2tools: Add UseParallelGC to Java command in wrapper scripts

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 70719 <at> debbugs.gnu.org.

-- 
70719: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70719
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Karl Hallsby <karl <at> hallsby.com>
Cc: Julien Lepiller <julien <at> lepiller.eu>, 70719-done <at> debbugs.gnu.org
Subject: Re: [bug#70719] [PATCH] gnu: tla2tools: Add UseParallelGC to Java
 command in wrapper scripts
Date: Fri, 31 May 2024 13:48:33 +0200

Hi,

Karl Hallsby <karl <at> hallsby.com> skribis:

> * gnu/pcakages/java.scm: Add -XX:+UseParallelGC to generated wrapper scripts
> for TLA+'s binary tools.
>
> TLA+'s tools request (and throw a warning message) when you invoke them
> without Java's parallel GC flag. Including this flag removes the warning
> message and should improve performance (theoretically).
>
> Change-Id: I12f7432db21db31ae2b0b30cc7f41f4a6af58b0a

Applied, thanks!

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Karl Hallsby <karl <at> hallsby.com>
To: guix-patches <at> gnu.org
Cc: Karl Hallsby <karl <at> hallsby.com>
Subject: [PATCH] gnu: tla2tools: Add UseParallelGC to Java command in wrapper
 scripts
Date: Thu,  2 May 2024 10:35:35 -0500

* gnu/pcakages/java.scm: Add -XX:+UseParallelGC to generated wrapper scripts
for TLA+'s binary tools.

TLA+'s tools request (and throw a warning message) when you invoke them
without Java's parallel GC flag. Including this flag removes the warning
message and should improve performance (theoretically).

Change-Id: I12f7432db21db31ae2b0b30cc7f41f4a6af58b0a
---
 gnu/packages/java.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index c43231dcb6..63acc11abe 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -20,6 +20,7 @@
 ;;; Copyright © 2021 Guillaume Le Vaillant <glv <at> posteo.net>
 ;;; Copyright © 2022 Artyom V. Poptsov <poptsov.artyom <at> gmail.com>
 ;;; Copyright © 2024 Paul A. Patience <paul <at> apatience.com>
+;;; Copyright © 2024 Raven Hallsby <karl <at> hallsby.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -14447,7 +14448,7 @@ (define-public tla2tools
                                (display
                                 (string-append
                                  "#!/bin/sh\n"
-                                 java " -cp " java-cp " " class " \"$@\""))))
+                                 java " -XX:+UseParallelGC " " -cp " java-cp " " class " \"$@\""))))
                            (chmod file #o755)))))
                     ;; bin/wrapper . java-class
                     '(("pcal" . "pcal.trans")

base-commit: e2ba93373a29ddf5d5754368957e89f3b426bb0a
-- 
2.41.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.