From debbugs-submit-bounces@debbugs.gnu.org Thu May 02 08:57:54 2024 Received: (at submit) by debbugs.gnu.org; 2 May 2024 12:57:54 +0000 Received: from localhost ([127.0.0.1]:43619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2W0X-0005e9-Sg for submit@debbugs.gnu.org; Thu, 02 May 2024 08:57:54 -0400 Received: from lists.gnu.org ([2001:470:142::17]:51058) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2W0U-0005e1-TY for submit@debbugs.gnu.org; Thu, 02 May 2024 08:57:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2W03-00009D-4J for guix-patches@gnu.org; Thu, 02 May 2024 08:57:23 -0400 Received: from 81-205-150-117.fixed.kpn.net ([81.205.150.117] helo=email.rimm.ee) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1s2Vzu-00005a-87 for guix-patches@gnu.org; Thu, 02 May 2024 08:57:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rimm.ee; s=herman; t=1714654626; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=0wIoS7kH+DmddOyUQypV9LtA32zV+aXfM8vBdBn9pRY=; b=ZxP2HXstNZ2UwUtFtn2ZrWeQ7wNsv7UcmrJAZp2UCk5p/e1dFWw0xg7qNhISVn5GM2QVox EIRRyykh2q8tdi1Uam99m5pJ40waYozBVeBe0k5l7pPWxETu0/K9bjeozPM2FNtB+uNPjq g8pBB0RlNsnDXiLTic/p56vG28AlxlqI9bjKuhgvvQnD+X/7mN0UBgRMOXXzmZ6Xn5NSDA BQ7AlIluPqNhtiRgYGepIYJiW5rNC//+XlFXxe31N+99OY8EwgkkoxmvTgZaJnvSIYzWbI /nPDAIja81qtgMcYzuca18SZDcqEG0bB1Y68Zi1wiPUklNzACIpyk37ZvjjhNg== Received: by 81-205-150-117.fixed.kpn.net (OpenSMTPD) with ESMTPSA id 8e32b643 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO) for ; Thu, 2 May 2024 12:57:06 +0000 (UTC) From: Herman Rimm To: guix-patches@gnu.org Subject: [PATCH 0/4] Change imported crate style. Date: Thu, 2 May 2024 14:57:00 +0200 Message-ID: <20240502125700.15062-1-herman@rimm.ee> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=81.205.150.117; envelope-from=herman@rimm.ee; helo=email.rimm.ee X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, TVD_RCVD_IP=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) Hello, Having created about 60 packages with the crate importer, I did it slightly faster than usual with this patch series applied. I would say 75% of the time the unindented #:cargo-development-inputs exceeded 72 characters. About 20% of the time a crate synopsis and description start with a proper noun (Rust) or an acronym (FFI). Adding 'This package provides ' makes the description into more of a sentence, though sometimes an indefinite article is missing. I could also instead add a flag to 'guix import' for extending the description in this way. Cheers, Herman Herman Rimm (4): guix: Indent cargo-development-inputs. guix: Beautify crate importer synopses. guix: Include a main verb in crate importer descriptions. guix: End package descriptions with period. guix/import/crate.scm | 12 ++++++++---- guix/import/utils.scm | 7 +++++++ guix/read-print.scm | 1 + 3 files changed, 16 insertions(+), 4 deletions(-) -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Thu May 02 08:59:39 2024 Received: (at 70715) by debbugs.gnu.org; 2 May 2024 12:59:39 +0000 Received: from localhost ([127.0.0.1]:43632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2W2F-0005g3-C2 for submit@debbugs.gnu.org; Thu, 02 May 2024 08:59:39 -0400 Received: from 81-205-150-117.fixed.kpn.net ([81.205.150.117]:53769 helo=email.rimm.ee) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2W2D-0005fj-ES for 70715@debbugs.gnu.org; Thu, 02 May 2024 08:59:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rimm.ee; s=herman; t=1714654749; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=NAtQpeOnGjzELXOfwBw88U3gMEVaL898HkOT2yEiImg=; b=MZwa1hxktAYVX3NC+k31ocWGLninjjZwxVuSphaLWAms12Ib5hRUo1qdhNJT5jTmuhNDsw g6AUB1Y6CTovWuUSaR6j+cfxAHH6c0ZJJPSvxCsFIisTO3wkKnjoNPhKSmtdjnqurZ4HeU pZMbXJS3AAWKJ0nSWY8uRFGD6h8leW6losTuMDsAd3tTsKf2pLXuxxukzEUui1iJCNJ7qA JkRovsWU+fB0s6llQ0sAwHd0jbTmqZzrS0BlnVpd/diayg5bapbo4TiO8qWs2sNw6MdGGh 47MO59tNJ53FT4Z0qbmXxfii6P1GB1DsYUMPXKX47L8KSff6fwCaGX5ZdW4emA== Received: by 81-205-150-117.fixed.kpn.net (OpenSMTPD) with ESMTPSA id 1c252a8d (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO) for <70715@debbugs.gnu.org>; Thu, 2 May 2024 12:59:08 +0000 (UTC) From: Herman Rimm To: 70715@debbugs.gnu.org Subject: [PATCH 1/4] guix: Indent cargo-development-inputs. Date: Thu, 2 May 2024 14:58:57 +0200 Message-ID: <20240502125900.15177-1-herman@rimm.ee> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * guix/import/crate.scm (make-crate-sexp): Swap cargo-development-inputs and cargo-inputs. * guix/read-print.scm (%newline-forms): Add #:cargo-development-inputs. Change-Id: I54a8c1934381cdb25b6d05e503d2bd2315d010b6 --- guix/import/crate.scm | 4 ++-- guix/read-print.scm | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_PBL RBL: Received via a relay in Spamhaus PBL [81.205.150.117 listed in zen.spamhaus.org] 0.0 TVD_RCVD_IP Message was received from an IP address -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-Debbugs-Envelope-To: 70715 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.6 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * guix/import/crate.scm (make-crate-sexp): Swap cargo-development-inputs and cargo-inputs. * guix/read-print.scm (%newline-forms): Add #:cargo-development-inputs. Change-Id: I54a8c1934381cdb25b6d05e503d2bd2315d010b6 --- guix/import/crate.scm | 4 ++-- guix/read-print.scm | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) Content analysis details: (2.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_PBL RBL: Received via a relay in Spamhaus PBL [81.205.150.117 listed in zen.spamhaus.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager * guix/import/crate.scm (make-crate-sexp): Swap cargo-development-inputs and cargo-inputs. * guix/read-print.scm (%newline-forms): Add #:cargo-development-inputs. Change-Id: I54a8c1934381cdb25b6d05e503d2bd2315d010b6 --- guix/import/crate.scm | 4 ++-- guix/read-print.scm | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/guix/import/crate.scm b/guix/import/crate.scm index 7a25b2243c..81e442141b 100644 --- a/guix/import/crate.scm +++ b/guix/import/crate.scm @@ -207,9 +207,9 @@ (define (format-inputs inputs) ,@(maybe-arguments (append (if build? '() '(#:skip-build? #t)) - (maybe-cargo-inputs cargo-inputs) (maybe-cargo-development-inputs - cargo-development-inputs))) + cargo-development-inputs) + (maybe-cargo-inputs cargo-inputs))) (home-page ,home-page) (synopsis ,synopsis) (description ,(beautify-description description)) diff --git a/guix/read-print.scm b/guix/read-print.scm index 6421b79737..80662f7189 100644 --- a/guix/read-print.scm +++ b/guix/read-print.scm @@ -365,6 +365,7 @@ (define %newline-forms ('git-reference '(uri origin source)) ('sha256 '(origin source package)) ('arguments '(package)) + ('#:cargo-development-inputs '(arguments)) ('list '(arguments package)) ('search-paths '(package)) ('native-search-paths '(package)) -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Thu May 02 08:59:40 2024 Received: (at 70715) by debbugs.gnu.org; 2 May 2024 12:59:40 +0000 Received: from localhost ([127.0.0.1]:43634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2W2F-0005g5-M7 for submit@debbugs.gnu.org; Thu, 02 May 2024 08:59:40 -0400 Received: from 81-205-150-117.fixed.kpn.net ([81.205.150.117]:53769 helo=email.rimm.ee) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2W2E-0005fj-FR for 70715@debbugs.gnu.org; Thu, 02 May 2024 08:59:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rimm.ee; s=herman; t=1714654749; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1gKiFeLS2qdzauVj0in3hDBSvz+CG2TxLnjtSH7gSUk=; b=D9OuMjxpH1vve6XNhqZamzDyXH4RYEYYmhc9iqjUJWzG9lw1cbCqxcNof+JxT5I9uxkxuJ h3BWB06usWzVfd4gbetjb+/HLh2tczQq1XhjjYHqiLAuvY5hWCvK98rsasb6+oVnpXNNGh AUBf+zlX9Scbn/8PsIXO7JBwjNKPcW1V/3sKAoD/8zG94g+ii5YLX1O2j7z1ox7PVt/9Yb APuG1Tb4aBooXt1yrL0cd/nR4Pt2uV2U/rH2n/n8WBIB6Rz8H1nGS/P77x8WRqk16I132M oIYW+Qy4//APxQIvj7y/msbSH8ytBnJa7/nSuGgtCS7P6vbuqXRVVqU1Du8chw== Received: by 81-205-150-117.fixed.kpn.net (OpenSMTPD) with ESMTPSA id ddfa2a48 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO) for <70715@debbugs.gnu.org>; Thu, 2 May 2024 12:59:09 +0000 (UTC) From: Herman Rimm To: 70715@debbugs.gnu.org Subject: [PATCH 2/4] guix: Beautify crate importer synopses. Date: Thu, 2 May 2024 14:58:58 +0200 Message-ID: <20240502125900.15177-2-herman@rimm.ee> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240502125900.15177-1-herman@rimm.ee> References: <20240502125900.15177-1-herman@rimm.ee> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * guix/import/crate.scm (make-crate-sexp): Use beautify-synopsis. Change-Id: I4e30e043d34da7a3c355e098f155c0c75b619063 --- guix/import/crate.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guix/import/crate.scm b/guix/import/crate.scm index 81e442141b..2f74333fa9 100644 --- a/guix/import/crate.scm +++ b/guix/import/crate.scm @@ -211, 7 +211, 7 @@ (define (format-inputs inputs [...] Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_PBL RBL: Received via a relay in Spamhaus PBL [81.205.150.117 listed in zen.spamhaus.org] 0.0 TVD_RCVD_IP Message was received from an IP address -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-Debbugs-Envelope-To: 70715 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.6 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * guix/import/crate.scm (make-crate-sexp): Use beautify-synopsis. Change-Id: I4e30e043d34da7a3c355e098f155c0c75b619063 --- guix/import/crate.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guix/import/crate.scm b/guix/import/crate.scm index 81e442141b..2f74333fa9 100644 --- a/guix/import/crate.scm +++ b/guix/import/crate.scm @@ -211,7 +211,7 @@ (define (format-inputs inputs [...] Content analysis details: (2.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_PBL RBL: Received via a relay in Spamhaus PBL [81.205.150.117 listed in zen.spamhaus.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager * guix/import/crate.scm (make-crate-sexp): Use beautify-synopsis. Change-Id: I4e30e043d34da7a3c355e098f155c0c75b619063 --- guix/import/crate.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guix/import/crate.scm b/guix/import/crate.scm index 81e442141b..2f74333fa9 100644 --- a/guix/import/crate.scm +++ b/guix/import/crate.scm @@ -211,7 +211,7 @@ (define (format-inputs inputs) cargo-development-inputs) (maybe-cargo-inputs cargo-inputs))) (home-page ,home-page) - (synopsis ,synopsis) + (synopsis ,(beautify-synopsis synopsis)) (description ,(beautify-description description)) (license ,(match license (() #f) -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Thu May 02 08:59:42 2024 Received: (at 70715) by debbugs.gnu.org; 2 May 2024 12:59:42 +0000 Received: from localhost ([127.0.0.1]:43637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2W2I-0005gS-4j for submit@debbugs.gnu.org; Thu, 02 May 2024 08:59:42 -0400 Received: from 81-205-150-117.fixed.kpn.net ([81.205.150.117]:53769 helo=email.rimm.ee) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2W2F-0005fj-59 for 70715@debbugs.gnu.org; Thu, 02 May 2024 08:59:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rimm.ee; s=herman; t=1714654749; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fByKIBXthAvsfmMnnC31qnD8RjAj8a92j01AGIDNn4c=; b=dwhTSsLzyc0EsoRLJd+qCermNcz26Q0gj99KnBjyp6X3OnGPYfBbrgHQNo+vNrp9g9Zo56 fp14/ALxb6OIxWvj/V9gkKRZWiMWHSaKkIPn8+Mx4krwml0x6v6ZL8PaBIIWgs1CPd74FX Zf63MnDGhFBV5YYxTg6GLVvAfshk1ZAlAEBDqwPpKkEYN0xo+1avRL/OYAh//im+QU3n/s 5YDjKOz8GZSHIwDVDq9AigMsxochyt+Cc+8Vu0RE9+o6hzGY/48SBct3bDE6W+BJpK2vrJ 0stIjakRxCBMt5Edbb4ALE8nmp33tnGs6gZMtlLvWA04rE7+1yA4ZCyUMqGCSQ== Received: by 81-205-150-117.fixed.kpn.net (OpenSMTPD) with ESMTPSA id 331010a5 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO) for <70715@debbugs.gnu.org>; Thu, 2 May 2024 12:59:09 +0000 (UTC) From: Herman Rimm To: 70715@debbugs.gnu.org Subject: [PATCH 3/4] guix: Include a main verb in crate importer descriptions. Date: Thu, 2 May 2024 14:58:59 +0200 Message-ID: <20240502125900.15177-3-herman@rimm.ee> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240502125900.15177-1-herman@rimm.ee> References: <20240502125900.15177-1-herman@rimm.ee> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * guix/import/crate.scm (make-crate-sexp): Start description with 'This package provides '. Change-Id: Id627759fb23da14fa7cb84e5dffb3bfc41950eab --- guix/import/crate.scm | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_PBL RBL: Received via a relay in Spamhaus PBL [81.205.150.117 listed in zen.spamhaus.org] 0.0 TVD_RCVD_IP Message was received from an IP address -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 T_FILL_THIS_FORM_SHORT Fill in a short form with personal information X-Debbugs-Envelope-To: 70715 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.6 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * guix/import/crate.scm (make-crate-sexp): Start description with 'This package provides '. Change-Id: Id627759fb23da14fa7cb84e5dffb3bfc41950eab --- guix/import/crate.scm | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) Content analysis details: (2.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_PBL RBL: Received via a relay in Spamhaus PBL [81.205.150.117 listed in zen.spamhaus.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager * guix/import/crate.scm (make-crate-sexp): Start description with 'This package provides '. Change-Id: Id627759fb23da14fa7cb84e5dffb3bfc41950eab --- guix/import/crate.scm | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/guix/import/crate.scm b/guix/import/crate.scm index 2f74333fa9..e739faa503 100644 --- a/guix/import/crate.scm +++ b/guix/import/crate.scm @@ -187,6 +187,7 @@ (define (format-inputs inputs) (guix-name (crate-name->package-name name)) (cargo-inputs (format-inputs cargo-inputs)) (cargo-development-inputs (format-inputs cargo-development-inputs)) + (description (beautify-description description)) (pkg `(package (name ,guix-name) (version ,version) @@ -212,7 +213,10 @@ (define (format-inputs inputs) (maybe-cargo-inputs cargo-inputs))) (home-page ,home-page) (synopsis ,(beautify-synopsis synopsis)) - (description ,(beautify-description description)) + (description ,(if (string-prefix? "This" description) + description + (string-append "This package provides " + description))) (license ,(match license (() #f) (#f #f) -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Thu May 02 08:59:42 2024 Received: (at 70715) by debbugs.gnu.org; 2 May 2024 12:59:42 +0000 Received: from localhost ([127.0.0.1]:43639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2W2I-0005gU-Ey for submit@debbugs.gnu.org; Thu, 02 May 2024 08:59:42 -0400 Received: from 81-205-150-117.fixed.kpn.net ([81.205.150.117]:53769 helo=email.rimm.ee) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2W2F-0005fj-Vk for 70715@debbugs.gnu.org; Thu, 02 May 2024 08:59:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rimm.ee; s=herman; t=1714654749; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tBpnVgqP1ug8BId/7VqzrO7z19d3qaQF1qCPyATmd60=; b=eApCf5w7rj6r13q6y28nyjwUqgq6gmRAQRLNn1GmwjNZKwb0e7GqGdWg0N6eJsALYbWhfY 2UCGae5/WqxGmqkzyfQDVfBW34ZsFXZJwY9DtfPV5JV5Q4gOSnx4X8UB4LqIvaIT9h6rfW i4NwvQCZ1vcySSs3JKlOMZ1VGmKJqzpDPl3XGlcuxnesO/G9uoV34Rmro98NJzvoS0/Jhl X1N2p4OJQ7zgzKOrqobi0cyz8PAcJ/eY4mVKh18bHIuhGF4KWvyRPuvKFTYNItgmcmcFct 1RkpFW50Lp6Kw3pBYi4fvdgeWN46X3TwHQV7s/IyvARamcXNa2M9KPE2R2iJ2w== Received: by 81-205-150-117.fixed.kpn.net (OpenSMTPD) with ESMTPSA id f9631cf8 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO) for <70715@debbugs.gnu.org>; Thu, 2 May 2024 12:59:09 +0000 (UTC) From: Herman Rimm To: 70715@debbugs.gnu.org Subject: [PATCH 4/4] guix: End package descriptions with period. Date: Thu, 2 May 2024 14:59:00 +0200 Message-ID: <20240502125900.15177-4-herman@rimm.ee> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240502125900.15177-1-herman@rimm.ee> References: <20240502125900.15177-1-herman@rimm.ee> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * guix/import/utils.scm (beautify-description): Append period to last words which do not end with one. Change-Id: Ia901dccadee6b4fef6c7f0176ce5871409ff6ce6 --- guix/import/utils.scm | 7 +++++++ 1 file changed, 7 insertions(+) Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_PBL RBL: Received via a relay in Spamhaus PBL [81.205.150.117 listed in zen.spamhaus.org] 0.0 TVD_RCVD_IP Message was received from an IP address -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-Debbugs-Envelope-To: 70715 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.6 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * guix/import/utils.scm (beautify-description): Append period to last words which do not end with one. Change-Id: Ia901dccadee6b4fef6c7f0176ce5871409ff6ce6 --- guix/import/utils.scm | 7 +++++++ 1 file changed, 7 insertions(+) Content analysis details: (2.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_PBL RBL: Received via a relay in Spamhaus PBL [81.205.150.117 listed in zen.spamhaus.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager * guix/import/utils.scm (beautify-description): Append period to last words which do not end with one. Change-Id: Ia901dccadee6b4fef6c7f0176ce5871409ff6ce6 --- guix/import/utils.scm | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/guix/import/utils.scm b/guix/import/utils.scm index 09a01cf315..e06f06e196 100644 --- a/guix/import/utils.scm +++ b/guix/import/utils.scm @@ -370,6 +370,13 @@ (define* (beautify-description description #:optional (length 80)) (cons* "This" "package" (string-downcase first) rest)) (_ words))) + (new-words + (match new-words + ((rest ... last) + (reverse (cons (if (string-suffix? "." last) + last + (string-append last ".")) + (reverse rest)))))) (cleaned (string-join (map fix-word new-words)))) ;; Use double spacing between sentences -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sun May 12 15:09:04 2024 Received: (at 70715) by debbugs.gnu.org; 12 May 2024 19:09:04 +0000 Received: from localhost ([127.0.0.1]:56010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6EZE-00089j-1P for submit@debbugs.gnu.org; Sun, 12 May 2024 15:09:04 -0400 Received: from 81-205-150-117.fixed.kpn.net ([81.205.150.117]:59293 helo=email.rimm.ee) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6EZ9-00089L-N9 for 70715@debbugs.gnu.org; Sun, 12 May 2024 15:09:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rimm.ee; s=herman; t=1715540925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Sw+e2t7XJ/1L99KAN32xgAjDB42rkd8PqQgBWNM+X/g=; b=KdASCRKeitSrZsNHCal9x2RWed8NN69q75cCTaB8Re6mKVovdRe/GFdCLe+is0G5wEgPQk w2/EFewWI6AnugatkuGXtzl6S72AVNNscxpeTNRhgc/AP6MsREIwmHC8OMfhrqI6wp4usy 0L0mcRRGD7F+j1jOOv5eIOjcrine1bxRJ1LaNQXk0/m6QFCFW2A/0xQ6eBTQZnCp5A+XWw 5h6257Iif4SeFIniRAMC5Jn4ie5zoDlY7pfaZFxmLbEdZMEpMfaMOAuC32c/0wRRCCocGv 5UE+VXe3YDziLfndbuNjGDwKDrcIMWkepX3BiMxA2zXjZB+SEQrqyA+Ahq2lSQ== Received: by 81-205-150-117.fixed.kpn.net (OpenSMTPD) with ESMTPSA id c49fd1ae (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO) for <70715@debbugs.gnu.org>; Sun, 12 May 2024 19:08:45 +0000 (UTC) From: Herman Rimm To: 70715@debbugs.gnu.org Subject: [PATCH v2 0/3] Change imported crate style. Date: Sun, 12 May 2024 21:08:29 +0200 Message-ID: X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Debbugs-Cc: Christopher Baines , Efraim Flashner , Lars-Dominik Braun , Marius Bakke , Munyoki Kilyungi , Sharlatan Hellseher , Tanguy Le Carrour , jgart Content-Transfer-Encoding: 8bit X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hello, I don't think indenting the #:cargo-development-inputs necessary; I removed the first patch and will work on [bug#49531] instead. I added a period to the package descriptions in the tests. I don't kno [...] Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 TVD_RCVD_IP Message was received from an IP address 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 3.6 RCVD_IN_PBL RBL: Received via a relay in Spamhaus PBL [81.205.150.117 listed in zen.spamhaus.org] X-Debbugs-Envelope-To: 70715 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.6 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hello, I don't think indenting the #:cargo-development-inputs necessary; I removed the first patch and will work on [bug#49531] instead. I added a period to the package descriptions in the tests. I don't kno [...] Content analysis details: (2.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_PBL RBL: Received via a relay in Spamhaus PBL [81.205.150.117 listed in zen.spamhaus.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager Hello, I don't think indenting the #:cargo-development-inputs necessary; I removed the first patch and will work on [bug#49531] instead. I added a period to the package descriptions in the tests. I don't know how to run all the tests, I ran '$ guix repl < tests/[test].scm' for tests containing package descriptions. Cheers, Herman Herman Rimm (3): guix: Beautify crate importer synopses. guix: Include a main verb in crate importer descriptions. guix: End package descriptions with period. guix/import/crate.scm | 8 ++++++-- guix/import/utils.scm | 9 +++++++++ tests/crate.scm | 36 ++++++++++++++++++------------------ tests/elm.scm | 2 +- tests/gem.scm | 12 ++++++------ tests/hexpm.scm | 8 ++++---- tests/minetest.scm | 2 +- tests/pypi.scm | 8 ++++---- 8 files changed, 49 insertions(+), 36 deletions(-) base-commit: 56980ea500a1db3c8586972b8abfaf5c4e24f82d -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sun May 12 15:09:07 2024 Received: (at 70715) by debbugs.gnu.org; 12 May 2024 19:09:07 +0000 Received: from localhost ([127.0.0.1]:56015 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6EZH-0008A6-B4 for submit@debbugs.gnu.org; Sun, 12 May 2024 15:09:07 -0400 Received: from 81-205-150-117.fixed.kpn.net ([81.205.150.117]:59293 helo=email.rimm.ee) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6EZD-00089L-Td for 70715@debbugs.gnu.org; Sun, 12 May 2024 15:09:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rimm.ee; s=herman; t=1715540925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QdFMxTQgsmy0Np0/GO+gQCxxqUP9YbOf3adTvRJSZ10=; b=Exc7EmVpYgTYJVykSt8W7al50uX4VJ6tVOwXuz3ev75X2agueqQlI4rWP33+7KHWCSPF+o 1WvKx5gTTDQmecVbyE8Ku8bWWcbulVZkKjQkEB5foPpU+S6TxlkR8Pry4FWip1wETalo2t TSKr1UqTAqpyc2SKF2pvrmPFFqIZAGeYcAU/wKdMU0S4vEoUgdGx5xXyZt6rD7zfQK0UAr IzjDPabsjOl23x/vN3EqyWQNxa4exrnc/ZpLF9QuBDmp2g84EFPF39kOvIEAbqlcl+MO40 7uziF918EdqpjYKS66Bc9RpXNj9oO/UJt4kvHJi1F/xBRXRmj26xP60qFcllHg== Received: by 81-205-150-117.fixed.kpn.net (OpenSMTPD) with ESMTPSA id 501fea79 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO) for <70715@debbugs.gnu.org>; Sun, 12 May 2024 19:08:45 +0000 (UTC) From: Herman Rimm To: 70715@debbugs.gnu.org Subject: [PATCH v2 1/3] guix: Beautify crate importer synopses. Date: Sun, 12 May 2024 21:08:30 +0200 Message-ID: <080a8f9eb967f46774fc3c6caf3db2668c6d775f.1715540349.git.herman@rimm.ee> X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 X-Debbugs-Cc: Efraim Flashner Content-Transfer-Encoding: 8bit X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * guix/import/crate.scm (make-crate-sexp): Use beautify-synopsis. Change-Id: I4e30e043d34da7a3c355e098f155c0c75b619063 --- guix/import/crate.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guix/import/crate.scm b/guix/import/crate.scm index 7a25b2243c..921e5499da 100644 --- a/guix/import/crate.scm +++ b/guix/import/crate.scm @@ -211,7 +211,7 @@ (define* (make-crate-sexp #:k [...] Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_PBL RBL: Received via a relay in Spamhaus PBL [81.205.150.117 listed in zen.spamhaus.org] 0.0 TVD_RCVD_IP Message was received from an IP address 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record X-Debbugs-Envelope-To: 70715 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.6 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * guix/import/crate.scm (make-crate-sexp): Use beautify-synopsis. Change-Id: I4e30e043d34da7a3c355e098f155c0c75b619063 --- guix/import/crate.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guix/import/crate.scm b/guix/import/crate.scm index 7a25b2243c..921e5499da 100644 --- a/guix/import/crate.scm +++ b/guix/import/crate.scm @@ -211,7 +211,7 @@ (define* (make-crate-sexp #:k [...] Content analysis details: (2.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_PBL RBL: Received via a relay in Spamhaus PBL [81.205.150.117 listed in zen.spamhaus.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager * guix/import/crate.scm (make-crate-sexp): Use beautify-synopsis. Change-Id: I4e30e043d34da7a3c355e098f155c0c75b619063 --- guix/import/crate.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guix/import/crate.scm b/guix/import/crate.scm index 7a25b2243c..921e5499da 100644 --- a/guix/import/crate.scm +++ b/guix/import/crate.scm @@ -211,7 +211,7 @@ (define* (make-crate-sexp #:key name version cargo-inputs cargo-development-inpu (maybe-cargo-development-inputs cargo-development-inputs))) (home-page ,home-page) - (synopsis ,synopsis) + (synopsis ,(beautify-synopsis synopsis)) (description ,(beautify-description description)) (license ,(match license (() #f) -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sun May 12 15:09:08 2024 Received: (at 70715) by debbugs.gnu.org; 12 May 2024 19:09:08 +0000 Received: from localhost ([127.0.0.1]:56017 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6EZH-0008AC-Q6 for submit@debbugs.gnu.org; Sun, 12 May 2024 15:09:08 -0400 Received: from 81-205-150-117.fixed.kpn.net ([81.205.150.117]:60569 helo=email.rimm.ee) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6EZE-00089M-Vc for 70715@debbugs.gnu.org; Sun, 12 May 2024 15:09:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rimm.ee; s=herman; t=1715540926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/EaQcB+QYq4xkyUFI0hWmGzPhIfJ2GH9aH8BkS7Mpj4=; b=L+404Oe73+NbjgylLQVk/txbHyFg3OajywIL4EaszwcQCj9Rvcx19iPm5ZPAOJK5VvyTA4 E3w12w8zsCZWBGny3Z3h5ax1qEuu6eB8nN7BaeE8STS83R3Rz6fho1bh1wyngk1fozOgEb GUjxXuiX/tK/iGOA16I7zaYUPrb5qzyQ1pNJ2r5KiwHmCGTP4YaNA1n30d2JbcIZnpYhV/ 977SUpNeBk2KapbdPt9Pa8riRaDVr+PlK5PGZei7IMbkEJ2OPQ0e6/SnbrAV3sGl1ykB9C xBu4NnXhZu0tVqsjZgHtCTH9IFFhIo2dInuFlEz2ktQ57avgS8M5NvA2t36NgA== Received: by 81-205-150-117.fixed.kpn.net (OpenSMTPD) with ESMTPSA id 5f2b917c (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO) for <70715@debbugs.gnu.org>; Sun, 12 May 2024 19:08:46 +0000 (UTC) From: Herman Rimm To: 70715@debbugs.gnu.org Subject: [PATCH v2 2/3] guix: Include a main verb in crate importer descriptions. Date: Sun, 12 May 2024 21:08:31 +0200 Message-ID: <2fdcf91f2da5f7170dd11daae30e71b3e77c3b1b.1715540349.git.herman@rimm.ee> X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 X-Debbugs-Cc: Efraim Flashner Content-Transfer-Encoding: 8bit X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * guix/import/crate.scm (make-crate-sexp): Start description with 'This package provides '. * tests/crate.scm: Set descriptions to "This package provides summary". --- guix/import/crate.scm | 6 +++++- [...] Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_PBL RBL: Received via a relay in Spamhaus PBL [81.205.150.117 listed in zen.spamhaus.org] 0.0 TVD_RCVD_IP Message was received from an IP address 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 T_FILL_THIS_FORM_SHORT Fill in a short form with personal information X-Debbugs-Envelope-To: 70715 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.6 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * guix/import/crate.scm (make-crate-sexp): Start description with 'This package provides '. * tests/crate.scm: Set descriptions to "This package provides summary". --- guix/import/crate.scm | 6 +++++- [...] Content analysis details: (2.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_PBL RBL: Received via a relay in Spamhaus PBL [81.205.150.117 listed in zen.spamhaus.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager * guix/import/crate.scm (make-crate-sexp): Start description with 'This package provides '. * tests/crate.scm: Set descriptions to "This package provides summary". --- guix/import/crate.scm | 6 +++++- tests/crate.scm | 36 ++++++++++++++++++------------------ 2 files changed, 23 insertions(+), 19 deletions(-) diff --git a/guix/import/crate.scm b/guix/import/crate.scm index 921e5499da..383a419741 100644 --- a/guix/import/crate.scm +++ b/guix/import/crate.scm @@ -187,6 +187,7 @@ (define* (make-crate-sexp #:key name version cargo-inputs cargo-development-inpu (guix-name (crate-name->package-name name)) (cargo-inputs (format-inputs cargo-inputs)) (cargo-development-inputs (format-inputs cargo-development-inputs)) + (description (beautify-description description)) (pkg `(package (name ,guix-name) (version ,version) @@ -212,7 +213,10 @@ (define* (make-crate-sexp #:key name version cargo-inputs cargo-development-inpu cargo-development-inputs))) (home-page ,home-page) (synopsis ,(beautify-synopsis synopsis)) - (description ,(beautify-description description)) + (description ,(if (string-prefix? "This" description) + description + (string-append "This package provides " + description))) (license ,(match license (() #f) (#f #f) diff --git a/tests/crate.scm b/tests/crate.scm index ce2f08aade..8b5bbc1b03 100644 --- a/tests/crate.scm +++ b/tests/crate.scm @@ -503,7 +503,7 @@ (define have-guile-semver? (("rust-leaf-alice" ('unquote 'rust-leaf-alice-0.7)))))) (home-page "http://example.com") (synopsis "summary") - (description "summary") + (description "This package provides summary") (license (list license:expat license:asl2.0)))) (string=? test-source-hash hash)) @@ -592,7 +592,7 @@ (define have-guile-semver? ('quasiquote (#:skip-build? #t))) (home-page "http://example.com") (synopsis "summary") - (description "summary") + (description "This package provides summary") (license (list license:expat license:asl2.0)))) (define-public 'rust-leaf-alice-0.7 (package @@ -611,7 +611,7 @@ (define have-guile-semver? (arguments ('quasiquote (#:skip-build? #t))) (home-page "http://example.com") (synopsis "summary") - (description "summary") + (description "This package provides summary") (license (list license:expat license:asl2.0)))) (define-public 'rust-leaf-bob-3 (package @@ -630,7 +630,7 @@ (define have-guile-semver? (arguments ('quasiquote (#:skip-build? #t))) (home-page "http://example.com") (synopsis "summary") - (description "summary") + (description "This package provides summary") (license (list license:expat license:asl2.0)))) (define-public 'rust-intermediate-b-1 (package @@ -653,7 +653,7 @@ (define have-guile-semver? ('unquote rust-leaf-bob-3)))))) (home-page "http://example.com") (synopsis "summary") - (description "summary") + (description "This package provides summary") (license (list license:expat license:asl2.0)))) (define-public 'rust-intermediate-a-1 (package @@ -680,7 +680,7 @@ (define have-guile-semver? ('unquote rust-leaf-bob-3)))))) (home-page "http://example.com") (synopsis "summary") - (description "summary") + (description "This package provides summary") (license (list license:expat license:asl2.0)))) (define-public 'rust-root-1 (package @@ -711,7 +711,7 @@ (define have-guile-semver? ('unquote rust-intermediate-c-1)))))) (home-page "http://example.com") (synopsis "summary") - (description "summary") + (description "This package provides summary") (license (list license:expat license:asl2.0))))) #t) (x @@ -740,7 +740,7 @@ (define have-guile-semver? ('unquote rust-leaf-alice-0.7)))))) (home-page "http://example.com") (synopsis "summary") - (description "summary") + (description "This package provides summary") (license (list license:expat license:asl2.0)))) (define-public 'rust-leaf-alice-0.7 (package @@ -758,7 +758,7 @@ (define have-guile-semver? (build-system cargo-build-system) (home-page "http://example.com") (synopsis "summary") - (description "summary") + (description "This package provides summary") (license (list license:expat license:asl2.0)))) (define-public 'rust-leaf-bob-3 (package @@ -776,7 +776,7 @@ (define have-guile-semver? (build-system cargo-build-system) (home-page "http://example.com") (synopsis "summary") - (description "summary") + (description "This package provides summary") (license (list license:expat license:asl2.0)))) (define-public 'rust-intermediate-b-1 (package @@ -798,7 +798,7 @@ (define have-guile-semver? ('unquote rust-leaf-bob-3)))))) (home-page "http://example.com") (synopsis "summary") - (description "summary") + (description "This package provides summary") (license (list license:expat license:asl2.0)))) (define-public 'rust-intermediate-a-1 (package @@ -824,7 +824,7 @@ (define have-guile-semver? ('unquote rust-leaf-bob-3)))))) (home-page "http://example.com") (synopsis "summary") - (description "summary") + (description "This package provides summary") (license (list license:expat license:asl2.0)))) (define-public 'rust-root-1 (package @@ -855,7 +855,7 @@ (define have-guile-semver? ('unquote rust-intermediate-c-1)))))) (home-page "http://example.com") (synopsis "summary") - (description "summary") + (description "This package provides summary") (license (list license:expat license:asl2.0))))) #t) (x @@ -972,7 +972,7 @@ (define rust-leaf-bob-3.0.2-yanked ('unquote 'rust-leaf-bob-4.0.0-yanked)))))) (home-page "http://example.com") (synopsis "summary") - (description "summary") + (description "This package provides summary") (license (list license:expat license:asl2.0))))) #t) (x @@ -1038,7 +1038,7 @@ (define rust-leaf-bob-3.0.2-yanked (build-system cargo-build-system) (home-page "http://example.com") (synopsis "summary") - (description "summary") + (description "This package provides summary") (license (list license:expat license:asl2.0)))) (define-public 'rust-leaf-bob-3.0.2-yanked (package @@ -1058,7 +1058,7 @@ (define rust-leaf-bob-3.0.2-yanked (build-system cargo-build-system) (home-page "http://example.com") (synopsis "summary") - (description "summary") + (description "This package provides summary") (license (list license:expat license:asl2.0)))) (define-public 'rust-leaf-bob-3 (package @@ -1076,7 +1076,7 @@ (define rust-leaf-bob-3.0.2-yanked (build-system cargo-build-system) (home-page "http://example.com") (synopsis "summary") - (description "summary") + (description "This package provides summary") (license (list license:expat license:asl2.0)))) (define-public 'rust-bar-1 (package @@ -1103,7 +1103,7 @@ (define rust-leaf-bob-3.0.2-yanked ('unquote 'rust-leaf-bob-4.0.0-yanked)))))) (home-page "http://example.com") (synopsis "summary") - (description "summary") + (description "This package provides summary") (license (list license:expat license:asl2.0))))) #t) (x -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sun May 12 15:09:09 2024 Received: (at 70715) by debbugs.gnu.org; 12 May 2024 19:09:09 +0000 Received: from localhost ([127.0.0.1]:56019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6EZI-0008AF-Bs for submit@debbugs.gnu.org; Sun, 12 May 2024 15:09:09 -0400 Received: from 81-205-150-117.fixed.kpn.net ([81.205.150.117]:59293 helo=email.rimm.ee) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6EZE-00089L-WC for 70715@debbugs.gnu.org; Sun, 12 May 2024 15:09:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rimm.ee; s=herman; t=1715540926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ks9ZRsnfU5xunSf64BxfTV6Q52+mtZISBNIm0GGloHk=; b=NoNfqgP+eS2dYDG+ov+vSxXk31RrHNBni91MP/3wzC88CNDWQivUCYBE5gNNokCTL76Amc MktgaquN79cYEQzY921o6s/jRpPtlxk3M4bqYWVITLAIgLc3D/u50AbEp71FnmHcdyvwKr 9t9z1YQsw0gD/WI982CmdL7DMtUU6IDZsX3m8vd7I6RO7ncUL45Y03AHXAh4kzAKe4yB+3 Jo8RDjYu/twxn26PQzo3VtDoFymoEkfnqJcggFsBPB/GEMc0CNQxZFIw3l95+svkqPzMJV Lr29yFdFa4j4TBLT0tYwsG+fDM2SgRixCtxmnEYafGhVbv9WvFJ07IzbGlDBRg== Received: by 81-205-150-117.fixed.kpn.net (OpenSMTPD) with ESMTPSA id 7b9f143b (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO) for <70715@debbugs.gnu.org>; Sun, 12 May 2024 19:08:46 +0000 (UTC) From: Herman Rimm To: 70715@debbugs.gnu.org Subject: [PATCH v2 3/3] guix: End package descriptions with period. Date: Sun, 12 May 2024 21:08:32 +0200 Message-ID: X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 X-Debbugs-Cc: Christopher Baines , Efraim Flashner , Lars-Dominik Braun , Marius Bakke , Munyoki Kilyungi , Sharlatan Hellseher , Tanguy Le Carrour , jgart Content-Transfer-Encoding: 8bit X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * guix/import/utils.scm (beautify-description): Append period to last words which do not end with one. * tests/crate.scm: Append period to descriptions. * tests/elm.scm: Append period to descriptions. [...] Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_PBL RBL: Received via a relay in Spamhaus PBL [81.205.150.117 listed in zen.spamhaus.org] 0.0 TVD_RCVD_IP Message was received from an IP address 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record X-Debbugs-Envelope-To: 70715 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.6 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * guix/import/utils.scm (beautify-description): Append period to last words which do not end with one. * tests/crate.scm: Append period to descriptions. * tests/elm.scm: Append period to descriptions. [...] Content analysis details: (2.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_PBL RBL: Received via a relay in Spamhaus PBL [81.205.150.117 listed in zen.spamhaus.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager * guix/import/utils.scm (beautify-description): Append period to last words which do not end with one. * tests/crate.scm: Append period to descriptions. * tests/elm.scm: Append period to descriptions. * tests/gem.scm: Append period to descriptions. * tests/hexpm.scm: Append period to descriptions. * tests/minetest.scm: Append period to descriptions. * tests/pypi.scm: Append period to descriptions. Change-Id: I0b12c4d94cb26cf62fab5b7cbf7885e66ff6c10f --- guix/import/utils.scm | 9 +++++++++ tests/crate.scm | 36 ++++++++++++++++++------------------ tests/elm.scm | 2 +- tests/gem.scm | 12 ++++++------ tests/hexpm.scm | 8 ++++---- tests/minetest.scm | 2 +- tests/pypi.scm | 8 ++++---- 7 files changed, 43 insertions(+), 34 deletions(-) diff --git a/guix/import/utils.scm b/guix/import/utils.scm index 09a01cf315..45fed93134 100644 --- a/guix/import/utils.scm +++ b/guix/import/utils.scm @@ -370,6 +370,15 @@ (define* (beautify-description description #:optional (length 80)) (cons* "This" "package" (string-downcase first) rest)) (_ words))) + (new-words + (match new-words + ((rest ... last) + (reverse (cons (if (or (string-suffix? "." last) + (string-suffix? "!" last) + (string-suffix? "?" last)) + last + (string-append last ".")) + (reverse rest)))))) (cleaned (string-join (map fix-word new-words)))) ;; Use double spacing between sentences diff --git a/tests/crate.scm b/tests/crate.scm index 8b5bbc1b03..5b4ad08c3c 100644 --- a/tests/crate.scm +++ b/tests/crate.scm @@ -503,7 +503,7 @@ (define have-guile-semver? (("rust-leaf-alice" ('unquote 'rust-leaf-alice-0.7)))))) (home-page "http://example.com") (synopsis "summary") - (description "This package provides summary") + (description "This package provides summary.") (license (list license:expat license:asl2.0)))) (string=? test-source-hash hash)) @@ -592,7 +592,7 @@ (define have-guile-semver? ('quasiquote (#:skip-build? #t))) (home-page "http://example.com") (synopsis "summary") - (description "This package provides summary") + (description "This package provides summary.") (license (list license:expat license:asl2.0)))) (define-public 'rust-leaf-alice-0.7 (package @@ -611,7 +611,7 @@ (define have-guile-semver? (arguments ('quasiquote (#:skip-build? #t))) (home-page "http://example.com") (synopsis "summary") - (description "This package provides summary") + (description "This package provides summary.") (license (list license:expat license:asl2.0)))) (define-public 'rust-leaf-bob-3 (package @@ -630,7 +630,7 @@ (define have-guile-semver? (arguments ('quasiquote (#:skip-build? #t))) (home-page "http://example.com") (synopsis "summary") - (description "This package provides summary") + (description "This package provides summary.") (license (list license:expat license:asl2.0)))) (define-public 'rust-intermediate-b-1 (package @@ -653,7 +653,7 @@ (define have-guile-semver? ('unquote rust-leaf-bob-3)))))) (home-page "http://example.com") (synopsis "summary") - (description "This package provides summary") + (description "This package provides summary.") (license (list license:expat license:asl2.0)))) (define-public 'rust-intermediate-a-1 (package @@ -680,7 +680,7 @@ (define have-guile-semver? ('unquote rust-leaf-bob-3)))))) (home-page "http://example.com") (synopsis "summary") - (description "This package provides summary") + (description "This package provides summary.") (license (list license:expat license:asl2.0)))) (define-public 'rust-root-1 (package @@ -711,7 +711,7 @@ (define have-guile-semver? ('unquote rust-intermediate-c-1)))))) (home-page "http://example.com") (synopsis "summary") - (description "This package provides summary") + (description "This package provides summary.") (license (list license:expat license:asl2.0))))) #t) (x @@ -740,7 +740,7 @@ (define have-guile-semver? ('unquote rust-leaf-alice-0.7)))))) (home-page "http://example.com") (synopsis "summary") - (description "This package provides summary") + (description "This package provides summary.") (license (list license:expat license:asl2.0)))) (define-public 'rust-leaf-alice-0.7 (package @@ -758,7 +758,7 @@ (define have-guile-semver? (build-system cargo-build-system) (home-page "http://example.com") (synopsis "summary") - (description "This package provides summary") + (description "This package provides summary.") (license (list license:expat license:asl2.0)))) (define-public 'rust-leaf-bob-3 (package @@ -776,7 +776,7 @@ (define have-guile-semver? (build-system cargo-build-system) (home-page "http://example.com") (synopsis "summary") - (description "This package provides summary") + (description "This package provides summary.") (license (list license:expat license:asl2.0)))) (define-public 'rust-intermediate-b-1 (package @@ -798,7 +798,7 @@ (define have-guile-semver? ('unquote rust-leaf-bob-3)))))) (home-page "http://example.com") (synopsis "summary") - (description "This package provides summary") + (description "This package provides summary.") (license (list license:expat license:asl2.0)))) (define-public 'rust-intermediate-a-1 (package @@ -824,7 +824,7 @@ (define have-guile-semver? ('unquote rust-leaf-bob-3)))))) (home-page "http://example.com") (synopsis "summary") - (description "This package provides summary") + (description "This package provides summary.") (license (list license:expat license:asl2.0)))) (define-public 'rust-root-1 (package @@ -855,7 +855,7 @@ (define have-guile-semver? ('unquote rust-intermediate-c-1)))))) (home-page "http://example.com") (synopsis "summary") - (description "This package provides summary") + (description "This package provides summary.") (license (list license:expat license:asl2.0))))) #t) (x @@ -972,7 +972,7 @@ (define rust-leaf-bob-3.0.2-yanked ('unquote 'rust-leaf-bob-4.0.0-yanked)))))) (home-page "http://example.com") (synopsis "summary") - (description "This package provides summary") + (description "This package provides summary.") (license (list license:expat license:asl2.0))))) #t) (x @@ -1038,7 +1038,7 @@ (define rust-leaf-bob-3.0.2-yanked (build-system cargo-build-system) (home-page "http://example.com") (synopsis "summary") - (description "This package provides summary") + (description "This package provides summary.") (license (list license:expat license:asl2.0)))) (define-public 'rust-leaf-bob-3.0.2-yanked (package @@ -1058,7 +1058,7 @@ (define rust-leaf-bob-3.0.2-yanked (build-system cargo-build-system) (home-page "http://example.com") (synopsis "summary") - (description "This package provides summary") + (description "This package provides summary.") (license (list license:expat license:asl2.0)))) (define-public 'rust-leaf-bob-3 (package @@ -1076,7 +1076,7 @@ (define rust-leaf-bob-3.0.2-yanked (build-system cargo-build-system) (home-page "http://example.com") (synopsis "summary") - (description "This package provides summary") + (description "This package provides summary.") (license (list license:expat license:asl2.0)))) (define-public 'rust-bar-1 (package @@ -1103,7 +1103,7 @@ (define rust-leaf-bob-3.0.2-yanked ('unquote 'rust-leaf-bob-4.0.0-yanked)))))) (home-page "http://example.com") (synopsis "summary") - (description "This package provides summary") + (description "This package provides summary.") (license (list license:expat license:asl2.0))))) #t) (x diff --git a/tests/elm.scm b/tests/elm.scm index c30623da03..48d3eb4b01 100644 --- a/tests/elm.scm +++ b/tests/elm.scm @@ -257,7 +257,7 @@ (define (directory-sha256 directory) "https://package.elm-lang.org/packages/elm-guix/demo/3.0.0") (synopsis "A test for `(guix import elm)`") (description - "This package provides a test for `(guix import elm)`") + "This package provides a test for `(guix import elm)`.") (properties '((upstream-name . "elm-guix/demo"))) (license license:gpl3+))) (equal? (directory-sha256 elm-guix-demo-dir) diff --git a/tests/gem.scm b/tests/gem.scm index 7e2436e3fb..dae29437e5 100644 --- a/tests/gem.scm +++ b/tests/gem.scm @@ -117,7 +117,7 @@ (define test-bundler-json (build-system ruby-build-system) (propagated-inputs (list bundler ruby-bar)) (synopsis "A cool gem") - (description "This package provides a cool gem") + (description "This package provides a cool gem.") (home-page "https://example.com") (license (list license:expat license:asl2.0))) #t) @@ -146,7 +146,7 @@ (define test-bundler-json (build-system ruby-build-system) (propagated-inputs (list bundler ruby-bar)) (synopsis "A cool gem") - (description "This package provides a cool gem") + (description "This package provides a cool gem.") (home-page "https://example.com") (license (list license:expat license:asl2.0))) #t) @@ -182,7 +182,7 @@ (define test-bundler-json (build-system ruby-build-system) (propagated-inputs (list bundler)) (synopsis "Another cool gem") - (description "Another cool gem") + (description "Another cool gem.") (home-page "https://example.com") (license #f)) ;no licensing info (package @@ -198,7 +198,7 @@ (define test-bundler-json (build-system ruby-build-system) (propagated-inputs (list bundler ruby-bar)) (synopsis "A cool gem") - (description "This package provides a cool gem") + (description "This package provides a cool gem.") (home-page "https://example.com") (license (list license:expat license:asl2.0)))) #t) @@ -234,7 +234,7 @@ (define test-bundler-json (build-system ruby-build-system) (propagated-inputs (list bundler)) (synopsis "Another cool gem") - (description "Another cool gem") + (description "Another cool gem.") (home-page "https://example.com") (license #f)) ;no licensing info (package @@ -250,7 +250,7 @@ (define test-bundler-json (build-system ruby-build-system) (propagated-inputs (list bundler ruby-bar)) (synopsis "A cool gem") - (description "This package provides a cool gem") + (description "This package provides a cool gem.") (home-page "https://example.com") (license (list license:expat license:asl2.0)))) #t) diff --git a/tests/hexpm.scm b/tests/hexpm.scm index 5df9af0ca6..1e746f9b34 100644 --- a/tests/hexpm.scm +++ b/tests/hexpm.scm @@ -152,7 +152,7 @@ (define test-fasel-release (build-system rebar-build-system) (inputs (list erlang-blubb erlang-fasel)) (synopsis "A cool package") - (description "This package provides a cool package") + (description "This package provides a cool package.") (home-page "https://hex.pm/packages/bla") (license (list license:expat license:asl2.0))) #t) @@ -212,7 +212,7 @@ (define test-fasel-release (build-system mix-build-system) (inputs (list erlang-fasel)) (synopsis "Another cool package") - (description "Another cool package") + (description "Another cool package.") (home-page "https://hex.pm/packages/blubb") (license license:expat)) (package @@ -227,7 +227,7 @@ (define test-fasel-release "1k6d70mxwqgq78jrbr7yqnw187yki74jnagybi7nacrj4a67qjha")))) (build-system gnu-build-system) (synopsis "Yet another cool package") - (description "Yet another cool package") + (description "Yet another cool package.") (home-page "https://hex.pm/packages/fasel") (license "GPL")) (package @@ -243,7 +243,7 @@ (define test-fasel-release (build-system rebar-build-system) (inputs (list erlang-blubb erlang-fasel)) (synopsis "A cool package") - (description "This package provides a cool package") + (description "This package provides a cool package.") (home-page "https://hex.pm/packages/bla") (license (list license:expat license:asl2.0)))) #t) diff --git a/tests/minetest.scm b/tests/minetest.scm index 78469bf95b..bf1313ee22 100644 --- a/tests/minetest.scm +++ b/tests/minetest.scm @@ -48,7 +48,7 @@ (define* (make-package-sexp #:key (home-page "https://example.org/foo") (repo "https://example.org/foo.git") (synopsis "synopsis") - (guix-description "description") + (guix-description "description.") (guix-license '(list license:cc-by-sa4.0 license:lgpl3+)) (inputs '()) diff --git a/tests/pypi.scm b/tests/pypi.scm index 42b39cde73..c9aee34d8b 100644 --- a/tests/pypi.scm +++ b/tests/pypi.scm @@ -315,7 +315,7 @@ (define-syntax-rule (with-pypi responses body ...) (native-inputs (list python-pytest)) (home-page "http://example.com") (synopsis "summary") - (description "summary") + (description "summary.") (license license:lgpl2.0)) (and (string=? default-sha256/base32 hash) (equal? (pypi->guix-package "foo" #:version "1.0.0") @@ -356,7 +356,7 @@ (define-syntax-rule (with-pypi responses body ...) (native-inputs (list python-pytest)) (home-page "http://example.com") (synopsis "summary") - (description "summary") + (description "summary.") (license license:lgpl2.0)) (string=? default-sha256/base32 hash)) (x @@ -384,7 +384,7 @@ (define-syntax-rule (with-pypi responses body ...) (build-system pyproject-build-system) (home-page "http://example.com") (synopsis "summary") - (description "summary") + (description "summary.") (license license:lgpl2.0)) (string=? default-sha256/base32 hash)) (x @@ -414,7 +414,7 @@ (define-syntax-rule (with-pypi responses body ...) (native-inputs (list python-pytest)) (home-page "http://example.com") (synopsis "summary") - (description "summary") + (description "summary.") (license license:lgpl2.0)) (string=? default-sha256/base32 hash)) (x -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 03 16:38:34 2024 Received: (at 70715-done) by debbugs.gnu.org; 3 Jun 2024 20:38:34 +0000 Received: from localhost ([127.0.0.1]:55807 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEERq-0001ps-DP for submit@debbugs.gnu.org; Mon, 03 Jun 2024 16:38:34 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEERl-0001pO-B0 for 70715-done@debbugs.gnu.org; Mon, 03 Jun 2024 16:38:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEERL-0002sl-N6; Mon, 03 Jun 2024 16:37:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=e9gp2aZJPdrQonrLkGWQ8KkLdByPwRVXcRVgvr0zWn4=; b=N5IzsL4QSm7PaJrd+FZP Zclb0RpPOJDEwri0TEnF/kFlHhrUzRGP1mGCZQG1rZFpVudoK4/KqzNODtfQIAg+R+lNDDBMu/EZV wGOnxiPgrpxRpU4q6M3CfqD/GPX3LPiDbu4CoTZBJUDphcQE97hHBEmYimnZLZQBxzwWpBXvM/7yI YNvW+uIXMMpstVGPzCsIzWMWBfMw/Ua0O3yylT2G02+ZBoEBBpBh1RY+gBZgj6Ua8jBmv4DzB70UG gIzxQsManMGUhxRNCIDtYxRcAwc/whcg0nVx5VswsUwwk0gYod+g5gxQf+7Mmv5hQ3dlbDq+8qnfq 2d+uquTSEH9g4Q==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Herman Rimm Subject: Re: [bug#70715] [PATCH v2 0/3] Change imported crate style. In-Reply-To: (Herman Rimm's message of "Sun, 12 May 2024 21:08:29 +0200") References: <20240502125700.15062-1-herman@rimm.ee> Date: Mon, 03 Jun 2024 22:37:55 +0200 Message-ID: <87tti9ahjw.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70715-done Cc: Tanguy Le Carrour , Sharlatan Hellseher , Munyoki Kilyungi , Lars-Dominik Braun , Efraim Flashner , 70715-done@debbugs.gnu.org, jgart , Marius Bakke , Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Herman, Herman Rimm skribis: > I don't think indenting the #:cargo-development-inputs necessary; > I removed the first patch and will work on [bug#49531] instead. Yes, addressing #49531 would be great. > guix: Beautify crate importer synopses. > guix: Include a main verb in crate importer descriptions. > guix: End package descriptions with period. Neat! Applied after tweaking commit logs and making minor changes (see following messages). Thanks! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 03 16:39:07 2024 Received: (at 70715) by debbugs.gnu.org; 3 Jun 2024 20:39:07 +0000 Received: from localhost ([127.0.0.1]:55819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEESR-0001rz-Fi for submit@debbugs.gnu.org; Mon, 03 Jun 2024 16:39:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEESQ-0001qt-4t for 70715@debbugs.gnu.org; Mon, 03 Jun 2024 16:39:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEES7-0002yu-QV; Mon, 03 Jun 2024 16:38:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=L0IKq80Q2lsHeyTHA+NP8MqhsTIXmViHksaKTo/a7wg=; b=ARLcJDPMI0DRgANGP1Dw pAHaAfh3ohNYXJlsbHSWejzaorw5AP9OSfxHjhwKREmUsAe7wJvmS1XlldX/XNksHUHule/RF0bvh 2q0a91kT5rzSHDexNiji4gN4izGJUQVV60ARqhBIa/qVO6ajVIGHifqjRGI+QxipCggWp31Q037my 8QJXHuKr6O5fQ60zmB+hhXHz7uAQprMGYcfa1FOI5E29h1sre8dMOShJiv45Py1Q8VCA/PoqP6aTQ NRVABeOXl3wR3xmC8il4oitmD9AfbQSH6cx5P4zTdVnwNjykjqsJpmy4zLgd4BWhhHUqueoT7qFKh 9lyQCPZArtiCzg==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Herman Rimm Subject: Re: [bug#70715] [PATCH v2 2/3] guix: Include a main verb in crate importer descriptions. In-Reply-To: <2fdcf91f2da5f7170dd11daae30e71b3e77c3b1b.1715540349.git.herman@rimm.ee> (Herman Rimm's message of "Sun, 12 May 2024 21:08:31 +0200") References: <2fdcf91f2da5f7170dd11daae30e71b3e77c3b1b.1715540349.git.herman@rimm.ee> Date: Mon, 03 Jun 2024 22:38:45 +0200 Message-ID: <87plsxahii.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70715 Cc: 70715@debbugs.gnu.org, Efraim Flashner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Herman Rimm skribis: > +++ b/guix/import/crate.scm > @@ -187,6 +187,7 @@ (define* (make-crate-sexp #:key name version cargo-in= puts cargo-development-inpu > (guix-name (crate-name->package-name name)) > (cargo-inputs (format-inputs cargo-inputs)) > (cargo-development-inputs (format-inputs cargo-development-inpu= ts)) > + (description (beautify-description description)) > (pkg `(package > (name ,guix-name) > (version ,version) > @@ -212,7 +213,10 @@ (define* (make-crate-sexp #:key name version cargo-i= nputs cargo-development-inpu > cargo-development-inputs= ))) > (home-page ,home-page) > (synopsis ,(beautify-synopsis synopsis)) > - (description ,(beautify-description description)) > + (description ,(if (string-prefix? "This" description) > + description > + (string-append "This package provides= " > + description))) I took the liberty to indent the =E2=80=98if=E2=80=99 above in the usual wa= y. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 03 16:39:42 2024 Received: (at 70715) by debbugs.gnu.org; 3 Jun 2024 20:39:42 +0000 Received: from localhost ([127.0.0.1]:55823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEESz-0001t2-Sn for submit@debbugs.gnu.org; Mon, 03 Jun 2024 16:39:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEESy-0001sl-Bt for 70715@debbugs.gnu.org; Mon, 03 Jun 2024 16:39:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEESd-00036H-Gs; Mon, 03 Jun 2024 16:39:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=e4CxWI04GMticzWnPaZu8ZJzmHe326f/X2JwkSf1hMw=; b=h0w1BAxpdOuKl1fU2Nt6 TLCW0Ksi8/hJGOxcm5QH6b+jvcqz3sMcn6A9aoBre1+P6x23hX8pKsDU/UzQ8Wk15vU9NXsvlP4tN wzZe03rMy7GuJd3UBCPj0+rPzChyKVzXt+W5merLO6pP0FI52wAC+B2KxWHg940EQnfheGTVCuYqK YeLHh8EOJwu8nrwdMYkSW978jxE//700t6IobjZ/WNbf5EsbrKg2BjNi9Qw+c6PF6IjkhEwpXfQ3o FO1h8Or3aQGwnkM3O+89X93fVk5WxcDSnrJiglZY3D9PRh3S+zI2JDdZikGgrxpbt52VYx2eekxff RTrEGNQFKN0n0g==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Herman Rimm Subject: Re: [bug#70715] [PATCH v2 3/3] guix: End package descriptions with period. In-Reply-To: (Herman Rimm's message of "Sun, 12 May 2024 21:08:32 +0200") References: Date: Mon, 03 Jun 2024 22:39:15 +0200 Message-ID: <87le3lahho.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70715 Cc: Tanguy Le Carrour , Sharlatan Hellseher , Munyoki Kilyungi , Lars-Dominik Braun , Efraim Flashner , 70715@debbugs.gnu.org, jgart , Marius Bakke , Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Herman Rimm skribis: > * guix/import/utils.scm (beautify-description): Append period to last > words which do not end with one. > * tests/crate.scm: Append period to descriptions. > * tests/elm.scm: Append period to descriptions. > * tests/gem.scm: Append period to descriptions. > * tests/hexpm.scm: Append period to descriptions. > * tests/minetest.scm: Append period to descriptions. > * tests/pypi.scm: Append period to descriptions. I also changed =E2=80=98tests/import-utils.scm=E2=80=99 in a similar way. From unknown Sat Jun 21 03:26:23 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 02 Jul 2024 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator