From unknown Wed Jun 18 23:02:41 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#70708 <70708@debbugs.gnu.org> To: bug#70708 <70708@debbugs.gnu.org> Subject: Status: [PATCH] gnu: hyperrogue: correct font path Reply-To: bug#70708 <70708@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:02:41 +0000 retitle 70708 [PATCH] gnu: hyperrogue: correct font path reassign 70708 guix-patches submitter 70708 Tadhg McDonald-Jensen severity 70708 normal tag 70708 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu May 02 00:40:13 2024 Received: (at submit) by debbugs.gnu.org; 2 May 2024 04:40:14 +0000 Received: from localhost ([127.0.0.1]:41340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2OEv-0008Ra-Hj for submit@debbugs.gnu.org; Thu, 02 May 2024 00:40:13 -0400 Received: from lists.gnu.org ([2001:470:142::17]:44278) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2KhL-0006FK-T6 for submit@debbugs.gnu.org; Wed, 01 May 2024 20:53:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2Kgu-0000Na-P6 for guix-patches@gnu.org; Wed, 01 May 2024 20:52:52 -0400 Received: from mail-qk1-x735.google.com ([2607:f8b0:4864:20::735]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s2Kgt-0007wl-Az for guix-patches@gnu.org; Wed, 01 May 2024 20:52:52 -0400 Received: by mail-qk1-x735.google.com with SMTP id af79cd13be357-79100a90868so272338885a.2 for ; Wed, 01 May 2024 17:52:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714611165; x=1715215965; darn=gnu.org; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=pk9badVjpwXUDnPpOAVPX9f9xaNOSlSvf4PEJQDLs3s=; b=P+qv/ZFJKG3f2CWIbYfqkTnjcS6NXzpw8SpdOj6V1pfkqFy4tYQ45GNg/DOrZ1BKeJ mq1H0DC4eLzCYfiH9hqyqlGsdCzRb4d90+S9Yf2wbpDyiamrmlfIot3GcwDC5fbkz0iR PNJxEbb6Sc6E2gS4sAA8WjTJagYMKIEdMJIlLNjKWKt66CHy9aLALg9SVS5vZoV9HgRe NrZRNs/5ZhdX/NAVDqWKKDTZrz9gL/1P3ba7d6Ngu27m4Ulhb5kH98o398q9j0qazqoL FTd5dgnM2KroYuaxSbmmzJoUU6kWoBXJPmtNz8TdZAX45RPniZ4k5zOrkPe6HJHQQYgx 9zTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714611165; x=1715215965; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=pk9badVjpwXUDnPpOAVPX9f9xaNOSlSvf4PEJQDLs3s=; b=WfYCh3FnKle/qnfbpkmVFyE4GkqS37MQwu6WlfQfDW11lFi7nTNqic69ELOdcUnIBP 4OQnJvPv68hEPVl3myscEkvlpG6a00AhS4VtTysqODxLN16/Z/j/2y436Rpj+Gl4bgbP wZTx4RW2uMKe1tBnMfMWx/R2Pl4C7L/uJa+dcU7h3gVfGdZ/i3nDtAQ70jAEoqlxSfY3 qPvFtv9M23UFd85e45ET6Hk4MJNYpDgTqDH1zautzxnBCGQnss+SZordvr+JS3hhOxxN 8mQ1t0DWf+C+HFNXgMApi31aHws3FwFJrTqoRbPEj0FNkS6pJfSHAMHPum36aQk6r3U2 dAXA== X-Gm-Message-State: AOJu0Yx2HNcN8znFPP4fDtlPcms06qSgS2zQH8vlKXYtyO3zpdtIsveM N/wmHdVevLfi6xrFmRwZ/A3tCBwcI2Qn9p8E8bp3g3xGOvZT1NfutYidPcjT X-Google-Smtp-Source: AGHT+IENQDaUC23s8zvY6q6Fcd7YWNSRFYWNAx1NVIy1CMU2ly93qD6oF927aPvMBGOg5Z+A7FClCA== X-Received: by 2002:ad4:5cc4:0:b0:69b:7eb7:a6ac with SMTP id iu4-20020ad45cc4000000b0069b7eb7a6acmr490291qvb.51.1714611164659; Wed, 01 May 2024 17:52:44 -0700 (PDT) Received: from [192.168.2.11] ([142.188.57.235]) by smtp.gmail.com with ESMTPSA id a12-20020a0ce90c000000b006a0e6008a79sm1671331qvo.133.2024.05.01.17.52.43 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 May 2024 17:52:44 -0700 (PDT) Message-ID: Date: Wed, 1 May 2024 20:52:43 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Content-Language: en-US To: guix-patches@gnu.org From: Tadhg McDonald-Jensen Subject: [PATCH] gnu: hyperrogue: correct font path Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::735; envelope-from=tadhgmister@gmail.com; helo=mail-qk1-x735.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 02 May 2024 00:40:11 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * gnu/packages/games.scm (hyperrogue): correct font path to use font-dejavu package instead of font in hyperrogue source code. Change-Id: I12a108e3fc2375d9bacd1ab1d2ad4e15144b602f --- gnu/packages/games.scm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm index 57e6c23f41..0ebe18c4be 100644 --- a/gnu/packages/games.scm +++ b/gnu/packages/games.scm @@ -6473,9 +6473,9 @@ (define-public hyperrogue (replace 'configure (lambda* (#:key inputs #:allow-other-keys) (let ((share-dir (string-append #$output "/share/hyperrogue/")) - (fonts-dir (dirname - (search-input-file inputs - "DejaVuSans-Bold.ttf")))) + (fonts-dir (string-append + (assoc-ref inputs "font-dejavu") + "/share/fonts/truetype"))) ;; Set fonts and music path. (substitute* "sysconfig.h" (("(#define HYPERPATH ).*" _ lead) base-commit: 4514239971895fc7ad47c7752e30d98a0c44a154 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 20 08:03:55 2025 Received: (at 70708) by debbugs.gnu.org; 20 Feb 2025 13:03:55 +0000 Received: from localhost ([127.0.0.1]:34205 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tl6DZ-0002Hl-Br for submit@debbugs.gnu.org; Thu, 20 Feb 2025 08:03:54 -0500 Received: from mailtransmit05.runbox.com ([2a0c:5a00:149::26]:56886) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tl6DU-0002Fx-5J for 70708@debbugs.gnu.org; Thu, 20 Feb 2025 08:03:49 -0500 Received: from mailtransmit03.runbox ([10.9.9.163] helo=aibo.runbox.com) by mailtransmit05.runbox.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1tl6DL-004cGQ-IU for 70708@debbugs.gnu.org; Thu, 20 Feb 2025 14:03:39 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=futurile.net; s=selector2; h=Content-Type:MIME-Version:Message-ID:Subject: To:From:Date; bh=dLkX0cPqFCk+vRgfy8X/31OZnO9rltQnDWppB72yLNU=; b=f+2krjM7H0wP FT0YD9Xr7XfMcfoQW2Qm2Ep/EAoKvMnYsU7QuZUBYqHEfVyV1mqfYihc3dAtdSkRQCi8EMbA9YEDs Svza+OXFQ6TArMOuZcjK83H4CUPAz0nejAV4MIs8XP5zZwDc/Qqfq8vRvqIcDN1jnT+9tRky2l/tJ GthQ/o0OA8K25u4hXDgG3/hvhRNzmQBd61LljCxW/PyuY8CNQ40QOltGdx3Cz66tKUGmF0h5qT2QE FQrNGN3xHsMiJIW7so1WGccEWUt/ZEZ4xmXAUnm7kxjsfAII1uaboBVew/TfXQrtB+LoOYLvmeMwa Bx6z6CXmq0YjbD9n+yV3ZA==; Received: from [10.9.9.73] (helo=submission02.runbox) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1tl6DL-0005Vw-0h; Thu, 20 Feb 2025 14:03:39 +0100 Received: by submission02.runbox with esmtpsa [Authenticated ID (641962)] (TLS1.2:ECDHE_SECP256R1__RSA_SHA256__AES_256_GCM:256) (Exim 4.93) id 1tl6D9-00FQwN-Cz; Thu, 20 Feb 2025 14:03:27 +0100 Date: Thu, 20 Feb 2025 13:03:25 +0000 From: Steve George To: 70708@debbugs.gnu.org, 70708-submitter@debbugs.gnu.org Subject: RE: hyperrogue: correct font path Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70708 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Tadhg, Your patch in #70708 embeds the font in hyperrogue to be font-dejavu [0]. Can you explain why this is necessary please? I'm not familiar with this game, but I just quickly ran it and the font appeared to be fine in the tutorial. Thanks, Steve / Futurile [0] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70708 From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 20 10:39:51 2025 Received: (at 70708-quiet) by debbugs.gnu.org; 20 Feb 2025 15:39:51 +0000 Received: from localhost ([127.0.0.1]:38252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tl8eU-000327-Kf for submit@debbugs.gnu.org; Thu, 20 Feb 2025 10:39:51 -0500 Received: from mail-qk1-x72b.google.com ([2607:f8b0:4864:20::72b]:55704) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tl8eR-00031G-Gw for 70708-quiet@debbugs.gnu.org; Thu, 20 Feb 2025 10:39:48 -0500 Received: by mail-qk1-x72b.google.com with SMTP id af79cd13be357-7c0a26b1c67so117139885a.3 for <70708-quiet@debbugs.gnu.org>; Thu, 20 Feb 2025 07:39:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740065982; x=1740670782; darn=debbugs.gnu.org; h=in-reply-to:autocrypt:content-language:references:to:subject:from :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=/uGgfOsKNbiWQ/TsKAJ3MAja158NKoHANmxOYRLwjmQ=; b=Xy2AZ/hViHVSlCfUfMxcV8HuNDUjhD2Yz43L94WJJzHCh/5Xcplxn65T+R5ay7w4n9 NGeXCZQLpO8gYDNEzEo1/cj8Ef9zesSBfmFx15wOqz7jTtg6Y9zpFF2+F0Q+gufCHZZE aG+JA+MkZM42yBfX1Q7mx6bve2YHJnZbr87YV4+dtcYyGq+rQoRyH9nuBTiveeh2bbSF OWGc4slXsJggiWm+GUDLmHV3NnueXpu/u2WwGYQ8xur4NU69zKRnewvc4lrBf4jpyRa1 qELAVjpRO+4SmUHPazWTGePSClVJIzpsz/ACJ8MR4ap+TycZzR5udPHZ4A16TZqNzQqT sPLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740065982; x=1740670782; h=in-reply-to:autocrypt:content-language:references:to:subject:from :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=/uGgfOsKNbiWQ/TsKAJ3MAja158NKoHANmxOYRLwjmQ=; b=AjoWVeOa4kXTR6k9nCPbE8+PwmqyhnTJFqUju8Mt062YGDwnevLyaC2lbFYzWlw13Q MkFuIK8A7CgrKkEM7/zCZj9mLpjfBJ6qqvVrdOCKm7anUTKUQofsrzTwL+DJKW1Sc4PZ 1F8wMIlAv20MZ2XstG8UxRpigkTjk9Z0sYWWL3xH/rwSavgCnmtcFiT69an6VMszRRF1 wHbiep/r7Owh1OJn5Te7n2U7BbJGsD/3dePJ9hsbUOgnbQybrOfzz/8pi9vmDrMWqQrb FKJyMpS3p/RB/EKdOJ32PqetwXCl0sUoBMEjxbGZxj2OHEiBF9vVN416aXb4IW+juNbF 6sQQ== X-Forwarded-Encrypted: i=1; AJvYcCXIsI3Xfgqxh0o8XQGBlOKj2Q04rPAMxLfRn2yPhP6um+p3LEXslhuDdyhQQuU4L1Mc9GyP+4/U9k8Khw==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yzfu1c2Lk4NpUhrGFF6GdxSidIenmVDRXxZ+anzlto4Oe1rZt1X CpZ6Zp+nYCIhisHLJpFpXzBOgOYbyrnhQSNJLJYGJe5/oKO5d+o7omQDObzX X-Gm-Gg: ASbGnctq3W5U5kXge8jOfx+UqC3bL99RzYnIkM5HM7nhsGhymOJh63v8nHQUA7V6BZt tbx3EJCN6j6mCnEOO3jsQmMUqwcH9rl30Ruj3egOkguDAwnI/qJvcu3hsyLgNqlUrixHQvMYA+K vRapSNPwV6YeNC6ZmK1uNcONS76BIpnScqcd5HypsPg4BJQiV0zcymuhJ+lQQ+FDw15kRhcUB0N NuQcNa8exRrvI+8iG2faXMFBcDGgAADrUZ9IetRFrfaEfWo2lnVnufOzVESLcRpFhCK7SSI7Sf3 EgPb48KiWM7enWScp/yLjrCysLTuNYnQceTtVV2KgFoMyGsXGxxECe3DY/GIkq+PQbmk X-Google-Smtp-Source: AGHT+IHQtACnhOR5vggvc7vYeUzkZOgd1X5ld46zqHM3crhN6l2nWRYtrMORNWA6K5BHTYh5wDC95g== X-Received: by 2002:a05:6214:2028:b0:6e4:2f4c:f2d2 with SMTP id 6a1803df08f44-6e66cd06504mr361230006d6.31.1740065981630; Thu, 20 Feb 2025 07:39:41 -0800 (PST) Received: from ?IPV6:2001:4958:30cb:fb01:c816:1089:b246:dd01? ([2001:4958:30cb:fb01:c816:1089:b246:dd01]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6e65d9f3f9dsm87209306d6.81.2025.02.20.07.39.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Feb 2025 07:39:40 -0800 (PST) Message-ID: <420d4741-17b1-4478-b32b-e16f200fc4c0@gmail.com> Date: Thu, 20 Feb 2025 10:39:38 -0500 MIME-Version: 1.0 User-Agent: Icedove Daily From: tadhgmister@gmail.com Subject: Re: bug#70708: hyperrogue: correct font path To: Steve George , 70708-quiet@debbugs.gnu.org References: Content-Language: en-US Autocrypt: addr=tadhgmister@gmail.com; keydata= xjMEZ3rpXBYJKwYBBAHaRw8BAQdAYDEhZ488BxMM8Md8rbPVN9LQYm5t0mEbfYA4muH4+TfN LVRhZGhnIE1jRG9uYWxkLUplbnNlbiA8dGFkaGdtaXN0ZXJAZ21haWwuY29tPsKPBBMWCAA3 FiEE9UIQxuXDjUBQBc31hcDI3Lv0TucFAmd66VwFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMB AAAKCRCFwMjcu/RO5yvRAPwIopAhcFwcgpAeh34s1MgV17YZOqpyNfkoj3RP2sW4GwEAk43y 9ATcrGsZg3rrnpo6bmedY8ssPsOPvalB2W8Gyg/OOARneuldEgorBgEEAZdVAQUBAQdAFPa4 7FHJdQf1AlwPz0ewUAPhB4c1pmGJntgFQgTvqGUDAQgHwn4EGBYIACYWIQT1QhDG5cONQFAF zfWFwMjcu/RO5wUCZ3rpXQUJBaOagAIbDAAKCRCFwMjcu/RO58X0AQD3umRLqs0tnYZ1HjK1 FZM7HKaLgW8UBMgk+s+b3bAHHAEA3wlt2RuX9me3oGTi+gSCIsX856/Wx5b7db5SWmG5Ugw= In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------Nal7MSigaJibU04Ad7U0jCBc" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70708-quiet X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------Nal7MSigaJibU04Ad7U0jCBc Content-Type: multipart/mixed; boundary="------------jFNxlYlFqW0CteDiHWn5rkIH"; protected-headers="v1" From: tadhgmister@gmail.com To: Steve George , 70708-quiet@debbugs.gnu.org Message-ID: <420d4741-17b1-4478-b32b-e16f200fc4c0@gmail.com> Subject: Re: bug#70708: hyperrogue: correct font path References: In-Reply-To: --------------jFNxlYlFqW0CteDiHWn5rkIH Content-Type: multipart/mixed; boundary="------------3TfdWxRlLofWSNb3v2SWh5Aj" --------------3TfdWxRlLofWSNb3v2SWh5Aj Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable The game source code includes a copy of the dejavusans.ttf https://github.com/zenorogue/hyperrogue/blob/master/DejaVuSans.ttf Since the source is considered the first input to the package the function `search-input-file` finds it in the games source code and thus the checkout of the code becomes a runtime dependency. This means that the music and sounds folders which are copied to the package build must be downloaded twice (one in checkout and one in built package) to use the game. If you run `guix graph hyperrogue --type=3Dreferences -M 1 | grep checkout` you will see the runtime dependency on the code checkout and if you remove font-dejavu from the dependencies without my patch you will see it still renders text fine in game. With my patch it correctly uses the font from the dejavu package and no longer depends on the checko= ut. If this is intended then at least we should remove the dependency on font-dejavu since it is not used at all and reference the music and sound from the checkout instead of copying it over and then also needing the original. On 2025-02-20 8:03 a.m., Steve George wrote: > Hi Tadhg, >=20 > Your patch in #70708 embeds the font in hyperrogue to be font-dejavu [0= ]. Can you explain why this is necessary please? I'm not familiar with th= is game, but I just quickly ran it and the font appeared to be fine in th= e tutorial. >=20 > Thanks, >=20 > Steve / Futurile >=20 > [0] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D70708 >=20 >=20 --------------3TfdWxRlLofWSNb3v2SWh5Aj Content-Type: application/pgp-keys; name="OpenPGP_0x85C0C8DCBBF44EE7.asc" Content-Disposition: attachment; filename="OpenPGP_0x85C0C8DCBBF44EE7.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEZ3rpXBYJKwYBBAHaRw8BAQdAYDEhZ488BxMM8Md8rbPVN9LQYm5t0mEbfYA4 muH4+TfNLVRhZGhnIE1jRG9uYWxkLUplbnNlbiA8dGFkaGdtaXN0ZXJAZ21haWwu Y29tPsKPBBMWCAA3FiEE9UIQxuXDjUBQBc31hcDI3Lv0TucFAmd66VwFCQWjmoAC GwMECwkIBwUVCAkKCwUWAgMBAAAKCRCFwMjcu/RO5yvRAPwIopAhcFwcgpAeh34s 1MgV17YZOqpyNfkoj3RP2sW4GwEAk43y9ATcrGsZg3rrnpo6bmedY8ssPsOPvalB 2W8Gyg/OOARneuldEgorBgEEAZdVAQUBAQdAFPa47FHJdQf1AlwPz0ewUAPhB4c1 pmGJntgFQgTvqGUDAQgHwn4EGBYIACYWIQT1QhDG5cONQFAFzfWFwMjcu/RO5wUC Z3rpXQUJBaOagAIbDAAKCRCFwMjcu/RO58X0AQD3umRLqs0tnYZ1HjK1FZM7HKaL gW8UBMgk+s+b3bAHHAEA3wlt2RuX9me3oGTi+gSCIsX856/Wx5b7db5SWmG5Ugw=3D =3DmvH2 -----END PGP PUBLIC KEY BLOCK----- --------------3TfdWxRlLofWSNb3v2SWh5Aj-- --------------jFNxlYlFqW0CteDiHWn5rkIH-- --------------Nal7MSigaJibU04Ad7U0jCBc Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQT1QhDG5cONQFAFzfWFwMjcu/RO5wUCZ7dMuwUDAAAAAAAKCRCFwMjcu/RO532s AQC4VSywK8iRUl1EYxmtKprXmS0p51X4UmBmvDELKOjWgwEAhNv223WauZ27k1ePLBMAp23aQOux fzBCA8iHFI6guwI= =1tLx -----END PGP SIGNATURE----- --------------Nal7MSigaJibU04Ad7U0jCBc-- From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 20 14:37:18 2025 Received: (at 70708-quiet) by debbugs.gnu.org; 20 Feb 2025 19:37:18 +0000 Received: from localhost ([127.0.0.1]:41542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tlCMH-0004rH-Eo for submit@debbugs.gnu.org; Thu, 20 Feb 2025 14:37:18 -0500 Received: from mailtransmit04.runbox.com ([2a0c:5a00:149::25]:34108) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tlCMD-0004pk-4J for 70708-quiet@debbugs.gnu.org; Thu, 20 Feb 2025 14:37:15 -0500 Received: from mailtransmit02.runbox ([10.9.9.162] helo=aibo.runbox.com) by mailtransmit04.runbox.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1tlCM4-005l5R-JG for 70708-quiet@debbugs.gnu.org; Thu, 20 Feb 2025 20:37:04 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=futurile.net; s=selector2; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:To:Subject:MIME-Version:Date:Message-ID; bh=kGxaHvqRZJD1ze5C2fcciAXrAf6qxuX7WjOYVZHrovY=; b=H3AtmhMvrP8Nf5cxNxfa9K01bp a+x4p3+B0ZFyxlzbmNwDLn18HjdrwZiH0vwLgUe8cu7UtCkKp7cOlVZUcRW22g7JDijJ56WtrpC9u dWotC61xhnc57IjKgxsu6i2xYWnu4yCG6nyp7G7MUhl+FTKAWGnSuzqxoCNDbcdFJp9oSw+B5u9hb 4MVGncW+u16hivMri8juwaO5KciwirItNhm4aUhyTDRKhwKUJpWJCnGkX28/Atd7G9t7BGyNYVpB+ Ye5Ytj4qarA4LipZhzRK1DNRGsxq7ZZ7MhLhTQ2LDOM5tu5Xo/5j/jCZHElUJp8Ty/5N18+DEX6Oi z8uvhlgQ==; Received: from [10.9.9.74] (helo=submission03.runbox) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1tlCM4-0001Bh-4h; Thu, 20 Feb 2025 20:37:04 +0100 Received: by submission03.runbox with esmtpsa [Authenticated ID (641962)] (TLS1.2:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.93) id 1tlCLx-00GL1C-BA; Thu, 20 Feb 2025 20:36:57 +0100 Message-ID: Date: Thu, 20 Feb 2025 19:36:55 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#70708: hyperrogue: correct font path To: tadhgmister@gmail.com, 70708-quiet@debbugs.gnu.org References: <420d4741-17b1-4478-b32b-e16f200fc4c0@gmail.com> Content-Language: en-US From: Steve George In-Reply-To: <420d4741-17b1-4478-b32b-e16f200fc4c0@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70708-quiet X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi, Ah OK, I understand. In that case would you be up for updating the patch to remove the font files using a snippet please? Thanks, Steve / Futurile On 20/02/2025 15:39, tadhgmister@gmail.com wrote: > The game source code includes a copy of the dejavusans.ttf > https://github.com/zenorogue/hyperrogue/blob/master/DejaVuSans.ttf > > Since the source is considered the first input to the package the > function `search-input-file` finds it in the games source code and thus > the checkout of the code becomes a runtime dependency. This means that > the music and sounds folders which are copied to the package build must > be downloaded twice (one in checkout and one in built package) to use > the game. > > If you run `guix graph hyperrogue --type=references -M 1 | grep > checkout` you will see the runtime dependency on the code checkout and > if you remove font-dejavu from the dependencies without my patch you > will see it still renders text fine in game. With my patch it correctly > uses the font from the dejavu package and no longer depends on the checkout. > > If this is intended then at least we should remove the dependency on > font-dejavu since it is not used at all and reference the music and > sound from the checkout instead of copying it over and then also needing > the original. > > > On 2025-02-20 8:03 a.m., Steve George wrote: >> Hi Tadhg, >> >> Your patch in #70708 embeds the font in hyperrogue to be font-dejavu [0]. Can you explain why this is necessary please? I'm not familiar with this game, but I just quickly ran it and the font appeared to be fine in the tutorial. >> >> Thanks, >> >> Steve / Futurile >> >> [0] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70708 >> From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 27 11:24:44 2025 Received: (at 70708-quiet) by debbugs.gnu.org; 27 Feb 2025 16:24:44 +0000 Received: from localhost ([127.0.0.1]:36649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tnggl-0007sg-RV for submit@debbugs.gnu.org; Thu, 27 Feb 2025 11:24:44 -0500 Received: from mail-qk1-x729.google.com ([2607:f8b0:4864:20::729]:50502) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tnggb-0007rY-Ty for 70708-quiet@debbugs.gnu.org; Thu, 27 Feb 2025 11:24:40 -0500 Received: by mail-qk1-x729.google.com with SMTP id af79cd13be357-7be6fdeee35so213421685a.1 for <70708-quiet@debbugs.gnu.org>; Thu, 27 Feb 2025 08:24:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740673468; x=1741278268; darn=debbugs.gnu.org; h=in-reply-to:autocrypt:content-language:references:to:subject:from :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=/WpfAYZUPZ0UMr/k4AGbBjUlFuruKGoleMDAKys0ddE=; b=c5LqkaIAmyyq11rkAkmcA+8qXSyF+pCbapVQ7rwiTV9+OBNUuMgF7jJRxB+KquGA9D wq/F6lQFM6+XJLJsb2vAYCygvZX3WwMbiMf/lH4A4ryw8GJ0mZtkVxWbF8z+0Zc7OgdP o8sy3vtHXFA6MO2QRRz919a6bt8QqEvhQ3M35KZDHtrwLIyslGnrad+NJvLQhQTapyFO qgckIYlDvJ62/zafeJ9uZZ+t4kepy+p62MKLtaBEekXYQW/fLub9BKXaNxBXXStjBRvo dPZKIEfvzUc1Y2kEzqup0Hrb6FbQcbPucTp+Z+tiOWCjsKIPFG1hsT4yRixOiC19NaM2 JbVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740673468; x=1741278268; h=in-reply-to:autocrypt:content-language:references:to:subject:from :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=/WpfAYZUPZ0UMr/k4AGbBjUlFuruKGoleMDAKys0ddE=; b=hkjXM7YRIOFZLrL6845HEwD1x4QDjxd7DCE8B3KYWGir2oWZf8PSE/oejmxPImY6mM JhvwnXkqcaSxmh0M7wmYLnXwI2Nvj9kDQby7mQb5mjLi7O4ZcJPj8pnrxdF1+8FTS7S2 /M2omE7kw8YlVsTnOL+i46AUSnJeNcSXwgSVYdsSnxjKjkWCBV4W7tQjAStyLCWZz6SH +gvsQC7Asem/K/yhf0XQO3YDp1cjxz6JEO/93ybl16njUdrxElwTHN0Kkyzfn0f3fYph 7QnKE4k/y+cVagbIK6WtGj28KuTETO7G3sgqtj4jTH3wMadILv5OSzLMGFUHtEyHUOdd HnsA== X-Forwarded-Encrypted: i=1; AJvYcCURnXA9WdEHT62UX69etl8elP+m5wPaBbPfLJGhCFchiMTWWP8ZpfgqN/iSLa509Ds0Tynbxlrl4il4Ag==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyhAH0giPkQr353cCCkXQ4p4V1cpIJm0t3FU0PY2brj4X/OBhNP Xri/rEyY4WIXhRrzzR8MIxeBwCjtK0WplQPDExg4DrpV8/QdAOmpaA3uHzP6 X-Gm-Gg: ASbGnctuH1XP+Mxaqx98WVhzx5Ya9q5CXfkC7liR5IiURJ/oUvQNaGk5p4NAituJGx0 t57lUi6bof9Qp/tpKb2OsjWWA2V1Jrc/C9v2Xz3oOvECOV19dqlgK12aQEhdMk7pQtnAPq1ejJD eHwwdab3RMKqbbuHHP4GDHKip+TMizoibXOdcf2jFyUtSEgetLUSXiRE5FQqJQWcSe1N4A+7o8z E74SoNeP84V8r/OCi1YxxoNV1LoIL53PL2KW/UdqmbPBHn8nFFwz74LSmpoGOCal126Pav/bCgR 7HRN958SAzoRJE/cgNU7TIknBjnqJS7E/rcVj749IiRUbTvzYMhRTPiPdiSSTZB9INJqCQY+eVI +TLE= X-Google-Smtp-Source: AGHT+IFH7rH5Sae+bNKZ0eKKn0FDUNIsUP41rqac3HVVbBst5UoyC04DQlVvD4puEi5EcBEVEqzy0g== X-Received: by 2002:a05:620a:4723:b0:7c0:bb63:5376 with SMTP id af79cd13be357-7c23bdff54dmr1704080185a.4.1740673467648; Thu, 27 Feb 2025 08:24:27 -0800 (PST) Received: from ?IPV6:2001:4958:30cb:fb01:c816:1089:b246:dd01? ([2001:4958:30cb:fb01:c816:1089:b246:dd01]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c378d9fe2bsm122561685a.88.2025.02.27.08.24.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Feb 2025 08:24:26 -0800 (PST) Message-ID: <851d48af-f355-4001-87eb-30c94dc28837@gmail.com> Date: Thu, 27 Feb 2025 11:24:25 -0500 MIME-Version: 1.0 User-Agent: Icedove Daily From: tadhgmister@gmail.com Subject: Re: bug#70708: hyperrogue: correct font path To: Steve George , 70708-quiet@debbugs.gnu.org References: <420d4741-17b1-4478-b32b-e16f200fc4c0@gmail.com> Content-Language: en-US Autocrypt: addr=tadhgmister@gmail.com; keydata= xjMEZ3rpXBYJKwYBBAHaRw8BAQdAYDEhZ488BxMM8Md8rbPVN9LQYm5t0mEbfYA4muH4+TfN LVRhZGhnIE1jRG9uYWxkLUplbnNlbiA8dGFkaGdtaXN0ZXJAZ21haWwuY29tPsKPBBMWCAA3 FiEE9UIQxuXDjUBQBc31hcDI3Lv0TucFAmd66VwFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMB AAAKCRCFwMjcu/RO5yvRAPwIopAhcFwcgpAeh34s1MgV17YZOqpyNfkoj3RP2sW4GwEAk43y 9ATcrGsZg3rrnpo6bmedY8ssPsOPvalB2W8Gyg/OOARneuldEgorBgEEAZdVAQUBAQdAFPa4 7FHJdQf1AlwPz0ewUAPhB4c1pmGJntgFQgTvqGUDAQgHwn4EGBYIACYWIQT1QhDG5cONQFAF zfWFwMjcu/RO5wUCZ3rpXQUJBaOagAIbDAAKCRCFwMjcu/RO58X0AQD3umRLqs0tnYZ1HjK1 FZM7HKaLgW8UBMgk+s+b3bAHHAEA3wlt2RuX9me3oGTi+gSCIsX856/Wx5b7db5SWmG5Ugw= In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------TQH1QOO9xoGaF0iT90E29Z0k" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70708-quiet X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------TQH1QOO9xoGaF0iT90E29Z0k Content-Type: multipart/mixed; boundary="------------N5BbPNSq0ZaQEtmroN9yllYD"; protected-headers="v1" From: tadhgmister@gmail.com To: Steve George , 70708-quiet@debbugs.gnu.org Message-ID: <851d48af-f355-4001-87eb-30c94dc28837@gmail.com> Subject: Re: bug#70708: hyperrogue: correct font path References: <420d4741-17b1-4478-b32b-e16f200fc4c0@gmail.com> In-Reply-To: --------------N5BbPNSq0ZaQEtmroN9yllYD Content-Type: multipart/mixed; boundary="------------swv01NLHXwntVR80fN78GVYv" --------------swv01NLHXwntVR80fN78GVYv Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi again, If I just delete the font file the build fails since `search-input-file` doesn't recursively check subfolders to find dejavu/share/fonts/truetype.= If we specify the folder of dejavu as I wrote in my patch then the file in the source will be ignored and I do not understand the benefit of also deleting it. Is there a less hardcoded more general purpose way to identify the folder with the font files? If so I can submit a modified patch to delete the one from source and then detect the appropriate folder from dejavu package but otherwise I feel like the patch I submitted is the best solution. Regards, Tadhg On 2025-02-20 2:36 p.m., Steve George wrote: > Hi, >=20 > Ah OK, I understand. >=20 > In that case would you be up for updating the patch to remove the font = > files using a snippet please? >=20 > Thanks, >=20 > Steve / Futurile >=20 > On 20/02/2025 15:39, tadhgmister@gmail.com wrote: >> The game source code includes a copy of the dejavusans.ttf >> https://github.com/zenorogue/hyperrogue/blob/master/DejaVuSans.ttf >> >> Since the source is considered the first input to the package the >> function `search-input-file` finds it in the games source code and thu= s >> the checkout of the code becomes a runtime dependency. This means that= >> the music and sounds folders which are copied to the package build mus= t >> be downloaded twice (one in checkout and one in built package) to use >> the game. >> >> If you run `guix graph hyperrogue --type=3Dreferences -M 1 | grep >> checkout` you will see the runtime dependency on the code checkout and= >> if you remove font-dejavu from the dependencies without my patch you >> will see it still renders text fine in game. With my patch it correctl= y >> uses the font from the dejavu package and no longer depends on the che= ckout. >> >> If this is intended then at least we should remove the dependency on >> font-dejavu since it is not used at all and reference the music and >> sound from the checkout instead of copying it over and then also needi= ng >> the original. >> >> >> On 2025-02-20 8:03 a.m., Steve George wrote: >>> Hi Tadhg, >>> >>> Your patch in #70708 embeds the font in hyperrogue to be font-dejavu = [0]. Can you explain why this is necessary please? I'm not familiar with = this game, but I just quickly ran it and the font appeared to be fine in = the tutorial. >>> >>> Thanks, >>> >>> Steve / Futurile >>> >>> [0] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D70708 >>> >=20 --------------swv01NLHXwntVR80fN78GVYv Content-Type: application/pgp-keys; name="OpenPGP_0x85C0C8DCBBF44EE7.asc" Content-Disposition: attachment; filename="OpenPGP_0x85C0C8DCBBF44EE7.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEZ3rpXBYJKwYBBAHaRw8BAQdAYDEhZ488BxMM8Md8rbPVN9LQYm5t0mEbfYA4 muH4+TfNLVRhZGhnIE1jRG9uYWxkLUplbnNlbiA8dGFkaGdtaXN0ZXJAZ21haWwu Y29tPsKPBBMWCAA3FiEE9UIQxuXDjUBQBc31hcDI3Lv0TucFAmd66VwFCQWjmoAC GwMECwkIBwUVCAkKCwUWAgMBAAAKCRCFwMjcu/RO5yvRAPwIopAhcFwcgpAeh34s 1MgV17YZOqpyNfkoj3RP2sW4GwEAk43y9ATcrGsZg3rrnpo6bmedY8ssPsOPvalB 2W8Gyg/OOARneuldEgorBgEEAZdVAQUBAQdAFPa47FHJdQf1AlwPz0ewUAPhB4c1 pmGJntgFQgTvqGUDAQgHwn4EGBYIACYWIQT1QhDG5cONQFAFzfWFwMjcu/RO5wUC Z3rpXQUJBaOagAIbDAAKCRCFwMjcu/RO58X0AQD3umRLqs0tnYZ1HjK1FZM7HKaL gW8UBMgk+s+b3bAHHAEA3wlt2RuX9me3oGTi+gSCIsX856/Wx5b7db5SWmG5Ugw=3D =3DmvH2 -----END PGP PUBLIC KEY BLOCK----- --------------swv01NLHXwntVR80fN78GVYv-- --------------N5BbPNSq0ZaQEtmroN9yllYD-- --------------TQH1QOO9xoGaF0iT90E29Z0k Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQT1QhDG5cONQFAFzfWFwMjcu/RO5wUCZ8CRuQUDAAAAAAAKCRCFwMjcu/RO57wg AP90U07Tj3VWFnRZoqXRlqPv+CgRs5CSCH1SCVeAE47tpAD/Z8u+Eb4rSLDO4YkFm0wF7houwuhw kf6yRMeDey2CsQM= =vwLv -----END PGP SIGNATURE----- --------------TQH1QOO9xoGaF0iT90E29Z0k-- From debbugs-submit-bounces@debbugs.gnu.org Mon May 05 10:54:24 2025 Received: (at 70708-quiet) by debbugs.gnu.org; 5 May 2025 14:54:24 +0000 Received: from localhost ([127.0.0.1]:41480 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uBxD6-0003TO-4A for submit@debbugs.gnu.org; Mon, 05 May 2025 10:54:24 -0400 Received: from mail-qt1-x835.google.com ([2607:f8b0:4864:20::835]:53292) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uBxD2-0003T7-9C for 70708-quiet@debbugs.gnu.org; Mon, 05 May 2025 10:54:20 -0400 Received: by mail-qt1-x835.google.com with SMTP id d75a77b69052e-476af5479feso54119661cf.2 for <70708-quiet@debbugs.gnu.org>; Mon, 05 May 2025 07:54:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746456854; x=1747061654; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=5JFKPegILHGQnlQ6RX1qt5GQSqCW01OAOEJrOZnmtOM=; b=BWgfwZGrCCoS78+bvCjHWLUxFYrjVcO87fx2nfeAKwzXBbwriyZvgRbTVaRtjYIMFm sNpxmALyrHXalIzQaTVCIQHMLzWaUWRoJl5FjusEb2+n/V83sQHWswwTnJ1RFaqtNttE 5hqkxq9+BrSTk7NSEY5Sgz1Y5oMOsIxjAcJ5583JDR+c1/dMAnDT3LCAwzcIphxLGri5 ioGQE43Ox6hcikYqLKoOXw5/Zsr6x8RW0NnJApAHtUux6SnpZIU22lTIdMUgLs0x9o0n tIxmp05dVaig741wYlmQZhj168ev89V9QEz6SN4hy920Eo50Bb8v6ITcN2fCixZEk5l1 TWYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746456854; x=1747061654; h=content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5JFKPegILHGQnlQ6RX1qt5GQSqCW01OAOEJrOZnmtOM=; b=u8078XmlG2360B8XpqGwRZtXFe3oIOQJ8gOqOCtXCc8cr21vUA20tt51UjJAwJpeBV TmyX3LfNf5569f7XowtHcefuJpPivRaPmXKOkGg0eEACsv2VbYC3ztOfnIkJ0SDWjxgR IfFbvSyPxhroqva1OBNOVv7QjD2H0Ifm4rIQ85G7uWMpS1QM9CR5Mg+s75oKygQwWuwU OqU3XOf1r0FxORDTABRB+NDarptXC7K9IWxiYhP1Ey1cXADHJKFb87t78Dj7jU4MHS4P 8oxUZgSloGtDgB41gprF0I2vCrKhA9tOSVAql08Zt3VglEQeMtz0pXS1zXN6Iw5oMeEG axhA== X-Forwarded-Encrypted: i=1; AJvYcCWDwcB71JBd4fGevtAc2ia4AmQjNv3LSdaBzbE4tNrOcSV3pGkHCOL+tQXSAVlHaVmhlxDQyxaeGw3msA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyUHNEeuCTO9hDX57jyWvmessG5sYQFu0fWZNY7Nm6LjWSAxwp1 /JWyHYal+T6DRxIkW0Q/oPh+D4kvNSdfcDGCbr+RSFZ3Tcl2HQTwnDB0nMGz/RJgew== X-Gm-Gg: ASbGnctq+gzNCyhuCVW7Ki17rHh7v+tjwUIp5zBDKORHo7Qr0aTQ9NETWKiVJ/3cPZ/ VABjo8Dm0BCl3VQpFG0KpurSDlOlMGCRZ+pvbHlLB9NJuWh7U9asX0+18KriNlL6TRva5JLYQgh CQeZ66i+TLFhtUrRcBCWY+n65sNZFUnbtTQpqnlsa8PwpTWPTMSblv7xfwXpvMxoDh2s8jlrysn nT0hlazNTvOLBkcYISTqjzygsrQLUH7FGxpIXGPEgevCGsnDmAvHmCv3q3QEHPbml/uZEPdM3E0 N2TGxcCoNEgrfKV9EwIiu56ADRVWSMBqvtENpGKchU+juDgMfL+JBUk= X-Google-Smtp-Source: AGHT+IEHAkfr7saVXtg18COzuYqms71MUPTUlBb1LBsEJh37RMFItVJt/ahIj1cARC2+FW88oYIQDQ== X-Received: by 2002:ac8:6f05:0:b0:47a:e0d6:f97c with SMTP id d75a77b69052e-48e01059609mr143028411cf.37.1746456854447; Mon, 05 May 2025 07:54:14 -0700 (PDT) Received: from [192.168.2.11] ([70.50.103.66]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-48b96ad246csm58516631cf.34.2025.05.05.07.54.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 May 2025 07:54:13 -0700 (PDT) Message-ID: <8815f888-998f-4afa-af35-fe7214f3037a@gmail.com> Date: Mon, 5 May 2025 10:54:03 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#70708: hyperrogue: correct font path From: Tadhg McDonald-Jensen To: Steve George , 70708-quiet@debbugs.gnu.org References: <420d4741-17b1-4478-b32b-e16f200fc4c0@gmail.com> <851d48af-f355-4001-87eb-30c94dc28837@gmail.com> Content-Language: en-US In-Reply-To: <851d48af-f355-4001-87eb-30c94dc28837@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70708-quiet X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) apparently HYPERFONTPATH was added in version 12.0 to make packaging easier for fedora and then removed again (commit cc3863d) in version 13.0. As such just updating the package to a newer version should inherently fix this issue although I'd have to take a closer look at how files are loaded to do the update myself. On 2025-02-27 11:24 a.m., tadhgmister@gmail.com wrote: > Hi again, > > If I just delete the font file the build fails since `search-input-file` > doesn't recursively check subfolders to find dejavu/share/fonts/truetype. > > If we specify the folder of dejavu as I wrote in my patch then the file > in the source will be ignored and I do not understand the benefit of > also deleting it. > > Is there a less hardcoded more general purpose way to identify the > folder with the font files? If so I can submit a modified patch to > delete the one from source and then detect the appropriate folder from > dejavu package but otherwise I feel like the patch I submitted is the > best solution. > > Regards, > Tadhg > > > On 2025-02-20 2:36 p.m., Steve George wrote: >> Hi, >> >> Ah OK, I understand. >> >> In that case would you be up for updating the patch to remove the font >> files using a snippet please? >> >> Thanks, >> >> Steve / Futurile >> >> On 20/02/2025 15:39, tadhgmister@gmail.com wrote: >>> The game source code includes a copy of the dejavusans.ttf >>> https://github.com/zenorogue/hyperrogue/blob/master/DejaVuSans.ttf >>> >>> Since the source is considered the first input to the package the >>> function `search-input-file` finds it in the games source code and thus >>> the checkout of the code becomes a runtime dependency. This means that >>> the music and sounds folders which are copied to the package build must >>> be downloaded twice (one in checkout and one in built package) to use >>> the game. >>> >>> If you run `guix graph hyperrogue --type=references -M 1 | grep >>> checkout` you will see the runtime dependency on the code checkout and >>> if you remove font-dejavu from the dependencies without my patch you >>> will see it still renders text fine in game. With my patch it correctly >>> uses the font from the dejavu package and no longer depends on the checkout. >>> >>> If this is intended then at least we should remove the dependency on >>> font-dejavu since it is not used at all and reference the music and >>> sound from the checkout instead of copying it over and then also needing >>> the original. >>> >>> >>> On 2025-02-20 8:03 a.m., Steve George wrote: >>>> Hi Tadhg, >>>> >>>> Your patch in #70708 embeds the font in hyperrogue to be font-dejavu [0]. Can you explain why this is necessary please? I'm not familiar with this game, but I just quickly ran it and the font appeared to be fine in the tutorial. >>>> >>>> Thanks, >>>> >>>> Steve / Futurile >>>> >>>> [0] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70708 >>>>