GNU bug report logs - #70707
30.0.50; [PATCH] ; Check the process param in function (python-shell-completion-at-point)

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#70707: closed (30.0.50; [PATCH] ; Check the process param in
 function (python-shell-completion-at-point))
Date: Thu, 09 May 2024 08:00:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 09 May 2024 10:58:30 +0300
with message-id <86h6f776xl.fsf <at> gnu.org>
and subject line Re: bug#70707: 30.0.50; [PATCH] ; Check the process param in function (python-shell-completion-at-point)
has caused the debbugs.gnu.org bug report #70707,
regarding 30.0.50; [PATCH] ; Check the process param in function (python-shell-completion-at-point)
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
70707: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70707
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Lin Sun <sunlin7.mail <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; [PATCH] ; Check the process param in function
 (python-shell-completion-at-point)
Date: Wed, 1 May 2024 22:49:29 +0000

[Message part 3 (text/plain, inline)]

Hi,

There is an unexpected error message happening with function
`python-shell-completion-at-point`.
> Wrong type argument: processp, nil
It happened because the function does NOT check the process param.
The patch will check the param and display a user error message gracefully.

Steps to reproduce the issue.
1. $ emacs -q /tmp/a.py # start emacs and open a python source file
2. type "C-c C-p" (or M-x run-python) to start a python shell
3. type exit() to stop the python process but the buffer still exists
4. M-x python-shell-completion-at-point  will get the error message

Please help review the patch. Thanks. Regards

[0001-Check-the-process-param-in-function-python-shell-com.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: kobarity <kobarity <at> gmail.com>
Cc: 70707-done <at> debbugs.gnu.org, sunlin7.mail <at> gmail.com
Subject: Re: bug#70707: 30.0.50; [PATCH] ; Check the process param in function
 (python-shell-completion-at-point)
Date: Thu, 09 May 2024 10:58:30 +0300

> Cc: 70707 <at> debbugs.gnu.org
> Date: Tue, 07 May 2024 00:12:10 +0900
> From: kobarity <kobarity <at> gmail.com>
> 
> > Hi Kobarity, Please help review the patch for checking process and
> > emitting user-error when it's not available. Thanks.
> 
> Hi Lin,
> 
> The patch itself looks good to me.

Thanks, installed on master, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.