GNU bug report logs - #70693
[PATCH] gnu: nss/fixed: Tweak performance test.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#70693: closed ([PATCH] gnu: nss/fixed: Tweak performance test.)
Date: Mon, 13 May 2024 12:45:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 13 May 2024 13:44:21 +0100
with message-id <871q6551ay.fsf <at> cbaines.net>
and subject line Re: [bug#70693] [PATCH v3 1/3] gnu: nss/fixed: Tweak performance test.
has caused the debbugs.gnu.org bug report #70693,
regarding [PATCH] gnu: nss/fixed: Tweak performance test.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
70693: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70693
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: nss/fixed: Tweak performance test.
Date: Wed,  1 May 2024 10:41:45 +0100

As I'm seeing this test fail with results of 5 to 7 seconds.

* gnu/packages/nss.scm (nss/fixed)[arguments]: Tweak a test to have a higher
time threshold.

Change-Id: Icb0551cd986acf67b2ba17dc8772a67b9747d31a
---
 gnu/packages/nss.scm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/gnu/packages/nss.scm b/gnu/packages/nss.scm
index 162e748094..60bc4d52de 100644
--- a/gnu/packages/nss.scm
+++ b/gnu/packages/nss.scm
@@ -280,6 +280,14 @@ (define-public nss/fixed
                          (setenv "USE_IP" "TRUE")
                          (setenv "IP_ADDRESS" "127.0.0.1")
 
+                         ;; This specific test is looking at performance "now
+                         ;; verify that we can quickly dump a database", and
+                         ;; we're not testing performance here (especially
+                         ;; since we're using faketime), so raise the
+                         ;; threshold
+                         (substitute* "tests/dbtests/dbtests.sh"
+                           ((" -lt 5") " -lt 50"))
+
                          ;; The "PayPalEE.cert" certificate expires every six months,
                          ;; leading to test failures:
                          ;; <https://bugzilla.mozilla.org/show_bug.cgi?id=609734>.  To

base-commit: 7d4ae2fca723114fb1df56de33b82177fbc4d0a6
-- 
2.41.0

[Message part 3 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: 70693-done <at> debbugs.gnu.org
Subject: Re: [bug#70693] [PATCH v3 1/3] gnu: nss/fixed: Tweak performance test.
Date: Mon, 13 May 2024 13:44:21 +0100

[Message part 4 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi!
>
> LGTM to me, please push!

Things are building, so I've pushed this to master as
7b0f145802f0c2c785014293d748721678fef824.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.