GNU bug report logs - #70680
[PATCH 1/1] * gnu/packages/golang.scm (go-1.22): Disable flakey tests.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
Subject: bug#70680: closed ([PATCH 1/1] * gnu/packages/golang.scm
 (go-1.22): Disable flakey tests. )
Date: Tue, 14 May 2024 10:52:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#70680: [PATCH 1/1] * gnu/packages/golang.scm (go-1.22): Disable flakey tests.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 70680 <at> debbugs.gnu.org.

-- 
70680: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70680
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 70680-done <at> debbugs.gnu.org
Subject: [PATCH 1/1] * gnu/packages/golang.scm (go-1.22): Disable flakey
 tests. 
Date: Tue, 14 May 2024 11:50:16 +0100

[Message part 3 (text/plain, inline)]

Pushed as 6fab2d5b318fb0a8a0887f6ce0ac3e342a8c23ef to go-team.

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
Subject: [PATCH 1/1] * gnu/packages/golang.scm (go-1.22): Disable flakey tests.
Date: Tue, 30 Apr 2024 11:54:08 -0600

---
 gnu/packages/golang.scm | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 4ce6f5ea6b..99d83dd104 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -12,7 +12,7 @@
 ;;; Copyright © 2018 Tomáš Čech <sleep_walker <at> gnu.org>
 ;;; Copyright © 2018 Pierre-Antoine Rouby <pierre-antoine.rouby <at> inria.fr>
 ;;; Copyright © 2018 Pierre Neidhardt <mail <at> ambrevar.xyz>
-;;; Copyright © 2018, 2019, 2020, 2023 Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
+;;; Copyright © 2018, 2019, 2020, 2023, 2024 Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
 ;;; Copyright © 2019 Giovanni Biscuolo <g <at> xelera.eu>
 ;;; Copyright © 2019, 2020 Alex Griffin <a <at> ajgrf.com>
 ;;; Copyright © 2019, 2020, 2021 Arun Isaac <arunisaac <at> systemreboot.net>
@@ -971,7 +971,13 @@ (define-public go-1.22
                 ;; to perl input in sourcecode generators and test scripts
                 (substitute* (find-files "src" "\\.pl$")
                   (("^#!.*")
-                   "#!/usr/bin/env perl\n"))))))))
+                   "#!/usr/bin/env perl\n"))))
+            (add-after 'unpack 'remove-flakey-thread-sanitizer-tests
+              (lambda _
+                ;; These tests have been identified as flakey:
+                ;; https://github.com/golang/go/issues/66427
+                (substitute* "src/cmd/cgo/internal/testsanitizers/tsan_test.go"
+                  ((".*tsan1[34].*") ""))))))))
     (native-inputs
      ;; Go 1.22 and later requires Go 1.20 (min. 1.20.6, which we don't have)
      ;; as the bootstrap toolchain.

base-commit: 8dab3df9529387ec1459d5483ac9664969c52e78
-- 
2.41.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.