From unknown Tue Jun 17 01:43:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7067: [PATCH] build: use gnulib's new termios module Resent-From: Jim Meyering Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 18 Sep 2010 19:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 7067 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: 7067@debbugs.gnu.org X-Debbugs-Original-To: bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.128483829210951 (code B ref -1); Sat, 18 Sep 2010 19:32:02 +0000 Received: (at submit) by debbugs.gnu.org; 18 Sep 2010 19:31:32 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ox38F-0002qa-SM for submit@debbugs.gnu.org; Sat, 18 Sep 2010 15:31:32 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ox38E-0002qR-Ak for submit@debbugs.gnu.org; Sat, 18 Sep 2010 15:31:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Ox3AX-0002NF-Tv for submit@debbugs.gnu.org; Sat, 18 Sep 2010 15:33:55 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:46806) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ox3AX-0002Mz-S1 for submit@debbugs.gnu.org; Sat, 18 Sep 2010 15:33:53 -0400 Received: from [140.186.70.92] (port=38520 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ox33w-0003Cv-JY for bug-coreutils@gnu.org; Sat, 18 Sep 2010 15:27:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Ox33i-00013q-1J for bug-coreutils@gnu.org; Sat, 18 Sep 2010 15:26:50 -0400 Received: from smtp1-g21.free.fr ([212.27.42.1]:49450) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ox33h-00013E-FJ for bug-coreutils@gnu.org; Sat, 18 Sep 2010 15:26:50 -0400 Received: from mx.meyering.net (unknown [82.230.74.64]) by smtp1-g21.free.fr (Postfix) with ESMTP id 22E85940128 for ; Sat, 18 Sep 2010 21:26:43 +0200 (CEST) Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id EA6FEAA7; Sat, 18 Sep 2010 21:26:42 +0200 (CEST) From: Jim Meyering Date: Sat, 18 Sep 2010 21:26:42 +0200 Message-ID: <878w2yluod.fsf@meyering.net> Lines: 93 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.2 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.2 (-----) Updating to the latest gnulib would have provoked this new syntax-check failure in coreutils: src/ls.c:42:#if HAVE_TERMIOS_H src/stty.c:39:#if HAVE_TERMIOS_H maint.mk: do not test the above HAVE_
_H symbol(s);\n with the corresponding gnulib module, they are always true make[3]: *** [sc_prohibit_always_true_header_tests] Error 1 That is easy to fix, along with the stray "\n" in the diagnostic. Here's the coreutils fix: I'll post the gnulib fix for maint.mk and a few unexpanded \n's to bug-gnulib separately. >From c53eabf7090121b62cd49b0379727e9602fe8aa9 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sat, 18 Sep 2010 20:24:41 +0200 Subject: [PATCH] build: use gnulib's new termios module With it, we can remove the two sole tests of HAVE_TERMIOS_H. * bootstrap.conf (gnulib_modules): Add termios. * src/ls.c: Don't test HAVE_TERMIOS_H. * src/stty.c: Likewise. * m4/jm-macros.m4 (gl_CHECK_ALL_TYPES): Remove configure-time test for termios.h. --- bootstrap.conf | 1 + m4/jm-macros.m4 | 3 +-- src/ls.c | 4 +--- src/stty.c | 4 +--- 4 files changed, 4 insertions(+), 8 deletions(-) diff --git a/bootstrap.conf b/bootstrap.conf index e84424a..920fe63 100644 --- a/bootstrap.conf +++ b/bootstrap.conf @@ -207,6 +207,7 @@ gnulib_modules=" sys_ioctl sys_stat sys_wait + termios timespec tzset uname diff --git a/m4/jm-macros.m4 b/m4/jm-macros.m4 index 20b9af9..6faf08a 100644 --- a/m4/jm-macros.m4 +++ b/m4/jm-macros.m4 @@ -1,4 +1,4 @@ -#serial 109 -*- autoconf -*- +#serial 110 -*- autoconf -*- dnl Misc type-related macros for coreutils. @@ -176,7 +176,6 @@ AC_DEFUN([gl_CHECK_ALL_HEADERS], sys/resource.h \ sys/systeminfo.h \ syslog.h \ - termios.h \ ) AC_CHECK_HEADERS([sys/sysctl.h], [], [], [AC_INCLUDES_DEFAULT diff --git a/src/ls.c b/src/ls.c index 6e3e836..f861df9 100644 --- a/src/ls.c +++ b/src/ls.c @@ -39,9 +39,7 @@ #include #include -#if HAVE_TERMIOS_H -# include -#endif +#include #if HAVE_STROPTS_H # include #endif diff --git a/src/stty.c b/src/stty.c index 71045c2..5d9d4f0 100644 --- a/src/stty.c +++ b/src/stty.c @@ -36,9 +36,7 @@ #include #include -#if HAVE_TERMIOS_H -# include -#endif +#include #if HAVE_STROPTS_H # include #endif -- 1.7.3.rc2.225.g4a2a From unknown Tue Jun 17 01:43:12 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Jim Meyering Subject: bug#7067: closed (Re: bug#7067: [PATCH] build: use gnulib's new termios module) Message-ID: References: <87wrqgevpy.fsf@meyering.net> <878w2yluod.fsf@meyering.net> X-Gnu-PR-Message: they-closed 7067 X-Gnu-PR-Package: coreutils X-Gnu-PR-Keywords: patch Reply-To: 7067@debbugs.gnu.org Date: Mon, 20 Sep 2010 07:09:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1284966542-5414-1" This is a multi-part message in MIME format... ------------=_1284966542-5414-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #7067: [PATCH] build: use gnulib's new termios module which was filed against the coreutils package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 7067@debbugs.gnu.org. --=20 7067: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D7067 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1284966542-5414-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 7067-done) by debbugs.gnu.org; 20 Sep 2010 07:08:09 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OxaTx-0001P4-3p for submit@debbugs.gnu.org; Mon, 20 Sep 2010 03:08:09 -0400 Received: from mx.meyering.net ([82.230.74.64]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OxaTs-0001Oh-P5 for 7067-done@debbugs.gnu.org; Mon, 20 Sep 2010 03:08:06 -0400 Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id 1DF19DB25; Mon, 20 Sep 2010 09:10:33 +0200 (CEST) From: Jim Meyering To: 7067-done@debbugs.gnu.org Subject: Re: bug#7067: [PATCH] build: use gnulib's new termios module In-Reply-To: <878w2yluod.fsf@meyering.net> (Jim Meyering's message of "Sat, 18 Sep 2010 21:26:42 +0200") References: <878w2yluod.fsf@meyering.net> Date: Mon, 20 Sep 2010 09:10:33 +0200 Message-ID: <87wrqgevpy.fsf@meyering.net> Lines: 23 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.2 (-----) X-Debbugs-Envelope-To: 7067-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.2 (-----) Jim Meyering wrote: > Updating to the latest gnulib would have provoked this new syntax-check > failure in coreutils: > > src/ls.c:42:#if HAVE_TERMIOS_H > src/stty.c:39:#if HAVE_TERMIOS_H > maint.mk: do not test the above HAVE_
_H symbol(s);\n with the corresponding gnulib module, they are always true > make[3]: *** [sc_prohibit_always_true_header_tests] Error 1 > > That is easy to fix, along with the stray "\n" in the diagnostic. > Here's the coreutils fix: > I'll post the gnulib fix for maint.mk and a few unexpanded \n's > to bug-gnulib separately. > ... > Subject: [PATCH] build: use gnulib's new termios module FYI, I've pushed that and a few other build tweaks: [PATCH 1/4] maint: don't use obsolete gnulib modules [PATCH 2/4] build: use gnulib's new termios module [PATCH 3/4] tests: sync tests/init.sh from gnulib [PATCH 4/4] build: update gnulib submodule to latest ------------=_1284966542-5414-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 18 Sep 2010 19:31:32 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ox38F-0002qa-SM for submit@debbugs.gnu.org; Sat, 18 Sep 2010 15:31:32 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ox38E-0002qR-Ak for submit@debbugs.gnu.org; Sat, 18 Sep 2010 15:31:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Ox3AX-0002NF-Tv for submit@debbugs.gnu.org; Sat, 18 Sep 2010 15:33:55 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:46806) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ox3AX-0002Mz-S1 for submit@debbugs.gnu.org; Sat, 18 Sep 2010 15:33:53 -0400 Received: from [140.186.70.92] (port=38520 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ox33w-0003Cv-JY for bug-coreutils@gnu.org; Sat, 18 Sep 2010 15:27:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Ox33i-00013q-1J for bug-coreutils@gnu.org; Sat, 18 Sep 2010 15:26:50 -0400 Received: from smtp1-g21.free.fr ([212.27.42.1]:49450) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ox33h-00013E-FJ for bug-coreutils@gnu.org; Sat, 18 Sep 2010 15:26:50 -0400 Received: from mx.meyering.net (unknown [82.230.74.64]) by smtp1-g21.free.fr (Postfix) with ESMTP id 22E85940128 for ; Sat, 18 Sep 2010 21:26:43 +0200 (CEST) Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id EA6FEAA7; Sat, 18 Sep 2010 21:26:42 +0200 (CEST) From: Jim Meyering To: bug-coreutils@gnu.org Subject: [PATCH] build: use gnulib's new termios module Date: Sat, 18 Sep 2010 21:26:42 +0200 Message-ID: <878w2yluod.fsf@meyering.net> Lines: 93 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.2 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.2 (-----) Updating to the latest gnulib would have provoked this new syntax-check failure in coreutils: src/ls.c:42:#if HAVE_TERMIOS_H src/stty.c:39:#if HAVE_TERMIOS_H maint.mk: do not test the above HAVE_
_H symbol(s);\n with the corresponding gnulib module, they are always true make[3]: *** [sc_prohibit_always_true_header_tests] Error 1 That is easy to fix, along with the stray "\n" in the diagnostic. Here's the coreutils fix: I'll post the gnulib fix for maint.mk and a few unexpanded \n's to bug-gnulib separately. >From c53eabf7090121b62cd49b0379727e9602fe8aa9 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sat, 18 Sep 2010 20:24:41 +0200 Subject: [PATCH] build: use gnulib's new termios module With it, we can remove the two sole tests of HAVE_TERMIOS_H. * bootstrap.conf (gnulib_modules): Add termios. * src/ls.c: Don't test HAVE_TERMIOS_H. * src/stty.c: Likewise. * m4/jm-macros.m4 (gl_CHECK_ALL_TYPES): Remove configure-time test for termios.h. --- bootstrap.conf | 1 + m4/jm-macros.m4 | 3 +-- src/ls.c | 4 +--- src/stty.c | 4 +--- 4 files changed, 4 insertions(+), 8 deletions(-) diff --git a/bootstrap.conf b/bootstrap.conf index e84424a..920fe63 100644 --- a/bootstrap.conf +++ b/bootstrap.conf @@ -207,6 +207,7 @@ gnulib_modules=" sys_ioctl sys_stat sys_wait + termios timespec tzset uname diff --git a/m4/jm-macros.m4 b/m4/jm-macros.m4 index 20b9af9..6faf08a 100644 --- a/m4/jm-macros.m4 +++ b/m4/jm-macros.m4 @@ -1,4 +1,4 @@ -#serial 109 -*- autoconf -*- +#serial 110 -*- autoconf -*- dnl Misc type-related macros for coreutils. @@ -176,7 +176,6 @@ AC_DEFUN([gl_CHECK_ALL_HEADERS], sys/resource.h \ sys/systeminfo.h \ syslog.h \ - termios.h \ ) AC_CHECK_HEADERS([sys/sysctl.h], [], [], [AC_INCLUDES_DEFAULT diff --git a/src/ls.c b/src/ls.c index 6e3e836..f861df9 100644 --- a/src/ls.c +++ b/src/ls.c @@ -39,9 +39,7 @@ #include #include -#if HAVE_TERMIOS_H -# include -#endif +#include #if HAVE_STROPTS_H # include #endif diff --git a/src/stty.c b/src/stty.c index 71045c2..5d9d4f0 100644 --- a/src/stty.c +++ b/src/stty.c @@ -36,9 +36,7 @@ #include #include -#if HAVE_TERMIOS_H -# include -#endif +#include #if HAVE_STROPTS_H # include #endif -- 1.7.3.rc2.225.g4a2a ------------=_1284966542-5414-1--