GNU bug report logs - #70623
[PATCH 0/2] fcitx5-configtool: enable kcm and remove inputs label

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 70623 in the body.
You can then email your comments to 70623 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/2] fcitx5-configtool: enable kcm and remove inputs label
Date: Sun, 28 Apr 2024 14:45:23 +0800

Zheng Junjie (2):
  gnu: fcitx5-configtool: Enable kcm support.
  gnu: fcitx5-configtool: Remove inputs label.

 gnu/packages/fcitx5.scm | 37 ++++++++++++++++++++++---------------
 1 file changed, 22 insertions(+), 15 deletions(-)


base-commit: 4178eaf3b2eeea8f6c2e49b1d65cd60a1663c4a9
-- 
2.41.0

Message #8 received at 70623 <at> debbugs.gnu.org (full text, mbox):

From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: 70623 <at> debbugs.gnu.org
Subject: [PATCH 1/2] gnu: fcitx5-configtool: Enable kcm support.
Date: Sun, 28 Apr 2024 14:52:16 +0800

* gnu/packages/fcitx5.scm (fcitx5-configtool)
[arguments]: Remove it.
[inputs]: Add qtdeclarative, qtquickcontrols2, ki18n, kpackage, kdeclarative,
kiconthemes, kcoreaddons, plasma-framework, kwindowsystem, kirigami, libxkbcommon.

Change-Id: I43a43458232a5ad3c1d156c779359e356cbf98b8
---
 gnu/packages/fcitx5.scm | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/fcitx5.scm b/gnu/packages/fcitx5.scm
index 435ccde45f..6e2f922c37 100644
--- a/gnu/packages/fcitx5.scm
+++ b/gnu/packages/fcitx5.scm
@@ -439,17 +439,24 @@ (define-public fcitx5-configtool
        (sha256
         (base32 "1pnwrj6kgha91djfvd2439nbhrmjargpw8ashhb91y5h3cdz7vhz"))))
     (build-system cmake-build-system)
-    (arguments
-     `(#:configure-flags
-       ;; KDE is currently not working on Guix, KCM supports doesn't make sense.
-       '("-DENABLE_KCM=Off")))
     (inputs
      `(("fcitx5" ,fcitx5)
        ("fcitx5-qt" ,fcitx5-qt)
        ("qtbase" ,qtbase-5)
        ("qtx11extras" ,qtx11extras)
+       ("qtdeclarative" ,qtdeclarative-5)
+       ("qtquickcontrols2" ,qtquickcontrols2-5)
+       ("ki18n" ,ki18n)
+       ("kpackage" ,kpackage)
+       ("kdeclarative" ,kdeclarative)
+       ("kiconthemes" ,kiconthemes)
+       ("kcoreaddons" ,kcoreaddons)
+       ("plasma-framework" ,plasma-framework)
        ("kitemviews" ,kitemviews)
        ("kwidgetsaddons" ,kwidgetsaddons)
+       ("kwindowsystem" ,kwindowsystem)
+       ("kirigami" ,kirigami)
+       ("libxkbcommon" ,libxkbcommon)
        ("libx11" ,libx11)
        ("xkeyboard-config" ,xkeyboard-config)
        ("libxkbfile" ,libxkbfile)
-- 
2.41.0

Message #11 received at 70623 <at> debbugs.gnu.org (full text, mbox):

From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: 70623 <at> debbugs.gnu.org
Subject: [PATCH 2/2] gnu: fcitx5-configtool: Remove inputs label.
Date: Sun, 28 Apr 2024 14:52:17 +0800

* gnu/packages/fcitx5.scm (fcitx5-configtool)
[inputs]: Remove label.

Change-Id: Ib45fbf71d5f2ffbac3285e388629b6cf0ca004fe
---
 gnu/packages/fcitx5.scm | 44 ++++++++++++++++++++---------------------
 1 file changed, 22 insertions(+), 22 deletions(-)

diff --git a/gnu/packages/fcitx5.scm b/gnu/packages/fcitx5.scm
index 6e2f922c37..aba0be21e7 100644
--- a/gnu/packages/fcitx5.scm
+++ b/gnu/packages/fcitx5.scm
@@ -440,28 +440,28 @@ (define-public fcitx5-configtool
         (base32 "1pnwrj6kgha91djfvd2439nbhrmjargpw8ashhb91y5h3cdz7vhz"))))
     (build-system cmake-build-system)
     (inputs
-     `(("fcitx5" ,fcitx5)
-       ("fcitx5-qt" ,fcitx5-qt)
-       ("qtbase" ,qtbase-5)
-       ("qtx11extras" ,qtx11extras)
-       ("qtdeclarative" ,qtdeclarative-5)
-       ("qtquickcontrols2" ,qtquickcontrols2-5)
-       ("ki18n" ,ki18n)
-       ("kpackage" ,kpackage)
-       ("kdeclarative" ,kdeclarative)
-       ("kiconthemes" ,kiconthemes)
-       ("kcoreaddons" ,kcoreaddons)
-       ("plasma-framework" ,plasma-framework)
-       ("kitemviews" ,kitemviews)
-       ("kwidgetsaddons" ,kwidgetsaddons)
-       ("kwindowsystem" ,kwindowsystem)
-       ("kirigami" ,kirigami)
-       ("libxkbcommon" ,libxkbcommon)
-       ("libx11" ,libx11)
-       ("xkeyboard-config" ,xkeyboard-config)
-       ("libxkbfile" ,libxkbfile)
-       ("gettext" ,gettext-minimal)
-       ("iso-codes" ,iso-codes)))
+     (list fcitx5
+           fcitx5-qt
+           qtbase-5
+           qtx11extras
+           qtdeclarative-5
+           qtquickcontrols2-5
+           ki18n
+           kpackage
+           kdeclarative
+           kiconthemes
+           kcoreaddons
+           plasma-framework
+           kitemviews
+           kwidgetsaddons
+           kwindowsystem
+           kirigami
+           libxkbcommon
+           libx11
+           xkeyboard-config
+           libxkbfile
+           gettext-minimal
+           iso-codes))
     (native-inputs
      (list extra-cmake-modules pkg-config))
     (home-page "https://github.com/fcitx/fcitx5-configtool")
-- 
2.41.0

Message #14 received at 70623 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: control <at> debbugs.gnu.org,70623 <at> debbugs.gnu.org
Subject: QA review for 70623
Date: Mon, 13 May 2024 14:37:56 +0200

user guix
usertag 70623 + reviewed-looks-good
thanks

Guix QA review form submission:
LGTM

Items marked as checked: Lint warnings, Package builds, Commit messages

-- 
Best regards,
Nicolas Graves

Message #19 received at 70623-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
Cc: 70623-done <at> debbugs.gnu.org, Zhu Zihao <all_but_last <at> 163.com>,
 宋文武 <iyzsong <at> envs.net>
Subject: Re: [bug#70623] [PATCH 0/2] fcitx5-configtool: enable kcm and
 remove inputs label
Date: Mon, 13 May 2024 21:49:48 +0100

[Message part 1 (text/plain, inline)]

Zheng Junjie <zhengjunjie <at> iscas.ac.cn> writes:

> Zheng Junjie (2):
>   gnu: fcitx5-configtool: Enable kcm support.
>   gnu: fcitx5-configtool: Remove inputs label.
>
>  gnu/packages/fcitx5.scm | 37 ++++++++++++++++++++++---------------
>  1 file changed, 22 insertions(+), 15 deletions(-)

Thanks both, I've pushed this to master as
a5455ed672c350a63989d5afb6caef3975cb7410.

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.