GNU bug report logs - #70576
[PATCH] `repeat-echo-message-string': support repeat keymap "hints"

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 70576 <at> debbugs.gnu.org, jdtsmith <at> gmail.com
Subject: bug#70576: [PATCH] `repeat-echo-message-string': support repeat keymap "hints"
Date: Thu, 02 May 2024 21:14:29 +0300

> From: Juri Linkov <juri <at> linkov.net>
> Cc: jdtsmith <at> gmail.com,  70576 <at> debbugs.gnu.org
> Date: Thu, 02 May 2024 19:16:06 +0300
> 
> >> >>> (defvar-keymap expreg-repeat-map
> >> >>>    :doc "Repeat map for `expreg' actions."
> >> >>>    :repeat '(:hints ((expreg-expand . "expand") (expreg-contract . "contract")))
> >> >>>    "\\" 'expreg-expand
> >> >>>    "|"  'expreg-contract)
> >> >>
> >> >> If a hint is missing for a command, it should just have its key mentioned.
> >> >> It looks like your idea would require changes to defvar-keymap.  Do you
> >> >> want to propose a patch?  We'd need some way to pass the hints in; perhaps
> >> >> the macro could set a property on the command symbol as you initially
> >> >> proposed.
> >> >
> >> > Alright, let's add this to defvar-keymap.  Please try the following patch.
> >>
> >> Thanks for the feature request.  This is pushed now.
> >
> > Thanks, but please also update the ELisp manual and add an entry to
> > NEWS about this change.
> 
> A NEWS entry was already added with "---" since I didn't expect that
> such a small feature that is not used anywhere needs to grow
> the size of the manual.

I don't see how we can avoid updating the ELisp manual, when the other
values of :repeat are already documented there, see the node "Creating
Keymaps".

So please add the description of the new value to those already
documented there.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.