GNU bug report logs - #70576
[PATCH] `repeat-echo-message-string': support repeat keymap "hints"

Previous Next

Full log

View this message in rfc822 format

From: JD Smith <jdtsmith <at> gmail.com>
To: Juri Linkov <juri <at> linkov.net>
Cc: 70576 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: bug#70576: [PATCH] `repeat-echo-message-string': support repeat keymap "hints"
Date: Thu, 2 May 2024 07:47:31 -0400

Thanks for working on this.  I'm sorry I didn't have a chance to test the patch, it looks good.  I don't think a disable variable is necessary for now, since most repeat maps are self-defined.

> On May 2, 2024, at 3:16 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> Cc: 70576 <at> debbugs.gnu.org
>> From: Juri Linkov <juri <at> linkov.net>
>> Date: Thu, 02 May 2024 09:48:06 +0300
>> 
>> close 70576 30.0.50
>> thanks
>> 
>>>>> (defvar-keymap expreg-repeat-map
>>>>>   :doc "Repeat map for `expreg' actions."
>>>>>   :repeat '(:hints ((expreg-expand . "expand") (expreg-contract . "contract")))
>>>>>   "\\" 'expreg-expand
>>>>>   "|"  'expreg-contract)
>>>> 
>>>> If a hint is missing for a command, it should just have its key mentioned.
>>>> It looks like your idea would require changes to defvar-keymap.  Do you
>>>> want to propose a patch?  We'd need some way to pass the hints in; perhaps
>>>> the macro could set a property on the command symbol as you initially
>>>> proposed.
>>> 
>>> Alright, let's add this to defvar-keymap.  Please try the following patch.
>> 
>> Thanks for the feature request.  This is pushed now.
> 
> Thanks, but please also update the ELisp manual and add an entry to
> NEWS about this change.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.