From unknown Sun Aug 17 01:22:51 2025 X-Loop: help-debbugs@gnu.org Subject: bug#70557: Fix compilation of Vala files conditionally added to _SOURCES Resent-From: Reuben Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Wed, 24 Apr 2024 20:59:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 70557 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: 70557@debbugs.gnu.org X-Debbugs-Original-To: bug-automake Received: via spool by submit@debbugs.gnu.org id=B.17139922889359 (code B ref -1); Wed, 24 Apr 2024 20:59:06 +0000 Received: (at submit) by debbugs.gnu.org; 24 Apr 2024 20:58:08 +0000 Received: from localhost ([127.0.0.1]:60163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzjgs-0002Qg-6e for submit@debbugs.gnu.org; Wed, 24 Apr 2024 16:58:07 -0400 Received: from lists.gnu.org ([2001:470:142::17]:55426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzjgj-0002OG-8u for submit@debbugs.gnu.org; Wed, 24 Apr 2024 16:58:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzjgM-0006N1-9I for bug-automake@gnu.org; Wed, 24 Apr 2024 16:57:34 -0400 Received: from mail-yb1-xb31.google.com ([2607:f8b0:4864:20::b31]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rzjgJ-0000NS-G3 for bug-automake@gnu.org; Wed, 24 Apr 2024 16:57:34 -0400 Received: by mail-yb1-xb31.google.com with SMTP id 3f1490d57ef6-de4665b4969so296456276.2 for ; Wed, 24 Apr 2024 13:57:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; t=1713992250; x=1714597050; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=PVnsU2DNSh8R//944AkSkHrwYLAhTDfVSOVXpE0/sSg=; b=ZJaR14nKph8EPFc7Xh+qD6zF9F3VKatR/rzf+oQMuAeQgQ06Xe3/4j8wQvNfcWhHWe hgTacW98gdLm/l4GLvMBAyyHkX3wRCbQgAMFU7hBPzw397ImxW3dX2xyRr4NGdw/hzZy QQ68PNuRMXM8Dy8G9nQoFDA9efS1u4X+5YKIU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713992250; x=1714597050; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=PVnsU2DNSh8R//944AkSkHrwYLAhTDfVSOVXpE0/sSg=; b=cWIuJBUpfoApRZxmW+17tQ2fvnc0+tj7ZzaVA/jEdE1mC3SJ5PZy4efXsg2PZvF/Jj IW0/ct9QhLmzECgsuGIoPwpGVTGlFGS2L7VR4A/POdAcIjdiG3hIkgORJ8aG6X9xIs5l O/5pY4Mpq6AjMNrMqQydUcjrYcrAo+vUi7wWkEajaVShxzrSOVEtj+ej2YuUP5LAQAhW xZstLNoA5QdMrYo2qf2p66JqB6EERzX0R2s2FtzBf1d3ciUGIO51uHyOUrl79YvVBL+6 dhb3A4zAvwaHwtGRBQs05jDnrRCbUlszP2WxTOP9JazvtGdCyLJzRH+IUviH6ZAaFs90 4mww== X-Gm-Message-State: AOJu0Yw0g78GNSERBZIVNMhthA45YfpiyvcrOPaWZXEdF0YViFT13gz3 5lmszTjkGEqA18YyV0DyIPUoSabsgme+F0lj7cZgydmI5UhwOho71CobbL5/0XAcGtiLBrQgnWW 2mdohIQ62Bu60zQveExPH19dk6UPmFR3aCETqJtQfu3HdT1kx5EGSAg== X-Google-Smtp-Source: AGHT+IGQnFgl1P7JyEBy1eA8X3sKs6KbztlwwR+veo3JqRWnZCF/MUJgQF62jZc2EOi4DRL4xJQz3jQBKz0KMVmZH98= X-Received: by 2002:a25:9c83:0:b0:de4:5eaa:4b5d with SMTP id y3-20020a259c83000000b00de45eaa4b5dmr4148315ybo.46.1713992249768; Wed, 24 Apr 2024 13:57:29 -0700 (PDT) MIME-Version: 1.0 From: Reuben Thomas Date: Wed, 24 Apr 2024 22:57:17 +0200 Message-ID: Content-Type: multipart/mixed; boundary="000000000000322e8c0616ddeb99" Received-SPF: pass client-ip=2607:f8b0:4864:20::b31; envelope-from=rrt@sc3d.org; helo=mail-yb1-xb31.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --000000000000322e8c0616ddeb99 Content-Type: multipart/alternative; boundary="000000000000322e8a0616ddeb97" --000000000000322e8a0616ddeb97 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I attach two patches. The first is a trivial documentation fix. The second fixes a bug I ran into recently with Vala compilation. I just needed to add some Vala source files to my program that are added to the relevant _SOURCES variable conditionally: if OS_WIN32 libenchant_la_SOURCES +=3D api-windows.vala else libenchant_la_SOURCES +=3D api-posix.vala endif (Motivation: the reason I have to add the files conditionally is two-fold: first, api-windows.vala and api-posix.vala call APIs that are only available on Windows and POSIX systems respectively. In itself, this does not require conditional inclusion; I can use Vala preprocessor directives, just as I would in C. But the Vala compiler generates C files, and I want the user of my package not to need a Vala compiler. Therefore, the generated C code must be independent of build-time configuration. Since the Vala compiler does not generate C preprocessor directives, I have to do conditional inclusion at build time some other way. So, I am doing it by using automake conditionals.) With current automake, something like the following Makefile line is generated: $(builddir)/libenchant_la_vala.stamp: api-windows.vala api-posix.vala=E2=80= =A6 With my patch, the following line is generated instead: $(builddir)/libenchant_la_vala.stamp: $(libenchant_la_SOURCES) Of course, $(libenchant_la_SOURCES) expands to the actual sources. The patch is trivial, so hopefully it's obvious if there's a problem for some reason! I hope I explained well enough what problem I'm trying to solve. --=20 https://rrt.sc3d.org --000000000000322e8a0616ddeb97 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I attach two patches. The first is a tr= ivial documentation fix. The second fixes a bug I ran into recently with Va= la compilation.

I just= needed to add some Vala source files to my program that are added to the r= elevant _SOURCES variable conditionally:

=
if OS_WIN32
libenchant_la_SOURCES +=3D api-windows.va= la
else
libenchant_la_SOURCES +=3D api-posix.vala
endif

(Motivation: the reason I have t= o add the files conditionally is two-fold: first, api-windows.vala and api-= posix.vala call APIs that are only available on Windows and POSIX systems r= espectively. In itself, this does not require conditional inclusion; I can = use Vala preprocessor directives, just as I would in C. But the Vala compil= er generates C files, and I want the user of my package not to need a Vala = compiler. Therefore, the generated C code must be independent of build-time= configuration. Since the Vala compiler does not generate C preprocessor di= rectives, I have to do conditional inclusion at build time some other way. = So, I am doing it by using automake conditionals.)

=
With current automake, something like the following= Makefile line is generated:

$(builddir)/libenchant_la_vala.stamp: api-windows.vala api-posix.v= ala=E2=80=A6

With = my patch, the following line is generated instead:

$(builddir)/libenchant_la_vala.stamp: $(li= benchant_la_SOURCES)

= Of course, $(libenchant_la_SOURCES) expands to the actual sources.

The patch is trivial, so hope= fully it's obvious if there's a problem for some reason! I hope I e= xplained well enough what problem I'm trying to solve.
<= div>
--
--000000000000322e8a0616ddeb97-- --000000000000322e8c0616ddeb99 Content-Type: text/x-patch; charset="UTF-8"; name="0002-vala-do-not-build-Vala-sources-excluded-by-automake-.patch" Content-Disposition: attachment; filename="0002-vala-do-not-build-Vala-sources-excluded-by-automake-.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lveacq891 RnJvbSA0OTA3NzdkYjcxYzIwODZjZmJkM2VjMzU5ZmNlY2E1ZmM4NTMwNDdkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSZXViZW4gVGhvbWFzIDxycnRAc2MzZC5vcmc+CkRhdGU6IFdl ZCwgMjQgQXByIDIwMjQgMjI6NDE6NDggKzAyMDAKU3ViamVjdDogW1BBVENIIDIvMl0gdmFsYTog ZG8gbm90IGJ1aWxkIFZhbGEgc291cmNlcyBleGNsdWRlZCBieSBhdXRvbWFrZQogY29uZGl0aW9u YWxzCk1JTUUtVmVyc2lvbjogMS4wCkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1V VEYtOApDb250ZW50LVRyYW5zZmVyLUVuY29kaW5nOiA4Yml0CgoqIGJpbi9hdXRvbWFrZS5pbjog bWFrZSB0aGUgX3ZhbGEuc3RhbXAgZmlsZSBkZXBlbmQgb24gdGhlIHJlbGV2YW50IF9TT1VSQ0VT CnZhcmlhYmxl4oCZcyB2YWx1ZSwgbm90IHRoZSBmdWxseS1leHBhbmRlZCBsaXN0IG9mIGFsbCBw b3NzaWJsZSBzb3VyY2VzLiBUaGlzCm1lYW5zIHRoYXQgc291cmNlIGZpbGVzIGFkZGVkIGNvbmRp dGlvbmFsbHkgdG8gYSBfU09VUkNFUyB2YXJpYWJsZSB3aWxsIG9ubHkKYmUgYWRkZWQgd2hlbiB0 aGUgY29uZGl0aW9uIGlzIHRydWUuCi0tLQogYmluL2F1dG9tYWtlLmluIHwgMiArLQogMSBmaWxl IGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvYmlu L2F1dG9tYWtlLmluIGIvYmluL2F1dG9tYWtlLmluCmluZGV4IDExMjczMDI2OS4uOTUxMjljMjk0 IDEwMDY0NAotLS0gYS9iaW4vYXV0b21ha2UuaW4KKysrIGIvYmluL2F1dG9tYWtlLmluCkBAIC01 ODg3LDcgKzU4ODcsNyBAQCBzdWIgbGFuZ192YWxhX2ZpbmlzaF90YXJnZXQKICAgbXkgJHN0YW1w ZmlsZSA9ICJcJChidWlsZGRpcikvJHtkZXJpdmVkfV92YWxhLnN0YW1wIjsKIAogICAkb3V0cHV0 X3J1bGVzIC49Ci0gICAgIlwkKGJ1aWxkZGlyKS8ke2Rlcml2ZWR9X3ZhbGEuc3RhbXA6IEB2YWxh X3NvdXJjZXNcbiIuCisgICAgIlwkKGJ1aWxkZGlyKS8ke2Rlcml2ZWR9X3ZhbGEuc3RhbXA6IFwk KCR7ZGVyaXZlZH1fU09VUkNFUylcbiIuCiAjIFNpbmNlIHRoZSBDIGZpbGVzIGdlbmVyYXRlZCBm cm9tIHRoZSB2YWxhIHNvdXJjZXMgZGVwZW5kIG9uIHRoZQogIyAke2Rlcml2ZWR9X3ZhbGEuc3Rh bXAgZmlsZSwgd2UgbXVzdCBlbnN1cmUgaXRzIHRpbWVzdGFtcCBpcyBvbGRlciB0aGFuCiAjIHRo b3NlIG9mIHRoZSBDIGZpbGVzIGdlbmVyYXRlZCBieSB0aGUgdmFsYWMgaW52b2NhdGlvbiBiZWxv dyAodGhpcyBpcwotLSAKMi4zNC4xCgo= --000000000000322e8c0616ddeb99 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-doc-add-missing-close-parenthesis-in-comment.patch" Content-Disposition: attachment; filename="0001-doc-add-missing-close-parenthesis-in-comment.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lveacq7u0 RnJvbSAzMmFkNmRhMmFmMzQ3MjVjYmI3NzFlOGYzODI0MzcwY2QxNWEwNTQwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSZXViZW4gVGhvbWFzIDxycnRAc2MzZC5vcmc+CkRhdGU6IFdl ZCwgMjQgQXByIDIwMjQgMjI6NDE6MTIgKzAyMDAKU3ViamVjdDogW1BBVENIIDEvMl0gZG9jOiBh ZGQgbWlzc2luZyBjbG9zZSBwYXJlbnRoZXNpcyBpbiBjb21tZW50LgoKKiBiaW4vYXV0b21ha2Uu aW46IGFkZCBtaXNzaW5nIGNsb3NlIHBhcmVudGhlc2lzLgotLS0KIGJpbi9hdXRvbWFrZS5pbiB8 IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlm ZiAtLWdpdCBhL2Jpbi9hdXRvbWFrZS5pbiBiL2Jpbi9hdXRvbWFrZS5pbgppbmRleCAxZGM0MGEw MGIuLjExMjczMDI2OSAxMDA2NDQKLS0tIGEvYmluL2F1dG9tYWtlLmluCisrKyBiL2Jpbi9hdXRv bWFrZS5pbgpAQCAtNTgwOSw3ICs1ODA5LDcgQEAgc3ViIGxhbmdfdmFsYV9maW5pc2hfdGFyZ2V0 CiAgICAgICAgICAgIwogICAgICAgICAgICMgVGhlIC1uZXdlciB0ZXN0IGhlcmUgaXMgY2hlY2tp bmcgIkMgZmlsZSBub3Qgb2xkZXIgdGhhbiBWYWxhCiAgICAgICAgICAgIyBmaWxlIiAobm90ICJD IGZpbGUgbmV3ZXIgdGhhbiBWYWxhIGZpbGUiOyBzZWUKLSAgICAgICAgICAjIGh0dHBzOi8vYnVn cy5nbnUub3JnLzQ0NzcyLiBUaGUgbG9nIG1lc3NhZ2Ugb24gdGhlIGNvbW1pdAorICAgICAgICAg ICMgaHR0cHM6Ly9idWdzLmdudS5vcmcvNDQ3NzIgKS4gVGhlIGxvZyBtZXNzYWdlIG9uIHRoZSBj b21taXQKICAgICAgICAgICAjIG1pc2xlYWRpbmdseSBzYXlzICJyZXZlcnNlZCIuCiAgICAgICAg ICAgIwogICAgICAgICAgICRvdXRwdXRfcnVsZXMgLj0gIiRidWlsdF9jX2ZpbGU6IFwkKGJ1aWxk ZGlyKS8ke2Rlcml2ZWR9X3ZhbGEuc3RhbXBcbiIKLS0gCjIuMzQuMQoK --000000000000322e8c0616ddeb99-- From unknown Sun Aug 17 01:22:51 2025 X-Loop: help-debbugs@gnu.org Subject: bug#70557: Fix compilation of Vala files conditionally added to _SOURCES Resent-From: Reuben Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Wed, 24 Apr 2024 21:40:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70557 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: 70557@debbugs.gnu.org X-Debbugs-Original-To: bug-automake Received: via spool by submit@debbugs.gnu.org id=B.17139947433914 (code B ref -1); Wed, 24 Apr 2024 21:40:05 +0000 Received: (at submit) by debbugs.gnu.org; 24 Apr 2024 21:39:03 +0000 Received: from localhost ([127.0.0.1]:60181 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzkKQ-00010H-Ve for submit@debbugs.gnu.org; Wed, 24 Apr 2024 17:39:02 -0400 Received: from lists.gnu.org ([2001:470:142::17]:51236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzkKL-0000ye-0J for submit@debbugs.gnu.org; Wed, 24 Apr 2024 17:38:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzkJy-0004Q4-39 for bug-automake@gnu.org; Wed, 24 Apr 2024 17:38:30 -0400 Received: from mail-yb1-xb34.google.com ([2607:f8b0:4864:20::b34]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rzkJv-0003Q6-FW for bug-automake@gnu.org; Wed, 24 Apr 2024 17:38:29 -0400 Received: by mail-yb1-xb34.google.com with SMTP id 3f1490d57ef6-de54c2a3eeaso384975276.1 for ; Wed, 24 Apr 2024 14:38:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; t=1713994706; x=1714599506; darn=gnu.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=VD0amhkEzlD4gPOTxEFyF7Jo5wpc/v/SjT3BmAjv9tM=; b=JdZtbYfrIiSmHDCFrFWW56ZwI2e5qgNdz8C+eXbsQxScm9i1GkNwqlOmWP1pR9JfiS rRr3Yxq/xEHoFxzrr180qKkZduBycGyLFH35VhLWBFKWNhBgWSELVMT90WsrAy2oGc48 x3b776xvUPjcr4XJLTVU/N261YZrXOBRI2IBk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713994706; x=1714599506; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VD0amhkEzlD4gPOTxEFyF7Jo5wpc/v/SjT3BmAjv9tM=; b=HPWfvwex1FljZ7kWFeHeDM89TtR40/TxoRnajda3F6Xj+uxafWN+hDP6348Ochk8RF TbAA57aqp+gyn1tznq2B20ZkHS7SqPMrRhE+A7M8Z8sHZIFZGLBDNqAY+OmghXePFWlp AdVhe+U5H3Wo5N/ijqQRB7lUlQAVfFwPnnPgqfUTmfibFOxcRQDuwvNP3FOp+dSsDf1d UoZClXScc3nEDbR61RsFiacHVl+P/AHN27Ye2OF9RVyOkwM2Srygbf/zHTS2ussnsSjk XDmHkkTll5X6/pYmYwXKiaMb4W5JfIYsLwuWikktDI6abuopDDjlQOgXh/y1XVDVWyLo zk0A== X-Gm-Message-State: AOJu0YzKvCxM38C/53XBQYbFOCckPm95cg3homObeAkNFCI9t4DaL5hp UuIN0U7YFCUFwWO+uNh99d8/VrjNKOpby/7bdw0Qv72Dgus19oah7HUYniUVPshev+gsneKv0dr QE+xsHoO7bL/w9hHznz2PFAaLJ8FV7rwOyXGzV+H6q/GF/xGDFNI= X-Google-Smtp-Source: AGHT+IGKJ6mlvXlVigc8tXxW0ILiOG8KrZKRAuVJbMY+rfLRcyHphCW0c0mtjkW7Nyy6bvV+0CXFgBvN2miTLdftY6I= X-Received: by 2002:a5b:14d:0:b0:dcd:3663:b5e5 with SMTP id c13-20020a5b014d000000b00dcd3663b5e5mr3551648ybp.25.1713994705589; Wed, 24 Apr 2024 14:38:25 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Reuben Thomas Date: Wed, 24 Apr 2024 23:38:13 +0200 Message-ID: Content-Type: multipart/alternative; boundary="00000000000092f4470616de7dc2" Received-SPF: pass client-ip=2607:f8b0:4864:20::b34; envelope-from=rrt@sc3d.org; helo=mail-yb1-xb34.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --00000000000092f4470616de7dc2 Content-Type: text/plain; charset="UTF-8" On Wed, 24 Apr 2024 at 22:57, Reuben Thomas wrote: > > The patch is trivial, so hopefully it's obvious if there's a problem for > some reason! I hope I explained well enough what problem I'm trying to > solve. > Apologies, I should have run the tests before posting the patch. Indeed, I have broken things. So, please consider the documentation patch, and I'll take another look at the bug-fix (which in any case I have also realised does not solve my problem; it is the wrong approach!). -- https://rrt.sc3d.org --00000000000092f4470616de7dc2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, 24 Apr 2024 at= 22:57, Reuben Thomas <rrt@sc3d.org&= gt; wrote:

The patch is trivial, so hopef= ully it's obvious if there's a problem for some reason! I hope I ex= plained well enough what problem I'm trying to solve.

Apologies, I should= have run the tests before posting the patch. Indeed, I have broken things.= So, please consider the documentation patch, and I'll take another loo= k at the bug-fix (which in any case I have also realised does not solve my = problem; it is the wrong approach!).

--
--00000000000092f4470616de7dc2-- From unknown Sun Aug 17 01:22:51 2025 X-Loop: help-debbugs@gnu.org Subject: bug#70557: Fix compilation of Vala files conditionally added to _SOURCES Resent-From: Reuben Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Wed, 24 Apr 2024 21:55:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70557 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: 70557@debbugs.gnu.org X-Debbugs-Original-To: bug-automake Received: via spool by submit@debbugs.gnu.org id=B.171399566514155 (code B ref -1); Wed, 24 Apr 2024 21:55:04 +0000 Received: (at submit) by debbugs.gnu.org; 24 Apr 2024 21:54:25 +0000 Received: from localhost ([127.0.0.1]:60185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzkZJ-0003fg-SH for submit@debbugs.gnu.org; Wed, 24 Apr 2024 17:54:24 -0400 Received: from lists.gnu.org ([2001:470:142::17]:46682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzkZC-0003dF-1e for submit@debbugs.gnu.org; Wed, 24 Apr 2024 17:54:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzkYp-0007h3-4V for bug-automake@gnu.org; Wed, 24 Apr 2024 17:53:51 -0400 Received: from mail-yb1-xb2f.google.com ([2607:f8b0:4864:20::b2f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rzkYk-0000y0-Vl for bug-automake@gnu.org; Wed, 24 Apr 2024 17:53:50 -0400 Received: by mail-yb1-xb2f.google.com with SMTP id 3f1490d57ef6-de467733156so446323276.0 for ; Wed, 24 Apr 2024 14:53:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; t=1713995625; x=1714600425; darn=gnu.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=XEs1PPi1ORWTRFI6t0MWoQgJRYzj6mcc+G4+xlR4dds=; b=u3mULq+ArYbaqMqLpSnZlNk74Tm0kABb2GW3L+0z5KqMHd34FtmBKulZ8/1d27bsk5 DYdqpdHfxS1J7MxbtaBzG6awEE4lyDr+iGbvi3kM1zfh4RaOF1ogPMCnPC5LS2O46mFG QcdBUyGQNy/hkDlJZwtG5BtqzLlFHfDJwMgus= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713995625; x=1714600425; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XEs1PPi1ORWTRFI6t0MWoQgJRYzj6mcc+G4+xlR4dds=; b=g2yV/QIgekLbu1eZCGjFwqlDIJDziXSDW5iXEt1BMA5Fty9kHtbGEYXbqIM084QeU5 WrDRc03L01W8qlo3INoN63/ssLcpuv+0uF8htWgSEJIUMfijaoZBjIsp9xBBldk9Isfz Slp5dbqhgaxipJp2YslRqOtivg0c4Y67p/oxJYMGPyTr8+XyoRII4V5YW6C7VZTFvr3n w/9vIELv5NA8VNC3Ba3JtzS2yTfRcW9fukOpzEWtEOK307p46bG/u20oWnWLLpx8wZ7t L1CmLveenNIL/M2GNC+pDOSNKHXmEw1xzn4gmYPEwASHIuk+A7sncaEXm3qokGBjLd0h B9Gw== X-Gm-Message-State: AOJu0YxrAdKMr1jMfPsQB5EzAAV1xQVr4wzrA+bb8ZEfp2GhD0dMCH9h rUgfIvu+pg3646YV/QT64nntXu7IQ93iGS2bajae8IIT6TtsdxjdFul5KL2f05Z0jPLp6dm9Nw5 P3GHW6rHOQwe7UYDnzA2ShTjNM+4Zrhx31njetypf7Odvk6gWPww= X-Google-Smtp-Source: AGHT+IHTHy+9FwavOXF9BtZ5vcgLqqE5JCbyfKV00v8WQJEZUF0kniUk3EN8NXO/TR463BSdXt1FJ939hDaZ0bmdW4A= X-Received: by 2002:a25:ae07:0:b0:de5:567b:88f with SMTP id a7-20020a25ae07000000b00de5567b088fmr4271651ybj.10.1713995625026; Wed, 24 Apr 2024 14:53:45 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Reuben Thomas Date: Wed, 24 Apr 2024 23:53:33 +0200 Message-ID: Content-Type: multipart/mixed; boundary="000000000000608b4a0616deb40d" Received-SPF: pass client-ip=2607:f8b0:4864:20::b2f; envelope-from=rrt@sc3d.org; helo=mail-yb1-xb2f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --000000000000608b4a0616deb40d Content-Type: multipart/alternative; boundary="000000000000608b470616deb40b" --000000000000608b470616deb40b Content-Type: text/plain; charset="UTF-8" On Wed, 24 Apr 2024 at 23:38, Reuben Thomas wrote: > Apologies, I should have run the tests before posting the patch. Indeed, I > have broken things. So, please consider the documentation patch, and I'll > take another look at the bug-fix (which in any case I have also realised > does not solve my problem; it is the wrong approach!). > Attached, an updated patch that passes the tests. It uses GNU Make functionality, but this is already required by the Vala support. -- https://rrt.sc3d.org --000000000000608b470616deb40b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, 24 Apr 2024 at 23:38, Reuben Thomas <rrt@sc3d.org> wrote:
Apologies, I should have run the t= ests before posting the patch. Indeed, I have broken things. So, please con= sider the documentation patch, and I'll take another look at the bug-fi= x (which in any case I have also realised does not solve my problem; it is = the wrong approach!).

Attached, an updated patch that passes the tests. It uses GNU Mak= e functionality, but this is already required by the Vala support.

--
=
--000000000000608b470616deb40b-- --000000000000608b4a0616deb40d Content-Type: text/x-patch; charset="UTF-8"; name="0002-vala-do-not-build-Vala-sources-excluded-by-automake-.patch" Content-Disposition: attachment; filename="0002-vala-do-not-build-Vala-sources-excluded-by-automake-.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lvecmrwf0 RnJvbSA5Mzc5MDA3OGY1MDlhNDI2NmRhNmJiNDM2ZDE4NDFmZWI3ZDY2NjYwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSZXViZW4gVGhvbWFzIDxycnRAc2MzZC5vcmc+CkRhdGU6IFdl ZCwgMjQgQXByIDIwMjQgMjI6NDE6NDggKzAyMDAKU3ViamVjdDogW1BBVENIIDIvMl0gdmFsYTog ZG8gbm90IGJ1aWxkIFZhbGEgc291cmNlcyBleGNsdWRlZCBieSBhdXRvbWFrZQogY29uZGl0aW9u YWxzCk1JTUUtVmVyc2lvbjogMS4wCkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1V VEYtOApDb250ZW50LVRyYW5zZmVyLUVuY29kaW5nOiA4Yml0CgoqIGJpbi9hdXRvbWFrZS5pbjog bWFrZSB0aGUgX3ZhbGEuc3RhbXAgZmlsZSBkZXBlbmQgb24gdGhlIHJlbGV2YW50IF9TT1VSQ0VT CnZhcmlhYmxl4oCZcyB2YWx1ZSwgbm90IHRoZSBmdWxseS1leHBhbmRlZCBsaXN0IG9mIGFsbCBw b3NzaWJsZSBzb3VyY2VzLiBUaGlzCm1lYW5zIHRoYXQgc291cmNlIGZpbGVzIGFkZGVkIGNvbmRp dGlvbmFsbHkgdG8gYSBfU09VUkNFUyB2YXJpYWJsZSB3aWxsIG9ubHkKYmUgYWRkZWQgd2hlbiB0 aGUgY29uZGl0aW9uIGlzIHRydWUuCi0tLQogYmluL2F1dG9tYWtlLmluIHwgMiArLQogMSBmaWxl IGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvYmlu L2F1dG9tYWtlLmluIGIvYmluL2F1dG9tYWtlLmluCmluZGV4IDExMjczMDI2OS4uNWM1YWZhMGIy IDEwMDY0NAotLS0gYS9iaW4vYXV0b21ha2UuaW4KKysrIGIvYmluL2F1dG9tYWtlLmluCkBAIC01 ODg3LDcgKzU4ODcsNyBAQCBzdWIgbGFuZ192YWxhX2ZpbmlzaF90YXJnZXQKICAgbXkgJHN0YW1w ZmlsZSA9ICJcJChidWlsZGRpcikvJHtkZXJpdmVkfV92YWxhLnN0YW1wIjsKIAogICAkb3V0cHV0 X3J1bGVzIC49Ci0gICAgIlwkKGJ1aWxkZGlyKS8ke2Rlcml2ZWR9X3ZhbGEuc3RhbXA6IEB2YWxh X3NvdXJjZXNcbiIuCisgICAgIlwkKGJ1aWxkZGlyKS8ke2Rlcml2ZWR9X3ZhbGEuc3RhbXA6IFwk KGZpbHRlciAlLnZhbGEgJS52YXBpLFwkKCR7ZGVyaXZlZH1fU09VUkNFUykpXG4iLgogIyBTaW5j ZSB0aGUgQyBmaWxlcyBnZW5lcmF0ZWQgZnJvbSB0aGUgdmFsYSBzb3VyY2VzIGRlcGVuZCBvbiB0 aGUKICMgJHtkZXJpdmVkfV92YWxhLnN0YW1wIGZpbGUsIHdlIG11c3QgZW5zdXJlIGl0cyB0aW1l c3RhbXAgaXMgb2xkZXIgdGhhbgogIyB0aG9zZSBvZiB0aGUgQyBmaWxlcyBnZW5lcmF0ZWQgYnkg dGhlIHZhbGFjIGludm9jYXRpb24gYmVsb3cgKHRoaXMgaXMKLS0gCjIuMzQuMQoK --000000000000608b4a0616deb40d-- From unknown Sun Aug 17 01:22:51 2025 X-Loop: help-debbugs@gnu.org Subject: bug#70557: Fix compilation of Vala files conditionally added to _SOURCES References: Resent-From: Karl Berry Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Thu, 25 Apr 2024 22:37:07 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70557 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: rrt@sc3d.org Cc: 70557@debbugs.gnu.org Received: via spool by 70557-submit@debbugs.gnu.org id=B70557.171408457616506 (code B ref 70557); Thu, 25 Apr 2024 22:37:07 +0000 Received: (at 70557) by debbugs.gnu.org; 25 Apr 2024 22:36:16 +0000 Received: from localhost ([127.0.0.1]:33454 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s07hN-0004Ho-Qi for submit@debbugs.gnu.org; Thu, 25 Apr 2024 18:36:15 -0400 Received: from frenzy.freefriends.org ([198.99.81.75]:57102 helo=freefriends.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s07hD-0004GN-2V for 70557@debbugs.gnu.org; Thu, 25 Apr 2024 18:36:08 -0400 X-Envelope-From: karl@freefriends.org Received: from freefriends.org (localhost [127.0.0.1]) by freefriends.org (8.14.7/8.14.7) with ESMTP id 43PMZhis009462 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Apr 2024 16:35:43 -0600 Received: (from apache@localhost) by freefriends.org (8.14.7/8.14.7/Submit) id 43PMZh6h009461; Thu, 25 Apr 2024 16:35:43 -0600 Date: Thu, 25 Apr 2024 16:35:43 -0600 Message-Id: <202404252235.43PMZh6h009461@freefriends.org> From: Karl Berry In-Reply-To: X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Attached, an updated patch that passes the tests. It uses GNU Make functionality, but this is already required by the Vala support. Thanks Ruben. I will peruse as soon as I have a chance, if no one else gets there first ... -k From unknown Sun Aug 17 01:22:51 2025 X-Loop: help-debbugs@gnu.org Subject: bug#70557: Fix compilation of Vala files conditionally added to _SOURCES References: Resent-From: Karl Berry Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Fri, 26 Apr 2024 22:54:07 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70557 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: rrt@sc3d.org Cc: 70557@debbugs.gnu.org Received: via spool by 70557-submit@debbugs.gnu.org id=B70557.17141720336947 (code B ref 70557); Fri, 26 Apr 2024 22:54:07 +0000 Received: (at 70557) by debbugs.gnu.org; 26 Apr 2024 22:53:53 +0000 Received: from localhost ([127.0.0.1]:38630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0URz-0001nj-Ms for submit@debbugs.gnu.org; Fri, 26 Apr 2024 18:53:53 -0400 Received: from frenzy.freefriends.org ([198.99.81.75]:32834 helo=freefriends.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0URw-0001mH-Ab for 70557@debbugs.gnu.org; Fri, 26 Apr 2024 18:53:49 -0400 X-Envelope-From: karl@freefriends.org Received: from freefriends.org (localhost [127.0.0.1]) by freefriends.org (8.14.7/8.14.7) with ESMTP id 43QMrON0019943 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Apr 2024 16:53:24 -0600 Received: (from apache@localhost) by freefriends.org (8.14.7/8.14.7/Submit) id 43QMrNKG019941; Fri, 26 Apr 2024 16:53:23 -0600 Date: Fri, 26 Apr 2024 16:53:23 -0600 Message-Id: <202404262253.43QMrNKG019941@freefriends.org> From: Karl Berry In-Reply-To: X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Reuben, any chance you can whomp up a test for this patch? I don't see a problem with the change, but it's always better to add a test against future regressions, etc. --thanks, karl. From unknown Sun Aug 17 01:22:51 2025 X-Loop: help-debbugs@gnu.org Subject: bug#70557: Fix compilation of Vala files conditionally added to _SOURCES Resent-From: Reuben Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Sat, 27 Apr 2024 18:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70557 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: Karl Berry Cc: 70557@debbugs.gnu.org Received: via spool by 70557-submit@debbugs.gnu.org id=B70557.171424304318037 (code B ref 70557); Sat, 27 Apr 2024 18:38:02 +0000 Received: (at 70557) by debbugs.gnu.org; 27 Apr 2024 18:37:23 +0000 Received: from localhost ([127.0.0.1]:49679 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0mvL-0004gr-60 for submit@debbugs.gnu.org; Sat, 27 Apr 2024 14:37:23 -0400 Received: from mail-yw1-x112d.google.com ([2607:f8b0:4864:20::112d]:57630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0mvH-0004gk-In for 70557@debbugs.gnu.org; Sat, 27 Apr 2024 14:37:21 -0400 Received: by mail-yw1-x112d.google.com with SMTP id 00721157ae682-6181d032bf9so31336287b3.3 for <70557@debbugs.gnu.org>; Sat, 27 Apr 2024 11:37:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; t=1714243015; x=1714847815; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=zGXYmasQFiSyUXwbTmAXvUsFBuaN+8mZ2R6puhzionU=; b=xhjPfSsYHghM29+6qziGZI0P6cSWdVHjyFmYApVXwGTI6tbmpq/ZwLjpuUFd5lUI6a kgAB8B2tUppVg6GSniIg7X01gp43nSj4hoRqz1cZ5fyH+bhKWqll+rDO8nMnyIu6GAny RUdETtlDyDz3U55fmxJ8JdjGSc8ohlkTToQrM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714243015; x=1714847815; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zGXYmasQFiSyUXwbTmAXvUsFBuaN+8mZ2R6puhzionU=; b=udHGKaSqMMCGkTOLGU9J7AD25AvDqAsumQx/kZwkoI6dD0DyJ5mgquVDO4rBt+jdxy mZmzMYK0V3qQc10KFxb7P24+97eyHTYHcz08pJjvESD3xkusuWMsixRT3LAVzCEnHf0+ m65Uag4a03LsOQaXAzVYnQw2y+8CCqGepf+r0JTle4sOS4P8NdmGJT2FRQgX4kTZ0TUD dOjxhniuhITLHIEd1Wa4CTqcZG099T34+GOgAVyYhPHCi/mNM5FDZsjQwCy75OMr2kp1 pA+D1XVZ2Y/hifDwmxXsGjANm9LllYXAKTstNX4ckPlKYwTH8f97YwBGj/6+XLdi2LZ1 knbQ== X-Gm-Message-State: AOJu0YxrSppv+QBxu5Hf/n4CiBZF7pOERYdN0RiIq9X8GQSBs0pKBI6p R1LPT5rh2R916d7NwSktCqP4ZSNxKycSrHAVnRgT/tV0wePXbU64EPm7zf2I/gSpKxbg9tTT/ow Sa6iG/tBQnKnvCSHpO1djpg9aYy8NCbflCvZR/EJFDNdgr4UOflU= X-Google-Smtp-Source: AGHT+IF24tpAmh1b7uCeXdN/7dqgAd+AImnuEud2LhGJbEyoyAOXglnpjskPcDQO6Am60h0wQ5YhjLLM749o5/EiB+k= X-Received: by 2002:a05:690c:7249:b0:611:18fc:9489 with SMTP id jm9-20020a05690c724900b0061118fc9489mr6435566ywb.28.1714243014622; Sat, 27 Apr 2024 11:36:54 -0700 (PDT) MIME-Version: 1.0 References: <202404262253.43QMrNKG019941@freefriends.org> In-Reply-To: <202404262253.43QMrNKG019941@freefriends.org> From: Reuben Thomas Date: Sat, 27 Apr 2024 20:36:42 +0200 Message-ID: Content-Type: multipart/alternative; boundary="000000000000f21d7a0617184d6e" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000f21d7a0617184d6e Content-Type: text/plain; charset="UTF-8" On Sat, 27 Apr 2024 at 00:53, Karl Berry wrote: > Reuben, any chance you can whomp up a test for this patch? > No problem, I will do this when I can find a moment. Since I don't actually need this fix after all, it may not be quick! -- https://rrt.sc3d.org --000000000000f21d7a0617184d6e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sat, 27 Apr 2024 at 00:53, Karl Berry <karl@freefriends.org> wrote:
Reuben, any chance you can whomp up a = test for this patch?

No problem, I will do this when I can find a moment. Since I don't act= ually need this fix after all, it may not be quick!
--
--000000000000f21d7a0617184d6e-- From unknown Sun Aug 17 01:22:51 2025 X-Loop: help-debbugs@gnu.org Subject: bug#70557: Fix compilation of Vala files conditionally added to _SOURCES Resent-From: Reuben Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Sun, 28 Apr 2024 22:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70557 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: Karl Berry Cc: 70557@debbugs.gnu.org Received: via spool by 70557-submit@debbugs.gnu.org id=B70557.171434203310521 (code B ref 70557); Sun, 28 Apr 2024 22:08:01 +0000 Received: (at 70557) by debbugs.gnu.org; 28 Apr 2024 22:07:13 +0000 Received: from localhost ([127.0.0.1]:53151 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s1Cfw-0002jd-ES for submit@debbugs.gnu.org; Sun, 28 Apr 2024 18:07:12 -0400 Received: from mail-yb1-xb36.google.com ([2607:f8b0:4864:20::b36]:47320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s1Cft-0002jX-55 for 70557@debbugs.gnu.org; Sun, 28 Apr 2024 18:07:10 -0400 Received: by mail-yb1-xb36.google.com with SMTP id 3f1490d57ef6-de54cb87998so4165959276.2 for <70557@debbugs.gnu.org>; Sun, 28 Apr 2024 15:06:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; t=1714342004; x=1714946804; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=LZ/ZQFrAJkBT6jV4rzLv9mVBTlpW6s4sxhIffUf4Pwc=; b=YxDjectYp6z4ULj4OrjXz2GlBmdotIJswqpqvuRiLsLwa0+vjkbNj/pxkI+WSiEy4J pxGFvxRlJ5rebs11Uh9r1dZYddDEQBfx/k747bLxmgal6j48DnDfHRx50fx5Rt8g5k0t GwMwVt+dqoMWG6pTh8waEnMf2eTPifbgqfcGw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714342004; x=1714946804; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LZ/ZQFrAJkBT6jV4rzLv9mVBTlpW6s4sxhIffUf4Pwc=; b=tdbyeObjWWREu1XecUN3OkCEdsJVgHqz4z3YYMw1Gt+0qE8HNt68z9bugpUWy84MA/ ePtUov7aZUyiSvGOzDVYzkJSAHJvzJQhHebC2d84uRUbNyQR71RtcjQ3fOceCL1GDygc L4GWcy/i6I4jdvdM9ryzc4ccB3wGWgv9VGuU7eKE60+HV6RImOrRX5m1oLtwHrC8ANLS ijr5X6W617/HGQX0DfFYQxkkjNRJW9A5zofKR1Ni6WFLdIQ62RMB4KhZ7+GfnNc78VuA VmbXVqT6TEyGrKaGhwVkxCaeVbdYndGULIoHWa2NuHpzkSWEXxIJVRPXLLo3aCLT0eem h5mg== X-Gm-Message-State: AOJu0YwF3gGsFeqg1+f0j/kpx85kw0VPONPuhpe52m8IhaC2bciKWsCd PtoVjhzeOiKmjjh+CIEtTuLHjwzSTiCKlq1oMtv+cnsPs5CoJAaoslq0AqIndrmDnw2e/4PtVYw FZ4cP5zsSMdpv0JvZ6twEU0JJCSV8TiAQR3Ruyw== X-Google-Smtp-Source: AGHT+IHv5s+7/flEDAiXw++eu9qPHbLc4QeoOefT98PWrETmRxCoBdRv0sqWqAo2qgDvbmkUG/seLE8iONwamsBjUUg= X-Received: by 2002:a25:d68b:0:b0:dc6:b820:bb45 with SMTP id n133-20020a25d68b000000b00dc6b820bb45mr9282625ybg.27.1714342003543; Sun, 28 Apr 2024 15:06:43 -0700 (PDT) MIME-Version: 1.0 References: <202404262253.43QMrNKG019941@freefriends.org> In-Reply-To: From: Reuben Thomas Date: Mon, 29 Apr 2024 00:06:31 +0200 Message-ID: Content-Type: multipart/mixed; boundary="00000000000025488306172f5a4f" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000025488306172f5a4f Content-Type: multipart/alternative; boundary="00000000000025488106172f5a4d" --00000000000025488106172f5a4d Content-Type: text/plain; charset="UTF-8" On Sat, 27 Apr 2024 at 20:36, Reuben Thomas wrote: > On Sat, 27 Apr 2024 at 00:53, Karl Berry wrote: > >> Reuben, any chance you can whomp up a test for this patch? >> > > No problem, I will do this when I can find a moment. Since I don't > actually need this fix after all, it may not be quick! > I found a moment, but not a fix. In fact, a fix is not in general possible (or at least, not without a considerable amount of messing around). The problem is that the Vala compiler needs to be able to see all the symbols in the program, so you have to give it all the source files at once, so you can't give it source files that contain alternative (duplicate) definitions of the same symbol. Hence, having conditionally-added sources like this is not compatible with shipping all C sources in the tarball, or to put it another way, with making the Vala compiler optional. But I think this is a great feature of Automake's Vala support! (Certainly, I believe it is unique.) So if Automake had in future a mode where it shipped only Vala sources, then in that mode it would make sense to conditionally-include Vala sources, and that would work. As a consolation, I attach another patch that fixes some English in comments in one of the Vala tests. I guess it is worth documenting this limitation of the current Vala support. If you agree with my reasoning above, then I will prepare a documentation patch based on it. -- https://rrt.sc3d.org --00000000000025488106172f5a4d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sat, 27 Apr 2024 at 20:36, Reuben Thomas <rrt@sc3d.org> wrote:
On Sat, 27 Apr 2024 at 00:53, Karl Berry <= ;karl@freefriends= .org> wrote:
Reuben, any chance you can whomp up a test for this patch?

No problem, I will do this when I can find a moment. Sin= ce I don't actually need this fix after all, it may not be quick!

I foun= d a moment, but not a fix. In fact, a fix is not in general possible (or at= least, not without a considerable amount of messing around). The problem i= s that the Vala compiler needs to be able to see all the symbols in the pro= gram, so you have to give it all the source files at once, so you can't= give it source files that contain alternative (duplicate) definitions of t= he same symbol.

Hence,= having conditionally-added sources like this is not compatible with shippi= ng all C sources in the tarball, or to put it another way, with making the = Vala compiler optional. But I think this is a great feature of Automake'= ;s Vala support! (Certainly, I believe it is unique.)

So if Automake had in future a mode where i= t shipped only Vala sources, then in that mode it would make sense to condi= tionally-include Vala sources, and that would work.

As a consolation, I attach another patch that= fixes some English in comments in one of the Vala tests.

I guess it is worth documenting this l= imitation of the current Vala support. If you agree with my reasoning above= , then I will prepare a documentation patch based on it.

--
<= a href=3D"https://rrt.sc3d.org" target=3D"_blank">https://rrt.sc3d.org<= /div>
--00000000000025488106172f5a4d-- --00000000000025488306172f5a4f Content-Type: text/x-patch; charset="US-ASCII"; name="0002-vala-fix-some-English-in-test-comments.patch" Content-Disposition: attachment; filename="0002-vala-fix-some-English-in-test-comments.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lvk2x5lt0 RnJvbSAxMjI0YTRlZjFkOWE5ODNjZDQ1ZGU0MmI0NjZiZGE4ZDkxOTQ0NmJlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSZXViZW4gVGhvbWFzIDxycnRAc2MzZC5vcmc+CkRhdGU6IFN1 biwgMjggQXByIDIwMjQgMjA6NDI6MjAgKzAyMDAKU3ViamVjdDogW1BBVENIIDIvM10gdmFsYTog Zml4IHNvbWUgRW5nbGlzaCBpbiB0ZXN0IGNvbW1lbnRzCgotLS0KIHQvdmFsYS12YXBpLnNoIHwg NiArKystLS0KIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvdC92YWxhLXZhcGkuc2ggYi90L3ZhbGEtdmFwaS5zaAppbmRleCBkZmRi MGE4ZTUuLjk5ODM3MTAxOSAxMDA2NDQKLS0tIGEvdC92YWxhLXZhcGkuc2gKKysrIGIvdC92YWxh LXZhcGkuc2gKQEAgLTE0LDcgKzE0LDcgQEAKICMgWW91IHNob3VsZCBoYXZlIHJlY2VpdmVkIGEg Y29weSBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UKICMgYWxvbmcgd2l0aCB0aGlz IHByb2dyYW0uICBJZiBub3QsIHNlZSA8aHR0cHM6Ly93d3cuZ251Lm9yZy9saWNlbnNlcy8+Lgog Ci0jIFRlc3QgYW5kIHRoYXQgdmFwaSBmaWxlcyBhcmUgY29ycmVjdGx5IGhhbmRsZWQgYnkgVmFs YSBzdXBwb3J0LgorIyBUZXN0IHRoYXQgdmFwaSBmaWxlcyBhcmUgY29ycmVjdGx5IGhhbmRsZWQg YnkgVmFsYSBzdXBwb3J0LgogCiByZXF1aXJlZD0ncGtnLWNvbmZpZyB2YWxhYyBjYyBHTlVtYWtl JwogLiB0ZXN0LWluaXQuc2gKQEAgLTQyLDcgKzQyLDcgQEAgcHVibGljIGNsYXNzIFphcmRveiB7 CiB9CiBFTkQKIAotIyBVc2UgcHJpbnRmLCBub3QgZWNobywgdG8gYXZvaWQgJ1xuJyBiZWluZyBj b25zaWRlcmVkIGFuZCBlc2NhcGUKKyMgVXNlIHByaW50Ziwgbm90IGVjaG8sIHRvIGF2b2lkICdc bicgYmVpbmcgY29uc2lkZXJlZCBhbiBlc2NhcGUKICMgc2VxdWVuY2UgYW5kIHByaW50ZWQgYXMg YSBuZXdsaW5lIGluICdmb28uaCcuCiBwcmludGYgJyVzXG4nICcjZGVmaW5lIEJBUkJBUiAiWmFy ZG96IVxuIicgPiBmb28uaAogCkBAIC03OCw3ICs3OCw3IEBAIGNyb3NzX2NvbXBpbGluZyB8fCAk TUFLRSB0ZXN0MSB8fCBleGl0IDEKIAogIyBTaW1wbGUgY2hlY2sgb24gcmVtYWtlIHJ1bGVzLgog JHNsZWVwCi0jIFVzZSBwcmludGYsIG5vdCBlY2hvLCB0byBhdm9pZCAnXG4nIGJlaW5nIGNvbnNp ZGVyZWQgYW5kIGVzY2FwZQorIyBVc2UgcHJpbnRmLCBub3QgZWNobywgdG8gYXZvaWQgJ1xuJyBi ZWluZyBjb25zaWRlcmVkIGFuIGVzY2FwZQogIyBzZXF1ZW5jZSBhbmQgcHJpbnRlZCBhcyBhIG5l d2xpbmUgaW4gJ2Zvby5oJy4KIHByaW50ZiAnJXNcbicgJyNkZWZpbmUgQkFaQkFaICJRdXV4IVxu IicgPiBmb28uaAogc2VkICdzL0JBUkJBUi9CQVpCQVovJyB6YXJkb3oudmFsYSA+IHQgJiYgbXYg LWYgdCB6YXJkb3oudmFsYSB8fCBleGl0IDk5Ci0tIAoyLjM0LjEKCg== --00000000000025488306172f5a4f-- From unknown Sun Aug 17 01:22:51 2025 X-Loop: help-debbugs@gnu.org Subject: bug#70557: Fix compilation of Vala files conditionally added to _SOURCES References: Resent-From: Karl Berry Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Mon, 29 Apr 2024 21:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70557 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: rrt@sc3d.org Cc: 70557@debbugs.gnu.org Received: via spool by 70557-submit@debbugs.gnu.org id=B70557.171442619113192 (code B ref 70557); Mon, 29 Apr 2024 21:30:01 +0000 Received: (at 70557) by debbugs.gnu.org; 29 Apr 2024 21:29:51 +0000 Received: from localhost ([127.0.0.1]:58817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s1YZL-0003Qi-D4 for submit@debbugs.gnu.org; Mon, 29 Apr 2024 17:29:51 -0400 Received: from frenzy.freefriends.org ([198.99.81.75]:48584 helo=freefriends.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s1YZF-0003QX-KB for 70557@debbugs.gnu.org; Mon, 29 Apr 2024 17:29:49 -0400 X-Envelope-From: karl@freefriends.org Received: from freefriends.org (localhost [127.0.0.1]) by freefriends.org (8.14.7/8.14.7) with ESMTP id 43TLTN5b010139 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 29 Apr 2024 15:29:23 -0600 Received: (from apache@localhost) by freefriends.org (8.14.7/8.14.7/Submit) id 43TLTNpI010138; Mon, 29 Apr 2024 15:29:23 -0600 Date: Mon, 29 Apr 2024 15:29:23 -0600 Message-Id: <202404292129.43TLTNpI010138@freefriends.org> From: Karl Berry In-Reply-To: X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) so you have to give it all the source files at once, Wow. I guess it is worth documenting this limitation of the current Vala support. If you agree with my reasoning above, then I will prepare a documentation patch based on it. All I know about Vala is what you've written, but given that, I do agree it would be useful to document it. So a doc patch would be most welcome. (The doc fixes in the test comments are fine, of course. I will apply as soon as I have a chance.) Thanks Reuben. -k From unknown Sun Aug 17 01:22:51 2025 X-Loop: help-debbugs@gnu.org Subject: bug#70557: Fix compilation of Vala files conditionally added to _SOURCES Resent-From: Reuben Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Tue, 30 Apr 2024 08:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70557 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: Karl Berry Cc: 70557@debbugs.gnu.org Received: via spool by 70557-submit@debbugs.gnu.org id=B70557.171446430810175 (code B ref 70557); Tue, 30 Apr 2024 08:06:01 +0000 Received: (at 70557) by debbugs.gnu.org; 30 Apr 2024 08:05:08 +0000 Received: from localhost ([127.0.0.1]:59181 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s1iU8-0002e3-83 for submit@debbugs.gnu.org; Tue, 30 Apr 2024 04:05:08 -0400 Received: from mail-yb1-xb33.google.com ([2607:f8b0:4864:20::b33]:42119) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s1iU5-0002dd-2O for 70557@debbugs.gnu.org; Tue, 30 Apr 2024 04:05:06 -0400 Received: by mail-yb1-xb33.google.com with SMTP id 3f1490d57ef6-dcc6fc978ddso4492374276.0 for <70557@debbugs.gnu.org>; Tue, 30 Apr 2024 01:04:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; t=1714464279; x=1715069079; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=PFnaEYhXZ86dpm54DaKCb6PAisiBiocJP9m74bDa6pg=; b=vQ6VbKaL8H5b8u4W+/IwpxUakKgL79trkqElLGPGN811Sa4E0QfITtWl7DITWP0n8s pjW/4bawGG3e2eHcvSHwFlVijFVwg1D7C5Rpm/Bu2A/3aJX7KPf0LaA5tdQVw6pgy+hu ifGWSfdIMzK7Hrw+cJAjaUbp/jztn40heorQ0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714464279; x=1715069079; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PFnaEYhXZ86dpm54DaKCb6PAisiBiocJP9m74bDa6pg=; b=a1YMIuEK7l01WwXQPoCrORu0YQIspGab2sDih6xI1QB/dIYZ4gQ2HnW/tM9WbM5VLR BdOBkm0dOPOqQmXqMP4RTdovyhW9bFJpsxgW3fICVNjtIMrGjCp/0xE8gcQLKZN0WLFz yFW1rEvEDuxDS9dVzDts2r3TB4LNVMkavoOcdUhlG33yxzRxSRsmx08kb66rltwfQYZZ KtyTaWUAK2jlTP3E9YmGsKKZPjfySjmn6nv8XuF/Cqx2S/8Qv2oVeXa2hDWlO4AWND/V pyLkUodVmeQLqyba9AqyPLR390U0xpPNIDn0/Cz1oi1+NENSJ3KA5hB4vNzWRSVfDFzR NC7A== X-Gm-Message-State: AOJu0Yxfr+NDJzNtDAQIez1LMqHPNDl861W9FkPuomO5yfqbpV+lxa35 6ziu2/6U7d5nKGKP/gMoKUkxCHl5UoHZTdliJuf5iftJ7XhKzPTGD2cR3cOExLQJ0SRzLPnXzdz u5/mvU4yKAxVTdkqb/ShATdugztBiZlsMVhiEzejpB/XRQ6xHoJM= X-Google-Smtp-Source: AGHT+IElKz2jo8F4X4qaMh0/xjs7k9meUo4NUnXUxADpelo4/dlCs+idrTOQiCc+YJog0vPYHlAchMVE0JsSvSSAwEo= X-Received: by 2002:a05:6902:2788:b0:dc6:e1ed:bd1c with SMTP id eb8-20020a056902278800b00dc6e1edbd1cmr1250102ybb.21.1714464278446; Tue, 30 Apr 2024 01:04:38 -0700 (PDT) MIME-Version: 1.0 References: <202404292129.43TLTNpI010138@freefriends.org> In-Reply-To: <202404292129.43TLTNpI010138@freefriends.org> From: Reuben Thomas Date: Tue, 30 Apr 2024 10:04:27 +0200 Message-ID: Content-Type: multipart/mixed; boundary="0000000000004c340006174bd294" X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) --0000000000004c340006174bd294 Content-Type: multipart/alternative; boundary="0000000000004c33ff06174bd292" --0000000000004c33ff06174bd292 Content-Type: text/plain; charset="UTF-8" On Mon, 29 Apr 2024 at 23:29, Karl Berry wrote: > > All I know about Vala is what you've written, but given that, I do agree > it would be useful to document it. So a doc patch would be most welcome. > Attached. -- https://rrt.sc3d.org --0000000000004c33ff06174bd292 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Mon, 29 Apr 2024 at 23:29, Karl Berry <karl@freefriends.org> wrote:

All I know about Vala is what you've written, but given that, I do agre= e
it would be useful to document it. So a doc patch would be most welcome.

Attached.

--
<= a href=3D"https://rrt.sc3d.org" target=3D"_blank">https://rrt.sc3d.org<= /div>
--0000000000004c33ff06174bd292-- --0000000000004c340006174bd294 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-doc-update-Vala-documentation.patch" Content-Disposition: attachment; filename="0001-doc-update-Vala-documentation.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lvm3r9230 RnJvbSBlZWFkNjAwZmZjZjNkMmFkNTZmMmRhMjVlYTgzNzFkY2E0MDQzMmVhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSZXViZW4gVGhvbWFzIDxycnRAc2MzZC5vcmc+CkRhdGU6IFR1 ZSwgMzAgQXByIDIwMjQgMDk6NTk6NTggKzAyMDAKU3ViamVjdDogW1BBVENIXSBkb2M6IHVwZGF0 ZSBWYWxhIGRvY3VtZW50YXRpb24KCiogVXBkYXRlIHRoZSBVUkwgZm9yIFZhbGEuCiogRHJvcCB0 aGUgbWVudGlvbiBvZiBhIHZlcnNpb24gcmVxdWlyZW1lbnQsIGFzIG5vIGN1cnJlbnQgc3lzdGVt IHdpbGwgaGF2ZSBhCnRvby1vbGQgdmVyc2lvbiBvZiBWYWxhLgoqIE5vdGUgdGhlIHJlc3RyaWN0 aW9uIG9uIGNvbmRpdGlvbmFsIGluY2x1c2lvbiBvZiBzb3VyY2UgZmlsZXMgaW4gKl9TT1VSQ0VT LgotLS0KIGRvYy9hdXRvbWFrZS50ZXhpIHwgMTUgKysrKysrKysrLS0tLS0tCiAxIGZpbGUgY2hh bmdlZCwgOSBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RvYy9h dXRvbWFrZS50ZXhpIGIvZG9jL2F1dG9tYWtlLnRleGkKaW5kZXggZDMwOTA1ZTBmLi5lNDgwNzlm NDQgMTAwNjQ0Ci0tLSBhL2RvYy9hdXRvbWFrZS50ZXhpCisrKyBiL2RvYy9hdXRvbWFrZS50ZXhp CkBAIC03MDIzLDE4ICs3MDIzLDIxIEBAIHRoZSBAY29kZXtfTERGTEFHU30gdmFyaWFibGUgZm9y IHRoZSBwcm9ncmFtLgogQGNpbmRleCBWYWxhIFN1cHBvcnQKIEBjaW5kZXggU3VwcG9ydCBmb3Ig VmFsYQogCi1BdXRvbWFrZSBwcm92aWRlcyBpbml0aWFsIHN1cHBvcnQgZm9yIFZhbGEKLShAdXJl ZntodHRwczovL3d3dy52YWxhLXByb2plY3Qub3JnL30pLgotVGhpcyByZXF1aXJlcyB2YWxhYyB2 ZXJzaW9uIDAuNy4wIG9yIGxhdGVyLCBhbmQgY3VycmVudGx5IHJlcXVpcmVzCi10aGUgdXNlciB0 byB1c2UgR05VIEBjb21tYW5ke21ha2V9LgorQXV0b21ha2Ugc3VwcG9ydHMgVmFsYSAoQHVyZWZ7 aHR0cHM6Ly92YWxhLmRldi99KS4KK1ZhbGEgc3VwcG9ydCByZXF1aXJlcyB0aGUgdXNlciB0byB1 c2UgR05VIEBjb21tYW5ke21ha2V9LgogCiBAZXhhbXBsZQogZm9vX1NPVVJDRVMgPSBmb28udmFs YSBiYXIudmFsYSB6YXJkb3ouYwogQGVuZCBleGFtcGxlCiAKIEFueSBAZmlsZXsudmFsYX0gZmls ZSBsaXN0ZWQgaW4gYSBAY29kZXtfU09VUkNFU30gdmFyaWFibGUgd2lsbCBiZQotY29tcGlsZWQg aW50byBDIGNvZGUgYnkgdGhlIFZhbGEgY29tcGlsZXIuIFRoZSBnZW5lcmF0ZWQgQGZpbGV7LmN9 IGZpbGVzCi1hcmUgZGlzdHJpYnV0ZWQuIFRoZSBlbmQgdXNlciBkb2VzIG5vdCBuZWVkIHRvIGhh dmUgYSBWYWxhIGNvbXBpbGVyIGluc3RhbGxlZC4KK2NvbXBpbGVkIGludG8gQyBjb2RlIGJ5IHRo ZSBWYWxhIGNvbXBpbGVyLiAgVGhlIGdlbmVyYXRlZCBAZmlsZXsuY30KK2ZpbGVzIGFyZSBkaXN0 cmlidXRlZC4gVGhlIGVuZCB1c2VyIGRvZXMgbm90IG5lZWQgdG8gaGF2ZSBhIFZhbGEKK2NvbXBp bGVyIGluc3RhbGxlZC4gIEJlY2F1c2UgYWxsIEMgZmlsZXMgbXVzdCBiZSBnZW5lcmF0ZWQsIGFu ZCB0aGUgVmFsYQorY29tcGlsZXIgY29tcGlsZXMgYWxsIHRoZSBAZmlsZXsudmFsYX0gZmlsZXMg Zm9yIGEgdGFyZ2V0IGF0IG9uY2UsIGl0IGlzCitub3QgcG9zc2libGUgdG8gYWRkIGZpbGVzIHRv IGEgQGNvZGV7X1NPVVJDRVN9IHZhcmlhYmxlIHRoYXQgY2Fubm90IGJlCitjb21waWxlZCB0b2dl dGhlcjsgZm9yIGV4YW1wbGUsIGFsdGVybmF0aXZlIHBsYXRmb3JtLXNwZWNpZmljCitkZWZpbml0 aW9ucyBvZiB0aGUgc2FtZSBtZXRob2RzLgogCiBBdXRvbWFrZSBzaGlwcyB3aXRoIGFuIEF1dG9j b25mIG1hY3JvIGNhbGxlZCBAY29kZXtBTV9QUk9HX1ZBTEFDfQogdGhhdCB3aWxsIGxvY2F0ZSB0 aGUgVmFsYSBjb21waWxlciBhbmQgb3B0aW9uYWxseSBjaGVjayBpdHMgdmVyc2lvbgotLSAKMi4z NC4xCgo= --0000000000004c340006174bd294-- From unknown Sun Aug 17 01:22:51 2025 X-Loop: help-debbugs@gnu.org Subject: bug#70557: Fix compilation of Vala files conditionally added to _SOURCES References: Resent-From: Karl Berry Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Mon, 06 May 2024 15:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70557 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: rrt@sc3d.org Cc: 70557@debbugs.gnu.org Received: via spool by 70557-submit@debbugs.gnu.org id=B70557.171500865422791 (code B ref 70557); Mon, 06 May 2024 15:18:02 +0000 Received: (at 70557) by debbugs.gnu.org; 6 May 2024 15:17:34 +0000 Received: from localhost ([127.0.0.1]:38614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s405u-0005vS-F3 for submit@debbugs.gnu.org; Mon, 06 May 2024 11:17:34 -0400 Received: from frenzy.freefriends.org ([198.99.81.75]:53802 helo=freefriends.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s405p-0005vH-Vt; Mon, 06 May 2024 11:17:32 -0400 X-Envelope-From: karl@freefriends.org Received: from freefriends.org (localhost [127.0.0.1]) by freefriends.org (8.14.7/8.14.7) with ESMTP id 446FH2Em022218 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 6 May 2024 09:17:02 -0600 Received: (from apache@localhost) by freefriends.org (8.14.7/8.14.7/Submit) id 446FH1HW022217; Mon, 6 May 2024 09:17:01 -0600 Date: Mon, 6 May 2024 09:17:01 -0600 Message-Id: <202405061517.446FH1HW022217@freefriends.org> From: Karl Berry In-Reply-To: X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thanks for the Vala doc patch, Reuben. Installed and closing. --best, karl. From unknown Sun Aug 17 01:22:51 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Reuben Thomas Subject: bug#70557: closed (Re: bug#70557: Fix compilation of Vala files conditionally added to _SOURCES) Message-ID: References: <202405061517.446FH1HW022217@freefriends.org> X-Gnu-PR-Message: they-closed 70557 X-Gnu-PR-Package: automake Reply-To: 70557@debbugs.gnu.org Date: Mon, 06 May 2024 15:18:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1715008682-22804-1" This is a multi-part message in MIME format... ------------=_1715008682-22804-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #70557: Fix compilation of Vala files conditionally added to _SOURCES which was filed against the automake package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 70557@debbugs.gnu.org. --=20 70557: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D70557 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1715008682-22804-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 70557-done) by debbugs.gnu.org; 6 May 2024 15:17:34 +0000 Received: from localhost ([127.0.0.1]:38612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s405u-0005vQ-8A for submit@debbugs.gnu.org; Mon, 06 May 2024 11:17:34 -0400 Received: from frenzy.freefriends.org ([198.99.81.75]:53802 helo=freefriends.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s405p-0005vH-Vt; Mon, 06 May 2024 11:17:32 -0400 X-Envelope-From: karl@freefriends.org Received: from freefriends.org (localhost [127.0.0.1]) by freefriends.org (8.14.7/8.14.7) with ESMTP id 446FH2Em022218 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 6 May 2024 09:17:02 -0600 Received: (from apache@localhost) by freefriends.org (8.14.7/8.14.7/Submit) id 446FH1HW022217; Mon, 6 May 2024 09:17:01 -0600 Date: Mon, 6 May 2024 09:17:01 -0600 Message-Id: <202405061517.446FH1HW022217@freefriends.org> From: Karl Berry To: rrt@sc3d.org Subject: Re: bug#70557: Fix compilation of Vala files conditionally added to _SOURCES In-Reply-To: X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 70557-done Cc: 70557@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thanks for the Vala doc patch, Reuben. Installed and closing. --best, karl. ------------=_1715008682-22804-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 24 Apr 2024 20:58:08 +0000 Received: from localhost ([127.0.0.1]:60163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzjgs-0002Qg-6e for submit@debbugs.gnu.org; Wed, 24 Apr 2024 16:58:07 -0400 Received: from lists.gnu.org ([2001:470:142::17]:55426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzjgj-0002OG-8u for submit@debbugs.gnu.org; Wed, 24 Apr 2024 16:58:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzjgM-0006N1-9I for bug-automake@gnu.org; Wed, 24 Apr 2024 16:57:34 -0400 Received: from mail-yb1-xb31.google.com ([2607:f8b0:4864:20::b31]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rzjgJ-0000NS-G3 for bug-automake@gnu.org; Wed, 24 Apr 2024 16:57:34 -0400 Received: by mail-yb1-xb31.google.com with SMTP id 3f1490d57ef6-de4665b4969so296456276.2 for ; Wed, 24 Apr 2024 13:57:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; t=1713992250; x=1714597050; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=PVnsU2DNSh8R//944AkSkHrwYLAhTDfVSOVXpE0/sSg=; b=ZJaR14nKph8EPFc7Xh+qD6zF9F3VKatR/rzf+oQMuAeQgQ06Xe3/4j8wQvNfcWhHWe hgTacW98gdLm/l4GLvMBAyyHkX3wRCbQgAMFU7hBPzw397ImxW3dX2xyRr4NGdw/hzZy QQ68PNuRMXM8Dy8G9nQoFDA9efS1u4X+5YKIU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713992250; x=1714597050; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=PVnsU2DNSh8R//944AkSkHrwYLAhTDfVSOVXpE0/sSg=; b=cWIuJBUpfoApRZxmW+17tQ2fvnc0+tj7ZzaVA/jEdE1mC3SJ5PZy4efXsg2PZvF/Jj IW0/ct9QhLmzECgsuGIoPwpGVTGlFGS2L7VR4A/POdAcIjdiG3hIkgORJ8aG6X9xIs5l O/5pY4Mpq6AjMNrMqQydUcjrYcrAo+vUi7wWkEajaVShxzrSOVEtj+ej2YuUP5LAQAhW xZstLNoA5QdMrYo2qf2p66JqB6EERzX0R2s2FtzBf1d3ciUGIO51uHyOUrl79YvVBL+6 dhb3A4zAvwaHwtGRBQs05jDnrRCbUlszP2WxTOP9JazvtGdCyLJzRH+IUviH6ZAaFs90 4mww== X-Gm-Message-State: AOJu0Yw0g78GNSERBZIVNMhthA45YfpiyvcrOPaWZXEdF0YViFT13gz3 5lmszTjkGEqA18YyV0DyIPUoSabsgme+F0lj7cZgydmI5UhwOho71CobbL5/0XAcGtiLBrQgnWW 2mdohIQ62Bu60zQveExPH19dk6UPmFR3aCETqJtQfu3HdT1kx5EGSAg== X-Google-Smtp-Source: AGHT+IGQnFgl1P7JyEBy1eA8X3sKs6KbztlwwR+veo3JqRWnZCF/MUJgQF62jZc2EOi4DRL4xJQz3jQBKz0KMVmZH98= X-Received: by 2002:a25:9c83:0:b0:de4:5eaa:4b5d with SMTP id y3-20020a259c83000000b00de45eaa4b5dmr4148315ybo.46.1713992249768; Wed, 24 Apr 2024 13:57:29 -0700 (PDT) MIME-Version: 1.0 From: Reuben Thomas Date: Wed, 24 Apr 2024 22:57:17 +0200 Message-ID: Subject: Fix compilation of Vala files conditionally added to _SOURCES To: bug-automake Content-Type: multipart/mixed; boundary="000000000000322e8c0616ddeb99" Received-SPF: pass client-ip=2607:f8b0:4864:20::b31; envelope-from=rrt@sc3d.org; helo=mail-yb1-xb31.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --000000000000322e8c0616ddeb99 Content-Type: multipart/alternative; boundary="000000000000322e8a0616ddeb97" --000000000000322e8a0616ddeb97 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I attach two patches. The first is a trivial documentation fix. The second fixes a bug I ran into recently with Vala compilation. I just needed to add some Vala source files to my program that are added to the relevant _SOURCES variable conditionally: if OS_WIN32 libenchant_la_SOURCES +=3D api-windows.vala else libenchant_la_SOURCES +=3D api-posix.vala endif (Motivation: the reason I have to add the files conditionally is two-fold: first, api-windows.vala and api-posix.vala call APIs that are only available on Windows and POSIX systems respectively. In itself, this does not require conditional inclusion; I can use Vala preprocessor directives, just as I would in C. But the Vala compiler generates C files, and I want the user of my package not to need a Vala compiler. Therefore, the generated C code must be independent of build-time configuration. Since the Vala compiler does not generate C preprocessor directives, I have to do conditional inclusion at build time some other way. So, I am doing it by using automake conditionals.) With current automake, something like the following Makefile line is generated: $(builddir)/libenchant_la_vala.stamp: api-windows.vala api-posix.vala=E2=80= =A6 With my patch, the following line is generated instead: $(builddir)/libenchant_la_vala.stamp: $(libenchant_la_SOURCES) Of course, $(libenchant_la_SOURCES) expands to the actual sources. The patch is trivial, so hopefully it's obvious if there's a problem for some reason! I hope I explained well enough what problem I'm trying to solve. --=20 https://rrt.sc3d.org --000000000000322e8a0616ddeb97 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I attach two patches. The first is a tr= ivial documentation fix. The second fixes a bug I ran into recently with Va= la compilation.

I just= needed to add some Vala source files to my program that are added to the r= elevant _SOURCES variable conditionally:

=
if OS_WIN32
libenchant_la_SOURCES +=3D api-windows.va= la
else
libenchant_la_SOURCES +=3D api-posix.vala
endif

(Motivation: the reason I have t= o add the files conditionally is two-fold: first, api-windows.vala and api-= posix.vala call APIs that are only available on Windows and POSIX systems r= espectively. In itself, this does not require conditional inclusion; I can = use Vala preprocessor directives, just as I would in C. But the Vala compil= er generates C files, and I want the user of my package not to need a Vala = compiler. Therefore, the generated C code must be independent of build-time= configuration. Since the Vala compiler does not generate C preprocessor di= rectives, I have to do conditional inclusion at build time some other way. = So, I am doing it by using automake conditionals.)

=
With current automake, something like the following= Makefile line is generated:

$(builddir)/libenchant_la_vala.stamp: api-windows.vala api-posix.v= ala=E2=80=A6

With = my patch, the following line is generated instead:

$(builddir)/libenchant_la_vala.stamp: $(li= benchant_la_SOURCES)

= Of course, $(libenchant_la_SOURCES) expands to the actual sources.

The patch is trivial, so hope= fully it's obvious if there's a problem for some reason! I hope I e= xplained well enough what problem I'm trying to solve.
<= div>
--
--000000000000322e8a0616ddeb97-- --000000000000322e8c0616ddeb99 Content-Type: text/x-patch; charset="UTF-8"; name="0002-vala-do-not-build-Vala-sources-excluded-by-automake-.patch" Content-Disposition: attachment; filename="0002-vala-do-not-build-Vala-sources-excluded-by-automake-.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lveacq891 RnJvbSA0OTA3NzdkYjcxYzIwODZjZmJkM2VjMzU5ZmNlY2E1ZmM4NTMwNDdkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSZXViZW4gVGhvbWFzIDxycnRAc2MzZC5vcmc+CkRhdGU6IFdl ZCwgMjQgQXByIDIwMjQgMjI6NDE6NDggKzAyMDAKU3ViamVjdDogW1BBVENIIDIvMl0gdmFsYTog ZG8gbm90IGJ1aWxkIFZhbGEgc291cmNlcyBleGNsdWRlZCBieSBhdXRvbWFrZQogY29uZGl0aW9u YWxzCk1JTUUtVmVyc2lvbjogMS4wCkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1V VEYtOApDb250ZW50LVRyYW5zZmVyLUVuY29kaW5nOiA4Yml0CgoqIGJpbi9hdXRvbWFrZS5pbjog bWFrZSB0aGUgX3ZhbGEuc3RhbXAgZmlsZSBkZXBlbmQgb24gdGhlIHJlbGV2YW50IF9TT1VSQ0VT CnZhcmlhYmxl4oCZcyB2YWx1ZSwgbm90IHRoZSBmdWxseS1leHBhbmRlZCBsaXN0IG9mIGFsbCBw b3NzaWJsZSBzb3VyY2VzLiBUaGlzCm1lYW5zIHRoYXQgc291cmNlIGZpbGVzIGFkZGVkIGNvbmRp dGlvbmFsbHkgdG8gYSBfU09VUkNFUyB2YXJpYWJsZSB3aWxsIG9ubHkKYmUgYWRkZWQgd2hlbiB0 aGUgY29uZGl0aW9uIGlzIHRydWUuCi0tLQogYmluL2F1dG9tYWtlLmluIHwgMiArLQogMSBmaWxl IGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvYmlu L2F1dG9tYWtlLmluIGIvYmluL2F1dG9tYWtlLmluCmluZGV4IDExMjczMDI2OS4uOTUxMjljMjk0 IDEwMDY0NAotLS0gYS9iaW4vYXV0b21ha2UuaW4KKysrIGIvYmluL2F1dG9tYWtlLmluCkBAIC01 ODg3LDcgKzU4ODcsNyBAQCBzdWIgbGFuZ192YWxhX2ZpbmlzaF90YXJnZXQKICAgbXkgJHN0YW1w ZmlsZSA9ICJcJChidWlsZGRpcikvJHtkZXJpdmVkfV92YWxhLnN0YW1wIjsKIAogICAkb3V0cHV0 X3J1bGVzIC49Ci0gICAgIlwkKGJ1aWxkZGlyKS8ke2Rlcml2ZWR9X3ZhbGEuc3RhbXA6IEB2YWxh X3NvdXJjZXNcbiIuCisgICAgIlwkKGJ1aWxkZGlyKS8ke2Rlcml2ZWR9X3ZhbGEuc3RhbXA6IFwk KCR7ZGVyaXZlZH1fU09VUkNFUylcbiIuCiAjIFNpbmNlIHRoZSBDIGZpbGVzIGdlbmVyYXRlZCBm cm9tIHRoZSB2YWxhIHNvdXJjZXMgZGVwZW5kIG9uIHRoZQogIyAke2Rlcml2ZWR9X3ZhbGEuc3Rh bXAgZmlsZSwgd2UgbXVzdCBlbnN1cmUgaXRzIHRpbWVzdGFtcCBpcyBvbGRlciB0aGFuCiAjIHRo b3NlIG9mIHRoZSBDIGZpbGVzIGdlbmVyYXRlZCBieSB0aGUgdmFsYWMgaW52b2NhdGlvbiBiZWxv dyAodGhpcyBpcwotLSAKMi4zNC4xCgo= --000000000000322e8c0616ddeb99 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-doc-add-missing-close-parenthesis-in-comment.patch" Content-Disposition: attachment; filename="0001-doc-add-missing-close-parenthesis-in-comment.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lveacq7u0 RnJvbSAzMmFkNmRhMmFmMzQ3MjVjYmI3NzFlOGYzODI0MzcwY2QxNWEwNTQwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSZXViZW4gVGhvbWFzIDxycnRAc2MzZC5vcmc+CkRhdGU6IFdl ZCwgMjQgQXByIDIwMjQgMjI6NDE6MTIgKzAyMDAKU3ViamVjdDogW1BBVENIIDEvMl0gZG9jOiBh ZGQgbWlzc2luZyBjbG9zZSBwYXJlbnRoZXNpcyBpbiBjb21tZW50LgoKKiBiaW4vYXV0b21ha2Uu aW46IGFkZCBtaXNzaW5nIGNsb3NlIHBhcmVudGhlc2lzLgotLS0KIGJpbi9hdXRvbWFrZS5pbiB8 IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlm ZiAtLWdpdCBhL2Jpbi9hdXRvbWFrZS5pbiBiL2Jpbi9hdXRvbWFrZS5pbgppbmRleCAxZGM0MGEw MGIuLjExMjczMDI2OSAxMDA2NDQKLS0tIGEvYmluL2F1dG9tYWtlLmluCisrKyBiL2Jpbi9hdXRv bWFrZS5pbgpAQCAtNTgwOSw3ICs1ODA5LDcgQEAgc3ViIGxhbmdfdmFsYV9maW5pc2hfdGFyZ2V0 CiAgICAgICAgICAgIwogICAgICAgICAgICMgVGhlIC1uZXdlciB0ZXN0IGhlcmUgaXMgY2hlY2tp bmcgIkMgZmlsZSBub3Qgb2xkZXIgdGhhbiBWYWxhCiAgICAgICAgICAgIyBmaWxlIiAobm90ICJD IGZpbGUgbmV3ZXIgdGhhbiBWYWxhIGZpbGUiOyBzZWUKLSAgICAgICAgICAjIGh0dHBzOi8vYnVn cy5nbnUub3JnLzQ0NzcyLiBUaGUgbG9nIG1lc3NhZ2Ugb24gdGhlIGNvbW1pdAorICAgICAgICAg ICMgaHR0cHM6Ly9idWdzLmdudS5vcmcvNDQ3NzIgKS4gVGhlIGxvZyBtZXNzYWdlIG9uIHRoZSBj b21taXQKICAgICAgICAgICAjIG1pc2xlYWRpbmdseSBzYXlzICJyZXZlcnNlZCIuCiAgICAgICAg ICAgIwogICAgICAgICAgICRvdXRwdXRfcnVsZXMgLj0gIiRidWlsdF9jX2ZpbGU6IFwkKGJ1aWxk ZGlyKS8ke2Rlcml2ZWR9X3ZhbGEuc3RhbXBcbiIKLS0gCjIuMzQuMQoK --000000000000322e8c0616ddeb99-- ------------=_1715008682-22804-1--