From unknown Sun Aug 10 07:36:29 2025 X-Loop: help-debbugs@gnu.org Subject: bug#70554: [PATCH] Eglot: Add 'command-modes' property to all suitable commands Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: joaotavora@gmail.com, bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Apr 2024 18:47:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 70554 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 70554@debbugs.gnu.org Cc: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Received: via spool by submit@debbugs.gnu.org id=B.171398441022473 (code B ref -1); Wed, 24 Apr 2024 18:47:06 +0000 Received: (at submit) by debbugs.gnu.org; 24 Apr 2024 18:46:50 +0000 Received: from localhost ([127.0.0.1]:59860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzhdn-0005px-Fm for submit@debbugs.gnu.org; Wed, 24 Apr 2024 14:46:50 -0400 Received: from lists.gnu.org ([2001:470:142::17]:38306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzhdj-0005nV-Ty for submit@debbugs.gnu.org; Wed, 24 Apr 2024 14:46:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzhd4-0007an-5R for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2024 14:46:05 -0400 Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rzhd1-0006ne-SW for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2024 14:46:01 -0400 Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2db13ca0363so1914631fa.3 for ; Wed, 24 Apr 2024 11:45:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713984357; x=1714589157; darn=gnu.org; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=4ElfCVksfQ8qtI0lcM7JMFOcTTW++wfGvVP5f21sEJY=; b=RChfEH6VwO+3y/V8eevtrVtDtnHLDhHpHoe0jjlEBo4WaZ4eEanCP3QVNjuXjWn8Gt gJhLoR1xvRc4Zr4gzDQo2g/1HLlrbNIBGioCoHpSMMBup9tZ20sBXvUz5VDPFkytZzs6 I01SybuK2AommtUDaIp+YFFvEEkkpKyZhaKKlLo/Wdz3YgQjFCR3mCxhMd7vJBWKPCZj IFlgFbvhNXsctFqSbDMb0U/pBcneFcKy/JX5I+iO1fGJqeASsQNod/SPsiTVAra98H6t c86myNIVV2XLnngf6CPGHbm2NoImtZmz9CWC2qg2HxfiPBtt2mO3eQk26r3jBcZIr9HB I66w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713984357; x=1714589157; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4ElfCVksfQ8qtI0lcM7JMFOcTTW++wfGvVP5f21sEJY=; b=JdlyK1xEXdeWb9/Ob5G5RMlvID6Z3dAO58CQ0ZohfM2T7+k1oLuk9C6s6pSKSvTjsg GY2MAxPjBtI6IOeungS67a47nQBQfkv+eD7kWISJo2PrVtHzzaS+ZuaWQpenzSe9I84D gw/kVDFPNM+86BFjK6yCtYt8ljCHGBOzWOL0gktl4RwoFiTBZulCumSDeZsgB4UGXxa3 XML7fCIxU4x8WMMUzti51RNkjd9nWNzxVC8tGGmmxG09Ea2bS91cqp5R9/AYR3o9G/vS BBcIMfc5fsAoY4Ya6CzLTqn4tTtgNBfn/3wqal+rrhecdCuYUkXpo1gaFeALgb1mLzwj Q/cw== X-Gm-Message-State: AOJu0Yw+j8IqrBQ/et4DAXWVebX6/0pAA6yivhZqEYas0RFq8q5vc0KB i12dAhzWIKwL+ZOgHx6BB2ar8zYeZVF62qnTEY9sB2UYLaID+WNWqCjXFg== X-Google-Smtp-Source: AGHT+IEMgeh7llXQtsv5RMw0VzqwpheANSFHKm7U/SZbUhjpLH+B/HQVbM5ug+tkCmrEHJnVk1xU/w== X-Received: by 2002:a2e:3a0f:0:b0:2de:22b2:ab3d with SMTP id h15-20020a2e3a0f000000b002de22b2ab3dmr2935324lja.7.1713984357066; Wed, 24 Apr 2024 11:45:57 -0700 (PDT) Received: from ars3 ([2a02:8109:8a87:ff00::6223]) by smtp.gmail.com with ESMTPSA id ak1-20020a170906888100b00a55b93c5cddsm3867188ejc.109.2024.04.24.11.45.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 11:45:56 -0700 (PDT) From: Augusto Stoffel Date: Wed, 24 Apr 2024 20:45:54 +0200 Message-ID: <87pluea9b1.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::22a; envelope-from=arstoffel@gmail.com; helo=mail-lj1-x22a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain Tags: patch See attachement. --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Eglot-Add-command-modes-property-to-all-suitable-com.patch >From 39b7e357706b6c7efb37f644d7ff990163c1db25 Mon Sep 17 00:00:00 2001 From: Augusto Stoffel Date: Sun, 21 Apr 2024 11:21:58 +0200 Subject: [PATCH] Eglot: Add 'command-modes' property to all suitable commands Those are the commands that call 'eglot--current-server-or-lose'. * lisp/progmodes/eglot.el (eglot--managed-mode), (eglot-list-connections-mode): Make non-interactive. --- lisp/progmodes/eglot.el | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index efdbfba1075..cddd8994212 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -1978,7 +1978,7 @@ eglot--track-changes (define-minor-mode eglot--managed-mode "Mode for source buffers managed by some Eglot project." - :init-value nil :lighter nil :keymap eglot-mode-map + :init-value nil :lighter nil :keymap eglot-mode-map :interactive nil (cond (eglot--managed-mode (pcase (plist-get (eglot--capabilities (eglot-current-server)) @@ -3951,6 +3951,7 @@ eglot--glob-emit-range (define-derived-mode eglot-list-connections-mode tabulated-list-mode "" "Eglot mode for listing server connections \\{eglot-list-connections-mode-map}" + :interactive nil (setq-local tabulated-list-format `[("Language server" 16) ("Project name" 16) ("Modes handled" 16)]) (tabulated-list-init-header)) @@ -4140,6 +4141,27 @@ eglot-inlay-hints-mode "https://debbugs.gnu.org/%s") (match-string 3)))) +;; Add command-mode property manually for compatibility with Emacs < 28. +(dolist (sym '(eglot-clear-status + eglot-code-action-inline + eglot-code-action-organize-imports + eglot-code-action-quickfix + eglot-code-action-rewrite + eglot-code-action-rewrite + eglot-code-actions + eglot-find-declaration + eglot-find-implementation + eglot-find-typeDefinition + eglot-forget-pending-continuations + eglot-format + eglot-format-buffer + eglot-inlay-hints-mode + eglot-reconnect + eglot-rename + eglot-signal-didChangeConfiguration + eglot-stderr-buffer)) + (function-put sym 'command-modes '(eglot--managed-mode))) + (provide 'eglot) -- 2.44.0 --=-=-=-- From unknown Sun Aug 10 07:36:29 2025 X-Loop: help-debbugs@gnu.org Subject: bug#70554: [PATCH] Eglot: Add 'command-modes' property to all suitable commands Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Apr 2024 09:35:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70554 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Augusto Stoffel Cc: 70554@debbugs.gnu.org, joaotavora@gmail.com Received: via spool by 70554-submit@debbugs.gnu.org id=B70554.17142104856196 (code B ref 70554); Sat, 27 Apr 2024 09:35:05 +0000 Received: (at 70554) by debbugs.gnu.org; 27 Apr 2024 09:34:45 +0000 Received: from localhost ([127.0.0.1]:38935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0eSC-0001bq-Lw for submit@debbugs.gnu.org; Sat, 27 Apr 2024 05:34:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0eSA-0001aY-Ql for 70554@debbugs.gnu.org; Sat, 27 Apr 2024 05:34:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s0eRm-0005kz-Lb; Sat, 27 Apr 2024 05:34:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=4TsLJM5GPB8gtM+W69UV7Kf0fcvoaIiVMq2vS9ZXVno=; b=G6Lx/hD3txNPq65L6NgV h+yLJdq7xEyleGQ7utOqdFiWjuMtUXNSZVljlc0RNx2oCl3Vm0cmHTkUjBTGyjRp4hsaRbQyQ1fJ4 D7QzsctLuMgKZj9BVXAI64jnFyGBxoQMifBFugoeTBNavcD9USwHjQMWsvBRxzetG6TwzWrn3qF3O HyDo43R0TAFPRW4mItCZcZBPcOGIJFz1Rpkx9pwDSjW5TbvFQuQMmW7Kn6NladBVwPjXwAWwA3KZN VLI0Cl3e8BVF+xWCfV7KqDYmimQjkbh5UYH7M1Ga3Rialb1vpci+rVVfDPvL/xe1RMDJ0boN3rRGV LvkPIKC/jrn2zg==; Date: Sat, 27 Apr 2024 12:34:15 +0300 Message-Id: <86cyqbw3mw.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87pluea9b1.fsf@gmail.com> (message from Augusto Stoffel on Wed, 24 Apr 2024 20:45:54 +0200) References: <87pluea9b1.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: João Távora > From: Augusto Stoffel > Date: Wed, 24 Apr 2024 20:45:54 +0200 > > See attachement. Thanks. João, any comments, or should I install this? From unknown Sun Aug 10 07:36:29 2025 X-Loop: help-debbugs@gnu.org Subject: bug#70554: [PATCH] Eglot: Add 'command-modes' property to all suitable commands Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Apr 2024 09:48:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70554 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 70554@debbugs.gnu.org, Augusto Stoffel Received: via spool by 70554-submit@debbugs.gnu.org id=B70554.171421123215608 (code B ref 70554); Sat, 27 Apr 2024 09:48:04 +0000 Received: (at 70554) by debbugs.gnu.org; 27 Apr 2024 09:47:12 +0000 Received: from localhost ([127.0.0.1]:38964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0eeD-000432-70 for submit@debbugs.gnu.org; Sat, 27 Apr 2024 05:47:12 -0400 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]:47379) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0ee8-00040U-6b for 70554@debbugs.gnu.org; Sat, 27 Apr 2024 05:47:06 -0400 Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-516ef30b16eso3320254e87.3 for <70554@debbugs.gnu.org>; Sat, 27 Apr 2024 02:46:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714211199; x=1714815999; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=9X5Fa6TK/OCwL+/5DRsGmk5vB9Q77RdxT6yMXoiReBc=; b=dCIy1SBRqsb+j+p5sn1bJ0I7KF7LU5uPsG+n0QT0Khzsrj4XU95KrsECcIaickEl8r uJ7g3es8GJLeriZtIKHMTKjTXhVFuZr7sLbHHOQOdhkeeK7qQRrnHCYFCkCDKfHI6/mK q1U6UGjNcsEvqzvkoY1mHQO9B0IjiOsUA6q1p/spoFY/vjDeZydx85Br3Vp3/9kn/a/B 07jEX8fagCoP2OoP5TGbhoJYUVQlNo7soQ/tFw3eT4+EFSRgcHivkfvaCJ0sNYL91p4k LrsnYv55iGdxI5YXJFgaD9BIYvjDEElPy4xgnJ239sBsD39mYCBCoFZPpNMv0SqOd7Uv wP+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714211199; x=1714815999; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9X5Fa6TK/OCwL+/5DRsGmk5vB9Q77RdxT6yMXoiReBc=; b=ikHv6KHYi7tr17hp0AQe0rTaufbaQTTx+X41h9iEjZF+3MiaWjw//zrneV2Vp/7Cmu PFY8dq/JryOgWyWfo5MWNOEzQ5h2u1ttL88Dh/51BnXPlC9rJU4MuphMlb5ojjYm1ISH CFopdR4hE5jrxWHDsv02/N1u5Vwbf5QFFo/fhQxIbzqFO+JfHWqmpoZncRZyIxUFD2RX 4Cd2eCqr5D/ohKA4k8jhYqf7oBKtQZDjnetL3otIEL+SXiNVBTizvC88cCBN2SIQCRco i/kaxoLxaC61NnruaoHOIzeTNWJ4iJN8ZlYd23v0kdLQIAFMaWFLeWTD2DmuW8GcbJhk IWpA== X-Forwarded-Encrypted: i=1; AJvYcCWbD8V5FuIxgkq8/MMZdscoLodzHYbv1OHOso3vUlpEUyZPdIVyLUH0TgME5lXFdmGZSOPSISJCZsNumioLFKP4G+icgOU= X-Gm-Message-State: AOJu0YydmhkLizWajHVMV+IAEJ6HMqwqgvczWvrQoXA3vEKnZgQMDuek 80oLf0K3/FOjsRN1rHnmJi1fIUx0bLpzUisU90mbqeC22qVmVtrU0Z0Pk/acvN5YmAbrCmohlSy 58gNcRljUaCc/FnI/fEOX4Kh1roo= X-Google-Smtp-Source: AGHT+IHUoaSaZAMiaD6DuljWvuDAWJr/EiyZXvpGO+gAC1ADfjCNGV3CLOwlEbu+o3mJl0L5pr1JK8SzaZGMEwPKefc= X-Received: by 2002:a19:7716:0:b0:51a:c913:a9ce with SMTP id s22-20020a197716000000b0051ac913a9cemr2557018lfc.50.1714211198932; Sat, 27 Apr 2024 02:46:38 -0700 (PDT) MIME-Version: 1.0 References: <87pluea9b1.fsf@gmail.com> <86cyqbw3mw.fsf@gnu.org> In-Reply-To: <86cyqbw3mw.fsf@gnu.org> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Sat, 27 Apr 2024 10:46:27 +0100 Message-ID: Content-Type: multipart/alternative; boundary="000000000000952287061710e5bf" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000952287061710e5bf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Apr 27, 2024 at 10:34=E2=80=AFAM Eli Zaretskii wrote= : > > Cc: Jo=C3=A3o T=C3=A1vora > > From: Augusto Stoffel > > Date: Wed, 24 Apr 2024 20:45:54 +0200 > > > > See attachement. > > Thanks. > > Jo=C3=A3o, any comments, or should I install this? > Isn't there a way to say this near where the commands are defined, perhaps near the `interactive` which marks a given function as a command? If there isn't, just install this, perhaps with a tweak to the commit message mentioning the top level form, and thanks. Jo=C3=A3o --000000000000952287061710e5bf Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sat, Apr 27, 2024 at 10:34=E2=80=AFAM Eli Zaretskii <eliz@gnu.org> wrote:
<= div class=3D"gmail_quote">
> Cc: Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com>
> From: Augusto Stoffel <arstoffel@gmail.com>
> Date: Wed, 24 Apr 2024 20:45:54 +0200
>
> See attachement.

Thanks.

Jo=C3=A3o, any comments, or should I install this?

Isn't there a way to say this= near where the commands are defined,
perhaps near the `interacti= ve` which marks a given function as a=C2=A0
command?=C2=A0 If the= re isn't, just install this, perhaps with a tweak=C2=A0
to th= e commit=C2=A0messag= e mentioning the top level form, and thanks.

Jo=C3=A3o --000000000000952287061710e5bf-- From unknown Sun Aug 10 07:36:29 2025 X-Loop: help-debbugs@gnu.org Subject: bug#70554: [PATCH] Eglot: Add 'command-modes' property to all suitable commands Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Apr 2024 18:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70554 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: Eli Zaretskii , 70554@debbugs.gnu.org Received: via spool by 70554-submit@debbugs.gnu.org id=B70554.17144143662810 (code B ref 70554); Mon, 29 Apr 2024 18:13:02 +0000 Received: (at 70554) by debbugs.gnu.org; 29 Apr 2024 18:12:46 +0000 Received: from localhost ([127.0.0.1]:58509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s1VUb-0000jG-O2 for submit@debbugs.gnu.org; Mon, 29 Apr 2024 14:12:46 -0400 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]:50329) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s1VUZ-0000j6-5p for 70554@debbugs.gnu.org; Mon, 29 Apr 2024 14:12:45 -0400 Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-a58ebdd8b64so226777966b.0 for <70554@debbugs.gnu.org>; Mon, 29 Apr 2024 11:12:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714414336; x=1715019136; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=f0/ASSra8jyMNE73x3z3qrG4akNb57KpZDM4sSywjHA=; b=Kx3t9Jk93z3Nu1meuzfCwrFmIJrn4Ab2PD5AI5e+Uj5+3GnSBNRJ/g8+t9IUNc+QgB UX2Le3ppPHm26j3PKCJqA7x6S2BwsfEHiTfmoQsqUCvR+bwBlItKhrPeXzN8igR6X4Au WAU3RTNJBGF80nk2JlTe+XSCQ7jK1ymwOXr45/+ZkMj6TH8RVhZdlZiOmh7aFYODgU7G 2JDqjD4YgzEB12nJ9gVK2jTi6AMTjFqpqff9HVQv44Atk9Lfx5UbZOqTBacAk/XpFhUo KD0gJhLFlE9sPQaEYBgn4nQF+zVKUDz2Rz9LZ3wyqJx3RSgOhBBTsUHFVtN5i14Qg5/t hXAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714414336; x=1715019136; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=f0/ASSra8jyMNE73x3z3qrG4akNb57KpZDM4sSywjHA=; b=oAdjytMj6+lgS1QIVmX+HLdVYOHeLbWf284uF61Dz9x0RrHlSfi+DqXy1iT8Y139ot PspzZqxLu0hnLB3wtaF87P65kABXR3uK+p0WL3HMNVQXj14uhyX+yhfx8ZYRhw10QFLm z7n7XMLv7Z0rd15FlZVLv0mvEQJmqCCaaY9IeKCMY1rzQ5K6Cnt1W4QQg7/bGjWuzHVp X6uM2rdM8r/k43lvTo2NyYR223IkpIu33/fLwtpV6G3/93dYM4+Tvw1nyxVjGaw5Yltw V04+IgNSBTDfSuKdCTZ8IGd2jFpPPzSnl13M6V2quEZXr/X96O4EuM1BkTYXr9GwgBNU yzdA== X-Forwarded-Encrypted: i=1; AJvYcCXSNigTYJtu2EL6yDWditOrlMeHMzAqTiny68epxyLtGe023i8TZ7OS5fiXju+wj8ZsK3Q7jBP90eee18fCkzQL9y6lxvg= X-Gm-Message-State: AOJu0Yw6RRek6YMPGtlfCx0sahhKl4pYnlZ3HxsYoAu5M9PCYhrsUcdh GpdebmPHIJuODsqt9zTs4PXM3XIggJyQvlj0gUBnyCZHWJEVPibLyUr2tg== X-Google-Smtp-Source: AGHT+IEK/rvE1DO0xaAPnY/VHs42pKIef29x3qXzF+cbMIdBTGjkR8ACVhxwMuFI/K2brCn3o5BOfg== X-Received: by 2002:a17:906:b210:b0:a55:387b:eef9 with SMTP id p16-20020a170906b21000b00a55387beef9mr7761997ejz.10.1714414336288; Mon, 29 Apr 2024 11:12:16 -0700 (PDT) Received: from ars3 ([2a02:8109:8a87:ff00::6223]) by smtp.gmail.com with ESMTPSA id a4-20020a170906368400b00a4e48e52ecbsm14058632ejc.198.2024.04.29.11.12.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Apr 2024 11:12:15 -0700 (PDT) From: Augusto Stoffel In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Sat, 27 Apr 2024 10:46:27 +0100") References: <87pluea9b1.fsf@gmail.com> <86cyqbw3mw.fsf@gnu.org> Date: Mon, 29 Apr 2024 20:12:14 +0200 Message-ID: <87frv4f37l.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, 27 Apr 2024 at 10:46, Jo=C3=A3o T=C3=A1vora wrote: > Isn't there a way to say this near where the commands are defined, > perhaps near the `interactive` which marks a given function as a=20 > command? If there isn't, just install this, perhaps with a tweak=20 > to the commit message mentioning the top level form, and thanks. This is not possible while keeping compatibility with older Emacs versions. There's already a comment to that effect in the patch, so the change you mention can be made in the future. From unknown Sun Aug 10 07:36:29 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Augusto Stoffel Subject: bug#70554: closed (Re: bug#70554: [PATCH] Eglot: Add 'command-modes' property to all suitable commands) Message-ID: References: <86frv0mw8o.fsf@gnu.org> <87pluea9b1.fsf@gmail.com> X-Gnu-PR-Message: they-closed 70554 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 70554@debbugs.gnu.org Date: Thu, 02 May 2024 08:53:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1714639982-21467-1" This is a multi-part message in MIME format... ------------=_1714639982-21467-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #70554: [PATCH] Eglot: Add 'command-modes' property to all suitable commands which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 70554@debbugs.gnu.org. --=20 70554: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D70554 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1714639982-21467-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 70554-done) by debbugs.gnu.org; 2 May 2024 08:52:54 +0000 Received: from localhost ([127.0.0.1]:42466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2SBS-0005a3-Cf for submit@debbugs.gnu.org; Thu, 02 May 2024 04:52:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2SBR-0005Zx-2R for 70554-done@debbugs.gnu.org; Thu, 02 May 2024 04:52:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2SAz-0006XA-SN; Thu, 02 May 2024 04:52:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=YlW2EDPVcQ0pcIXXoI9u8snb6MWh+BVKgSoxDgkQRWg=; b=DF03wE1WDds5hIENkWQk AN1ADs4fWkufw5eQ7nEk0a7OS2C2ftvScW3Bb/DWFDcJeVOvMj8NoffWptEUW9PpXcnTIHaAanohs nNwUVaEqAK2QaXipAcj8xv15s3paSQAcar29UFOMEg7dqs5dB3j+cKJSJlkxLwWwCMThxpojEviTx 7d4ND1R43fOpdbrf3LzbEskGLUWE1TmuzH43Y4dJQTYweFOVIv7crS4DNdryuIV698B4s+3yo6Yc+ LegDhmlx23BhB3oqPkuNZUxDKXvy3ioG4fNUtV6NCl2CqZR5McrBHPTC/ZWy1lmxl6ea62Pk7vtZo jS/RdyRXKeUg6g==; Date: Thu, 02 May 2024 11:52:23 +0300 Message-Id: <86frv0mw8o.fsf@gnu.org> From: Eli Zaretskii To: Augusto Stoffel In-Reply-To: <87frv4f37l.fsf@gmail.com> (message from Augusto Stoffel on Mon, 29 Apr 2024 20:12:14 +0200) Subject: Re: bug#70554: [PATCH] Eglot: Add 'command-modes' property to all suitable commands References: <87pluea9b1.fsf@gmail.com> <86cyqbw3mw.fsf@gnu.org> <87frv4f37l.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70554-done Cc: 70554-done@debbugs.gnu.org, joaotavora@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Augusto Stoffel > Cc: Eli Zaretskii , 70554@debbugs.gnu.org > Date: Mon, 29 Apr 2024 20:12:14 +0200 > > On Sat, 27 Apr 2024 at 10:46, João Távora wrote: > > > Isn't there a way to say this near where the commands are defined, > > perhaps near the `interactive` which marks a given function as a > > command? If there isn't, just install this, perhaps with a tweak > > to the commit message mentioning the top level form, and thanks. > > This is not possible while keeping compatibility with older Emacs > versions. There's already a comment to that effect in the patch, so the > change you mention can be made in the future. Thanks, so I've now installed this on the master branch, and I'm therefore closing this bug. ------------=_1714639982-21467-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 24 Apr 2024 18:46:50 +0000 Received: from localhost ([127.0.0.1]:59860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzhdn-0005px-Fm for submit@debbugs.gnu.org; Wed, 24 Apr 2024 14:46:50 -0400 Received: from lists.gnu.org ([2001:470:142::17]:38306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzhdj-0005nV-Ty for submit@debbugs.gnu.org; Wed, 24 Apr 2024 14:46:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzhd4-0007an-5R for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2024 14:46:05 -0400 Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rzhd1-0006ne-SW for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2024 14:46:01 -0400 Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2db13ca0363so1914631fa.3 for ; Wed, 24 Apr 2024 11:45:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713984357; x=1714589157; darn=gnu.org; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=4ElfCVksfQ8qtI0lcM7JMFOcTTW++wfGvVP5f21sEJY=; b=RChfEH6VwO+3y/V8eevtrVtDtnHLDhHpHoe0jjlEBo4WaZ4eEanCP3QVNjuXjWn8Gt gJhLoR1xvRc4Zr4gzDQo2g/1HLlrbNIBGioCoHpSMMBup9tZ20sBXvUz5VDPFkytZzs6 I01SybuK2AommtUDaIp+YFFvEEkkpKyZhaKKlLo/Wdz3YgQjFCR3mCxhMd7vJBWKPCZj IFlgFbvhNXsctFqSbDMb0U/pBcneFcKy/JX5I+iO1fGJqeASsQNod/SPsiTVAra98H6t c86myNIVV2XLnngf6CPGHbm2NoImtZmz9CWC2qg2HxfiPBtt2mO3eQk26r3jBcZIr9HB I66w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713984357; x=1714589157; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4ElfCVksfQ8qtI0lcM7JMFOcTTW++wfGvVP5f21sEJY=; b=JdlyK1xEXdeWb9/Ob5G5RMlvID6Z3dAO58CQ0ZohfM2T7+k1oLuk9C6s6pSKSvTjsg GY2MAxPjBtI6IOeungS67a47nQBQfkv+eD7kWISJo2PrVtHzzaS+ZuaWQpenzSe9I84D gw/kVDFPNM+86BFjK6yCtYt8ljCHGBOzWOL0gktl4RwoFiTBZulCumSDeZsgB4UGXxa3 XML7fCIxU4x8WMMUzti51RNkjd9nWNzxVC8tGGmmxG09Ea2bS91cqp5R9/AYR3o9G/vS BBcIMfc5fsAoY4Ya6CzLTqn4tTtgNBfn/3wqal+rrhecdCuYUkXpo1gaFeALgb1mLzwj Q/cw== X-Gm-Message-State: AOJu0Yw+j8IqrBQ/et4DAXWVebX6/0pAA6yivhZqEYas0RFq8q5vc0KB i12dAhzWIKwL+ZOgHx6BB2ar8zYeZVF62qnTEY9sB2UYLaID+WNWqCjXFg== X-Google-Smtp-Source: AGHT+IEMgeh7llXQtsv5RMw0VzqwpheANSFHKm7U/SZbUhjpLH+B/HQVbM5ug+tkCmrEHJnVk1xU/w== X-Received: by 2002:a2e:3a0f:0:b0:2de:22b2:ab3d with SMTP id h15-20020a2e3a0f000000b002de22b2ab3dmr2935324lja.7.1713984357066; Wed, 24 Apr 2024 11:45:57 -0700 (PDT) Received: from ars3 ([2a02:8109:8a87:ff00::6223]) by smtp.gmail.com with ESMTPSA id ak1-20020a170906888100b00a55b93c5cddsm3867188ejc.109.2024.04.24.11.45.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 11:45:56 -0700 (PDT) From: Augusto Stoffel To: bug-gnu-emacs@gnu.org Subject: [PATCH] Eglot: Add 'command-modes' property to all suitable commands X-Debbugs-Cc: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Wed, 24 Apr 2024 20:45:54 +0200 Message-ID: <87pluea9b1.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::22a; envelope-from=arstoffel@gmail.com; helo=mail-lj1-x22a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain Tags: patch See attachement. --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Eglot-Add-command-modes-property-to-all-suitable-com.patch >From 39b7e357706b6c7efb37f644d7ff990163c1db25 Mon Sep 17 00:00:00 2001 From: Augusto Stoffel Date: Sun, 21 Apr 2024 11:21:58 +0200 Subject: [PATCH] Eglot: Add 'command-modes' property to all suitable commands Those are the commands that call 'eglot--current-server-or-lose'. * lisp/progmodes/eglot.el (eglot--managed-mode), (eglot-list-connections-mode): Make non-interactive. --- lisp/progmodes/eglot.el | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index efdbfba1075..cddd8994212 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -1978,7 +1978,7 @@ eglot--track-changes (define-minor-mode eglot--managed-mode "Mode for source buffers managed by some Eglot project." - :init-value nil :lighter nil :keymap eglot-mode-map + :init-value nil :lighter nil :keymap eglot-mode-map :interactive nil (cond (eglot--managed-mode (pcase (plist-get (eglot--capabilities (eglot-current-server)) @@ -3951,6 +3951,7 @@ eglot--glob-emit-range (define-derived-mode eglot-list-connections-mode tabulated-list-mode "" "Eglot mode for listing server connections \\{eglot-list-connections-mode-map}" + :interactive nil (setq-local tabulated-list-format `[("Language server" 16) ("Project name" 16) ("Modes handled" 16)]) (tabulated-list-init-header)) @@ -4140,6 +4141,27 @@ eglot-inlay-hints-mode "https://debbugs.gnu.org/%s") (match-string 3)))) +;; Add command-mode property manually for compatibility with Emacs < 28. +(dolist (sym '(eglot-clear-status + eglot-code-action-inline + eglot-code-action-organize-imports + eglot-code-action-quickfix + eglot-code-action-rewrite + eglot-code-action-rewrite + eglot-code-actions + eglot-find-declaration + eglot-find-implementation + eglot-find-typeDefinition + eglot-forget-pending-continuations + eglot-format + eglot-format-buffer + eglot-inlay-hints-mode + eglot-reconnect + eglot-rename + eglot-signal-didChangeConfiguration + eglot-stderr-buffer)) + (function-put sym 'command-modes '(eglot--managed-mode))) + (provide 'eglot) -- 2.44.0 --=-=-=-- ------------=_1714639982-21467-1--