GNU bug report logs - #70554
[PATCH] Eglot: Add 'command-modes' property to all suitable commands

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 70554 in the body.
You can then email your comments to 70554 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Augusto Stoffel <arstoffel <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Eglot: Add 'command-modes' property to all suitable commands
Date: Wed, 24 Apr 2024 20:45:54 +0200

[Message part 1 (text/plain, inline)]

Tags: patch

See attachement.

[0001-Eglot-Add-command-modes-property-to-all-suitable-com.patch (text/patch, attachment)]

Message #8 received at 70554 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Augusto Stoffel <arstoffel <at> gmail.com>
Cc: 70554 <at> debbugs.gnu.org, joaotavora <at> gmail.com
Subject: Re: bug#70554: [PATCH] Eglot: Add 'command-modes' property to all
 suitable commands
Date: Sat, 27 Apr 2024 12:34:15 +0300

> Cc: João Távora <joaotavora <at> gmail.com>
> From: Augusto Stoffel <arstoffel <at> gmail.com>
> Date: Wed, 24 Apr 2024 20:45:54 +0200
> 
> See attachement.

Thanks.

João, any comments, or should I install this?

Message #11 received at 70554 <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 70554 <at> debbugs.gnu.org, Augusto Stoffel <arstoffel <at> gmail.com>
Subject: Re: bug#70554: [PATCH] Eglot: Add 'command-modes' property to all
 suitable commands
Date: Sat, 27 Apr 2024 10:46:27 +0100

[Message part 1 (text/plain, inline)]

On Sat, Apr 27, 2024 at 10:34 AM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > Cc: João Távora <joaotavora <at> gmail.com>
> > From: Augusto Stoffel <arstoffel <at> gmail.com>
> > Date: Wed, 24 Apr 2024 20:45:54 +0200
> >
> > See attachement.
>
> Thanks.
>
> João, any comments, or should I install this?
>

Isn't there a way to say this near where the commands are defined,
perhaps near the `interactive` which marks a given function as a
command?  If there isn't, just install this, perhaps with a tweak
to the commit message mentioning the top level form, and thanks.

João

[Message part 2 (text/html, inline)]

Message #14 received at 70554 <at> debbugs.gnu.org (full text, mbox):

From: Augusto Stoffel <arstoffel <at> gmail.com>
To: João Távora <joaotavora <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 70554 <at> debbugs.gnu.org
Subject: Re: bug#70554: [PATCH] Eglot: Add 'command-modes' property to all
 suitable commands
Date: Mon, 29 Apr 2024 20:12:14 +0200

On Sat, 27 Apr 2024 at 10:46, João Távora wrote:

> Isn't there a way to say this near where the commands are defined,
> perhaps near the `interactive` which marks a given function as a 
> command?  If there isn't, just install this, perhaps with a tweak 
> to the commit message mentioning the top level form, and thanks.

This is not possible while keeping compatibility with older Emacs
versions.  There's already a comment to that effect in the patch, so the
change you mention can be made in the future.

Message #19 received at 70554-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Augusto Stoffel <arstoffel <at> gmail.com>
Cc: 70554-done <at> debbugs.gnu.org, joaotavora <at> gmail.com
Subject: Re: bug#70554: [PATCH] Eglot: Add 'command-modes' property to all
 suitable commands
Date: Thu, 02 May 2024 11:52:23 +0300

> From: Augusto Stoffel <arstoffel <at> gmail.com>
> Cc: Eli Zaretskii <eliz <at> gnu.org>,  70554 <at> debbugs.gnu.org
> Date: Mon, 29 Apr 2024 20:12:14 +0200
> 
> On Sat, 27 Apr 2024 at 10:46, João Távora wrote:
> 
> > Isn't there a way to say this near where the commands are defined,
> > perhaps near the `interactive` which marks a given function as a 
> > command?  If there isn't, just install this, perhaps with a tweak 
> > to the commit message mentioning the top level form, and thanks.
> 
> This is not possible while keeping compatibility with older Emacs
> versions.  There's already a comment to that effect in the patch, so the
> change you mention can be made in the future.

Thanks, so I've now installed this on the master branch, and I'm
therefore closing this bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.