From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 23 16:46:25 2024 Received: (at submit) by debbugs.gnu.org; 23 Apr 2024 20:46:25 +0000 Received: from localhost ([127.0.0.1]:54235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzN1y-00033x-6k for submit@debbugs.gnu.org; Tue, 23 Apr 2024 16:46:25 -0400 Received: from lists.gnu.org ([2001:470:142::17]:35918) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzN1r-00031W-FF for submit@debbugs.gnu.org; Tue, 23 Apr 2024 16:46:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzN1U-0000zR-6y for guix-patches@gnu.org; Tue, 23 Apr 2024 16:45:52 -0400 Received: from mail-108-mta184.mxroute.com ([136.175.108.184]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rzN1R-00034j-Sx for guix-patches@gnu.org; Tue, 23 Apr 2024 16:45:51 -0400 Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta184.mxroute.com (ZoneMTA) with ESMTPSA id 18f0cb5162e0003bea.001 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 23 Apr 2024 20:45:45 +0000 X-Zone-Loop: 76b93738f303db7c0b2003857b18bc0e9844bee67037 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freakingpenguin.com; s=x; h=Content-Transfer-Encoding:MIME-Version: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=SsDpLRx3BE0R3JQt5L0TDzv7eIc0si0ITaSyHPts9cU=; b=Qi2VlVlFZ/8JST3MbTO5oMZIH0 UD/d4ZHdiJP7sQC9xONEhWdjy9tUp4rRqygV6iwPsYxeq6HF7f3hJ+wDfW2kuk63X0XKAV/YFnNYe 8vLXSGeZpcTTVUm18M0A3HYICbVmIO7gDCTIUEpjfJ8UJK3EFH61j4ez6AZBZmF6WyKuS2Asv+Ts4 Br5KPLyYAWJ2Cd+3IaJyM/ng0+R/SNEG1bGjOzoogphV6Up6+aHYZPVAb61hwGXDRzHSb90F5U3y5 ViPhn01n1WRsUCGtlpuuI+rMWqTyft9pR9uZeC1bagG97oJuG7TTXzNCh/boV13VBLQuZiKxfW3RK Jss1Lr2w==; From: Richard Sent To: guix-patches@gnu.org Subject: [PATCH 0/4] Improve Shepherd service support for networked file systems Date: Tue, 23 Apr 2024 16:44:47 -0400 Message-ID: MIME-Version: 1.0 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit X-Authenticated-Id: richard@freakingpenguin.com Received-SPF: pass client-ip=136.175.108.184; envelope-from=richard@freakingpenguin.com; helo=mail-108-mta184.mxroute.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: Richard Sent X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) Hi Guix! This patch series aims to improve the experience when using Guix and Shepherd to manage networked file systems. Previously, operating-system file-system entries would all be started before the symbol 'file-systems was provided, which many other Shepherd services depend on. This meant that adding a networked file-system with (mount? #t) would (depending on mount-can-fail?) either halt boot due to 'user-processes (and thus 'networking) not being provisioned, or fail to mount, even though Guix contained the code to sucessfully mount that file system. Now, file system entries can specify arbitrary Shepherd symbols that other services provision. When this is done, that specific file-system entry is not mounted as part of providing 'file-systems. I considered adding a (network?) flag to the file-system record instead, but that wouldn't handle every case (say, if an Avahi .local address was used). So instead I went with the more general approach. Prior workarounds were verbose [1] and required creating a custom service entry. This method allows for reusing code already present in (gnu services base) and (gnu build file-systems). I considered splitting CIFS support into its own patch, but since the support is fairly meaningless without the preceding commits, I figured keeping it was best. This patch series resolves https://issues.guix.gnu.org/46563. Richard Sent (4): file-systems: Add requirements field to file-systems services: base: Use requirements to delay some file-systems file-systems: Add support for mounting CIFS file systems system: Do not check for CIFS file system availability doc/guix.texi | 13 ++++++++ gnu/build/file-systems.scm | 60 ++++++++++++++++++++++++++++++++----- gnu/machine/ssh.scm | 3 +- gnu/services/base.scm | 16 ++++++++-- gnu/system/file-systems.scm | 3 ++ guix/scripts/system.scm | 3 +- 6 files changed, 87 insertions(+), 11 deletions(-) base-commit: 0f68306268773f0eaa4327e1f6fdcb39442e4a34 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 23 16:48:18 2024 Received: (at 70542) by debbugs.gnu.org; 23 Apr 2024 20:48:19 +0000 Received: from localhost ([127.0.0.1]:54255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzN3j-0003NV-Ku for submit@debbugs.gnu.org; Tue, 23 Apr 2024 16:48:18 -0400 Received: from mail-108-mta19.mxroute.com ([136.175.108.19]:46821) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzN3d-0003M9-3a for 70542@debbugs.gnu.org; Tue, 23 Apr 2024 16:48:09 -0400 Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta19.mxroute.com (ZoneMTA) with ESMTPSA id 18f0cb6e2b40003bea.001 for <70542@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 23 Apr 2024 20:47:43 +0000 X-Zone-Loop: 0216e505b7a0a8264361f18032a25031e2a3b3c2cb82 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freakingpenguin.com; s=x; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=v3IW4uFe6Ct60NonFKfWMHf3ECzON50UkPPy5OhczLo=; b=iC/D/0ppWINBDLjJjss8erhdpz 34hfaO4vv5+P5m1U237xZOZmKXfRXvB0uzJ8EecLSJGFW7akMBlBigC3OAYDB89BemIzSLwycvOVD OZzK6OdI85gXP0eBsd0+Fc3W30p+F5lYZ8r2QoaHa2IpxlKPm/iih94cFqIr9oX6HoxWKutE/vLzM PxOe3fdRMyYlJ/oF9Xz+msVZsDuldHpuO5elTCWDT9lsXXyuuMmecTGgOgaoLvJ5P66caQVYf1JkH HxpnEFeh4857UfW657x0ws1M3Hlyp6Bo8hIo3w+BuIqxfVSmcZ4dJe+ay9Vf62BlCj72A87bxBsGX l3lJoeOg==; From: Richard Sent To: 70542@debbugs.gnu.org Subject: [PATCH 1/4] file-systems: Add requirements field to file-systems Date: Tue, 23 Apr 2024 16:47:19 -0400 Message-ID: In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authenticated-Id: richard@freakingpenguin.com X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70542 Cc: Richard Sent X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/system/file-systems.scm (file-system): Add requirements field to the file-system record. This field will be used for adding additional Shepherd requirements to a file system Shepherd service. * doc/guix.texi: Add documentation for file-system requirements. Change-Id: If0392db03d48e8820aa53df1df482c12ec72e1a5 --- doc/guix.texi | 13 +++++++++++++ gnu/system/file-systems.scm | 3 +++ 2 files changed, 16 insertions(+) diff --git a/doc/guix.texi b/doc/guix.texi index 65af136e61..80b24e2de9 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -17751,6 +17751,19 @@ File Systems Another example is a file system that depends on a mapped device, for example for an encrypted partition (@pxref{Mapped Devices}). + +@item @code{requirements} (default: @code{'()}) +This is a list of symbols denoting Shepherd requirements that must be +met before mounting the file system. + +As an example, an NFS file system would typically have a requirement for +@code{networking}. + +Typically, file systems are mounted before most other Shepherd services +are started. However, file systems with a non-empty requirements field +are mounted after Shepherd services have begun. Any Shepherd service +that depends on a file system with a non-empty requirements field must +depend on it directly and not on the generic symbol @code{file-systems}. @end table @end deftp diff --git a/gnu/system/file-systems.scm b/gnu/system/file-systems.scm index af0567bd3e..76a51a2b69 100644 --- a/gnu/system/file-systems.scm +++ b/gnu/system/file-systems.scm @@ -57,6 +57,7 @@ (define-module (gnu system file-systems) file-system-repair file-system-create-mount-point? file-system-dependencies + file-system-requirements file-system-location file-system-type-predicate @@ -185,6 +186,8 @@ (define-record-type* file-system (default #f)) (dependencies file-system-dependencies ; list of (default '())) ; or + (requirements file-system-requirements ; list of symbols + (default '())) (location file-system-location (default (current-source-location)) (innate))) -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 23 16:49:05 2024 Received: (at 70542) by debbugs.gnu.org; 23 Apr 2024 20:49:06 +0000 Received: from localhost ([127.0.0.1]:54263 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzN4Y-0003Wr-9a for submit@debbugs.gnu.org; Tue, 23 Apr 2024 16:49:05 -0400 Received: from mail-108-mta34.mxroute.com ([136.175.108.34]:38921) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzN3d-0003MA-4e for 70542@debbugs.gnu.org; Tue, 23 Apr 2024 16:48:12 -0400 Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta34.mxroute.com (ZoneMTA) with ESMTPSA id 18f0cb6f2a20003bea.001 for <70542@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 23 Apr 2024 20:47:47 +0000 X-Zone-Loop: fb768efe4dcacf4848e89ee4ceeb28903401ea06368c X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freakingpenguin.com; s=x; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=JFnq50DttwZ+qap2nmDE1ZtMkgIdnaAfw2lUNyI0zJs=; b=HqeOuTJXpxzEfIHBnvfI3r28PU uVnrJ/voJ3+DzGk1L5VQLpqLi2VOUsu8qdlbQfbDjFVQsy6UeoiN2o4O+kysHmgEV3L+45fgsWl4/ wWD/CF7jyDEabHbaxym95s5pf2K9ZGy+PztoSzZBILCYqbJiIy8ph1f2ViPlNmIjfzd6Owuag0nZq x9hzs5U6R/kticDvl4jaUJGpixw53GhbnIcmGZl2OnrueA0ePWnebftt4Ugl7I52yys+6IgcCGjS/ mMEVpwHeChTx8hUHNCYlAUuZMuEEsA7bmGdAk9SOg42LjkufNnIjOaHo9nXgfX76HxS2NnBhujorQ 7r73/tCw==; From: Richard Sent To: 70542@debbugs.gnu.org Subject: [PATCH 2/4] services: base: Use requirements to delay some file-systems Date: Tue, 23 Apr 2024 16:47:20 -0400 Message-ID: <91efec381997bd89208d9f4a47141ae6481fb963.1713904784.git.richard@freakingpenguin.com> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authenticated-Id: richard@freakingpenguin.com X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70542 Cc: Richard Sent X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Add a mechanism to only require a subset of file-system entries during early Shepherd initialization. Any file-system with additional Shepherd service requirements (e.g. networking) will be brought up after 'file-systems is provisioned. * gnu/services/base.scm (file-system-shepherd-service): Splice file-system-requirements into the Shepherd service requirement list. * gnu/services/base.scm (file-system-shepherd-services): Provision 'file-system when file-systems that satisfy initial-file-system? are started. Change-Id: I7b1336ee970f4320f7431bef187e66f34f0d718c --- gnu/services/base.scm | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/gnu/services/base.scm b/gnu/services/base.scm index 3f912225a0..af92b700b4 100644 --- a/gnu/services/base.scm +++ b/gnu/services/base.scm @@ -403,6 +403,7 @@ (define (file-system-shepherd-service file-system) (create? (file-system-create-mount-point? file-system)) (mount? (file-system-mount? file-system)) (dependencies (file-system-dependencies file-system)) + (requirements (file-system-requirements file-system)) (packages (file-system-packages (list file-system)))) (and (or mount? create?) (with-imported-modules (source-module-closure @@ -411,7 +412,8 @@ (define (file-system-shepherd-service file-system) (provision (list (file-system->shepherd-service-name file-system))) (requirement `(root-file-system udev - ,@(map dependency->shepherd-service-name dependencies))) + ,@(map dependency->shepherd-service-name dependencies) + ,@requirements)) (documentation "Check, mount, and unmount the given file system.") (start #~(lambda args #$(if create? @@ -460,12 +462,22 @@ (define (file-system-shepherd-services file-systems) (or (file-system-mount? x) (file-system-create-mount-point? x))) file-systems))) + + (define (initial-file-system? file-system) + "Return #t if the file system should be mounted initially or #f." + ;; File systems with additional Shepherd requirements (e.g. networking) + ;; should not be considered initial. Those requirements likely rely on + ;; 'file-systems being provisioned. + (null? (file-system-requirements file-system))) + (define sink (shepherd-service (provision '(file-systems)) (requirement (cons* 'root-file-system 'user-file-systems (map file-system->shepherd-service-name - file-systems))) + ;; Only file systems considered initial should + ;; be required to provision 'file-systems. + (filter initial-file-system? file-systems)))) (documentation "Target for all the initially-mounted file systems") (start #~(const #t)) (stop #~(const #f)))) -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 23 16:49:11 2024 Received: (at 70542) by debbugs.gnu.org; 23 Apr 2024 20:49:13 +0000 Received: from localhost ([127.0.0.1]:54265 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzN4b-0003XQ-Qk for submit@debbugs.gnu.org; Tue, 23 Apr 2024 16:49:11 -0400 Received: from mail-108-mta217.mxroute.com ([136.175.108.217]:38211) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzN3h-0003N5-VT for 70542@debbugs.gnu.org; Tue, 23 Apr 2024 16:48:17 -0400 Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta217.mxroute.com (ZoneMTA) with ESMTPSA id 18f0cb701b30003bea.001 for <70542@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 23 Apr 2024 20:47:51 +0000 X-Zone-Loop: 20718e557b230361005c5e9978407a7cec17626c1460 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freakingpenguin.com; s=x; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=hF0faV2T67I+4RAauNmiSl9RRGb3R2Gw5DORSuQpHLg=; b=iKHYhzqAu+M0UDae3lX/b0oxU6 xU7k54SXSiGWt0zaAh5sh7IV87wEpsx8k0o9Z4Ty3jDjmWq5Au8ODHpLTg5hl3boco8dLYQauNmLZ KhfhDA8wDAhAXFI2yc0bTg8qHlBi2IQkqbkZvv2WhOL6D8IXaj+xSPNuHEKv9WPUs2LwuDmy+JQMm CrFRD4tkTCScAyimVdOGAD6Iub0I6f/OFCZWIulBYk1hwqeMeUe+m3t7Cgz5Q42OwPgaFXEp7Wgga L3bCAHzGDOtOCMr2jdOgcgrxnVOncgXHQYpII2UUVb7YKx9xlNyT+6tssFzhkdYfYlESVAM26VFEI /7yn1DZQ==; From: Richard Sent To: 70542@debbugs.gnu.org Subject: [PATCH 3/4] file-systems: Add support for mounting CIFS file systems Date: Tue, 23 Apr 2024 16:47:21 -0400 Message-ID: In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Authenticated-Id: richard@freakingpenguin.com X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70542 Cc: Richard Sent X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/build/file-systems (canonicalize-device-name): Do not attempt to resolve CIFS formatted device specifications. * gnu/build/file-systems (mount-file-system): Add (mount-cifs) and (host-to-ip). Logic for ip/host to ip resolution was duplicated with mount-nfs, so isolate into a dedicated function. Change-Id: I522d70a10651ca79533a4fc60b96b884243a3526 --- gnu/build/file-systems.scm | 60 +++++++++++++++++++++++++++++++++----- 1 file changed, 53 insertions(+), 7 deletions(-) diff --git a/gnu/build/file-systems.scm b/gnu/build/file-systems.scm index 78d779f398..ae29b36c4e 100644 --- a/gnu/build/file-systems.scm +++ b/gnu/build/file-systems.scm @@ -8,6 +8,7 @@ ;;; Copyright © 2020 Maxim Cournoyer ;;; Copyright © 2022 Oleg Pykhalov ;;; Copyright © 2024 Nicolas Graves +;;; Copyright © 2024 Richard Sent ;;; ;;; This file is part of GNU Guix. ;;; @@ -37,6 +38,7 @@ (define-module (gnu build file-systems) #:use-module (rnrs bytevectors) #:use-module (ice-9 match) #:use-module (ice-9 rdelim) + #:use-module (ice-9 regex) #:use-module (system foreign) #:autoload (system repl repl) (start-repl) #:use-module (srfi srfi-1) @@ -1047,8 +1049,11 @@ (define (canonicalize-device-spec spec) (match spec ((? string?) - (if (or (string-contains spec ":/") (string=? spec "none")) - spec ; do not resolve NFS / tmpfs devices + (if (or (string-contains spec ":/") ;nfs + (and (>= (string-length spec) 2) + (equal? (string-take spec 2) "//")) ;cifs + (string=? spec "none")) + spec ; do not resolve NFS / CIFS / tmpfs devices ;; Nothing to do, but wait until SPEC shows up. (resolve identity spec identity))) ((? file-system-label?) @@ -1156,6 +1161,14 @@ (define* (mount-file-system fs #:key (root "/root") (repair (file-system-repair fs))) "Mount the file system described by FS, a object, under ROOT." + (define* (host-to-ip host #:optional service) + "Return the IP address for host, which may be an IP address or a hostname." + (let* ((aa (match (getaddrinfo host service) ((x . _) x))) + (sa (addrinfo:addr aa)) + (inet-addr (inet-ntop (sockaddr:fam sa) + (sockaddr:addr sa)))) + inet-addr)) + (define (mount-nfs source mount-point type flags options) (let* ((idx (string-rindex source #\:)) (host-part (string-take source idx)) @@ -1163,11 +1176,7 @@ (define* (mount-file-system fs #:key (root "/root") (host (match (string-split host-part (string->char-set "[]")) (("" h "") h) ((h) h))) - (aa (match (getaddrinfo host "nfs") ((x . _) x))) - (sa (addrinfo:addr aa)) - (inet-addr (inet-ntop (sockaddr:fam sa) - (sockaddr:addr sa)))) - + (inet-addr (host-to-ip host "nfs"))) ;; Mounting an NFS file system requires passing the address ;; of the server in the addr= option (mount source mount-point type flags @@ -1176,6 +1185,41 @@ (define* (mount-file-system fs #:key (root "/root") (if options (string-append "," options) ""))))) + + (define (mount-cifs source mount-point type flags options) + ;; Source is of form "///" + (let* ((regex-match (string-match "//([^/]+)/(.+)" source)) + (server (match:substring regex-match 1)) + (share (match:substring regex-match 2)) + ;; Match ",guest,", ",guest$", "^guest,", or "^guest$," not + ;; e.g. user=foo,pass=notaguest + (guest? (string-match "(^|,)(guest)($|,)" options)) + ;; Perform DNS resolution now instead of attempting kernel dns + ;; resolver upcalling. /sbin/request-key does not exist and the + ;; kernel hardcodes the path. + ;; + ;; (getaddrinfo) doesn't support cifs service, so omit it. + (inet-addr (host-to-ip server))) + (mount source mount-point type flags + (string-append "ip=" + inet-addr + ;; As of Linux af1a3d2ba9 (v5.11) unc is ignored + ;; and source is parsed by the kernel + ;; directly. Pass it for compatibility. + ",unc=" + ;; Match format of mount.cifs's mount syscall. + "\\\\" server "\\" share + (if guest? + ",user=,pass=" + "") + (if options + ;; No need to delete "guest" from options. + ;; linux/fs/smb/client/fs_context.c explicitly + ;; ignores it. Also, avoiding excess commas + ;; when deleting is a pain. + (string-append "," options) + ""))))) + (let* ((type (file-system-type fs)) (source (canonicalize-device-spec (file-system-device fs))) (target (string-append root "/" @@ -1210,6 +1254,8 @@ (define* (mount-file-system fs #:key (root "/root") (cond ((string-prefix? "nfs" type) (mount-nfs source target type flags options)) + ((string-prefix? "cifs" type) + (mount-cifs source target type flags options)) ((memq 'shared (file-system-flags fs)) (mount source target type flags options) (mount "none" target #f MS_SHARED)) -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 23 16:49:17 2024 Received: (at 70542) by debbugs.gnu.org; 23 Apr 2024 20:49:19 +0000 Received: from localhost ([127.0.0.1]:54269 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzN4h-0003Yf-KX for submit@debbugs.gnu.org; Tue, 23 Apr 2024 16:49:16 -0400 Received: from mail-108-mta205.mxroute.com ([136.175.108.205]:39331) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzN3n-0003OB-2E for 70542@debbugs.gnu.org; Tue, 23 Apr 2024 16:48:19 -0400 Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta205.mxroute.com (ZoneMTA) with ESMTPSA id 18f0cb70c560003bea.001 for <70542@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 23 Apr 2024 20:47:53 +0000 X-Zone-Loop: 64cc3a143911022501d988fb8399ffcea087e1bc289a X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freakingpenguin.com; s=x; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=LBLAiBjTSPvGnakzep01c6deoJNF1KR5XHn9hW3qe9U=; b=CojS/kxOhcEudZ36nlsKHLxOsB 4L+xTsBG+AkBYrVSvvd0ihDLK3EU68JdaHac1hJ1uXa7kxcTg318BHn4aeDKNkkCVSWeQ9ZF+C6gk HZGGfD2M3WE2K2aaDmRWwtxU5ek79DpGcMbzWZzehGlr5JWV3rVHIM91xP50eGIfI0+IkjxXmFCgP YqHV4lMJVSZQdJ+36PovfYEn53GXqfEQtm9QXZawp+9CYKRq+GCz+yiEJC7pjq1ia9uOV2qEHuabf 9XI7MT8TCUAiOYZQhikC9t4X6VpKsUKVt/QK0QwKtBnSB2gM6cfzf5T4sOJdjO23j5T8PT6RnasLM mdZnTkhw==; From: Richard Sent To: 70542@debbugs.gnu.org Subject: [PATCH 4/4] system: Do not check for CIFS file system availability Date: Tue, 23 Apr 2024 16:47:22 -0400 Message-ID: <26b45dc93012f6a25a8eefed69e1c470fc8e4ad8.1713904784.git.richard@freakingpenguin.com> In-Reply-To: References: MIME-Version: 1.0 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit X-Authenticated-Id: richard@freakingpenguin.com X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70542 Cc: Richard Sent X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/machine/ssh.scm (machine-check-file-system-availability): Skip checking for CIFS availability, similar to NFS. * guix/scripts/system.scm (check-file-system-availability): Likewise. Change-Id: Ib6452d1b0d3c15028c79b05422ffa317de0a419a --- gnu/machine/ssh.scm | 3 ++- guix/scripts/system.scm | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/gnu/machine/ssh.scm b/gnu/machine/ssh.scm index b47ce7c225..0be9ebbc0d 100644 --- a/gnu/machine/ssh.scm +++ b/gnu/machine/ssh.scm @@ -222,7 +222,8 @@ (define (machine-check-file-system-availability machine) (not (member (file-system-type fs) %pseudo-file-system-types)) ;; Don't try to validate network file systems. - (not (string-prefix? "nfs" (file-system-type fs))) + (not (or (string-prefix? "nfs" (file-system-type fs)) + (string-prefix? "cifs" (file-system-type fs)))) (not (memq 'bind-mount (file-system-flags fs))))) (operating-system-file-systems (machine-operating-system machine)))) diff --git a/guix/scripts/system.scm b/guix/scripts/system.scm index 2260bcf985..99c58f3812 100644 --- a/guix/scripts/system.scm +++ b/guix/scripts/system.scm @@ -591,7 +591,8 @@ (define (check-file-system-availability file-systems) (not (member (file-system-type fs) %pseudo-file-system-types)) ;; Don't try to validate network file systems. - (not (string-prefix? "nfs" (file-system-type fs))) + (not (or (string-prefix? "nfs" (file-system-type fs)) + (string-prefix? "cifs" (file-system-type fs)))) (not (memq 'bind-mount (file-system-flags fs))))) file-systems)) -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 23 16:52:16 2024 Received: (at 70542) by debbugs.gnu.org; 23 Apr 2024 20:52:16 +0000 Received: from localhost ([127.0.0.1]:54297 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzN7f-00045b-1y for submit@debbugs.gnu.org; Tue, 23 Apr 2024 16:52:16 -0400 Received: from mail-108-mta226.mxroute.com ([136.175.108.226]:33477) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzN7b-00044x-EG for 70542@debbugs.gnu.org; Tue, 23 Apr 2024 16:52:13 -0400 Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta226.mxroute.com (ZoneMTA) with ESMTPSA id 18f0cbaaa0d0003bea.001 for <70542@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 23 Apr 2024 20:51:50 +0000 X-Zone-Loop: e9fbfbd625322a451dadc9dfe13505f16d7842ec2944 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freakingpenguin.com; s=x; h=Content-Type:MIME-Version:Message-ID:Date: Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Iqn+JA7dWlCurJwKPyi45rDXIe688kCrWR5ob7OUwxI=; b=VCsR3Uo2I0b7Y9+g09W+GrbUoH zC8aDVPri3tn7zwaSREXugT5orLbuZfa3h5CQkv+A3U3qKaMtk1hpnbD1k1cau9vdLiVOLBKon+Z5 otcr7/pEhfIV4eueRqEn3JrBxYqQqpUJPylBYJitE0wQ/E0HgCmDEWLtpnnem1WkQvhQZbduxpID/ /eFP4JrjpBslx3jDwd0LI+gW2EeeRcL03WklSyNp/5mNC69CEYZjJyT80qie50T6RJkldfvHI1WHy qQC8H6Yq8IndFMWF27Z1rEVFu0E9/UQ8BMqLwb1oGXvAGWDVES29uvENr+4+bEDYevSuPQ0ECvD9q HZkuPwzQ==; From: Richard Sent To: 70542@debbugs.gnu.org Subject: Missing reference in cover letter Date: Tue, 23 Apr 2024 16:51:42 -0400 Message-ID: <87a5ljls4h.fsf@freakingpenguin.com> MIME-Version: 1.0 Content-Type: text/plain X-Authenticated-Id: richard@freakingpenguin.com X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70542 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Oops, forgot to include the link to [1] in the cover letter. (If you see this Felix, nothing's wrong with your code! :) I just needed an example of how it's currently done.) [1] https://lists.gnu.org/archive/html/guix-devel/2024-04/msg00233.html -- Take it easy, Richard Sent Making my computer weirder one commit at a time. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 24 13:27:37 2024 Received: (at 70542) by debbugs.gnu.org; 24 Apr 2024 17:27:37 +0000 Received: from localhost ([127.0.0.1]:59518 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzgPA-0006Ef-1Z for submit@debbugs.gnu.org; Wed, 24 Apr 2024 13:27:37 -0400 Received: from mail-lf1-x144.google.com ([2a00:1450:4864:20::144]:52234) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzgP4-0006C6-Ke for 70542@debbugs.gnu.org; Wed, 24 Apr 2024 13:27:34 -0400 Received: by mail-lf1-x144.google.com with SMTP id 2adb3069b0e04-5176f217b7bso118418e87.0 for <70542@debbugs.gnu.org>; Wed, 24 Apr 2024 10:27:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713979627; x=1714584427; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=a/XmoO6+gYuZne4mAo3cwQk0aMt61gMn9/61Rz/jTaA=; b=Qigxci4ORhtpiZXEjbcYCty0EQIyeoXSCpSzMsYQZ5BWa+QvTiZKztIN0HR7DRbziP BGTyY1N+Yd1us33s95Ft5j0mxZeGdDooz5Zut/vqTPmADWIF/AvQzIBKrz/GZvNiWz4Y My8bT68wgXObJa7A8v5WNTbkjmMthkaI4MHkdX0p5nqJESkXz+N69AbcYSioKugyBBJc ++F8E4h8mIZ/L/6xqTDRV1HHi36lIvexXZTSIgxOwYAHZ+AGjPHGiuyxzfQRo+S+tBI8 hCDuhvAl1PH9LnGe2HDcYwM/OFerb66xu19HX8VVrrBgpI34JGt2ZYSt+0OYy99LfwSN rpug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713979627; x=1714584427; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=a/XmoO6+gYuZne4mAo3cwQk0aMt61gMn9/61Rz/jTaA=; b=EWdea2fJiHNZ4OEoQoY6oPb3LYkvTjRLqjtBBVl8wkvIum5X+uZL0lv28yYB1yt8e6 cfVLIGsbRI4AjTLyZb2SeJQU0JUGVX4iwQQL0v7aAoHX9p5ERvRWCaFOcAt15lTRkOiW kRyELIeUHDIKEYqek/yTGfUQLppIxagXeGqBX0AAO/VHP0QXP8JDzziAR8ZChW+f11/m 4sj3Knt7e3olLPCSWxPZMtUD0bTcfEjUZScMxizzAtCuz91worblPPvLwZP0ozMcqwSV tu54h59flCF7HhjSRPx5Ln/IvhUJQk7XXgmnmcEZtZOHq+qkB0gzTzuRhMw0c7NoDEB/ 9qtA== X-Forwarded-Encrypted: i=1; AJvYcCWaOqxgW/YjsDBPM5uaFqm9KdoYM+TsXOpOPA9ESE5xCCw2ZfTcgOos+AoH6FEQytpgqTwYN2MXsZeBWHK0Kb1gZfaS5Fo= X-Gm-Message-State: AOJu0Yyh8EttoAjq5YLZA2poEnZfiADp6Ub3+jk9emEBV7f7LVDxxOXe IjwTrlJDBOQfyCYT8ZinjbcwmU/TL4OealKYCJrI5OOw8sS9XQ3w X-Google-Smtp-Source: AGHT+IFl0X5eh3ppwjppHKUDZIY0r1Gf48jHjGjgcWNTifOUuL7/chsChqGPXxiWWA84rTSKLX1G6g== X-Received: by 2002:a2e:b6d4:0:b0:2da:4947:1643 with SMTP id m20-20020a2eb6d4000000b002da49471643mr2292936ljo.24.1713979626918; Wed, 24 Apr 2024 10:27:06 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id n26-20020a1709061d1a00b00a525860ecc5sm8560866ejh.180.2024.04.24.10.27.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 10:27:06 -0700 (PDT) Message-ID: <9e8db033896577e723bc9bc7aa358215a1bddd1d.camel@gmail.com> Subject: Re: [PATCH 4/4] system: Do not check for CIFS file system availability From: Liliana Marie Prikler To: Richard Sent , 70542@debbugs.gnu.org Date: Wed, 24 Apr 2024 19:26:56 +0200 In-Reply-To: <26b45dc93012f6a25a8eefed69e1c470fc8e4ad8.1713904784.git.richard@freakingpenguin.com> References: <26b45dc93012f6a25a8eefed69e1c470fc8e4ad8.1713904784.git.richard@freakingpenguin.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70542 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Dienstag, dem 23.04.2024 um 16:47 -0400 schrieb Richard Sent: > * gnu/machine/ssh.scm (machine-check-file-system-availability): Skip > checking > for CIFS availability, similar to NFS. > * guix/scripts/system.scm (check-file-system-availability): Likewise. >=20 > Change-Id: Ib6452d1b0d3c15028c79b05422ffa317de0a419a This should probably be done already when adding the CIFS file system. Cheers From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 24 13:29:51 2024 Received: (at 70542) by debbugs.gnu.org; 24 Apr 2024 17:29:52 +0000 Received: from localhost ([127.0.0.1]:59532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzgRJ-0006dS-Cw for submit@debbugs.gnu.org; Wed, 24 Apr 2024 13:29:51 -0400 Received: from mail-ej1-x644.google.com ([2a00:1450:4864:20::644]:56688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzgRE-0006bH-K3 for 70542@debbugs.gnu.org; Wed, 24 Apr 2024 13:29:47 -0400 Received: by mail-ej1-x644.google.com with SMTP id a640c23a62f3a-a559b919303so13785466b.1 for <70542@debbugs.gnu.org>; Wed, 24 Apr 2024 10:29:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713979761; x=1714584561; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=gtWLuDgoZkF+XEh0GFeZCmMqUWVuJTX53d5gkZHMV6k=; b=UYcBAmSMjHKoT2fnhfBgsBz3zOWpAqEj/NJuQvB/3h5Sr5Mj9DPTIKnQwTx6lyM3Uz cM4jEFnPw7J4r5CDcf1Sg/aTJ6/KKyDY2UvmzRs/+p9iz4zDlDoZeG283bLcZ+JZIfTG 0SJqXRLnED0dvzUFgaNP0w2DwiYEIZmwy2Sg2CZOcj39MMUU0zlPO3mpnXvfcTwOCcw9 wnnuRXOOhlYXIArQWjg7K8uKAJFB2HXGHu5xsPivXLnzlfC/9tJtK13KcIKDKya7O1cq vVmQffoHOBB1J8qJZ/ckNFSERZIZsb8Ham/55CYvuFpF3SblMZxjb/QmCGGQ9/Jx8S8z SPnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713979761; x=1714584561; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gtWLuDgoZkF+XEh0GFeZCmMqUWVuJTX53d5gkZHMV6k=; b=Xz7/FlCuZWNfUYaDUqVpeMdIrAUfLiu91rC1WgewFKVhSLAjhp04k0PpM4eDso5aG2 48dXRCuTQApspMHhfgiJK4pdEwOkBwJM7fsFRCpPWFknlLRyiIo7O8hXi5cpiP2NWSd0 DLtlx4HPdQEtyx097tTS+plINAyjVDUJYx62x1gOQipKSaZ0U5QpuwV2s4d7mbr8dczH Q3LPa1KIXug60G2UC2AE6ZhK1yYmAM5dwFrtGW0CWkgvMo168qbxJ9CLgXli3NAzbXvL vIxmpe/ZtAuBrLqBjZEJutRL3Cv0xesI94YACSabtDgWoB2om3QYTsAK7MWtN+R4VO3Z ZxWA== X-Forwarded-Encrypted: i=1; AJvYcCURHD+Eh2MVzOYTtMiRbj/JllJ8Rzolb3vxQwpM4h1KN3Q+ayMiPGPGh1kMX/qERvHmJt6blBwgcRqR5sIqGEJjbFTKSeA= X-Gm-Message-State: AOJu0Yx++du9ylbNBi01hqrN2Z6TAk6bUZWgGz8/j6HHrv7zH92dWCix qcAulsJQfOBSLdiCDmufMTz9ZhQEKdienMBduTtErtzuFmryRpzL X-Google-Smtp-Source: AGHT+IFP8KlcftUFb0rUf7UYcfu3YL7P6YD7ZU9WP8KKfuyIJwJrSgSlKokpNd2CduQyay3Ky9l0og== X-Received: by 2002:a17:906:3181:b0:a52:671a:aaf2 with SMTP id 1-20020a170906318100b00a52671aaaf2mr2116723ejy.72.1713979752856; Wed, 24 Apr 2024 10:29:12 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id qt3-20020a170906ece300b00a5887fed95dsm1586605ejb.2.2024.04.24.10.29.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 10:29:12 -0700 (PDT) Message-ID: <036dbbe1dc78d8c1e36f70caa5e5f2b6b21abc56.camel@gmail.com> Subject: Re: [PATCH 3/4] file-systems: Add support for mounting CIFS file systems From: Liliana Marie Prikler To: Richard Sent , 70542@debbugs.gnu.org Date: Wed, 24 Apr 2024 19:29:11 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70542 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) QW0gRGllbnN0YWcsIGRlbSAyMy4wNC4yMDI0IHVtIDE2OjQ3IC0wNDAwIHNjaHJpZWIgUmljaGFy ZCBTZW50Ogo+ICogZ251L2J1aWxkL2ZpbGUtc3lzdGVtcyAoY2Fub25pY2FsaXplLWRldmljZS1u YW1lKTogRG8gbm90IGF0dGVtcHQKPiB0byByZXNvbHZlIENJRlMgZm9ybWF0dGVkIGRldmljZSBz cGVjaWZpY2F0aW9ucy4KPiAqIGdudS9idWlsZC9maWxlLXN5c3RlbXMgKG1vdW50LWZpbGUtc3lz dGVtKTogQWRkIChtb3VudC1jaWZzKQo+IGFuZCAoaG9zdC10by1pcCkuIExvZ2ljIGZvciBpcC9o b3N0IHRvIGlwIHJlc29sdXRpb24gd2FzIGR1cGxpY2F0ZWQKPiB3aXRoIG1vdW50LW5mcywgc28g aXNvbGF0ZSBpbnRvIGEgZGVkaWNhdGVkIGZ1bmN0aW9uLgpZb3Ugc2hvdWxkIGZhY3RvciBvdXQg aG9zdC10by1pcCBpbiBhIHNlcGFyYXRlIHBhdGNoIGJlZm9yZSBhZGRpbmcKbW91bnQtY2lmcy4K Cj4gQ2hhbmdlLUlkOiBJNTIyZDcwYTEwNjUxY2E3OTUzM2E0ZmM2MGI5NmI4ODQyNDNhMzUyNgo+ IC0tLQo+IMKgZ251L2J1aWxkL2ZpbGUtc3lzdGVtcy5zY20gfCA2MCArKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKystLS0KPiAtLQo+IMKgMSBmaWxlIGNoYW5nZWQsIDUzIGluc2VydGlv bnMoKyksIDcgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2dudS9idWlsZC9maWxlLXN5 c3RlbXMuc2NtIGIvZ251L2J1aWxkL2ZpbGUtc3lzdGVtcy5zY20KPiBpbmRleCA3OGQ3NzlmMzk4 Li5hZTI5YjM2YzRlIDEwMDY0NAo+IC0tLSBhL2dudS9idWlsZC9maWxlLXN5c3RlbXMuc2NtCj4g KysrIGIvZ251L2J1aWxkL2ZpbGUtc3lzdGVtcy5zY20KPiBAQCAtOCw2ICs4LDcgQEAKPiDCoDs7 OyBDb3B5cmlnaHQgwqkgMjAyMCBNYXhpbSBDb3Vybm95ZXIgPG1heGltLmNvdXJub3llckBnbWFp bC5jb20+Cj4gwqA7OzsgQ29weXJpZ2h0IMKpIDIwMjIgT2xlZyBQeWtoYWxvdiA8Z28ud2lndXN0 QGdtYWlsLmNvbT4KPiDCoDs7OyBDb3B5cmlnaHQgwqkgMjAyNCBOaWNvbGFzIEdyYXZlcyA8bmdy YXZlc0BuZ3JhdmVzLmZyPgo+ICs7OzsgQ29weXJpZ2h0IMKpIDIwMjQgUmljaGFyZCBTZW50IDxy aWNoYXJkQGZyZWFraW5ncGVuZ3Vpbi5jb20+Cj4gwqA7OzsKPiDCoDs7OyBUaGlzIGZpbGUgaXMg cGFydCBvZiBHTlUgR3VpeC4KPiDCoDs7Owo+IEBAIC0zNyw2ICszOCw3IEBAIChkZWZpbmUtbW9k dWxlIChnbnUgYnVpbGQgZmlsZS1zeXN0ZW1zKQo+IMKgwqAgIzp1c2UtbW9kdWxlIChybnJzIGJ5 dGV2ZWN0b3JzKQo+IMKgwqAgIzp1c2UtbW9kdWxlIChpY2UtOSBtYXRjaCkKPiDCoMKgICM6dXNl LW1vZHVsZSAoaWNlLTkgcmRlbGltKQo+ICvCoCAjOnVzZS1tb2R1bGUgKGljZS05IHJlZ2V4KQo+ IMKgwqAgIzp1c2UtbW9kdWxlIChzeXN0ZW0gZm9yZWlnbikKPiDCoMKgICM6YXV0b2xvYWTCoMKg IChzeXN0ZW0gcmVwbCByZXBsKSAoc3RhcnQtcmVwbCkKPiDCoMKgICM6dXNlLW1vZHVsZSAoc3Jm aSBzcmZpLTEpCj4gQEAgLTEwNDcsOCArMTA0OSwxMSBAQCAoZGVmaW5lIChjYW5vbmljYWxpemUt ZGV2aWNlLXNwZWMgc3BlYykKPiDCoAo+IMKgwqAgKG1hdGNoIHNwZWMKPiDCoMKgwqDCoCAoKD8g c3RyaW5nPykKPiAtwqDCoMKgwqAgKGlmIChvciAoc3RyaW5nLWNvbnRhaW5zIHNwZWMgIjovIikg KHN0cmluZz0/IHNwZWMgIm5vbmUiKSkKPiAtwqDCoMKgwqDCoMKgwqDCoCBzcGVjwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCA7IGRvIG5vdCByZXNvbHZlIE5GUyAvIHRtcGZzIGRl dmljZXMKPiArwqDCoMKgwqAgKGlmIChvciAoc3RyaW5nLWNvbnRhaW5zIHNwZWMgIjovIikgO25m cwo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKGFuZCAoPj0gKHN0cmluZy1sZW5ndGggc3Bl YykgMikKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoZXF1YWw/IChzdHJp bmctdGFrZSBzcGVjIDIpICIvLyIpKSA7Y2lmcwo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg KHN0cmluZz0/IHNwZWMgIm5vbmUiKSkKPiArwqDCoMKgwqDCoMKgwqDCoCBzcGVjwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCA7IGRvIG5vdCByZXNvbHZlIE5GUyAvIENJRlMgLyB0 bXBmcwo+IGRldmljZXMKPiDCoMKgwqDCoMKgwqDCoMKgwqAgOzsgTm90aGluZyB0byBkbywgYnV0 IHdhaXQgdW50aWwgU1BFQyBzaG93cyB1cC4KPiDCoMKgwqDCoMKgwqDCoMKgwqAgKHJlc29sdmUg aWRlbnRpdHkgc3BlYyBpZGVudGl0eSkpKQo+IMKgwqDCoMKgICgoPyBmaWxlLXN5c3RlbS1sYWJl bD8pCj4gQEAgLTExNTYsNiArMTE2MSwxNCBAQCAoZGVmaW5lKiAobW91bnQtZmlsZS1zeXN0ZW0g ZnMgIzprZXkgKHJvb3QKPiAiL3Jvb3QiKQo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChyZXBhaXIgKGZpbGUtc3lzdGVtLXJlcGFpciBm cykpKQo+IMKgwqAgIk1vdW50IHRoZSBmaWxlIHN5c3RlbSBkZXNjcmliZWQgYnkgRlMsIGEgPGZp bGUtc3lzdGVtPiBvYmplY3QsCj4gdW5kZXIgUk9PVC4iCj4gwqAKPiArwqAgKGRlZmluZSogKGhv c3QtdG8taXAgaG9zdCAjOm9wdGlvbmFsIHNlcnZpY2UpCj4gK8KgwqDCoCAiUmV0dXJuIHRoZSBJ UCBhZGRyZXNzIGZvciBob3N0LCB3aGljaCBtYXkgYmUgYW4gSVAgYWRkcmVzcyBvciBhCj4gaG9z dG5hbWUuIgo+ICvCoMKgwqAgKGxldCogKChhYSAobWF0Y2ggKGdldGFkZHJpbmZvIGhvc3Qgc2Vy dmljZSkgKCh4IC4gXykgeCkpKQo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoCAoc2EgKGFkZHJpbmZv OmFkZHIgYWEpKQo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoCAoaW5ldC1hZGRyIChpbmV0LW50b3Ag KHNvY2thZGRyOmZhbSBzYSkKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoc29ja2FkZHI6YWRkciBzYSkpKSkKPiArwqDC oMKgwqDCoCBpbmV0LWFkZHIpKQo+ICsKPiDCoMKgIChkZWZpbmUgKG1vdW50LW5mcyBzb3VyY2Ug bW91bnQtcG9pbnQgdHlwZSBmbGFncyBvcHRpb25zKQo+IMKgwqDCoMKgIChsZXQqICgoaWR4IChz dHJpbmctcmluZGV4IHNvdXJjZSAjXDopKQo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKGhvc3Qt cGFydCAoc3RyaW5nLXRha2Ugc291cmNlIGlkeCkpCj4gQEAgLTExNjMsMTEgKzExNzYsNyBAQCAo ZGVmaW5lKiAobW91bnQtZmlsZS1zeXN0ZW0gZnMgIzprZXkgKHJvb3QKPiAiL3Jvb3QiKQo+IMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgKGhvc3QgKG1hdGNoIChzdHJpbmctc3BsaXQgaG9zdC1wYXJ0 IChzdHJpbmctPmNoYXItc2V0Cj4gIltdIikpCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCAoKCIiIGggIiIpIGgpCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCAoKGgpIGgpKSkKPiAtwqDCoMKgwqDCoMKgwqDCoMKgwqAgKGFhIChtYXRjaCAoZ2V0YWRkcmlu Zm8gaG9zdCAibmZzIikgKCh4IC4gXykgeCkpKQo+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoCAoc2Eg KGFkZHJpbmZvOmFkZHIgYWEpKQo+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoCAoaW5ldC1hZGRyIChp bmV0LW50b3AgKHNvY2thZGRyOmZhbSBzYSkKPiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoc29ja2FkZHI6YWRkciBzYSkp KSkKPiAtCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgIChpbmV0LWFkZHIgKGhvc3QtdG8taXAgaG9z dCAibmZzIikpKQo+IMKgwqDCoMKgwqDCoCA7OyBNb3VudGluZyBhbiBORlMgZmlsZSBzeXN0ZW0g cmVxdWlyZXMgcGFzc2luZyB0aGUgYWRkcmVzcwo+IMKgwqDCoMKgwqDCoCA7OyBvZiB0aGUgc2Vy dmVyIGluIHRoZSBhZGRyPSBvcHRpb24KPiDCoMKgwqDCoMKgwqAgKG1vdW50IHNvdXJjZSBtb3Vu dC1wb2ludCB0eXBlIGZsYWdzCj4gQEAgLTExNzYsNiArMTE4NSw0MSBAQCAoZGVmaW5lKiAobW91 bnQtZmlsZS1zeXN0ZW0gZnMgIzprZXkgKHJvb3QKPiAiL3Jvb3QiKQo+IMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChpZiBvcHRpb25zCj4g wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCAoc3RyaW5nLWFwcGVuZCAiLCIgb3B0aW9ucykKPiDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICIiKSkpKSkKPiAr Cj4gK8KgIChkZWZpbmUgKG1vdW50LWNpZnMgc291cmNlIG1vdW50LXBvaW50IHR5cGUgZmxhZ3Mg b3B0aW9ucykKPiArwqDCoMKgIDs7IFNvdXJjZSBpcyBvZiBmb3JtICIvLzxzZXJ2ZXItaXAtb3It aG9zdD4vPHNlcnZpY2U+Igo+ICvCoMKgwqAgKGxldCogKChyZWdleC1tYXRjaCAoc3RyaW5nLW1h dGNoICIvLyhbXi9dKykvKC4rKSIgc291cmNlKSkKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqAgKHNl cnZlciAobWF0Y2g6c3Vic3RyaW5nIHJlZ2V4LW1hdGNoIDEpKQo+ICvCoMKgwqDCoMKgwqDCoMKg wqDCoCAoc2hhcmUgKG1hdGNoOnN1YnN0cmluZyByZWdleC1tYXRjaCAyKSkKPiArwqDCoMKgwqDC oMKgwqDCoMKgwqAgOzsgTWF0Y2ggIixndWVzdCwiLCAiLGd1ZXN0JCIsICJeZ3Vlc3QsIiwgb3Ig Il5ndWVzdCQsIgo+IG5vdAo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoCA7OyBlLmcuIHVzZXI9Zm9v LHBhc3M9bm90YWd1ZXN0Cj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgIChndWVzdD8gKHN0cmluZy1t YXRjaCAiKF58LCkoZ3Vlc3QpKCR8LCkiIG9wdGlvbnMpKQo+ICvCoMKgwqDCoMKgwqDCoMKgwqDC oCA7OyBQZXJmb3JtIEROUyByZXNvbHV0aW9uIG5vdyBpbnN0ZWFkIG9mIGF0dGVtcHRpbmcKPiBr ZXJuZWwgZG5zCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgIDs7IHJlc29sdmVyIHVwY2FsbGluZy4g L3NiaW4vcmVxdWVzdC1rZXkgZG9lcyBub3QgZXhpc3QKPiBhbmQgdGhlCj4gK8KgwqDCoMKgwqDC oMKgwqDCoMKgIDs7IGtlcm5lbCBoYXJkY29kZXMgdGhlIHBhdGguCj4gK8KgwqDCoMKgwqDCoMKg wqDCoMKgIDs7Cj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgIDs7IChnZXRhZGRyaW5mbykgZG9lc24n dCBzdXBwb3J0IGNpZnMgc2VydmljZSwgc28gb21pdAo+IGl0Lgo+ICvCoMKgwqDCoMKgwqDCoMKg wqDCoCAoaW5ldC1hZGRyIChob3N0LXRvLWlwIHNlcnZlcikpKQo+ICvCoMKgwqDCoMKgIChtb3Vu dCBzb3VyY2UgbW91bnQtcG9pbnQgdHlwZSBmbGFncwo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAgKHN0cmluZy1hcHBlbmQgImlwPSIKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGluZXQtYWRkcgo+ICvCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgOzsgQXMgb2YgTGludXggYWYxYTNk MmJhOSAodjUuMTEpIHVuYyBpcwo+IGlnbm9yZWQKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIDs7IGFuZCBzb3VyY2UgaXMgcGFyc2VkIGJ5 IHRoZSBrZXJuZWwKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIDs7IGRpcmVjdGx5LiBQYXNzIGl0IGZvciBjb21wYXRpYmlsaXR5Lgo+ICvC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgIix1 bmM9Igo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqAgOzsgTWF0Y2ggZm9ybWF0IG9mIG1vdW50LmNpZnMncyBtb3VudAo+IHN5c2NhbGwuCj4g K8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAi XFxcXCIgc2VydmVyICJcXCIgc2hhcmUKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChpZiBndWVzdD8KPiArwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgIix1c2VyPSxwYXNz PSIKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqAgIiIpCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCAoaWYgb3B0aW9ucwo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCA7OyBObyBuZWVkIHRvIGRlbGV0 ZSAiZ3Vlc3QiIGZyb20KPiBvcHRpb25zLgo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCA7OyBsaW51eC9mcy9zbWIvY2xpZW50 L2ZzX2NvbnRleHQuYwo+IGV4cGxpY2l0bHkKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgOzsgaWdub3JlcyBpdC4gQWxzbywg YXZvaWRpbmcgZXhjZXNzCj4gY29tbWFzCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIDs7IHdoZW4gZGVsZXRpbmcgaXMgYSBw YWluLgo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCAoc3RyaW5nLWFwcGVuZCAiLCIgb3B0aW9ucykKPiArwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgIiIpKSkp KQpBbnkgcmVhc29uIHdlIG91Z2h0IHRvIHNvbHZlIGd1ZXN0IHNwZWNpYWxseT8gIExldCdzIGp1 c3QgYXNzdW1lIHRoYXQKdXNlciBhbmQgcGFzcyBhcmUgYWx3YXlzIChwb3NzaWJseSBlbXB0eSkg c3RyaW5ncy4gIElmIHlvdSBuZWVkIHRvCmFic3RyYWN0IG92ZXIgaXQsIHlvdSBjb3VsZCBhbHdh eXMgbWFrZSBhIHByb2NlZHVyZSBvciBzb21ldGhpbmcuCgpDaGVlcnMKCg== From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 24 13:31:18 2024 Received: (at 70542) by debbugs.gnu.org; 24 Apr 2024 17:31:18 +0000 Received: from localhost ([127.0.0.1]:59541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzgSi-0006wK-TC for submit@debbugs.gnu.org; Wed, 24 Apr 2024 13:31:18 -0400 Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]:47531) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzgSe-0006u4-0a for 70542@debbugs.gnu.org; Wed, 24 Apr 2024 13:31:14 -0400 Received: by mail-ed1-x542.google.com with SMTP id 4fb4d7f45d1cf-572347c2ba8so46370a12.3 for <70542@debbugs.gnu.org>; Wed, 24 Apr 2024 10:30:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713979849; x=1714584649; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=196ngP8U0hRvbsJDNwShyOyrrgPDxhGuALkfyLBofU4=; b=kFWGcflco/ueBQ8MClocdO7flU7W2nZmLO+7m8Fw7ayeCoxDy54ScLqY8nwRLSRJs2 XoMQoAHPPC+6271KhuPZEXrXp+QOeYguqtPMpIOTwBv+G46UPRAjkr1grUtBQas0VRpO TsiviWj225aQb8mEEev3lobLdGgU6bjSnBsjTGxm4ubdo4VhpSVSLs2F/xPescKnieJP rq6uXMNjQAYP5dDmR97ixVZjUvsS1G5wCEA5sBDLIDh0nesIaUL5TCW0IuctWuL4L71W K2w7A53GSkJq1WlLxpFNo8XXnNmsf3tqIYbiJpTyHznGgUzi5Emt/vJAzld4HbKorRtP rPAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713979849; x=1714584649; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=196ngP8U0hRvbsJDNwShyOyrrgPDxhGuALkfyLBofU4=; b=X+mDyUz4O4FepRgFc9FDS1TDm41RtfW076Hj2i6NG15OGB4AdQLf/YNDFnuA+uVcEl YB0vTnnrWlnYnoevs1R3CSq/tirFwMZnlpVuFu8nqBF0ZBu7QJ4og65ttuuEt3QNSuFU lqdn2gFoSmZYzQv2KCbcisCfozgwD8CJ0XeASu/VD0hweJauus9LA/pJL1WedRRk4diU I7MlLImdBeW/7Cb/TVhnjHEWvPmiE0/M9kzUhkTDTiqxu4L+F9cUc7yLRGWDn2Kf2pB3 sLwBWhpVOF5QCvcRTtjvvcla0kJG/XPTpmgTxmOVBg9iHjVYxNC5KMeaJZytaxvKt/dg IStQ== X-Forwarded-Encrypted: i=1; AJvYcCWVcsOF5ia+w1hopJdEOE2lWTli2+lhptkCNIxQ6JUEYOh19L+dejRGATl32N357yz2S4t/xfB1l7VRRVYmKRcj2FTazwg= X-Gm-Message-State: AOJu0YxCrsXyq/CytrxCRGFaJB9+KWuI/vRyOgIqNYnhZk1anJxmlOq8 LrbV+NuzKfKtTUyzVQ+fk9A44doki8B0cmZubkpWdW6tzaKfoflj X-Google-Smtp-Source: AGHT+IEXCMQKQcVO1+L0LMvfrMu6kWqlVuOxFmD9z5//2GT0i1fCR6EkVBKL0V0Zysz4d30Iipu6Ew== X-Received: by 2002:a50:d481:0:b0:572:1589:eb98 with SMTP id s1-20020a50d481000000b005721589eb98mr1946849edi.12.1713979848632; Wed, 24 Apr 2024 10:30:48 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id fk6-20020a056402398600b00571ba529bbasm8086009edb.44.2024.04.24.10.30.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 10:30:48 -0700 (PDT) Message-ID: Subject: Re: [PATCH 2/4] services: base: Use requirements to delay some file-systems From: Liliana Marie Prikler To: Richard Sent , 70542@debbugs.gnu.org Date: Wed, 24 Apr 2024 19:30:47 +0200 In-Reply-To: <91efec381997bd89208d9f4a47141ae6481fb963.1713904784.git.richard@freakingpenguin.com> References: <91efec381997bd89208d9f4a47141ae6481fb963.1713904784.git.richard@freakingpenguin.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70542 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) QW0gRGllbnN0YWcsIGRlbSAyMy4wNC4yMDI0IHVtIDE2OjQ3IC0wNDAwIHNjaHJpZWIgUmljaGFy ZCBTZW50Ogo+IEFkZCBhIG1lY2hhbmlzbSB0byBvbmx5IHJlcXVpcmUgYSBzdWJzZXQgb2YgZmls ZS1zeXN0ZW0gZW50cmllcwo+IGR1cmluZyBlYXJseQo+IFNoZXBoZXJkIGluaXRpYWxpemF0aW9u LiBBbnkgZmlsZS1zeXN0ZW0gd2l0aCBhZGRpdGlvbmFsIFNoZXBoZXJkCj4gc2VydmljZQo+IHJl cXVpcmVtZW50cyAoZS5nLiBuZXR3b3JraW5nKSB3aWxsIGJlIGJyb3VnaHQgdXAgYWZ0ZXIgJ2Zp bGUtc3lzdGVtcwo+IGlzCj4gcHJvdmlzaW9uZWQuCj4gCj4gKiBnbnUvc2VydmljZXMvYmFzZS5z Y20gKGZpbGUtc3lzdGVtLXNoZXBoZXJkLXNlcnZpY2UpOiBTcGxpY2UKPiBmaWxlLXN5c3RlbS1y ZXF1aXJlbWVudHMgaW50byB0aGUgU2hlcGhlcmQgc2VydmljZSByZXF1aXJlbWVudCBsaXN0Lgo+ ICogZ251L3NlcnZpY2VzL2Jhc2Uuc2NtIChmaWxlLXN5c3RlbS1zaGVwaGVyZC1zZXJ2aWNlcyk6 IFByb3Zpc2lvbgo+ICdmaWxlLXN5c3RlbSB3aGVuIGZpbGUtc3lzdGVtcyB0aGF0IHNhdGlzZnkg aW5pdGlhbC1maWxlLXN5c3RlbT/CoCBhcmUKPiBzdGFydGVkLgo+IAo+IENoYW5nZS1JZDogSTdi MTMzNmVlOTcwZjQzMjBmNzQzMWJlZjE4N2U2NmYzNGYwZDcxOGMKPiAtLS0KPiDCoGdudS9zZXJ2 aWNlcy9iYXNlLnNjbSB8IDE2ICsrKysrKysrKysrKysrLS0KPiDCoDEgZmlsZSBjaGFuZ2VkLCAx NCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9nbnUvc2Vy dmljZXMvYmFzZS5zY20gYi9nbnUvc2VydmljZXMvYmFzZS5zY20KPiBpbmRleCAzZjkxMjIyNWEw Li5hZjkyYjcwMGI0IDEwMDY0NAo+IC0tLSBhL2dudS9zZXJ2aWNlcy9iYXNlLnNjbQo+ICsrKyBi L2dudS9zZXJ2aWNlcy9iYXNlLnNjbQo+IEBAIC00MDMsNiArNDAzLDcgQEAgKGRlZmluZSAoZmls ZS1zeXN0ZW0tc2hlcGhlcmQtc2VydmljZSBmaWxlLQo+IHN5c3RlbSkKPiDCoMKgwqDCoMKgwqDC oMKgIChjcmVhdGU/IChmaWxlLXN5c3RlbS1jcmVhdGUtbW91bnQtcG9pbnQ/IGZpbGUtc3lzdGVt KSkKPiDCoMKgwqDCoMKgwqDCoMKgIChtb3VudD/CoCAoZmlsZS1zeXN0ZW0tbW91bnQ/IGZpbGUt c3lzdGVtKSkKPiDCoMKgwqDCoMKgwqDCoMKgIChkZXBlbmRlbmNpZXMgKGZpbGUtc3lzdGVtLWRl cGVuZGVuY2llcyBmaWxlLXN5c3RlbSkpCj4gK8KgwqDCoMKgwqDCoMKgIChyZXF1aXJlbWVudHMg KGZpbGUtc3lzdGVtLXJlcXVpcmVtZW50cyBmaWxlLXN5c3RlbSkpCj4gwqDCoMKgwqDCoMKgwqDC oCAocGFja2FnZXMgKGZpbGUtc3lzdGVtLXBhY2thZ2VzIChsaXN0IGZpbGUtc3lzdGVtKSkpKQo+ IMKgwqDCoMKgIChhbmQgKG9yIG1vdW50PyBjcmVhdGU/KQo+IMKgwqDCoMKgwqDCoMKgwqDCoCAo d2l0aC1pbXBvcnRlZC1tb2R1bGVzIChzb3VyY2UtbW9kdWxlLWNsb3N1cmUKPiBAQCAtNDExLDcg KzQxMiw4IEBAIChkZWZpbmUgKGZpbGUtc3lzdGVtLXNoZXBoZXJkLXNlcnZpY2UgZmlsZS0KPiBz eXN0ZW0pCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChwcm92aXNpb24gKGxpc3QgKGZpbGUt c3lzdGVtLT5zaGVwaGVyZC1zZXJ2aWNlLW5hbWUKPiBmaWxlLXN5c3RlbSkpKQo+IMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCAocmVxdWlyZW1lbnQgYChyb290LWZpbGUtc3lzdGVtCj4gwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHVkZXYKPiAt wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAsQCht YXAgZGVwZW5kZW5jeS0+c2hlcGhlcmQtc2VydmljZS1uYW1lCj4gZGVwZW5kZW5jaWVzKSkpCj4g K8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgLEAo bWFwIGRlcGVuZGVuY3ktPnNoZXBoZXJkLXNlcnZpY2UtbmFtZQo+IGRlcGVuZGVuY2llcykKPiAr wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAsQHJl cXVpcmVtZW50cykpCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChkb2N1bWVudGF0aW9uICJD aGVjaywgbW91bnQsIGFuZCB1bm1vdW50IHRoZSBnaXZlbiBmaWxlCj4gc3lzdGVtLiIpCj4gwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIChzdGFydCAjfihsYW1iZGEgYXJncwo+IMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgIyQoaWYgY3JlYXRlPwo+IEBAIC00 NjAsMTIgKzQ2MiwyMiBAQCAoZGVmaW5lIChmaWxlLXN5c3RlbS1zaGVwaGVyZC1zZXJ2aWNlcyBm aWxlLQo+IHN5c3RlbXMpCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChvciAoZmlsZS1zeXN0ZW0tbW91bnQ/IHgpCj4g wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgKGZpbGUtc3lzdGVtLWNyZWF0ZS1tb3VudC0KPiBwb2ludD8geCkp KQo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIGZpbGUtc3lzdGVtcykpKQo+ICsKPiArwqDCoMKgIChkZWZpbmUgKGluaXRpYWwt ZmlsZS1zeXN0ZW0/IGZpbGUtc3lzdGVtKQo+ICvCoMKgwqDCoMKgICJSZXR1cm4gI3QgaWYgdGhl IGZpbGUgc3lzdGVtIHNob3VsZCBiZSBtb3VudGVkIGluaXRpYWxseSBvcgo+ICNmLiIKPiArwqDC oMKgwqDCoCA7OyBGaWxlIHN5c3RlbXMgd2l0aCBhZGRpdGlvbmFsIFNoZXBoZXJkIHJlcXVpcmVt ZW50cyAoZS5nLgo+IG5ldHdvcmtpbmcpCj4gK8KgwqDCoMKgwqAgOzsgc2hvdWxkIG5vdCBiZSBj b25zaWRlcmVkIGluaXRpYWwuIFRob3NlIHJlcXVpcmVtZW50cyBsaWtlbHkKPiByZWx5IG9uCj4g K8KgwqDCoMKgwqAgOzsgJ2ZpbGUtc3lzdGVtcyBiZWluZyBwcm92aXNpb25lZC4KPiArwqDCoMKg wqDCoCAobnVsbD8gKGZpbGUtc3lzdGVtLXJlcXVpcmVtZW50cyBmaWxlLXN5c3RlbSkpKQo+ICsK PiDCoMKgwqDCoCAoZGVmaW5lIHNpbmsKPiDCoMKgwqDCoMKgwqAgKHNoZXBoZXJkLXNlcnZpY2UK PiDCoMKgwqDCoMKgwqDCoCAocHJvdmlzaW9uICcoZmlsZS1zeXN0ZW1zKSkKPiDCoMKgwqDCoMKg wqDCoCAocmVxdWlyZW1lbnQgKGNvbnMqICdyb290LWZpbGUtc3lzdGVtICd1c2VyLWZpbGUtc3lz dGVtcwo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoCAobWFwIGZpbGUtc3lzdGVtLT5zaGVwaGVyZC1zZXJ2aWNlLW5hbWUKPiAtwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZmls ZS1zeXN0ZW1zKSkpCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIDs7IE9ubHkgZmlsZSBzeXN0ZW1zIGNvbnNpZGVyZWQKPiBp bml0aWFsIHNob3VsZAo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCA7OyBiZSByZXF1aXJlZCB0byBwcm92aXNpb24gJ2ZpbGUt Cj4gc3lzdGVtcy4KPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgKGZpbHRlciBpbml0aWFsLWZpbGUtc3lzdGVtPyBmaWxlLQo+ IHN5c3RlbXMpKSkpCkknZCBjb21wb3NlIG51bGw/IGFuZCBmaWxlLXN5c3RlbS1yZXF1aXJlbWVu dHMgZGlyZWN0bHkgaW4gdGhlIGZpbHRlciDigJMKdGhhdCdzIGVhc2llciB0byB3cmFwIG15IGhl YWQgYXJvdW5kLgpZb3UgdGhlbiBhbHNvIGhhdmUgYSBsaXR0bGUgbW9yZSBzcGFjZSB0byBleHBs YWluIHdoeSB0aGlzIGNvbXBvc2l0aW9uCmlzIGRvbmUgaW4gdGhlIGZpcnN0IHBsYWNlLgoKQ2hl ZXJzCg== From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 24 13:32:19 2024 Received: (at 70542) by debbugs.gnu.org; 24 Apr 2024 17:32:19 +0000 Received: from localhost ([127.0.0.1]:59548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzgTi-00077r-Fd for submit@debbugs.gnu.org; Wed, 24 Apr 2024 13:32:19 -0400 Received: from mail-lf1-x142.google.com ([2a00:1450:4864:20::142]:60531) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzgTf-00076u-Oh for 70542@debbugs.gnu.org; Wed, 24 Apr 2024 13:32:17 -0400 Received: by mail-lf1-x142.google.com with SMTP id 2adb3069b0e04-51bae805c56so75928e87.0 for <70542@debbugs.gnu.org>; Wed, 24 Apr 2024 10:31:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713979912; x=1714584712; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=+VZnfyUlCwMh4Wds/hZDDmpN6pG/l2hSQQgqqa4DnIo=; b=h9fvjGWpKCTkgzHpHFm8Y4zNzYNzhWOKPKKQZfYwHBzqAQVTNOGeE2R1tgrSValV6V QoKsggAiJ/Xm1xqCYnAwe4mItpTbGPMJeYD7pI2LzGo/ZZHhNFpUl8mEly+T+0ml82Xa +EBJtsC4blV4CxGT+hWtJUVFv7QdZVGb/Ugyi0+LKSVm4FKJ5hki17OnFPl/VkWodsvu VJXusXc7D8uxaxWKIDYdItk9oDt69wzsLCgCup8MlFJGFX14HNSaFNFXWOhvRonfSvkO t9OyQwc6BQTC5YOLrhLAHxBxQ0fKQdTGOyLfLDVKPnYpkro2Rjugfwx3ED+QvgE7R5cI 5qug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713979912; x=1714584712; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+VZnfyUlCwMh4Wds/hZDDmpN6pG/l2hSQQgqqa4DnIo=; b=rEZzvYiRcIRofkQTu+Z6nnzS9VdLq6kL4k039HouKoIpgbQj6ZBLwL22s0JgzLMPd+ jWXe8HlzCXoS5V4btekFTLti563GMcvZfEUijjgBiQ3OOPx1+NsTw212bWFr5WtyF0xg DV2BpEuFLcL4JsVNvlAhNsc/96CeFFglFv24bVAnJ49O6iKRtXu9HI2R3Piv6lYjA2H0 FcCtcldIgxED+CiXj/2Utg35LOCDsxh0Jrqn/f2RBPHl6521tPmWu/Zl/XXy2arhsCNN 9Vt7cVwCDcUqk6zlbyQJAedFJ2V+DZP6NGB5W0TgDT+y7DGHGTlzDOdwo/AwjmMFzJdc tc3A== X-Forwarded-Encrypted: i=1; AJvYcCXnLE6lYzvG4JMXxFFhIk4isdyKSdouU4YXu012eEM4OeCOYnEmV0R+UX2ZIBjYfVTCK0kZ+N+AMxY4b2cdeW6rhJbENpc= X-Gm-Message-State: AOJu0Yx3c+0LCFPCx67EmfXdDZbmdC9+KUgjvh0n3t/4letOLX4Dl8rb sz/1F0nHbbc2X00yXCeqU+o0awb0nTSDhhSjQ+nLVlX/KX+t8X5O6vDwq2Gf X-Google-Smtp-Source: AGHT+IGOYUWIG7klEnfn/w9QXuJum8WjTnRT/bXnr8Y4iLSOY7tMxeHmBwnk9lupZuV61tfUOfopCA== X-Received: by 2002:ac2:4e70:0:b0:51b:223f:ac49 with SMTP id y16-20020ac24e70000000b0051b223fac49mr2077544lfs.38.1713979912124; Wed, 24 Apr 2024 10:31:52 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id h26-20020a17090619da00b00a588729de82sm1696972ejd.142.2024.04.24.10.31.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 10:31:51 -0700 (PDT) Message-ID: <909cf4b2bc72a6e9bcfdc403c21d4519dc8f0ef2.camel@gmail.com> Subject: Re: [PATCH 1/4] file-systems: Add requirements field to file-systems From: Liliana Marie Prikler To: Richard Sent , 70542@debbugs.gnu.org Date: Wed, 24 Apr 2024 19:31:50 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70542 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) QW0gRGllbnN0YWcsIGRlbSAyMy4wNC4yMDI0IHVtIDE2OjQ3IC0wNDAwIHNjaHJpZWIgUmljaGFy ZCBTZW50Ogo+ICogZ251L3N5c3RlbS9maWxlLXN5c3RlbXMuc2NtIChmaWxlLXN5c3RlbSk6IEFk ZCByZXF1aXJlbWVudHMgZmllbGQKPiB0byB0aGUKPiBmaWxlLXN5c3RlbSByZWNvcmQuIFRoaXMg ZmllbGQgd2lsbCBiZSB1c2VkIGZvciBhZGRpbmcgYWRkaXRpb25hbAo+IFNoZXBoZXJkCj4gcmVx dWlyZW1lbnRzIHRvIGEgZmlsZSBzeXN0ZW0gU2hlcGhlcmQgc2VydmljZS4KPiAqIGRvYy9ndWl4 LnRleGk6IEFkZCBkb2N1bWVudGF0aW9uIGZvciBmaWxlLXN5c3RlbSByZXF1aXJlbWVudHMuCj4g Cj4gQ2hhbmdlLUlkOiBJZjAzOTJkYjAzZDQ4ZTg4MjBhYTUzZGYxZGY0ODJjMTJlYzcyZTFhNQo+ IC0tLQo+IMKgZG9jL2d1aXgudGV4acKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfCAxMyAr KysrKysrKysrKysrCj4gwqBnbnUvc3lzdGVtL2ZpbGUtc3lzdGVtcy5zY20gfMKgIDMgKysrCj4g wqAyIGZpbGVzIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvZG9j L2d1aXgudGV4aSBiL2RvYy9ndWl4LnRleGkKPiBpbmRleCA2NWFmMTM2ZTYxLi44MGIyNGUyZGU5 IDEwMDY0NAo+IC0tLSBhL2RvYy9ndWl4LnRleGkKPiArKysgYi9kb2MvZ3VpeC50ZXhpCj4gQEAg LTE3NzUxLDYgKzE3NzUxLDE5IEBAIEZpbGUgU3lzdGVtcwo+IMKgCj4gwqBBbm90aGVyIGV4YW1w bGUgaXMgYSBmaWxlIHN5c3RlbSB0aGF0IGRlcGVuZHMgb24gYSBtYXBwZWQgZGV2aWNlLAo+IGZv cgo+IMKgZXhhbXBsZSBmb3IgYW4gZW5jcnlwdGVkIHBhcnRpdGlvbiAoQHB4cmVme01hcHBlZCBE ZXZpY2VzfSkuCj4gKwo+ICtAaXRlbSBAY29kZXtyZXF1aXJlbWVudHN9IChkZWZhdWx0OiBAY29k ZXsnKCl9KQo+ICtUaGlzIGlzIGEgbGlzdCBvZiBzeW1ib2xzIGRlbm90aW5nIFNoZXBoZXJkIHJl cXVpcmVtZW50cyB0aGF0IG11c3QKPiBiZQo+ICttZXQgYmVmb3JlIG1vdW50aW5nIHRoZSBmaWxl IHN5c3RlbS4KPiArCj4gK0FzIGFuIGV4YW1wbGUsIGFuIE5GUyBmaWxlIHN5c3RlbSB3b3VsZCB0 eXBpY2FsbHkgaGF2ZSBhIHJlcXVpcmVtZW50Cj4gZm9yCj4gK0Bjb2Rle25ldHdvcmtpbmd9Lgo+ ICsKPiArVHlwaWNhbGx5LCBmaWxlIHN5c3RlbXMgYXJlIG1vdW50ZWQgYmVmb3JlIG1vc3Qgb3Ro ZXIgU2hlcGhlcmQKPiBzZXJ2aWNlcwo+ICthcmUgc3RhcnRlZC4gSG93ZXZlciwgZmlsZSBzeXN0 ZW1zIHdpdGggYSBub24tZW1wdHkgcmVxdWlyZW1lbnRzCj4gZmllbGQKPiArYXJlIG1vdW50ZWQg YWZ0ZXIgU2hlcGhlcmQgc2VydmljZXMgaGF2ZSBiZWd1bi4gQW55IFNoZXBoZXJkIHNlcnZpY2UK PiArdGhhdCBkZXBlbmRzIG9uIGEgZmlsZSBzeXN0ZW0gd2l0aCBhIG5vbi1lbXB0eSByZXF1aXJl bWVudHMgZmllbGQKPiBtdXN0Cj4gK2RlcGVuZCBvbiBpdCBkaXJlY3RseSBhbmQgbm90IG9uIHRo ZSBnZW5lcmljIHN5bWJvbCBAY29kZXtmaWxlLQo+IHN5c3RlbXN9Lgo+IMKgQGVuZCB0YWJsZQo+ IMKgQGVuZCBkZWZ0cAo+IMKgCj4gZGlmZiAtLWdpdCBhL2dudS9zeXN0ZW0vZmlsZS1zeXN0ZW1z LnNjbSBiL2dudS9zeXN0ZW0vZmlsZS0KPiBzeXN0ZW1zLnNjbQo+IGluZGV4IGFmMDU2N2JkM2Uu Ljc2YTUxYTJiNjkgMTAwNjQ0Cj4gLS0tIGEvZ251L3N5c3RlbS9maWxlLXN5c3RlbXMuc2NtCj4g KysrIGIvZ251L3N5c3RlbS9maWxlLXN5c3RlbXMuc2NtCj4gQEAgLTU3LDYgKzU3LDcgQEAgKGRl ZmluZS1tb2R1bGUgKGdudSBzeXN0ZW0gZmlsZS1zeXN0ZW1zKQo+IMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCBmaWxlLXN5c3RlbS1yZXBhaXIKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZmls ZS1zeXN0ZW0tY3JlYXRlLW1vdW50LXBvaW50Pwo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBm aWxlLXN5c3RlbS1kZXBlbmRlbmNpZXMKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBmaWxlLXN5 c3RlbS1yZXF1aXJlbWVudHMKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZmlsZS1zeXN0ZW0t bG9jYXRpb24KPiDCoAo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBmaWxlLXN5c3RlbS10eXBl LXByZWRpY2F0ZQo+IEBAIC0xODUsNiArMTg2LDggQEAgKGRlZmluZS1yZWNvcmQtdHlwZSogPGZp bGUtc3lzdGVtPiBmaWxlLXN5c3RlbQo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgKGRlZmF1bHQgI2YpKQo+IMKgwqAgKGRlcGVuZGVuY2llc8KgwqDCoMKg IGZpbGUtc3lzdGVtLWRlcGVuZGVuY2llc8KgwqDCoMKgwqAgOyBsaXN0IG9mIDxmaWxlLQo+IHN5 c3RlbT4KPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChkZWZhdWx0 ICcoKSkpwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIDsgb3IgPG1hcHBlZC0KPiBkZXZp Y2U+Cj4gK8KgIChyZXF1aXJlbWVudHPCoMKgwqDCoCBmaWxlLXN5c3RlbS1yZXF1aXJlbWVudHPC oMKgwqDCoMKgIDsgbGlzdCBvZiBzeW1ib2xzCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIChkZWZhdWx0ICcoKSkpCj4gwqDCoCAobG9jYXRpb27CoMKgwqDCoMKgwqDC oMKgIGZpbGUtc3lzdGVtLWxvY2F0aW9uCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCAoZGVmYXVsdCAoY3VycmVudC1zb3VyY2UtbG9jYXRpb24pKQo+IMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKGlubmF0ZSkpKQpMR1RNLCBjb3VsZCBw b3NzaWJseSBiZSBtZXJnZWQgd2l0aCAyLzQgaWYgb3RoZXJzIGFncmVlLgoKQ2hlZXJzCg== From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 24 14:23:10 2024 Received: (at 70542) by debbugs.gnu.org; 24 Apr 2024 18:23:10 +0000 Received: from localhost ([127.0.0.1]:59770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzhGu-0001q1-1v for submit@debbugs.gnu.org; Wed, 24 Apr 2024 14:23:09 -0400 Received: from mail-108-mta160.mxroute.com ([136.175.108.160]:35329) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzhGn-0001oP-ST for 70542@debbugs.gnu.org; Wed, 24 Apr 2024 14:23:06 -0400 Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta160.mxroute.com (ZoneMTA) with ESMTPSA id 18f11586f9a0008ca2.001 for <70542@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 24 Apr 2024 18:22:39 +0000 X-Zone-Loop: 64d960423ed513b0d88a7a0cb06353ae2c5dc23e902b X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freakingpenguin.com; s=x; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=rZj69MnE058MWBEfeTCLcYwbg4Swj6UUxAx5Q1U25Uo=; b=eNA+auSqW6P7XyBCykifeXp5/N oG07xYkoysFT5cbdj2lVEVyDtDiqNKDfh8WjMllRx62omgip5bCoeCwjKsJ7R1E0L71/CTcuMN5F8 0LJ6wZwa4j2bNaDCOmy+MEwRkfz87NplOnrjYZzz6U2SR1KLXEBjjezxfqH5nhW5XmFqWz1AvHf8u uKj/frxGFQMYVZ7CbXZzzXtyw54+5LoOpeBgd89mCti79QMNzEMfzFyeZivj6LfmxbS8lyEhX3Mv5 zyfAURcS4tWT6D0RaagGN5Ui9nSN5gn/PseNQuMhLMTuE27tgFHK6rUHUcidxfvhWwCdnZzPFrtEe QjrevmOg==; From: Richard Sent To: Liliana Marie Prikler Subject: Re: [PATCH 3/4] file-systems: Add support for mounting CIFS file systems In-Reply-To: <036dbbe1dc78d8c1e36f70caa5e5f2b6b21abc56.camel@gmail.com> (Liliana Marie Prikler's message of "Wed, 24 Apr 2024 19:29:11 +0200") References: <036dbbe1dc78d8c1e36f70caa5e5f2b6b21abc56.camel@gmail.com> Date: Wed, 24 Apr 2024 14:22:35 -0400 Message-ID: <87frvazklw.fsf@freakingpenguin.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Authenticated-Id: richard@freakingpenguin.com X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70542 Cc: 70542@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi! Thanks for the feedback! :) > Any reason we ought to solve guest specially? Let's just assume that > user and pass are always (possibly empty) strings. If you need to > abstract over it, you could always make a procedure or something. My reason for handling guest specifically is to try and match the behavior of the userspace "mount.cifs" program as much as possible. That program will parse options, and if it encounters the option "guest", silently replace it with "user=,pass=" before initiating the mount system call. The kernel driver itself ignores the "guest" option, so unless we handle it ourselves by inserting blank user and pass options, it wouldn't have an effect. If I understand what you're saying, we could have user and pass variables that default to "" unless options includes e.g. user=foo,pass=bar. That would diverge from mount.cifs's behavior though, which is something I'm reluctant to do. I don't know if not passing user or pass is identical to passing user=,pass=, but if it's not then users would get confused reading mount.cifs's documentation and trying to apply the same logic to their OS declaration. -- Take it easy, Richard Sent Making my computer weirder one commit at a time. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 24 14:47:49 2024 Received: (at 70542) by debbugs.gnu.org; 24 Apr 2024 18:47:49 +0000 Received: from localhost ([127.0.0.1]:59872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzhen-00061E-IJ for submit@debbugs.gnu.org; Wed, 24 Apr 2024 14:47:49 -0400 Received: from mail-lf1-x141.google.com ([2a00:1450:4864:20::141]:53424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzhel-00060Z-Fb for 70542@debbugs.gnu.org; Wed, 24 Apr 2024 14:47:47 -0400 Received: by mail-lf1-x141.google.com with SMTP id 2adb3069b0e04-518a56cdbcfso186998e87.2 for <70542@debbugs.gnu.org>; Wed, 24 Apr 2024 11:47:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713984444; x=1714589244; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=+WKvADnaqLljJM4Chj6Nmuay5cYMDDk/WlxyJYlFm+c=; b=bLdLwS9LLuev4+C3db1RJhdEyuCGgPojnKpRR80tIIdqySvsG2hax+I7KQYK2N16UN ma8IMPU0NfOsABSJ99j9sT2z4iwOOHJaVC/9A5Ay9JG8uAjTlnSd4tmvd6aS7ICwXdJ6 E4/fQxRMSahcDlmCF0hJ8B2QPUsf/kPTyQzpjQXIDy6E7zE+Ly/Ex2ig788cBILoFQKm 2+huMLIfFe51JbVEmxziAfOGPkPrGK5rzcMORwCHufHEm5H7FiRsuyB96O7Ht1/AobNl mS2WXa/Az7pVMO1WiMOSY3SOcOXwwK2iO6lcNVYAnK2UOllp7mKRzqfaLIfXtKALjC99 YxOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713984444; x=1714589244; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=+WKvADnaqLljJM4Chj6Nmuay5cYMDDk/WlxyJYlFm+c=; b=akLA31p1aYjwOiVW1Yg39Fwd0t9d8X3ym0dK0x82G6oGIHq4fdl3TJXt4caQrTvYWi EPBXFQh7ZPvZisfjIIl5bMD8Pr0myZDE8KeRCTvCYb7+4H/1bf2FZDXXWcvaT+Ay270X +j1fynPtoprn6POqK2vZNX7S0viIG8JWpA5ioq4Z3AWNrHUpRWDt1I+DobMEhE7lqk/y VbHUYJtBMZP6M/0DkR9D1F7ZM0WO7YAM2k6Laulhfn51ngtMmDNdrpgreOm4ZXzmjyOp UBUNIHMXUDPduWy5j/fBemlLxXFbVJLPMPCkvyWZHcEbRB6EWiEDSHs/zeEoZ52mUE38 Iquw== X-Gm-Message-State: AOJu0Yy/N8amGP9OJsOSYpJai9Kx4nX/PMeG7fBnI8QCOIineGkQ1EYi YKmN9kW8ZKq0xQsH9OgG0ZBm3M4ovd51TAv82sbNA8yvipgG4Evi X-Google-Smtp-Source: AGHT+IHt35xsQBpxIVcCwQcaiFOsLjXcAXQaA0QhYzbF31r2MqMGF2n+XzKVXdrwbhMuU8nYZ9f07g== X-Received: by 2002:a05:6512:4892:b0:51b:2eef:bf4c with SMTP id eq18-20020a056512489200b0051b2eefbf4cmr3065148lfb.9.1713984443933; Wed, 24 Apr 2024 11:47:23 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id bk2-20020a170907360200b00a55a8ec5879sm5045970ejc.116.2024.04.24.11.47.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 11:47:23 -0700 (PDT) Message-ID: <9e56714d2d48b006be519a1c03de5e37bd8af4c2.camel@gmail.com> Subject: Re: [PATCH 3/4] file-systems: Add support for mounting CIFS file systems From: Liliana Marie Prikler To: Richard Sent Date: Wed, 24 Apr 2024 20:47:21 +0200 In-Reply-To: <87frvazklw.fsf@freakingpenguin.com> References: <036dbbe1dc78d8c1e36f70caa5e5f2b6b21abc56.camel@gmail.com> <87frvazklw.fsf@freakingpenguin.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70542 Cc: 70542@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Mittwoch, dem 24.04.2024 um 14:22 -0400 schrieb Richard Sent: > Hi! >=20 > Thanks for the feedback! :) >=20 > > Any reason we ought to solve guest specially? Let's just assume > > that user and pass are always (possibly empty) strings. If you need > > to abstract over it, you could always make a procedure or > > something. >=20 > My reason for handling guest specifically is to try and match the > behavior of the userspace "mount.cifs" program as much as possible. > That program will parse options, and if it encounters the option > "guest", silently replace it with "user=3D,pass=3D" before initiating the > mount system call. >=20 > The kernel driver itself ignores the "guest" option, so unless we > handle it ourselves by inserting blank user and pass options, it > wouldn't have an effect. >=20 > If I understand what you're saying, we could have user and pass > variables that default to "" unless options includes e.g. > user=3Dfoo,pass=3Dbar. That would diverge from mount.cifs's behavior > though, which is something I'm reluctant to do. >=20 > I don't know if not passing user or pass is identical to passing > user=3D,pass=3D, but if it's not then users would get confused reading > mount.cifs's documentation and trying to apply the same logic to > their OS declaration. I'm rarely that deep in our interaction with file systems, but do we go through mount or do directly talk to the kernel driver? If we do mount.cifs under the hood, this should not be an issue. Otherwise, we should do our best to document this behaviour. I assume that specifying neither user nor guest would result in an error, but you're welcome to discover bugs^Wfresh new features. Cheers From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 24 15:20:06 2024 Received: (at 70542) by debbugs.gnu.org; 24 Apr 2024 19:20:06 +0000 Received: from localhost ([127.0.0.1]:60024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rziA0-00037v-Qk for submit@debbugs.gnu.org; Wed, 24 Apr 2024 15:20:06 -0400 Received: from mail-108-mta251.mxroute.com ([136.175.108.251]:39771) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzi9w-00036b-AU for 70542@debbugs.gnu.org; Wed, 24 Apr 2024 15:20:02 -0400 Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta251.mxroute.com (ZoneMTA) with ESMTPSA id 18f118c9a4d0008ca2.001 for <70542@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 24 Apr 2024 19:19:38 +0000 X-Zone-Loop: 10a5bc91988afd54e811d49d53afa427803ad5e85ebe X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freakingpenguin.com; s=x; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=22VhqsXhc+5TODlVZKSUx/iE4+0FKG7FHUh9hMg+1P0=; b=Y9IMKs//BLnQxZFn1bUvC3xbif GnkAjmtLtBTMONYaUI2xKitbXoU40BZXnJM+JK0URDDT1HI+FG6ozTgFpcEj4YjW22ZxTrBSBqEVi 0sHeQx0Kvips97nCEzu/sdFPTvFGdJ3GunvAPXpeuYS9HwS5DpyfD9BImEPqDe+wwR3nO+7/772GE Kx3U0ryJL6CsIZHpCubPW9P6Gzfj/kpDVdKRi41cIrk9vA8Z+f/AViJuNIj5nf4yzuGXoE5SlPUpg SFdspsccrvbOChMV+pTQObZbkSJ5BBYTNhpv8w1BQ+N34xWszB0veNkzBbCY5FrtLfTHFLjw/UNTo 4WC+s/iw==; From: Richard Sent To: Liliana Marie Prikler Subject: Re: [PATCH 3/4] file-systems: Add support for mounting CIFS file systems In-Reply-To: <9e56714d2d48b006be519a1c03de5e37bd8af4c2.camel@gmail.com> (Liliana Marie Prikler's message of "Wed, 24 Apr 2024 20:47:21 +0200") References: <036dbbe1dc78d8c1e36f70caa5e5f2b6b21abc56.camel@gmail.com> <87frvazklw.fsf@freakingpenguin.com> <9e56714d2d48b006be519a1c03de5e37bd8af4c2.camel@gmail.com> Date: Wed, 24 Apr 2024 15:19:34 -0400 Message-ID: <87bk5yzhyx.fsf@freakingpenguin.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Authenticated-Id: richard@freakingpenguin.com X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70542 Cc: 70542@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > I'm rarely that deep in our interaction with file systems Haha, join the club! > do we go through mount or do directly talk to the kernel driver? If we > do mount.cifs under the hood, this should not be an issue. Otherwise, > we should do our best to document this behaviour. mount-file-system uses the mount system call under the hood, no userspace tooling as far as I can tell. See mount in (guix build syscalls). Unfortunately this means we need to replicate the userspace mount.cifs program's behavior for handling the guest option. This would definitely be easier (and probably compatible with more file systems) if we used the standard userspace tools, but I don't think there's a good way to do that at present. My hope is that if we match mount.cifs's behavior in how we handle the guest option (adding user=,pass=), we won't need extra documentation explaining CIFS file system options. Users would just follow mount.cifs's documentation (which is probably what they'd find first). To my knowledge the patch's current behavior w.r.t. guest matches mount.cifs. If we were to implement our own divergent behavior from mount.cifs, then we would need to document that divergence. But I don't think we need to document that our behavior matches the mount.cifs program's behavior. (Or, if we do, it should probably be a more general statement like "File system options are passed to the mount system call, with slight adjustments to match the userspace mount. equivalent program's behavior." Something akin to that, but it's not specifically a CIFS thing.) > I assume that specifying neither user nor guest would result in an > error, but you're welcome to discover bugs^Wfresh new features. I think I'd be content with calling that "user error". If mount.cifs doesn't do anything special, neither should we. ;) -- Take it easy, Richard Sent Making my computer weirder one commit at a time. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 25 00:58:02 2024 Received: (at 70542) by debbugs.gnu.org; 25 Apr 2024 04:58:02 +0000 Received: from localhost ([127.0.0.1]:60328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzrBE-0008RN-W1 for submit@debbugs.gnu.org; Thu, 25 Apr 2024 00:58:01 -0400 Received: from mail-108-mta59.mxroute.com ([136.175.108.59]:42921) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzrB8-0008Q2-CM for 70542@debbugs.gnu.org; Thu, 25 Apr 2024 00:57:54 -0400 Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta59.mxroute.com (ZoneMTA) with ESMTPSA id 18f139da3e90008ca2.001 for <70542@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 25 Apr 2024 04:57:29 +0000 X-Zone-Loop: fa98ce4f2a9aeb040a47bb2faeba62812971e77ca3e6 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freakingpenguin.com; s=x; h=Content-Transfer-Encoding:MIME-Version: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vOPokPfPk8VpB87OVgfZvG+sPA5RYqb4xYKtITTM2GA=; b=iNeKeskk5xV5Va5EDP2FbPjXEM SD5JzTs6qn430GuNHiPxYykgYKTzLrTTh+TlL9ZnsHWEJqz6Jb51ZYWoZZkmwUVbVfofntDm1gqfk p5mVBidOl4yNv6NDiawUkkJeku9i5fSQ7ts9wDAZ0w+MHXj9rJcEVsUTecrys/lidlZkl631VIEa2 l7BV6z5uojXj3tR199y/AUM8Faouk3n9FErQ7PKm/Hqe0FOxKzYmG33Of1SuKkJl0IouaacvTTgmR M/TctQQI3AmW7aLcfZJd/mUX4/pGIRog7Wn2XJdhwATluNoxSV+vhSQbsrz+hsg8b3Y8/hO5FdTf6 hYMdtg9A==; From: Richard Sent To: 70542@debbugs.gnu.org Subject: [PATCH v2 1/3] services: base: Add optional delayed mount of file-systems Date: Thu, 25 Apr 2024 00:56:03 -0400 Message-ID: <784e7f59e64d7d8c29f7e0207f5d15727cdd8ba2.1714020965.git.richard@freakingpenguin.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authenticated-Id: richard@freakingpenguin.com X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70542 Cc: Richard Sent X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Add a mechanism to only require mounting a subset of file-system entries during early Shepherd initialization. Any file-system with additional Shepherd service requirements (e.g. networking) is not required to provision 'file-systems. * gnu/services/base.scm (file-system-shepherd-service): Splice file-system-requirements into the Shepherd service requirement list. * gnu/services/base.scm (file-system-shepherd-services): Provision 'file-system only when file system services without additional Shepherd requirements are started. * gnu/system/file-systems.scm (file-system): Add requirements field to the file-system record. This field is used for adding additional Shepherd requirements to a file-system Shepherd service. * doc/guix.texi: Add documentation for file-system requirements. Change-Id: If0392db03d48e8820aa53df1df482c12ec72e1a5 --- doc/guix.texi | 13 +++++++++++++ gnu/services/base.scm | 14 ++++++++++++-- gnu/system/file-systems.scm | 3 +++ 3 files changed, 28 insertions(+), 2 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 3ee9f54773..5c89e2110f 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -17750,6 +17750,19 @@ File Systems Another example is a file system that depends on a mapped device, for example for an encrypted partition (@pxref{Mapped Devices}). + +@item @code{requirements} (default: @code{'()}) +This is a list of symbols denoting Shepherd requirements that must be +met before mounting the file system. + +As an example, an NFS file system would typically have a requirement for +@code{networking}. + +Typically, file systems are mounted before most other Shepherd services +are started. However, file systems with a non-empty requirements field +are mounted after Shepherd services have begun. Any Shepherd service +that depends on a file system with a non-empty requirements field must +depend on it directly and not on the generic symbol @code{file-systems}. @end table @end deftp diff --git a/gnu/services/base.scm b/gnu/services/base.scm index 3f912225a0..4fd946c4aa 100644 --- a/gnu/services/base.scm +++ b/gnu/services/base.scm @@ -403,6 +403,7 @@ (define (file-system-shepherd-service file-system) (create? (file-system-create-mount-point? file-system)) (mount? (file-system-mount? file-system)) (dependencies (file-system-dependencies file-system)) + (requirements (file-system-requirements file-system)) (packages (file-system-packages (list file-system)))) (and (or mount? create?) (with-imported-modules (source-module-closure @@ -411,7 +412,8 @@ (define (file-system-shepherd-service file-system) (provision (list (file-system->shepherd-service-name file-system))) (requirement `(root-file-system udev - ,@(map dependency->shepherd-service-name dependencies))) + ,@(map dependency->shepherd-service-name dependencies) + ,@requirements)) (documentation "Check, mount, and unmount the given file system.") (start #~(lambda args #$(if create? @@ -460,12 +462,20 @@ (define (file-system-shepherd-services file-systems) (or (file-system-mount? x) (file-system-create-mount-point? x))) file-systems))) + (define sink (shepherd-service (provision '(file-systems)) (requirement (cons* 'root-file-system 'user-file-systems (map file-system->shepherd-service-name - file-systems))) + ;; Do not require file systems with Shepherd + ;; requirements to provision + ;; 'file-systems. Many Shepherd services + ;; require 'file-systems, so we would likely + ;; deadlock. + (filter (lambda (file-system) + (null? (file-system-requirements file-system))) + file-systems)))) (documentation "Target for all the initially-mounted file systems") (start #~(const #t)) (stop #~(const #f)))) diff --git a/gnu/system/file-systems.scm b/gnu/system/file-systems.scm index af0567bd3e..76a51a2b69 100644 --- a/gnu/system/file-systems.scm +++ b/gnu/system/file-systems.scm @@ -57,6 +57,7 @@ (define-module (gnu system file-systems) file-system-repair file-system-create-mount-point? file-system-dependencies + file-system-requirements file-system-location file-system-type-predicate @@ -185,6 +186,8 @@ (define-record-type* file-system (default #f)) (dependencies file-system-dependencies ; list of (default '())) ; or + (requirements file-system-requirements ; list of symbols + (default '())) (location file-system-location (default (current-source-location)) (innate))) base-commit: 91d9e145e15241c20729a4f1fa43f3d662f6b806 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 25 00:58:38 2024 Received: (at 70542) by debbugs.gnu.org; 25 Apr 2024 04:58:40 +0000 Received: from localhost ([127.0.0.1]:60333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzrBo-00006D-V8 for submit@debbugs.gnu.org; Thu, 25 Apr 2024 00:58:38 -0400 Received: from mail-108-mta14.mxroute.com ([136.175.108.14]:36599) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzrBH-0008Rq-SL for 70542@debbugs.gnu.org; Thu, 25 Apr 2024 00:58:02 -0400 Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta14.mxroute.com (ZoneMTA) with ESMTPSA id 18f139dc8f00008ca2.001 for <70542@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 25 Apr 2024 04:57:38 +0000 X-Zone-Loop: 082bd6afa2b500dc65feda76776b6484c3bb71293a4b X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freakingpenguin.com; s=x; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=yasHRBpWaIqbi/HgdOUj3gkXs98JDrHEX8axByTcj9g=; b=Zc9q9gTJVpcneADfENiWf4LmOb gukNlHmvcKTCeYaLVbR0yYNh+l/MvyNC72ZsRZ5hkP+SNI1vWzf8NxakQboG5pPwgXHzOVrSVrs4a yZ27+wrfGONDJL5k9ix3VQTSVM47tfF6/uVQRg1vSPVFus047l12g2VMj1W9M0Uf3XWRP92pIN1/c e7Ohw9NhSI2hFrxAyYV6wk/2XEPhpVvX2Cu+XLemq/PoKrTVxe8feKIvwlv7LBmH6Mominei9dRTJ YYyb9wk5pGJVo+pfV8pTAIOebhaFx+oOOOnfqofQMkRJkeAAO3/0hYwAM1y5S0XYiDLMrhcjgk57F v2IJX1BA==; From: Richard Sent To: 70542@debbugs.gnu.org Subject: [PATCH v2 2/3] file-systems: Add host-to-ip nested function Date: Thu, 25 Apr 2024 00:56:04 -0400 Message-ID: In-Reply-To: <784e7f59e64d7d8c29f7e0207f5d15727cdd8ba2.1714020965.git.richard@freakingpenguin.com> References: <784e7f59e64d7d8c29f7e0207f5d15727cdd8ba2.1714020965.git.richard@freakingpenguin.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authenticated-Id: richard@freakingpenguin.com X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70542 Cc: Richard Sent X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/build/file-systems (mount-file-system): Split out getaddrinfo logic into a dedicated function, (host-to-ip) Change-Id: I522d70a10651ca79533a4fc60b96b884243a3526 --- gnu/build/file-systems.scm | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/gnu/build/file-systems.scm b/gnu/build/file-systems.scm index 78d779f398..e47ac39ab0 100644 --- a/gnu/build/file-systems.scm +++ b/gnu/build/file-systems.scm @@ -1156,6 +1156,14 @@ (define* (mount-file-system fs #:key (root "/root") (repair (file-system-repair fs))) "Mount the file system described by FS, a object, under ROOT." + (define* (host-to-ip host #:optional service) + "Return the IP address for host, which may be an IP address or a hostname." + (let* ((aa (match (getaddrinfo host service) ((x . _) x))) + (sa (addrinfo:addr aa)) + (inet-addr (inet-ntop (sockaddr:fam sa) + (sockaddr:addr sa)))) + inet-addr)) + (define (mount-nfs source mount-point type flags options) (let* ((idx (string-rindex source #\:)) (host-part (string-take source idx)) @@ -1163,11 +1171,7 @@ (define* (mount-file-system fs #:key (root "/root") (host (match (string-split host-part (string->char-set "[]")) (("" h "") h) ((h) h))) - (aa (match (getaddrinfo host "nfs") ((x . _) x))) - (sa (addrinfo:addr aa)) - (inet-addr (inet-ntop (sockaddr:fam sa) - (sockaddr:addr sa)))) - + (inet-addr (host-to-ip host "nfs"))) ;; Mounting an NFS file system requires passing the address ;; of the server in the addr= option (mount source mount-point type flags @@ -1176,6 +1180,7 @@ (define* (mount-file-system fs #:key (root "/root") (if options (string-append "," options) ""))))) + (let* ((type (file-system-type fs)) (source (canonicalize-device-spec (file-system-device fs))) (target (string-append root "/" -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 25 00:58:44 2024 Received: (at 70542) by debbugs.gnu.org; 25 Apr 2024 04:58:45 +0000 Received: from localhost ([127.0.0.1]:60335 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzrBu-00007v-Lo for submit@debbugs.gnu.org; Thu, 25 Apr 2024 00:58:44 -0400 Received: from mail-108-mta189.mxroute.com ([136.175.108.189]:44785) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzrBR-0008Ti-R3 for 70542@debbugs.gnu.org; Thu, 25 Apr 2024 00:58:14 -0400 Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta189.mxroute.com (ZoneMTA) with ESMTPSA id 18f139de8c20008ca2.001 for <70542@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 25 Apr 2024 04:57:46 +0000 X-Zone-Loop: 579330028cbf4d74e0df57f44a47ece3e70142f0d0bb X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freakingpenguin.com; s=x; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=vs0ksIXRLil2Wu6ptR0iYB7JH/lgfD33tOt8ohbEIV4=; b=OabaQKX/ndCDK6nJMOnyWd/IMn olMe/05FmCwT5gmMkp+ca8j6TEB5V+FmETFxHm1Cz2Tb9wncHoFKbtHIu/+xlWY9a1DVbBbeAfK33 p0Qs2I5GK8xXuwve8yMKntazx6YMpaIQo19av6KOrVUwbX9h8O2scEOqe+vWVZvwADSD6b9RlWqqh p2ZOlQ5LorrTSXjzYYzn5k5fT4qGIklOJT+wHwVvHKJftvi4fK89GM6qiFYU6EkFGPpbgEv2B6bqC dmiPSmcldkImOBtBkPYfFUHAOS0haZPf6J98AJowY3q9DUazWBOal6Kth9ICLiA+xR10F72sacKnq zQ8j1IXQ==; From: Richard Sent To: 70542@debbugs.gnu.org Subject: [PATCH v2 3/3] file-systems: Add support for mounting CIFS file systems Date: Thu, 25 Apr 2024 00:56:05 -0400 Message-ID: In-Reply-To: <784e7f59e64d7d8c29f7e0207f5d15727cdd8ba2.1714020965.git.richard@freakingpenguin.com> References: <784e7f59e64d7d8c29f7e0207f5d15727cdd8ba2.1714020965.git.richard@freakingpenguin.com> MIME-Version: 1.0 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Authenticated-Id: richard@freakingpenguin.com X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70542 Cc: Richard Sent X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/build/file-systems (canonicalize-device-name): Do not attempt to resolve CIFS formatted device specifications. (mount-file-systems): Add mount-cifs nested function. * gnu/machine/ssh.scm (machine-check-file-system-availability): Skip checking for CIFS availability, similar to NFS. * guix/scripts/system.scm (check-file-system-availability): Likewise. Change-Id: I182e290eba64bbe5d1332815eb93bb68c01e0c3c --- gnu/build/file-systems.scm | 45 ++++++++++++++++++++++++++++++++++++-- gnu/machine/ssh.scm | 3 ++- guix/scripts/system.scm | 3 ++- 3 files changed, 47 insertions(+), 4 deletions(-) diff --git a/gnu/build/file-systems.scm b/gnu/build/file-systems.scm index e47ac39ab0..ae29b36c4e 100644 --- a/gnu/build/file-systems.scm +++ b/gnu/build/file-systems.scm @@ -8,6 +8,7 @@ ;;; Copyright © 2020 Maxim Cournoyer ;;; Copyright © 2022 Oleg Pykhalov ;;; Copyright © 2024 Nicolas Graves +;;; Copyright © 2024 Richard Sent ;;; ;;; This file is part of GNU Guix. ;;; @@ -37,6 +38,7 @@ (define-module (gnu build file-systems) #:use-module (rnrs bytevectors) #:use-module (ice-9 match) #:use-module (ice-9 rdelim) + #:use-module (ice-9 regex) #:use-module (system foreign) #:autoload (system repl repl) (start-repl) #:use-module (srfi srfi-1) @@ -1047,8 +1049,11 @@ (define (canonicalize-device-spec spec) (match spec ((? string?) - (if (or (string-contains spec ":/") (string=? spec "none")) - spec ; do not resolve NFS / tmpfs devices + (if (or (string-contains spec ":/") ;nfs + (and (>= (string-length spec) 2) + (equal? (string-take spec 2) "//")) ;cifs + (string=? spec "none")) + spec ; do not resolve NFS / CIFS / tmpfs devices ;; Nothing to do, but wait until SPEC shows up. (resolve identity spec identity))) ((? file-system-label?) @@ -1181,6 +1186,40 @@ (define* (mount-file-system fs #:key (root "/root") (string-append "," options) ""))))) + (define (mount-cifs source mount-point type flags options) + ;; Source is of form "///" + (let* ((regex-match (string-match "//([^/]+)/(.+)" source)) + (server (match:substring regex-match 1)) + (share (match:substring regex-match 2)) + ;; Match ",guest,", ",guest$", "^guest,", or "^guest$," not + ;; e.g. user=foo,pass=notaguest + (guest? (string-match "(^|,)(guest)($|,)" options)) + ;; Perform DNS resolution now instead of attempting kernel dns + ;; resolver upcalling. /sbin/request-key does not exist and the + ;; kernel hardcodes the path. + ;; + ;; (getaddrinfo) doesn't support cifs service, so omit it. + (inet-addr (host-to-ip server))) + (mount source mount-point type flags + (string-append "ip=" + inet-addr + ;; As of Linux af1a3d2ba9 (v5.11) unc is ignored + ;; and source is parsed by the kernel + ;; directly. Pass it for compatibility. + ",unc=" + ;; Match format of mount.cifs's mount syscall. + "\\\\" server "\\" share + (if guest? + ",user=,pass=" + "") + (if options + ;; No need to delete "guest" from options. + ;; linux/fs/smb/client/fs_context.c explicitly + ;; ignores it. Also, avoiding excess commas + ;; when deleting is a pain. + (string-append "," options) + ""))))) + (let* ((type (file-system-type fs)) (source (canonicalize-device-spec (file-system-device fs))) (target (string-append root "/" @@ -1215,6 +1254,8 @@ (define* (mount-file-system fs #:key (root "/root") (cond ((string-prefix? "nfs" type) (mount-nfs source target type flags options)) + ((string-prefix? "cifs" type) + (mount-cifs source target type flags options)) ((memq 'shared (file-system-flags fs)) (mount source target type flags options) (mount "none" target #f MS_SHARED)) diff --git a/gnu/machine/ssh.scm b/gnu/machine/ssh.scm index b47ce7c225..0be9ebbc0d 100644 --- a/gnu/machine/ssh.scm +++ b/gnu/machine/ssh.scm @@ -222,7 +222,8 @@ (define (machine-check-file-system-availability machine) (not (member (file-system-type fs) %pseudo-file-system-types)) ;; Don't try to validate network file systems. - (not (string-prefix? "nfs" (file-system-type fs))) + (not (or (string-prefix? "nfs" (file-system-type fs)) + (string-prefix? "cifs" (file-system-type fs)))) (not (memq 'bind-mount (file-system-flags fs))))) (operating-system-file-systems (machine-operating-system machine)))) diff --git a/guix/scripts/system.scm b/guix/scripts/system.scm index 2260bcf985..99c58f3812 100644 --- a/guix/scripts/system.scm +++ b/guix/scripts/system.scm @@ -591,7 +591,8 @@ (define (check-file-system-availability file-systems) (not (member (file-system-type fs) %pseudo-file-system-types)) ;; Don't try to validate network file systems. - (not (string-prefix? "nfs" (file-system-type fs))) + (not (or (string-prefix? "nfs" (file-system-type fs)) + (string-prefix? "cifs" (file-system-type fs)))) (not (memq 'bind-mount (file-system-flags fs))))) file-systems)) -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 25 02:52:29 2024 Received: (at 70542) by debbugs.gnu.org; 25 Apr 2024 06:52:30 +0000 Received: from localhost ([127.0.0.1]:60409 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzsy2-00038N-89 for submit@debbugs.gnu.org; Thu, 25 Apr 2024 02:52:29 -0400 Received: from mout.web.de ([212.227.15.14]:60749) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzsxw-00036G-24 for 70542@debbugs.gnu.org; Thu, 25 Apr 2024 02:52:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1714027916; x=1714632716; i=jonathan.brielmaier@web.de; bh=oqWp/CRoNDJ/ARQTZblBPA4smfX7/UD7pGhn62I06kU=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:From:Subject: Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=i0BjTQyBld+A81nHpHmcerZmEx281aKitmt1cU7VN+pizQVHJbh2aJhPtBi8niRN zRWrLEk0KCqlljiDLwR24hDOMax+nZiogANAmc1NHoMmz6ZVqaCbQTgZj2KaZGUld 9wTk47L9jZQyQirzgZAnW20OmubmiTZbxunTeMp/tJzhqP54KSpMMS2NzQpXL5hii 0Dc0KbYqTIPPULO5a8fKdFFoZ/nqD2xZiK4+mU7nJN9+rWbfnFahV/jWScMPO7tfn STG2lCAdDZQJY7VT4HQtZZqiDZqNNmHc6i6L5SNDfp5vkFxS5t5qWgYw54y3c7tZo ihcQZeI6Zp6w560+wQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.29] ([77.181.128.147]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MNfUF-1sJrkt27Lv-00P9AR for <70542@debbugs.gnu.org>; Thu, 25 Apr 2024 08:51:56 +0200 Message-ID: <9e8e0f42-e403-d919-3b18-be010757097c@web.de> Date: Thu, 25 Apr 2024 08:51:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 To: 70542@debbugs.gnu.org Content-Language: de-DE, en-US From: Jonathan Brielmaier Subject: [PATCH 0/4] Improve Shepherd service support for networked file systems Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:xCkOvKqVzoyyAAz/OWrbeoGhjkWFV0JHrTWdNpDrdxUj1sOpyZS h+xlAsPoubdjooyM+DxNolw9SBgL7xYlOiebCg/dhcme9N970Dd/K0dnCdmaf2Qy1sOnji6 KG2kEomtrPxsrQzGPNQbxdfoxGIInZFXtvl+LIa3z9u9CDVX5ph2oRVGjUKqpJPtnOlS2Sd w9UnLAE6BzLqHbkyK42kA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:jG44qzffHlU=;9sa2X5oYIVWFc3NU+8baeEucAwJ 9QGNiBYHNJoy8rQyQJiYbbErFYg7mzBVO3F/HRDmlB8x9YJcb4S0KcvT53A8k7X4iwTIK2oi1 kSctOY/jr2ThxfUfQLU3qsE7w6auVBUC1jWiYMCDFYCS7BuzqhJN/7REs1oreeYJU9yWIAlSF imcrgQc+3FREvAgTIuVcaLt7G+7EbFf4jaZj2s/wzY38C2OstBGlAw/UgZAyec7TIOiC5Gx13 VotYycSyZmjF1vSbG6fVkzkksuD4SDiuUig+0dPl16tA6l/ecthiw9m0XK4uP9/YABZPmAL9g R+rZu5RLrAZE9TuvYfc3y9rYqsGFwOElGxqHzcropkkkPgIvibAAWlkNDzTd2ku5p+hkc4qfT GueieoSdL25/fmq0YrW6hBi2K/Qd/xzmdQUgit+igGU4X5m4763YqTXk3GNUI43KvRbBTJ7bB 5tQe0jjnkSbhSFj55xJFsQ4cLRepIYdVasxZrE10RTGgXWOF1uRkCyy5xzzjfT9L5mGML6QhX 3qLnS2aUmMi7BFWlt9fkyaG4Yjuv6OQf5nGZwaFlBmqDtfdIyuSTTdXh5gogK08sp9OUu6yvL sHdEHKPQi/DxYlB231/qZiEOgx1EUKMNdWk8+kk5442a4GkimrUbrAy0e638+zOOLyv/tiU6B dwdN8uR8HKW+AIjcf7IbixL/RVhb9U8dEIdS02GC5yqGC+Mnj8pfLRVx4Kzwhw9lTBfCqPe62 uN6/iyEubb7m2Iok8w1x5oH+4YMTA/s7j3oBktNc6dXg7EyyJrT1j9iRFywzvmClHPUSoC7Ql w25z69B6iii3QBAH52i2Lfz0XvqZZ1hcqPnlFFu+8AuDA= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70542 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello Richard, thanks for improving the CIFS mounting problem! I'm using a CIFS share on one of my servers. There I stumbled upon a problem, that the share is disappearing (e.g. CIFS server unavailable for a short time) and gets not automatically remounted. So I'm using a simple cron job to workaround this problem: ``` ;; CIFS mount disappears often (define mount-all-job #~(job "0 * * * *" "mount --all" #:user "root")) ``` Do you know if this particular problem gets resolved with your patch? ~Jonathan From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 25 09:44:37 2024 Received: (at 70542) by debbugs.gnu.org; 25 Apr 2024 13:44:38 +0000 Received: from localhost ([127.0.0.1]:60741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzzOn-0000NB-6U for submit@debbugs.gnu.org; Thu, 25 Apr 2024 09:44:36 -0400 Received: from mail-108-mta1.mxroute.com ([136.175.108.1]:43835) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzzOb-0000Kz-Dc for 70542@debbugs.gnu.org; Thu, 25 Apr 2024 09:44:23 -0400 Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta1.mxroute.com (ZoneMTA) with ESMTPSA id 18f157f9b560008ca2.001 for <70542@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 25 Apr 2024 13:43:55 +0000 X-Zone-Loop: f41248c01652547fc179f9142e55e340a2e00bcdf388 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freakingpenguin.com; s=x; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=HelotezeQjdYfI6uoWXoZ377gZkSUxKiLkN1VqTa/4s=; b=SadkDhiW5d/hWKePOa9wkKAE6Z edkEj0qxzYmNDbUNx2YlVCmbiM1BQ44XvQeGo+kbvisG1uIA1bXWcy4rAWcA97ObBEmnAVPA7Onf+ 9M9f5Lpu/n5gQqkeG/lr+mXzFA2bysbAq245scGDNTHagGaWFTvK9ZFvAPwotHWlMtkFOoCp6efCu LskBDQjub6YbytIkGet454C9KecJOnbjbMJELNKrtjkP5bbgZ81G5T91ZOJbmi6ehkT3g2lmstZkp 5BL4EKVBO40FtaMBXm3ihW/CP80UYr0koEyp/KLYJz6nTv68JJV1U5CZ8osQXYhz4Ounl/heU5+CC s2RmXd9g==; From: Richard Sent To: Jonathan Brielmaier Subject: Re: [bug#70542] [PATCH 0/4] Improve Shepherd service support for networked file systems In-Reply-To: <9e8e0f42-e403-d919-3b18-be010757097c@web.de> (Jonathan Brielmaier's message of "Thu, 25 Apr 2024 08:51:56 +0200") References: <9e8e0f42-e403-d919-3b18-be010757097c@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Thu, 25 Apr 2024 09:43:47 -0400 Message-ID: <87le51y2uk.fsf@freakingpenguin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Authenticated-Id: richard@freakingpenguin.com X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70542 Cc: 70542@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Jonathan! Jonathan Brielmaier writes: > Hello Richard, > > thanks for improving the CIFS mounting problem! > > I'm using a CIFS share on one of my servers. There I stumbled upon a > problem, that the share is disappearing (e.g. CIFS server unavailable > for a short time) and gets not automatically remounted. > > Do you know if this particular problem gets resolved with your patch? > I've never experienced that issue myself so I can't say for sure. However, I don't believe my patch would resolve that issue. file-system-shepherd-service in (gnu services base) is in charge of mounting the file system. That service does not attempt to monitor the file system's status after running. There's no daemon. If the file system is mounted successfully, Shepherd will think there's no problem. My understanding is that Shepherd will not respawn a service that starts, then exits sucessfully. From Shepherd's manual: > start=E2=80=99. If the starting attempt failed, it must return =E2=80=98= #f=E2=80=99 > or throw an exception; otherwise, the return value is stored > as the =E2=80=9Crunning value=E2=80=9D of the service. This could be solved by, for example, adding a remount? flag and/or remount-delay field to file-systems and changing file-system-shepherd-service to conditionally use a fork-style constructor many other services use. Within that process, a loop checks if there is a file system mounted at the target location. There might be a better way to structure this. I'd be a little worried about adding many new file-system record fields that aren't always used. Consider when needed-for-boot is #t, file-system-shepherd-service isn't used at all. Those new flags silently do nothing. I think that's fine when it's just one (requirements), but it's probably worth some thought if we add more later. Either way it's probably another patch problem. --=20 Take it easy, Richard Sent Making my computer weirder one commit at a time. From debbugs-submit-bounces@debbugs.gnu.org Thu May 02 08:46:25 2024 Received: (at 70542) by debbugs.gnu.org; 2 May 2024 12:46:25 +0000 Received: from localhost ([127.0.0.1]:43565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2VpR-0005XK-0i for submit@debbugs.gnu.org; Thu, 02 May 2024 08:46:25 -0400 Received: from mail-108-mta139.mxroute.com ([136.175.108.139]:37509) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2VpL-0005X0-SD for 70542@debbugs.gnu.org; Thu, 02 May 2024 08:46:23 -0400 Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta139.mxroute.com (ZoneMTA) with ESMTPSA id 18f3956fd460008ca2.001 for <70542@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 02 May 2024 12:45:53 +0000 X-Zone-Loop: 236c2edd566f757011b69fecefdb3d75742efe658c35 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freakingpenguin.com; s=x; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=voGzJMhby+1FBXW/R7jUVkqn/Sg6kln0VwjUbhGrJaE=; b=eeUAz++Fp/K5grjpSUkqcibno+ J1nN+LhZEorW7cLEmog3Xp5Muel1w1Xp2HunjUbGSCd711UdFbnAW2/pQc2lCKXGE1bhYCXjAJU7g YVQ70TK2VYrPevkAOsh8EYOBSO0S1VNbNeEkaD5kbY8w25utuyg9nebB0UgGgMnUfK7P4yiDJQDYK RLA4HNg2GN3DuVdv9N3ozktT6Z0f0yDryan7k92oax826W1VkbVjgKMl9ghUAdHLMpjUmLbSKPJsh f/ZcrrKxdoJUEra2Add6vZJexKtIRl42H0y8TQTyv1ZxeJXD22yQUOl8EExkqEwSyHe9PoUtsMyC2 /QQbvIUA==; From: Richard Sent To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: Value in adding Shepherd requirements to file-systems entries? In-Reply-To: <87ikzwzi9s.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Thu, 02 May 2024 11:15:43 +0200") References: <87le54hhfu.fsf@freakingpenguin.com> <87ikzwzi9s.fsf@gnu.org> Date: Thu, 02 May 2024 08:45:45 -0400 Message-ID: <87a5l8qt52.fsf@freakingpenguin.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Authenticated-Id: richard@freakingpenguin.com X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70542 Cc: guix-devel@gnu.org, 70542@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludo! > The other option would be to allow for symbols in the =E2=80=98dependenci= es=E2=80=99 > field, because it=E2=80=99s really the same thing. That would only requi= re a > new clause in the =E2=80=98dependency->shepherd-service-name=E2=80=99 pro= cedure. Personally I prefer separating requirements and dependencies. Dependencies adjusts the order of mounting file-systems /before/ provisioning 'file-systems, while requirements actually delays mounting a file system until Shepherd services have started (by removing it as a requirement for provisioning 'file-systems). I think this distinction in behavior should be emphasized in the API and manual. An alternative to the requirement/requirements field is changing the name to shepherd-requirement. That would be consistent with other services and make the distinction between dependencies and requirements unambiguous. (And sidestep the pluralization question.) Happy to change to whatever the consensus is! --=20 Take it easy, Richard Sent Making my computer weirder one commit at a time. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 01 19:27:02 2024 Received: (at 70542) by debbugs.gnu.org; 1 Jun 2024 23:27:02 +0000 Received: from localhost ([127.0.0.1]:57523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDY7q-0003ru-5F for submit@debbugs.gnu.org; Sat, 01 Jun 2024 19:27:02 -0400 Received: from mail-108-mta181.mxroute.com ([136.175.108.181]:40801) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDY7o-0003rd-9s for 70542@debbugs.gnu.org; Sat, 01 Jun 2024 19:27:01 -0400 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta181.mxroute.com (ZoneMTA) with ESMTPSA id 18fd6207f25000e2b6.001 for <70542@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sat, 01 Jun 2024 23:26:45 +0000 X-Zone-Loop: 05facf07d4232e15f9e17e75f52095b38cc13819f541 X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freakingpenguin.com; s=x; h=Content-Transfer-Encoding:MIME-Version: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=t1zMUYNtBF5ZGXk2sOcGl5QMotp9T8iuWu9djiVDKFI=; b=S0t+gVNXFMoJoiY2ZxD+at0Gv2 IOmjHRs4LD9Ri30/BwwfHV2XmcT8QBRb5apZKyhVgd56IK/NfEkhkNSg5sFPaAHrXrx9vhCSE7Qu4 oLW+NlTjOSt7pwz7CuJX1Imq6k0qXaSUrBqZtgVlBtAD0XrNy4Xuq9aRHxHjanDWU6pczf4NXTiX6 WxUwqfV2fxsG2Fj4CcPVFiAfJS80pJ/ROY0d0ykw1qy6JjbJT8fH2H2jP8UrjQw/j3MIeENPgS+I/ 2ZJ2U4xme9vMBl0+/jK6+D8/l6R8/38G5Arc0CelExNeusNItKk6i0oxcTJsam4WGf3ioKYITsiQi oyeVke/w==; From: Richard Sent To: 70542@debbugs.gnu.org Subject: [PATCH v3 0/3] Improve Shepherd service support for networked file systems Date: Sat, 1 Jun 2024 19:26:15 -0400 Message-ID: MIME-Version: 1.0 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit X-Authenticated-Id: richard@freakingpenguin.com X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70542 Cc: Richard Sent X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi all, Since there hasn't been any discussion on this patch and it fell off QA recently, I figured I'd resubmit with a small change. file-system-requirements was changed to file-system-shepherd-requirements to be more consistent with other services. I still feel like shepherd-requirements shouldn't be merged with dependencies due to functional differences, but if there's consensus otherwise I can change it. I believe all other feedback so far has been addressed. :) Richard Sent (3): services: base: Add optional delayed mount of file-systems file-systems: Add host-to-ip nested function file-systems: Add support for mounting CIFS file systems doc/guix.texi | 14 +++++++++ gnu/build/file-systems.scm | 60 ++++++++++++++++++++++++++++++++----- gnu/machine/ssh.scm | 3 +- gnu/services/base.scm | 14 +++++++-- gnu/system/file-systems.scm | 57 ++++++++++++++++++----------------- guix/scripts/system.scm | 3 +- 6 files changed, 113 insertions(+), 38 deletions(-) base-commit: fba6896f625dcbeef112387fc90abe83acae1720 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 01 19:27:07 2024 Received: (at 70542) by debbugs.gnu.org; 1 Jun 2024 23:27:07 +0000 Received: from localhost ([127.0.0.1]:57526 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDY7u-0003sK-GM for submit@debbugs.gnu.org; Sat, 01 Jun 2024 19:27:07 -0400 Received: from mail-108-mta28.mxroute.com ([136.175.108.28]:33213) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDY7t-0003sD-0C for 70542@debbugs.gnu.org; Sat, 01 Jun 2024 19:27:05 -0400 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta28.mxroute.com (ZoneMTA) with ESMTPSA id 18fd6209b42000e2b6.001 for <70542@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sat, 01 Jun 2024 23:26:52 +0000 X-Zone-Loop: ceb20fc60aff35bc0dc15f5855f592538b213dadcf1c X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freakingpenguin.com; s=x; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=OU0QWBAQSRCJR9iz4SlpjMP1fKEkEkWGsEZ2KIPGil0=; b=feLAxADQVTnHiSgiWqBAu5RRUt jVzDB75mdmOOP7bd695VJticFc69QR7Y1L00mGjqkWmIbu2yoNXxgrUGcc1nK8E6UN/jPPjfM4l9o kvELeA0vevOuFXUfJUEr+GxMP80MuMsJQZSN5rQHxqbBxlbYGaH9Kj6duhUvtYyBAqLfb7t/sFcKK 8NyXYKEbHe09nTmQP2zh2BeXBB2GG450I26QchIZCjqa9BwexINmGkns4mDITaEI4pm/6GglW+OU/ H7w8E3MPJfgmXWiDIDHtCJC1PJgKelv4pFWfvH8BaCJrSTCQHeR/tWSDID+3gcTKtnFSdp2W0jN5D /z3cl9Og==; From: Richard Sent To: 70542@debbugs.gnu.org Subject: [PATCH v3 1/3] services: base: Add optional delayed mount of file-systems Date: Sat, 1 Jun 2024 19:26:16 -0400 Message-ID: <9ce75e011c2459e20902e7fe1d68b691531daa66.1717283896.git.richard@freakingpenguin.com> In-Reply-To: References: MIME-Version: 1.0 X-Debbugs-Cc: Florian Pelz , Ludovic Courtès , Matthew Trzcinski , Maxim Cournoyer Content-Transfer-Encoding: 8bit X-Authenticated-Id: richard@freakingpenguin.com X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70542 Cc: Richard Sent X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Add a mechanism to only require mounting a subset of file-system entries during early Shepherd initialization. Any file-system with additional Shepherd service requirements (e.g. networking) is not required to provision 'file-systems. * gnu/services/base.scm (file-system-shepherd-service): Splice file-system-requirements into the Shepherd service requirement list. (file-system-shepherd-services): Provision 'file-system only when file system services without additional Shepherd requirements are started. * gnu/system/file-systems.scm (file-system): Add shepherd-requirements field to the file-system record. This field is used for adding additional Shepherd requirements to a file-system Shepherd service. * doc/guix.texi: Add documentation for file-system shepherd-requirements. Change-Id: If0392db03d48e8820aa53df1df482c12ec72e1a5 --- doc/guix.texi | 14 +++++++++ gnu/services/base.scm | 14 +++++++-- gnu/system/file-systems.scm | 57 +++++++++++++++++++------------------ 3 files changed, 56 insertions(+), 29 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 1224104038..158fd6c125 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -17862,6 +17862,20 @@ File Systems Another example is a file system that depends on a mapped device, for example for an encrypted partition (@pxref{Mapped Devices}). + +@item @code{shepherd-requirements} (default: @code{'()}) +This is a list of symbols denoting Shepherd requirements that must be +met before mounting the file system. + +As an example, an NFS file system would typically have a requirement for +@code{networking}. + +Typically, file systems are mounted before most other Shepherd services +are started. However, file systems with a non-empty +shepherd-requirements field are mounted after Shepherd services have +begun. Any Shepherd service that depends on a file system with a +non-empty shepherd-requirements field must depend on it directly and not +on the generic symbol @code{file-systems}. @end table @end deftp diff --git a/gnu/services/base.scm b/gnu/services/base.scm index 85160bd3ab..a552438753 100644 --- a/gnu/services/base.scm +++ b/gnu/services/base.scm @@ -404,6 +404,7 @@ (define (file-system-shepherd-service file-system) (create? (file-system-create-mount-point? file-system)) (mount? (file-system-mount? file-system)) (dependencies (file-system-dependencies file-system)) + (requirements (file-system-shepherd-requirements file-system)) (packages (file-system-packages (list file-system)))) (and (or mount? create?) (with-imported-modules (source-module-closure @@ -412,7 +413,8 @@ (define (file-system-shepherd-service file-system) (provision (list (file-system->shepherd-service-name file-system))) (requirement `(root-file-system udev - ,@(map dependency->shepherd-service-name dependencies))) + ,@(map dependency->shepherd-service-name dependencies) + ,@requirements)) (documentation "Check, mount, and unmount the given file system.") (start #~(lambda args #$(if create? @@ -461,12 +463,20 @@ (define (file-system-shepherd-services file-systems) (or (file-system-mount? x) (file-system-create-mount-point? x))) file-systems))) + (define sink (shepherd-service (provision '(file-systems)) (requirement (cons* 'root-file-system 'user-file-systems (map file-system->shepherd-service-name - file-systems))) + ;; Do not require file systems with Shepherd + ;; requirements to provision + ;; 'file-systems. Many Shepherd services + ;; require 'file-systems, so we would likely + ;; deadlock. + (filter (lambda (file-system) + (null? (file-system-shepherd-requirements file-system))) + file-systems)))) (documentation "Target for all the initially-mounted file systems") (start #~(const #t)) (stop #~(const #f)))) diff --git a/gnu/system/file-systems.scm b/gnu/system/file-systems.scm index c791b24a9f..4ea8237c70 100644 --- a/gnu/system/file-systems.scm +++ b/gnu/system/file-systems.scm @@ -57,6 +57,7 @@ (define-module (gnu system file-systems) file-system-repair file-system-create-mount-point? file-system-dependencies + file-system-shepherd-requirements file-system-location file-system-type-predicate @@ -161,33 +162,35 @@ (define-syntax validate-file-system-flags (define-record-type* file-system make-file-system file-system? - (device file-system-device) ; string | | - (mount-point file-system-mount-point) ; string - (type file-system-type) ; string - (flags file-system-flags ; list of symbols - (default '()) - (sanitize validate-file-system-flags)) - (options file-system-options ; string or #f - (default #f)) - (mount? file-system-mount? ; Boolean - (default #t)) - (mount-may-fail? file-system-mount-may-fail? ; Boolean - (default #f)) - (needed-for-boot? %file-system-needed-for-boot? ; Boolean - (default #f)) - (check? file-system-check? ; Boolean - (default #t)) - (skip-check-if-clean? file-system-skip-check-if-clean? ; Boolean - (default #t)) - (repair file-system-repair ; symbol or #f - (default 'preen)) - (create-mount-point? file-system-create-mount-point? ; Boolean - (default #f)) - (dependencies file-system-dependencies ; list of - (default '())) ; or - (location file-system-location - (default (current-source-location)) - (innate))) + (device file-system-device) ; string | | + (mount-point file-system-mount-point) ; string + (type file-system-type) ; string + (flags file-system-flags ; list of symbols + (default '()) + (sanitize validate-file-system-flags)) + (options file-system-options ; string or #f + (default #f)) + (mount? file-system-mount? ; Boolean + (default #t)) + (mount-may-fail? file-system-mount-may-fail? ; Boolean + (default #f)) + (needed-for-boot? %file-system-needed-for-boot? ; Boolean + (default #f)) + (check? file-system-check? ; Boolean + (default #t)) + (skip-check-if-clean? file-system-skip-check-if-clean? ; Boolean + (default #t)) + (repair file-system-repair ; symbol or #f + (default 'preen)) + (create-mount-point? file-system-create-mount-point? ; Boolean + (default #f)) + (dependencies file-system-dependencies ; list of + (default '())) ; or + (shepherd-requirements file-system-shepherd-requirements ; list of symbols + (default '())) + (location file-system-location + (default (current-source-location)) + (innate))) ;; A file system label for use in the 'device' field. (define-record-type -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 01 19:27:12 2024 Received: (at 70542) by debbugs.gnu.org; 1 Jun 2024 23:27:12 +0000 Received: from localhost ([127.0.0.1]:57531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDY80-0003sj-3I for submit@debbugs.gnu.org; Sat, 01 Jun 2024 19:27:12 -0400 Received: from mail-108-mta164.mxroute.com ([136.175.108.164]:36419) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDY7y-0003sV-13 for 70542@debbugs.gnu.org; Sat, 01 Jun 2024 19:27:10 -0400 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta164.mxroute.com (ZoneMTA) with ESMTPSA id 18fd620a234000e2b6.001 for <70542@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sat, 01 Jun 2024 23:26:54 +0000 X-Zone-Loop: e76e2358c0ce9f97b3e07bd05981b6003293e7f0e764 X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freakingpenguin.com; s=x; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=yasHRBpWaIqbi/HgdOUj3gkXs98JDrHEX8axByTcj9g=; b=cy4kmPXNJ3U914/udoTpJUL75g zKkuBCs1aet0EG+Kw3i9S/TLqIDuO/BjRlQppS9B9qrtbiEwqjroXtZTyATYKQ17Lo7k97cF+EcYS GTDbN0Qrx8zAqoZJ+PVNFMucnaRc6Gyd3M4Xp5jy9MqdegWQeqUvwlrvrMuCJntJIHq0MEE+W8J3+ XiPHsEZv3qyCYdXU2V5U3SGdQXGdZ+dFaZB74lIFMrWvU0weLNCzvLvvdXhEr6zLWaZ975ctxG2Uc /2j5DwH6ScMde5NVXeUUnAU+2WHZo7foTO3KdhrAyFVLwXcfnsF/C6uJhpU/JO7Elx8jsm78/SucJ jN0PYT6Q==; From: Richard Sent To: 70542@debbugs.gnu.org Subject: [PATCH v3 2/3] file-systems: Add host-to-ip nested function Date: Sat, 1 Jun 2024 19:26:17 -0400 Message-ID: In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authenticated-Id: richard@freakingpenguin.com X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70542 Cc: Richard Sent X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/build/file-systems (mount-file-system): Split out getaddrinfo logic into a dedicated function, (host-to-ip) Change-Id: I522d70a10651ca79533a4fc60b96b884243a3526 --- gnu/build/file-systems.scm | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/gnu/build/file-systems.scm b/gnu/build/file-systems.scm index 78d779f398..e47ac39ab0 100644 --- a/gnu/build/file-systems.scm +++ b/gnu/build/file-systems.scm @@ -1156,6 +1156,14 @@ (define* (mount-file-system fs #:key (root "/root") (repair (file-system-repair fs))) "Mount the file system described by FS, a object, under ROOT." + (define* (host-to-ip host #:optional service) + "Return the IP address for host, which may be an IP address or a hostname." + (let* ((aa (match (getaddrinfo host service) ((x . _) x))) + (sa (addrinfo:addr aa)) + (inet-addr (inet-ntop (sockaddr:fam sa) + (sockaddr:addr sa)))) + inet-addr)) + (define (mount-nfs source mount-point type flags options) (let* ((idx (string-rindex source #\:)) (host-part (string-take source idx)) @@ -1163,11 +1171,7 @@ (define* (mount-file-system fs #:key (root "/root") (host (match (string-split host-part (string->char-set "[]")) (("" h "") h) ((h) h))) - (aa (match (getaddrinfo host "nfs") ((x . _) x))) - (sa (addrinfo:addr aa)) - (inet-addr (inet-ntop (sockaddr:fam sa) - (sockaddr:addr sa)))) - + (inet-addr (host-to-ip host "nfs"))) ;; Mounting an NFS file system requires passing the address ;; of the server in the addr= option (mount source mount-point type flags @@ -1176,6 +1180,7 @@ (define* (mount-file-system fs #:key (root "/root") (if options (string-append "," options) ""))))) + (let* ((type (file-system-type fs)) (source (canonicalize-device-spec (file-system-device fs))) (target (string-append root "/" -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 01 19:27:13 2024 Received: (at 70542) by debbugs.gnu.org; 1 Jun 2024 23:27:13 +0000 Received: from localhost ([127.0.0.1]:57533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDY80-0003sn-Hl for submit@debbugs.gnu.org; Sat, 01 Jun 2024 19:27:13 -0400 Received: from mail-108-mta17.mxroute.com ([136.175.108.17]:36475) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDY7x-0003sU-Uu for 70542@debbugs.gnu.org; Sat, 01 Jun 2024 19:27:11 -0400 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta17.mxroute.com (ZoneMTA) with ESMTPSA id 18fd620ae72000e2b6.001 for <70542@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sat, 01 Jun 2024 23:26:57 +0000 X-Zone-Loop: 0f629324437261765c86d6d917a31091273f3c21b2f9 X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freakingpenguin.com; s=x; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=vs0ksIXRLil2Wu6ptR0iYB7JH/lgfD33tOt8ohbEIV4=; b=EpKAjvkVhWnqYaw55HpBVovXhZ /ydh2vIVUgvbUVbYkZk1bVuq+nI4Ub2XEL3oKSoPdFWjY+TpRPteI1Al5jLMcv5MQWCcNyAkemfW1 fsiftKXlx3HEwzfn7QdQ90XA2p5aX6CfSsoGyxiiz+AXBkUrfq0ny8qnC3OqCS0iAcS0O5Zsqj18+ pIqrqcYMB1YYzwOyusYUYl6Uw8hRb1zN7bqWpcQiwZPvwQP0tuDBkDm176ylqiiLt2DeIcjaFUytX VeiriaSXhHtliy1/212bHiurISb7kVYvxme0DNM6PZi6Lw7+h48QvzHMUQLMrHCet7JQjwJUI/YK4 uOgXpEiQ==; From: Richard Sent To: 70542@debbugs.gnu.org Subject: [PATCH v3 3/3] file-systems: Add support for mounting CIFS file systems Date: Sat, 1 Jun 2024 19:26:18 -0400 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Authenticated-Id: richard@freakingpenguin.com X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70542 Cc: Richard Sent X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/build/file-systems (canonicalize-device-name): Do not attempt to resolve CIFS formatted device specifications. (mount-file-systems): Add mount-cifs nested function. * gnu/machine/ssh.scm (machine-check-file-system-availability): Skip checking for CIFS availability, similar to NFS. * guix/scripts/system.scm (check-file-system-availability): Likewise. Change-Id: I182e290eba64bbe5d1332815eb93bb68c01e0c3c --- gnu/build/file-systems.scm | 45 ++++++++++++++++++++++++++++++++++++-- gnu/machine/ssh.scm | 3 ++- guix/scripts/system.scm | 3 ++- 3 files changed, 47 insertions(+), 4 deletions(-) diff --git a/gnu/build/file-systems.scm b/gnu/build/file-systems.scm index e47ac39ab0..ae29b36c4e 100644 --- a/gnu/build/file-systems.scm +++ b/gnu/build/file-systems.scm @@ -8,6 +8,7 @@ ;;; Copyright © 2020 Maxim Cournoyer ;;; Copyright © 2022 Oleg Pykhalov ;;; Copyright © 2024 Nicolas Graves +;;; Copyright © 2024 Richard Sent ;;; ;;; This file is part of GNU Guix. ;;; @@ -37,6 +38,7 @@ (define-module (gnu build file-systems) #:use-module (rnrs bytevectors) #:use-module (ice-9 match) #:use-module (ice-9 rdelim) + #:use-module (ice-9 regex) #:use-module (system foreign) #:autoload (system repl repl) (start-repl) #:use-module (srfi srfi-1) @@ -1047,8 +1049,11 @@ (define (canonicalize-device-spec spec) (match spec ((? string?) - (if (or (string-contains spec ":/") (string=? spec "none")) - spec ; do not resolve NFS / tmpfs devices + (if (or (string-contains spec ":/") ;nfs + (and (>= (string-length spec) 2) + (equal? (string-take spec 2) "//")) ;cifs + (string=? spec "none")) + spec ; do not resolve NFS / CIFS / tmpfs devices ;; Nothing to do, but wait until SPEC shows up. (resolve identity spec identity))) ((? file-system-label?) @@ -1181,6 +1186,40 @@ (define* (mount-file-system fs #:key (root "/root") (string-append "," options) ""))))) + (define (mount-cifs source mount-point type flags options) + ;; Source is of form "///" + (let* ((regex-match (string-match "//([^/]+)/(.+)" source)) + (server (match:substring regex-match 1)) + (share (match:substring regex-match 2)) + ;; Match ",guest,", ",guest$", "^guest,", or "^guest$," not + ;; e.g. user=foo,pass=notaguest + (guest? (string-match "(^|,)(guest)($|,)" options)) + ;; Perform DNS resolution now instead of attempting kernel dns + ;; resolver upcalling. /sbin/request-key does not exist and the + ;; kernel hardcodes the path. + ;; + ;; (getaddrinfo) doesn't support cifs service, so omit it. + (inet-addr (host-to-ip server))) + (mount source mount-point type flags + (string-append "ip=" + inet-addr + ;; As of Linux af1a3d2ba9 (v5.11) unc is ignored + ;; and source is parsed by the kernel + ;; directly. Pass it for compatibility. + ",unc=" + ;; Match format of mount.cifs's mount syscall. + "\\\\" server "\\" share + (if guest? + ",user=,pass=" + "") + (if options + ;; No need to delete "guest" from options. + ;; linux/fs/smb/client/fs_context.c explicitly + ;; ignores it. Also, avoiding excess commas + ;; when deleting is a pain. + (string-append "," options) + ""))))) + (let* ((type (file-system-type fs)) (source (canonicalize-device-spec (file-system-device fs))) (target (string-append root "/" @@ -1215,6 +1254,8 @@ (define* (mount-file-system fs #:key (root "/root") (cond ((string-prefix? "nfs" type) (mount-nfs source target type flags options)) + ((string-prefix? "cifs" type) + (mount-cifs source target type flags options)) ((memq 'shared (file-system-flags fs)) (mount source target type flags options) (mount "none" target #f MS_SHARED)) diff --git a/gnu/machine/ssh.scm b/gnu/machine/ssh.scm index b47ce7c225..0be9ebbc0d 100644 --- a/gnu/machine/ssh.scm +++ b/gnu/machine/ssh.scm @@ -222,7 +222,8 @@ (define (machine-check-file-system-availability machine) (not (member (file-system-type fs) %pseudo-file-system-types)) ;; Don't try to validate network file systems. - (not (string-prefix? "nfs" (file-system-type fs))) + (not (or (string-prefix? "nfs" (file-system-type fs)) + (string-prefix? "cifs" (file-system-type fs)))) (not (memq 'bind-mount (file-system-flags fs))))) (operating-system-file-systems (machine-operating-system machine)))) diff --git a/guix/scripts/system.scm b/guix/scripts/system.scm index 2260bcf985..99c58f3812 100644 --- a/guix/scripts/system.scm +++ b/guix/scripts/system.scm @@ -591,7 +591,8 @@ (define (check-file-system-availability file-systems) (not (member (file-system-type fs) %pseudo-file-system-types)) ;; Don't try to validate network file systems. - (not (string-prefix? "nfs" (file-system-type fs))) + (not (or (string-prefix? "nfs" (file-system-type fs)) + (string-prefix? "cifs" (file-system-type fs)))) (not (memq 'bind-mount (file-system-flags fs))))) file-systems)) -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 04 06:07:09 2024 Received: (at 70542-done) by debbugs.gnu.org; 4 Jun 2024 10:07:09 +0000 Received: from localhost ([127.0.0.1]:35259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sER4O-0006nk-JX for submit@debbugs.gnu.org; Tue, 04 Jun 2024 06:07:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sER4M-0006n6-0P for 70542-done@debbugs.gnu.org; Tue, 04 Jun 2024 06:07:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sER40-0005wg-3y; Tue, 04 Jun 2024 06:06:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=aPGmV/TwDxdtU7czJBwxGwa0v2c3o3t9N/Dx0RT+jRo=; b=DZnkvObqKEBSWvWQtxzP D4Q0JgOTK2MybcCxtiP7MBOOejDGmA55kCPGhipy31Wa473VF2PA4yoVGnqAxwQutvCD5jc2VrVmi N9QO7BqmfYnOA/+HnSNZcsXg9NfeZaJ3sydaqSIRulEAJk5TS591oQtB965d6Ui7wwIxGKpuH6hwM GKzlY1pKOuv+rn/nmq1uuf1TRGibQg1KMFJQcETVhYxd9Z+PxrB3oz+bUIQxNqEkuKcA+9IFyymtq iw5Lh+gbOJP+x+HRQGHTxEDfVWM0/1yrsrxOp30eKw3W7sReNhZO+PuzRVhRlepEMv7vB5D9i11rq IVenQQfwpnI1Pw==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Richard Sent Subject: Re: [bug#70542] [PATCH v3 0/3] Improve Shepherd service support for networked file systems In-Reply-To: (Richard Sent's message of "Sat, 1 Jun 2024 19:26:15 -0400") References: Date: Tue, 04 Jun 2024 12:06:41 +0200 Message-ID: <874ja981ji.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70542-done Cc: Josselin Poiret , 70542-done@debbugs.gnu.org, Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Ricardo Wurmus , Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Richard, Richard Sent skribis: > Since there hasn't been any discussion on this patch and it fell off QA > recently, I figured I'd resubmit with a small change. > > file-system-requirements was changed to file-system-shepherd-requirements= to > be more consistent with other services. > > I still feel like shepherd-requirements shouldn't be merged with dependen= cies > due to functional differences, but if there's consensus otherwise I can c= hange > it. > > I believe all other feedback so far has been addressed. :) Thanks for the heads-up, I had forgotten about this patch set=E2=80=A6 > services: base: Add optional delayed mount of file-systems > file-systems: Add host-to-ip nested function > file-systems: Add support for mounting CIFS file systems LGTM, applied. Thank you! Ludo=E2=80=99. From unknown Fri Jun 20 07:28:48 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 02 Jul 2024 11:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator