GNU bug report logs - #70529
Several packages have dbus service files with broken file paths

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 70529 in the body.
You can then email your comments to 70529 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nathan Dehnel <ncdehnel <at> gmail.com>
To: bug-guix <bug-guix <at> gnu.org>
Subject: Several packages have dbus service files with broken file paths
Date: Tue, 23 Apr 2024 04:18:27 -0500

I was investigating powerdevil and snapper being broken and I
discovered packages with incorrect file paths in the Exec line of
their dbus services

$ ls -d /gnu/store/**/share/dbus-1/services/** | grep -v
profile/share/dbus-1 | while read line; do grep Exec $line 2>
/dev/null | grep -v /gnu/store && echo $line >>/dev/stderr; done
Exec=libexec/fontinst
/gnu/store/6hz6j922gs1861h49id3ddjsg02cwkl1-plasma-workspace-5.27.7/share/dbus-1/services/org.kde.fontinst.service
Exec=libexec/fontinst
/gnu/store/nv8ccgy6jzfjkik5c5vy6id7dplnbb1y-plasma-workspace-5.27.7/share/dbus-1/services/org.kde.fontinst.service



$ ls -d /gnu/store/**/share/dbus-1/system-services/** | grep -v
profile/share/dbus-1 | while read line; do grep Exec $line 2>
/dev/null | grep -v /gnu/store && echo $line >>/dev/stderr; done
Exec=/usr/sbin/snapperd
/gnu/store/07dlq92dnm85k7rmgl9q5ma8r6jsy79n-snapper-0.10.7/share/dbus-1/system-services/org.opensuse.Snapper.service
# who have MM installed but turned off.  Thus the Exec path available to
# D-Bus is /bin/false, but systemd knows the real Exec path due to the MM
/gnu/store/16j7szl8lgjzb3fhm4b0mrs2dhd18pzr-modem-manager-1.18.12/share/dbus-1/system-services/org.freedesktop.ModemManager1.service
Exec=libexec/kde_ufw_plugin_helper
/gnu/store/2pr3flqh8yjkyl5zdk6ymw7azhdsd5qn-plasma-firewall-5.27.7/share/dbus-1/system-services/org.kde.ufw.service
Exec=/usr/sbin/snapperd
/gnu/store/2vlrhf10dxx5zl6pqzkk0hd06f7g1bqq-snapper-0.10.7/share/dbus-1/system-services/org.opensuse.Snapper.service
# who have MM installed but turned off.  Thus the Exec path available to
# D-Bus is /bin/false, but systemd knows the real Exec path due to the MM
/gnu/store/5ca8f1gcc5ahn9kh2994mxnkwhny7csw-modem-manager-1.18.12/share/dbus-1/system-services/org.freedesktop.ModemManager1.service
Exec=libexec/fontinst_helper
/gnu/store/6hz6j922gs1861h49id3ddjsg02cwkl1-plasma-workspace-5.27.7/share/dbus-1/system-services/org.kde.fontinst.service
Exec=libexec/backlighthelper
/gnu/store/7m8l38wvi92bdar6li8amjaxhnvs6ffi-powerdevil-5.27.7/share/dbus-1/system-services/org.kde.powerdevil.backlighthelper.service
Exec=libexec/chargethresholdhelper
/gnu/store/7m8l38wvi92bdar6li8amjaxhnvs6ffi-powerdevil-5.27.7/share/dbus-1/system-services/org.kde.powerdevil.chargethresholdhelper.service
Exec=libexec/discretegpuhelper
/gnu/store/7m8l38wvi92bdar6li8amjaxhnvs6ffi-powerdevil-5.27.7/share/dbus-1/system-services/org.kde.powerdevil.discretegpuhelper.service
Exec=libexec/kauth_ktexteditor_helper
/gnu/store/7xjgrp07s6vni8nr9j6kg43my94x4kr4-ktexteditor-5.114.0/share/dbus-1/system-services/org.kde.ktexteditor.katetextbuffer.service
Exec=libexec/kauth_ktexteditor_helper
/gnu/store/8bwwmnm1vsf16950cdm70c1vd8a1rhg4-ktexteditor-5.114.0/share/dbus-1/system-services/org.kde.ktexteditor.katetextbuffer.service
Exec=libexec/kde_ufw_plugin_helper
/gnu/store/d5vwa7vdcnf4vmarb9dz2690jgylxblp-plasma-firewall-5.27.7/share/dbus-1/system-services/org.kde.ufw.service
Exec=/usr/sbin/snapperd
/gnu/store/gc335dlb1y368fhv8625lmgp6bj1g3in-snapper-0.10.7/share/dbus-1/system-services/org.opensuse.Snapper.service
Exec=libexec/ksysguardprocesslist_helper
/gnu/store/i1n66kjkc1yd4ni1wpsgd40w1wvf3sji-libksysguard-5.27.7/share/dbus-1/system-services/org.kde.ksysguard.processlisthelper.service
Exec=libexec/kcmdatetimehelper
/gnu/store/l8f8fnv5ni0frawqh45yds1as494n26h-plasma-desktop-5.27.7/share/dbus-1/system-services/org.kde.kcontrol.kcmclock.service
Exec=libexec/kded-smart-helper
/gnu/store/llvacn6ibdrigxhg1bhqgsvad3ivpyqd-plasma-disks-5.27.7/share/dbus-1/system-services/org.kde.kded.smart.service
Exec=libexec/kinfocenter-dmidecode-helper
/gnu/store/mwlcz9f2dl650mvrhzll6c9msc4ppkhb-kinfocenter-5.27.7/share/dbus-1/system-services/org.kde.kinfocenter.dmidecode.service
Exec=libexec/fontinst_helper
/gnu/store/nv8ccgy6jzfjkik5c5vy6id7dplnbb1y-plasma-workspace-5.27.7/share/dbus-1/system-services/org.kde.fontinst.service
Exec=libexec/kded-smart-helper
/gnu/store/qw745xy5hz8viq4y6csrdw89nwyj0qxs-plasma-disks-5.27.7/share/dbus-1/system-services/org.kde.kded.smart.service
Exec=libexec/kinfocenter-dmidecode-helper
/gnu/store/srb98cwh801f5hr80vwv4mlnmspjsy0d-kinfocenter-5.27.7/share/dbus-1/system-services/org.kde.kinfocenter.dmidecode.service
Exec=libexec/ksysguardprocesslist_helper
/gnu/store/vhzhsdn13q1q8qfns23kb2l7w066ig7j-libksysguard-5.27.7/share/dbus-1/system-services/org.kde.ksysguard.processlisthelper.service
Exec=libexec/kcmdatetimehelper
/gnu/store/wcc6skf3p74s0mmhhs32hrzk3p9srid6-plasma-desktop-5.27.7/share/dbus-1/system-services/org.kde.kcontrol.kcmclock.service
Exec=libexec/backlighthelper
/gnu/store/zsszwz0q0h2vj4vbzw0lwj2vxvqjavn9-powerdevil-5.27.7/share/dbus-1/system-services/org.kde.powerdevil.backlighthelper.service
Exec=libexec/chargethresholdhelper
/gnu/store/zsszwz0q0h2vj4vbzw0lwj2vxvqjavn9-powerdevil-5.27.7/share/dbus-1/system-services/org.kde.powerdevil.chargethresholdhelper.service
Exec=libexec/discretegpuhelper
/gnu/store/zsszwz0q0h2vj4vbzw0lwj2vxvqjavn9-powerdevil-5.27.7/share/dbus-1/system-services/org.kde.powerdevil.discretegpuhelper.service

Message #8 received at 70529 <at> debbugs.gnu.org (full text, mbox):

From: iyzsong <at> envs.net
To: guix-patches <at> gnu.org
Cc: 70529 <at> debbugs.gnu.org,
 宋文武 <iyzsong <at> member.fsf.org>
Subject: [PATCH] gnu: kauth: Fix KAUTH_HELPER_INSTALL_ABSOLUTE_DIR.
Date: Thu, 25 Apr 2024 18:32:37 +0800

From: 宋文武 <iyzsong <at> member.fsf.org>

KAuth helpers use KAUTH_HELPER_INSTALL_ABSOLUTE_DIR as the prefix for "Exec="
in their dbus service files, which should really be an absolute directory.

Fixes <https://issues.guix.gnu.org/70529>.

* gnu/packages/kde-frameworks.scm (kauth)[arguments]<#:phases>: In
fix-cmake-install-directories phase, replace KAUTH_HELPER_INSTALL_DIR
with '${KDE_INSTALL_LIBEXECDIR}/kauth' and KAUTH_HELPER_INSTALL_ABSOLUTE_DIR
with '${KDE_INSTALL_FULL_LIBEXECDIR}/kauth'.

Change-Id: I57920c59dca503fd4bc8727cb35e1b0fb6016e56
---
 gnu/packages/kde-frameworks.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 95c0f95e8c..8991c36f89 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -1645,9 +1645,9 @@ (define-public kauth
                 (("@KAUTH_POLICY_FILES_INSTALL_DIR@")
                  "${KDE_INSTALL_DATADIR}/polkit-1/actions")
                 (("@KAUTH_HELPER_INSTALL_DIR@")
-                 "${KDE_INSTALL_LIBEXECDIR}")
+                 "${KDE_INSTALL_LIBEXECDIR}/kauth")
                 (("@KAUTH_HELPER_INSTALL_ABSOLUTE_DIR@")
-                 "${KDE_INSTALL_LIBEXECDIR}"))))
+                 "${KDE_INSTALL_FULL_LIBEXECDIR}/kauth"))))
           (replace 'check
             (lambda* (#:key tests? #:allow-other-keys)
               (when tests?

base-commit: 4514239971895fc7ad47c7752e30d98a0c44a154
-- 
2.41.0

Message #11 received at 70529 <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> envs.net>
To: Nathan Dehnel <ncdehnel <at> gmail.com>
Cc: 70529 <at> debbugs.gnu.org
Subject: Re: bug#70529: Several packages have dbus service files with broken
 file paths
Date: Thu, 25 Apr 2024 18:34:58 +0800

Nathan Dehnel <ncdehnel <at> gmail.com> writes:

> I was investigating powerdevil and snapper being broken and I
> discovered packages with incorrect file paths in the Exec line of
> their dbus services
>
> $ ls -d /gnu/store/**/share/dbus-1/services/** | grep -v
> profile/share/dbus-1 | while read line; do grep Exec $line 2>
> /dev/null | grep -v /gnu/store && echo $line >>/dev/stderr; done
> Exec=libexec/fontinst
> /gnu/store/6hz6j922gs1861h49id3ddjsg02cwkl1-plasma-workspace-5.27.7/share/dbus-1/services/org.kde.fontinst.service
> Exec=libexec/fontinst
> /gnu/store/nv8ccgy6jzfjkik5c5vy6id7dplnbb1y-plasma-workspace-5.27.7/share/dbus-1/services/org.kde.fontinst.service
> [...]

Hello, thank you the report, I have send a patch to fix this (tested
fine with ktexteditor and plasma-disks).

Message #16 received at 70529-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: iyzsong <at> envs.net
Cc: 70529-done <at> debbugs.gnu.org, 70566-done <at> debbugs.gnu.org,
 宋文武 <iyzsong <at> member.fsf.org>
Subject: Re: [bug#70566] [PATCH] gnu: kauth: Fix
 KAUTH_HELPER_INSTALL_ABSOLUTE_DIR.
Date: Sun, 28 Apr 2024 10:48:03 -0400

Hi,

iyzsong <at> envs.net writes:

> From: 宋文武 <iyzsong <at> member.fsf.org>
>
> KAuth helpers use KAUTH_HELPER_INSTALL_ABSOLUTE_DIR as the prefix for "Exec="
> in their dbus service files, which should really be an absolute directory.
>
> Fixes <https://issues.guix.gnu.org/70529>.
>
> * gnu/packages/kde-frameworks.scm (kauth)[arguments]<#:phases>: In
> fix-cmake-install-directories phase, replace KAUTH_HELPER_INSTALL_DIR
> with '${KDE_INSTALL_LIBEXECDIR}/kauth' and KAUTH_HELPER_INSTALL_ABSOLUTE_DIR
> with '${KDE_INSTALL_FULL_LIBEXECDIR}/kauth'.

Applied!

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.