GNU bug report logs - #70522
29.2.50; eglot-shutdown sends SIGKILL before LSP server can exit gracefully

Previous Next

Full log

Message #16 received at 70522-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Daniel Pettersson <daniel <at> dpettersson.net>
Cc: joaotavora <at> gmail.com, 70522-done <at> debbugs.gnu.org, azeng <at> janestreet.com,
 app-emacs-dev <at> janestreet.com
Subject: Re: bug#70522: 29.2.50; eglot-shutdown sends SIGKILL before LSP
 server can exit gracefully
Date: Sat, 27 Apr 2024 12:20:17 +0300

> From: Daniel Pettersson <daniel <at> dpettersson.net>
> Cc: Aaron Zeng <azeng <at> janestreet.com>,  70522 <at> debbugs.gnu.org,
>   app-emacs-dev <at> janestreet.com,  João Távora
>  <joaotavora <at> gmail.com>
> Date: Tue, 23 Apr 2024 18:58:06 +0200
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > Daniel, could you please look into this issue?
> 
> Change makes sense, the only "risk" is that jsonrpc users populate the
> *Warnings* buffer with an warning that they should take action upon and
> solve, so I think this is an no brainer.
> 
> Nice job!
> 
> I have done some adhock testing of eglot and dape. Was not able to
> produce the warning, which means that eglot and dape are using the
> function as intended (at least when interacting with the servers I
> tested with).
> 
> When the function is touched I would like to do some small additions to
> the documentation of the function, would be nice if the docstring
> mention the undocumented behavior and an small comment to make it a bit
> easier to follow along. 

Thanks, installed on master, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.