From unknown Fri Jun 20 05:33:05 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#70522 <70522@debbugs.gnu.org> To: bug#70522 <70522@debbugs.gnu.org> Subject: Status: 29.2.50; eglot-shutdown sends SIGKILL before LSP server can exit gracefully Reply-To: bug#70522 <70522@debbugs.gnu.org> Date: Fri, 20 Jun 2025 12:33:05 +0000 retitle 70522 29.2.50; eglot-shutdown sends SIGKILL before LSP server can e= xit gracefully reassign 70522 emacs submitter 70522 Aaron Zeng severity 70522 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 22 17:40:50 2024 Received: (at submit) by debbugs.gnu.org; 22 Apr 2024 21:40:51 +0000 Received: from localhost ([127.0.0.1]:48024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rz1P5-0004MJ-RV for submit@debbugs.gnu.org; Mon, 22 Apr 2024 17:40:50 -0400 Received: from lists.gnu.org ([2001:470:142::17]:42086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rz1P0-0004Kf-Q7 for submit@debbugs.gnu.org; Mon, 22 Apr 2024 17:40:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rz1Oa-0006en-Nl for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2024 17:40:17 -0400 Received: from mxout1.mail.janestreet.com ([38.105.200.78]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rz1OX-00033Q-Ht for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2024 17:40:15 -0400 Received: from mail-lj1-f200.google.com ([209.85.208.200]) by mxgoog2.mail.janestreet.com with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) (Exim 4.97.1) id 1rz1OV-00000006O3U-3ldb for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2024 17:40:11 -0400 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2d9ebfd9170so45023431fa.0 for ; Mon, 22 Apr 2024 14:40:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=google; t=1713822009; x=1714426809; darn=gnu.org; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=/+JCE2vW+pNPwoNjSbx/SM+UyFYrY+/W8UpFKdgS1xc=; b=L/2e0cXWHm1uMOprjmmPagjtmCrzIq+7UBlUtDkGLx2i5mN4phc2xpDOV5rvYWZU0m N5GOrAgNHOgimJUrbMLNl0zC6+i+0eM4boFcst0Ql1UemJWdaCSW0iitIU2hMofSqXck 7oEn94FRaDM2axg2sBBhpXmJUwtzwtu7xIAx0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1713822011; bh=/+JCE2vW+pNPwoNjSbx/SM+UyFYrY+/W8UpFKdgS1xc=; h=From:Date:Subject:To:Cc; b=27NCkj2My60DM71wcKqMoYCA1S78sQIZKHzLL9AJ2DgN98N2w3V92+JugsZpmjS7H WsCUOvbdJbRaUHgyvA5KJkkgxJ724olRSGQToYNSfXpIsO82Ho13azIr2oqrPA1hfA iGyquckSy2oMJjjoSspEJNlV2JcaU2gp2JsD4N3z5Rz4xbkiygrylXf7KJT7JU/DUB JSQUp0oE2A4bftsTATHSgE7vlbKYmfKwlZTgiq3TZIjaEjNHAaZTWKA0cVRdMK8zF1 dMVmScwpCVREWTy8OC+Rw2Px1u6tdo+6l6I3TXDHu8eiYE/4E299jct4MSuTgRKukh gdajiGaN1VQ4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713822009; x=1714426809; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=/+JCE2vW+pNPwoNjSbx/SM+UyFYrY+/W8UpFKdgS1xc=; b=PNLO8aRX9kLqo65JMInxlzfC+mNbqetCS1h/7T4C/YIh6fbt8cFaXUgLPJs0vjv83u +D5ZEr/JkNIeOFEYTCmsOaZ+T0dA0P/oxSFEqYs2D0skmXDDRvBQFbGSRNsDHUnDgf2x Mye06mVyLtrSsB/OFQlswkvVRbTsrtMaCcPRljQgqRmUulQ9gZQRlmhehzyZ3INTIzkk 2M4AJttyrHan61J/VXytQtJte0B5MlCX7R86k6sTzDlXsFiTElEecdTI5LHgjTrC+vYm vRWo2JtwsnoWoWwghtnGY+ePURlD1t+qSG+dFWkX15uE9ocmi9vig5ciQ3gR/4YNGPHP KAtA== X-Gm-Message-State: AOJu0YzBx1pRAPsLodgHJdsneCPLGDKxh3V/3MSKoyInVKApXCVaXj5O iGKlFcXuDtcJS3LdsFs2EEGEn6XrktuVZRkqNXKoA/oahWlRK2rM6HYvHfF+ZeZq9co17ZZg5se eq7uvLDGs2uMLCLhbr9F28EQOonSCGv7XbixMaxby4SQ+1L3O8kxzziNf2We5ARTIiUfgRGUgZa 7LLqDqt7ChtcAnunRixGrSrkiuz8pvJ9rt61E= X-Received: by 2002:a05:651c:446:b0:2d8:36f9:67af with SMTP id g6-20020a05651c044600b002d836f967afmr9481359ljg.44.1713822009524; Mon, 22 Apr 2024 14:40:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHoRy1XkRBUD+msDdsW4OMmN5OkKzHmLXfmwEzyEJPiU7z+OaxgqMeUn4Hc3LNWT2VLgifb64t0wKL2tgQOCkU= X-Received: by 2002:a05:651c:446:b0:2d8:36f9:67af with SMTP id g6-20020a05651c044600b002d836f967afmr9481355ljg.44.1713822009168; Mon, 22 Apr 2024 14:40:09 -0700 (PDT) MIME-Version: 1.0 From: Aaron Zeng Date: Mon, 22 Apr 2024 17:39:32 -0400 Message-ID: Subject: 29.2.50; eglot-shutdown sends SIGKILL before LSP server can exit gracefully To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=38.105.200.78; envelope-from=azeng@janestreet.com; helo=mxout1.mail.janestreet.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: app-emacs-dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) 1. emacs -Q 2. M-x eglot in some file (I tested with OCaml-LSP and another language server, the latter is internal to my site) 3. M-x eglot-shutdown This messages: [jsonrpc] Server exited with status 9 Which is a little confusing. One would expect the language server to exit with status 0, and not end up with "killed" in the events buffer, if the server exited successfully upon user request. I installed the following patch locally at my site, and it seems to fix the issue (now the server exits with status 0). I think it also better matches the docstring of `jsonrpc-shutdown'. diff --git a/jsonrpc.el b/jsonrpc.el --- a/jsonrpc.el +++ b/jsonrpc.el @@ -598,8 +598,8 @@ With optional CLEANUP, kill any associat while (not (process-get proc 'jsonrpc-sentinel-cleanup-started)) unless (zerop i) do (jsonrpc--warn "Sentinel for %s still hasn't run, deleting it!" proc) + (delete-process proc) do - (delete-process proc) (accept-process-output nil 0.1)) (when cleanup (kill-buffer (process-buffer (jsonrpc--process conn))) In GNU Emacs 29.2.50 (build 2, x86_64-pc-linux-gnu, X toolkit, cairo version 1.15.12, Xaw scroll bars) of 2024-04-15 built on psr-qws-hydra382 Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Rocky Linux 8.9 (Green Obsidian) Configured using: 'configure --config-cache --with-x-toolkit=lucid --without-gpm --without-gconf --without-selinux --without-imagemagick --with-modules --with-gif=no --with-cairo --with-rsvg --without-compress-install --prefix=/j/office/app/emacs/store/20240415-155142' Configured features: CAIRO DBUS FREETYPE GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XINPUT2 XPM LUCID ZLIB Important settings: value of $LANG: en_US.utf8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo x-toolkit xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 38416 8673) (symbols 48 5185 0) (strings 32 14033 2273) (string-bytes 1 396649) (vectors 16 10266) (vector-slots 8 156275 9779) (floats 8 40 13) (intervals 56 253 0) (buffers 976 10)) From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 23 01:52:33 2024 Received: (at 70522) by debbugs.gnu.org; 23 Apr 2024 05:52:35 +0000 Received: from localhost ([127.0.0.1]:50054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rz94s-0001mx-Uk for submit@debbugs.gnu.org; Tue, 23 Apr 2024 01:52:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38204) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rz94c-0001jq-MV for 70522@debbugs.gnu.org; Tue, 23 Apr 2024 01:52:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rz94F-0004Np-Sm; Tue, 23 Apr 2024 01:51:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=k6NaRY3oSimBZmssYhjJl6jpr0awuE/D36vlgOp1EMA=; b=FORgrmXw0g+RtvcSGrHG o8xG62DXGVH4KkW6gU7m/p6g51KcqIwrOOSP1yS3dUiS+tjXslCP6va/1NVrE0cygCewFuJsjXpwV laJ/tWtekZh1Y6m3LbaxCleZxPnv15D1GK4Z6XK+zBxyKRQxB8MsflVbswzOZ7jGtDirhjxCpur1j tYAzqxsV6ZazbdMZcH8AycimF9nWkE0ZHKYwrfnHaeaBsZg59Eqc9Ystv/NM/SfxV7zojw7LCgjH3 VtuOD9WUJxkYOMTuDnWYZlAgpovb5CEh6Vc7T2vwHbEsDxiwN00x7NbQuKOCNDDDAJQLRlTqckrsW DhhWBAg0F//68w==; Date: Tue, 23 Apr 2024 08:51:46 +0300 Message-Id: <86wmoo4oel.fsf@gnu.org> From: Eli Zaretskii To: Aaron Zeng , Daniel Pettersson In-Reply-To: (message from Aaron Zeng on Mon, 22 Apr 2024 17:39:32 -0400) Subject: Re: bug#70522: 29.2.50; eglot-shutdown sends SIGKILL before LSP server can exit gracefully References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70522 Cc: 70522@debbugs.gnu.org, app-emacs-dev@janestreet.com, =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: app-emacs-dev > From: Aaron Zeng > Date: Mon, 22 Apr 2024 17:39:32 -0400 > > 1. emacs -Q > 2. M-x eglot in some file (I tested with OCaml-LSP and another language > server, the latter is internal to my site) > 3. M-x eglot-shutdown > > This messages: > > [jsonrpc] Server exited with status 9 > > Which is a little confusing. One would expect the language server to > exit with status 0, and not end up with "killed" in the events buffer, > if the server exited successfully upon user request. > > I installed the following patch locally at my site, and it seems to fix > the issue (now the server exits with status 0). I think it also better > matches the docstring of `jsonrpc-shutdown'. > > diff --git a/jsonrpc.el b/jsonrpc.el > --- a/jsonrpc.el > +++ b/jsonrpc.el > @@ -598,8 +598,8 @@ With optional CLEANUP, kill any associat > while (not (process-get proc 'jsonrpc-sentinel-cleanup-started)) > unless (zerop i) do > (jsonrpc--warn "Sentinel for %s still hasn't run, deleting it!" proc) > + (delete-process proc) > do > - (delete-process proc) > (accept-process-output nil 0.1)) > (when cleanup > (kill-buffer (process-buffer (jsonrpc--process conn))) Thanks. Daniel, could you please look into this issue? From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 23 12:58:42 2024 Received: (at 70522) by debbugs.gnu.org; 23 Apr 2024 16:58:42 +0000 Received: from localhost ([127.0.0.1]:53282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzJTb-0006UU-UT for submit@debbugs.gnu.org; Tue, 23 Apr 2024 12:58:42 -0400 Received: from mail-lj1-f178.google.com ([209.85.208.178]:57694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzJTU-0006SP-68 for 70522@debbugs.gnu.org; Tue, 23 Apr 2024 12:58:37 -0400 Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2dd7e56009cso31355051fa.3 for <70522@debbugs.gnu.org>; Tue, 23 Apr 2024 09:58:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713891489; x=1714496289; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sisEilpjxAEL7T3lSioCQ4rmlBZTj3zJqypufIxtYj8=; b=GKp50P3c5AteryBWkHMRyXw5bHuyn+ulXKOGacX8T6igx7ZHSAnX6C//gKelUcxuxg y/DUCDNYvWHi+3JDvIzGs69QvuMnmHuwcjSKuT+R+X/5PhCAINJJhCdCmy+eMmcfM3Q+ XEnDL4jbvKHgMYdUP6zRvQTwkeyUGAKSpfBn/tSvBSdkHh/ZipqVShE7hwR1jCyPYLgJ 5veWSHM/js7kDthmlMbmL50/rj/2V98PgLClUvcvadZGYMUmCO0diRVSenkJIemq0WY/ N34PvQcwdXXAZjcFAzqvzd33idI1dSK7EnccyPdwb3NuBSM/Bj7J2SvHsdqAqenneM44 dAyQ== X-Forwarded-Encrypted: i=1; AJvYcCWMmjHkOKBP/5ByApvimGZfgtZ/qfK6kcslko6U0cSfXbbvuonvLLYIioWF5xunbDl3MMJzKE4+dh5P1wn1V4EEoaEBxxk= X-Gm-Message-State: AOJu0YwVecmEEs0PseGvv4A0WcI6/Af307BsGbF0g8DKcWmaxZWyoY+k 2Y7cmh8gyLJfCTesXFadxHopIuVjH2ne40DhO0JG2cocGM2pdkhR X-Google-Smtp-Source: AGHT+IEkw6daTS8ZZZ8XPh+5UtEwcQhOzIf60tUUeE9ViKDmuRQWyMkmYZuJfCySjRDiql1Qgq8o6g== X-Received: by 2002:a2e:9316:0:b0:2dc:d26e:5e8 with SMTP id e22-20020a2e9316000000b002dcd26e05e8mr9696328ljh.34.1713891488856; Tue, 23 Apr 2024 09:58:08 -0700 (PDT) Received: from Daniels-Air (c-72cde455.027-357-6d6c6d4.bbcust.telenor.se. [85.228.205.114]) by smtp.gmail.com with ESMTPSA id t7-20020a2e9c47000000b002d68abf446bsm1756194ljj.139.2024.04.23.09.58.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 09:58:08 -0700 (PDT) From: Daniel Pettersson To: Eli Zaretskii Subject: Re: bug#70522: 29.2.50; eglot-shutdown sends SIGKILL before LSP server can exit gracefully In-Reply-To: <86wmoo4oel.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 23 Apr 2024 08:51:46 +0300") References: <86wmoo4oel.fsf@gnu.org> Date: Tue, 23 Apr 2024 18:58:06 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 70522 Cc: 70522@debbugs.gnu.org, app-emacs-dev@janestreet.com, Aaron Zeng , =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --=-=-= Content-Type: text/plain Eli Zaretskii writes: > Daniel, could you please look into this issue? Change makes sense, the only "risk" is that jsonrpc users populate the *Warnings* buffer with an warning that they should take action upon and solve, so I think this is an no brainer. Nice job! I have done some adhock testing of eglot and dape. Was not able to produce the warning, which means that eglot and dape are using the function as intended (at least when interacting with the servers I tested with). When the function is touched I would like to do some small additions to the documentation of the function, would be nice if the docstring mention the undocumented behavior and an small comment to make it a bit easier to follow along. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=doc_changes.diff Content-Description: documentation changes diff --git a/lisp/jsonrpc.el b/lisp/jsonrpc.el index 5037d8c5b2b..111e58cefe2 100644 --- a/lisp/jsonrpc.el +++ b/lisp/jsonrpc.el @@ -591,15 +591,18 @@ jsonrpc-running-p (cl-defmethod jsonrpc-shutdown ((conn jsonrpc-process-connection) &optional cleanup) "Wait for JSONRPC connection CONN to shutdown. -With optional CLEANUP, kill any associated buffers." +With optional CLEANUP, kill any associated buffers. +If CONN is not shutdown within an reasonable amount of time, warn +and delete process." (unwind-protect (cl-loop with proc = (jsonrpc--process conn) for i from 0 while (not (process-get proc 'jsonrpc-sentinel-cleanup-started)) unless (zerop i) do (jsonrpc--warn "Sentinel for %s still hasn't run, deleting it!" proc) - do (delete-process proc) + do + ;; Let sentinel have a chance to run (accept-process-output nil 0.1)) (when cleanup (kill-buffer (process-buffer (jsonrpc--process conn))) --=-=-= Content-Type: text/plain / Daniel --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 27 05:21:01 2024 Received: (at 70522-done) by debbugs.gnu.org; 27 Apr 2024 09:21:02 +0000 Received: from localhost ([127.0.0.1]:38915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0eEr-0007Mm-Ko for submit@debbugs.gnu.org; Sat, 27 Apr 2024 05:21:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0eEi-0007Km-5r for 70522-done@debbugs.gnu.org; Sat, 27 Apr 2024 05:20:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s0eEI-0002iP-Mz; Sat, 27 Apr 2024 05:20:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=kYFICaHdPn1b/s0/MxutYyQLeZH6+gdZVgUecyJzRY4=; b=RRX/ur1RlCt5/EJgdU5f fVVcpil0a8g6I0Bbk5Vl8FVERto1QC9XkkfgPPg6cAzxBmBPhn23OGAW8l8ATChYstDWFqJVn0wrt i9nC9M3/gUQqqIN4EFPeoy49WeTUZ6SIgFS2y3rqLZdPMTbQWsOfwNVU/FHer5EeYkj5gsLzV1M0Y rDsDkwwiW9AMXq3R+GQk1twVmHMSXl+uJQvJO6NioYXq8tmp5e8UE2avOHJ3eIRXUMW64Sivz0o+u tWHOsgJZegvo02/ULOxuaM94QYmuJqt1rlmUCwzp8FmBPujZ8n7niivSzD52+OsNdnIrl41sZoaGL sI6tD732Ioa4AA==; Date: Sat, 27 Apr 2024 12:20:17 +0300 Message-Id: <86frv7w4a6.fsf@gnu.org> From: Eli Zaretskii To: Daniel Pettersson In-Reply-To: (message from Daniel Pettersson on Tue, 23 Apr 2024 18:58:06 +0200) Subject: Re: bug#70522: 29.2.50; eglot-shutdown sends SIGKILL before LSP server can exit gracefully References: <86wmoo4oel.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70522-done Cc: joaotavora@gmail.com, 70522-done@debbugs.gnu.org, azeng@janestreet.com, app-emacs-dev@janestreet.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Daniel Pettersson > Cc: Aaron Zeng , 70522@debbugs.gnu.org, > app-emacs-dev@janestreet.com, João Távora > > Date: Tue, 23 Apr 2024 18:58:06 +0200 > > Eli Zaretskii writes: > > > Daniel, could you please look into this issue? > > Change makes sense, the only "risk" is that jsonrpc users populate the > *Warnings* buffer with an warning that they should take action upon and > solve, so I think this is an no brainer. > > Nice job! > > I have done some adhock testing of eglot and dape. Was not able to > produce the warning, which means that eglot and dape are using the > function as intended (at least when interacting with the servers I > tested with). > > When the function is touched I would like to do some small additions to > the documentation of the function, would be nice if the docstring > mention the undocumented behavior and an small comment to make it a bit > easier to follow along. Thanks, installed on master, and closing the bug. From unknown Fri Jun 20 05:33:05 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 25 May 2024 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator