GNU bug report logs - #70516
[PATCH] gnu: Add libgpod.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#70516: closed ([PATCH] gnu: Add libgpod.)
Date: Fri, 31 May 2024 11:44:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 31 May 2024 13:43:17 +0200
with message-id <87h6eetdey.fsf <at> gnu.org>
and subject line Re: [bug#70516] [PATCH v1 2/2] gnu: clementine: Build with libgpod.
has caused the debbugs.gnu.org bug report #70516,
regarding [PATCH] gnu: Add libgpod.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
70516: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70516
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Sergey Trofimov <sarg <at> sarg.org.ru>
To: guix-patches <at> gnu.org
Cc: Sergey Trofimov <sarg <at> sarg.org.ru>
Subject: [PATCH] gnu: Add libgpod.
Date: Mon, 22 Apr 2024 20:24:43 +0200

* gnu/packages/music.scm (libgpod): New variable.
(clementine)[inputs]: Make use of it.
---
 gnu/packages/music.scm | 55 +++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 54 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index df3ff38b4a..94f4da95ab 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -182,6 +182,7 @@ (define-module (gnu packages music)
   #:use-module (gnu packages readline)
   #:use-module (gnu packages rsync)
   #:use-module (gnu packages ruby)
+  #:use-module (gnu packages scsi)
   #:use-module (gnu packages sdl)
   #:use-module (gnu packages serialization)
   #:use-module (gnu packages sphinx)
@@ -430,6 +431,58 @@ (define-public aria-maestosa
 score, keyboard, guitar, drum and controller views.")
     (license license:gpl3+)))
 
+(define-public libgpod
+  (package
+    (name "libgpod")
+    (version "0.8.3")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://git.code.sf.net/p/gtkpod/libgpod")
+             (commit "8dc5015ae036b219c4c9579a156886aa3a722aa5")))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1yzngb7h1mibz4x56w9fh02vx8xi4wyq4fjc3ad0jayv3hxjjkqv"))))
+    (arguments
+     (list
+      #:configure-flags
+      #~(list
+         "--without-hal"
+         "--enable-udev"
+         (string-append "--with-udev-dir=" #$output "/lib/udev")
+         (string-append "--prefix=" #$output))
+
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'patch-autotools-version-requirement
+            (lambda _
+              (setenv "ACLOCAL_FLAGS"
+                      (string-join
+                       (map (lambda (s) (string-append "-I " s))
+                            (string-split (getenv "ACLOCAL_PATH") #\:))
+                       " "))
+              (substitute* "configure.ac"
+                (("libplist >= 1\\.0") "libplist-2.0 >= 2.2")
+                (("-Werror") ""))
+              ;; patch for plist-2.0
+              (substitute* "tools/ipod-lockdown.c"
+                (("plist_dict_insert_item") "plist_dict_set_item"))
+              ;; it expects version-suffixed binary
+              (substitute* "gnome-autogen.sh"
+                (("automake-1\\.13") "automake")))))))
+
+    (build-system gnu-build-system)
+    (native-inputs
+     (list automake libtool autoconf intltool pkg-config `(,glib "bin") gtk-doc))
+    (propagated-inputs (list libimobiledevice))
+    (inputs (list libxml2 sg3-utils sqlite taglib libplist gdk-pixbuf))
+    (home-page "https://sourceforge.net/projects/gtkpod")
+    (synopsis "Library to access iPod contents")
+    (description "Library to access iPod contents.  Enables iPod support in
+@code{Clementine}.")
+    (license license:lgpl2.1+)))
+
 (define-public clementine
   (package
     (name "clementine")
@@ -511,7 +564,7 @@ (define-public clementine
            gst-libav
            libcdio
            libmygpo-qt
-           ;; TODO: Package libgpod.
+           libgpod
            libmtp
            libxml2
            protobuf

base-commit: 02df0a8a7d4712398d90f8635d4004e76bbc9f51
prerequisite-patch-id: f9cc903b8048c8c6fde576fbf38ab110263020e3
prerequisite-patch-id: aba438a3c32ef44149bbc749c1e0b89d00006b3e
prerequisite-patch-id: 1bcd992c56c1b094479b842032fc9731315cbf83
prerequisite-patch-id: 500c43ab90039ca164d6b0864adb110bd9bd9afe
prerequisite-patch-id: f7629448294f448f1914d9bc50a4136a05b77c03
-- 
2.41.0

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Sergey Trofimov <sarg <at> sarg.org.ru>
Cc: 70516-done <at> debbugs.gnu.org
Subject: Re: [bug#70516] [PATCH v1 2/2] gnu: clementine: Build with libgpod.
Date: Fri, 31 May 2024 13:43:17 +0200

Sergey Trofimov <sarg <at> sarg.org.ru> skribis:

> * gnu/packages/music.scm (clementine): Add libgpod to dependencies.

Applied, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.