GNU bug report logs - #70503
[PATCH] Add function "TeX-master-output-file"

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 70503 in the body.
You can then email your comments to 70503 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Paul Nelson <ultrono <at> gmail.com>
To: bug-auctex <at> gnu.org
Subject: [PATCH] Add function "TeX-master-output-file"
Date: Sun, 21 Apr 2024 22:57:37 +0200

[Message part 1 (text/plain, inline)]

I think that a function as in the attached patch, which wraps the
function TeX--master-output-dir introduced along with TeX-output-dir,
would be a useful addition to the public-facing API.  For example, I
would use it in both of the packages that I recently shared on the
devel list (these would otherwise refer to the internal function
TeX--master-output-dir).  Any other suggestions are welcome, of
course.

Thanks, best,

Paul

[0001-Add-function-TeX-master-output-file.patch (application/octet-stream, attachment)]

Message #8 received at 70503 <at> debbugs.gnu.org (full text, mbox):

From: Ikumi Keita <ikumi <at> ikumi.que.jp>
To: Paul Nelson <ultrono <at> gmail.com>
Cc: Arash Esbati <arash <at> gnu.org>, 70503 <at> debbugs.gnu.org,
 Tassilo Horn <tsdh <at> gnu.org>
Subject: Re: bug#70503: [PATCH] Add function "TeX-master-output-file"
Date: Fri, 26 Apr 2024 23:13:17 +0900

Hi Paul,

>>>>> Paul Nelson <ultrono <at> gmail.com> writes:
> I think that a function as in the attached patch, which wraps the
> function TeX--master-output-dir introduced along with TeX-output-dir,
> would be a useful addition to the public-facing API.  For example, I
> would use it in both of the packages that I recently shared on the
> devel list (these would otherwise refer to the internal function
> TeX--master-output-dir).  Any other suggestions are welcome, of
> course.

The proposed function seems reasonable enough and I think AUCTeX can
accept it.

To Tassilo & Arash: I'm not sure the new workflow after the inclusion of
the main branch. Should I commit new changeset to main branch instead of
master branch now? And should I add an entry for NEWS.org, in addition
to commit message?

Regards,
Ikumi Keita
#StandWithUkraine #StopWarInUkraine
#Gaza #StopMassiveKilling #CeasefireNOW

Message #11 received at 70503 <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Ikumi Keita <ikumi <at> ikumi.que.jp>
Cc: Tassilo Horn <tsdh <at> gnu.org>, 70503 <at> debbugs.gnu.org,
 Paul Nelson <ultrono <at> gmail.com>
Subject: Re: bug#70503: [PATCH] Add function "TeX-master-output-file"
Date: Fri, 26 Apr 2024 17:24:13 +0200

Hi Keita,

Ikumi Keita <ikumi <at> ikumi.que.jp> writes:

> The proposed function seems reasonable enough and I think AUCTeX can
> accept it.
>
> To Tassilo & Arash: I'm not sure the new workflow after the inclusion of
> the main branch. Should I commit new changeset to main branch instead of
> master branch now? And should I add an entry for NEWS.org, in addition
> to commit message?

Thanks for looking at this.  The new workflow (for the time being) is
actually the old one: Push all changes to the master branch, and we can
merge that onto main when needed.  The only minor change is probably to
add noteworthy changes to NEWS.org and not to changes.texi.

And while we're at: I think we should review the patch in bug#70525 and
once installed, we can merge and start a new ELPA release, i.e., merge
master onto main, wait if somebody complains, and then bump the Version
number in auctex.el, voilà, in theory ;-)

@Paul: Do you have any other patches pending?  I think you're also
waiting for 14.0.5 in order to start the ELPA release of your packages,
right?

Best, Arash

Message #14 received at 70503 <at> debbugs.gnu.org (full text, mbox):

From: Paul Nelson <ultrono <at> gmail.com>
To: Arash Esbati <arash <at> gnu.org>
Cc: Ikumi Keita <ikumi <at> ikumi.que.jp>, 70503 <at> debbugs.gnu.org,
 Tassilo Horn <tsdh <at> gnu.org>
Subject: Re: bug#70503: [PATCH] Add function "TeX-master-output-file"
Date: Fri, 26 Apr 2024 17:30:43 +0200

> @Paul: Do you have any other patches pending?  I think you're also
> waiting for 14.0.5 in order to start the ELPA release of your packages,
> right?
>
> Best, Arash

Yes and yes.  I have three further minor patches, one of which builds
on #70525, the other two of which are very minor.  Could easily send
these tomorrow, for instance.

Thanks, best,

Paul

Message #17 received at 70503 <at> debbugs.gnu.org (full text, mbox):

From: Ikumi Keita <ikumi <at> ikumi.que.jp>
To: Paul Nelson <ultrono <at> gmail.com>, Arash Esbati <arash <at> gnu.org>
Cc: 70503 <at> debbugs.gnu.org, Tassilo Horn <tsdh <at> gnu.org>
Subject: Re: bug#70503: [PATCH] Add function "TeX-master-output-file"
Date: Sat, 27 Apr 2024 01:28:57 +0900

Hi Arash,

>>>>> Arash Esbati <arash <at> gnu.org> writes:
> Thanks for looking at this.  The new workflow (for the time being) is
> actually the old one: Push all changes to the master branch, and we can
> merge that onto main when needed.  The only minor change is probably to
> add noteworthy changes to NEWS.org and not to changes.texi.

Thanks, I committed to the master branch and pushed. I'll close this
bug.

Regards,
Ikumi Keita
#StandWithUkraine #StopWarInUkraine
#Gaza #StopMassiveKilling #CeasefireNOW

Message #22 received at 70503 <at> debbugs.gnu.org (full text, mbox):

From: Tassilo Horn <tsdh <at> gnu.org>
To: Ikumi Keita <ikumi <at> ikumi.que.jp>
Cc: Arash Esbati <arash <at> gnu.org>, 70503 <at> debbugs.gnu.org,
 Paul Nelson <ultrono <at> gmail.com>
Subject: Re: bug#70503: [PATCH] Add function "TeX-master-output-file"
Date: Fri, 26 Apr 2024 18:57:23 +0200

Ikumi Keita <ikumi <at> ikumi.que.jp> writes:

>> Thanks for looking at this.  The new workflow (for the time being) is
>> actually the old one: Push all changes to the master branch, and we can
>> merge that onto main when needed.  The only minor change is probably to
>> add noteworthy changes to NEWS.org and not to changes.texi.
>
> Thanks, I committed to the master branch and pushed. I'll close this
> bug.

Merged into main, so a new ELPA-devel package should appear within 6
hours including Paul's (and Vangelis') recent changes.  Thanks a lot!

  Tassilo

Message #25 received at 70503 <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Ikumi Keita <ikumi <at> ikumi.que.jp>
Cc: Tassilo Horn <tsdh <at> gnu.org>, 70503 <at> debbugs.gnu.org,
 Paul Nelson <ultrono <at> gmail.com>
Subject: Re: bug#70503: [PATCH] Add function "TeX-master-output-file"
Date: Sat, 27 Apr 2024 12:09:32 +0200

Ikumi Keita <ikumi <at> ikumi.que.jp> writes:

> Thanks, I committed to the master branch and pushed. I'll close this
> bug.

Thanks Keita.  Can you in future also add/amend the bug number to the
commit message, please?  It makes it easier to search for a bug inside
Git.

TIA.  Best, Arash

Message #28 received at 70503 <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Paul Nelson <ultrono <at> gmail.com>
Cc: Ikumi Keita <ikumi <at> ikumi.que.jp>, 70503 <at> debbugs.gnu.org,
 Tassilo Horn <tsdh <at> gnu.org>
Subject: Re: bug#70503: [PATCH] Add function "TeX-master-output-file"
Date: Sat, 27 Apr 2024 12:11:23 +0200

Paul Nelson <ultrono <at> gmail.com> writes:

> Yes and yes.  I have three further minor patches, one of which builds
> on #70525, the other two of which are very minor.  Could easily send
> these tomorrow, for instance.

Great, bring 'em on :-)

Message #31 received at 70503 <at> debbugs.gnu.org (full text, mbox):

From: Ikumi Keita <ikumi <at> ikumi.que.jp>
To: Arash Esbati <arash <at> gnu.org>
Cc: Tassilo Horn <tsdh <at> gnu.org>, 70503 <at> debbugs.gnu.org,
 Paul Nelson <ultrono <at> gmail.com>
Subject: Re: bug#70503: [PATCH] Add function "TeX-master-output-file"
Date: Sat, 27 Apr 2024 19:22:39 +0900

>>>>> Arash Esbati <arash <at> gnu.org> writes:
> Thanks Keita.  Can you in future also add/amend the bug number to the
> commit message, please?  It makes it easier to search for a bug inside
> Git.

Oh, sorry. I forgot to fix up the commit messages to include the bug
number for recent commits. :-(

Regards,
Ikumi Keita
#StandWithUkraine #StopWarInUkraine
#Gaza #StopMassiveKilling #CeasefireNOW

Message #34 received at 70503 <at> debbugs.gnu.org (full text, mbox):

From: Paul Nelson <ultrono <at> gmail.com>
To: Arash Esbati <arash <at> gnu.org>
Cc: Ikumi Keita <ikumi <at> ikumi.que.jp>, 70503 <at> debbugs.gnu.org,
 Tassilo Horn <tsdh <at> gnu.org>
Subject: Re: bug#70503: [PATCH] Add function "TeX-master-output-file"
Date: Sat, 27 Apr 2024 15:54:56 +0200

> Great, bring 'em on :-)

I sent a couple just now.  I have a couple more ready to go, but they
would likely produce  conflicts unless the submitted patches are
accepted exactly as is, so I'll wait.

Thanks, best,

Paul

Message #37 received at 70503 <at> debbugs.gnu.org (full text, mbox):

From: Paul Nelson <ultrono <at> gmail.com>
To: Arash Esbati <arash <at> gnu.org>
Cc: Ikumi Keita <ikumi <at> ikumi.que.jp>, 70503 <at> debbugs.gnu.org,
 Tassilo Horn <tsdh <at> gnu.org>
Subject: Re: bug#70503: [PATCH] Add function "TeX-master-output-file"
Date: Tue, 14 May 2024 05:18:34 +0200

[Message part 1 (text/plain, inline)]

>
>
> @Paul: Do you have any other patches pending?  I think you're also
> waiting for 14.0.5 in order to start the ELPA release of your packages,
> right?
>
> Best, Arash
>

It looks like I've gone a solid week now without submitting any patches,
which suggests that things are now a "go" on my end for bumping the version.

Thanks, best,

Paul

[Message part 2 (text/html, inline)]

Message #40 received at 70503 <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Paul Nelson <ultrono <at> gmail.com>
Cc: Ikumi Keita <ikumi <at> ikumi.que.jp>, 70503 <at> debbugs.gnu.org,
 Tassilo Horn <tsdh <at> gnu.org>
Subject: Re: bug#70503: [PATCH] Add function "TeX-master-output-file"
Date: Tue, 14 May 2024 07:21:16 +0200

Paul Nelson <ultrono <at> gmail.com> writes:

> It looks like I've gone a solid week now without submitting any
> patches, which suggests that things are now a "go" on my end for
> bumping the version.

Ok, thanks.  I think we'll wait until the patch for bug#70811 is
installed and then we can start the release process.  Unless I'm missing
something?

Best, Arash

Message #43 received at 70503 <at> debbugs.gnu.org (full text, mbox):

From: Ikumi Keita <ikumi <at> ikumi.que.jp>
To: Arash Esbati <arash <at> gnu.org>
Cc: Tassilo Horn <tsdh <at> gnu.org>, 70503 <at> debbugs.gnu.org,
 Paul Nelson <ultrono <at> gmail.com>
Subject: Re: bug#70503: [PATCH] Add function "TeX-master-output-file"
Date: Tue, 14 May 2024 20:39:19 +0900

>>>>> Arash Esbati <arash <at> gnu.org> writes:
> Ok, thanks.  I think we'll wait until the patch for bug#70811 is
> installed and then we can start the release process.  Unless I'm missing
> something?

Now bug#70811 is resolved. I think we can go now.

Bye,
Ikumi Keita
#StandWithUkraine #StopWarInUkraine
#Gaza #StopMassiveKilling #CeasefireNOW

Message #46 received at 70503 <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Ikumi Keita <ikumi <at> ikumi.que.jp>
Cc: Paul Nelson <ultrono <at> gmail.com>, 70503 <at> debbugs.gnu.org,
 Tassilo Horn <tsdh <at> gnu.org>
Subject: Re: bug#70503: [PATCH] Add function "TeX-master-output-file"
Date: Tue, 14 May 2024 14:53:17 +0200

Ikumi Keita <ikumi <at> ikumi.que.jp> writes:

> Now bug#70811 is resolved. I think we can go now.

Thanks, I updated NEWS.org and pushed.  Then I did:

• $ git switch main
• $ git merge origin/master and get the following:

CONFLICT (modify/delete): Makefile.in deleted in HEAD and modified in
origin/master.  Version origin/master of Makefile.in left in tree.
Automatic merge failed; fix conflicts and then commit the result.

@Tassilo: Please help ;-)

Best, Arash

Message #49 received at 70503 <at> debbugs.gnu.org (full text, mbox):

From: Tassilo Horn <tsdh <at> gnu.org>
To: Arash Esbati <arash <at> gnu.org>
Cc: Ikumi Keita <ikumi <at> ikumi.que.jp>, 70503 <at> debbugs.gnu.org,
 Paul Nelson <ultrono <at> gmail.com>
Subject: Re: bug#70503: [PATCH] Add function "TeX-master-output-file"
Date: Wed, 15 May 2024 10:04:34 +0200

Arash Esbati <arash <at> gnu.org> writes:

> Thanks, I updated NEWS.org and pushed.  Then I did:
>
> • $ git switch main
> • $ git merge origin/master and get the following:
>
> CONFLICT (modify/delete): Makefile.in deleted in HEAD and modified in
> origin/master.  Version origin/master of Makefile.in left in tree.
> Automatic merge failed; fix conflicts and then commit the result.
>
> @Tassilo: Please help ;-)

Well, you added style/amsrefs.el to Makefile.in in 61f8825c on master
but I've deleted Makefile.in on main since there we use GNUmakefile.
And in that, we simply use wildcards instead of enumerating all style
files.  So I confirmed my deletion with "git rm Makefile.in" in order to
resolve the conflict and commit and push the merge.

So now a new ELPA-devel release should be triggered.  Feel free to
change the Version yourself in order to trigger a new ELPA release.

Bye,
Tassilo

Message #52 received at 70503 <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Tassilo Horn <tsdh <at> gnu.org>
Cc: Ikumi Keita <ikumi <at> ikumi.que.jp>, 70503 <at> debbugs.gnu.org,
 Paul Nelson <ultrono <at> gmail.com>
Subject: Re: bug#70503: [PATCH] Add function "TeX-master-output-file"
Date: Wed, 15 May 2024 12:30:37 +0200

Tassilo Horn <tsdh <at> gnu.org> writes:

> Well, you added style/amsrefs.el to Makefile.in in 61f8825c on master
> but I've deleted Makefile.in on main since there we use GNUmakefile.
> And in that, we simply use wildcards instead of enumerating all style
> files.

Thanks, this part was clear to me.

> So I confirmed my deletion with "git rm Makefile.in" in order to
> resolve the conflict and commit and push the merge.

Ah, this was not clear to me.  So on the main branch, I do "git rm
Makefile.in" and that resolves the conflict, right?.  I will try that
next time I add something to Makefile.in on master, thanks.

> So now a new ELPA-devel release should be triggered.  Feel free to
> change the Version yourself in order to trigger a new ELPA release.

My plan was to do that during this weekend once everything on ELPA-devel
works.

Best, Arash

Message #55 received at 70503 <at> debbugs.gnu.org (full text, mbox):

From: Tassilo Horn <tsdh <at> gnu.org>
To: Arash Esbati <arash <at> gnu.org>
Cc: Ikumi Keita <ikumi <at> ikumi.que.jp>, 70503 <at> debbugs.gnu.org,
 Paul Nelson <ultrono <at> gmail.com>
Subject: Re: bug#70503: [PATCH] Add function "TeX-master-output-file"
Date: Wed, 15 May 2024 16:13:08 +0200

Arash Esbati <arash <at> gnu.org> writes:

>> So I confirmed my deletion with "git rm Makefile.in" in order to
>> resolve the conflict and commit and push the merge.
>
> Ah, this was not clear to me.  So on the main branch, I do "git rm
> Makefile.in" and that resolves the conflict, right?.  I will try that
> next time I add something to Makefile.in on master, thanks.

I think it won't bother you with this edit-delete conflict anymore but
we'll see.

>> So now a new ELPA-devel release should be triggered.  Feel free to
>> change the Version yourself in order to trigger a new ELPA release.
>
> My plan was to do that during this weekend once everything on ELPA-devel
> works.

Alright then.

Bye,
Tassilo

Message #58 received at 70503 <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Tassilo Horn <tsdh <at> gnu.org>
Cc: Ikumi Keita <ikumi <at> ikumi.que.jp>, 70503 <at> debbugs.gnu.org,
 Paul Nelson <ultrono <at> gmail.com>
Subject: Re: bug#70503: [PATCH] Add function "TeX-master-output-file"
Date: Sun, 19 May 2024 09:54:13 +0200

Tassilo Horn <tsdh <at> gnu.org> writes:

> Arash Esbati <arash <at> gnu.org> writes:
>
>> My plan was to do that during this weekend once everything on ELPA-devel
>> works.
>
> Alright then.

I just pushed a change bumping the version number.  A new ELPA release
should appear soon (hopefully).

Best, Arash

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.