GNU bug report logs - #70494
[PATCH 00/23] Groundwork for the Guile guix-daemon

Previous Next

Full log

Message #128 received at 70494 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: Josselin Poiret <dev <at> jpoiret.xyz>, 70494 <at> debbugs.gnu.org,
 Simon Tournier <zimon.toutoune <at> gmail.com>, Mathieu Othacehe <othacehe <at> gnu.org>,
 Tobias Geerinckx-Rice <me <at> tobias.gr>, Ricardo Wurmus <rekado <at> elephly.net>,
 Christopher Baines <guix <at> cbaines.net>
Subject: Re: [bug#70494] [PATCH 18/23] guix: http-client: Add network-error?.
Date: Thu, 16 May 2024 18:23:22 +0200

Christopher Baines <mail <at> cbaines.net> skribis:

> Plus remove http-get-error? from network-error? as a http-get-error? doesn't
> indicate a network error.
>
> * guix/scripts/substitute.scm (system-error?, network-error?): Move from here.
> (process-substitution/fallback, process-substitution): Use http-get-error?
> with network-error?.
> * guix/http-client.scm: To here, and also don't use http-get-error?.
>
> Change-Id: I61ee9e5fbf90ebb76a34aa8b9ec8f5d74f8a3c54

LGTM, but...

> -              (guard (c ((network-error? c)
> +              (guard (c ((or (http-get-error? c)
> +                             (network-error? c))
>                           (when (http-get-error? c)
>                             (warning (G_ "download from '~a' failed: ~a, ~s~%")
>                                      (uri->string (http-get-error-uri c))
> @@ -663,7 +644,8 @@ (define* (process-substitution store-item destination
>    (let ((expected-hash
>           actual-hash
>           (guard
> -             (c ((network-error? c)
> +             (c ((or (http-get-error? c)
> +                     (network-error? c))

These two hunks should probably go to a different commit, because
they’re really fixing a bug.

(The commit log subject line doesn’t need the “guix:” prefix.)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.