GNU bug report logs - #70485
30.0.50; Asymetrical margins break mode-line-right-align-edge

Previous Next

Package: emacs;

Reported by: Charles Gonnaud <charles.gonnaud <at> gmail.com>

Date: Sat, 20 Apr 2024 21:39:03 UTC

Severity: normal

Found in version 30.0.50

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #10 received at 70485-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Charles Gonnaud <charles.gonnaud <at> gmail.com>
Cc: 70485-done <at> debbugs.gnu.org
Subject: Re: bug#70485: 30.0.50;
 Asymetrical margins break mode-line-right-align-edge
Date: Thu, 25 Apr 2024 19:36:47 +0300
> Date: Sat, 20 Apr 2024 23:38:18 +0200
> From: Charles Gonnaud <charles.gonnaud <at> gmail.com>
> 
> Hello to all,
> Thank you for your work maintaining emacs, this is my first bug report
> so please be indulgent.
> 
> *** Bug description
> 
> I use a minor-mode similar to olivetti
> (https://github.com/rnkn/olivetti), which uses margins to center the
> text in the window.
> 
> Playing around with the doom modeline, which copied emacs 30's
> implementation of `mode-line-right-align-edge', I noticed that setting
> a different margin on the left and right resulted in a cropped modeline
> to the right.
> 
> *** Suggested patch
> 
> In mode--line-format-right-align() (lisp/bindings.el:384)
> - (* (or (cdr (window-margins)) 1)
> + (* (or (car (window-margins)) 0)

Thanks, you are right.  I've now installed your proposed change on the
master branch, and I'm therefore closing this bug.




This bug report was last modified 1 year and 87 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.