From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 19 19:05:38 2024 Received: (at submit) by debbugs.gnu.org; 19 Apr 2024 23:05:38 +0000 Received: from localhost ([127.0.0.1]:60867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rxxIX-0001pU-CG for submit@debbugs.gnu.org; Fri, 19 Apr 2024 19:05:38 -0400 Received: from lists.gnu.org ([2001:470:142::17]:58800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rxvME-00048C-0c for submit@debbugs.gnu.org; Fri, 19 Apr 2024 17:01:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxvLW-0001Hq-MI for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2024 17:00:35 -0400 Received: from mail-vk1-xa2e.google.com ([2607:f8b0:4864:20::a2e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rxvLU-0006qC-3o for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2024 17:00:34 -0400 Received: by mail-vk1-xa2e.google.com with SMTP id 71dfb90a1353d-4db24342894so720741e0c.0 for ; Fri, 19 Apr 2024 14:00:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713560429; x=1714165229; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=EWsWsFvWbI9DbG2xjapX7oz26DQ9c+Z0BGA+DXSLZ2w=; b=GBap2dmTegnTZERngqtW5oM6vXe1327JVcWGbVpWHjGXWKxeYyIMOwAT1liGOZLtmg n8W9b+zZ0e03XbpriRq7Vdve9HDsUAmxH03sL+BrT6hSBNsnZP2RNLceWW4jrmDpaasp 88U5RXoIRxYkGWF/cuuQzOPKAEdDmSJZY2wcf9svzSJnPD8IDjLh08DntZUBaf01jK0Z hiQS0kTQwshzmhi8yCulShHadX01l1SMCOgnCErz90Y3/G/6bxbkLUtf4eGFdlTp146u qU9mcwBGk4OEQ5jUSKD+9wEIIqEQm8lDEyl5+5I7TWAwlZaEkPt2CHBL4O9EQuYK0XxS IiFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713560429; x=1714165229; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=EWsWsFvWbI9DbG2xjapX7oz26DQ9c+Z0BGA+DXSLZ2w=; b=BhKpKt/4X3vV8P25gpYxDuFTeW9+R9WcwA9eTV1ac5EiAEQib/q81lmW1ha9qIJRZa HNON/64nxeqshEu7GVnvHJHYCgiByQMKWi/IyOleys3NnYNOqiVaTYWH65gHjccXLx6P OK/SaH7cl3kNjm+2cPAhS8LIXJYSju+JjpRKlZfKV9fOoKOZVptd6BDl8Ok5nqvOMOjb fke8UfbiHjfQK+VwCG7bw9cqxagZitG53G7jACS/swM26NLHThJb42kGK//K91N4ZXLK uz6e43dSh2ladyKncQLRU5MPg8hl8AIoi1wsIFsa89Pjdd601VPipd3+eEJWFHsJtqkp pzJA== X-Gm-Message-State: AOJu0Yx3e1G3VKbeVMT/hvnYFTUxwlacK/cxHgGjzY1lFc2cagat9uua BY8yd7Jz+xJd0s7ssNhXOn8xsogySMktBuJq1KqenSxf6McRvO82mSOYri06ZXLZDKYggVIQVE6 BIGIrmDn5gT8iP7pD82IHhikI8k3OwFhZ X-Google-Smtp-Source: AGHT+IGnMuIVn/8sFKuqP+ANN23hIfhC38PI7fuQe8ERcFmFSbTAGLYIp3MxcjQio630b8MtkC4pne1wao399f75j8I= X-Received: by 2002:a05:6122:220c:b0:4d4:19e9:db0 with SMTP id bb12-20020a056122220c00b004d419e90db0mr3465109vkb.0.1713560428874; Fri, 19 Apr 2024 14:00:28 -0700 (PDT) MIME-Version: 1.0 From: Prateek Sharma Date: Sat, 20 Apr 2024 02:30:17 +0530 Message-ID: Subject: 30.0.50; [PATCH] Fix treesitter-font-lock-settings for built-in functions and attributes. To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="000000000000aa270806167960c9" Received-SPF: pass client-ip=2607:f8b0:4864:20::a2e; envelope-from=ps.prateek.sharma143@gmail.com; helo=mail-vk1-xa2e.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Dear maintainers, I do a lot of programming in python and have noticed that if there is a method of a class defined with the same name as a builtin function. It gets highlighted with the face for builtin functions and [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (ps.prateek.sharma143[at]gmail.com) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (ps.prateek.sharma143[at]gmail.com) 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 HTML_MESSAGE BODY: HTML included in message X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 19 Apr 2024 19:05:09 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --000000000000aa270806167960c9 Content-Type: multipart/alternative; boundary="000000000000aa270806167960c7" --000000000000aa270806167960c7 Content-Type: text/plain; charset="UTF-8" Dear maintainers, I do a lot of programming in python and have noticed that if there is a method of a class defined with the same name as a builtin function. It gets highlighted with the face for builtin functions and it looks different for all the other functions and confuses me sometimes and just looks inconsistent. I have made a simple fix to the treesitter query and it seems to have fixed the problem. Please share you thoughts on this fix. This is my first time contributing to an open-source project and to emacs. Very excited to hear from you guys!!! Prateek Sharma --000000000000aa270806167960c7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Dear maintainers,

I do a lot of programming in pyth= on and have noticed that if there is a
method of a class defined with th= e same name as a builtin function. It
gets highlighted with the face for= builtin functions and it looks
different for all the other functions an= d confuses me sometimes and just
looks inconsistent.

I have made = a simple fix to the treesitter query and it seems to have
fixed the prob= lem.

Please share you thoughts on this fix. This is my first timecontributing to an open-source project and to emacs. Very excited to
he= ar from you guys!!!

Prateek Sharma
--000000000000aa270806167960c7-- --000000000000aa270806167960c9 Content-Type: application/octet-stream; name="0001-Fix-treesitter-font-lock-settings-for-built-in-funct.patch" Content-Disposition: attachment; filename="0001-Fix-treesitter-font-lock-settings-for-built-in-funct.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lv75meqq0 RnJvbSAzYmEyM2FlYTI4Nzk2YjgwMTgzMmJhZjFhYTVlMTA5MmNmZjg4ZTZlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQcmF0ZWVrIFNoYXJtYSA8cHMucHJhdGVlay5zaGFybWExNDNA Z21haWwuY29tPgpEYXRlOiBTYXQsIDIwIEFwciAyMDI0IDAyOjA2OjE3ICswNTMwClN1YmplY3Q6 IFtQQVRDSF0gRml4IHRyZWVzaXR0ZXItZm9udC1sb2NrLXNldHRpbmdzIGZvciBidWlsdC1pbiBm dW5jdGlvbnMgYW5kCiBhdHRyaWJ1dGVzLgoKKiBldGMvTkVXUzogQW5ub3VuY2UgdGhlIGVmZmVj dCBvZiB0aGUgY2hhbmdlcyBmb3IgdGhlIHRyZWVzaXR0ZXItZm9udC1sb2NrLXNldHRpbmdzIGZv ciBidWlsdC1pbiBmdW5jdGlvbnMgYW5kIGF0dHJpYnV0ZXMKKiBsaXNwL3Byb2dtb2Rlcy9weXRo b24uZWwgKHB5dGhvbi0tdHJlZXNpdC1zZXR0aW5ncyk6IENoYW5nZSB0aGUgdHJlZXNpdHRlciBx dWVyeSB0byBmZXRjaCB0aGUgY29ycmVjdCB0eXBlIG9mIG5vZGUgZm9yIGJ1aWx0LWluIGZ1bmN0 aW9ucyBhbmQgYXR0cmlidXRlcyBhbmQgaGlnaGxpZ2h0IHRoZW0gd2l0aCBjb3JyZXNwb25kaW5n IGZvbnQtbG9jayBmYWNlLgotLS0KIGV0Yy9ORVdTICAgICAgICAgICAgICAgICB8ICA5ICsrKysr KysrKwogbGlzcC9wcm9nbW9kZXMvcHl0aG9uLmVsIHwgMTMgKysrKysrLS0tLS0tLQogMiBmaWxl cyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L2V0Yy9ORVdTIGIvZXRjL05FV1MKaW5kZXggOGFkMWU3OGNhNjAuLmU1Y2Q3MGI2MTA2IDEwMDY0 NAotLS0gYS9ldGMvTkVXUworKysgYi9ldGMvTkVXUwpAQCAtMTMxOSw2ICsxMzE5LDE1IEBAIGlu c3RlYWQgb2Y6CiBUaGlzIGFsbG93cyB0aGUgdXNlciB0byBzcGVjaWZ5IGNvbW1hbmQgbGluZSBh cmd1bWVudHMgdG8gdGhlIG5vbgogaW50ZXJhY3RpdmUgUHl0aG9uIGludGVycHJldGVyIHNwZWNp ZmllZCBieSAncHl0aG9uLWludGVycHJldGVyJy4KIAorKioqIFRyZWVzaXR0ZXIgc3ludGF4IGhp Z2hsaWdodGluZyBmb3IgYnVpbHQtaW4gZnVuY3Rpb25zIGZpeGVkCitUaGUgZml4IGhpZ2hsaWdo dHMgb25seSB0aGUgY29ycmVjdCBidWlsdC1pbiBmdW5jdGlvbiBjYWxscyBhbmQKK2F0dHJpYnV0 ZXMgd2l0aCBmb250LWxvY2stYnVpbHRpbi1mYWNlLiBXaGVuIHNvbWUgY2xhc3MgZGVmaW5lcwor YSBmdW5jdGlvbiB3aXRoIHRoZSBzYW1lIG5hbWUgYXMgYSBidWlsdC1pbiBmdW5jdGlvbiwgZWFy bGllciBpdCB3YXMKK2JlaW5nIGhpZ2hsaWdodGVkIHdpdGggdGhlIHNhbWUgZm9udC1sb2NrLWJ1 aWx0aW4tZmFjZSwgd2hpY2ggd2FzCitpbmNvcnJlY3QuIE5vdywgbm9ybWFsIHVzZXIgZGVmaW5l ZCBmdW5jdGlvbnMgd2lsbCBiZSBoaWdobGlnaHRlZAord2l0aCBmb250LWxvY2stZnVuY3Rpb24t Y2FsbC1mYWNlIGZhY2UgYW5kIGJ1aWx0LWluIGZ1bmN0aW9ucyBhbmQKK2F0dHJpYnV0ZXMgd2ls bCBiZSBoaWdobGlnaHRlZCB3aXRoIGZvbnQtbG9jay1idWlsdGluLWZhY2UuCisKICoqIFNjaGVt ZSBtb2RlCiBTY2hlbWUgbW9kZSBub3cgaGFuZGxlcyByZWd1bGFyIGV4cHJlc3Npb24gbGl0ZXJh bCAnIy9yZWdleHAvJyB0aGF0IGlzCiBhdmFpbGFibGUgaW4gc29tZSBTY2hlbWUgaW1wbGVtZW50 YXRpb25zLgpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvcHl0aG9uLmVsIGIvbGlzcC9wcm9n bW9kZXMvcHl0aG9uLmVsCmluZGV4IDg1Mjc5ZDNlODRiLi41YzY3ZDA3NjVlYiAxMDA2NDQKLS0t IGEvbGlzcC9wcm9nbW9kZXMvcHl0aG9uLmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL3B5dGhvbi5l bApAQCAtMTIwNiwxMyArMTIwNiwxMiBAQCBmb250aWZpZWQuIgogCiAgICA6ZmVhdHVyZSAnYnVp bHRpbgogICAgOmxhbmd1YWdlICdweXRob24KLSAgIGAoKChpZGVudGlmaWVyKSBAZm9udC1sb2Nr LWJ1aWx0aW4tZmFjZQotICAgICAgKDptYXRjaCAsKHJ4LXRvLXN0cmluZwotICAgICAgICAgICAg ICAgIGAoc2VxIGJvbAotICAgICAgICAgICAgICAgICAgICAgIChvciAsQHB5dGhvbi0tdHJlZXNp dC1idWlsdGlucwotICAgICAgICAgICAgICAgICAgICAgICAgICAsQHB5dGhvbi0tdHJlZXNpdC1z cGVjaWFsLWF0dHJpYnV0ZXMpCi0gICAgICAgICAgICAgICAgICAgICAgZW9sKSkKLSAgICAgICAg ICAgICAgQGZvbnQtbG9jay1idWlsdGluLWZhY2UpKSkKKyAgIGAoKGNhbGwgZnVuY3Rpb246IChp ZGVudGlmaWVyKSBAZm9udC1sb2NrLWJ1aWx0aW4tZmFjZQorICAgICAgICAgICAoOm1hdGNoICwo cngtdG8tc3RyaW5nIGAoc2VxIGJvbCAob3IgLEBweXRob24tLXRyZWVzaXQtYnVpbHRpbnMpIGVv bCkpCisgICAgICAgICAgICAgICAgICAgQGZvbnQtbG9jay1idWlsdGluLWZhY2UpKQorICAgICAo YXR0cmlidXRlIGF0dHJpYnV0ZTogKGlkZW50aWZpZXIpIEBmb250LWxvY2stYnVpbHRpbi1mYWNl CisgICAgICAgICAgICAgICAgKDptYXRjaCAsKHJ4LXRvLXN0cmluZyBgKHNlcSBib2wgKG9yICxA cHl0aG9uLS10cmVlc2l0LXNwZWNpYWwtYXR0cmlidXRlcykgZW9sKSkKKyAgICAgICAgICAgICAg ICAgICAgICAgIEBmb250LWxvY2stYnVpbHRpbi1mYWNlKSkpCiAKICAgIDpmZWF0dXJlICdkZWNv cmF0b3IKICAgIDpsYW5ndWFnZSAncHl0aG9uCi0tIAoyLjM5LjMgKEFwcGxlIEdpdC0xNDYpCgo= --000000000000aa270806167960c9-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 20 02:14:16 2024 Received: (at 70478) by debbugs.gnu.org; 20 Apr 2024 06:14:16 +0000 Received: from localhost ([127.0.0.1]:34491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ry3zK-0003DS-IE for submit@debbugs.gnu.org; Sat, 20 Apr 2024 02:14:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56156) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ry3zG-0003CP-Qe for 70478@debbugs.gnu.org; Sat, 20 Apr 2024 02:14:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ry3yw-0003L8-TQ; Sat, 20 Apr 2024 02:13:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=uRrKcIB6W4P53aDrkuhEImkVF5wzrf2qT9VfNNPBqQc=; b=ltRhcu7e8Fe8 xDM+rh/QExuGS7mUvXFmgU/7ZlydHtMLk6uDS84tP/YSqeXQw9EsDnKVsXpbkfWhASgVUkExFe9T9 WJjQXDhCBu28c9W6qZhatoynYBVOAQaYyZZUgI/GpfrwzLGksKdWX5Qp07NPudRh0C6GfAcvCZI+2 uI42eg6h7PUMeEgMIxBzQA7w6N3oiq+wnCZyyeAYhv/p4r+1x1JHrQrnP7cXIZFVkxbUBOgqLHa5x wPQS6hsFHd56JAzc/YZQBYMBdMD/sUAIVKuEUEtXiK9n32PM4Zns2WRaY5F/Zkm70C4hseA/ISt67 IKYqlUY2BIFnWF3IqY0ozQ==; Date: Sat, 20 Apr 2024 09:13:48 +0300 Message-Id: <86le58a7dv.fsf@gnu.org> From: Eli Zaretskii To: Prateek Sharma , Yuan Fu In-Reply-To: (message from Prateek Sharma on Sat, 20 Apr 2024 02:30:17 +0530) Subject: Re: bug#70478: 30.0.50; [PATCH] Fix treesitter-font-lock-settings for built-in functions and attributes. References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70478 Cc: 70478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Prateek Sharma > Date: Sat, 20 Apr 2024 02:30:17 +0530 > > I do a lot of programming in python and have noticed that if there is a > method of a class defined with the same name as a builtin function. It > gets highlighted with the face for builtin functions and it looks > different for all the other functions and confuses me sometimes and just > looks inconsistent. > > I have made a simple fix to the treesitter query and it seems to have > fixed the problem. > > Please share you thoughts on this fix. This is my first time > contributing to an open-source project and to emacs. Very excited to > hear from you guys!!! Thanks. Yuan, any comments? I have a few minor comments below. > diff --git a/etc/NEWS b/etc/NEWS > index 8ad1e78ca60..e5cd70b6106 100644 > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -1319,6 +1319,15 @@ instead of: > This allows the user to specify command line arguments to the non > interactive Python interpreter specified by 'python-interpreter'. > > +*** Treesitter syntax highlighting for built-in functions fixed > +The fix highlights only the correct built-in function calls and > +attributes with font-lock-builtin-face. When some class defines > +a function with the same name as a built-in function, earlier it was > +being highlighted with the same font-lock-builtin-face, which was > +incorrect. Now, normal user defined functions will be highlighted > +with font-lock-function-call-face face and built-in functions and > +attributes will be highlighted with font-lock-builtin-face. This part is not needed, I think: we don't document bugfixes in NEWS. > + `((call function: (identifier) @font-lock-builtin-face > + (:match ,(rx-to-string `(seq bol (or ,@python--treesit-builtins) eol)) > + @font-lock-builtin-face)) > + (attribute attribute: (identifier) @font-lock-builtin-face > + (:match ,(rx-to-string `(seq bol (or ,@python--treesit-special-attributes) eol)) > + @font-lock-builtin-face))) Please reformat the whitespace here to avoid exceeding 80 columns in each individual line. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 20 02:54:47 2024 Received: (at 70478) by debbugs.gnu.org; 20 Apr 2024 06:54:48 +0000 Received: from localhost ([127.0.0.1]:34659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ry4cZ-0007qv-4n for submit@debbugs.gnu.org; Sat, 20 Apr 2024 02:54:47 -0400 Received: from mail-vk1-xa30.google.com ([2607:f8b0:4864:20::a30]:44403) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ry4cX-0007qK-5M for 70478@debbugs.gnu.org; Sat, 20 Apr 2024 02:54:45 -0400 Received: by mail-vk1-xa30.google.com with SMTP id 71dfb90a1353d-4dabbd69c71so769773e0c.1 for <70478@debbugs.gnu.org>; Fri, 19 Apr 2024 23:54:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713596065; x=1714200865; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ldlGDWLqlYG4eJvSl55RwetYaxw3pR8inMWLOiHF7OE=; b=k8SBL3qUOsSy8TMKAhpVyv58aocnNqMq6pbdXTP1g7ey88H9IVYLz7/AwYGxAd+/ti XUEkXu1/hdUnd69Qnu0+lJyoAvMc+RVhhKt6SehZaSOl9z7OJ4KxF0y3vNeP4N1sE0n1 N3IUwUbNmc1qzhqB3CmFYHdYSMrzSeat/RdfY3ZBi6G4PzG/KyM7w3Ueob7gXMWchZYI sU93/8rFCLAMEEKWUnt+iRnwr0l2+tijoeG7HjZab32zvWgcrO5I4BB/Npr1KssEvQBP diwKYMJa684q8hjblp6niVFEVWheGvzm5/PW1Hl0Lv23tJHVN2RyBF8IRYegHS+h67bd KdtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713596065; x=1714200865; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ldlGDWLqlYG4eJvSl55RwetYaxw3pR8inMWLOiHF7OE=; b=N5ysMHBivBimAI1YJcsQKqR17RoADhfW9d0ur9bcJqrtrHhog1Wl5wyed5RP21UFTt GkIFLzoWy0cjD4nCN1tfGw3IPEPYtJFFc1URrm5GtaaxmYQ83Tx12MelMSS1YGrUv/hb JKFHP2n8tCUD4oyyUy1JkCB3mCiDSQ7aBstBIxOdmoXb5WlEg504w4z9taSskBmldOWA k1L3iLO4ClfAb0YxJZRN03IeNppatBr0BLe3a3fEfyf28EQ5C90YbRK7tD0fD9ogpXib zxGCJ1dEZe9+QARq3DTE5lkY0ctgmNrJZLvFSEoypSmvt3i2hkyw2WWuzIqNq018a6Pj woDQ== X-Forwarded-Encrypted: i=1; AJvYcCWgl6bjrxvCXMv9xmFd23OmRHYnpnZBek/l0oa6DNNxvlKcBhMKHJ/HiXCa8XmiEm/GxsxAr0WoJFdFiYc19hjsi6jIXYA= X-Gm-Message-State: AOJu0Yz9DKW8GJmqGcnoQ2VSvRZ/hdxeargcSmJrXVKGGIWWHgo4qfzv 9JGqGNV4Kuua408VsKxK/BlzHaQW4lEWe032EW4lJh3/9LJ4J4vBJ4yQnEjcKFeHi6vchnehYQz vsc/iDnNiSto+r4dECG4H5uvpoBc= X-Google-Smtp-Source: AGHT+IFN3r3k4IyjPNWJ8PXk2O4ny0vAOk8yF/o2xj9BRX288nC7jiKnbO86TAOntP5ILWbsgFkGdnz2l0aiz1Ilevs= X-Received: by 2002:ac5:c856:0:b0:4db:11aa:7ab1 with SMTP id g22-20020ac5c856000000b004db11aa7ab1mr4420774vkm.10.1713596064905; Fri, 19 Apr 2024 23:54:24 -0700 (PDT) MIME-Version: 1.0 References: <86le58a7dv.fsf@gnu.org> In-Reply-To: <86le58a7dv.fsf@gnu.org> From: Prateek Sharma Date: Sat, 20 Apr 2024 12:24:13 +0530 Message-ID: Subject: Re: bug#70478: 30.0.50; [PATCH] Fix treesitter-font-lock-settings for built-in functions and attributes. To: Eli Zaretskii Content-Type: multipart/mixed; boundary="000000000000bcd314061681ac7e" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 70478 Cc: Yuan Fu , 70478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --000000000000bcd314061681ac7e Content-Type: multipart/alternative; boundary="000000000000bcd312061681ac7c" --000000000000bcd312061681ac7c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hey, Thanks for reviewing my changes. Here is the patch for reformatted version of the above fix. I've also removed the announcement in the NEWS file. On Sat, Apr 20, 2024 at 11:43=E2=80=AFAM Eli Zaretskii wrote= : > > From: Prateek Sharma > > Date: Sat, 20 Apr 2024 02:30:17 +0530 > > > > I do a lot of programming in python and have noticed that if there is a > > method of a class defined with the same name as a builtin function. It > > gets highlighted with the face for builtin functions and it looks > > different for all the other functions and confuses me sometimes and jus= t > > looks inconsistent. > > > > I have made a simple fix to the treesitter query and it seems to have > > fixed the problem. > > > > Please share you thoughts on this fix. This is my first time > > contributing to an open-source project and to emacs. Very excited to > > hear from you guys!!! > > Thanks. Yuan, any comments? > > I have a few minor comments below. > > > diff --git a/etc/NEWS b/etc/NEWS > > index 8ad1e78ca60..e5cd70b6106 100644 > > --- a/etc/NEWS > > +++ b/etc/NEWS > > @@ -1319,6 +1319,15 @@ instead of: > > This allows the user to specify command line arguments to the non > > interactive Python interpreter specified by 'python-interpreter'. > > > > +*** Treesitter syntax highlighting for built-in functions fixed > > +The fix highlights only the correct built-in function calls and > > +attributes with font-lock-builtin-face. When some class defines > > +a function with the same name as a built-in function, earlier it was > > +being highlighted with the same font-lock-builtin-face, which was > > +incorrect. Now, normal user defined functions will be highlighted > > +with font-lock-function-call-face face and built-in functions and > > +attributes will be highlighted with font-lock-builtin-face. > > This part is not needed, I think: we don't document bugfixes in NEWS. > > > + `((call function: (identifier) @font-lock-builtin-face > > + (:match ,(rx-to-string `(seq bol (or > ,@python--treesit-builtins) eol)) > > + @font-lock-builtin-face)) > > + (attribute attribute: (identifier) @font-lock-builtin-face > > + (:match ,(rx-to-string `(seq bol (or > ,@python--treesit-special-attributes) eol)) > > + @font-lock-builtin-face))) > > Please reformat the whitespace here to avoid exceeding 80 columns in > each individual line. > --000000000000bcd312061681ac7c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hey, Thanks for reviewing my changes.

H= ere is the patch for reformatted=C2=A0version of the above fix. I've al= so removed the announcement in the NEWS file.

On Sat, Apr 20, 2024 at = 11:43=E2=80=AFAM Eli Zaretskii <eliz@gnu= .org> wrote:
> From: Prateek Sharma <ps.prateek.sharma143@gmail.com>
> Date: Sat, 20 Apr 2024 02:30:17 +0530
>
> I do a lot of programming in python and have noticed that if there is = a
> method of a class defined with the same name as a builtin function. It=
> gets highlighted with the face for builtin functions and it looks
> different for all the other functions and confuses me sometimes and ju= st
> looks inconsistent.
>
> I have made a simple fix to the treesitter query and it seems to have<= br> > fixed the problem.
>
> Please share you thoughts on this fix. This is my first time
> contributing to an open-source project and to emacs. Very excited to > hear from you guys!!!

Thanks.=C2=A0 Yuan, any comments?

I have a few minor comments below.

> diff --git a/etc/NEWS b/etc/NEWS
> index 8ad1e78ca60..e5cd70b6106 100644
> --- a/etc/NEWS
> +++ b/etc/NEWS
> @@ -1319,6 +1319,15 @@ instead of:
>=C2=A0 This allows the user to specify command line arguments to the no= n
>=C2=A0 interactive Python interpreter specified by 'python-interpre= ter'.
>=C2=A0
> +*** Treesitter syntax highlighting for built-in functions fixed
> +The fix highlights only the correct built-in function calls and
> +attributes with font-lock-builtin-face. When some class defines
> +a function with the same name as a built-in function, earlier it was<= br> > +being highlighted with the same font-lock-builtin-face, which was
> +incorrect. Now, normal user defined functions will be highlighted
> +with font-lock-function-call-face face and built-in functions and
> +attributes will be highlighted with font-lock-builtin-face.

This part is not needed, I think: we don't document bugfixes in NEWS.
> +=C2=A0 =C2=A0`((call function: (identifier) @font-lock-builtin-face > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(:match ,(rx-to-string `(seq= bol (or ,@python--treesit-builtins) eol))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= @font-lock-builtin-face))
> +=C2=A0 =C2=A0 =C2=A0(attribute attribute: (identifier) @font-lock-bui= ltin-face
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (:match ,(rx-= to-string `(seq bol (or ,@python--treesit-special-attributes) eol))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 @font-lock-builtin-face)))

Please reformat the whitespace here to avoid exceeding 80 columns in
each individual line.
--000000000000bcd312061681ac7c-- --000000000000bcd314061681ac7e Content-Type: application/octet-stream; name="0002-Reformat-treesitter-query-for-builtins-to-not-exceed.patch" Content-Disposition: attachment; filename="0002-Reformat-treesitter-query-for-builtins-to-not-exceed.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lv7qsoa60 RnJvbSA4NjdjNjc2NzBiMzFkMGFkZjRhMTY3MTE3OTJlMmQ4MzllYjhlYmQ3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQcmF0ZWVrIFNoYXJtYSA8cHMucHJhdGVlay5zaGFybWExNDNA Z21haWwuY29tPgpEYXRlOiBTYXQsIDIwIEFwciAyMDI0IDEyOjEzOjQ4ICswNTMwClN1YmplY3Q6 IFtQQVRDSCAyLzJdIFJlZm9ybWF0IHRyZWVzaXR0ZXIgcXVlcnkgZm9yIGJ1aWx0aW5zIHRvIG5v dCBleGNlZWQgODAKIGNvbHVtbnMKCiogZXRjL05FV1M6IFJlbW92ZSBidWdmaXggbmV3cyBhcyBp dCdzIG5vdCBuZWVkZWQKKiBsaXNwL3Byb2dtb2Rlcy9weXRob24uZWwgKHB5dGhvbi0tdHJlZXNp dC1zZXR0aW5ncyk6IFJlZm9ybWF0IHRoZSB0cmVlc2l0dGVyIHF1ZXJ5IGZvciBmb250LWxvY2sg dG8gbm90IGV4Y2VlZCA4MCBjb2x1bW5zCi0tLQogZXRjL05FV1MgICAgICAgICAgICAgICAgIHwg OSAtLS0tLS0tLS0KIGxpc3AvcHJvZ21vZGVzL3B5dGhvbi5lbCB8IDcgKysrKystLQogMiBmaWxl cyBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L2V0Yy9ORVdTIGIvZXRjL05FV1MKaW5kZXggZTVjZDcwYjYxMDYuLjhhZDFlNzhjYTYwIDEwMDY0 NAotLS0gYS9ldGMvTkVXUworKysgYi9ldGMvTkVXUwpAQCAtMTMxOSwxNSArMTMxOSw2IEBAIGlu c3RlYWQgb2Y6CiBUaGlzIGFsbG93cyB0aGUgdXNlciB0byBzcGVjaWZ5IGNvbW1hbmQgbGluZSBh cmd1bWVudHMgdG8gdGhlIG5vbgogaW50ZXJhY3RpdmUgUHl0aG9uIGludGVycHJldGVyIHNwZWNp ZmllZCBieSAncHl0aG9uLWludGVycHJldGVyJy4KIAotKioqIFRyZWVzaXR0ZXIgc3ludGF4IGhp Z2hsaWdodGluZyBmb3IgYnVpbHQtaW4gZnVuY3Rpb25zIGZpeGVkCi1UaGUgZml4IGhpZ2hsaWdo dHMgb25seSB0aGUgY29ycmVjdCBidWlsdC1pbiBmdW5jdGlvbiBjYWxscyBhbmQKLWF0dHJpYnV0 ZXMgd2l0aCBmb250LWxvY2stYnVpbHRpbi1mYWNlLiBXaGVuIHNvbWUgY2xhc3MgZGVmaW5lcwot YSBmdW5jdGlvbiB3aXRoIHRoZSBzYW1lIG5hbWUgYXMgYSBidWlsdC1pbiBmdW5jdGlvbiwgZWFy bGllciBpdCB3YXMKLWJlaW5nIGhpZ2hsaWdodGVkIHdpdGggdGhlIHNhbWUgZm9udC1sb2NrLWJ1 aWx0aW4tZmFjZSwgd2hpY2ggd2FzCi1pbmNvcnJlY3QuIE5vdywgbm9ybWFsIHVzZXIgZGVmaW5l ZCBmdW5jdGlvbnMgd2lsbCBiZSBoaWdobGlnaHRlZAotd2l0aCBmb250LWxvY2stZnVuY3Rpb24t Y2FsbC1mYWNlIGZhY2UgYW5kIGJ1aWx0LWluIGZ1bmN0aW9ucyBhbmQKLWF0dHJpYnV0ZXMgd2ls bCBiZSBoaWdobGlnaHRlZCB3aXRoIGZvbnQtbG9jay1idWlsdGluLWZhY2UuCi0KICoqIFNjaGVt ZSBtb2RlCiBTY2hlbWUgbW9kZSBub3cgaGFuZGxlcyByZWd1bGFyIGV4cHJlc3Npb24gbGl0ZXJh bCAnIy9yZWdleHAvJyB0aGF0IGlzCiBhdmFpbGFibGUgaW4gc29tZSBTY2hlbWUgaW1wbGVtZW50 YXRpb25zLgpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvcHl0aG9uLmVsIGIvbGlzcC9wcm9n bW9kZXMvcHl0aG9uLmVsCmluZGV4IDVjNjdkMDc2NWViLi5kNmMyOWU1ZmZjNiAxMDA2NDQKLS0t IGEvbGlzcC9wcm9nbW9kZXMvcHl0aG9uLmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL3B5dGhvbi5l bApAQCAtMTIwNywxMCArMTIwNywxMyBAQCBmb250aWZpZWQuIgogICAgOmZlYXR1cmUgJ2J1aWx0 aW4KICAgIDpsYW5ndWFnZSAncHl0aG9uCiAgICBgKChjYWxsIGZ1bmN0aW9uOiAoaWRlbnRpZmll cikgQGZvbnQtbG9jay1idWlsdGluLWZhY2UKLSAgICAgICAgICAgKDptYXRjaCAsKHJ4LXRvLXN0 cmluZyBgKHNlcSBib2wgKG9yICxAcHl0aG9uLS10cmVlc2l0LWJ1aWx0aW5zKSBlb2wpKQorICAg ICAgICAgICAoOm1hdGNoICwocngtdG8tc3RyaW5nCisgICAgICAgICAgICAgICAgICAgICBgKHNl cSBib2wgKG9yICxAcHl0aG9uLS10cmVlc2l0LWJ1aWx0aW5zKSBlb2wpKQogICAgICAgICAgICAg ICAgICAgIEBmb250LWxvY2stYnVpbHRpbi1mYWNlKSkKICAgICAgKGF0dHJpYnV0ZSBhdHRyaWJ1 dGU6IChpZGVudGlmaWVyKSBAZm9udC1sb2NrLWJ1aWx0aW4tZmFjZQotICAgICAgICAgICAgICAg ICg6bWF0Y2ggLChyeC10by1zdHJpbmcgYChzZXEgYm9sIChvciAsQHB5dGhvbi0tdHJlZXNpdC1z cGVjaWFsLWF0dHJpYnV0ZXMpIGVvbCkpCisgICAgICAgICAgICAgICAgKDptYXRjaCAsKHJ4LXRv LXN0cmluZworICAgICAgICAgICAgICAgICAgICAgICAgICBgKHNlcSBib2wKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgKG9yICxAcHl0aG9uLS10cmVlc2l0LXNwZWNpYWwtYXR0cmli dXRlcykgZW9sKSkKICAgICAgICAgICAgICAgICAgICAgICAgIEBmb250LWxvY2stYnVpbHRpbi1m YWNlKSkpCiAKICAgIDpmZWF0dXJlICdkZWNvcmF0b3IKLS0gCjIuMzkuMyAoQXBwbGUgR2l0LTE0 NikKCg== --000000000000bcd314061681ac7e-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 20 02:56:01 2024 Received: (at 70478) by debbugs.gnu.org; 20 Apr 2024 06:56:01 +0000 Received: from localhost ([127.0.0.1]:34668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ry4di-00082b-30 for submit@debbugs.gnu.org; Sat, 20 Apr 2024 02:56:01 -0400 Received: from mail-vk1-xa29.google.com ([2607:f8b0:4864:20::a29]:56431) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ry4df-000813-3U for 70478@debbugs.gnu.org; Sat, 20 Apr 2024 02:55:56 -0400 Received: by mail-vk1-xa29.google.com with SMTP id 71dfb90a1353d-4dae8b2d29bso698100e0c.0 for <70478@debbugs.gnu.org>; Fri, 19 Apr 2024 23:55:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713596135; x=1714200935; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4cQ6nTDSKI02SzkFAO/Jep7zIA4MHEn/lihlPqfynf4=; b=lrk4oAyRNYXktTfUp6sVty0QOzpwauTfQKwTE66UHu/kN2OkRHSWY8OQlnDZaw6zsf pn+hGeeKqfie+5cgRBFeLf5s1B5SlhUMkQM0wrq5vssXgpm4AxS74X5H/Di7QV6SS3kt 3hEE3yKd+owzJ3u1geIBPHYMZebppG1rtg74xvdvQMQXBD/8O2E/nhBqevSwAV/Ed7Ah vE4Dq1j2PNuQFaRC4+SSGk+kowqRyF5c0pB/imnC06I5S8rDar3Qi1dkuWsJonZZaWos IH1QgN0YTN8ioeLqz180dqryEAXNxxIRnonIlbC55bo4rHzwZwwFid2+lZuBJ2j0+sRt cNDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713596135; x=1714200935; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4cQ6nTDSKI02SzkFAO/Jep7zIA4MHEn/lihlPqfynf4=; b=WUup9F8s2gScuhwFegKRn9lskjFMiuowK98FpL0Ht3fYJ6N7Mk3oSUTAxVcYJ5q1mR 16zz8W6RGtt8202sMGVoDKXfCp4rG7LT6mNK6K/AZqA1Lqw5Dt7rFF5xvSD9Jf9r1hJo YeE143w/DEntBe8Upcb4kZVXZbHsJnA7v5/5dCYnZDlKeGH5cLzh7IbjwgU+X/4kvKgC QMFzAl8BPLOulkrj4P/iTGvsBEdlGWEhKcwUYnZ7RiqmY4fajcOvJqZwgYfOL6ZtnqYA 4eOO/ZIbh84kWFKoe052nCD3QieUoECh9JGyrjPg9GfzjyHb6udLslpsSYZ4qNTyW+RG jleQ== X-Forwarded-Encrypted: i=1; AJvYcCVt1k7dAwP0UbGJEWAw2pqrZVE97TzglacJxYELMR8QX5OBvJjwCo9/McPQpEfI4bo0PFUJ/Nm/BvO8nWUkxaCAVLinjpI= X-Gm-Message-State: AOJu0YxMaZImNc9sUWBnIU17KlrAiCqz5iB2k0xhZKe49hXEDjJ060XS CcxLLqWpsXamvRE7iSJTvIrzs9qt33udj9RZ2QgYKK8CMpaBuf1RvZ5jlnX2gD/aSn1+3ghNHnp 6vTybY0C+p1k/tUuYd48PooCyVxc= X-Google-Smtp-Source: AGHT+IH4g0NfIdpmKSCeLDjiPAnLuIictsuuQiQk17wjFOpPoJsp6aR/IR0f26tUeqCDhzxKjpZfnQqMt3ziaNC0fuQ= X-Received: by 2002:a05:6122:32d4:b0:4c0:24e6:f49d with SMTP id ck20-20020a05612232d400b004c024e6f49dmr5037711vkb.1.1713596134897; Fri, 19 Apr 2024 23:55:34 -0700 (PDT) MIME-Version: 1.0 References: <86le58a7dv.fsf@gnu.org> In-Reply-To: From: Prateek Sharma Date: Sat, 20 Apr 2024 12:25:24 +0530 Message-ID: Subject: Re: bug#70478: 30.0.50; [PATCH] Fix treesitter-font-lock-settings for built-in functions and attributes. To: Eli Zaretskii Content-Type: multipart/alternative; boundary="000000000000e8bd5d061681b0a7" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 70478 Cc: Yuan Fu , 70478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --000000000000e8bd5d061681b0a7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Also should I squash the changes of both the above commits into one and then create a patch file? On Sat, Apr 20, 2024 at 12:24=E2=80=AFPM Prateek Sharma < ps.prateek.sharma143@gmail.com> wrote: > Hey, Thanks for reviewing my changes. > > Here is the patch for reformatted version of the above fix. I've also > removed the announcement in the NEWS file. > > On Sat, Apr 20, 2024 at 11:43=E2=80=AFAM Eli Zaretskii wro= te: > >> > From: Prateek Sharma >> > Date: Sat, 20 Apr 2024 02:30:17 +0530 >> > >> > I do a lot of programming in python and have noticed that if there is = a >> > method of a class defined with the same name as a builtin function. It >> > gets highlighted with the face for builtin functions and it looks >> > different for all the other functions and confuses me sometimes and ju= st >> > looks inconsistent. >> > >> > I have made a simple fix to the treesitter query and it seems to have >> > fixed the problem. >> > >> > Please share you thoughts on this fix. This is my first time >> > contributing to an open-source project and to emacs. Very excited to >> > hear from you guys!!! >> >> Thanks. Yuan, any comments? >> >> I have a few minor comments below. >> >> > diff --git a/etc/NEWS b/etc/NEWS >> > index 8ad1e78ca60..e5cd70b6106 100644 >> > --- a/etc/NEWS >> > +++ b/etc/NEWS >> > @@ -1319,6 +1319,15 @@ instead of: >> > This allows the user to specify command line arguments to the non >> > interactive Python interpreter specified by 'python-interpreter'. >> > >> > +*** Treesitter syntax highlighting for built-in functions fixed >> > +The fix highlights only the correct built-in function calls and >> > +attributes with font-lock-builtin-face. When some class defines >> > +a function with the same name as a built-in function, earlier it was >> > +being highlighted with the same font-lock-builtin-face, which was >> > +incorrect. Now, normal user defined functions will be highlighted >> > +with font-lock-function-call-face face and built-in functions and >> > +attributes will be highlighted with font-lock-builtin-face. >> >> This part is not needed, I think: we don't document bugfixes in NEWS. >> >> > + `((call function: (identifier) @font-lock-builtin-face >> > + (:match ,(rx-to-string `(seq bol (or >> ,@python--treesit-builtins) eol)) >> > + @font-lock-builtin-face)) >> > + (attribute attribute: (identifier) @font-lock-builtin-face >> > + (:match ,(rx-to-string `(seq bol (or >> ,@python--treesit-special-attributes) eol)) >> > + @font-lock-builtin-face))) >> >> Please reformat the whitespace here to avoid exceeding 80 columns in >> each individual line. >> > --000000000000e8bd5d061681b0a7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Also should I squash the changes of both the above commits= into one and then create a patch file?

On Sat, Apr 20, 2024 at 12:24=E2=80= =AFPM Prateek Sharma <= ps.prateek.sharma143@gmail.com> wrote:
Hey, Thanks for reviewing my= changes.

Here is the patch for reformatted=C2=A0version= of the above fix. I've also removed the announcement in the NEWS file.=

On Sat, Apr 20, 2024 at 11:43=E2=80=AFAM Eli Zaretskii <eliz@gnu.org> wrote:
> From: Prateek Shar= ma <= ps.prateek.sharma143@gmail.com>
> Date: Sat, 20 Apr 2024 02:30:17 +0530
>
> I do a lot of programming in python and have noticed that if there is = a
> method of a class defined with the same name as a builtin function. It=
> gets highlighted with the face for builtin functions and it looks
> different for all the other functions and confuses me sometimes and ju= st
> looks inconsistent.
>
> I have made a simple fix to the treesitter query and it seems to have<= br> > fixed the problem.
>
> Please share you thoughts on this fix. This is my first time
> contributing to an open-source project and to emacs. Very excited to > hear from you guys!!!

Thanks.=C2=A0 Yuan, any comments?

I have a few minor comments below.

> diff --git a/etc/NEWS b/etc/NEWS
> index 8ad1e78ca60..e5cd70b6106 100644
> --- a/etc/NEWS
> +++ b/etc/NEWS
> @@ -1319,6 +1319,15 @@ instead of:
>=C2=A0 This allows the user to specify command line arguments to the no= n
>=C2=A0 interactive Python interpreter specified by 'python-interpre= ter'.
>=C2=A0
> +*** Treesitter syntax highlighting for built-in functions fixed
> +The fix highlights only the correct built-in function calls and
> +attributes with font-lock-builtin-face. When some class defines
> +a function with the same name as a built-in function, earlier it was<= br> > +being highlighted with the same font-lock-builtin-face, which was
> +incorrect. Now, normal user defined functions will be highlighted
> +with font-lock-function-call-face face and built-in functions and
> +attributes will be highlighted with font-lock-builtin-face.

This part is not needed, I think: we don't document bugfixes in NEWS.
> +=C2=A0 =C2=A0`((call function: (identifier) @font-lock-builtin-face > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(:match ,(rx-to-string `(seq= bol (or ,@python--treesit-builtins) eol))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= @font-lock-builtin-face))
> +=C2=A0 =C2=A0 =C2=A0(attribute attribute: (identifier) @font-lock-bui= ltin-face
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (:match ,(rx-= to-string `(seq bol (or ,@python--treesit-special-attributes) eol))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 @font-lock-builtin-face)))

Please reformat the whitespace here to avoid exceeding 80 columns in
each individual line.
--000000000000e8bd5d061681b0a7-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 20 03:41:55 2024 Received: (at 70478) by debbugs.gnu.org; 20 Apr 2024 07:41:55 +0000 Received: from localhost ([127.0.0.1]:34847 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ry5MB-0005Hq-9q for submit@debbugs.gnu.org; Sat, 20 Apr 2024 03:41:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ry5M8-0005Gj-Eu for 70478@debbugs.gnu.org; Sat, 20 Apr 2024 03:41:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ry5Lo-0006yi-FO; Sat, 20 Apr 2024 03:41:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=NPuYRr9MLADq5Je9eTTClGCPLC/sm0u80PY7AYzHDn0=; b=O8njGLX6B1fm CnLY+7P/jqZxbrm3EOIhkk49/jP2BJ2ZAWA4yuVMRfsPs9yH21m+3ayRAFC+9YzC8CLe7MsdiUv3Y T7Fxn222KMs82AvmORDyDCgrmcLoNdAHdHMTbcC9pkJZJWCcrKI+vV0UN4pcN1ejUXvhqke263mVj IMSChNwpkoTYORoXwyRnacIx3NKT2I1VqL3TrliKwz+QyzJeLSEfE4U5AWR1eyVbt9IZGOO+2//z3 0UQ1lCAqhlEcp97PzOfNvm7T2itR35MVJG7orqEGxDRxyqNomLei2o+BIialsbVUzGCv64XnSGU5w 3C+tc7JdBSxYxxZZf6s+JA==; Date: Sat, 20 Apr 2024 10:41:29 +0300 Message-Id: <86edb0a3bq.fsf@gnu.org> From: Eli Zaretskii To: Prateek Sharma In-Reply-To: (message from Prateek Sharma on Sat, 20 Apr 2024 12:25:24 +0530) Subject: Re: bug#70478: 30.0.50; [PATCH] Fix treesitter-font-lock-settings for built-in functions and attributes. References: <86le58a7dv.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70478 Cc: casouri@gmail.com, 70478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Prateek Sharma > Date: Sat, 20 Apr 2024 12:25:24 +0530 > Cc: Yuan Fu , 70478@debbugs.gnu.org > > Also should I squash the changes of both the above commits into one and then create a patch file? You should squash, yes. Other than that, attaching the patches as you did is fine. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 20 03:54:09 2024 Received: (at 70478) by debbugs.gnu.org; 20 Apr 2024 07:54:09 +0000 Received: from localhost ([127.0.0.1]:34912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ry5Y0-000752-IO for submit@debbugs.gnu.org; Sat, 20 Apr 2024 03:54:08 -0400 Received: from mail-oo1-xc30.google.com ([2607:f8b0:4864:20::c30]:58554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ry5Xy-00073h-CN for 70478@debbugs.gnu.org; Sat, 20 Apr 2024 03:54:07 -0400 Received: by mail-oo1-xc30.google.com with SMTP id 006d021491bc7-5aa400b917dso1944344eaf.0 for <70478@debbugs.gnu.org>; Sat, 20 Apr 2024 00:53:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713599626; x=1714204426; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=pOPVtGfrE93/tZIZ+l5Ujn4ZY9x9f04rTU/one2hHZ8=; b=Knq9RMiJ//Fz2zbNCs4bAVYnNWC2mHWyqo3lJ2uGU6arbQbTVkeq7V6Lh+u3x3D/hC /OJ3zYDQ2/sbSLS+RUdYtpCjefpz8u73cP3oYRhmpVJhlD16P1aIAzoUM5Z7aaaW3gew mBwnuw6ipOv/2Bqa+EAWQ9M4mfpM0mQFaFYxWcY88u1lCBpGPPg5VuX9SOpsjJWvNSxo W0zVql6Sys2pNOfrCJUhp1/JwssnN5MDShSAm08tzbMZHHQNYVo+oFrmmOWrfH14WkDI DSolzUaEvEiznJ18NpONa9c6DZX5w5FGeGnLu5RvMUViPxHKA7nbtdHDyGb8d5jtF/Y7 zZJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713599626; x=1714204426; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pOPVtGfrE93/tZIZ+l5Ujn4ZY9x9f04rTU/one2hHZ8=; b=dhqvSJ3lg4ZqZ3VF183CcG/iCjV2sWSk7ce3IE7iN2D1PgDuHbA/MicSlA6Q0QYlEj nJNNjqZo9htTxKxaTniLx0vnt+dSIeRWOyiJpVslvshLVTGJi52pa9gFpinb0E8e0XRf +noRkY0d8D8ECa5TsBayJTHCOismoR2EOQ7U/gGwash5fXCirdq3gsG6QVqm1EulMdkZ F+LgfPp+9qnIgTjc3gHAkx2tpbtdOMG7JFe6lCrS0QwN3tWZWP7T40JcHuIWE7aVX0/e I70k4R35B5PHRZB0ONvYyMXSxBBFRl4hcCxHNvjwiP7WonipK3UDBvI3rvJ9U59j5yVv qCVA== X-Forwarded-Encrypted: i=1; AJvYcCUTOFocWbMSQFq7hnW6VxFf4WAdaIvzAAn2smj2hapMLVd8NeBqi8BLELa8PiQzuio7Qzr9aIBjdbnPo8yGvlSapeDTXP4= X-Gm-Message-State: AOJu0Yx+UUmgbZOcjrdW2In89VQk2uZEjZG2KuztktDraVuOl2IljAqU DnvUe99c/aA6hGEshSISP8mXSDAB0wET65vvKSvIj4QDCwOCkIM4PENW/2/53W5eRajgn0AaKQA PIlPyjgeHRMOZa/73ok00HE0c7AA= X-Google-Smtp-Source: AGHT+IG9ANJVtg4O+90DqOP3meWgaNMY5kHJicY3SRcgYkbzz1ft74eMTYNsLoXh+rkg/vzAukU+9UWuvl8Y0hPy6n4= X-Received: by 2002:a05:6358:795:b0:181:6575:1b23 with SMTP id n21-20020a056358079500b0018165751b23mr6996143rwj.5.1713599625947; Sat, 20 Apr 2024 00:53:45 -0700 (PDT) MIME-Version: 1.0 References: <86le58a7dv.fsf@gnu.org> <86edb0a3bq.fsf@gnu.org> In-Reply-To: <86edb0a3bq.fsf@gnu.org> From: Prateek Sharma Date: Sat, 20 Apr 2024 13:23:34 +0530 Message-ID: Subject: Re: bug#70478: 30.0.50; [PATCH] Fix treesitter-font-lock-settings for built-in functions and attributes. To: Eli Zaretskii Content-Type: multipart/mixed; boundary="000000000000feb82e0616828096" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 70478 Cc: casouri@gmail.com, 70478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --000000000000feb82e0616828096 Content-Type: multipart/alternative; boundary="000000000000feb82d0616828094" --000000000000feb82d0616828094 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Here is the patch for the squashed commit and updated code. Thanks for helping me out! On Sat, Apr 20, 2024 at 1:11=E2=80=AFPM Eli Zaretskii wrote: > > From: Prateek Sharma > > Date: Sat, 20 Apr 2024 12:25:24 +0530 > > Cc: Yuan Fu , 70478@debbugs.gnu.org > > > > Also should I squash the changes of both the above commits into one and > then create a patch file? > > You should squash, yes. Other than that, attaching the patches as you > did is fine. > > Thanks. > --000000000000feb82d0616828094 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Here is the patch for the squashed commit and updated code= . Thanks for helping me out!


On Sat, Apr 20, 2024 at 1:11=E2= =80=AFPM Eli Zaretskii <eliz@gnu.org= > wrote:
>= From: Prateek Sharma <ps.prateek.sharma143@gmail.com>
> Date: Sat, 20 Apr 2024 12:25:24 +0530
> Cc: Yuan Fu <casouri@gmail.com>, 70478@debbugs.gnu.org
>
> Also should I squash the changes of both the above commits into one an= d then create a patch file?

You should squash, yes.=C2=A0 Other than that, attaching the patches as you=
did is fine.

Thanks.
--000000000000feb82d0616828094-- --000000000000feb82e0616828096 Content-Type: application/octet-stream; name="0001-Fix-treesitter-font-lock-settings-for-built-in-funct.patch" Content-Disposition: attachment; filename="0001-Fix-treesitter-font-lock-settings-for-built-in-funct.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lv7symwy0 RnJvbSA2YjhlMTU1YTZmYzkxN2ViNjQ0YTMyYzA2ZmE3MzgzYThjYmY0N2I5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQcmF0ZWVrIFNoYXJtYSA8cHMucHJhdGVlay5zaGFybWExNDNA Z21haWwuY29tPgpEYXRlOiBTYXQsIDIwIEFwciAyMDI0IDAyOjA2OjE3ICswNTMwClN1YmplY3Q6 IFtQQVRDSF0gRml4IHRyZWVzaXR0ZXItZm9udC1sb2NrLXNldHRpbmdzIGZvciBidWlsdC1pbiBm dW5jdGlvbnMgYW5kCiBhdHRyaWJ1dGVzLgoKKiBsaXNwL3Byb2dtb2Rlcy9weXRob24uZWwgKHB5 dGhvbi0tdHJlZXNpdC1zZXR0aW5ncyk6IENoYW5nZSB0aGUgdHJlZXNpdHRlciBxdWVyeSB0byBm ZXRjaCB0aGUgY29ycmVjdCB0eXBlIG9mIG5vZGUgZm9yIGJ1aWx0LWluIGZ1bmN0aW9ucyBhbmQg YXR0cmlidXRlcyBhbmQgaGlnaGxpZ2h0IHRoZW0gd2l0aCBjb3JyZXNwb25kaW5nIGZvbnQtbG9j ayBmYWNlLgotLS0KIGxpc3AvcHJvZ21vZGVzL3B5dGhvbi5lbCB8IDE2ICsrKysrKysrKy0tLS0t LS0KIDEgZmlsZSBjaGFuZ2VkLCA5IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCgpkaWZm IC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvcHl0aG9uLmVsIGIvbGlzcC9wcm9nbW9kZXMvcHl0aG9u LmVsCmluZGV4IDg1Mjc5ZDNlODRiLi5kNmMyOWU1ZmZjNiAxMDA2NDQKLS0tIGEvbGlzcC9wcm9n bW9kZXMvcHl0aG9uLmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL3B5dGhvbi5lbApAQCAtMTIwNiwx MyArMTIwNiwxNSBAQCBmb250aWZpZWQuIgogCiAgICA6ZmVhdHVyZSAnYnVpbHRpbgogICAgOmxh bmd1YWdlICdweXRob24KLSAgIGAoKChpZGVudGlmaWVyKSBAZm9udC1sb2NrLWJ1aWx0aW4tZmFj ZQotICAgICAgKDptYXRjaCAsKHJ4LXRvLXN0cmluZwotICAgICAgICAgICAgICAgIGAoc2VxIGJv bAotICAgICAgICAgICAgICAgICAgICAgIChvciAsQHB5dGhvbi0tdHJlZXNpdC1idWlsdGlucwot ICAgICAgICAgICAgICAgICAgICAgICAgICAsQHB5dGhvbi0tdHJlZXNpdC1zcGVjaWFsLWF0dHJp YnV0ZXMpCi0gICAgICAgICAgICAgICAgICAgICAgZW9sKSkKLSAgICAgICAgICAgICAgQGZvbnQt bG9jay1idWlsdGluLWZhY2UpKSkKKyAgIGAoKGNhbGwgZnVuY3Rpb246IChpZGVudGlmaWVyKSBA Zm9udC1sb2NrLWJ1aWx0aW4tZmFjZQorICAgICAgICAgICAoOm1hdGNoICwocngtdG8tc3RyaW5n CisgICAgICAgICAgICAgICAgICAgICBgKHNlcSBib2wgKG9yICxAcHl0aG9uLS10cmVlc2l0LWJ1 aWx0aW5zKSBlb2wpKQorICAgICAgICAgICAgICAgICAgIEBmb250LWxvY2stYnVpbHRpbi1mYWNl KSkKKyAgICAgKGF0dHJpYnV0ZSBhdHRyaWJ1dGU6IChpZGVudGlmaWVyKSBAZm9udC1sb2NrLWJ1 aWx0aW4tZmFjZQorICAgICAgICAgICAgICAgICg6bWF0Y2ggLChyeC10by1zdHJpbmcKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgYChzZXEgYm9sCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIChvciAsQHB5dGhvbi0tdHJlZXNpdC1zcGVjaWFsLWF0dHJpYnV0ZXMpIGVvbCkpCisg ICAgICAgICAgICAgICAgICAgICAgICBAZm9udC1sb2NrLWJ1aWx0aW4tZmFjZSkpKQogCiAgICA6 ZmVhdHVyZSAnZGVjb3JhdG9yCiAgICA6bGFuZ3VhZ2UgJ3B5dGhvbgotLSAKMi4zOS4zIChBcHBs ZSBHaXQtMTQ2KQoK --000000000000feb82e0616828096-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 20 23:48:04 2024 Received: (at 70478) by debbugs.gnu.org; 21 Apr 2024 03:48:05 +0000 Received: from localhost ([127.0.0.1]:40307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryOBQ-0003C7-BU for submit@debbugs.gnu.org; Sat, 20 Apr 2024 23:48:04 -0400 Received: from mail-qk1-x72b.google.com ([2607:f8b0:4864:20::72b]:44438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryOBN-0003B8-Q6 for 70478@debbugs.gnu.org; Sat, 20 Apr 2024 23:48:02 -0400 Received: by mail-qk1-x72b.google.com with SMTP id af79cd13be357-78f02c96c52so221715485a.1 for <70478@debbugs.gnu.org>; Sat, 20 Apr 2024 20:47:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713671261; x=1714276061; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qwLVa9SaLeINOz7iqh4K2HxirKkGSDzPrfr/9Ao+Gvc=; b=HUufhqVt2lhQ7H6zSUc8mMuA7aCxrV5GZdVYgayB2KTTI1MvtPB6PQ0abPfMwo2pHe n6Fh54zlicpLbEml01YM3hDJtiCyUGdHTMu/WojN/Iqrd3Bry4WZktLICPUvVioTwleW 6j7pvHUwGIC48vp270sWfGy6mkiju3rqfRcs6rOX7n6Q/Lck+9Fczo559x58r4qKamN9 Exhm08PCk+eIPo/KWp3F+YYl62dU49fshfBOdVpgpa8iloIpCnl3bgmIG1PqEh9kPvXd IUjJJl+CE1Qj91XGPgqe8V+AlLGXkhkeDpwVL15PABT+CjiGVqr7qBQK895KG9w6qZLP nVSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713671261; x=1714276061; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qwLVa9SaLeINOz7iqh4K2HxirKkGSDzPrfr/9Ao+Gvc=; b=J/6QcNUAs+W8BWigX1XNHe/nPsxzr1z5DcGV40WVO4+lPXSd0mG3rnp3yxdVqXAqZv ISnDmejWl6IqxuYse2GjEvNC8jo+gWSQc2e/2m0+0RQxNQ/AmGP4G2/vSo+Ybg0rlV+I eBfq0Ak3V73fPS1G5fUped+Ntb3SxA6u3IFw3oRlERpyP4MNmCqH53s5ABiAV1n5sM8v NBTgPJrmvmxuZhab26PJx3nK21zNStaGIdtECeUXh24q8+HjSXd6F3tx4o+6mD3zwtGa bnzZJ76xfZKVQLfg1p1XkhJrkmVGpo2lTG3/DZiyK3MP4YKOAQo+xUGpqww8M3WVmiZD 97YQ== X-Forwarded-Encrypted: i=1; AJvYcCXr6kKwjKkH4AXEhXr6tLR+bUcGGkDq2cdBzLdaXzPUIPqdU8nCPooxhSndieYHFn24YRRgI0RL9jMAljt60/TJnAS1Jsc= X-Gm-Message-State: AOJu0YyrEFak/CQzm4JdH5tmX/vf/2CUPwxM7H6+oRu/oiPj65FwR5y/ a+NYN3GUXgHn6ws8EfnDP/m7dgBTbxC1DRm441DXxMEnn95NwXei X-Google-Smtp-Source: AGHT+IGFwioHpKnRXugS3rI8HeDkDP4zaJcJ+yrX29Bm312LbJKwCFPGKfwPuh8H/P3bwvgXzYoHSw== X-Received: by 2002:a05:620a:56c1:b0:78f:179e:9fd1 with SMTP id wh1-20020a05620a56c100b0078f179e9fd1mr6961832qkn.37.1713671260995; Sat, 20 Apr 2024 20:47:40 -0700 (PDT) Received: from smtpclient.apple ([208.95.235.149]) by smtp.gmail.com with ESMTPSA id q24-20020a637518000000b005dc4b562f6csm5365647pgc.3.2024.04.20.20.47.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 20 Apr 2024 20:47:40 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6.1.1\)) Subject: Re: bug#70478: 30.0.50; [PATCH] Fix treesitter-font-lock-settings for built-in functions and attributes. From: Yuan Fu In-Reply-To: Date: Sat, 20 Apr 2024 20:47:29 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <7587CCB2-559E-46D7-B497-668477F41CF4@gmail.com> References: <86le58a7dv.fsf@gnu.org> <86edb0a3bq.fsf@gnu.org> To: Prateek Sharma X-Mailer: Apple Mail (2.3731.700.6.1.1) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70478 Cc: Eli Zaretskii , 70478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Apr 20, 2024, at 12:53 AM, Prateek Sharma = wrote: >=20 > Here is the patch for the squashed commit and updated code. Thanks for = helping me out! >=20 >=20 > On Sat, Apr 20, 2024 at 1:11=E2=80=AFPM Eli Zaretskii = wrote: > > From: Prateek Sharma > > Date: Sat, 20 Apr 2024 12:25:24 +0530 > > Cc: Yuan Fu , 70478@debbugs.gnu.org > >=20 > > Also should I squash the changes of both the above commits into one = and then create a patch file? >=20 > You should squash, yes. Other than that, attaching the patches as you > did is fine. >=20 > Thanks. > <0001-Fix-treesitter-font-lock-settings-for-built-in-funct.patch> Thanks! Should I apply this to master or emacs-29? It=E2=80=99s a fix so = I think emacs-29? Yuan= From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 21 01:17:18 2024 Received: (at 70478) by debbugs.gnu.org; 21 Apr 2024 05:17:18 +0000 Received: from localhost ([127.0.0.1]:40649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryPZl-0005Lu-Pl for submit@debbugs.gnu.org; Sun, 21 Apr 2024 01:17:18 -0400 Received: from mail-vs1-xe29.google.com ([2607:f8b0:4864:20::e29]:56351) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryPZk-0005Li-RL for 70478@debbugs.gnu.org; Sun, 21 Apr 2024 01:17:17 -0400 Received: by mail-vs1-xe29.google.com with SMTP id ada2fe7eead31-479e857876fso1173408137.0 for <70478@debbugs.gnu.org>; Sat, 20 Apr 2024 22:17:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713676616; x=1714281416; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=rfudxBnkpkSJtUHBS99x+ydjMV4nMhfb8cGlOrF7gpk=; b=EV+uQOOa/N/eGOu1Q6KjpSFSfhWnVm7b+ZbRbl09P8tzqO+LdJsTWpFrfqm8OvL6bW Cp3fcUCbvJyLiO6jbWIbZsglsafm0ygpSH+OEOSP8YhFtvssEN08z8AWHfw+HcfndOwH WwhwVhdYfquB0AmERUhFgeJzXij6KQTdlNJnvgfiZ4tYQpA+GKAj5gZLrQbfbQCdilNu I8GDvaD+LoPH8X9LmD9n2pfRGzXPS4ikjnlPGskj00QDOn4BZnBJY3nImqMu82q61aak 6gNmKkLl6kkfjPTjPYOos3Imn7ejgkn1FesRy2g6549DptpoXZIdr1/afJ94mnjhf1jb KXYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713676616; x=1714281416; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rfudxBnkpkSJtUHBS99x+ydjMV4nMhfb8cGlOrF7gpk=; b=q2eQufHSqusmQ2v9XnxLffGb6jUrG5xrGpwUMQfSx60P72B2y0OAajaRCYqzqncMhw i3kDvcBSAVH91uh2DM5pjxduE5B9Hixt46IAvXgKXHRWRvfT8qBuBFuVWtZW3SkeQtB+ hQtgcK/ytc7XysDHGeVlNUtYUHFI1OO/woNpc8RwDI/qWauRBaI1GOIrVeu8KIx38ZZz TW3Sms250ROWqYlvKMexqIEf4GDTgCTViXpdWxw+9FEh4xVCqLNE3rR3aNSSJ7q8KrVV LcTWseiy5qgYRTFeXNizZBJgSLPfF9oH4hhSA3I84NErIX/rCYl13Zcx7GBy6Q7qhDLe n1jw== X-Forwarded-Encrypted: i=1; AJvYcCUs2/kgyO30yqjyjLOTFoVeWgv0XFENT0L9k1eqc071pbvaFIniC6VSGWID6jDn6WorWweXSf3Yb7pphKHE98UGfMEg2FY= X-Gm-Message-State: AOJu0YyBI7PojbRsu+8vofukEVw8cNEG4WhqbI4iqycdK41/ZS9/wbpL CBbHQs1vjiseF9ZBkOpjWo7ZGZAVEPEyfTL1JZmt/INyXxSWKFcatlAMcCfcKiE30vVLbYY9uEp k+VsPactWvbKn29AFEh5ZpApUO7Y= X-Google-Smtp-Source: AGHT+IHkfM+Pl8Uq5FiojunD7KCPRIncnLMdhzVoCZzBzVruTNRO3x6Da2vR/5TexmpBaNJx5RHm6GnrDnTglRABzAk= X-Received: by 2002:a67:bb08:0:b0:47a:31f9:163b with SMTP id m8-20020a67bb08000000b0047a31f9163bmr7494018vsn.13.1713676616138; Sat, 20 Apr 2024 22:16:56 -0700 (PDT) MIME-Version: 1.0 References: <86le58a7dv.fsf@gnu.org> <86edb0a3bq.fsf@gnu.org> <7587CCB2-559E-46D7-B497-668477F41CF4@gmail.com> In-Reply-To: <7587CCB2-559E-46D7-B497-668477F41CF4@gmail.com> From: Prateek Sharma Date: Sun, 21 Apr 2024 10:46:44 +0530 Message-ID: Subject: Re: bug#70478: 30.0.50; [PATCH] Fix treesitter-font-lock-settings for built-in functions and attributes. To: Yuan Fu Content-Type: multipart/alternative; boundary="000000000000f708750616946d3f" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 70478 Cc: Eli Zaretskii , 70478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --000000000000f708750616946d3f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Well, I think emacs-29 also needs this fix. There is one other fix with indentation in python-ts-mode that is needed in emacs-29. But it's already fixed in emacs-30 as I've tested. On Sun, Apr 21, 2024 at 9:17=E2=80=AFAM Yuan Fu wrote: > > > > On Apr 20, 2024, at 12:53 AM, Prateek Sharma < > ps.prateek.sharma143@gmail.com> wrote: > > > > Here is the patch for the squashed commit and updated code. Thanks for > helping me out! > > > > > > On Sat, Apr 20, 2024 at 1:11=E2=80=AFPM Eli Zaretskii wr= ote: > > > From: Prateek Sharma > > > Date: Sat, 20 Apr 2024 12:25:24 +0530 > > > Cc: Yuan Fu , 70478@debbugs.gnu.org > > > > > > Also should I squash the changes of both the above commits into one > and then create a patch file? > > > > You should squash, yes. Other than that, attaching the patches as you > > did is fine. > > > > Thanks. > > <0001-Fix-treesitter-font-lock-settings-for-built-in-funct.patch> > > Thanks! Should I apply this to master or emacs-29? It=E2=80=99s a fix so = I think > emacs-29? > > Yuan --000000000000f708750616946d3f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Well, I think emacs-29 also needs this fix.

=
There is one other fix with indentation in python-ts-mode that is need= ed in emacs-29. But it's already fixed in emacs-30 as I've tested.<= /div>

On Sun, Apr 21, 2024 at 9:17=E2=80=AFAM Yuan Fu <casouri@gmail.com> wrote:


> On Apr 20, 2024, at 12:53 AM, Prateek Sharma <ps.prateek.sharma143@gmail.c= om> wrote:
>
> Here is the patch for the squashed commit and updated code. Thanks for= helping me out!
>
>
> On Sat, Apr 20, 2024 at 1:11=E2=80=AFPM Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Prateek Sharma <ps.prateek.sharma143@gmail.com>
> > Date: Sat, 20 Apr 2024 12:25:24 +0530
> > Cc: Yuan Fu <casouri@gmail.com>, 70478@debbugs.gnu.org
> >
> > Also should I squash the changes of both the above commits into o= ne and then create a patch file?
>
> You should squash, yes.=C2=A0 Other than that, attaching the patches a= s you
> did is fine.
>
> Thanks.
> <0001-Fix-treesitter-font-lock-settings-for-built-in-funct.patch>= ;

Thanks! Should I apply this to master or emacs-29? It=E2=80=99s a fix so I = think emacs-29?

Yuan
--000000000000f708750616946d3f-- From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 21 01:28:12 2024 Received: (at 70478) by debbugs.gnu.org; 21 Apr 2024 05:28:13 +0000 Received: from localhost ([127.0.0.1]:40693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryPkK-0006bp-6O for submit@debbugs.gnu.org; Sun, 21 Apr 2024 01:28:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryPkI-0006aw-BW for 70478@debbugs.gnu.org; Sun, 21 Apr 2024 01:28:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ryPjs-0000WP-MU; Sun, 21 Apr 2024 01:27:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=Ube1dYJwfUI1yWhE8M+PUhzqbOYOiGialNq9fePzs50=; b=o9WquZ9pdTeQytyd+Kg/ j6ZsQv1Ygh2N6RG5ngWdjfLJL+uX+YoZArcsYkwbMMoh3km7AgfVN+dLASLK3FCkxSu+3XU43ZxiL 3H0p1s+skmbFIl2X4SMc0rkw7dQnqHSM/fujoOm+6ayUPv4LgzUzPGXzF8CI5J36wWqwGmCivyCV3 BRPrMIxB8g0Kzx+7gudQS4PrlprfKpDpFlepRVom2blJ8Jz6CpajQn7yFQlV3XxqdHomy1o+XYyZr liIF4NQY9Cvt38AstdFd1e67JLKs/HNNffCrhXU+Rfb5Bfq/AHIK4I+wbXV8iSOQq3NKDnZYBjlj+ zw2GEJqwkwqR7A==; Date: Sun, 21 Apr 2024 08:27:26 +0300 Message-Id: <86a5ln8ev5.fsf@gnu.org> From: Eli Zaretskii To: Yuan Fu In-Reply-To: <7587CCB2-559E-46D7-B497-668477F41CF4@gmail.com> (message from Yuan Fu on Sat, 20 Apr 2024 20:47:29 -0700) Subject: Re: bug#70478: 30.0.50; [PATCH] Fix treesitter-font-lock-settings for built-in functions and attributes. References: <86le58a7dv.fsf@gnu.org> <86edb0a3bq.fsf@gnu.org> <7587CCB2-559E-46D7-B497-668477F41CF4@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70478 Cc: ps.prateek.sharma143@gmail.com, 70478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Yuan Fu > Date: Sat, 20 Apr 2024 20:47:29 -0700 > Cc: Eli Zaretskii , > 70478@debbugs.gnu.org > > > On Sat, Apr 20, 2024 at 1:11 PM Eli Zaretskii wrote: > > > From: Prateek Sharma > > > Date: Sat, 20 Apr 2024 12:25:24 +0530 > > > Cc: Yuan Fu , 70478@debbugs.gnu.org > > > > > > Also should I squash the changes of both the above commits into one and then create a patch file? > > > > You should squash, yes. Other than that, attaching the patches as you > > did is fine. > > > > Thanks. > > <0001-Fix-treesitter-font-lock-settings-for-built-in-funct.patch> > > Thanks! Should I apply this to master or emacs-29? It’s a fix so I think emacs-29? Yes, emacs-29 is fine. From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 21 19:40:17 2024 Received: (at 70478) by debbugs.gnu.org; 21 Apr 2024 23:40:17 +0000 Received: from localhost ([127.0.0.1]:45250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rygnB-0004G4-EB for submit@debbugs.gnu.org; Sun, 21 Apr 2024 19:40:17 -0400 Received: from mail-ot1-x32f.google.com ([2607:f8b0:4864:20::32f]:52733) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rygn8-0004F4-Ak for 70478@debbugs.gnu.org; Sun, 21 Apr 2024 19:40:16 -0400 Received: by mail-ot1-x32f.google.com with SMTP id 46e09a7af769-6eb797e10ceso2375236a34.1 for <70478@debbugs.gnu.org>; Sun, 21 Apr 2024 16:39:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713742793; x=1714347593; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8ihJF7129D/5VCU6PqDAqasebIa5REw+k5nHc/CU1to=; b=RpVxy1VjgNClDP3nrrSsS3VfRFhLzdq+znzXaJpjur342QJdaLYcL7q0mAlksz/sKf p5DK4y2w8RfWSfbvnnBd4YyxqJ0oC4vCSKh8w3291ARgn6fsVP4+Jdf/1CDQyCKR0U// 2JWR4UmbfwxN5NXlVOXOnlRXpoDwFfcARg0+0MsLkuMrD0AEKFDhK/amMtOrVznNm22S 1MAyw5f/kTumqew+7w5zCGE/6Rhm5/tydnRKuV3pZKiVbf1CqnXJpC4EhNTkhtnHZvcR vkuFKXzv3VS98q6MBreSUwk82tC5BdtMm2gA8B+KiGmyZ+DgObW1SkD3DdDUhVZVv7O1 s/CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713742793; x=1714347593; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8ihJF7129D/5VCU6PqDAqasebIa5REw+k5nHc/CU1to=; b=Ou/3dzwR/9CR0t85WvyuWAx4PjclLS6tyUBdH8PSvXRH3XoHFG6CpdHDULufezONtA RP70lrBW5Bs76P8TAuC78+CTWQEbrEk/CU3rx65JSCKzCPjgWrDxV/RA6PcH5NUAMDgD bGp8agMLE+Bvy8uxrEMUUFUfaOlaDOd8k7tKHdz6GUsTLJmnKXeHdFWW0Upj5YHaqG/j FYJlvaFIULphM5wKJO7w7o2PS8iJfximSeS6n0I+JltFIiU2rRTU/yBW/0EtoAiIxHKV EWLaeljeqitHDF492fTMX/Was+QObDLClBFrwv2TCYvcSnyeoAD2uH/AAF4hdj0C+pql frgw== X-Forwarded-Encrypted: i=1; AJvYcCVmjWshOtxmuY9hADOyM9k5R3wlm2kPkaTIFvBssU2UDmr5Mey+PqzuLrqEh0fnRsWXozomGCV3pWewf6iEOEUyoiz5CDE= X-Gm-Message-State: AOJu0YwYLtMQ6oxZw5wmJrnaFJcRxF4DJVNwYvCB/8EPRYZJT6Gf1pHX UQ/IPK6pJ7zjvTmY48J3PQn8JY63lat1aVa8u0kJUlKuw7xATIH5 X-Google-Smtp-Source: AGHT+IGO8p3anqwp3wy5W/Gf4w/B9+ZTsMVtrZCYrg7xX7in6K5CC0I1ZxaaPzj3SApH4EM6j9e8xw== X-Received: by 2002:a05:6830:e89:b0:6eb:e1ba:6648 with SMTP id dp9-20020a0568300e8900b006ebe1ba6648mr5762353otb.1.1713742792877; Sun, 21 Apr 2024 16:39:52 -0700 (PDT) Received: from smtpclient.apple ([2601:641:300:4910:e4f6:f0b8:c91d:e40b]) by smtp.gmail.com with ESMTPSA id z23-20020a656657000000b005f8072699e1sm3299639pgv.45.2024.04.21.16.39.51 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 Apr 2024 16:39:52 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6.1.1\)) Subject: Re: bug#70478: 30.0.50; [PATCH] Fix treesitter-font-lock-settings for built-in functions and attributes. From: Yuan Fu In-Reply-To: <86a5ln8ev5.fsf@gnu.org> Date: Sun, 21 Apr 2024 16:39:40 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <86le58a7dv.fsf@gnu.org> <86edb0a3bq.fsf@gnu.org> <7587CCB2-559E-46D7-B497-668477F41CF4@gmail.com> <86a5ln8ev5.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3731.700.6.1.1) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70478 Cc: Prateek Sharma , 70478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Apr 20, 2024, at 10:27 PM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Sat, 20 Apr 2024 20:47:29 -0700 >> Cc: Eli Zaretskii , >> 70478@debbugs.gnu.org >>=20 >>> On Sat, Apr 20, 2024 at 1:11=E2=80=AFPM Eli Zaretskii = wrote: >>>> From: Prateek Sharma >>>> Date: Sat, 20 Apr 2024 12:25:24 +0530 >>>> Cc: Yuan Fu , 70478@debbugs.gnu.org >>>>=20 >>>> Also should I squash the changes of both the above commits into one = and then create a patch file? >>>=20 >>> You should squash, yes. Other than that, attaching the patches as = you >>> did is fine. >>>=20 >>> Thanks. >>> <0001-Fix-treesitter-font-lock-settings-for-built-in-funct.patch> >>=20 >> Thanks! Should I apply this to master or emacs-29? It=E2=80=99s a fix = so I think emacs-29? >=20 > Yes, emacs-29 is fine. Merged. BTW, Prateek, make sure to wrap the title and body of the commit = message, and not end the title with a period. =F0=9F=98=8A Yuan= From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 21 20:05:17 2024 Received: (at control) by debbugs.gnu.org; 22 Apr 2024 00:05:17 +0000 Received: from localhost ([127.0.0.1]:45272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryhBN-0007TY-D5 for submit@debbugs.gnu.org; Sun, 21 Apr 2024 20:05:17 -0400 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]:55440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryhBI-0007SM-Vt for control@debbugs.gnu.org; Sun, 21 Apr 2024 20:05:15 -0400 Received: by mail-pf1-x42a.google.com with SMTP id d2e1a72fcca58-6edc61d0ff6so3843413b3a.2 for ; Sun, 21 Apr 2024 17:04:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713744291; x=1714349091; darn=debbugs.gnu.org; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:from:to:cc:subject:date:message-id:reply-to; bh=AwZyn33IACIppV++Vls40FPdl8bCxszKtA7755fCeKU=; b=K92Dd3Owv0nam0IJRt2iJXqGhSFHzjSocXK6RMl9LOKJ8+CDMH4ZTAWD4pOkTrCdib 3CXtYqucZjM5XlwrXFJ2zFBGCcTZU6IIcvmPKpd80t54Hjnb8yPhbql9HCUw0OQUYEQ0 xzB7wyYf+g261CQ6+jj9MFxS1tJ/HQxzoacinq0ZmDZU1Y05JDXhrClAYteYeZdMXYjR SqaxTON9nIK0TxUoA9yy2kccR/iLwIzNpZDUz5GvgUvJxUhtLi1+dowwlzAPwri4pdSo TwNb1xtQSQVkavePQpZ2KbU4wyFav4dTF5DNtdORjDrVkpotkeyx0s50fUe5yhrHVsOU PKRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713744291; x=1714349091; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AwZyn33IACIppV++Vls40FPdl8bCxszKtA7755fCeKU=; b=cWCsmn8mRQ2euYKgaI4Z0E4kNfWrcYjTvB5ZC5XD7x+g1pyF4vgE+mK5MZv+0h0Y0p tH2LblHkP1+4KQCFzOKbDo5v9ZVgZ3PDPxREKxodd73YJaDSemzBG8T+Zu5oYp05Kmnm ldxdgBPV7kXnNu3C7TmteuCKlX+Ww/CaEtpLyrL2Kmua6tnFVDV9P8dZoeKmm3ylO10d Ki3EYSbE/eX2yjH8xlUi3epBcCAeMjlnk+6Ylf6f1tRY+07o94dLQ/YLw/7lFDcOkT59 R5lj4bMy+sHuZAXmURnqbe6pU+lOEswFd1NFtRR7HjJsHLEB5890Tr9AnKZDNYtKdON4 7aZQ== X-Gm-Message-State: AOJu0YyN8YkOmvAgL3p2lEzLc4SMasCWQp0sRlkjyRw9MTYmK688R0tP RuYsFMC8Fk0cXP7TbWTL4VYQ++IpuoMG3SkW6FJ7S92k+epc5UaAeJ6/eA== X-Google-Smtp-Source: AGHT+IF0v6cwdcJNVWl+RTGQ4IBrrzm3+udFshLvMmQ8FGvRULQjO9BEJ4/yik0MbJJrrRxNYBD/YQ== X-Received: by 2002:a05:6a20:2d09:b0:1ac:e379:5548 with SMTP id g9-20020a056a202d0900b001ace3795548mr8478896pzl.45.1713744291097; Sun, 21 Apr 2024 17:04:51 -0700 (PDT) Received: from smtpclient.apple ([2601:641:300:4910:e4f6:f0b8:c91d:e40b]) by smtp.gmail.com with ESMTPSA id 17-20020a056a00073100b006eadc87233dsm6625894pfm.165.2024.04.21.17.04.50 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 Apr 2024 17:04:50 -0700 (PDT) From: Yuan Fu Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6.1.1\)) Subject: control message for bug #70478 Message-Id: Date: Sun, 21 Apr 2024 17:04:40 -0700 To: control@debbugs.gnu.org X-Mailer: Apple Mail (2.3731.700.6.1.1) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 70478 30.1 quit From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 21 22:29:46 2024 Received: (at 70478) by debbugs.gnu.org; 22 Apr 2024 02:29:46 +0000 Received: from localhost ([127.0.0.1]:45304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryjR8-0001ry-8t for submit@debbugs.gnu.org; Sun, 21 Apr 2024 22:29:46 -0400 Received: from mail-vk1-xa34.google.com ([2607:f8b0:4864:20::a34]:54445) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryjR2-0001qb-7u for 70478@debbugs.gnu.org; Sun, 21 Apr 2024 22:29:40 -0400 Received: by mail-vk1-xa34.google.com with SMTP id 71dfb90a1353d-4dabbf19e1eso1129690e0c.0 for <70478@debbugs.gnu.org>; Sun, 21 Apr 2024 19:29:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713752955; x=1714357755; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=nY3unlh1YgGkPUMWcp9COhg1hobuJaWi09ct00DV1ws=; b=DitduYnvov5Yw/R/yp1Rnzke0dZQv5doaPLFSwqFCikL6QXXswiN6ggDWNUlSnZ1Q3 U8vvU2Yguu9iIY2plswcKQLaMwqGnu3Z3Geqp01wS4U+hP3nvM2Y1LJTXxSNPncTwiWs Tfu/GbiKscWtOIj2wV9Li7T21MhDm0kC/edKzb/jQm2uO3TN/PwrUHRUJ0rXGX02fEmY 70YuEcQClRO4pC74ID+/5miWIuWiFbM4zvRckQWTH0eD48NFTzh+nSd5rsvKWEiLIdcq Tq0ZbWti5p3Mc1+n/+OcadvULs0B4rY6YBj+OgkEBSvrTxZU+NwNELrqNoUDCUeXPWBq pJAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713752955; x=1714357755; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nY3unlh1YgGkPUMWcp9COhg1hobuJaWi09ct00DV1ws=; b=hoSfGIgsK180eb4HhdCa1FAkKU1eSMt+uqWf73+QWcJlXrfc4t1dNmv6IHntN3/pE6 cDohn+NOUBcQLGfqoHGhSXeeKrr4gubXIni6GuQUejPtnEnanYj/Gp71HV0lzrKbJODh RWexEckWclbUerqy6d8bylD+2xCeF2QGlR0DmiuwxznLGuDCavB6IP/4wc7xhjYuMz1K T3WTSXsOm9LY5q0YyvFhWepnZiGjWH0OiQGvpkii/7LYTwX4XFHt2des/pX5LNf/E8q5 jxxShj8BjveaigcCAX3UH1KViF6tyrOVyWWl5p1fovog8cjPNgdLJgubE9POqzADaPTX DzRA== X-Forwarded-Encrypted: i=1; AJvYcCW4lnF3CfaLu0gO8Rqo8mK/wJtpfQRs4qzifjmgJ6rlR6ZEafzmNF/YSGoa4Kvl/ra5rkRCDD98mL+XGqltUtWkZbdfE7s= X-Gm-Message-State: AOJu0YwA77dwwEhfL2K2ynPa2fo0iy+IIr5Qp+vsfxbWHrdLtmfbCT2z XfRPXDgYJS8KtrBhFkeLCKgk6ds7EzlyUfhhWtEkcWbhjt+jnz5ZJHvKJ+AhPTMgHNnIxPdgS7Q FwInUU7gW2WniMztRH8q7gJHkLlQ= X-Google-Smtp-Source: AGHT+IF8P8Vvy1wBXe0Z5pouvD+pzFyk5Oipl5mM94quB0vEVABL/gplz/3fRWJq9FHVCemVdHba4fKOGfbqCw4OpwU= X-Received: by 2002:a05:6122:ca0:b0:4da:9a90:a6f2 with SMTP id ba32-20020a0561220ca000b004da9a90a6f2mr10296381vkb.10.1713752954802; Sun, 21 Apr 2024 19:29:14 -0700 (PDT) MIME-Version: 1.0 References: <86le58a7dv.fsf@gnu.org> <86edb0a3bq.fsf@gnu.org> <7587CCB2-559E-46D7-B497-668477F41CF4@gmail.com> <86a5ln8ev5.fsf@gnu.org> In-Reply-To: From: Prateek Sharma Date: Mon, 22 Apr 2024 07:59:03 +0530 Message-ID: Subject: Re: bug#70478: 30.0.50; [PATCH] Fix treesitter-font-lock-settings for built-in functions and attributes. To: Yuan Fu Content-Type: multipart/mixed; boundary="0000000000001ab0b90616a6349f" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 70478 Cc: Eli Zaretskii , 70478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --0000000000001ab0b90616a6349f Content-Type: multipart/alternative; boundary="0000000000001ab0b80616a6349d" --0000000000001ab0b80616a6349d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Yuan, do you mean like this in the attached file? On Mon, Apr 22, 2024 at 5:09=E2=80=AFAM Yuan Fu wrote: > > > > On Apr 20, 2024, at 10:27 PM, Eli Zaretskii wrote: > > > >> From: Yuan Fu > >> Date: Sat, 20 Apr 2024 20:47:29 -0700 > >> Cc: Eli Zaretskii , > >> 70478@debbugs.gnu.org > >> > >>> On Sat, Apr 20, 2024 at 1:11=E2=80=AFPM Eli Zaretskii = wrote: > >>>> From: Prateek Sharma > >>>> Date: Sat, 20 Apr 2024 12:25:24 +0530 > >>>> Cc: Yuan Fu , 70478@debbugs.gnu.org > >>>> > >>>> Also should I squash the changes of both the above commits into one > and then create a patch file? > >>> > >>> You should squash, yes. Other than that, attaching the patches as yo= u > >>> did is fine. > >>> > >>> Thanks. > >>> <0001-Fix-treesitter-font-lock-settings-for-built-in-funct.patch> > >> > >> Thanks! Should I apply this to master or emacs-29? It=E2=80=99s a fix = so I > think emacs-29? > > > > Yes, emacs-29 is fine. > > Merged. BTW, Prateek, make sure to wrap the title and body of the commit > message, and not end the title with a period. =F0=9F=98=8A > > Yuan --0000000000001ab0b80616a6349d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Yuan, do you mean like this in the attached file?
On Mon, A= pr 22, 2024 at 5:09=E2=80=AFAM Yuan Fu <casouri@gmail.com> wrote:


> On Apr 20, 2024, at 10:27 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> From: Yuan Fu <casouri@gmail.com>
>> Date: Sat, 20 Apr 2024 20:47:29 -0700
>> Cc: Eli Zaretskii <eliz@gnu.org>,
>> 70478@d= ebbugs.gnu.org
>>
>>> On Sat, Apr 20, 2024 at 1:11=E2=80=AFPM Eli Zaretskii <eliz@gnu.org> wrote: >>>> From: Prateek Sharma <ps.prateek.sharma143@gmail.com> >>>> Date: Sat, 20 Apr 2024 12:25:24 +0530
>>>> Cc: Yuan Fu <casouri@gmail.com>, 70478@debbugs.gnu.org
>>>>
>>>> Also should I squash the changes of both the above commits= into one and then create a patch file?
>>>
>>> You should squash, yes.=C2=A0 Other than that, attaching the p= atches as you
>>> did is fine.
>>>
>>> Thanks.
>>> <0001-Fix-treesitter-font-lock-settings-for-built-in-funct.= patch>
>>
>> Thanks! Should I apply this to master or emacs-29? It=E2=80=99s a = fix so I think emacs-29?
>
> Yes, emacs-29 is fine.

Merged. BTW, Prateek, make sure to wrap the title and body of the commit me= ssage, and not end the title with a period. =F0=9F=98=8A

Yuan
--0000000000001ab0b80616a6349d-- --0000000000001ab0b90616a6349f Content-Type: application/octet-stream; name="0001-Fix-treesitter-font-lock-settings-for-built-in-funct.patch" Content-Disposition: attachment; filename="0001-Fix-treesitter-font-lock-settings-for-built-in-funct.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lvac8b3g0 RnJvbSA2YjhlMTU1YTZmYzkxN2ViNjQ0YTMyYzA2ZmE3MzgzYThjYmY0N2I5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQcmF0ZWVrIFNoYXJtYSA8cHMucHJhdGVlay5zaGFybWExNDNA Z21haWwuY29tPgpEYXRlOiBTYXQsIDIwIEFwciAyMDI0IDAyOjA2OjE3ICswNTMwClN1YmplY3Q6 IFtQQVRDSF0gRml4IHRyZWVzaXR0ZXItZm9udC1sb2NrLXNldHRpbmdzIGZvciBidWlsdC1pbgog ZnVuY3Rpb25zIGFuZCBhdHRyaWJ1dGVzCgoqIGxpc3AvcHJvZ21vZGVzL3B5dGhvbi5lbCAocHl0 aG9uLS10cmVlc2l0LXNldHRpbmdzKTogQ2hhbmdlIHRoZQogIHRyZWVzaXR0ZXIgcXVlcnkgdG8g ZmV0Y2ggdGhlIGNvcnJlY3QgdHlwZSBvZiBub2RlIGZvciBidWlsdC1pbgogIGZ1bmN0aW9ucyBh bmQgYXR0cmlidXRlcyBhbmQgaGlnaGxpZ2h0IHRoZW0gd2l0aCBjb3JyZXNwb25kaW5nCiAgZm9u dC1sb2NrIGZhY2UuCi0tLQogbGlzcC9wcm9nbW9kZXMvcHl0aG9uLmVsIHwgMTYgKysrKysrKysr LS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9saXNwL3Byb2dtb2Rlcy9weXRob24uZWwgYi9saXNwL3Byb2dtb2Rlcy9w eXRob24uZWwKaW5kZXggODUyNzlkM2U4NGIuLmQ2YzI5ZTVmZmM2IDEwMDY0NAotLS0gYS9saXNw L3Byb2dtb2Rlcy9weXRob24uZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvcHl0aG9uLmVsCkBAIC0x MjA2LDEzICsxMjA2LDE1IEBAIGZvbnRpZmllZC4iCiAKICAgIDpmZWF0dXJlICdidWlsdGluCiAg ICA6bGFuZ3VhZ2UgJ3B5dGhvbgotICAgYCgoKGlkZW50aWZpZXIpIEBmb250LWxvY2stYnVpbHRp bi1mYWNlCi0gICAgICAoOm1hdGNoICwocngtdG8tc3RyaW5nCi0gICAgICAgICAgICAgICAgYChz ZXEgYm9sCi0gICAgICAgICAgICAgICAgICAgICAgKG9yICxAcHl0aG9uLS10cmVlc2l0LWJ1aWx0 aW5zCi0gICAgICAgICAgICAgICAgICAgICAgICAgICxAcHl0aG9uLS10cmVlc2l0LXNwZWNpYWwt YXR0cmlidXRlcykKLSAgICAgICAgICAgICAgICAgICAgICBlb2wpKQotICAgICAgICAgICAgICBA Zm9udC1sb2NrLWJ1aWx0aW4tZmFjZSkpKQorICAgYCgoY2FsbCBmdW5jdGlvbjogKGlkZW50aWZp ZXIpIEBmb250LWxvY2stYnVpbHRpbi1mYWNlCisgICAgICAgICAgICg6bWF0Y2ggLChyeC10by1z dHJpbmcKKyAgICAgICAgICAgICAgICAgICAgIGAoc2VxIGJvbCAob3IgLEBweXRob24tLXRyZWVz aXQtYnVpbHRpbnMpIGVvbCkpCisgICAgICAgICAgICAgICAgICAgQGZvbnQtbG9jay1idWlsdGlu LWZhY2UpKQorICAgICAoYXR0cmlidXRlIGF0dHJpYnV0ZTogKGlkZW50aWZpZXIpIEBmb250LWxv Y2stYnVpbHRpbi1mYWNlCisgICAgICAgICAgICAgICAgKDptYXRjaCAsKHJ4LXRvLXN0cmluZwor ICAgICAgICAgICAgICAgICAgICAgICAgICBgKHNlcSBib2wKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgKG9yICxAcHl0aG9uLS10cmVlc2l0LXNwZWNpYWwtYXR0cmlidXRlcykgZW9s KSkKKyAgICAgICAgICAgICAgICAgICAgICAgIEBmb250LWxvY2stYnVpbHRpbi1mYWNlKSkpCiAK ICAgIDpmZWF0dXJlICdkZWNvcmF0b3IKICAgIDpsYW5ndWFnZSAncHl0aG9uCi0tIAoyLjM5LjMg KEFwcGxlIEdpdC0xNDYpCgo= --0000000000001ab0b90616a6349f-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 22 02:29:00 2024 Received: (at 70478) by debbugs.gnu.org; 22 Apr 2024 06:29:00 +0000 Received: from localhost ([127.0.0.1]:45537 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rynAi-0002yl-1w for submit@debbugs.gnu.org; Mon, 22 Apr 2024 02:29:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rynAd-0002xD-1d for 70478@debbugs.gnu.org; Mon, 22 Apr 2024 02:28:57 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rynAH-00037v-HZ; Mon, 22 Apr 2024 02:28:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=lIk25dNNsczXLYhE0171GpDb8iOKlWBghhSZUTMKD+c=; b=WgAfphAGGEPrigMtyH2k Vpa/Zk2s9oKSn+SH6bQRCtXRmX5P4vUtPKWTbLvPpHebefFDxajZasAZ5brHImsHNq9UnP/8BQf76 E//6CD5Bu5eesLao2MTqX2pMyWErN5XJKprGlcGFnKtuQ8kBbii1Bqbdq/5d1ULfGc5Ryn9V2JF3P NHpn2/lRpl42VdgpV0Y5ZScIL7byIgF73lpYjOaB/hbHg1XkNdUS0d/UY2HfujxLnDNiw6Ahe03vD CHa2nia1Z2LhplsBbVcRIGvDbrktQid51R4GadHKYmMnLzjYaQsjcCKdAS4SamCp/wL1n2EeizmCS 6zqFw03QIzjXcg==; Date: Mon, 22 Apr 2024 09:28:30 +0300 Message-Id: <867cgp7vxt.fsf@gnu.org> From: Eli Zaretskii To: Yuan Fu In-Reply-To: (message from Yuan Fu on Sun, 21 Apr 2024 16:39:40 -0700) Subject: Re: bug#70478: 30.0.50; [PATCH] Fix treesitter-font-lock-settings for built-in functions and attributes. References: <86le58a7dv.fsf@gnu.org> <86edb0a3bq.fsf@gnu.org> <7587CCB2-559E-46D7-B497-668477F41CF4@gmail.com> <86a5ln8ev5.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70478 Cc: ps.prateek.sharma143@gmail.com, 70478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Yuan Fu > Date: Sun, 21 Apr 2024 16:39:40 -0700 > Cc: Prateek Sharma , > 70478@debbugs.gnu.org > > > Yes, emacs-29 is fine. > > Merged. BTW, Prateek, make sure to wrap the title and body of the commit message, and not end the title with a period. 😊 Did you forget to push? From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 22 02:34:53 2024 Received: (at 70478) by debbugs.gnu.org; 22 Apr 2024 06:34:53 +0000 Received: from localhost ([127.0.0.1]:45543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rynGO-0003aD-1Z for submit@debbugs.gnu.org; Mon, 22 Apr 2024 02:34:53 -0400 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]:47245) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rynGL-0003ZJ-UY for 70478@debbugs.gnu.org; Mon, 22 Apr 2024 02:34:50 -0400 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-1e9320c2ef6so8383575ad.2 for <70478@debbugs.gnu.org>; Sun, 21 Apr 2024 23:34:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713767668; x=1714372468; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=z4nXNLoSDHIK+t3ybWI3kJl6PMNAk2aY6wJKMgDxC0c=; b=lfzRD2jwm6yZ7or7uaESoCu8M0I8HXqmOW49goclAmLjrBpJgRNEGchWFkNOvVuTiH t0wHKGagbKsc2ayEItyCJuZIIVZxQ9ZFb/cJaPMjn7ZaSCMRbM+tL/kaAZLqNy9jKd9/ vQo4jS/ystKruCW5HpBfXAUIlrgaKrPgDzCd2u2RwX4aY4cpNwxiGuhfBeqnjOHeW0jB +fOTrW/H4CxAc7YZuhsO/rtn4mVA0I4CRWyywrJ4i7nstcoxrZwh2p3NbnDB55MyuzW3 NOY6NE73a37fGZEu/zdQOJrMc4pYAqpuWxtULxkRLNrokWPV1lXGDU/N1MY0by2ge5ah FATw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713767668; x=1714372468; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z4nXNLoSDHIK+t3ybWI3kJl6PMNAk2aY6wJKMgDxC0c=; b=JIO3oZKQyFXqhcqSEDpdNTWtGmNteJsBRmccEpiTLlBN5T8KcCQUTVVp6wehMzQbsI Go7Al5reorSgMLePj7mfktzIheEoGgNArmL0x3X5SjIdPXANayRzhO45dRpsPyznFUQK /k3crnLI2TvDSNAlim2MOmFqn03GDjRL2TvizfpYIo/XeUQDgjIoLjycxYsxoFVoT3dW LGpRTsVtBfL4WYFtuThKvVRQjcgGdbqznPxQk2/y3Jta3AIwb2Rk0QRFwvCXx9v3gL1t /xN79xGrYuOxrjqBJTIyl9PwvtCnCUi559009Mc9E93SL7VSRmgIaQiLfUocoKSJuabH FRHQ== X-Forwarded-Encrypted: i=1; AJvYcCUD1gariDX4VzKSPtCGaMcM7mb9QvqAKMAgFhCp5GbOcyI8nz+VtU9H++BkEOABkyWBDgkaMbkMxjCLdy3mMLFFXyAOzCI= X-Gm-Message-State: AOJu0YxLixTZqljQYIK8JFrXd01zjRbA01VrHh6aLQ9HF45z87rQr/gf Ch+q/jpR07QeCO3mtfBj/19d7sSRebElp43pnAkyuARZGkv9+QRx X-Google-Smtp-Source: AGHT+IEncwukSkES7/KgFSCDc9JG/ARc3lGB8Xmus3/dpTt0Nqopv/fDxftR/TIWxXTQ934OeP5arA== X-Received: by 2002:a17:902:ea11:b0:1e4:b1ea:23ef with SMTP id s17-20020a170902ea1100b001e4b1ea23efmr11089340plg.49.1713767668328; Sun, 21 Apr 2024 23:34:28 -0700 (PDT) Received: from smtpclient.apple ([2601:641:300:4910:e4f6:f0b8:c91d:e40b]) by smtp.gmail.com with ESMTPSA id h3-20020a170902680300b001e26c4823d0sm7455771plk.52.2024.04.21.23.34.27 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 Apr 2024 23:34:27 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6.1.1\)) Subject: Re: bug#70478: 30.0.50; [PATCH] Fix treesitter-font-lock-settings for built-in functions and attributes. From: Yuan Fu In-Reply-To: <867cgp7vxt.fsf@gnu.org> Date: Sun, 21 Apr 2024 23:34:16 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <86le58a7dv.fsf@gnu.org> <86edb0a3bq.fsf@gnu.org> <7587CCB2-559E-46D7-B497-668477F41CF4@gmail.com> <86a5ln8ev5.fsf@gnu.org> <867cgp7vxt.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3731.700.6.1.1) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70478 Cc: Prateek Sharma , 70478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Apr 21, 2024, at 11:28 PM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Sun, 21 Apr 2024 16:39:40 -0700 >> Cc: Prateek Sharma , >> 70478@debbugs.gnu.org >>=20 >>> Yes, emacs-29 is fine. >>=20 >> Merged. BTW, Prateek, make sure to wrap the title and body of the = commit message, and not end the title with a period. =F0=9F=98=8A >=20 > Did you forget to push? Forgot I did, sorry about the hiccup. Pushed now. Yuan= From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 22 02:37:13 2024 Received: (at 70478) by debbugs.gnu.org; 22 Apr 2024 06:37:14 +0000 Received: from localhost ([127.0.0.1]:45547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rynIe-0003pK-Ou for submit@debbugs.gnu.org; Mon, 22 Apr 2024 02:37:13 -0400 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]:45328) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rynIc-0003oJ-LO for 70478@debbugs.gnu.org; Mon, 22 Apr 2024 02:37:11 -0400 Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-6eff9dc1821so3965669b3a.3 for <70478@debbugs.gnu.org>; Sun, 21 Apr 2024 23:36:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713767809; x=1714372609; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=cSZlkmx2GXQQofDYUDZBCWSkl81PeAwEx3Bwe7PIl58=; b=W49Xo2HVg2ckAPx22ARzTOlaHIFEZgayEFPcqkU8hPjub+9WUzP48PiyewZtGER1Lh hgEAO1PnBUNLBxDbNrxGtoFwbEtJicy5+00HzgS3Mme7rjl8fvSQsdt9R+L3NHdr/AXp rkIZQclYo4K+BDnzmMdnmrth2/WWQOE8KhpDbPu2mIpj4hgu8P/lhE73F5ZCfBw/q3zN YBg+Jt+1hHLI+sTpOTyug2QJ3/mhar9n3WPGCd7RH+l7nXer3UxMUAFFd/vwupNafZpS DaJeoZpR8iqNUJf9OcHtMfFxzPj03bxiELxsw38wVPoQTbR+cUOEXF065SuAlpwq2Q5D 9GmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713767809; x=1714372609; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cSZlkmx2GXQQofDYUDZBCWSkl81PeAwEx3Bwe7PIl58=; b=Wa/RuIDHXSnlhuwUNgjVegPJusQ8J0PpbgOHpW9yMJNCrrDY1sej5nOVdvlVXpJP1B QQ9rYC/LMzDbFuNTvtta0TmYpjcCp5BBixoBFKz7TRKcAiIXaM/ikeFvYHm8QoGV1v1o l5pcnVDm+0mKmEOb8C5IpGKwNOknSllo+QCu3TluTVgi7s9IX0WJiH95ARwTKcmWhI0x ADwAh0VcuZsbx+1mD+6oL5euJH7fnixoKdo2TLbO1cHmnPIUO2hBH0u9tQfiznU8Tfco Ou37qdYzgyS11T8s261lWsvchU7okSx5RiM8C5u1xqArOaK3UXYBPABHrVIF+ckV+uHy yhbA== X-Forwarded-Encrypted: i=1; AJvYcCW9b6wQt8HneX0n7cYRCDWUY23NRkCJAQ/Ym2PgcEwi6E9+PF0SqurQI/p+Ru5g0u3bYdyD9FAVHKjd1JjIKhxXSL7TT1Y= X-Gm-Message-State: AOJu0YyWzZ3wz+6IwOmTI2FIS7nIbneDdJC65gNeVc/tyY+6Hq+bylSq 8wa+7rl4dRXqBPER6mgWO9+ek7zb15+J2YVy+Auw1nwFA7u3fpHYH/TDnQ== X-Google-Smtp-Source: AGHT+IHSBCHJVwvMOQS15uwJUWTv2Z5uebmKaPmxgjW0UIFy/xIp0s/rLHg9nOFA3QNaXi87Z5pDkA== X-Received: by 2002:a05:6a00:1413:b0:6e7:20a7:9fc0 with SMTP id l19-20020a056a00141300b006e720a79fc0mr10066807pfu.34.1713767808826; Sun, 21 Apr 2024 23:36:48 -0700 (PDT) Received: from smtpclient.apple ([2601:641:300:4910:e4f6:f0b8:c91d:e40b]) by smtp.gmail.com with ESMTPSA id 3-20020a631943000000b005df41b00ee9sm6809553pgz.68.2024.04.21.23.36.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 Apr 2024 23:36:48 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6.1.1\)) Subject: Re: bug#70478: 30.0.50; [PATCH] Fix treesitter-font-lock-settings for built-in functions and attributes. From: Yuan Fu In-Reply-To: Date: Sun, 21 Apr 2024 23:36:37 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <86le58a7dv.fsf@gnu.org> <86edb0a3bq.fsf@gnu.org> <7587CCB2-559E-46D7-B497-668477F41CF4@gmail.com> <86a5ln8ev5.fsf@gnu.org> To: Prateek Sharma X-Mailer: Apple Mail (2.3731.700.6.1.1) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70478 Cc: Eli Zaretskii , 70478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Apr 21, 2024, at 7:29 PM, Prateek Sharma = wrote: >=20 > Yuan, do you mean like this in the attached file? Exactly! I already amended and merged your patch. But next time you will = know how to write it ;-) Yuan= From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 22 11:51:13 2024 Received: (at 70478) by debbugs.gnu.org; 22 Apr 2024 15:51:13 +0000 Received: from localhost ([127.0.0.1]:46516 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryvwl-0007xU-V7 for submit@debbugs.gnu.org; Mon, 22 Apr 2024 11:51:12 -0400 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]:55763) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryvwf-0007ve-6K for 70478@debbugs.gnu.org; Mon, 22 Apr 2024 11:51:09 -0400 Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-6ecec796323so4693926b3a.3 for <70478@debbugs.gnu.org>; Mon, 22 Apr 2024 08:50:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713801043; x=1714405843; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YpK9R0kmyci1nI38Ej3fWHQsEhVVfwfMJKTvoGFqPuI=; b=S7JoI5ER2yXpundSkW8XJ8l40vaFI2CrP0gS4cmiYX8vftYmhY0Oijbm6ltWPmdEcp omd/izDpNp8xXF9qzqWNtHvQhMMA610yjX9/NVA0+VTVTBWEQX6ZW8uWowlBDqvNuJr7 3EKRk+pKYIWgfSkzN1HxkQA4l0SfyxTNrXNHjlHFX30NaHx1gC8/EtMUPqsdUuAtQjrz X/cMITEjTOK3E4fEbK5PLmidunwwiJ7mhUOG/nd/x38aOYzuUjdcsnNnJXrCfZL7f+EA 4aunIRsjd4tEVKbzD2R9GAhYVr1TtjGJPzOvlaPaNZY7rftavqfAgmTEmcOHZaYdqEq1 FVaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713801043; x=1714405843; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YpK9R0kmyci1nI38Ej3fWHQsEhVVfwfMJKTvoGFqPuI=; b=C7q4HNgXeED4BvwSnLsNt9AnsFqW7fTPrsu03/Z4nA1aFbDbDsJAUsrfQb5X+j7vD5 ygsCo7QgYxWZBwpmZO5W2tirguABM6Ex2ODmy4XHbkKPr96A0Xa+sG7nHL2LLozLEIV3 k5nIxzBGGelMzqBIIa6ws2fjALcNXjngerSOic+0AM8M3gccbS1KRe/0zuH/IVI46kPS k8UJjWX2DZ2A/uNLhhg5aEJBh2mk8cq9lIFjRg7tWtD41axyqv2j2h+uFtggrBuYCX54 4SSm2oJjrwbP2kpvYC3u47DQkHvCob+i3Sqqe8TzPVKhW5K2lsoz/sNR6Nxuet5nE4Av TEQg== X-Gm-Message-State: AOJu0YzOEi9pQIVhZg7wwZvPS/bYVxFfWvp+nUVEVfZqkYpLniraC9Dv tndxzTIA2RPwkGlqs1diHWkgC5v+Ty3QS1mQcUYEr4zgkAKiS4Wj X-Google-Smtp-Source: AGHT+IFRjDM8bu+an1LB/5TMyVa38bKYfYnZY4pTUMCLBi48y3p6PdI++LX+ZcCmo2j2wy4Zu15iaw== X-Received: by 2002:a05:6a21:3945:b0:1a7:4b3f:a66c with SMTP id ac5-20020a056a21394500b001a74b3fa66cmr15095138pzc.49.1713801043091; Mon, 22 Apr 2024 08:50:43 -0700 (PDT) Received: from smtpclient.apple ([2601:641:300:4910:e4f6:f0b8:c91d:e40b]) by smtp.gmail.com with ESMTPSA id h6-20020a056a00170600b006e6b180d87asm7971143pfc.35.2024.04.22.08.50.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Apr 2024 08:50:42 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6.1.1\)) Subject: Re: bug#70478: 30.0.50; [PATCH] Fix treesitter-font-lock-settings for built-in functions and attributes. From: Yuan Fu In-Reply-To: Date: Mon, 22 Apr 2024 08:50:31 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <86le58a7dv.fsf@gnu.org> <86edb0a3bq.fsf@gnu.org> <7587CCB2-559E-46D7-B497-668477F41CF4@gmail.com> <86a5ln8ev5.fsf@gnu.org> To: Prateek Sharma X-Mailer: Apple Mail (2.3731.700.6.1.1) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70478 Cc: Eli Zaretskii , 70478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) [Adding debbugs back to CC] > On Apr 22, 2024, at 7:27 AM, Prateek Sharma = wrote: >=20 > Hi Yuan, I saw that it was merged into the emacs-29 branch but not in = master. I was wondering when we usually sync with master, like is there = a schedule? So that I know when to rebuild my emacs installation. > And thanks for guiding me through this. I also submitted the form for = copyright assignment to the mail id given in the CONTRIBUTE file, but = didn't get any response yet. Oops, we should=E2=80=99ve waited until your copyright assignment is = completed. Eli, should I revert the patch for now? Yuan= From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 22 12:19:15 2024 Received: (at 70478) by debbugs.gnu.org; 22 Apr 2024 16:19:15 +0000 Received: from localhost ([127.0.0.1]:46649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rywNv-0002dR-0k for submit@debbugs.gnu.org; Mon, 22 Apr 2024 12:19:15 -0400 Received: from mail-oi1-x235.google.com ([2607:f8b0:4864:20::235]:49263) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rywNs-0002cW-49 for 70478@debbugs.gnu.org; Mon, 22 Apr 2024 12:19:13 -0400 Received: by mail-oi1-x235.google.com with SMTP id 5614622812f47-3c70b652154so2498517b6e.2 for <70478@debbugs.gnu.org>; Mon, 22 Apr 2024 09:18:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713802730; x=1714407530; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=nQ9EAALRNtsMLR/6hNF4jzo550b8rOp+qJld3AYRay4=; b=iy8ZELW29msltq2sAMIsWb/tVVlEGe5tgSjziE/AsH0QyG3XXyPwIzvdErBHps3aPC K8oJBN91mTBmA31R5KqxlDTOB3eSQGMBeGgkzFUMgG0CRnF2AdLjyPpa/JV3i0RUVZgl dr6dX/kFVTkeTiwbLuPUI4K9yA4vuslUOfNxdVhC0RoYwDIzw0SHHtuDmdrwBzzf9Hi4 SMANemzyXa14C+Hzu6HW6IYp7FvItTbqxcp8C5PUbJAV7/an6RBHnIxsgjn9CEk2es3d +fcKlA840p54bkaG8/GN+m0Ag3clIY/0DPaz/8zIhuMfFgfBvNGGhbfo5AHXssh0Y1op uJzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713802730; x=1714407530; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nQ9EAALRNtsMLR/6hNF4jzo550b8rOp+qJld3AYRay4=; b=Z6UMmB8/G7q0q8lqGaptzufPuh0fvBK1QCQD77J32cuckzEeqGLSXcwo09UQCS8Yw5 wMIBeJzHkpEm6N4bT4aUmKamsG5jDnFY2Usxfbn1wJXhuobt5z6+dXVjDKqND1q9J4lG NZlYysJt2DfGIUhIhVLTRsJ31qsbea2LOxZ323E8X0dZ9doXjdTV1ZdBtHxqh/LiR0UC DyM837ZQfDN1p2HLEx2g1M4ZWRsTYUHWuns4KEabFuNttyiqe9rplMIapD46ow54YbQK Bg97cNL5OmQ4A7c1fik9tPYBr1HNSwp/1dy9/00Pj1iyrGsWSPFrs62LvekCcN7gmK5I S53g== X-Gm-Message-State: AOJu0Ywnu6OJIwCqq37SRG0qvt2o9AX8NOcZNTToilLz/eY9qmtSnROn MOof6b7pyMBrvIw8zNMnblidlnn6kzR56/tclgE0FZtMxA3SoiQgXZ4Dxw0RxNnWgyiZTe1Q/Kn rKI3qppYN1T9ouxA6OSu/zfooGOg= X-Google-Smtp-Source: AGHT+IHuDJ6A58w5r00ntsErXV4d3rttsO+icail8gbEQw15czuqzIUvwmcv7FNJKBpOmUgNaaoyV7TuZ0op9fl68Q8= X-Received: by 2002:a05:6808:200b:b0:3c8:2b32:276d with SMTP id q11-20020a056808200b00b003c82b32276dmr5972442oiw.0.1713802730472; Mon, 22 Apr 2024 09:18:50 -0700 (PDT) MIME-Version: 1.0 References: <86le58a7dv.fsf@gnu.org> <86edb0a3bq.fsf@gnu.org> <7587CCB2-559E-46D7-B497-668477F41CF4@gmail.com> <86a5ln8ev5.fsf@gnu.org> In-Reply-To: From: Prateek Sharma Date: Mon, 22 Apr 2024 21:48:39 +0530 Message-ID: Subject: Re: bug#70478: 30.0.50; [PATCH] Fix treesitter-font-lock-settings for built-in functions and attributes. To: Yuan Fu Content-Type: multipart/alternative; boundary="000000000000f7145e0616b1ca06" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 70478 Cc: Eli Zaretskii , 70478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --000000000000f7145e0616b1ca06 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Is that mandatory for a few lines of changes as well? I thought it's required for more than 12 lines of changes.I have submitted it, but didn't get any response yet. Is there any way that we can speed up the process? Prateek On Mon, Apr 22, 2024 at 9:20=E2=80=AFPM Yuan Fu wrote: > [Adding debbugs back to CC] > > > On Apr 22, 2024, at 7:27 AM, Prateek Sharma < > ps.prateek.sharma143@gmail.com> wrote: > > > > Hi Yuan, I saw that it was merged into the emacs-29 branch but not in > master. I was wondering when we usually sync with master, like is there a > schedule? So that I know when to rebuild my emacs installation. > > And thanks for guiding me through this. I also submitted the form for > copyright assignment to the mail id given in the CONTRIBUTE file, but > didn't get any response yet. > > Oops, we should=E2=80=99ve waited until your copyright assignment is comp= leted. > Eli, should I revert the patch for now? > > Yuan --000000000000f7145e0616b1ca06 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Is that mandatory for a few lines of changes as well? I th= ought it's required for more than 12 lines of changes.I have submitted = it, but didn't get any response yet. Is there any way that we can speed= up the process?

Prateek

On Mon, Apr 22, 2024 at 9:20=E2=80=AFPM Yuan= Fu <casouri@gmail.com> wrot= e:
[Adding debbu= gs back to CC]

> On Apr 22, 2024, at 7:27 AM, Prateek Sharma <ps.prateek.sharma143@gmail.co= m> wrote:
>
> Hi Yuan, I saw that it was merged into the emacs-29 branch but not in = master. I was wondering when we usually sync with master, like is there a s= chedule? So that I know when to rebuild my emacs installation.
> And thanks for guiding me through this. I also submitted the form for = copyright assignment to the mail id given in the CONTRIBUTE file, but didn&= #39;t get any response yet.

Oops, we should=E2=80=99ve waited until your copyright assignment is comple= ted. Eli, should I revert the patch for now?

Yuan
--000000000000f7145e0616b1ca06-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 22 12:22:13 2024 Received: (at 70478) by debbugs.gnu.org; 22 Apr 2024 16:22:13 +0000 Received: from localhost ([127.0.0.1]:46666 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rywQl-0002vz-Jt for submit@debbugs.gnu.org; Mon, 22 Apr 2024 12:22:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53282) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rywQh-0002uw-Ol for 70478@debbugs.gnu.org; Mon, 22 Apr 2024 12:22:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rywQK-0004rd-JU; Mon, 22 Apr 2024 12:21:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Subject:To:From: Date; bh=3ib76lGiDdEpEveOer0ZwnNxZDZCsTj6oEYz7ATLuEQ=; b=dzvZ5osSA3wItqiQoD0C RMxN4/uvvZrUX/skmUQztwnalYCXEw6QwpmS0wNTsjmM4BqlW0ONdxek6qxD7Z5q7znyTVK2+VFnP e+Bf6sXXcZOohZvDEn8RnQ9rzZwSycWXAbnBFOywz6aSYf2B5lAhqrDKSay18C98KsHHrWKaSUO7u K+cZ5a2xFzBunU3qlmjzSgbx1hCzT+qkXFCpWFrwvcHVH4T9QBqxhj2Iyhd22ajxdgdL0CQBvd65q ntVE4hXCmVg/rOAUIYSLbcyS+VX/A4FY2Wgl7/XPIKOpvUbRGQX3Nia+QF17Me7tPKTSxOpTHsvJN z8/XKXFIIHphzQ==; Date: Mon, 22 Apr 2024 19:21:41 +0300 From: Eli Zaretskii To: Yuan Fu , Prateek Sharma Subject: =?US-ASCII?Q?Re=3A_bug=2370478=3A_30=2E0=2E50=3B_=5BP?= =?US-ASCII?Q?ATCH=5D_Fix_treesitter-font-?= =?US-ASCII?Q?lock-settings_for_built-in_functions_and_attributes=2E?= User-Agent: K-9 Mail for Android In-Reply-To: References: <86le58a7dv.fsf@gnu.org> <86edb0a3bq.fsf@gnu.org> <7587CCB2-559E-46D7-B497-668477F41CF4@gmail.com> <86a5ln8ev5.fsf@gnu.org> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Autocrypt: addr=eliz@gnu.org; keydata= mQENBF+pf4UBCAC6vjkWLSAsQpe8YIGKLQzNOJx/IjGtCdFF8uzmO5jmME+SD8ROuJN+t5KXVw58 uzu75EFD0vHTY9e+udJ2gkpuy0NnzkFcbumdLLo2ERKCoSctZZRhzKXI5z5cHxCqW0B2ygHRrRLt oNlGID7bAgcgSViT1ptGqTXO7zGVu4Airok7dNzcPtHgns8GlR5YAFX0TvE6oGd0l2VPghNeVJKJ OjrbfhoDxl3ucFpqbqMH8z9HTLDOFpz8UaYYUdJMi3xX6vwTZxI2sM2RRVLUpZyllAkSMI4lln1O OgazM/62DJUs/rKIHKBnF6h3/qsJUjUYXaAHbrXY26mWllAd536lABEBAAG0I0VsaSBaYXJldHNr aWkgKGVsaXopIDxlbGl6QGdudS5vcmc+iQE4BBMBAgAiBQJfqX+FAhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgAAKCRCRwSYvAeuNOYUQB/4/iIKKOG45ijNaRoTvmJJZMvj1S07WQxEm7c5SHEeE QbLOAxB9vESOV7sLueuN3oqEndtzyYt4x1WTSBmHFF7h5fcCMjBs41siOIp5Sj/xD0Bvaa0IKGCR SZ7PAo8Mq3wgajXpTpn9vxE2PmtzA8KdEE0K1+f9pVAfOpUIcCl44rIxLUW352XG0y7iz6c/O6LB 1deOKMiKFctKO7pBti1dJEm1ImewLH3H8uTbwspLOs3EB8xhsESxmTidnze68HX2jt+2EeMgCdki NU+LWbexQZPfIS7+ZmE06ll0v6+Jy7ZdTkCCRypKWTnW7pIFsq/p4kybV8O/kHSV6B4vvQBfuQEN BF+pf4UBCACvFrdx/m22lgObypSmSS4TNlNvQnMUorrMmp0U32hv5adt6CKXeMjk05F+GcIfVMrp xqMBn4sEUIXWhhogQJa9ZbWEP/HbS8XjMMbz0Q0Siaty9+DSspK/9u2GWKsz3uQzLCexIJtzmXvj AVmvoMCAU/F2t038ggygjYLRgyLRNLgbbartu2dMkvrfxRjheip60S4S3utOcwUf/qdoa1grNann CFluHr/ftXCeeuGB4H8iO0BXWNby6NZPizxJttx9gdcH8/OmDOJkXyRMTT/3sSem76CSOjfXcz7s aJlg680NQhG5TmuYERjJD4+U02K5RuqTsEnOuWeFy4p+/mslABEBAAGJATYEGAECAAkFAl+pf4UC GwwAIQkQkcEmLwHrjTkWIQTmyQKcNjrUHXh6jruRwSYvAeuNOejsB/9rVegsfEBSRLjeeYXyJrOf dme7BYpYsQCw2vGTnrJTGFQ9HM2zT9+wAENBHWjQPJOptJwo5w4xIbZgwJy0uIN3sV18xbCRSxX0 ZSk8GJG0PrQTCaf2xs0kqsShnkvqyo5QSyUlFUAG7m1o7NUhF95Q89oxGO8JyvR356kqNbzUn0Cq PxKyS42QfC8dyFNgVhVPbZp6aONnUwY5SbtCLJtZCBgvppI9XaBH41BDukSE4GgSLoYsSIGShg4h e+bGypAsGtQ9uwmryUi1gRrDgca3wFo/G0rbJn2ZKoLbGFZivWPVgAgd9/O5sLSPFznOdcRGxEA2 gk7A1ReaJ10PtQz0 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70478 Cc: 70478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On April 22, 2024 6:50:31 PM GMT+03:00, Yuan Fu wrote= : > [Adding debbugs back to CC] >=20 > > On Apr 22, 2024, at 7:27 AM, Prateek Sharma wrote: > >=20 > > Hi Yuan, I saw that it was merged into the emacs-29 branch but not in = master=2E I was wondering when we usually sync with master, like is there a= schedule? So that I know when to rebuild my emacs installation=2E > > And thanks for guiding me through this=2E I also submitted the form fo= r copyright assignment to the mail id given in the CONTRIBUTE file, but did= n't get any response yet=2E >=20 > Oops, we should=E2=80=99ve waited until your copyright assignment is com= pleted=2E Eli, should I revert the patch for now? No need to revert, as the patch was quite small, AFAIR, below the threshol= d=2E From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 23 00:26:46 2024 Received: (at 70478) by debbugs.gnu.org; 23 Apr 2024 04:26:46 +0000 Received: from localhost ([127.0.0.1]:49666 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rz7jx-0000Xg-QU for submit@debbugs.gnu.org; Tue, 23 Apr 2024 00:26:46 -0400 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]:50530) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rz7jt-0000WF-F9 for 70478@debbugs.gnu.org; Tue, 23 Apr 2024 00:26:44 -0400 Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1e651a9f3ffso28970705ad.1 for <70478@debbugs.gnu.org>; Mon, 22 Apr 2024 21:26:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713846379; x=1714451179; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=U33AMjVjz79dpsAOuGUKQ0sI1iAUm8q8ednnWlbJIbQ=; b=aDl+A/LGkBrSdafknSn3gQOHLFxqhKjI4XWOE49RRPWkQ6P66fLOqp4x8sahiTw1lk zzsrANafkdJatnKN70gkkNqKCh6YnjOjzxiUGcJgagDakWaZm5QVTrBU5XXYZ80S5Oqt vdE+hPh7A4JtnhdjozKatVbh5xKXFSliHwiqNEyjHqE64gMmFF0dHZeztdr09kztCcon q5EJ3XFSofCkCMux6StI3KzImgQE+MOwUelYE9qxP+k54OjYNg2DfqrB1+fxbqigSfun WHgszEhI1uW+1Ve6y4zr7mAckbT9PYsHODYRvt28mbRjzwHnmlI9mGUkD2W9cJfP7lxq FA2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713846379; x=1714451179; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U33AMjVjz79dpsAOuGUKQ0sI1iAUm8q8ednnWlbJIbQ=; b=PXGl3T5CnhltiTWUf2Ov1t5bpAG3RN+oSGPQWbiaHcUCI8b7OHCaSotgMR5RreghtH x8mUKLp6etzoZq3mUhS7WoXTlkvmcurv9GMoq+ktlGwtWjgKBETNrYbyzxavcTgI+nQL 3a1VWSfW20YFtzgkx9SmNK05ROfdzjy684DkC6p086JTiqNEuLQ/H/CUDavDbKCmFYwm gaWlmQwpJl64WyXASe2gIy9ZZ/Fu2OS3nRiL/+uuPh02X+PXr7hNMEM/HyfFjALJROYJ 0SkBk7R6m6Zm1hjLKjqT8bAxKWyekASVyNfeKX3Zm2c1fgsMoBTRjehcJbXv1S/oLaj3 URZg== X-Forwarded-Encrypted: i=1; AJvYcCVy0A51Ajcm9RAadXbqwSsSuOLYSw78V9qTXea+QenJSjHbMRnS50peL21kjjozKuv9h5UQVx/uJQq6kAhtEsUmKCvIePs= X-Gm-Message-State: AOJu0Yxm3UGQsewkVTj0Xqk9sOeo6nn0h7gWH7tkvAAyL/7supsG1sqa FtQW+IAJNqSYR5MX4ykUViDbv7jbjzD8U5glBxb9rx5SeC2Iv18L X-Google-Smtp-Source: AGHT+IHGzvQVdNYwmX5FPsiB5SGMhx9hvt1z5wXvDuJwNJDoMzyJGtEk/o0XRVZWhErBvTu5UipgTw== X-Received: by 2002:a17:902:f547:b0:1e7:d482:9e09 with SMTP id h7-20020a170902f54700b001e7d4829e09mr13826483plf.7.1713846379138; Mon, 22 Apr 2024 21:26:19 -0700 (PDT) Received: from smtpclient.apple ([2601:641:300:4910:e4f6:f0b8:c91d:e40b]) by smtp.gmail.com with ESMTPSA id km14-20020a17090327ce00b001e77d1e6b64sm8987059plb.241.2024.04.22.21.26.17 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Apr 2024 21:26:18 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6.1.1\)) Subject: Re: bug#70478: 30.0.50; [PATCH] Fix treesitter-font-lock-settings for built-in functions and attributes. From: Yuan Fu In-Reply-To: Date: Mon, 22 Apr 2024 21:26:06 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <20E66238-6549-46FB-AAE9-DF987A67C83E@gmail.com> References: <86le58a7dv.fsf@gnu.org> <86edb0a3bq.fsf@gnu.org> <7587CCB2-559E-46D7-B497-668477F41CF4@gmail.com> <86a5ln8ev5.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3731.700.6.1.1) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70478 Cc: Prateek Sharma , 70478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Apr 22, 2024, at 9:21 AM, Eli Zaretskii wrote: >=20 > On April 22, 2024 6:50:31 PM GMT+03:00, Yuan Fu = wrote: >> [Adding debbugs back to CC] >>=20 >>> On Apr 22, 2024, at 7:27 AM, Prateek Sharma = wrote: >>>=20 >>> Hi Yuan, I saw that it was merged into the emacs-29 branch but not = in master. I was wondering when we usually sync with master, like is = there a schedule? So that I know when to rebuild my emacs installation. >>> And thanks for guiding me through this. I also submitted the form = for copyright assignment to the mail id given in the CONTRIBUTE file, = but didn't get any response yet. >>=20 >> Oops, we should=E2=80=99ve waited until your copyright assignment is = completed. Eli, should I revert the patch for now? >=20 >=20 > No need to revert, as the patch was quite small, AFAIR, below the = threshold. Oh right. Somehow I thought the patch are larger than it actually it. = False alarm! Yuan= From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 23 02:14:41 2024 Received: (at 70478) by debbugs.gnu.org; 23 Apr 2024 06:14:41 +0000 Received: from localhost ([127.0.0.1]:50191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rz9QO-0004YM-5I for submit@debbugs.gnu.org; Tue, 23 Apr 2024 02:14:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rz9QF-0004XE-Ec for 70478@debbugs.gnu.org; Tue, 23 Apr 2024 02:14:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rz9Pt-0008Kj-Jl; Tue, 23 Apr 2024 02:14:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=bfMKJJwh2hEoHI6bgt/q7cjcSsH2Rv66X/HOIUL8iGk=; b=R4VL6vC+p99e uu6R7fWUx7AMSo6Jf8A8EWPXovJq0ITu5fuGl3qKMlvB+mEKW/Z73iJjcZdPEvlSULbOVpgRpwx5T vdrSZtqQj6vZJRGaRwY3YpXRx+LS2SkuflC7MFCl5k/rMoltWnc14zUzfL5Gk+ZaqZTxb6NRlZfab UWBBLE4Ahb5yXnzhw2Ha5uCXYJzgIYk5dFtsbw7zjpXLv4Y3OK3WgQlqIY1q0ZBGBQdZS5B2C4oku lVTYDWxLztcw8hdppUC7ZmxWsPRKqIQZD8TdiVEzMFbgZvuZiabV3W2sNRjnCEfc709z338gXNPOP 4PVkJs+WXomrb74n1P/XtQ==; Date: Tue, 23 Apr 2024 09:14:03 +0300 Message-Id: <86r0ew4ndg.fsf@gnu.org> From: Eli Zaretskii To: Yuan Fu In-Reply-To: <20E66238-6549-46FB-AAE9-DF987A67C83E@gmail.com> (message from Yuan Fu on Mon, 22 Apr 2024 21:26:06 -0700) Subject: Re: bug#70478: 30.0.50; [PATCH] Fix treesitter-font-lock-settings for built-in functions and attributes. References: <86le58a7dv.fsf@gnu.org> <86edb0a3bq.fsf@gnu.org> <7587CCB2-559E-46D7-B497-668477F41CF4@gmail.com> <86a5ln8ev5.fsf@gnu.org> <20E66238-6549-46FB-AAE9-DF987A67C83E@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70478 Cc: ps.prateek.sharma143@gmail.com, 70478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Yuan Fu > Date: Mon, 22 Apr 2024 21:26:06 -0700 > Cc: Prateek Sharma , > 70478@debbugs.gnu.org > > > On Apr 22, 2024, at 9:21 AM, Eli Zaretskii wrote: > > > > No need to revert, as the patch was quite small, AFAIR, below the threshold. > > Oh right. Somehow I thought the patch are larger than it actually it. False alarm! Well, the commit log message should have had the "Copyright-paperwork-exempt" cookie, but given that the paperwork is in the works, this is not a grave problem. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 24 09:46:52 2024 Received: (at 70478) by debbugs.gnu.org; 24 Apr 2024 13:46:52 +0000 Received: from localhost ([127.0.0.1]:58541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzcxW-0001Fd-Go for submit@debbugs.gnu.org; Wed, 24 Apr 2024 09:46:52 -0400 Received: from mail-vs1-xe2f.google.com ([2607:f8b0:4864:20::e2f]:51430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzcxP-0001Do-3B for 70478@debbugs.gnu.org; Wed, 24 Apr 2024 09:46:48 -0400 Received: by mail-vs1-xe2f.google.com with SMTP id ada2fe7eead31-479e12bde9fso2493782137.2 for <70478@debbugs.gnu.org>; Wed, 24 Apr 2024 06:46:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713966380; x=1714571180; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=p8wbukLpcKhmwu/ilg6+ShxuKbOxsN+5ZAFfh/ABTxA=; b=XZVJp5eNdXXDBCJuicQR9iLI+s78UOJooGddXCmFKMN+1wdF7zp/KbXBjbK3M6em5O L8/Og4hRZz6q9EKJ/GZOfMlgWgG6Gc7Kfja/96pbKrMm0NSU2auBYberYwsIRqkZ2eqb D76AVngNDUrURSshXVpFFlfDpg0SSxiGyEL6XsnYWDiUtihOrWo4BeiEsJd8G0E9WuGG Vp7SYgpUW+YoBZyku7dz2Tss2oOFAyfXfv/KigXEq9YoFUdowXjF82ZHJhz28S+diUn2 YYtMesr1bolGbAH4YZZ0Bum50jGYeBS9bW9wogLc5SsRG1kYIGnZZj1YD8KtNelhfO3J ClKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713966380; x=1714571180; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=p8wbukLpcKhmwu/ilg6+ShxuKbOxsN+5ZAFfh/ABTxA=; b=QhA6Ypm+BbBN5kEkGKg66fFJUGEUt9941YeaofuoQkRzuKUts8Y4k1X/c3Vde1W3Gg dvEAcE1ug48D1WVzgTXw7lKfODxvQlAIlTTDAV2NzvfoWLT2srBPPvbe4y0/hypciSJs +iSFzUg3KEMZkonq+NRCqBaAn2oTesYDBGYU1/Hps4evjaLcMHtLOzGzOEgQ1EwYwtll 7+ErI/oqykvKpGaYEm2uFBLBqRG4FU43OAhkNcS+FlxoFiwcsrgklZ94XAi+G2BdmJfn JaMC3UCl453CbYwE9359jGDUNsAdZ1u9UvYHrBHEkX/pRhwc8X805JIjMf1TbH6X+QBO Ft+g== X-Forwarded-Encrypted: i=1; AJvYcCWQMzanfO8vPTfs4fuEnXVTmxSzakhO463VFF6YfvxufiDn/9TvLLn5n7h4FFfHrEJG2vw2Hg3kUA9sxxMkbuoZFGvM4Ps= X-Gm-Message-State: AOJu0Yy2JKedv5p1i06ytjFnivfcYIpZngCjVwQqmbjr5Ida5zawpgWg zbdfMJ4HfO+nK4lOiVcVOsMR+KuKapqPG9KDMlDQbOJIUThZ4BbWw3HEGMBpWaE2QYTeQpr/YZQ GfI9gUhbrClOcBjc36vxO7EXigJA= X-Google-Smtp-Source: AGHT+IH4oQAs/cdcOvSTcfP/otiijBQFsFppfv5DRM5PMtQqd9+KE45gD/pKc20r010Rv2cRzDFrtrrRqyBVGZnp9Xc= X-Received: by 2002:a67:fd56:0:b0:47b:a01b:e1fd with SMTP id g22-20020a67fd56000000b0047ba01be1fdmr2604179vsr.28.1713966380231; Wed, 24 Apr 2024 06:46:20 -0700 (PDT) MIME-Version: 1.0 References: <86le58a7dv.fsf@gnu.org> <86edb0a3bq.fsf@gnu.org> <7587CCB2-559E-46D7-B497-668477F41CF4@gmail.com> <86a5ln8ev5.fsf@gnu.org> <20E66238-6549-46FB-AAE9-DF987A67C83E@gmail.com> <86r0ew4ndg.fsf@gnu.org> In-Reply-To: <86r0ew4ndg.fsf@gnu.org> From: Prateek Sharma Date: Wed, 24 Apr 2024 19:16:08 +0530 Message-ID: Subject: Re: bug#70478: 30.0.50; [PATCH] Fix treesitter-font-lock-settings for built-in functions and attributes. To: Eli Zaretskii Content-Type: multipart/alternative; boundary="00000000000040357f0616d7e5b9" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 70478 Cc: Yuan Fu , 70478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --00000000000040357f0616d7e5b9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Eli, When do we merge emacs-29 to master? I noticed that the changes are not merged in master. Do we have a schedule for syncing master with emacs-29? On Tue, Apr 23, 2024 at 11:44=E2=80=AFAM Eli Zaretskii wrote= : > > From: Yuan Fu > > Date: Mon, 22 Apr 2024 21:26:06 -0700 > > Cc: Prateek Sharma , > > 70478@debbugs.gnu.org > > > > > On Apr 22, 2024, at 9:21 AM, Eli Zaretskii wrote: > > > > > > No need to revert, as the patch was quite small, AFAIR, below the > threshold. > > > > Oh right. Somehow I thought the patch are larger than it actually it. > False alarm! > > Well, the commit log message should have had the > "Copyright-paperwork-exempt" cookie, but given that the paperwork is > in the works, this is not a grave problem. > --00000000000040357f0616d7e5b9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Eli,
When do we merge emacs-29 to master? I noticed= that the changes are not merged in master. Do we have a schedule for synci= ng master with emacs-29?

On Tue, Apr 23, 2024 at 11:44=E2=80=AFAM = Eli Zaretskii <eliz@gnu.org> wrot= e:
> From: Yu= an Fu <casouri@gm= ail.com>
> Date: Mon, 22 Apr 2024 21:26:06 -0700
> Cc: Prateek Sharma <ps.prateek.sharma143@gmail.com>,
>=C2=A0 70478= @debbugs.gnu.org
>
> > On Apr 22, 2024, at 9:21 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> >
> > No need to revert, as the patch was quite small, AFAIR, below the= threshold.
>
> Oh right. Somehow I thought the patch are larger than it actually it. = False alarm!

Well, the commit log message should have had the
"Copyright-paperwork-exempt" cookie, but given that the paperwork= is
in the works, this is not a grave problem.
--00000000000040357f0616d7e5b9-- From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 24 11:32:20 2024 Received: (at 70478) by debbugs.gnu.org; 24 Apr 2024 15:32:21 +0000 Received: from localhost ([127.0.0.1]:59008 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzebb-00027x-Hy for submit@debbugs.gnu.org; Wed, 24 Apr 2024 11:32:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzebY-00025v-Am for 70478@debbugs.gnu.org; Wed, 24 Apr 2024 11:32:18 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzebA-0004ZA-TK; Wed, 24 Apr 2024 11:31:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=bQzgvJpnE9sa0cruyhFVvpfINL+YTcyJKMOY/2vkeBY=; b=N7hFYB7n9q9i Xzi3SaHiWM4sFE89ISzCXDDkdgGgqIXmgrwz1RvX/0bsKSWvD7I/CoGQJR29iSM8DWh2aZA8OC262 RFEjZ+ys9qDcHHi40RAt3Z38oSVH6e7suxwO00ikbNTF7ludgTqYKqoa1kICVxhfrTwC3ifWxdyPk K9z7tAZ22ltPwVUqRdAOgWoEaGkwMvif6E2OcOinEmEpByzRmhTx8QUX/aAIHRGmhLfm2S8s5Ni9G MISXyozfRnSAHC4YR+Rp/ItT31Vv4XqqUAunYrczuZOexbdNcHo6nQre7MjWX8tzIgbcjxxjhS1Cm DEKoVVrnJ3Hl3e0N8zqCPw==; Date: Wed, 24 Apr 2024 18:31:51 +0300 Message-Id: <86frva3hg8.fsf@gnu.org> From: Eli Zaretskii To: Prateek Sharma In-Reply-To: (message from Prateek Sharma on Wed, 24 Apr 2024 19:16:08 +0530) Subject: Re: bug#70478: 30.0.50; [PATCH] Fix treesitter-font-lock-settings for built-in functions and attributes. References: <86le58a7dv.fsf@gnu.org> <86edb0a3bq.fsf@gnu.org> <7587CCB2-559E-46D7-B497-668477F41CF4@gmail.com> <86a5ln8ev5.fsf@gnu.org> <20E66238-6549-46FB-AAE9-DF987A67C83E@gmail.com> <86r0ew4ndg.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70478 Cc: casouri@gmail.com, 70478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Prateek Sharma > Date: Wed, 24 Apr 2024 19:16:08 +0530 > Cc: Yuan Fu , 70478@debbugs.gnu.org > > When do we merge emacs-29 to master? I noticed that the changes are not merged in master. Do we have a > schedule for syncing master with emacs-29? I usually merge once a week, so it will happen in a couple of days. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 24 11:33:49 2024 Received: (at 70478) by debbugs.gnu.org; 24 Apr 2024 15:33:49 +0000 Received: from localhost ([127.0.0.1]:59017 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzed2-0002Od-2U for submit@debbugs.gnu.org; Wed, 24 Apr 2024 11:33:49 -0400 Received: from mail-oo1-xc35.google.com ([2607:f8b0:4864:20::c35]:52452) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzecy-0002Mn-1E for 70478@debbugs.gnu.org; Wed, 24 Apr 2024 11:33:45 -0400 Received: by mail-oo1-xc35.google.com with SMTP id 006d021491bc7-5aa27dba8a1so4220827eaf.0 for <70478@debbugs.gnu.org>; Wed, 24 Apr 2024 08:33:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713972801; x=1714577601; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=F1dD6ajDNeM3jnOGiCzLmD8bNkqG6ud3q4/VTnGWnkM=; b=fwF7AYofyjxRgGaUkfX2u8GVxOcd38qeQziNQiQISe4tTHWATHHUqFjsDCc7nbaM4Q IQYiTR8NEOtrNtB2k4u1Ofxc6yF8WRwihz+Rz7H33+NEpg9O3d/IBQo/3ELVr2gGK9XY 9FMvdvg8caqKpY4+oNPJCtpnPVHwA2Y44OHgbr2vpPiWND5U/JYq4dR725Chawq8mI9d hqJtJqLNvHu42Ss9W8ky/CEeYkV0VdO2dCtOvwqNwDvkSqxDFo+JmpIyzeykfXGXXLeB du4o2BnXMHo8Y9SUlgSnKJTN1hWGitv3NSMXDw5eI5a2SioVO+1ClrBMtudW6ZR3DoQ3 PBng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713972801; x=1714577601; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=F1dD6ajDNeM3jnOGiCzLmD8bNkqG6ud3q4/VTnGWnkM=; b=BdqH7InVYOMhswFG1YElHQepcWhOwwYZpfIEx0U97eXbTCR65P6arXZ0V9n0liGARD //tPMG028gCg8I8ecOhq6Gtj+66xVifkoUpktM8bZm65GTfZeC67LjF1M0Z3012vvT/D jTdAf5HFy1rV/bnzKXp9mNAC6PyjzezNAmlB2rBKMscbgWUuPQgCD7a3kx8BCAg4/94o BycigfuuotMyObhQKiXNjTeWWhSg+1LueG+vu+n3T5m6HJWYoYMidPw8oeuotuPmU2zq Jkkoe/aXr8Z6t920G9kouW2j5tqf63niPDD4FYgeTO+PKActn2eCzdHGLzHI3kPvXzCw kniQ== X-Forwarded-Encrypted: i=1; AJvYcCUvPpgWdBaJz8NGLPw78Tgi0aWao+Cy1hzKUNB86AZZzlqw6W84ruaGwuT9PCHt+nZ6UegPNoYa8ITAcKFCG1f9KvxV76g= X-Gm-Message-State: AOJu0Yxyf3m60KZYH7NV0kzykZ+klZDjYthQFaCGtrHRAJ4g259TGLYO 5ksjBm3cxDp9+mTYNJNbw1WAqce/Lf2V26fCfb0yvldybcZKm5fmkjfSBN6WaYKn6f5RekEMkX2 mD4jDRUTytlhr9gHorjxXZWQEWY4= X-Google-Smtp-Source: AGHT+IF+rI6srXmFYt9XZtReSXAu6vgo9TTcvvugx3E5CJuaItlOtRp2lKFeoLj1fAZjOckB5xgh3TekfdFDcjKF5ds= X-Received: by 2002:a05:6358:7281:b0:186:1128:bca7 with SMTP id w1-20020a056358728100b001861128bca7mr3167969rwf.6.1713972800891; Wed, 24 Apr 2024 08:33:20 -0700 (PDT) MIME-Version: 1.0 References: <86le58a7dv.fsf@gnu.org> <86edb0a3bq.fsf@gnu.org> <7587CCB2-559E-46D7-B497-668477F41CF4@gmail.com> <86a5ln8ev5.fsf@gnu.org> <20E66238-6549-46FB-AAE9-DF987A67C83E@gmail.com> <86r0ew4ndg.fsf@gnu.org> <86frva3hg8.fsf@gnu.org> In-Reply-To: <86frva3hg8.fsf@gnu.org> From: Prateek Sharma Date: Wed, 24 Apr 2024 21:03:09 +0530 Message-ID: Subject: Re: bug#70478: 30.0.50; [PATCH] Fix treesitter-font-lock-settings for built-in functions and attributes. To: Eli Zaretskii Content-Type: multipart/alternative; boundary="000000000000f3b5350616d96313" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 70478 Cc: Yuan Fu , 70478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --000000000000f3b5350616d96313 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Okay, Thanks! On Wed, 24 Apr, 2024, 9:01=E2=80=AFpm Eli Zaretskii, wrote: > > From: Prateek Sharma > > Date: Wed, 24 Apr 2024 19:16:08 +0530 > > Cc: Yuan Fu , 70478@debbugs.gnu.org > > > > When do we merge emacs-29 to master? I noticed that the changes are not > merged in master. Do we have a > > schedule for syncing master with emacs-29? > > I usually merge once a week, so it will happen in a couple of days. > --000000000000f3b5350616d96313 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Okay, Thanks!

On Wed, 24 Apr, 2024, 9:01=E2=80=AFpm Eli Za= retskii, <eliz@gnu.org> wrote:
> From: Prateek Sharma <ps.prateek.sharma143@gmail.com>
> Date: Wed, 24 Apr 2024 19:16:08 +0530
> Cc: Yuan Fu <casouri@gmail.com>, 70478@debbugs.gnu.org=
>
> When do we merge emacs-29 to master? I noticed that the changes are no= t merged in master. Do we have a
> schedule for syncing master with emacs-29?

I usually merge once a week, so it will happen in a couple of days.
--000000000000f3b5350616d96313-- From unknown Mon Aug 18 18:04:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 23 May 2024 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator