GNU bug report logs - #70473
[PATCH] tests: fix stdin tests

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Tanmay <tanmaynpatil105 <at> gmail.com>
Subject: bug#70473: closed (Re: [bug-diffutils] bug#70473: [PATCH] tests:
 fix stdin tests)
Date: Fri, 19 Apr 2024 15:53:04 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#70473: [PATCH] tests: fix stdin tests

which was filed against the diffutils package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 70473 <at> debbugs.gnu.org.

-- 
70473: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70473
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Tanmay <tanmaynpatil105 <at> gmail.com>
Cc: 70473-done <at> debbugs.gnu.org
Subject: Re: [bug-diffutils] bug#70473: [PATCH] tests: fix stdin tests
Date: Fri, 19 Apr 2024 08:52:12 -0700

On 2024-04-19 05:07, Tanmay wrote:
> I noticed that in the tests/stdin directory, we were taking input directly
> from the 'd' directory, which seems incorrect.
> 
> tests/stdin:31 diff -u - a <d >out 2>err || fail=1

I don't see a bug there. In general 'diff DIRECTORY FILE' acts like 
'diff DIRECTORY/FILE FILE'; here 'diff - a <d' acts like 'diff d/a a'.

[Message part 3 (message/rfc822, inline)]

From: Tanmay <tanmaynpatil105 <at> gmail.com>
To: bug-diffutils <at> gnu.org
Subject: [PATCH] tests: fix stdin tests
Date: Fri, 19 Apr 2024 17:37:04 +0530

[Message part 4 (text/plain, inline)]

Hi,

I noticed that in the tests/stdin directory, we were taking input directly
from the 'd' directory, which seems incorrect.

tests/stdin:31 diff -u - a <d >out 2>err || fail=1

I'm not sure how the tests were working with input directly from the 'd'
directory. I'm including a patch which fixes it.

Thanks,
Tanmay

From 021148712cb01efb954e9c1a6961b2df9cdfcf04 Mon Sep 17 00:00:00 2001
From: Tanmay Patil <tanmaynpatil105 <at> gmail.com>
Date: Fri, 19 Apr 2024 17:20:39 +0530
Subject: [PATCH] tests: fix stdin tests

Signed-off-by: Tanmay Patil <tanmaynpatil105 <at> gmail.com>
---
 tests/stdin | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/stdin b/tests/stdin
index 0fd9e7e..dda076b 100755
--- a/tests/stdin
+++ b/tests/stdin
@@ -24,7 +24,7 @@ compare /dev/null err || fail=1
 mkdir d || framework_failure_
 echo a >d/a || framework_failure_

-diff -u - a <d >out 2>err || fail=1
+diff -u - a <d/a >out 2>err || fail=1
 compare /dev/null out || fail=1
 compare /dev/null err || fail=1

-- 
2.40.1

[Message part 5 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.