GNU bug report logs - #70469
[PATCH] gnu: isc-dhcp: Make dhclien-script hooks work.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#70469: closed ([PATCH] gnu: isc-dhcp: Make dhclien-script
 hooks work.)
Date: Mon, 13 May 2024 20:46:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 13 May 2024 21:45:08 +0100
with message-id <87ttj11lwr.fsf <at> cbaines.net>
and subject line Re: [bug#70469] [PATCH] gnu: isc-dhcp: Make dhclien-script hooks work.
has caused the debbugs.gnu.org bug report #70469,
regarding [PATCH] gnu: isc-dhcp: Make dhclien-script hooks work.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
70469: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70469
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Alexey Abramov <levenson <at> mmer.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: isc-dhcp: Make dhclien-script hooks work.
Date: Fri, 19 Apr 2024 08:30:38 +0200

dhclient provides a hook mechanism for users. In order to run these
hooks, dhclient-script uses run-parts to run all the executable files
found in requested directory. run-parts is part of debianutils
packages.

* gnu/packages/admin.scm (isc-dhcp)[inputs]: Add "debianutils" to
provide access to run-parts.
---
 gnu/packages/admin.scm | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index b60857b264..0bf96af835 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -122,6 +122,7 @@ (define-module (gnu packages admin)
   #:use-module (gnu packages curl)
   #:use-module (gnu packages cyrus-sasl)
   #:use-module (gnu packages datastructures)
+  #:use-module (gnu packages debian)
   #:use-module (gnu packages dns)
   #:use-module (gnu packages elf)
   #:use-module (gnu packages file)
@@ -1563,7 +1564,8 @@ (define-public isc-dhcp
                       (coreutils (assoc-ref inputs "coreutils*"))
                       (inetutils (assoc-ref inputs "inetutils"))
                       (grep      (assoc-ref inputs "grep*"))
-                      (sed       (assoc-ref inputs "sed*")))
+                      (sed       (assoc-ref inputs "sed*"))
+                      (debianutils (assoc-ref inputs "debianutils")))
                  (substitute* "client/scripts/linux"
                    (("/sbin/ip")
                     (search-input-file inputs "/sbin/ip")))
@@ -1578,7 +1580,7 @@ (define-public isc-dhcp
                      ,(map (lambda (dir)
                              (string-append dir "/bin:"
                                             dir "/sbin"))
-                           (list inetutils coreutils grep sed))))))))))
+                           (list inetutils coreutils grep sed debianutils))))))))))
 
       (native-inputs
        (list config perl file))
@@ -1589,6 +1591,10 @@ (define-public isc-dhcp
                       '()
                       `(("iproute" ,iproute)))
 
+                ;; dhclient-script provides hooks to users and uses run-parts in
+                ;; order to list users defined hooks.
+                ("debianutils" ,debianutils)
+
                 ;; isc-dhcp bundles a copy of BIND, which has proved vulnerable
                 ;; in the past.  Use a BIND-VERSION of our choosing instead.
                 ("bind-source-tarball"
-- 
2.41.0

[Message part 3 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: Alexey Abramov via Guix-patches via <guix-patches <at> gnu.org>
Cc: 70469-done <at> debbugs.gnu.org, Alexey Abramov <levenson <at> mmer.org>
Subject: Re: [bug#70469] [PATCH] gnu: isc-dhcp: Make dhclien-script hooks work.
Date: Mon, 13 May 2024 21:45:08 +0100

[Message part 4 (text/plain, inline)]

Alexey Abramov via Guix-patches via <guix-patches <at> gnu.org> writes:

> dhclient provides a hook mechanism for users. In order to run these
> hooks, dhclient-script uses run-parts to run all the executable files
> found in requested directory. run-parts is part of debianutils
> packages.
>
> * gnu/packages/admin.scm (isc-dhcp)[inputs]: Add "debianutils" to
> provide access to run-parts.
> ---
>  gnu/packages/admin.scm | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)

Thanks both, I've pushed this to master as
7d6d54202ab609877b14490e487a1df106072b7d.

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.