From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 19 02:31:51 2024 Received: (at submit) by debbugs.gnu.org; 19 Apr 2024 06:31:51 +0000 Received: from localhost ([127.0.0.1]:57054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rxhmp-0006Aj-8l for submit@debbugs.gnu.org; Fri, 19 Apr 2024 02:31:51 -0400 Received: from lists.gnu.org ([2001:470:142::17]:48896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rxhmn-00069f-BX for submit@debbugs.gnu.org; Fri, 19 Apr 2024 02:31:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxhmK-0005jM-R1 for guix-patches@gnu.org; Fri, 19 Apr 2024 02:31:23 -0400 Received: from mail.mmer.org ([178.22.65.174]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxhmI-0007bC-VM for guix-patches@gnu.org; Fri, 19 Apr 2024 02:31:20 -0400 Received: from mail.mmer.org (localhost [127.0.0.1]) by mail.mmer.org (OpenSMTPD) with ESMTP id 7ac4b5a5 for ; Fri, 19 Apr 2024 06:31:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=mmer.org; h=from:to :subject:date:message-id:mime-version:content-transfer-encoding; s=dkim; bh=vJRL8Pk48QA6+UAco3AyJgqmigc/8VkUYwYd5C8GrEc=; b=i5ir RYo0zSp5O+lXq3v3XJ3sLh02sM+mZVV9reJ1FzHqW86sVL8cFUW+sHqyCCwKjtOt ge+qAoD9G1RRVLziAxoBKD7qZyX83M4shtY5H7WLEVEL82sIt0EIya1kY2Vjdxi/ LR7+EVpD1eIN7KKdJEN+cjJFtFjkuiSGYxtzUeU= Received: from delta (13-208-98-95.ftth.glasoperator.nl [95.98.208.13]) by mail.mmer.org (OpenSMTPD) with ESMTPSA id b5b7bc11 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Fri, 19 Apr 2024 06:31:13 +0000 (UTC) From: Alexey Abramov To: guix-patches@gnu.org Subject: [PATCH] gnu: isc-dhcp: Make dhclien-script hooks work. Date: Fri, 19 Apr 2024 08:30:38 +0200 Message-ID: <20240419063038.21727-1-levenson@mmer.org> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=178.22.65.174; envelope-from=levenson@mmer.org; helo=mail.mmer.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) dhclient provides a hook mechanism for users. In order to run these hooks, dhclient-script uses run-parts to run all the executable files found in requested directory. run-parts is part of debianutils packages. * gnu/packages/admin.scm (isc-dhcp)[inputs]: Add "debianutils" to provide access to run-parts. --- gnu/packages/admin.scm | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm index b60857b264..0bf96af835 100644 --- a/gnu/packages/admin.scm +++ b/gnu/packages/admin.scm @@ -122,6 +122,7 @@ (define-module (gnu packages admin) #:use-module (gnu packages curl) #:use-module (gnu packages cyrus-sasl) #:use-module (gnu packages datastructures) + #:use-module (gnu packages debian) #:use-module (gnu packages dns) #:use-module (gnu packages elf) #:use-module (gnu packages file) @@ -1563,7 +1564,8 @@ (define-public isc-dhcp (coreutils (assoc-ref inputs "coreutils*")) (inetutils (assoc-ref inputs "inetutils")) (grep (assoc-ref inputs "grep*")) - (sed (assoc-ref inputs "sed*"))) + (sed (assoc-ref inputs "sed*")) + (debianutils (assoc-ref inputs "debianutils"))) (substitute* "client/scripts/linux" (("/sbin/ip") (search-input-file inputs "/sbin/ip"))) @@ -1578,7 +1580,7 @@ (define-public isc-dhcp ,(map (lambda (dir) (string-append dir "/bin:" dir "/sbin")) - (list inetutils coreutils grep sed)))))))))) + (list inetutils coreutils grep sed debianutils)))))))))) (native-inputs (list config perl file)) @@ -1589,6 +1591,10 @@ (define-public isc-dhcp '() `(("iproute" ,iproute))) + ;; dhclient-script provides hooks to users and uses run-parts in + ;; order to list users defined hooks. + ("debianutils" ,debianutils) + ;; isc-dhcp bundles a copy of BIND, which has proved vulnerable ;; in the past. Use a BIND-VERSION of our choosing instead. ("bind-source-tarball" -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Mon May 13 08:18:55 2024 Received: (at 70469) by debbugs.gnu.org; 13 May 2024 12:18:56 +0000 Received: from localhost ([127.0.0.1]:60633 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6Udr-0006c5-Oi for submit@debbugs.gnu.org; Mon, 13 May 2024 08:18:55 -0400 Received: from 12.mo582.mail-out.ovh.net ([178.32.125.228]:34717) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6Udm-0006bs-Ce for 70469@debbugs.gnu.org; Mon, 13 May 2024 08:18:53 -0400 Received: from director10.ghost.mail-out.ovh.net (unknown [10.108.9.148]) by mo582.mail-out.ovh.net (Postfix) with ESMTP id 4VdJS80kF3z1HFY for <70469@debbugs.gnu.org>; Mon, 13 May 2024 12:18:48 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-kxrg4 (unknown [10.108.42.203]) by director10.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 8430E1FED8; Mon, 13 May 2024 12:18:47 +0000 (UTC) Received: from ngraves.fr ([37.59.142.103]) by ghost-submission-6684bf9d7b-kxrg4 with ESMTPSA id IWR6EicFQmb1nwMAn9kkbA (envelope-from ); Mon, 13 May 2024 12:18:47 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-103G005cd3abd04-56c2-4ae6-8219-86cb54c562b6, AFD3D7969371CC029319C969337B9752385513BA) smtp.auth=ngraves@ngraves.fr X-OVh-ClientIp: 80.214.129.131 From: Nicolas Graves To: control@debbugs.gnu.org,70469@debbugs.gnu.org Subject: QA review for 70469 Date: Mon, 13 May 2024 14:18:44 +0200 Message-ID: <87v83h29cr.fsf@ngraves.fr> MIME-Version: 1.0 Content-Type: text/plain X-Ovh-Tracer-Id: 371265496588280502 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvledrvdeggedghedtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpefhvffufffkgggtsehttdertddttddtnecuhfhrohhmpefpihgtohhlrghsucfirhgrvhgvshcuoehnghhrrghvvghssehnghhrrghvvghsrdhfrheqnecuggftrfgrthhtvghrnhepueejleeileejfffhleetjedtleejheevudffleevgfdufeekhefgvddvveegveefnecukfhppeduvdejrddtrddtrddupdektddrvddugedruddvledrudefuddpfeejrdehledrudegvddruddtfeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepnhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrpdhnsggprhgtphhtthhopedupdhrtghpthhtohepjedtgeeileesuggvsggsuhhgshdrghhnuhdrohhrghdpoffvtefjohhsthepmhhoheekvddpmhhouggvpehsmhhtphhouhht X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70469 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) user guix usertag 70469 + reviewed-looks-good thanks Guix QA review form submission: LGTM. Items marked as checked: Lint warnings, Package builds, Commit messages -- Best regards, Nicolas Graves From debbugs-submit-bounces@debbugs.gnu.org Mon May 13 16:45:33 2024 Received: (at submit) by debbugs.gnu.org; 13 May 2024 20:45:33 +0000 Received: from localhost ([127.0.0.1]:34806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6cY8-0000ds-Kb for submit@debbugs.gnu.org; Mon, 13 May 2024 16:45:32 -0400 Received: from lists.gnu.org ([209.51.188.17]:44120) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6cY6-0000dk-FY for submit@debbugs.gnu.org; Mon, 13 May 2024 16:45:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s6cXq-0006XP-AM for guix-patches@gnu.org; Mon, 13 May 2024 16:45:16 -0400 Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s6cXo-0007Ge-I3 for guix-patches@gnu.org; Mon, 13 May 2024 16:45:14 -0400 Received: from localhost (unknown [45.67.83.168]) by mira.cbaines.net (Postfix) with ESMTPSA id E04B127BBE2; Mon, 13 May 2024 21:45:10 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 3376e1e7; Mon, 13 May 2024 20:45:09 +0000 (UTC) From: Christopher Baines To: Alexey Abramov via Guix-patches via Subject: Re: [bug#70469] [PATCH] gnu: isc-dhcp: Make dhclien-script hooks work. In-Reply-To: <20240419063038.21727-1-levenson@mmer.org> (Alexey Abramov via Guix-patches via's message of "Fri, 19 Apr 2024 08:30:38 +0200") References: <20240419063038.21727-1-levenson@mmer.org> User-Agent: mu4e 1.12.2; emacs 29.3 Date: Mon, 13 May 2024 21:45:08 +0100 Message-ID: <87ttj11lwr.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: 70469-done@debbugs.gnu.org, Alexey Abramov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Alexey Abramov via Guix-patches via writes: > dhclient provides a hook mechanism for users. In order to run these > hooks, dhclient-script uses run-parts to run all the executable files > found in requested directory. run-parts is part of debianutils > packages. > > * gnu/packages/admin.scm (isc-dhcp)[inputs]: Add "debianutils" to > provide access to run-parts. > --- > gnu/packages/admin.scm | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) Thanks both, I've pushed this to master as 7d6d54202ab609877b14490e487a1df106072b7d. Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmZCe9RfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xd5sA/9H+zCIw0o3TdvrO6rDbD+go/Md4AuD7Nu MehqOsDAWoPa78g8L/WvpzfXOsitSmzyf2JT16SFZYlRbzEdEgasT1fC+WH6iKXX Q7Mtyn1w6nb6kVKZvVbjVaHIYzfGb/CwFxK8oHKB/f3PAChdgX9cMbwdgLp3lTN0 BQI/4+3nEJx2HZIcfP0BAC1IhHv0//mSGcUJLcUtyg2ou2BB0smHOMUpcoBFgq/L fVwonYrgK3kgn/CcAo5zFUsdSrRofNQ2sTYgWnPwnCrzFbqQcbMKT69KUvvry8BT zq8mD1X69RDizXAhF+74cDz6MWRqaQFFaLnv75RKK/zV4Ry0LVwi+Sh2Y6WCF4qR l0OwVhSRZQD/5RcNCRjrCYAmr8VTUnFmehHTgqkDH5Sg+YnqtIlP9b32uDTjMayG v6X8sPz3HfD+Hu6slYFwGfy2/nk+/++gsKUzX17WBKGTnw9jdAIHS7w68cC4RkKL l6gjZxtDXp/JQiv2fLcyr/XxVcSnNN18K1dAiICYK+FoxduG9FUTxVtv6ID2eFm9 kpw8RXOoXlM8sMo/L2NE4IH24lULRKCZDZVeGtHYDwNDdniBn82sNRw9CO10K5Dw 5usZF7SnDqNO6A03/I4/knzWsAD2PvqgoWoDyHwbBeNOLbWMppIDj9QV2gf2prF/ c9oSEiDzwtg= =v6yL -----END PGP SIGNATURE----- --=-=-=-- From unknown Tue Aug 19 09:32:17 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 12 Jun 2024 11:24:17 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator