GNU bug report logs - #70465
[PATCH] Add font-locking rule for Rust function signatures

Previous Next

Package: emacs;

Reported by: Noah Peart <noah.v.peart <at> gmail.com>

Date: Fri, 19 Apr 2024 02:03:04 UTC

Severity: normal

Tags: patch

Done: Yuan Fu <casouri <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Noah Peart <noah.v.peart <at> gmail.com>
Subject: bug#70465: closed (Re: bug#70465: [PATCH] Add font-locking rule
 for Rust function signatures)
Date: Mon, 22 Apr 2024 00:05:02 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#70465: [PATCH] Add font-locking rule for Rust function signatures

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 70465 <at> debbugs.gnu.org.

-- 
70465: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70465
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Yuan Fu <casouri <at> gmail.com>
To: Noah Peart <noah.v.peart <at> gmail.com>
Cc: 70465-done <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#70465: [PATCH] Add font-locking rule for Rust function
 signatures
Date: Sun, 21 Apr 2024 17:03:59 -0700

> On Apr 19, 2024, at 10:43 AM, Noah Peart <noah.v.peart <at> gmail.com> wrote:
> 
> Got it, thanks!
> 
> On Fri, Apr 19, 2024 at 10:35 AM Eli Zaretskii <eliz <at> gnu.org> wrote:
> > From: Noah Peart <noah.v.peart <at> gmail.com>
> > Date: Fri, 19 Apr 2024 09:47:38 -0700
> > Cc: Yuan Fu <casouri <at> gmail.com>, 70465 <at> debbugs.gnu.org
> > 
> > > Please be sure to add the bug number to the commit log message when
> > you install this.
> > 
> > When submitting a patch, is there an easy way to add the bug number to
> > the commit?
> 
> Only after you get the bug report back from the bug tracker.  When you
> send the first message which creates a new bug report, you cannot know
> it.  So we only ask people to add the bug number if they submit a
> revised patch, because at that point the number is already known.
> When an original patch is installed, the person who pushes it must do
> a "git commit --amend" to edit the commit log message to add the bug
> number.

And merged.

Yuan
[Message part 3 (message/rfc822, inline)]
From: Noah Peart <noah.v.peart <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add font-locking rule for Rust function signatures
Date: Thu, 18 Apr 2024 19:01:57 -0700
[Message part 4 (text/plain, inline)]
Tags: patch


Adds a rule to font-lock Rust function signatures and missing function
modifier "default" to rust-ts-mode--keywords.

The new rule adds font-locking to signatures as in the following
example:

    trait Foo {
        fn foo() -> String;
//            ^ font-lock-function-name-face
    }


In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.33, cairo version 1.16.0) of 2024-04-18 built on noah-X580VD
Repository revision: 0a57dfcff8d0abcf4427cfbfd886264bb3b8eaab
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Ubuntu 22.04.4 LTS

Configured using:
 'configure --prefix=/usr/local --with-modules --with-tree-sitter
--with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls
--with-json --with-mailutils --with-jpeg --with-png --with-rsvg
--with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12
CXX=gcc-12'
[Message part 5 (text/html, inline)]
[0001-Add-font-locking-rule-for-Rust-function-signatures.patch (text/x-patch, attachment)]

This bug report was last modified 1 year and 92 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.