GNU bug report logs - #70455
[PATCH] Add new user option `preview-leave-open-previews-visible'

Previous Next

Package: auctex;

Reported by: Paul Nelson <ultrono <at> gmail.com>

Date: Thu, 18 Apr 2024 14:52:03 UTC

Severity: normal

Tags: patch

Done: Arash Esbati <arash <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #22 received at 70455 <at> debbugs.gnu.org (full text, mbox):

From: Tassilo Horn <tsdh <at> gnu.org>
To: Ikumi Keita <ikumi <at> ikumi.que.jp>
Cc: Arash Esbati <arash <at> gnu.org>, 70455 <at> debbugs.gnu.org,
 Paul Nelson <ultrono <at> gmail.com>
Subject: Re: bug#70455: [PATCH] Add new user option
 `preview-leave-open-previews-visible'
Date: Mon, 22 Apr 2024 13:55:45 +0200
Ikumi Keita <ikumi <at> ikumi.que.jp> writes:

>> Your patch uses `cl-find-if' which is a function.  Until now, we used
>> only macros from the cl-lib inside AUCTeX in order to have no other
>> runtime dependencies.  In general, I have no problem if we lift this
>> limitation and use cl-lib functions as well -- the library is part of
>> Emacs and why not use it.  But before we do this, I'd like to hear
>> from Keita and Tassilo what they think about this.
>
> I don't mind. It doesn't matter to use emacs built-in library to write
> code simply.

FWIW, if we go ELPA-releases only and drop standalone tarball releases,
I would suggest we just use

  ;; Package-Requires: ...

in our auctex.el in order to specify the required emacs version,
"cl-lib", and even "compat" and remove all legacy code for emacs
versions older than the last release.

Bye,
Tassilo




This bug report was last modified 1 year and 88 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.