GNU bug report logs - #70415
30.0.50; [Cygwin] `lock-file' creates a symlink with funny name

Previous Next

Full log

Message #80 received at 70415 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ken Brown <kbrown <at> cornell.edu>
Cc: yamaoka <at> jpl.org, 70415 <at> debbugs.gnu.org
Subject: Re: bug#70415: 30.0.50; [Cygwin] `lock-file' creates a symlink with
 funny name
Date: Sun, 05 May 2024 19:32:15 +0300

> Date: Sun, 5 May 2024 12:21:03 -0400
> Cc: yamaoka <at> jpl.org, 70415 <at> debbugs.gnu.org
> From: Ken Brown <kbrown <at> cornell.edu>
> 
> On 5/5/2024 1:40 AM, Eli Zaretskii wrote:
> > Right.  Does the below look like the right change to support such
> > weird cases?
> > 
> > diff --git a/src/filelock.c b/src/filelock.c
> > index 01d35c4..86c6eeb 100644
> > --- a/src/filelock.c
> > +++ b/src/filelock.c
> > @@ -419,7 +419,9 @@ current_lock_owner (lock_info_type *owner, Lisp_Object lfname)
> >         boot += 2;
> >         FALLTHROUGH;
> >       case ':':
> > -      if (! c_isdigit (boot[0]))
> > +      if (! c_isdigit (boot[0])
> > +	  /* A negative number.  */
> > +	  || (boot[0] == '-' && c_isdigit (boot[1])))
> >   	return EINVAL;
> >         boot_time = strtoimax (boot, &lfinfo_end, 10);
> >         break;
> 
> Not quite.  I think it should be

Right, thanks.  Now installed on master, and I think we can close this
bug?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.