From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 16 05:20:57 2024 Received: (at submit) by debbugs.gnu.org; 16 Apr 2024 09:20:57 +0000 Received: from localhost ([127.0.0.1]:42750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwezo-0006P0-DW for submit@debbugs.gnu.org; Tue, 16 Apr 2024 05:20:57 -0400 Received: from lists.gnu.org ([2001:470:142::17]:48026) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwezj-0006Nu-3y for submit@debbugs.gnu.org; Tue, 16 Apr 2024 05:20:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rwezD-00037k-SE for bug-gnu-emacs@gnu.org; Tue, 16 Apr 2024 05:20:21 -0400 Received: from mout.gmx.net ([212.227.17.21]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rwez9-0007yB-8v for bug-gnu-emacs@gnu.org; Tue, 16 Apr 2024 05:20:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1713259211; x=1713864011; i=stephen.berman@gmx.net; bh=HwGwMeKpMSrKcfLIZ6+c55o2vuVUVZQ0dblMbWvPCDM=; h=X-UI-Sender-Class:From:To:Subject:Date:Message-ID:MIME-Version: Content-Type:cc:content-transfer-encoding:content-type:date:from: message-id:mime-version:reply-to:subject:to; b=S8WfIjXByEj7xTv9lG1b+S7T8Gm90LEI5UDtRHRPtMRgq4aLKARsw/Lr8QSHlUim jbi4oukehJA2uOdZ2CuG89FV8e747StPdE0yqibNE+I6o0TTzsN3XKD4pVueBjXmn L65izpZaUNPiXgO8eyZlyVDH8ZrcNUmOPompu8alBOxm6o0DoTiXhj8bkrGysuGnW dCp5I2De3qDb/3f2ePjzSNJXcWrkHnLckcEVlwshUcm65LTQg4DpxmgsnMZhXmBdY WxACQ+Bd6MrTKL3HbyxO3qp2+dpuLhiwewepf9rSZruC+J4CSAbXv4Za0XfsEzosc eesA0WYK0dDzCCfnGQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs ([88.130.48.38]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MfHEJ-1sP92u2wJf-00gpbk for ; Tue, 16 Apr 2024 11:20:11 +0200 From: Stephen Berman To: bug-gnu-emacs@gnu.org Subject: 30.0.50; FR: skip inactive widgets when tabbing X-Debbugs-Cc: Date: Tue, 16 Apr 2024 11:20:10 +0200 Message-ID: <87zfttpstx.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:0Noh35BZ44THPNTrc8pruZo8F6Jn3BllA7yH3qRQxB8lA9rqe5l /pNEqhjv3w7SyRLfRe+v6I3jOEohkpdnRtzaGDGpcESSwalGh0kMjv3Wp/6KzqtiqFVfqHN V2+UnDmLC6L/lyBnfpSTWCnfZd/OL7Xy0I1Y6X1RlEiHp1KOmyJ8NNK7GKin0VDNMVFS62c hh8rbQdBSaZ61+LJBhyvg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:EiZrotqKi3w=;qdacXIZgYFlvVZTL+exKZyPiQoJ nemrCns6UqVLUh8Xk+qws7kXwtPwAuA2HgWKB0LSTcbKIf9LSmSCvPAbbW50KbKajFg/DpEct zkTilqvq+1PXSZQd0lqrjD8wcM+cw/WvpY0YUJiVRU5s+bZghFNC5/xznci7qXSHdfv3z51p0 F44VDeBhG+2yYU83FmFHNsAGikFsZD9pAGAtAwDfYwiURejtOuVARalkjk1y2vS68mN1/8fEC +Y9hKE9+h36qJ6i76wvX24i7Xhm0WJAL2DrDFTzPp7pK1QPZCcJQEECJlkGEwSFqHVZiMElnb UJn1FFvCH8xrUXe164QEgeInLfJlNdOPsDygpF25eGf1icFTYqGTYus1LpFIbihnw90OMrNNX TZByWoOe1/M+Qcek6SsmhwhMU/9ZqSxhxZpcxTUFCcgnG4zBXz4HFbp3WYuB4Un8BckoL1ubN vG56NohH+U6vt5kS/wY0vJTd8vf5fDqsfoDdO+mCAKqsZLChlbX/u8wgv41xWimTVKAV+aWxd eH7FAle2/7YURFztnD7BgMZi9kqo20Cpfe2LRHYkkI8yXP7BwTEC+f0Ybrx0iHMCD3BJyVd8k s2K9XOOdeEmijIHq0g6D6t23IS7vjJM2T6YczZcXfSo6yWXgraDZ3maaLNOF6NWWscxdv081A zh3eCOG3jLjnBJ9DC9JRwqpes0Fqm5dX3dC4C58haahKylaUiLmy1jyw6h+KUZUWSt/ykHPrv hq2s/tRF8hjrzdr5bajFU2DEokhYnJMsEU8jMHcMi82RJfLI5mpDKzfH/stpgjjAPHg4YmyLW 9F+Q2nYWN61fZZFSvL5nYDwfZtdGh7JXuGCq9t+I6/VsANn37TeIRyqU606/osoA8v Received-SPF: pass client-ip=212.227.17.21; envelope-from=stephen.berman@gmx.net; helo=mout.gmx.net X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: In buffers containing widgets, such as the Customize buffers, the widgets can be either active or inactive: when you click (with the mouse or RET) on an active widget, its associated action is execute [...] Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [88.130.48.38 listed in zen.spamhaus.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stephen.berman[at]gmx.net) 0.0 T_SPF_PERMERROR SPF: test of record failed (permerror) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 SPOOFED_FREEMAIL No description available. X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.6 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: In buffers containing widgets, such as the Customize buffers, the widgets can be either active or inactive: when you click (with the mouse or RET) on an active widget, its associated action is execute [...] Content analysis details: (2.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [88.130.48.38 listed in zen.spamhaus.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stephen.berman[at]gmx.net) 0.0 T_SPF_PERMERROR SPF: test of record failed (permerror) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager --=-=-= Content-Type: text/plain In buffers containing widgets, such as the Customize buffers, the widgets can be either active or inactive: when you click (with the mouse or RET) on an active widget, its associated action is executed, and when you click on an inactive widget, this raises the error "Attempt to perform action on inactive widget". You can navigate among the widgets by pressing TAB or S-TAB to move point to the next or previous widget. I think it would be useful and convenient to skip over inactive widgets when tabbing; e.g. you then avoid accidentally tabbing to an inactive widget, typing RET and getting the error, and in a buffer with many active and inactive widgets, you can tab more quickly to the desired active widget by skipping over the inactive ones. The attached patch implements this behavior. Since tabbing to inactive widgets has always been the behavior in the widget library, skipping is conditioned on the value of a boolean defcustom, with the default being the current non-skipping. In GNU Emacs 30.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.41, cairo version 1.18.0) of 2024-04-16 built on strobelfs Repository revision: b436f430e3897e1aa6dcb5a39564a3553bbf631f Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101013 System Description: Linux From Scratch r12.1-41 Configured using: 'configure 'CFLAGS=-Og -g3' PKG_CONFIG_PATH=/opt/qt5/lib/pkgconfig' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG LCMS2 LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB --=-=-= Content-Type: text/x-patch Content-Disposition: attachment Content-Description: skip inactive widgets patch Content-Transfer-Encoding: quoted-printable diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el index 172da3db1e0..b40d4bf8898 100644 =2D-- a/lisp/wid-edit.el +++ b/lisp/wid-edit.el @@ -1219,11 +1219,20 @@ widget-button-press (when (commandp command) (call-interactively command)))))) +(defcustom widget-skip-inactive nil + "If non-nil, skip inactive widgets when tabbing through buffer." + :version "30.1" + :group 'widgets + :type 'boolean) + (defun widget-tabable-at (&optional pos) "Return the tabable widget at POS, or nil. -POS defaults to the value of (point)." +POS defaults to the value of (point). If user option +`widget-skip-inactive' is non-nil, inactive widgets are not tabable." (let ((widget (widget-at pos))) - (if widget + (if (and widget (if widget-skip-inactive + (widget-apply widget :active) + t)) (let ((order (widget-get widget :tab-order))) (if order (if (>=3D order 0) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 16 08:54:13 2024 Received: (at 70413) by debbugs.gnu.org; 16 Apr 2024 12:54:13 +0000 Received: from localhost ([127.0.0.1]:43748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwiKC-0001oJ-Tx for submit@debbugs.gnu.org; Tue, 16 Apr 2024 08:54:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwiKA-0001n5-8S for 70413@debbugs.gnu.org; Tue, 16 Apr 2024 08:54:11 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rwiJs-0005ma-KC; Tue, 16 Apr 2024 08:53:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=BNtRnObEQ+SsdF5wG+uz2o4UTZdhKyGTzXMLZG+YqtY=; b=lOxB+qBW7KE/ 21yJzAnNwz7YuS2M/+PskRzizKhRgM29cMblVrzYWdUoMQNRX8aOBJXFkYNGHNsrJ1rAYNjzdhlY/ 9pOjI8cUrMIP9hxk5xCL6+8ovauZg31g4F3TQJJLmdN/1FyGK4/Oiw8uRuNPhrMQo/Hc6/tBYdm5D ZFWqjqfAVKnE114IeA08PDHzyHRnaMkrzZFTEsRq093oCIaXrZ9OKWMt5HuZMy8OM2DrjfF3ewvoW Oj+PEXZhANz6p2WQ4mGp5RFQLxXrv4j/vqnYSpQtuKX97f+Pt1yE99GZfT4MsA7X1ETTWwYb4UKif sfVgeBOImsg70a6FZ7etrg==; Date: Tue, 16 Apr 2024 15:53:48 +0300 Message-Id: <865xwhjwo3.fsf@gnu.org> From: Eli Zaretskii To: Stephen Berman In-Reply-To: <87zfttpstx.fsf@gmx.net> (bug-gnu-emacs@gnu.org) Subject: Re: bug#70413: 30.0.50; FR: skip inactive widgets when tabbing References: <87zfttpstx.fsf@gmx.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70413 Cc: 70413@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Tue, 16 Apr 2024 11:20:10 +0200 > From: Stephen Berman via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > In buffers containing widgets, such as the Customize buffers, the > widgets can be either active or inactive: when you click (with the mouse > or RET) on an active widget, its associated action is executed, and when > you click on an inactive widget, this raises the error "Attempt to > perform action on inactive widget". You can navigate among the widgets > by pressing TAB or S-TAB to move point to the next or previous widget. > > I think it would be useful and convenient to skip over inactive widgets > when tabbing; e.g. you then avoid accidentally tabbing to an inactive > widget, typing RET and getting the error, and in a buffer with many > active and inactive widgets, you can tab more quickly to the desired > active widget by skipping over the inactive ones. > > The attached patch implements this behavior. Since tabbing to inactive > widgets has always been the behavior in the widget library, skipping is > conditioned on the value of a boolean defcustom, with the default being > the current non-skipping. This is OK, but please announce this new option in NEWS. From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 16 17:56:59 2024 Received: (at 70413) by debbugs.gnu.org; 16 Apr 2024 21:56:59 +0000 Received: from localhost ([127.0.0.1]:45271 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwqnT-0005cQ-0q for submit@debbugs.gnu.org; Tue, 16 Apr 2024 17:56:59 -0400 Received: from mout.gmx.net ([212.227.17.22]:46001) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwqnQ-0005bY-4C for 70413@debbugs.gnu.org; Tue, 16 Apr 2024 17:56:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1713304597; x=1713909397; i=stephen.berman@gmx.net; bh=sEJvaXsiX28ILceOwEKYDT4Cr+XFyhJGPXumpBzgsMs=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=ix/Hfm7VbwsAJ5rzs0x18WY4jcwSIedbmmce8XmmaHd1+QXuxABXS+kCYxp+lCeH q8MlfLkKLkxwgikjaRBoIJXYJJVPf67wgbj5NZJRlFHPTQfQpRwps55vJgMrPwJvl KaC+5MoKrXNacOOVxwFicKt2zdv313SmLHJ0ZBDaGVTYLc3Sh/HN2Bxv0NwhPO/C+ CnkH2a3msyAa3r8CeJuBHexHXXLhp9wo8rVzLZOF9Fiyeje+UgmL0G81uQehwleT+ JiirrJUdNilKtoxlQFoibyMkIMSNrd61A0aR+/DbefGrlxQVTkork0hxCnfo53J5A mJisJkTGPEr3WE1cPA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs ([88.130.48.38]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MMGNC-1sCjFT1JSw-00JGWX; Tue, 16 Apr 2024 23:56:37 +0200 From: Stephen Berman To: Eli Zaretskii Subject: Re: bug#70413: 30.0.50; FR: skip inactive widgets when tabbing In-Reply-To: <865xwhjwo3.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 16 Apr 2024 15:53:48 +0300") References: <87zfttpstx.fsf@gmx.net> <865xwhjwo3.fsf@gnu.org> Date: Tue, 16 Apr 2024 23:56:36 +0200 Message-ID: <87v84hott7.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:Vbu74D9NeLTqAR3vo3jv8+agkUuUbKzJVTRt1l5gCMUHAyOuDhx pSisB/6whlhHg2QDn0Db/8E+w6L8hmGuyuJ3+os7OQKFGGpxZXkgJSQizbGbLpf0sLJje4a cyPuOc20N+Nyj1G19Qs410hnavQxuszJL+iExJH9tos0u8+TKe/IblWR1UTyrHaBM8ZZsBm /mhBb39iEb84EF7btFVrA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:qXcOlFaeCTI=;Yv1mZ3yad4XH5Am9ZnPt2f4CLN/ 8ZtTraKI/4r6Y/NpincOUxGol5UMFToZmtlZVDCJFgciQlu3UWE7dO0424CRFNV9x0EWD31fV HEOngNcY4mnXbVQcXI6h62eNbMDcfoJLYq/kc5QQ0sh++qtyCWL8QKxSDB9RkkBahiX/S8X4y 0pv0YTs+Ckq3ZBJCpJv+TNVVtPU9rKckMwKRLirhkj+vEUJdZJRR28s+sXMbabJP9J03CQ4+b Brk3P1bQ45Q8toZFFWeeISujiMkpsBT3DaZAOahf6GendNOzVn7/CQRVV/uTz4+TLuA4PXyJW K0YQ18f3RVYwxa73rl0mn7cHJ5pXnktMAf/MyVvnB0K20qRWemfbYL24r3luR8gnk6oJGDJUR vSpQJKA1kN5hzHn9c38PxqGGgK+ZgPYtlf3gJCGyl2+l56Pyqxz8rbKYieyZpKHy2Gep5J3Xt r9ma0MIFcanAlcd2g0/CohglbINKa3qGz9++7uEQKbigdjj89C84y+sU4kkuBCUsXNnaJw1kS HgxuQlnMTQCGtT1VCoQ9UISLOqHox7ZFY5JR2uhaqYEL0pppj3rPdA/4B7lsOD4X2fwBxnd/i DxbMT0dWzQKocOvs0wqHBcTDtcuCd2VCM6Rv2cxaFRjcISIz4O3EKAbfbGKAl9AnZJPZLX2Qi 64t+embj21KSSW16pdTF5QeWE7BxvK+WD2ND4qlMX6pcNtwI+4fV9adHqLVApXSBD7Qa0edeq 161FP3I7WJ9tpaZGTSvmGSSZrWCAEW2Cb3G6HcNNoqrQvABDfpUdnqni/qoy1/CR7HW1g5ksG 2aFhNyr0ykYEVzVAnKuaQ+HXPmsfCVERkWsmiitUlsCd4= Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70413 Cc: 70413@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Tue, 16 Apr 2024 15:53:48 +0300 Eli Zaretskii wrote: >> Date: Tue, 16 Apr 2024 11:20:10 +0200 >> From: Stephen Berman via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> In buffers containing widgets, such as the Customize buffers, the >> widgets can be either active or inactive: when you click (with the mous= e >> or RET) on an active widget, its associated action is executed, and whe= n >> you click on an inactive widget, this raises the error "Attempt to >> perform action on inactive widget". You can navigate among the widgets >> by pressing TAB or S-TAB to move point to the next or previous widget. >> >> I think it would be useful and convenient to skip over inactive widgets >> when tabbing; e.g. you then avoid accidentally tabbing to an inactive >> widget, typing RET and getting the error, and in a buffer with many >> active and inactive widgets, you can tab more quickly to the desired >> active widget by skipping over the inactive ones. >> >> The attached patch implements this behavior. Since tabbing to inactive >> widgets has always been the behavior in the widget library, skipping is >> conditioned on the value of a boolean defcustom, with the default being >> the current non-skipping. > > This is OK, but please announce this new option in NEWS. Thanks; see the attached patch. I think this user option should also be documented in the Widget manual, so the patch includes that as well. The Widget manual has a node for widget customizations, so I added it there. But I think it is helpful to mention it also in the node "Widgets and the Buffer", where the tabbing commands `widget-forward' and `widget-backward' are documented, so that patch does that too. If you confirm this is ok, I'll push the code and doc changes to master. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 16 18:04:58 2024 Received: (at 70413) by debbugs.gnu.org; 16 Apr 2024 22:04:58 +0000 Received: from localhost ([127.0.0.1]:45292 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwqvB-0006fz-I5 for submit@debbugs.gnu.org; Tue, 16 Apr 2024 18:04:58 -0400 Received: from mout.gmx.net ([212.227.17.20]:40229) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwqv6-0006et-MH for 70413@debbugs.gnu.org; Tue, 16 Apr 2024 18:04:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1713305074; x=1713909874; i=stephen.berman@gmx.net; bh=d4b2ghEJsKrnlHHAHYyK1waopPnQmbuS87D5qm0QK3M=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=TYNycwKyo3SxNN0WmyeFScC+7zhU65sQBM327uLPHYAqQoymwYGpIrGLSF+DNVaz wkUO61FjL6FdfrBH4wm3aqdbveFxvf9bHv4CTruS7JY9Cwh9fv6O8mS9wWBtKjKkG +BHduRIpmn4fBb6r41heTInL9lV6XL0gUuQBoqXMpZSr3tt2R6q13q01xpcH5U68c gT3ntjFKDSebWWSCVQXd26XmSxb1cBobfiOzmr05OGmlVGBqCohngVNJ86YuY56u2 l+asFnZkAQod5nPGF2E5YsDZfqqQXm4w1tP85SFbHot2eSyw2YR6z3+aDZnDqiTb9 I6QveTpcOnugjOjiLw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs ([88.130.48.38]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M4JmT-1rx7tj03Wr-000KeA; Wed, 17 Apr 2024 00:04:34 +0200 From: Stephen Berman To: Eli Zaretskii Subject: Re: bug#70413: 30.0.50; FR: skip inactive widgets when tabbing In-Reply-To: <87v84hott7.fsf@gmx.net> (Stephen Berman's message of "Tue, 16 Apr 2024 23:56:36 +0200") References: <87zfttpstx.fsf@gmx.net> <865xwhjwo3.fsf@gnu.org> <87v84hott7.fsf@gmx.net> Date: Wed, 17 Apr 2024 00:04:33 +0200 Message-ID: <87r0f5otfy.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:4MILmmyAJtItaZYkdazl6IyeCeF95w8KoAIIH7Y098hKzQAFe3I DW87KGDrdec9bEB1oOsNQYmdfuQCVN4XDg16rrFUNf7dY0MZ7D6XomXV/ZZuBp/4BFiC76m 6PDvQXpXuiz9F5BuWdWqFyt5f37LllGQpEmF6AzdK/agCqHDFS3sfnJqYgSncxT/Yu1S+VN W5EVU5Ec2LC4pBHvXcUhQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:5oA2vUI3Yyw=;t88J+FiSsDPKxP6YCIUV4Gur1sb +eEEWocgVQx+0dj+q9JXjH4WjDdDs1J3lawiqOEwNU7Td5hsR2VmPMqyqsO1Vywh8pqD814EB I5KkuoKJRQYhHS21PhFdDCtETl681o0exIE19wBXCD+QbJa7+dq+wc850zaVfSnXZ6V9BpVAc G5UTgE3+o3CT/xWC9qzdgC5n7+YMHz6S5iHjLur9RQy+0nbnzlnA269Oa4QaKiBhkMl7dmmRO EtxqZIsGWfB72LlWTLy/ZG3b2Yh+770QxLgLRaPiuzkHkLmXGL4ir27Ovs81SNVFrH48pldiP XWO6g1NArakaJRyEwJCKoDXbQVZPKdyiByuC9Fc9uNzpZag3JYnNHFj0QGujVlUkmw98WGeU3 Z00sq8LEzqdCN+swnJHPIZMU7od9Rf27wxfApBYLSELtKVma5nr4SxIPVSJrpZl2LnEziCNod 4Lg0Dp6gf9h1mL2xszjLh1EEsWLCwUVH8R2gj7ykQA8VkWO2NhspwEMpqNruQEWodK1yWr6Wv 92F5UlXrdUa1YlB1ywykoJ7kloBJLFwAW3ipIGDKkfbB0nHYRQaZ0APMBAMqhf4RX8dGWp9tc PWq9t4cjjNy4oszxTK3AkA64vEp+dK1eGB3d4OGhzDSFId1x8a4HE8M+IfXiYKvh3l4bjpKso YIGWQyl1HtnC6haNaeMqrimdiiF9FKqsA1gJ/g/s3cYGrw1PksiwAmQK3iieX9DR4rXlWBln9 A3sP4NlhcfAjqiFao0n6Aa51TYVTN1QPcvTfDoT/eH+JRcLt235oj1LxRUp3EScOYIIhmdKHw Q/xRcUIrPWlEekKr0MI9EgeFqwytbp/1jCSGffuw9mKFk= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70413 Cc: 70413@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Tue, 16 Apr 2024 23:56:36 +0200 Stephen Berman = wrote: > On Tue, 16 Apr 2024 15:53:48 +0300 Eli Zaretskii wrote: > >>> Date: Tue, 16 Apr 2024 11:20:10 +0200 >>> From: Stephen Berman via "Bug reports for GNU Emacs, >>> the Swiss army knife of text editors" >>> >>> In buffers containing widgets, such as the Customize buffers, the >>> widgets can be either active or inactive: when you click (with the mou= se >>> or RET) on an active widget, its associated action is executed, and wh= en >>> you click on an inactive widget, this raises the error "Attempt to >>> perform action on inactive widget". You can navigate among the widget= s >>> by pressing TAB or S-TAB to move point to the next or previous widget. >>> >>> I think it would be useful and convenient to skip over inactive widget= s >>> when tabbing; e.g. you then avoid accidentally tabbing to an inactive >>> widget, typing RET and getting the error, and in a buffer with many >>> active and inactive widgets, you can tab more quickly to the desired >>> active widget by skipping over the inactive ones. >>> >>> The attached patch implements this behavior. Since tabbing to inactiv= e >>> widgets has always been the behavior in the widget library, skipping i= s >>> conditioned on the value of a boolean defcustom, with the default bein= g >>> the current non-skipping. >> >> This is OK, but please announce this new option in NEWS. > > Thanks; see the attached patch. I think this user option should also be > documented in the Widget manual, so the patch includes that as well. > The Widget manual has a node for widget customizations, so I added it > there. But I think it is helpful to mention it also in the node > "Widgets and the Buffer", where the tabbing commands `widget-forward' > and `widget-backward' are documented, so that patch does that too. If > you confirm this is ok, I'll push the code and doc changes to master. > > Steve Berman ... and here's the patch: --=-=-= Content-Type: text/x-patch Content-Disposition: attachment Content-Description: widget doc and NEWS patch Content-Transfer-Encoding: quoted-printable diff --git a/doc/misc/widget.texi b/doc/misc/widget.texi index cfb9d2211cf..154d8446b75 100644 =2D-- a/doc/misc/widget.texi +++ b/doc/misc/widget.texi @@ -795,6 +795,11 @@ Widgets and the Buffer @end deffn @end table +@noindent +By default, tabbing can put point on an inactive widget. To skip over +inactive widgets when tabbing, set the user option +@code{widget-skip-inactive} to a non-@code{nil} value. +@xref{Customization}. When editing an @code{editable-field} widget, the following commands are available: @@ -3321,6 +3326,15 @@ Customization By default, its value is @code{nil}. @end defopt +@defopt widget-skip-inactive +If non-@code{nil}, navigating between widgets by @kbd{M-@key{TAB}} +(@code{widget-forward}) or @kbd{S-@key{TAB}} (@code{widget-backward}, +also bound to @kbd{M-@key{TAB}}) skips over inactive widgets. + +By default, its value is @code{nil} and tabbing does not skip over +inactive widgets. +@end defopt + @defopt widget-documentation-links If non-@code{nil}, add hyperlinks to documentation strings. @end defopt diff --git a/etc/NEWS b/etc/NEWS index 99f33a7b8dd..7b87e0b17c5 100644 =2D-- a/etc/NEWS +++ b/etc/NEWS @@ -1603,6 +1603,13 @@ This allows disabling JavaScript in xwidget Webkit = sessions. 'insert-directory', now supports the '--time=3DTIME' and '--sort=3Dtime' options of GNU 'ls'. +** Widget + ++++ +*** New user option 'widget-skip-inactive'. +If non-nil, moving point forward or backward between widgets by typing +TAB or S-TAB skips over inactive widgets. The default value is nil. + =0C * New Modes and Packages in Emacs 30.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 17 08:05:13 2024 Received: (at 70413) by debbugs.gnu.org; 17 Apr 2024 12:05:13 +0000 Received: from localhost ([127.0.0.1]:45941 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rx42G-0000NO-JN for submit@debbugs.gnu.org; Wed, 17 Apr 2024 08:05:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rx42B-0000L1-8w for 70413@debbugs.gnu.org; Wed, 17 Apr 2024 08:05:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rx41l-0005z8-Jo; Wed, 17 Apr 2024 08:04:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=vpN/ESEAmA3rseacF+lGV/TD9YKWu1XSzRPH8+9fJxc=; b=OjHYcO6QpEVU De7/Rg+GXidpQcw4/+/Uim/WbJuxqqTRtxDv9jIMCCL2NqPflCbb3pKPXmS9XmVsvzhvWuRvoci6I EAkTAcHa/xjeiz2WTJz4iUGxhRs5tfHK4xHTxbpEwJCLfdFuPjcC5pO0Ku6mxYu25ssvSqlQAL5a1 sulghVOFaBXodP7rFM336g1Yj6LWwax3LeUaFDxmXHIFwiT6jq0C0ByjJYfudXYXwYdexiMcI5SWI mJSreI0bPxc7qedhSf9KASzoVxZ2z7ciHIApsw59Tj9Q6cM8cw0Y432DJJCs9W7fmIaa3YlWsqEGu hIxt7+FjZ3kEZ6OxrxuBbA==; Date: Wed, 17 Apr 2024 15:04:34 +0300 Message-Id: <865xwgi4a5.fsf@gnu.org> From: Eli Zaretskii To: Stephen Berman In-Reply-To: <87r0f5otfy.fsf@gmx.net> (message from Stephen Berman on Wed, 17 Apr 2024 00:04:33 +0200) Subject: Re: bug#70413: 30.0.50; FR: skip inactive widgets when tabbing References: <87zfttpstx.fsf@gmx.net> <865xwhjwo3.fsf@gnu.org> <87v84hott7.fsf@gmx.net> <87r0f5otfy.fsf@gmx.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70413 Cc: 70413@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stephen Berman > Cc: 70413@debbugs.gnu.org > Date: Wed, 17 Apr 2024 00:04:33 +0200 > > > Thanks; see the attached patch. I think this user option should also be > > documented in the Widget manual, so the patch includes that as well. > > The Widget manual has a node for widget customizations, so I added it > > there. But I think it is helpful to mention it also in the node > > "Widgets and the Buffer", where the tabbing commands `widget-forward' > > and `widget-backward' are documented, so that patch does that too. If > > you confirm this is ok, I'll push the code and doc changes to master. > > > > Steve Berman > > ... and here's the patch: LGTM, with 2 minor comments: > +@defopt widget-skip-inactive > +If non-@code{nil}, navigating between widgets by @kbd{M-@key{TAB}} ^^^^^^^^^^^^^^^^^ This should probably be @kbd{key{TAB}}. > +(@code{widget-forward}) or @kbd{S-@key{TAB}} (@code{widget-backward}, > +also bound to @kbd{M-@key{TAB}}) skips over inactive widgets. ^ I'd add a comma there. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 17 09:58:20 2024 Received: (at 70413) by debbugs.gnu.org; 17 Apr 2024 13:58:20 +0000 Received: from localhost ([127.0.0.1]:46116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rx5nn-0008Fa-Lr for submit@debbugs.gnu.org; Wed, 17 Apr 2024 09:58:20 -0400 Received: from mout.gmx.net ([212.227.17.20]:44231) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rx5nj-0008ED-Pg for 70413@debbugs.gnu.org; Wed, 17 Apr 2024 09:58:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1713362276; x=1713967076; i=stephen.berman@gmx.net; bh=dTXA/6QwoqJlKpcM91iHJ2V8AgdxvgwPYK+LcAnooHM=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=JA4vs+T+XpE8jhlmdl9FLHd8I/pKWJH7QHjd5xiJpNyu49Z3pnFHRFiCh64BKZtl GohrbZSwbnReC344zmQSsFVOkSP0tQuTT9CpBOY8E33CTIDVUmWBg/y8JgyN61+o5 eXdvZWJ71u4Yubbo4g615mJTy+AVYtIaFpbbG/JwMagYA3uBzON1U2z3rl+wIAusz 9VbcI5WfkzLkkMRwhZ6NWq4T5mtutqTqyRrlwYF1Fh+eHhEiruox4c8K7DK1uuljK pfYBgRIXjWN1F/GZRZ2kvNzALseubQVwLhk6OX2RCXw9H2gVpSb8iZNIyUexlQHZr G8cLspGSbQStrd+oIw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs ([94.134.94.216]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MDQic-1s4H3a2tHy-00ASz2; Wed, 17 Apr 2024 15:57:56 +0200 From: Stephen Berman To: Eli Zaretskii Subject: Re: bug#70413: 30.0.50; FR: skip inactive widgets when tabbing In-Reply-To: <865xwgi4a5.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 17 Apr 2024 15:04:34 +0300") References: <87zfttpstx.fsf@gmx.net> <865xwhjwo3.fsf@gnu.org> <87v84hott7.fsf@gmx.net> <87r0f5otfy.fsf@gmx.net> <865xwgi4a5.fsf@gnu.org> Date: Wed, 17 Apr 2024 15:57:56 +0200 Message-ID: <87bk688523.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:S8Rsvk40s4bWA2GTA+SAIM5IIHbY5UxELA/OryslfvuFD9K97t5 hYnrZl6hmfzTQuDvPCrlJXIoSoAEkPIBDuZALwieDiUUPfWc0p0Cn0l1RZeuZ+sl+4sg4+E 28esGNxp9SUSV/rJ5+RdD71a3TwyKnuopaSX0A2iRzzYpKKQ/sv3Nw8NQTgyP1cqrqroSNV OfSR6KBy8T0KkH/+7Rvlg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:yFBqtd++FOU=;insuuNtSFeZAJZzh4FQt0MkIlr+ ZFikFazkXsgrzHJFCI/gIv8ni12KnwkeKMiuiz4tE+eUb1LtyS1vMZXMTItvG1sd1mv3w8rQn IPTlG9NUePwptM+tED3pGNbTG+olpxX9bPE0SwpPXOvVcCBS0EXat7dMapGzoHkc7tAygHsxm bspHBdLbCpReeE7yg3AxA0I9qwR79k0kKv4w9r9RYU3RRMBfeDjYoGzFP51XJJHli2eYoGXqk HpiA9gtjXNp0LqXloXoyPYJXhmYduNbETrCIXjIhz0vjz0A0pDtlJZDKk4cEB6qHZc2j4dnwS 6T9ec+dUO1WqUPIdhxqmOF2EZiTj/ol2AYlr0rifM2ZagYso3kZZh1f99mNjT6Tt/WAwCxuFw 0B+TyctnfWzGAPizqo2Z3cwQ9U0ErNUIHwH89ee41WuY4B8ksUhj539/d0z9vUX2hidxRN2T0 Q1bcH5ohTB76NJC40yj7mPrilsEzzaTOdEyPJjd776PQx6Hf6N7LsDgPcCZhszhSCOgR6XjKG 7sXXregg+WrRaucKdBSS9++rzIgcmv0GDEqKmUQXkeM8rlEuV5af/umzWDEYA+P07MyZtQle+ TJ096BtuwVJVKrvZw4I33TEoF2jGjglEdeM4GgIIum/scGK/yKpyj+p5r7tHXyPrCTJLXleyT mjttSbzHuHbdH+xqQna+Gtv8u3BihvYJAKnsgqotavIjeA1y9o7QwX4sOB7OCWMzoghHwNsTi ZD9/Pknl2JYte7pSb1LAhH5E0VWNdcO/B0D1YnRUldiCquLEV80oV6aYFrNLAC9+0LW4oO5PL +EZKJYCqorlUzoKe6hrv1DYIPFxW2RWQofE38/FmEqH/U= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70413 Cc: 70413@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Wed, 17 Apr 2024 15:04:34 +0300 Eli Zaretskii wrote: >> From: Stephen Berman >> Cc: 70413@debbugs.gnu.org >> Date: Wed, 17 Apr 2024 00:04:33 +0200 >>=20 >> > Thanks; see the attached patch. I think this user option should also = be >> > documented in the Widget manual, so the patch includes that as well. >> > The Widget manual has a node for widget customizations, so I added it >> > there. But I think it is helpful to mention it also in the node >> > "Widgets and the Buffer", where the tabbing commands `widget-forward' >> > and `widget-backward' are documented, so that patch does that too. If >> > you confirm this is ok, I'll push the code and doc changes to master. >> > >> > Steve Berman >>=20 >> ... and here's the patch: > > LGTM, with 2 minor comments: > >> +@defopt widget-skip-inactive >> +If non-@code{nil}, navigating between widgets by @kbd{M-@key{TAB}} > ^^^^^^^^^^^^^^^^^ Oops, that was copy-pasta; thanks for catching it. > This should probably be @kbd{key{TAB}}. Or rather @key{TAB}, right? That's what's used earlier in the Widget manual and IIUC is what (info "(texinfo) @key") recommends. >> +(@code{widget-forward}) or @kbd{S-@key{TAB}} (@code{widget-backward}, >> +also bound to @kbd{M-@key{TAB}}) skips over inactive widgets. > ^ > I'd add a comma there. AFAIK, according to the usual rules of comma usage in English, a comma should not be used there, since the entire phrase "navigating between widgets by =E2=80=98=E2=80=99 (=E2=80=98widget-forward=E2=80=99) or = =E2=80=98S-=E2=80=99 (=E2=80=98widget-backward=E2=80=99, also bound to =E2=80=98M-=E2=80=99)" is the subject of "skips". But I= grant that, due to the length of this phrase and the parenthetical phrases it includes, it does prosodically "feel" like there should be a comma. The following reformulation avoids this, and moreover conforms better to the style of the Widget manual by using the imperative form "skip": If non-@code{nil}, skip over inactive widgets when using @key{TAB} (@code{widget-forward}) or @kbd{S-@key{TAB}} (@code{widget-backward}, also bound to @kbd{M-@key{TAB}}) to navigate between widgets. Is this formulation acceptable? Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 17 11:43:17 2024 Received: (at 70413) by debbugs.gnu.org; 17 Apr 2024 15:43:18 +0000 Received: from localhost ([127.0.0.1]:46609 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rx7RL-0004IE-Nu for submit@debbugs.gnu.org; Wed, 17 Apr 2024 11:43:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59986) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rx7RH-0004Gu-J4 for 70413@debbugs.gnu.org; Wed, 17 Apr 2024 11:43:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rx7Qy-0005AL-T2; Wed, 17 Apr 2024 11:42:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=0H7dP7WNug5JcY0dNq/k4GFxrzkM6XXkPfOMFo9kuY0=; b=Npry6DyfSQ+R kGua+G91Zad6pmaYaj38s3FwFQRNgeI8Rx0axihlENLwcM1aJKw1wX6/0jwFErLTRZEGS666jjbjl 0Wt9JMcRgK3QFchIQw59xGegRBrmwX7d6LbxWFqiKWK7CtW7QmhUggjPebr6T8TeWT+ycwLy1iajB fxKe/AzEWW24q7UMGGTJPiT46iegJbp/EgZ4++Q3p4KRIB/LYRekntrRRu+lX+A7Ak58HDtDx9Jz1 NpcJTOgC1G1kth77zxYSZfEbTyc7dWwDihOuaSFr2zXWb4vX5JRxsPcJ4pdgwLVw55Sg4mBEcUPYp GrgMt96R8VHXxKzpoU/cLw==; Date: Wed, 17 Apr 2024 18:42:49 +0300 Message-Id: <86frvkgfly.fsf@gnu.org> From: Eli Zaretskii To: Stephen Berman In-Reply-To: <87bk688523.fsf@gmx.net> (message from Stephen Berman on Wed, 17 Apr 2024 15:57:56 +0200) Subject: Re: bug#70413: 30.0.50; FR: skip inactive widgets when tabbing References: <87zfttpstx.fsf@gmx.net> <865xwhjwo3.fsf@gnu.org> <87v84hott7.fsf@gmx.net> <87r0f5otfy.fsf@gmx.net> <865xwgi4a5.fsf@gnu.org> <87bk688523.fsf@gmx.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70413 Cc: 70413@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stephen Berman > Cc: 70413@debbugs.gnu.org > Date: Wed, 17 Apr 2024 15:57:56 +0200 > > On Wed, 17 Apr 2024 15:04:34 +0300 Eli Zaretskii wrote: > > >> +@defopt widget-skip-inactive > >> +If non-@code{nil}, navigating between widgets by @kbd{M-@key{TAB}} > > ^^^^^^^^^^^^^^^^^ > > Oops, that was copy-pasta; thanks for catching it. > > > This should probably be @kbd{key{TAB}}. > > Or rather @key{TAB}, right? That's what's used earlier in the Widget > manual and IIUC is what (info "(texinfo) @key") recommends. No, @kbd{@key{TAB}} is correct when you are talking about user typing something (as opposed to talking about the key TAB). Texinfo explicitly tells you that @key is for naming a key, not for describing user input. > If non-@code{nil}, skip over inactive widgets when using @key{TAB} > (@code{widget-forward}) or @kbd{S-@key{TAB}} (@code{widget-backward}, > also bound to @kbd{M-@key{TAB}}) to navigate between widgets. > > Is this formulation acceptable? Yes, thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 17 13:36:30 2024 Received: (at 70413) by debbugs.gnu.org; 17 Apr 2024 17:36:30 +0000 Received: from localhost ([127.0.0.1]:47116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rx9Cu-0003MB-Vl for submit@debbugs.gnu.org; Wed, 17 Apr 2024 13:36:30 -0400 Received: from mout.gmx.net ([212.227.15.15]:49059) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rx9Cq-0003Km-3M for 70413@debbugs.gnu.org; Wed, 17 Apr 2024 13:36:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1713375365; x=1713980165; i=stephen.berman@gmx.net; bh=ecUXnNRz12009SxUSqkMZktMB5oM49opV3irkoCw8Xw=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=dms6Qo5jPpCCm4EJtq35QPXqATIhG2DEAQaqsWz5QYEY/TXrBGLl5eb5gksBmysa rNbDygKnx4NloYKP5a9RZMKOAHQKppxoFJXTl5RhUVnDI/gMt/UqfZvi2D+lzsa3x 23QdPsMxH8s3MEwKDAlareddjEPF0qUJpwteOkOWRJrywvHSJic3YIdugqn8mRg72 aASWMWWcsfKO9KfJZBkymTRwxQXQ5qvJu9U798jjLOQOWP0cS9jVwYQ9sclRRP6J9 UrvAyCCPdmuV6jzGDQYWHj/QD+uh3TYaDfTAPsBFy0GXb9ZsOc1tM0EGtKfuOt4SW 7OSojKRl7HgWPo6nJg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs ([94.134.94.216]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N49lD-1sff3F3ZYn-0107Et; Wed, 17 Apr 2024 19:36:04 +0200 From: Stephen Berman To: Eli Zaretskii Subject: Re: bug#70413: 30.0.50; FR: skip inactive widgets when tabbing In-Reply-To: <86frvkgfly.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 17 Apr 2024 18:42:49 +0300") References: <87zfttpstx.fsf@gmx.net> <865xwhjwo3.fsf@gnu.org> <87v84hott7.fsf@gmx.net> <87r0f5otfy.fsf@gmx.net> <865xwgi4a5.fsf@gnu.org> <87bk688523.fsf@gmx.net> <86frvkgfly.fsf@gnu.org> Date: Wed, 17 Apr 2024 19:36:04 +0200 Message-ID: <877cgv99iz.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:MUtqCk7udKc5AoducKH5RZn+UXlsBWHEteNr2yJmMkXx+azRMQm 6ABK/gR5/WNnYaUs38pvuqMg7QldFaJY/X9eiV5VKhH5v7cNI3XTncZKSNxCuXToJrbeaiS bnK8REm6FkCZUg91jbm/0Yhi41seOKI9xvOM943sXtzmXNROaoDMxVfpwvK35wqRn2k/juo IN+qFFxWgiXA2+P2U6jDw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:xJxUq2BQZtI=;OqKLzWTIGLOuit5hajsU1/iAAM/ IKBxzbUCPv2vFGDwEMtbefJ6Umv35OEvuZ7NtPXpq4wav9GmC8u4Uv52vZ0Y99KLOg+ZwyCMv 7ZQeMqMYTCxZ/qWItgX5wLSR2iRktkofLnQN4AQSUwP3sQIppIGALViKzua/qiWVvPJnzCASr 0UdApHyntIFtIbTewwI80ZoM1bpxTA5lIQtbcr65afD6mPbiP+3Ywck/Xoql+cVI47qpoHPZJ EXUdr02MvAuu89jhK+vWsujh6tM4Sbj5B2nOC7I9WkwMDeWsQJ27j4wdHefIF/HdUpvT+QfgS h8pkSeLzueAKrenMS5Kbr+eTLoS8HvRyW4OYnUyw80EVe9YPYIJPb/S71klvp4r7waDv+IKvl Tqbdib4kU5E7q2s2wBjdEjah51u/emdtsflX11D+yDJrwRgoAud7fJG1RmasTm5mJiMW7OkIJ bwrly4Ksz4Jq8GMSgfUEW20GzCZurfVeHLQhF6VHDIAl55esE3B5gFfaKqVLsLTIWKwcJc+m9 D12/wOybZVNOrjz7n9o0Csprhy3VWsV3MEHiPJ3DFeEC8P0/OyjCmLoRVD3t8dTe9WEBO3Dov 0dhyjMwuqEeE95qY/+p6PESBulSxOjw0RakiES1VWw8xuHdCgkXSoU6Z7eAKOM9TmTqK28pUO yll0pU9m5GNwiIWDZ/lYJZncvDqCzTMntW7F/5vkH1KqmtIximcM2QHoA2g69G7gYKLF9ZGPV 3hT+M7tiR0tdYnV1OpPzxNbcMgaVGsUdu2jZqrdOokfpD1azdqJBEyfvfiaxoVYl+x1vHFnlN sdSYqz2alB9DozPO/Rof0NHdNwAIViOFKqRxGVhPNF5Ho= Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70413 Cc: 70413@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Wed, 17 Apr 2024 18:42:49 +0300 Eli Zaretskii wrote: >> From: Stephen Berman >> Cc: 70413@debbugs.gnu.org >> Date: Wed, 17 Apr 2024 15:57:56 +0200 >> >> On Wed, 17 Apr 2024 15:04:34 +0300 Eli Zaretskii wrote: >> >> >> +@defopt widget-skip-inactive >> >> +If non-@code{nil}, navigating between widgets by @kbd{M-@key{TAB}} >> > ^^^^^^^^^^^^^^^^^ >> >> Oops, that was copy-pasta; thanks for catching it. >> >> > This should probably be @kbd{key{TAB}}. >> >> Or rather @key{TAB}, right? That's what's used earlier in the Widget >> manual and IIUC is what (info "(texinfo) @key") recommends. > > No, @kbd{@key{TAB}} is correct when you are talking about user typing > something (as opposed to talking about the key TAB). > > Texinfo explicitly tells you that @key is for naming a key, not for > describing user input. Ah, ok. I guess I misunderstood that, and also I misinterpreted the use of @key{TAB} in (info "(widget) Widgets and the Buffer") that I referred to above: it is in a table that begins with @table @kbd, so the effect is that of @kbd{@key{TAB}}. (But I do think there are several typos or incorrect markup in that node and possibly elsewhere in the Widget manual; but I'll make a separate bug report about that.) >> If non-@code{nil}, skip over inactive widgets when using @key{TAB} >> (@code{widget-forward}) or @kbd{S-@key{TAB}} (@code{widget-backward}, >> also bound to @kbd{M-@key{TAB}}) to navigate between widgets. >> >> Is this formulation acceptable? > > Yes, thanks. Thanks, I've pushed the changes to master as commit 91333dacfa1. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 17 13:37:55 2024 Received: (at 70413-done) by debbugs.gnu.org; 17 Apr 2024 17:37:55 +0000 Received: from localhost ([127.0.0.1]:47125 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rx9EH-0003WI-Mk for submit@debbugs.gnu.org; Wed, 17 Apr 2024 13:37:55 -0400 Received: from mout.gmx.net ([212.227.15.18]:55541) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rx9EB-0003Uc-Ju for 70413-done@debbugs.gnu.org; Wed, 17 Apr 2024 13:37:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1713375448; x=1713980248; i=stephen.berman@gmx.net; bh=oauk4iaeyXaCPxcQtyUUqfYVOe5t6pmmpLwKVvuzmmg=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=HsM9CyIIRVS64Is41zcVKCG77A3puc65eYLV/aSVMVVQvLkge8eLvZ9AwhaFyEtV r2uEfw3fonvj1r2EHvHJPMntJ4qir+D7eaHgarfKhILaUu+GP7Ftf94DwLwIZOEzu /bEC7GsFf2WDKVM4E9JP9lY7gRvaS9eb6uV+lYC2YSxhGnPFU2EeTaz3MlgEqGKEn 0gr5G2dcTJ7ikKeJfHhNjQpHjiDwv3pOhLxYuH3J8VFCS7HovZ7Rundb5uzecqOCN nBRdODMT+spDZsokNkKMiMz/U1aVKnfCmDkAVSiQv0hC3xtV7K+F64WO52jbVkTvF CYTr8BbVSjgPnt0TsQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs ([94.134.94.216]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M9Wuk-1s2fWu3ZyO-005W3x; Wed, 17 Apr 2024 19:37:28 +0200 From: Stephen Berman To: Eli Zaretskii Subject: Re: bug#70413: 30.0.50; FR: skip inactive widgets when tabbing In-Reply-To: <877cgv99iz.fsf@gmx.net> (Stephen Berman's message of "Wed, 17 Apr 2024 19:36:04 +0200") References: <87zfttpstx.fsf@gmx.net> <865xwhjwo3.fsf@gnu.org> <87v84hott7.fsf@gmx.net> <87r0f5otfy.fsf@gmx.net> <865xwgi4a5.fsf@gnu.org> <87bk688523.fsf@gmx.net> <86frvkgfly.fsf@gnu.org> <877cgv99iz.fsf@gmx.net> Date: Wed, 17 Apr 2024 19:37:28 +0200 Message-ID: <8734rj99gn.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:3/+0S9pEtWXMIwZI/ZjJWX8qAQEE3e7JEDzr9JNblcuXfTxNhbV ANlBDP5sT1CoCYLqx5YlUZvG9dayphr0cCJevwh1tJS4/3nCDDRsWOaWFr+uBYIDOIWNJfi upnodyj6GYxvHoXuQE1eWHxoy627LVsp7lJgNcFpH3HJkFWhMDm2sScSa4AyNpU4QrrN47u KoQRkqGt8zNTjbhPrDczA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:/GHj+ucvKcw=;884SNTR/bNMvFjNm9QHX2w8rKMY Q6iENzR3JpvgZp5htYbVeXl/XzxGMIJ3arkupU0p0SDHOpWL6O95dZKkLWd8OiY8+HpO3Cefk yjhuHUcrEep4WcKDzUqA6X1YxIAs7QgSzUVB3PRDewtbn5VhmnKEtcv0/6BuTl9Q8aroB89wj NYPyJxN2tCh/PPQ8STlPmBN/gaHBcZiwd9WgEzcD4OeTbe3MLtvSVWWelxsvJwCSm5zQ/t3XA tx7o8QUwcNCcYF1YvhB66Fg3+11LtZngfh1ZR3oSWD+BcuB2aT8/b9Z5MPIM9FjiyxaGLUJPI AysqyqpqlIJs9WZ+MxGm5Z7TqkggrR/EDhzO8fd1OsqoUpe7Tz3Lo55ze62/MB5TU6OYmuZEq M6WLWJ4RSnT5k8zAzHLRW+aUDYqvFmuDR/QNSHomRrKEZ81m32kSPvZURgbWeH2RsdTA4yDuA 2IHEVLJDTl0+6tGcl7fHX0kQ0H87RHv0O+lj7XIISf10I+GVzpIx23XFXHKUiM5/Wum9ixja1 bwGVTOieBpxPhkDQvumkBtKA6SXeHw8b4UIpjuZEq5GJUzymGyS9VqwEPrHusPB7Iy5I/Jzjk b5xp2ChduGjZWMaINORHEO3ntXOQz2py78g1eXEUnu/lwLR8oE/CQqMsa1Wkbpqa+8J/ajxhz AaWKNXbj2E6QUpgyw+tOLwLvBZSQMZHfJejSEQo7Qi37o0gLQvwAxHj+/Ypc2ggHyJRVey33Y ZbEybxg2ueCeHkv4JjH2PFOLNMVh8c1abh3KSh8TgK7bC0h9QtUK06gppJ3g0sBz3sTMmdnN3 YBDNzT8GKajJyxgb7KN+9rUX4PfR9tanrYWynvQ6x0Gzs= Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70413-done Cc: 70413-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Wed, 17 Apr 2024 19:36:04 +0200 Stephen Berman = wrote: > On Wed, 17 Apr 2024 18:42:49 +0300 Eli Zaretskii wrote: [...] >>> If non-@code{nil}, skip over inactive widgets when using @key{TAB} >>> (@code{widget-forward}) or @kbd{S-@key{TAB}} (@code{widget-backward}= , >>> also bound to @kbd{M-@key{TAB}}) to navigate between widgets. >>> >>> Is this formulation acceptable? >> >> Yes, thanks. > > Thanks, I've pushed the changes to master as commit 91333dacfa1. And now closing the bug. Steve Berman From unknown Sat Aug 16 16:02:16 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 16 May 2024 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator