GNU bug report logs - #70369
[PATCH] Fix folding glitch with tmm disabled

Previous Next

Package: auctex;

Reported by: Paul Nelson <ultrono <at> gmail.com>

Date: Sat, 13 Apr 2024 22:00:04 UTC

Severity: normal

Tags: patch

Done: Arash Esbati <arash <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Arash Esbati <arash <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#70369: closed ([PATCH] Fix folding glitch with tmm disabled)
Date: Wed, 17 Apr 2024 20:37:01 +0000
[Message part 1 (text/plain, inline)]
Your message dated Wed, 17 Apr 2024 22:35:48 +0200
with message-id <m2a5lrk9qz.fsf <at> macmutant.fritz.box>
and subject line Re: bug#70369: [PATCH] Fix folding glitch with tmm disabled
has caused the debbugs.gnu.org bug report #70369,
regarding [PATCH] Fix folding glitch with tmm disabled
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
70369: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70369
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Paul Nelson <ultrono <at> gmail.com>
To: bug-auctex <at> gnu.org
Subject: [PATCH] Fix folding glitch with tmm disabled
Date: Sat, 13 Apr 2024 23:58:50 +0200
[Message part 3 (text/plain, inline)]
Hello,

Steps to reproduce:
- Disable transient-mark-mode.
- Create test.tex containing "\emph{foo} \emph{bar}".
- Move point inside "foo" and set the mark (C-SPC).  Note that this
does not "activate the region".
- TeX-fold-buffer (C-c C-o C-b).
- Move the point into "bar".

What should happen is that the second fold is revealed.  Instead, both
folds are revealed.

The fix is to replace mark-active with (TeX-active-mark) inside
TeX-fold-post-command.

I looked for other places where "mark-active" was used incorrectly,
and fixed a couple minor ones, involving menu entries.

Thanks, best,

Paul
[0001-Change-some-mark-active-to-TeX-active-mark.patch (application/octet-stream, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Arash Esbati <arash <at> gnu.org>
To: Paul Nelson <ultrono <at> gmail.com>
Cc: 70369-done <at> debbugs.gnu.org
Subject: Re: bug#70369: [PATCH] Fix folding glitch with tmm disabled
Date: Wed, 17 Apr 2024 22:35:48 +0200
Arash Esbati <arash <at> gnu.org> writes:

> Again, can't apply the patch.  Can you please try to fix as well?

Scratch that, my bad, sorry.  Installed with commit 5abc3d7f68.  Thanks
for your contribution.  Closing.

Best, Arash


This bug report was last modified 1 year and 94 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.