GNU bug report logs - #70362
[PATCH] Add font-locking for Go built-in functions in go-ts-mode

Previous Next

Package: emacs;

Reported by: Noah Peart <noah.v.peart <at> gmail.com>

Date: Sat, 13 Apr 2024 05:49:03 UTC

Severity: normal

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #34 received at 70362 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Randy Taylor <dev <at> rjt.dev>
Cc: noah.v.peart <at> gmail.com, casouri <at> gmail.com, 70362 <at> debbugs.gnu.org,
 dmitry <at> gutov.dev
Subject: Re: bug#70362: [PATCH] Add font-locking for Go built-in functions in
 go-ts-mode
Date: Thu, 18 Apr 2024 17:15:22 +0300
> Date: Thu, 18 Apr 2024 13:44:56 +0000
> From: Randy Taylor <dev <at> rjt.dev>
> Cc: noah.v.peart <at> gmail.com, casouri <at> gmail.com, dmitry <at> gutov.dev, 70362 <at> debbugs.gnu.org
> 
> On Thursday, April 18th, 2024 at 06:32, Eli Zaretskii <eliz <at> gnu.org> wrote:
> > 
> > > Date: Tue, 16 Apr 2024 00:44:16 +0000
> > 
> > > From: Randy Taylor dev <at> rjt.dev
> > > Cc: Yuan Fu casouri <at> gmail.com, Dmitry Gutov dmitry <at> gutov.dev, Eli Zaretskii eliz <at> gnu.org, 70362 <at> debbugs.gnu.org
> > > 
> > > Thanks for working on this Noah, it looks good to me as well.
> > > 
> > > Perhaps builtin could come before constant in treesit-font-lock-feature-list to keep things alphabetical?
> > 
> > 
> > I've rearranged them, thanks for noticing this.
> 
> Thanks, but I was referring to the treesit-font-lock-feature-list variable (see attached patch), not go-ts-mode--font-lock-settings which is not alphabetized.

Thanks, installed.




This bug report was last modified 1 year and 29 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.