GNU bug report logs - #70362
[PATCH] Add font-locking for Go built-in functions in go-ts-mode

Previous Next

Full log

Message #25 received at 70362-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Yuan Fu <casouri <at> gmail.com>
Cc: dmitry <at> gutov.dev, 70362-done <at> debbugs.gnu.org, noah.v.peart <at> gmail.com
Subject: Re: bug#70362: [PATCH] Add font-locking for Go built-in functions in
 go-ts-mode
Date: Thu, 18 Apr 2024 13:31:25 +0300

> From: Yuan Fu <casouri <at> gmail.com>
> Date: Sun, 14 Apr 2024 16:32:43 -0700
> Cc: Noah Peart <noah.v.peart <at> gmail.com>,
>  Eli Zaretskii <eliz <at> gnu.org>,
>  70362 <at> debbugs.gnu.org
> 
> 
> Dmitry Gutov <dmitry <at> gutov.dev> writes:
> 
> > On 13/04/2024 10:40, Noah Peart wrote:
> >> I put it at level 3 following the conventions in other treesit modes
> >> I checked: python-ts-mode, ruby-ts-mode, rust-ts-mode all put
> >> builtins at level 3.
> >> But, I haven't done a full census of the ts modes so there might be
> >> variability.
> >
> > SGTM. If classic major modes highlight a thing (and they do that for
> > built-ins), we usually put it in the default highlighting for ts modes
> > as well (meaning level 3 or lower).
> 
> Right. And the patch looks good to me.

Thanks, installed on master, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.