GNU bug report logs - #70362
[PATCH] Add font-locking for Go built-in functions in go-ts-mode

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#70362: closed ([PATCH] Add font-locking for Go built-in
 functions in go-ts-mode)
Date: Thu, 18 Apr 2024 10:33:13 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 18 Apr 2024 13:31:25 +0300
with message-id <86wmovdksi.fsf <at> gnu.org>
and subject line Re: bug#70362: [PATCH] Add font-locking for Go built-in functions in go-ts-mode
has caused the debbugs.gnu.org bug report #70362,
regarding [PATCH] Add font-locking for Go built-in functions in go-ts-mode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
70362: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70362
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Noah Peart <noah.v.peart <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add font-locking for Go built-in functions in go-ts-mode
Date: Fri, 12 Apr 2024 22:47:37 -0700

[Message part 3 (text/plain, inline)]

Tags: patch

This patch adds a new `builtin` feature to
`treesit-font-lock-feature-list` in `go-ts-mode` and a corresponding
rule to `go-ts-mode--font-lock-settings` to highlight Go's built-in
functions.

[Message part 4 (text/html, inline)]

[0001-Add-font-locking-for-Go-built-in-functions-in-go-ts-.patch (text/x-patch, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Yuan Fu <casouri <at> gmail.com>
Cc: dmitry <at> gutov.dev, 70362-done <at> debbugs.gnu.org, noah.v.peart <at> gmail.com
Subject: Re: bug#70362: [PATCH] Add font-locking for Go built-in functions in
 go-ts-mode
Date: Thu, 18 Apr 2024 13:31:25 +0300

> From: Yuan Fu <casouri <at> gmail.com>
> Date: Sun, 14 Apr 2024 16:32:43 -0700
> Cc: Noah Peart <noah.v.peart <at> gmail.com>,
>  Eli Zaretskii <eliz <at> gnu.org>,
>  70362 <at> debbugs.gnu.org
> 
> 
> Dmitry Gutov <dmitry <at> gutov.dev> writes:
> 
> > On 13/04/2024 10:40, Noah Peart wrote:
> >> I put it at level 3 following the conventions in other treesit modes
> >> I checked: python-ts-mode, ruby-ts-mode, rust-ts-mode all put
> >> builtins at level 3.
> >> But, I haven't done a full census of the ts modes so there might be
> >> variability.
> >
> > SGTM. If classic major modes highlight a thing (and they do that for
> > built-ins), we usually put it in the default highlighting for ts modes
> > as well (meaning level 3 or lower).
> 
> Right. And the patch looks good to me.

Thanks, installed on master, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.