GNU bug report logs - #70362
[PATCH] Add font-locking for Go built-in functions in go-ts-mode

Previous Next

Full log

Message #20 received at 70362 <at> debbugs.gnu.org (full text, mbox):

From: Randy Taylor <dev <at> rjt.dev>
To: Noah Peart <noah.v.peart <at> gmail.com>
Cc: Dmitry Gutov <dmitry <at> gutov.dev>, Yuan Fu <casouri <at> gmail.com>,
 70362 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#70362: [PATCH] Add font-locking for Go built-in functions in
 go-ts-mode
Date: Tue, 16 Apr 2024 00:44:16 +0000

On Sunday, April 14th, 2024 at 19:32, Yuan Fu <casouri <at> gmail.com> wrote:
> 
> Dmitry Gutov dmitry <at> gutov.dev writes:
> 
> > On 13/04/2024 10:40, Noah Peart wrote:
> > 
> > > I put it at level 3 following the conventions in other treesit modes
> > > I checked: python-ts-mode, ruby-ts-mode, rust-ts-mode all put
> > > builtins at level 3.
> > > But, I haven't done a full census of the ts modes so there might be
> > > variability.
> > 
> > SGTM. If classic major modes highlight a thing (and they do that for
> > built-ins), we usually put it in the default highlighting for ts modes
> > as well (meaning level 3 or lower).
> 
> 
> Right. And the patch looks good to me.
> 
> Yuan
> 

Thanks for working on this Noah, it looks good to me as well.

Perhaps builtin could come before constant in treesit-font-lock-feature-list to keep things alphabetical?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.