GNU bug report logs - #70362
[PATCH] Add font-locking for Go built-in functions in go-ts-mode

Previous Next

Package: emacs;

Reported by: Noah Peart <noah.v.peart <at> gmail.com>

Date: Sat, 13 Apr 2024 05:49:03 UTC

Severity: normal

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #14 received at 70362 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Noah Peart <noah.v.peart <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>
Cc: 70362 <at> debbugs.gnu.org
Subject: Re: bug#70362: [PATCH] Add font-locking for Go built-in functions in
 go-ts-mode
Date: Sat, 13 Apr 2024 15:16:45 +0300
On 13/04/2024 10:40, Noah Peart wrote:
> I put it at level 3 following the conventions in other treesit modes
> I checked: python-ts-mode, ruby-ts-mode, rust-ts-mode all put builtins 
> at level 3.
> But, I haven't done a full census of the ts modes so there might be 
> variability.

SGTM. If classic major modes highlight a thing (and they do that for 
built-ins), we usually put it in the default highlighting for ts modes 
as well (meaning level 3 or lower).




This bug report was last modified 1 year and 29 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.