Subject: Re: bug#70362: [PATCH] Add font-locking for Go built-in functions in go-ts-mode

From: Randy Taylor <[email-masked]>
Date: Thu, 18 Apr 2024 13:44:56 +0000

On Thursday, April 18th, 2024 at 06:32, Eli Zaretskii <[email-masked]> wrote:
> 
> > Date: Tue, 16 Apr 2024 00:44:16 +0000
> 
> > From: Randy Taylor [email-masked]
> > Cc: Yuan Fu [email-masked], Dmitry Gutov [email-masked], Eli Zaretskii [email-masked], [email-masked]
> > 
> > Thanks for working on this Noah, it looks good to me as well.
> > 
> > Perhaps builtin could come before constant in treesit-font-lock-feature-list to keep things alphabetical?
> 
> 
> I've rearranged them, thanks for noticing this.

Thanks, but I was referring to the treesit-font-lock-feature-list variable (see attached patch), not go-ts-mode--font-lock-settings which is not alphabetized.

From e77c132d934ad61117d55a5562c9cf0dc1fae47c Mon Sep 17 00:00:00 2001
From: Randy Taylor <[email-masked]>
Date: Thu, 18 Apr 2024 09:38:28 -0400
Subject: [PATCH] ; Alphabetize go-ts-mode's treesit-font-lock-feature-list

* lisp/progmodes/go-ts-mode.el (go-ts-mode):
Rearrange features to keep alphabetical order.  (Bug#70362)
---
 lisp/progmodes/go-ts-mode.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/progmodes/go-ts-mode.el b/lisp/progmodes/go-ts-mode.el
index f2b586dfb43..aef224ab3fa 100644
--- a/lisp/progmodes/go-ts-mode.el
+++ b/lisp/progmodes/go-ts-mode.el
@@ -284,7 +284,7 @@ go-ts-mode
     (setq-local treesit-font-lock-feature-list
                 '(( comment definition)
                   ( keyword string type)
-                  ( constant escape-sequence label number builtin)
+                  ( builtin constant escape-sequence label number)
                   ( bracket delimiter error function operator property variable)))
 
     (treesit-major-mode-setup)))
-- 
2.44.0