From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 13 01:23:49 2024 Received: (at submit) by debbugs.gnu.org; 13 Apr 2024 05:23:50 +0000 Received: from localhost ([127.0.0.1]:59827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvVrh-0000Ec-A5 for submit@debbugs.gnu.org; Sat, 13 Apr 2024 01:23:49 -0400 Received: from lists.gnu.org ([2001:470:142::17]:55900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvVrd-0000Cp-C1 for submit@debbugs.gnu.org; Sat, 13 Apr 2024 01:23:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rvVrF-0001ok-Is for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2024 01:23:21 -0400 Received: from mail-oa1-x2d.google.com ([2001:4860:4864:20::2d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rvVrC-0001b2-I5 for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2024 01:23:21 -0400 Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-22edbb5dd40so837853fac.1 for ; Fri, 12 Apr 2024 22:23:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712985796; x=1713590596; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=kD+BILPwFRqE7IqqR03karRCiRUQ9I1EnrhJo3HEY3Y=; b=MqOKiScbiVhBKNwMofbbj35b95rHi7dwD8Ajc+JNTSfHGH8YtV6s5RL3xbJ+lQo3Yw Gwug3l1IYNmyNBUtcK72aHl6+1fKjkaT7O/murC5QHEnwdBvt6Ezq/JUuNrnHVYAVN5F 7l+6h9Pr6CEcSQ3dl+9bBITlkLoRi+Tw7p/PtLEdv10K6RG2aXZNKopgi0pMJB0yN0HC YTMge2m6et6uWKGhyOhM/heAgCmwxxfY05PnnceiINbYp6sFFtSpU2vcN3XGWChXjzDB t/6uBRQ+hk6CxecxBSyv4oiuAD+ss0TfSYl1Ffsfc+NhCkd4EOQ0tgoCsoCxJuhJ+qTC 4ffg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712985796; x=1713590596; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=kD+BILPwFRqE7IqqR03karRCiRUQ9I1EnrhJo3HEY3Y=; b=n38LXhLzNwqo/lnd9D7GvMOT0g8MN7y/vCAYaj3WjINmhJ3+z+D0MrBq7rH0lrMAeH VUqFM/RHV8348hb35BXkw1KMZQOSgHX+SReYyAdPTkxKcGwkTPDsKX5G/AqaccuAF/PQ XH+0tqzg3rPd3+PcZn8hhY2aEc/dNP2ZEWoRtv3SDLS4R85rJsyk6XmPwms1scmUAwJC PontqftvCohnRL9Xa3pkKs+kR2Lm1lnXwORbQANPgkigvvwY3Ysy6AdKJQ1SgoZSIrxw cw/r5nIz4fNJG9R7SubJA2UNZqWkPqJVlOdPcRUeN7CrF6XeaYavWx0FOi1s9zqjY6HU NpOg== X-Gm-Message-State: AOJu0YykKGolnbeVPoXSstDnM7xreAkAPeJLudwVpv9zjCXZHUO4WDR2 ypxapUyyVj0PsMGnCjkrPRzcmmexY/fsKnBkySbSw3tKCDXv4WOA7cH14YEnwh1v9e8sZsey+ls RHCVr2CYGvNB2t+7tNsajuMBliKjnH9f0OScDdw== X-Google-Smtp-Source: AGHT+IHEBoTGCoB2+ozeHTmvSezIMgSM5yB5sVSWAMMgr6t/QgK0Gx9+eYV4yitAP6xW4a/DiVfbZPRQV4VGzkKH/AU= X-Received: by 2002:a05:6870:a10a:b0:22e:83e8:2f13 with SMTP id m10-20020a056870a10a00b0022e83e82f13mr3099263oae.24.1712985796001; Fri, 12 Apr 2024 22:23:16 -0700 (PDT) MIME-Version: 1.0 From: Noah Peart Date: Fri, 12 Apr 2024 22:23:05 -0700 Message-ID: Subject: [PATCH] Add font-locking for operators in go-ts-mode. To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="000000000000e05bcb0615f395e7" Received-SPF: pass client-ip=2001:4860:4864:20::2d; envelope-from=noah.v.peart@gmail.com; helo=mail-oa1-x2d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --000000000000e05bcb0615f395e7 Content-Type: multipart/alternative; boundary="000000000000e05bc90615f395e5" --000000000000e05bc90615f395e5 Content-Type: text/plain; charset="UTF-8" Tags: patch Adds font-locking for Go operators in `go-ts-mode'. The operator feature is already added to `treesit-font-lock-feature-list' in `go-ts-mode` - this just adds the missing rule to `go-ts-mode--font-lock-settings'. In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.33, cairo version 1.16.0) of 2024-04-07 built on noah-X580VD Repository revision: ee377aaddf9d73116b93c3d54b1ffef9a3a8b925 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101004 System Description: Ubuntu 22.04.4 LTS Configured using: 'configure --prefix=/usr/local --with-modules --with-tree-sitter --with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls --with-json --with-mailutils --with-jpeg --with-png --with-rsvg --with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12 CXX=gcc-12' --000000000000e05bc90615f395e5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Tags: patch


Adds font-locking for Go operators = in `go-ts-mode'. The operator feature
is already added to `treesit-f= ont-lock-feature-list' in `go-ts-mode` - this
just adds the missing = rule to `go-ts-mode--font-lock-settings'.


In GNU Emacs 30.0.= 50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.33, cairo version 1.= 16.0) of 2024-04-07 built on noah-X580VD
Repository revision: ee377aaddf= 9d73116b93c3d54b1ffef9a3a8b925
Repository branch: master
Windowing sy= stem distributor 'The X.Org Foundation', version 11.0.12101004
S= ystem Description: Ubuntu 22.04.4 LTS

Configured using:
=C2=A0= 9;configure --prefix=3D/usr/local --with-modules --with-tree-sitter
--wi= th-threads --with-x-toolkit=3Dgtk3 --with-xwidgets --with-gnutls
--with-= json --with-mailutils --with-jpeg --with-png --with-rsvg
--with-tiff --w= ith-xml2 --with-xpm --with-imagemagick CC=3Dgcc-12
CXX=3Dgcc-12'
=
--000000000000e05bc90615f395e5-- --000000000000e05bcb0615f395e7 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Add-font-locking-for-operators-in-go-ts-mode.patch" Content-Disposition: attachment; filename="0001-Add-font-locking-for-operators-in-go-ts-mode.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_luxnhexb0 RnJvbSBmZDM5M2E2MjU5ZTVmMzQ3OWE5ZjI0NDc2NGVmMjZhNzk2NTA1ZTI4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb2FoIFBlYXJ0IDxub2FoLnYucGVhcnRAZ21haWwuY29tPgpE YXRlOiBGcmksIDEyIEFwciAyMDI0IDIyOjA5OjE3IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gQWRk IGZvbnQtbG9ja2luZyBmb3Igb3BlcmF0b3JzIGluIGdvLXRzLW1vZGUuCgoqIGxpc3AvcHJvZ21v ZGVzL2dvLXRzLW1vZGUuZWwgKGdvLXRzLW1vZGUtLWZvbnQtbG9jay1zZXR0aW5ncyk6IEFkZApm b250LWxvY2tpbmcgZm9yIEdvIG9wZXJhdG9ycy4KLS0tCiBsaXNwL3Byb2dtb2Rlcy9nby10cy1t b2RlLmVsIHwgNCArKysrCiAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspCgpkaWZmIC0t Z2l0IGEvbGlzcC9wcm9nbW9kZXMvZ28tdHMtbW9kZS5lbCBiL2xpc3AvcHJvZ21vZGVzL2dvLXRz LW1vZGUuZWwKaW5kZXggY2MzMzA2ODhkYzMuLjdjYTNiZmE1ZTY1IDEwMDY0NAotLS0gYS9saXNw L3Byb2dtb2Rlcy9nby10cy1tb2RlLmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL2dvLXRzLW1vZGUu ZWwKQEAgLTEzNSw2ICsxMzUsMTAgQEAgZ28tdHMtbW9kZS0tZm9udC1sb2NrLXNldHRpbmdzCiAg ICA6ZmVhdHVyZSAnZGVsaW1pdGVyCiAgICAnKChbIiwiICIuIiAiOyIgIjoiXSkgQGZvbnQtbG9j ay1kZWxpbWl0ZXItZmFjZSkKIAorICAgOmxhbmd1YWdlICdnbworICAgOmZlYXR1cmUgJ29wZXJh dG9yCisgICBgKFssQGdvLXRzLW1vZGUtLW9wZXJhdG9yc10gQGZvbnQtbG9jay1vcGVyYXRvci1m YWNlKQorCiAgICA6bGFuZ3VhZ2UgJ2dvCiAgICA6ZmVhdHVyZSAnZGVmaW5pdGlvbgogICAgJygo ZnVuY3Rpb25fZGVjbGFyYXRpb24KLS0gCjIuMzQuMQoK --000000000000e05bcb0615f395e7-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 13 03:21:01 2024 Received: (at 70361) by debbugs.gnu.org; 13 Apr 2024 07:21:01 +0000 Received: from localhost ([127.0.0.1]:59929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvXh6-00018y-1A for submit@debbugs.gnu.org; Sat, 13 Apr 2024 03:21:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57176) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvXh4-00017p-Gm for 70361@debbugs.gnu.org; Sat, 13 Apr 2024 03:20:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rvXgo-0007PD-Si; Sat, 13 Apr 2024 03:20:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2hqKefUaGXIh2hOt7XHAuaDa3rfuz7KkIanfj/m1gac=; b=ITGUKz4ew4xW s/CEQfoMFbTEdttiVz8nJ9+tSoJ77p2eB3zz9Venv0wHYXhHZDZzHCDic+Fwnl+lCQQzQM7LD8UCF Jw1+VcWMINqaNrq0eaRPA+ciE065dN5GZk9f9JisP2xP/lRDrJ4Uk/BN5QsYZEvCs1Cc9Hnq+mePL 0unz9Qid6rvlvj2jamfagHKMl99FpBTY8dImYOGG2CWFdbhk8tuXnCoMcyDgyGfiAz1C6VOX0yCiV fvpsiFD5+aBWTRfbYSsVakiKvjz+Pv1MeTOrUzsQMKk3GF2lNEuvOaP8XkPWxtbV08lWTEGMyz49a 9BT39cgChpjZO2tv51WBXw==; Date: Sat, 13 Apr 2024 10:20:40 +0300 Message-Id: <86r0f9ranr.fsf@gnu.org> From: Eli Zaretskii To: Noah Peart In-Reply-To: (message from Noah Peart on Fri, 12 Apr 2024 22:23:05 -0700) Subject: Re: bug#70361: [PATCH] Add font-locking for operators in go-ts-mode. References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70361 Cc: 70361@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Noah Peart > Date: Fri, 12 Apr 2024 22:23:05 -0700 > > Adds font-locking for Go operators in `go-ts-mode'. The operator feature > is already added to `treesit-font-lock-feature-list' in `go-ts-mode` - this > just adds the missing rule to `go-ts-mode--font-lock-settings'. Thanks. The operators will be fontified only if treesit-font-lock-level is 4, right? That's the level at which we decided to fontify operators. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 13 03:27:58 2024 Received: (at 70361) by debbugs.gnu.org; 13 Apr 2024 07:27:59 +0000 Received: from localhost ([127.0.0.1]:59969 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvXnp-0002Ay-7k for submit@debbugs.gnu.org; Sat, 13 Apr 2024 03:27:58 -0400 Received: from mail-oa1-x2f.google.com ([2001:4860:4864:20::2f]:47158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvXnl-00029a-Q5 for 70361@debbugs.gnu.org; Sat, 13 Apr 2024 03:27:55 -0400 Received: by mail-oa1-x2f.google.com with SMTP id 586e51a60fabf-22f32226947so959408fac.2 for <70361@debbugs.gnu.org>; Sat, 13 Apr 2024 00:27:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712993258; x=1713598058; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=yc8N19Esjv2DIT9rKBv5xYuG5rbN26BjBW/F0JFei/o=; b=NZQWAUbEHdZgE14Hlb3pC+QlFzc7XNnTDHJEt9YTVTGoSAeXttAUPfKpgbQf18cyEg 4KwixPWzdVH/wgiGuNTpcK/WaRAeufSKIKdVs+2kcv8xvLzGTfDj3SuMm1GGUVoH+wc2 g3AUz66qk/6fu8ssXr664pFDh6S8SOy5flE7UDZwPvMGSsWQianW7T2aX9rPUevTS/En Qhfpu3NHNH5uvSL2bh5lzeFUxhm0S9CPD0KLaXWWxi4BudM34Ss/690CRzIyDcsi2OFT i+uNqNRINFvNmq2AoJEG5FhxgjWZjMAIuSqr2wwJ0h+mRbRbF0Vwjrvb5Q/ypdMybYRk Wcfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712993258; x=1713598058; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yc8N19Esjv2DIT9rKBv5xYuG5rbN26BjBW/F0JFei/o=; b=fXwytvSR93gUiK4gQb6L3Ppp4ecZ/60/jUNeSYVnjWB9JooxzpOGJ6ylI3KzC8Q1QH hD9BxFTcOcmSpajqGvJZIG0o6EIc6XGR6CyUFHnLL+BBi4eGK2kTswWz0feE2xxFbNdG hxd2ENvPsOcLPVmcNiEywIaAIqThQlwc4gOWTbujdg+1e+TSsoCIjN4EHBol6pKWdfvw KUGhKUrame4h4nEaO3ZvC6g/tnkCHGnsxRGvJUzphdo0MnuarFqZQ3+zOT0huTED7tdU CtVrKEcwDsf/G7kRTwZZ1vBTdvl4c+bxtPIqITjSxQn/CGv2CHhI6aqHrJRwuWDxZ+K5 CyDA== X-Gm-Message-State: AOJu0YzYg+7bC+vzuk8bJgc5Jf+1FCiyLzOa0WoPX0DMTDTrOtQBa+P5 VEqECevZiu/FQM1j286AiXAl8AjeyUGQ+pm6oEm+a4MM89SRCvsdUsMHs6Lwsu+CLzAjE/uDgBB ZWl2hLDrSh1YWK08gjO1pEHHn3Ks= X-Google-Smtp-Source: AGHT+IGQ+iyBGQvEbUlAO5fgDhCqZoMvQ7BzKS1N8rbatWE1TlACf+UDhOYAksB8/i3KKmMS+Sq7zY1UovoJ99iZdWs= X-Received: by 2002:a05:6870:e09:b0:22e:d13b:c13d with SMTP id mp9-20020a0568700e0900b0022ed13bc13dmr5512501oab.18.1712993257575; Sat, 13 Apr 2024 00:27:37 -0700 (PDT) MIME-Version: 1.0 References: <86r0f9ranr.fsf@gnu.org> In-Reply-To: <86r0f9ranr.fsf@gnu.org> From: Noah Peart Date: Sat, 13 Apr 2024 00:27:26 -0700 Message-ID: Subject: Re: bug#70361: [PATCH] Add font-locking for operators in go-ts-mode. To: Eli Zaretskii Content-Type: multipart/alternative; boundary="0000000000009edd470615f5526e" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70361 Cc: 70361@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000009edd470615f5526e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > The operators will be fontified only if treesit-font-lock-level is 4, right? Yea, operator is at level 4 - I didn't change the treesit-font-lock-feature-list. On Sat, Apr 13, 2024 at 12:20=E2=80=AFAM Eli Zaretskii wrote= : > > From: Noah Peart > > Date: Fri, 12 Apr 2024 22:23:05 -0700 > > > > Adds font-locking for Go operators in `go-ts-mode'. The operator featur= e > > is already added to `treesit-font-lock-feature-list' in `go-ts-mode` - > this > > just adds the missing rule to `go-ts-mode--font-lock-settings'. > > Thanks. > > The operators will be fontified only if treesit-font-lock-level is 4, > right? That's the level at which we decided to fontify operators. > --0000000000009edd470615f5526e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> The operators will be fontified only if treesit-font-= lock-level is 4,
right?

Yea, operator is at level 4 -= I didn't change the treesit-font-lock-feature-list.



On Sat, Apr 13, 2024 at 12:20=E2=80=AFAM Eli Zaretskii <= ;eliz@gnu.org> wrote:
> From: Noah Peart <noah.v.peart@gmail.= com>
> Date: Fri, 12 Apr 2024 22:23:05 -0700
>
> Adds font-locking for Go operators in `go-ts-mode'. The operator f= eature
> is already added to `treesit-font-lock-feature-list' in `go-ts-mod= e` - this
> just adds the missing rule to `go-ts-mode--font-lock-settings'.
Thanks.

The operators will be fontified only if treesit-font-lock-level is 4,
right?=C2=A0 That's the level at which we decided to fontify operators.=
--0000000000009edd470615f5526e-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 13 03:33:31 2024 Received: (at 70361) by debbugs.gnu.org; 13 Apr 2024 07:33:31 +0000 Received: from localhost ([127.0.0.1]:59979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvXtB-0002ze-Hy for submit@debbugs.gnu.org; Sat, 13 Apr 2024 03:33:31 -0400 Received: from mail-oo1-xc29.google.com ([2607:f8b0:4864:20::c29]:46456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvXt9-0002yH-47 for 70361@debbugs.gnu.org; Sat, 13 Apr 2024 03:33:28 -0400 Received: by mail-oo1-xc29.google.com with SMTP id 006d021491bc7-5aa26990d5aso1125499eaf.1 for <70361@debbugs.gnu.org>; Sat, 13 Apr 2024 00:33:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712993591; x=1713598391; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=M1wLszlEjjpnogH1qOUuhsEDCGWqLOFhGUEjNK4cap8=; b=lhoUizwfE0cNo9gxGDy6Iu1U6+TGkcGsgkkgH6LWU6MLnY4MHnYwurscvIUiN3Visd D00aGMuAh+R6Eo9fBdP7Mo5AUSr1vpkpkKrcmZ0lIXQT0HI9fHbOw4AzSpjY77Qd6yTj woQ0vEd54SaMI9NEH3CvPnJNmZ2KoZbIpxHgcwKpd5Ntfkjwh/d4qTNUvSvH284ry/eq Gz2YA46cfAO9Gc/5PNDfikyPqlBe6b6llYyTY7rtwzrbuP4Uf74WxJfYzMxkJf5TfIsq WmOLyaHD4h/asB/p44iSosJ/FAzvGt4PiacJvUvVGRBG9x/3tmPhe0db36Fmfw/mIqWf oUqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712993591; x=1713598391; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=M1wLszlEjjpnogH1qOUuhsEDCGWqLOFhGUEjNK4cap8=; b=GXTAdP3Fq518W6oROlCpkR2e+tnUafqy9uvDaR6xILleQlsG5dszZXJme4In7r3QBs Zv4MZxJU/UEkLefl259WDygUEWlAwtLV8H3WR/ehJ7YrMy4CH7MAz7+BpKULj0OZUC6M Z8Ho0TFczcMNQwET+wnP6UgmCtqKlRDHDpSx8+2u8U7IZEpsnnYP+Z1xMgGBuuizwwlF JEPPwA8jjrPxa7Y9ibGmhz1k5ujIlxdPgwaSgw8JHu9NQcofhSCKL54+Ugto/4eAdQ68 nbsgFHCJF3pD8QatFvvdXm6KUAKreNne7k7DS5hicFrthGY5HZf61O2wYc31iGdaOaf+ QLPg== X-Gm-Message-State: AOJu0YyW66T2FwW2Ve3z2OJBw7tJc05/oV1+8iHuTCR7lEpZJRts1jkU 3fwmd3RLt0+/wtfW18sisRnWt7NtnblQfB5n9j45/vxDUvW1rybhVyqnX8/YHcm6SseCk1K7QJg ssIAlD/9UumxNmtyy66kir30bZIepYzJra1U= X-Google-Smtp-Source: AGHT+IFtoHo3oD3SuM5oexIB6QF6blW0sXtf7tI5PIrvAqI8vAllwCCUZqmcuIe/rcHLdbSxalYGHPqVN0BsFAIuJrU= X-Received: by 2002:a05:6870:e09:b0:22e:d13b:c13d with SMTP id mp9-20020a0568700e0900b0022ed13bc13dmr5525010oab.18.1712993591000; Sat, 13 Apr 2024 00:33:11 -0700 (PDT) MIME-Version: 1.0 References: <86r0f9ranr.fsf@gnu.org> In-Reply-To: From: Noah Peart Date: Sat, 13 Apr 2024 00:32:59 -0700 Message-ID: Subject: Re: bug#70361: [PATCH] Add font-locking for operators in go-ts-mode. To: Eli Zaretskii Content-Type: multipart/alternative; boundary="0000000000007e86b80615f5668f" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70361 Cc: 70361@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000007e86b80615f5668f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On a somewhat related note, I was wondering why the treesit modes in emacs define their `treesit-font-lock-feature-list`s in the mode definitions. Wouldn't it be more user-friendly to `defvar` the feature list? On Sat, Apr 13, 2024 at 12:27=E2=80=AFAM Noah Peart wrote: > > The operators will be fontified only if treesit-font-lock-level is 4, > right? > > Yea, operator is at level 4 - I didn't change the > treesit-font-lock-feature-list. > > > > On Sat, Apr 13, 2024 at 12:20=E2=80=AFAM Eli Zaretskii wro= te: > >> > From: Noah Peart >> > Date: Fri, 12 Apr 2024 22:23:05 -0700 >> > >> > Adds font-locking for Go operators in `go-ts-mode'. The operator featu= re >> > is already added to `treesit-font-lock-feature-list' in `go-ts-mode` - >> this >> > just adds the missing rule to `go-ts-mode--font-lock-settings'. >> >> Thanks. >> >> The operators will be fontified only if treesit-font-lock-level is 4, >> right? That's the level at which we decided to fontify operators. >> > --0000000000007e86b80615f5668f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On a somewhat related note, I was wondering why the treesi= t=C2=A0modes in emacs
define their `treesit-font-lock-feature-list`s in= the mode definitions.

Wouldn't it be more use= r-friendly to `defvar` the feature list?

On Sat, Apr 13, 2024 at 12:27= =E2=80=AFAM Noah Peart <noah.v= .peart@gmail.com> wrote:
> The operators will be fontified only = if treesit-font-lock-level is 4,
right?

Yea, operator= is at level 4 - I didn't change the treesit-font-lock-feature-list.



On Sat, Apr 13, 2024 at 12:20=E2=80=AFAM E= li Zaretskii <eliz@gnu= .org> wrote:
> From: Noah Peart <noah.v.peart@gmail.com>
> Date: Fri, 12 Apr 2024 22:23:05 -0700
>
> Adds font-locking for Go operators in `go-ts-mode'. The operator f= eature
> is already added to `treesit-font-lock-feature-list' in `go-ts-mod= e` - this
> just adds the missing rule to `go-ts-mode--font-lock-settings'.
Thanks.

The operators will be fontified only if treesit-font-lock-level is 4,
right?=C2=A0 That's the level at which we decided to fontify operators.=
--0000000000007e86b80615f5668f-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 13 03:40:38 2024 Received: (at 70361) by debbugs.gnu.org; 13 Apr 2024 07:40:38 +0000 Received: from localhost ([127.0.0.1]:59988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvY05-00041i-Kl for submit@debbugs.gnu.org; Sat, 13 Apr 2024 03:40:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvY02-00040N-Re for 70361@debbugs.gnu.org; Sat, 13 Apr 2024 03:40:35 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rvXzn-0002t8-4o; Sat, 13 Apr 2024 03:40:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=KRvwhjkrNlA0aT6vrNpksgDsyXSrSHc99qR8PZriLnc=; b=fSNM7QUgW1hs gU8F2gZRmBEjDtic4WJPp9xIR3sq3DHkcUKXsrnU7/weJs7Rf9k6qmsvinISWHQpzcRb4A3lMk6au EaQdAAgKIFSuqIp5IJYoR60B/sH7s84K9frKAFiQxCsa5SnR5QKwhWJhASkE1JgQ3neOGIYZjWIEF ais6fa5eemwJ4TTOHuZmcEaIINFh+IQCHbUYfgNFPC0UGo8r20ltHlz67wll4laPtDEAW1s1ZDDeA OSM+x1iZPK4N8a/WbdgjVCkyrfE7ZVW3tTC5Rb2zhWrj2XU6QFnTTtQ2o5D90Q8huCKOySYus7w8R eRlzoNgP1/GDBj72YCkYtQ==; Date: Sat, 13 Apr 2024 10:40:09 +0300 Message-Id: <86mspxr9ra.fsf@gnu.org> From: Eli Zaretskii To: Noah Peart , Yuan Fu In-Reply-To: (message from Noah Peart on Sat, 13 Apr 2024 00:32:59 -0700) Subject: Re: bug#70361: [PATCH] Add font-locking for operators in go-ts-mode. References: <86r0f9ranr.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70361 Cc: 70361@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Noah Peart > Date: Sat, 13 Apr 2024 00:32:59 -0700 > Cc: 70361@debbugs.gnu.org > > On a somewhat related note, I was wondering why the treesit modes in emacs > define their `treesit-font-lock-feature-list`s in the mode definitions. > > Wouldn't it be more user-friendly to `defvar` the feature list? AFAIR, we do that in the mode's settings because the translation of general categories into mode-specific settings is not easy, and because we want users to control that via the fontification level, not below that. What problems do you see with the current approach that would require more fine-grained user control? And why do you think a defvar is the proper way of providing such control? From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 13 03:54:17 2024 Received: (at 70361) by debbugs.gnu.org; 13 Apr 2024 07:54:18 +0000 Received: from localhost ([127.0.0.1]:60023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvYDH-00065q-N7 for submit@debbugs.gnu.org; Sat, 13 Apr 2024 03:54:17 -0400 Received: from mail-oa1-x34.google.com ([2001:4860:4864:20::34]:54720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvYDF-00064T-0i for 70361@debbugs.gnu.org; Sat, 13 Apr 2024 03:54:14 -0400 Received: by mail-oa1-x34.google.com with SMTP id 586e51a60fabf-23333dddd8aso973397fac.1 for <70361@debbugs.gnu.org>; Sat, 13 Apr 2024 00:54:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712994837; x=1713599637; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Gjo9EnM8t0pAUFOPmuT/DntwbAB4UjW15SmyLeAAJ28=; b=AM3XXUTUIRUgBcvAqD5b5yLOeKEVOvi0dYA788DBvTZTjXKsq+vJeMqMph5nZSYnvg VgQYawe43e95Yuqryc2DUVg8sRIx9ILlJtSsd7Y8XCpU7fQcA6/4zsp3nwb8noBX1TZF mVNN99sIbhfJtLVpR7xZZD4GfLJUwEotNkoBpH+vR19opUnEvKxWJHHE8iCSSL4ZsGx3 9kWwVFXPR9jPTiy+kf8Sbari9WIJCH8HRDUJE6ehwJLtZFjXHQg8wLBMrXhD4I6OUNwf 9T+1Kr0z5JK6KwSdFWJ9AhUPOUjMi1xABmBUG7qeo2exyztkWPncrmt7lWS4lqLmAwv4 NIFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712994837; x=1713599637; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Gjo9EnM8t0pAUFOPmuT/DntwbAB4UjW15SmyLeAAJ28=; b=Jh8XO7DgrTc3KK6epnZBVNhCJkrEWZO61tIEz48FdGJzMJK2ZopUskk3X2ZQRn3FV7 BXJGVvr5mMNSqkgWZWipar71szXRoegbK0sYgTyJ2jQCT8551tyRJuyiYqrB1qZ3HUFv jRfyWvTpbY7QncZKK9dMRhrjEhij5GaEXgQc5Zid8ANbfCAiK/ge/DnSgOROhipHAHg9 uDW9WqKuvX/OnRzXYc46eZ+rmhEVUiVOZqPbEcXRuFApEXlWYzOEgwrRAuPGXcIn715h Q6WyktGc+x3ClOvFG4aLUewEG+aO1H76kOI4OEr3+p0bo6swv2/bE14JCi62BPJpWViQ vpxg== X-Forwarded-Encrypted: i=1; AJvYcCXIdEzgEbsNe2Nb62ENnulpEr+sDgWW1zos2El6Rhbtid2vqHMelpLIYmKQWihDMPqUB4I6EQlaBPe0ifKSvLoIouyJAao= X-Gm-Message-State: AOJu0YyuOuHZAVuaUz9umh5gTP1UxiMO+2FBR8OFrhVwcY9h0UxAXCyG XhiXp5JXG1AOvApUHHkl3JmFMk/ZhttqlD/NMjzimPBRdF+ePDvv2mdUnRIQhHjLo0Jo+j4ycsQ FXJqTh41D1+QSJqvCCKnrw/vFWGZILHj9kDMzIQ== X-Google-Smtp-Source: AGHT+IFxp4ZdDo/fvqJ7Ju+0kT+JjNZjFXMLLIKLn/2iatEWI9KNFmswM/mgbFa5yGiRVk8Ou4Alm73UsUyN5/wy8RQ= X-Received: by 2002:a05:6870:b68d:b0:22e:bc50:3492 with SMTP id cy13-20020a056870b68d00b0022ebc503492mr5037006oab.47.1712994836769; Sat, 13 Apr 2024 00:53:56 -0700 (PDT) MIME-Version: 1.0 References: <86r0f9ranr.fsf@gnu.org> <86mspxr9ra.fsf@gnu.org> In-Reply-To: <86mspxr9ra.fsf@gnu.org> From: Noah Peart Date: Sat, 13 Apr 2024 00:53:45 -0700 Message-ID: Subject: Re: bug#70361: [PATCH] Add font-locking for operators in go-ts-mode. To: Eli Zaretskii Content-Type: multipart/alternative; boundary="000000000000bf73490615f5b03d" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70361 Cc: 70361@debbugs.gnu.org, Yuan Fu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000bf73490615f5b03d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > What problems do you see with the current approach that would require more fine-grained user control? The main issue for me is removing the `error` feature from any mode that adds it with `:override t`. I find the override font-locking is jarring - in some Languages half the buffer can switch in and out of parse errors when you do something as simple as removing a closing paren. Also, allowing users to rearrange features at different levels seems like a bonus. > And why do you think a defvar is the proper way of providing such control= ? You're right, I don't think it's the best way - it's just what I've been doing in treesit modes I've written till now. On Sat, Apr 13, 2024 at 12:40=E2=80=AFAM Eli Zaretskii wrote= : > > From: Noah Peart > > Date: Sat, 13 Apr 2024 00:32:59 -0700 > > Cc: 70361@debbugs.gnu.org > > > > On a somewhat related note, I was wondering why the treesit modes in > emacs > > define their `treesit-font-lock-feature-list`s in the mode definitions. > > > > Wouldn't it be more user-friendly to `defvar` the feature list? > > AFAIR, we do that in the mode's settings because the translation of > general categories into mode-specific settings is not easy, and > because we want users to control that via the fontification level, not > below that. > > What problems do you see with the current approach that would require > more fine-grained user control? And why do you think a defvar is the > proper way of providing such control? > --000000000000bf73490615f5b03d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> What problems do you see with the current approach th= at would require
more fine-grained user control?

The = main issue for me is removing the `error` feature from any mode
t= hat adds it with `:override t`. I find the override font-locking is jarring= - in some
Languages half the buffer can switch in and out of par= se errors when you
do something as simple as removing a closing p= aren.

Also, allowing users to rearrange features a= t different levels seems like a bonus.

> And wh= y do you think a defvar is the proper way of providing such control?
<= div>
You're right, I don't think it's the best wa= y - it's just what I've been doing in
treesit=C2=A0modes = I've written till now.

On Sat, Apr 13, 2024 at 12:40=E2=80=AFAM El= i Zaretskii <eliz@gnu.org> wrote:=
> From: Noah= Peart <noah= .v.peart@gmail.com>
> Date: Sat, 13 Apr 2024 00:32:59 -0700
> Cc: 70361@d= ebbugs.gnu.org
>
> On a somewhat related note, I was wondering why the treesit modes in e= macs
> define their `treesit-font-lock-feature-list`s in the mode definitions= .
>
> Wouldn't it be more user-friendly to `defvar` the feature list?
AFAIR, we do that in the mode's settings because the translation of
general categories into mode-specific settings is not easy, and
because we want users to control that via the fontification level, not
below that.

What problems do you see with the current approach that would require
more fine-grained user control?=C2=A0 And why do you think a defvar is the<= br> proper way of providing such control?
--000000000000bf73490615f5b03d-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 13 05:33:38 2024 Received: (at 70361) by debbugs.gnu.org; 13 Apr 2024 09:33:38 +0000 Received: from localhost ([127.0.0.1]:60146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvZlQ-0006x7-M5 for submit@debbugs.gnu.org; Sat, 13 Apr 2024 05:33:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvZlO-0006vl-N2 for 70361@debbugs.gnu.org; Sat, 13 Apr 2024 05:33:36 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rvZl8-0008FQ-S1; Sat, 13 Apr 2024 05:33:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=S0FgjfWgdZd1T6MVXNQYYokwv3E9lBhPZxwL9H8tt/U=; b=GvDT1HwwY+lC zf0v9wCDJhrfm4qyIdP0v+ZhHRT8oOHjQOQ9V0lWByE2Ny/eJH3d2mF0mzapJLHJs40I9dIv1+Rhk ruuXjkrl74IyCyr5JnEi7XCM5B+fOFVezEUkHPivmpLtnNchgdpX5l3aADvllCd05Us8GMOE4+djL dS45/ohpcU86kMtjB6+hs3P+a3KxNmrG2NcNU2wLY1NOE4cx6GEctDvTvZtY1pv0r498kJyOpPcOl NKFTNtSAxUQTZLszChcSbK4CNxBCOxUrswEAhZrB9cgFa18Gj0Fk8aqbrRPFdw6/NR56iJCRi/axu Xc/+eojq0unuYlmNw+JDrQ==; Date: Sat, 13 Apr 2024 12:33:15 +0300 Message-Id: <86sezpppyc.fsf@gnu.org> From: Eli Zaretskii To: Noah Peart In-Reply-To: (message from Noah Peart on Sat, 13 Apr 2024 00:53:45 -0700) Subject: Re: bug#70361: [PATCH] Add font-locking for operators in go-ts-mode. References: <86r0f9ranr.fsf@gnu.org> <86mspxr9ra.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70361 Cc: 70361@debbugs.gnu.org, casouri@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Noah Peart > Date: Sat, 13 Apr 2024 00:53:45 -0700 > Cc: Yuan Fu , 70361@debbugs.gnu.org > > > What problems do you see with the current approach that would require > more fine-grained user control? > > The main issue for me is removing the `error` feature from any mode > that adds it with `:override t`. I find the override font-locking is jarring - in some > Languages half the buffer can switch in and out of parse errors when you > do something as simple as removing a closing paren. Maybe we should have a user option to turn error feature on and off. Yuan, WDYT? > Also, allowing users to rearrange features at different levels seems like a bonus. Not sure about this one. We didn't have that in the traditional font-lock, did we? From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 14 19:26:30 2024 Received: (at 70361) by debbugs.gnu.org; 14 Apr 2024 23:26:30 +0000 Received: from localhost ([127.0.0.1]:36374 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rw9Ez-0004yt-Mf for submit@debbugs.gnu.org; Sun, 14 Apr 2024 19:26:30 -0400 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]:54539) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rw9Et-0004xB-Hb for 70361@debbugs.gnu.org; Sun, 14 Apr 2024 19:26:28 -0400 Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-517ab9a4a13so2058478a12.1 for <70361@debbugs.gnu.org>; Sun, 14 Apr 2024 16:26:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713137166; x=1713741966; darn=debbugs.gnu.org; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=3IpJdkzOYt3IqFNx5xpY+NVJWXhLRd5Fg4TSMAYHY/o=; b=jLuo2/WdjI5r5jCiRAX9zSnQ+oCAfG5OD7vphsvCBhUoBgrTpzwK81ufF7Z04m0Q3K IUBKJeh4e3dk7HtNO4IO3ObmmC00Hyt0hsaeSnCSgIDdKQTdK1Cd5m13+WPdtV3h3/qA RJhC0Afp7xdFyinrGEImnw9epugBh7eM7l1bTGBBqkSXQ6NyIK0kuSK3f6lDErJ760/Y cBuwrufmFEge6rxQXS56IlApfz1dFrjY+YzBk3kbV++0uA6w5m9rIXiKDu1ObmxYv0c8 /xAnExG9OyViLuX1PPdDePyetWASvell9CS/FN5xQ1ls6yQ2PwlADJ+cVNaCixId5O/d 7bhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713137166; x=1713741966; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3IpJdkzOYt3IqFNx5xpY+NVJWXhLRd5Fg4TSMAYHY/o=; b=EFAVzd+DKi890/xPdUywIjXjsgcoouGvPuDwNJfw3svZjg5TEhuJW8f/eYaYhwr8xg O/7ORo5xLfnlsNPxWOtpatbw59QeuHt/qfBBJ3AjzvGNv9WcIiUp5yHOidE0QmU2FXln yQwvHdlCfb2/eHcnCBZnh+WWLTHIHi0c9Vplht7s3y1pmhCUX6DG6Y+80xeB3X4+qMNv BxaNbbSpoBHOJ4QE/lADCECjmJCxJLKjg9QVQMi/UFwAlPgSMDPRHSymCy1Kly4/skGv cqXh8cyf99SZ/JH/S5PGlKU09pReogZOcUXu2qwIo0kWou2rQikOeq0IBZZzG3bR9jZ1 mEtA== X-Forwarded-Encrypted: i=1; AJvYcCXx9Q7lmqgts2greyBwFMZiRiI4PmFt6vc5QEwcaAhelWanaD12dGdVH/92uDPljGHuE+7h2Ll6/imH8vuqOwmZvDouCgY= X-Gm-Message-State: AOJu0YxhD/NmeF931nRGKdnFT+8JuXQhKu3s23la2mrF68mjTu0bn6XD VV3dSfaJm7ZpVUJzInRzURRJLizIQctqENJq9g5F5xOjWOAcrFdd X-Google-Smtp-Source: AGHT+IF9sN1eoRvPqPWD8a4B1CS/oVUEgiqpymYtMbEOU8crXSSQVitiSVmYeFxtxeRCqK5T0EaBWg== X-Received: by 2002:a17:902:e5c6:b0:1e4:2b90:7282 with SMTP id u6-20020a170902e5c600b001e42b907282mr12295064plf.14.1713137166284; Sun, 14 Apr 2024 16:26:06 -0700 (PDT) Received: from smtpclient.apple ([2601:641:300:4910:ddd5:ebc3:f048:bab8]) by smtp.gmail.com with ESMTPSA id h11-20020a170902680b00b001e0bcccc800sm4686442plk.35.2024.04.14.16.26.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 14 Apr 2024 16:26:05 -0700 (PDT) From: Yuan Fu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Re: bug#70361: [PATCH] Add font-locking for operators in go-ts-mode. Message-Id: <29DC7974-83D5-425C-83AC-CF9FEF58D091@gmail.com> Date: Sun, 14 Apr 2024 16:25:54 -0700 To: Eli Zaretskii X-Mailer: Apple Mail (2.3731.700.6) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70361 Cc: 70361@debbugs.gnu.org, Noah Peart , dev@rjt.dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Noah Peart >> Date: Sat, 13 Apr 2024 00:53:45 -0700 >> Cc: Yuan Fu , 70361@debbugs.gnu.org >>=20 >> > What problems do you see with the current approach that would = require >> more fine-grained user control? >>=20 >> The main issue for me is removing the `error` feature from any mode >> that adds it with `:override t`. I find the override font-locking is = jarring - in some >> Languages half the buffer can switch in and out of parse errors when = you >> do something as simple as removing a closing paren. > > Maybe we should have a user option to turn error feature on and off. > Yuan, WDYT? Sure, I=E2=80=99m not a big advocate for highlighting the errors to = begin with. The tree-sitter parse errors aren=E2=80=99t meant to be used for = highlighting anyway. This is just something some major mode provides because it=E2=80=99= s a nice bonus, and it=E2=80=99s effectiveness probably varies by language = grammar. The user can turn off error feature with treesit-font-lock-recompute-features, like they do for any other features. Do we want to add a user option in addition? In any case, even if we add such user option, it should be added at the major mode level, since the error feature is at major mode level, it isn=E2=80=99t = something provided uniformly across all tree-sitter modes. >> Also, allowing users to rearrange features at different levels seems = like a bonus. > > Not sure about this one. We didn't have that in the traditional > font-lock, did we? If major modes define a xxx-mode-feature-list, sure, the user can redefine that list to their liking. Again that=E2=80=99s a major mode = level decision. I CC=E2=80=99ed Randy since he=E2=80=99s the maintainer of go-ts-mode. Yuan From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 14 19:34:49 2024 Received: (at 70361) by debbugs.gnu.org; 14 Apr 2024 23:34:49 +0000 Received: from localhost ([127.0.0.1]:36383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rw9N3-0006DC-1C for submit@debbugs.gnu.org; Sun, 14 Apr 2024 19:34:49 -0400 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]:51682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rw9Mz-0006BV-Gk for 70361@debbugs.gnu.org; Sun, 14 Apr 2024 19:34:47 -0400 Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-1e0bec01232so20098635ad.3 for <70361@debbugs.gnu.org>; Sun, 14 Apr 2024 16:34:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713137668; x=1713742468; darn=debbugs.gnu.org; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=7Eixhic06OzTEe+dz/k0Xmz2+su3x+D8MgxyYCKKVlw=; b=ickW3pll4JgNQsKucYfFshNHp0kdGTCCKoYOweOBfU7R36+Wf3ge0tIQAZ3FGX4xuy Lkdqa9jeH+lMX3Scl8VIIs7X+ploDUbUwiY9VHMch804ds3cL4o9AnontFDwBVpmmeYJ LBaTTFcCjPPgLpaXtpJE1aUjBf1tVXLpC76dFkIInM22VBKGtc3vMoxeAk3nQku2NR8q eOcjSmwS3n5mwcRqVLxi8SJkS8vqRl9DZqwz4JlftvdNP0P/OOtojIUFe79L69x9wF8S qJxyI9V7Pj0rKchVyZacpOKLu7R62KR1M3mr+P7YteV2zdPw2mzz/eRR84uvA4Ev28Z5 rd8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713137668; x=1713742468; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7Eixhic06OzTEe+dz/k0Xmz2+su3x+D8MgxyYCKKVlw=; b=ckgTdzvH/rl3xm9fp+76mSeYIhd2ypHYUiHc1gftN2l9Z7fJkAOLIkKcq9c4KLbUSq SmYzQjzK7guFh+kvxqwCgrCW5sRcMKNPFczQfNf1uLSSBlLPxRCY9g9k0QuIVntVafmn bQc6L+zUb9Wp0qLIIJdH7fdkcbu222EzGJxHHmFIobKE8QqkgzOSgi6b3d6xfNj+39i/ iJaoersplZ3STobd484X+R+ZJ+XFXuovjCSA+NZZS7AlExytFAL+Bkxchaebzz8HL0f1 t5j16SrYXiI1PpJ1Wx1UgpM6MsPcTy7htoYPKyhpxBcfe7/DrPbtbkfZc4hxoNvHxWEW pHCg== X-Forwarded-Encrypted: i=1; AJvYcCXkMnNGgKT3oIXRwXJrvqMyo6lKEMqVTwk6+49gwyXXyOUsNocRFua/JgNALvwXDKTS9mhfoHQsHCnrWA811kwcB6fRKX4= X-Gm-Message-State: AOJu0YwuQ1YdVfKGbPhJIQM+VVrj5nmMyrB+uSFIRqdJbm+IzdlSgflw +Lh2AoP31h13aoLfgdyv1e9E5qSZGqG0RhcnXJl9K6pSdylD3UQ/ X-Google-Smtp-Source: AGHT+IGZQr0M3Wf+5pciuouZQ5KIXJqztAmaBBt/jB8e0TGN2+3wx3FpEiLW8OPL53CK/xes60xg3w== X-Received: by 2002:a17:902:c40a:b0:1e4:8c64:33c6 with SMTP id k10-20020a170902c40a00b001e48c6433c6mr9127649plk.59.1713137668198; Sun, 14 Apr 2024 16:34:28 -0700 (PDT) Received: from smtpclient.apple ([2601:641:300:4910:ddd5:ebc3:f048:bab8]) by smtp.gmail.com with ESMTPSA id kw14-20020a170902f90e00b001e249903b0fsm6617067plb.256.2024.04.14.16.34.27 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 14 Apr 2024 16:34:27 -0700 (PDT) From: Yuan Fu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Re: bug#70361: [PATCH] Add font-locking for operators in go-ts-mode. Message-Id: Date: Sun, 14 Apr 2024 16:34:16 -0700 To: Eli Zaretskii X-Mailer: Apple Mail (2.3731.700.6) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70361 Cc: 70361@debbugs.gnu.org, noah.v.peart@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Noah Peart >> Date: Sat, 13 Apr 2024 00:32:59 -0700 >> Cc: 70361@debbugs.gnu.org >>=20 >> On a somewhat related note, I was wondering why the treesit modes in = emacs >> define their `treesit-font-lock-feature-list`s in the mode = definitions. >>=20 >> Wouldn't it be more user-friendly to `defvar` the feature list? > > AFAIR, we do that in the mode's settings because the translation of > general categories into mode-specific settings is not easy, and > because we want users to control that via the fontification level, not > below that. > > What problems do you see with the current approach that would require > more fine-grained user control? And why do you think a defvar is the > proper way of providing such control? Replying to Noah, I don=E2=80=99t think there=E2=80=99s anything wrong = for a major mode to define a xxx-mode-feature-list and assign it to treesit-font-lock-feature-list when setting up the major mode. We just don=E2=80=99t want a central tree-sitter-font-lock-feature-list that = controls the feature list of every major mode in a single place. But again, even if a xxx-mode defines xxx-mode-feature-list, it would be a bit of a hassle to take out or remove a single feature from the list, since it=E2=80=99s a list of list. (You can just setq the whole list, = but then you need to keep it in sync with upstream.) It=E2=80=99s probably easier = to call treesit-font-lock-recompute-features in the major mode hook anyway. Yuan From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 15 08:05:58 2024 Received: (at 70361) by debbugs.gnu.org; 15 Apr 2024 12:05:58 +0000 Received: from localhost ([127.0.0.1]:37051 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwL5u-0002Tt-KX for submit@debbugs.gnu.org; Mon, 15 Apr 2024 08:05:58 -0400 Received: from mail-oa1-x2a.google.com ([2001:4860:4864:20::2a]:45536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwL5m-0002Rk-4s for 70361@debbugs.gnu.org; Mon, 15 Apr 2024 08:05:52 -0400 Received: by mail-oa1-x2a.google.com with SMTP id 586e51a60fabf-2331bef249eso1303973fac.3 for <70361@debbugs.gnu.org>; Mon, 15 Apr 2024 05:05:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713182728; x=1713787528; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=T2yHInQgxIdbfHOHgmDXAmvtPl+G/ZmEyBd9iw5Qfeg=; b=IC+XHIz+IDlhoKypm8K1y+EOpi87RXRIUjkNGGikykoYfhH7tKwJSGNsVHQeB0C5tV 3BGDCppvY5qSvRUlUTj3mevtVxzaXOBulSUd+bgQV7PK/WOpb8FxnbpP5zY49MnMQaxc hdjDSXuU+m8P/+tT6ky7aQ5oI3LKslqaYG3bsJmb3Agc1Q9KzksS4YtqVvMoCYj5JWci hHkg9pe+7xlikO5O+371aWbWWNYKI5KaC5pFSgcyoBdQLBaNylWI1AM4z20L8+Du+e2d CwXog+7/SrZQJOFgG0A4HpqVLZb1poEQiUIC4MkkwbAxg3MU3x1QTm80GCjlWIY88mDi RAnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713182728; x=1713787528; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=T2yHInQgxIdbfHOHgmDXAmvtPl+G/ZmEyBd9iw5Qfeg=; b=xRaOZLJyTjzZ1zgEJrQTemsQG+Iur0uBHQOTCst6ereRtgPdocP1wFAVvQnjZSGBqU W+V1gfp1Jx7nqhj2IAmw3a+JS09WKssRF6CtG/8SgQNt+mDB9/1q5M3Y92HrvqIvvgU1 3sRY1Zs94qfEZRC458yAzQ9lOuOWnutBR48dBeDyO3hbSBeAeDub0COzO7dF+GPJMp0a jm4NLMDCAgLTWn6eh3EVCGcv2vdMn55P/3hdYcrf3csO0baikiY9rYdnxa2dOod54mj0 GW2RvcAhh93kbDnYDxvAR2I31TFVPurtWNU/TdAUkB9UZtfM/bR00WUbiJYnwAKQT6vL 1gFQ== X-Forwarded-Encrypted: i=1; AJvYcCW8j2uw1AOf602GgWS4Z5Ys2mp78+JZewW8a6qN4/Eu+u3f07LorERWQb67F7XAo6FrkmIa5hYEev7/cnJ2TKMraPw6hGY= X-Gm-Message-State: AOJu0YxGhX4F0fl6RAB0lfP8Uk9B4XngqVKde7yNO4Yv2X6Bc//JQCNb upkQ3ya0+sZYPMs2E/CeIK2qvNlaIAamMfhKCBZLABzbA0FptAOIqvLKydY/fcce2l2bleSZHga O5ZzDKffd7eTvrp5Oz+RVRCGTLiA= X-Google-Smtp-Source: AGHT+IE5Kog6vhofQzMAXBBxy6QXkhphdMxbtKNQbn4bhcrQMVtqtHC+sN5aSsT0H8r0zFn6Mvhc++K7zxEhfRz5Yqk= X-Received: by 2002:a05:6870:8a28:b0:22a:7b20:410d with SMTP id p40-20020a0568708a2800b0022a7b20410dmr12106126oaq.33.1713182728392; Mon, 15 Apr 2024 05:05:28 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Noah Peart Date: Mon, 15 Apr 2024 05:05:17 -0700 Message-ID: Subject: Re: bug#70361: [PATCH] Add font-locking for operators in go-ts-mode. To: Yuan Fu Content-Type: multipart/alternative; boundary="000000000000f619820616216f2b" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70361 Cc: 70361@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000f619820616216f2b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thankyou, this all makes sense. I do think it would be nice if it was easier to somehow add user customizations to the font-locking, especially since it is so easy to write tree-sitter font-locking rules. > We just don=E2=80=99t want a central tree-sitter-font-lock-feature-list t= hat controls the feature list of every major mode in a single place. What would you think of something like a `user` feature that could be enabled globally and users could add their mode-specific rules there? Eg. (defvar my-treesit-font-lock-rules (treesit-font-lock-rules :language 'go :feature 'user '((identifier)) :language 'typescript :feature 'user '((identifier)) ;; ... )) This wouldn't work very well in certain cases where ordering of the rules was important, however. On Sun, Apr 14, 2024 at 4:34=E2=80=AFPM Yuan Fu wrote: > > Eli Zaretskii writes: > > >> From: Noah Peart > >> Date: Sat, 13 Apr 2024 00:32:59 -0700 > >> Cc: 70361@debbugs.gnu.org > >> > >> On a somewhat related note, I was wondering why the treesit modes in > emacs > >> define their `treesit-font-lock-feature-list`s in the mode definitions= . > >> > >> Wouldn't it be more user-friendly to `defvar` the feature list? > > > > AFAIR, we do that in the mode's settings because the translation of > > general categories into mode-specific settings is not easy, and > > because we want users to control that via the fontification level, not > > below that. > > > > What problems do you see with the current approach that would require > > more fine-grained user control? And why do you think a defvar is the > > proper way of providing such control? > > Replying to Noah, I don=E2=80=99t think there=E2=80=99s anything wrong fo= r a major mode > to define a xxx-mode-feature-list and assign it to > treesit-font-lock-feature-list when setting up the major mode. We just > don=E2=80=99t want a central tree-sitter-font-lock-feature-list that cont= rols > the feature list of every major mode in a single place. > > But again, even if a xxx-mode defines xxx-mode-feature-list, it would be > a bit of a hassle to take out or remove a single feature from the list, > since it=E2=80=99s a list of list. (You can just setq the whole list, but= then > you need to keep it in sync with upstream.) It=E2=80=99s probably easier = to call > treesit-font-lock-recompute-features in the major mode hook anyway. > > Yuan > --000000000000f619820616216f2b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thankyou, this all makes sense.=C2=A0 I do think it= =C2=A0would be nice if it was easier to somehow=C2=A0
add user cu= stomizations to the font-locking, especially since it is so easy to write t= ree-sitter
font-locking rules.

> We j= ust don=E2=80=99t want a central tree-sitter-font-lock-feature-list that co= ntrols
the feature list of every major mode in a single place.
What would you think of something like a `user` feature that co= uld be enabled
globally and users could add their mode-specific r= ules there? Eg.

=C2=A0 =C2=A0 (defvar my-treesit-f= ont-lock-rules
=C2=A0 =C2=A0 =C2=A0 (treesit-font-lock-rules
=C2=A0 = =C2=A0 =C2=A0 =C2=A0:language 'go
=C2=A0 =C2=A0 =C2=A0 =C2=A0:featur= e 'user
=C2=A0 =C2=A0 =C2=A0 =C2=A0'((identifier))

=C2=A0= =C2=A0 =C2=A0 =C2=A0:language 'typescript
=C2=A0 =C2=A0 =C2=A0 =C2= =A0:feature 'user
=C2=A0 =C2=A0 =C2=A0 =C2=A0'((identifier))
= =C2=A0 =C2=A0 =C2=A0 =C2=A0;; ...
=C2=A0 =C2=A0 =C2=A0 =C2=A0))

This wouldn't work very well in certain cases wher= e ordering of the rules
was important, however.

On Sun, Apr = 14, 2024 at 4:34=E2=80=AFPM Yuan Fu <casouri@gmail.com> wrote:

Eli Zaretskii <eliz@gn= u.org> writes:

>> From: Noah Peart <noah.v.peart@gmail.com>
>> Date: Sat, 13 Apr 2024 00:32:59 -0700
>> Cc: 703= 61@debbugs.gnu.org
>>
>> On a somewhat related note, I was wondering why the treesit modes = in emacs
>> define their `treesit-font-lock-feature-list`s in the mode definit= ions.
>>
>> Wouldn't it be more user-friendly to `defvar` the feature list= ?
>
> AFAIR, we do that in the mode's settings because the translation o= f
> general categories into mode-specific settings is not easy, and
> because we want users to control that via the fontification level, not=
> below that.
>
> What problems do you see with the current approach that would require<= br> > more fine-grained user control?=C2=A0 And why do you think a defvar is= the
> proper way of providing such control?

Replying to Noah, I don=E2=80=99t think there=E2=80=99s anything wrong for = a major mode
to define a xxx-mode-feature-list and assign it to
treesit-font-lock-feature-list when setting up the major mode. We just
don=E2=80=99t want a central tree-sitter-font-lock-feature-list that contro= ls
the feature list of every major mode in a single place.

But again, even if a xxx-mode defines xxx-mode-feature-list, it would be a bit of a hassle to take out or remove a single feature from the list,
since it=E2=80=99s a list of list. (You can just setq the whole list, but t= hen
you need to keep it in sync with upstream.) It=E2=80=99s probably easier to= call
treesit-font-lock-recompute-features in the major mode hook anyway.

Yuan
--000000000000f619820616216f2b-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 15 21:50:24 2024 Received: (at 70361) by debbugs.gnu.org; 16 Apr 2024 01:50:24 +0000 Received: from localhost ([127.0.0.1]:40832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwXxm-0007vw-Uq for submit@debbugs.gnu.org; Mon, 15 Apr 2024 21:50:23 -0400 Received: from mail-4022.proton.ch ([185.70.40.22]:18017) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwXxi-0007u9-Ns for 70361@debbugs.gnu.org; Mon, 15 Apr 2024 21:50:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1713232200; x=1713491400; bh=1kz+zEIgNsQTFU1zaXBBjVq1X2PnFt+h9KRAZwVcMPc=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=LNb5pP1ZA9McWyq0go8HviM0jpxgEVCICFFq7L5hbFg9/0ME++7uhklHyBEYze6eb 2vkD+f4OLC7kCiBpZlH9q0fN1ZJ+/D7dkNK1FokfGqVsrm2v4C88tT4CLNwaI5nHtQ L8VE8MbDxznL2QSc3giIhEkQ2ptokXpjWVIImDMLixVEGOVigKUnb+uxi+VJhPlw8T Fireu4ZutrdHsxIlGgJlNriKxVnTSzeGUCFTi2mSuLW8Lwx/0rAmNz2cQO4W57iu64 N0KfwApWud7Na7jXrYmE8HrrNWakNxUH6frkDHi0SmH9Lsq4vqFrDSWgziVu301bjE qdy2vrWGtVH0A== Date: Tue, 16 Apr 2024 01:49:53 +0000 To: Noah Peart From: Randy Taylor Subject: Re: bug#70361: [PATCH] Add font-locking for operators in go-ts-mode. Message-ID: In-Reply-To: References: Feedback-ID: 44397038:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 70361 Cc: 70361@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Saturday, April 13th, 2024 at 01:23, Noah Peart = wrote: > Tags: patch >=20 >=20 > Adds font-locking for Go operators in `go-ts-mode'. The operator feature > is already added to `treesit-font-lock-feature-list' in `go-ts-mode` - th= is > just adds the missing rule to `go-ts-mode--font-lock-settings'. Thanks for working on this. It looks good to me, would someone be able to install it? Thanks in advance= . From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 16 01:58:19 2024 Received: (at 70361) by debbugs.gnu.org; 16 Apr 2024 05:58:19 +0000 Received: from localhost ([127.0.0.1]:41798 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwbph-0006x4-8I for submit@debbugs.gnu.org; Tue, 16 Apr 2024 01:58:19 -0400 Received: from mail-ua1-x92b.google.com ([2607:f8b0:4864:20::92b]:57806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwbpd-0006w7-45 for 70361@debbugs.gnu.org; Tue, 16 Apr 2024 01:58:15 -0400 Received: by mail-ua1-x92b.google.com with SMTP id a1e0cc1a2514c-7e128b1ba75so1330804241.3 for <70361@debbugs.gnu.org>; Mon, 15 Apr 2024 22:58:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713247075; x=1713851875; darn=debbugs.gnu.org; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=R2m/EWf+tvoZGcAQbfSN+2bj51Z1l2ozNpflR0S5TY8=; b=V5WPeabT4PZzMqoLA5pJBL3F9BySG8kaVQ8OGz3rpPupsWszKvnl0ikGKgE5YLH4QM K6m78bErmCw9I9CvwDmCQO2ufNuGA22z6TvkqA3MuPv4WbwfLKnyol+mf2xiFDQproCF 3r6I3TPCBn8nWdq8HH7aDQ35IFFEpZBP/JrUJriazN6BqWG5UHbj9AxZtb/zjOLBA8/p VYJyq6MDKNuZlX0hCzqa9elgy/YxGa4+vNJpfrTp+QMA0USkPdE8ecUQ98/5iJ3V6CXw OVSk01fp49hsclRSvbYIRQmUa/L2mgGPgPlMndBpuN75x/oBv3t7mw5JLX71kMk+MUPa P2OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713247075; x=1713851875; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R2m/EWf+tvoZGcAQbfSN+2bj51Z1l2ozNpflR0S5TY8=; b=Yi+zKSP+miVajsQ27rM+Dqm8NT16du76QDcrrtw1Rln6TZWFuug3Vq2HTVUXuEpE4n LnCYUVQwLudqv5N5GTReeuRSl1W/Mc9eZNaI8sKfQVn7l0UPvibHXhQIrPDoFIL/40uy M94HWSogRX4tqwjL+3JhPsAEzbs39eJW20s76JgB5pYazn7ErrVxJe0UU8T7Sv2TJ7Nw Bhe5qCv+COo516LdycYmjYPFCsD+QPvKGw86uHCpeHGVmo3WtgkW80qFecUwg6jmjxFF qYEjeK2JlQ8SjgFxR32PG2qcLtzvGAGL1540BNm78+Xd9D5ViaxILH+KcdSMMTnywNqi aP0A== X-Gm-Message-State: AOJu0Yx8xELZhaV6+3MEYZPwdVsQHqb554rO49GTn0QCOdS300mk5jKa KjWEmGFaCW9hcT5B7nVp2Y+zai1v8LVhtLqusMeTU4JjBZ3/tFGo X-Google-Smtp-Source: AGHT+IHlRlFeMSpTqnraLjnIKuClj1f6IFjJd+WRdYtrjDqqnH0OXTniet6ZlkDuojtvvCi5sSDdOA== X-Received: by 2002:a05:6102:160b:b0:479:d2ff:7cfb with SMTP id cu11-20020a056102160b00b00479d2ff7cfbmr14896012vsb.24.1713247075153; Mon, 15 Apr 2024 22:57:55 -0700 (PDT) Received: from smtpclient.apple ([2601:641:300:4910:b0d6:b334:a9ae:40be]) by smtp.gmail.com with ESMTPSA id x30-20020a056a00189e00b006eaf43b5982sm3312964pfh.108.2024.04.15.22.57.53 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Apr 2024 22:57:54 -0700 (PDT) From: Yuan Fu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Re: bug#70361: [PATCH] Add font-locking for operators in go-ts-mode. Message-Id: Date: Mon, 15 Apr 2024 22:57:43 -0700 To: Noah Peart X-Mailer: Apple Mail (2.3731.700.6) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70361 Cc: 70361@debbugs.gnu.org, eliz@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Noah Peart writes: > Thankyou, this all makes sense. I do think it would be nice if it was = easier to somehow=20 > add user customizations to the font-locking, especially since it is so = easy to write tree-sitter > font-locking rules. Right. We (well, I) were focusing on support for writing major modes and didn=E2=80=99t give enough attention to the customization aspect, = especially for beginners. >> We just don=E2=80=99t want a central = tree-sitter-font-lock-feature-list that controls > the feature list of every major mode in a single place. > > What would you think of something like a `user` feature that could be = enabled > globally and users could add their mode-specific rules there? Eg. > > (defvar my-treesit-font-lock-rules > (treesit-font-lock-rules > :language 'go > :feature 'user > '((identifier)) > > :language 'typescript > :feature 'user > '((identifier)) > ;; ... > )) > > This wouldn't work very well in certain cases where ordering of the = rules > was important, however. I think that=E2=80=99s a good start. I like that it=E2=80=99s tied to = each language rather than a major mode, so it avoids problems with derived major modes. Indentation can also use some easy customization options. On a separate note, something like this might be better off in a ELPA package, such that it has more freedom to evolve and break things. Things that are added to Emacs core tend to fossilize, or at least become very hard to change. (To be precise, I mean the interface tend to be hard to change, implementation details can and do change all the time.) I=E2=80=99d say that order wouldn=E2=80=99t be a problem since I imagine = most of tht time, the user wants their fontification override all else. Yuan From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 16 01:59:12 2024 Received: (at 70361) by debbugs.gnu.org; 16 Apr 2024 05:59:12 +0000 Received: from localhost ([127.0.0.1]:41806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwbqZ-00074x-Ne for submit@debbugs.gnu.org; Tue, 16 Apr 2024 01:59:12 -0400 Received: from mail-pf1-x430.google.com ([2607:f8b0:4864:20::430]:50437) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwbqW-00073f-UE for 70361@debbugs.gnu.org; Tue, 16 Apr 2024 01:59:10 -0400 Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-6ed691fb83eso3263974b3a.1 for <70361@debbugs.gnu.org>; Mon, 15 Apr 2024 22:58:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713247131; x=1713851931; darn=debbugs.gnu.org; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=27lANKd+XgfvrGxWWwwzj7MrDG0aGstyp8OB7PGUSMQ=; b=lVmIvaaidF0hviTREzEfmt50bpBSXq0W4X/6uTS54zLXjDSnkjq6l0z187ICYx2+Ck tqWUI9RKp/SFsEjEUJP5ZMncpRXYI3e19MbVsxW/rVevl8kjaXhVp/DY8VIpkRScYbAU jPWj0Tp4/UpeJFbAdaD13d15KCGwkykpWMtV26nn1f227sllyF2x7DQdVcQXrm9akHFM V8HgJkE5WFIeNE6zQHmVx8y48ZCI8X+/V+LRApJRISFqwK9QnjYMZlY/vzvGLImJNbFC GwdvKNNtN6aXMajj7BU19i0h2Dfds/BvGVcc70ezogL0RbwalavlaY5oRSAXdAFIMjJj fNxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713247131; x=1713851931; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=27lANKd+XgfvrGxWWwwzj7MrDG0aGstyp8OB7PGUSMQ=; b=TYDGOW6g4ylmpG6ZKUQcVlO2JpMyWpfjDkGjKMV13fyAcOLg11v/xQs8RkqCYyJJDh FGUw1QepkZaPFQsjgQT/MNWAheJUbKi8tw5rJfhy4pTr8wqFlvqOgSetlSucf/1IJfa8 i+kXqqNdXA9uCeF428UBV+39XeTsteqrabtXkbv0FUvfciDjUvky4LOq2UTq592AQBN+ Cn8O4o2ikdhrt7KjeAacp0eOL9sgAJk3hql6qakklLfHV3Sg0nFFTOPwsl3Y8A07LL+2 hxC4tX6osRKEGQVrOdzkapAYP25g0vPmkFF6ApFLyNnuLgcIzAhlpl0md9W8s/5URGfz Me7g== X-Forwarded-Encrypted: i=1; AJvYcCUid38uHfghvE4qU+v4rqpWNCGH97pyYyOUP0iUbaaLTF8x05eOkG7Trtrp7oUGuCgx/RmkZmKvJ9KVz59I+L50hLEat84= X-Gm-Message-State: AOJu0Yw5X81MzuKjW5l3TQAN7iIY1JkPgdmgp5udg4ckrV5HPVA8cD6y YLGQKrcaYIrN5c65kykzHjbqOh6hm/N+CCggocAM1o1KDpXF+3C2 X-Google-Smtp-Source: AGHT+IHd0aR+hw4KRy6zuY8F8CAxlyhrDis/4+0UbdTHesCRy2iDAaFlSJ4lZ9C4yan+TTB7aXnPZA== X-Received: by 2002:a05:6a00:2d88:b0:6ed:21b2:cb17 with SMTP id fb8-20020a056a002d8800b006ed21b2cb17mr12209259pfb.4.1713247130849; Mon, 15 Apr 2024 22:58:50 -0700 (PDT) Received: from smtpclient.apple ([2601:641:300:4910:b0d6:b334:a9ae:40be]) by smtp.gmail.com with ESMTPSA id x30-20020a056a00189e00b006eaf43b5982sm3312964pfh.108.2024.04.15.22.58.50 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Apr 2024 22:58:50 -0700 (PDT) From: Yuan Fu Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Re: bug#70361: [PATCH] Add font-locking for operators in go-ts-mode. Message-Id: <6EA4DADC-BD27-48F9-A65B-29BE0EF7DB92@gmail.com> Date: Mon, 15 Apr 2024 22:58:39 -0700 To: Randy Taylor X-Mailer: Apple Mail (2.3731.700.6) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70361 Cc: 70361@debbugs.gnu.org, noah.v.peart@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Randy Taylor writes: > On Saturday, April 13th, 2024 at 01:23, Noah Peart = wrote: >> Tags: patch >>=20 >>=20 >> Adds font-locking for Go operators in `go-ts-mode'. The operator = feature >> is already added to `treesit-font-lock-feature-list' in `go-ts-mode` = - this >> just adds the missing rule to `go-ts-mode--font-lock-settings'. > > Thanks for working on this. > > It looks good to me, would someone be able to install it? Thanks in = advance. Done. Yuan From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 16 08:35:17 2024 Received: (at 70361) by debbugs.gnu.org; 16 Apr 2024 12:35:18 +0000 Received: from localhost ([127.0.0.1]:43641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwi1t-000819-Ig for submit@debbugs.gnu.org; Tue, 16 Apr 2024 08:35:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwi1q-000809-Fd for 70361@debbugs.gnu.org; Tue, 16 Apr 2024 08:35:15 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rwi1Y-0002V0-MK; Tue, 16 Apr 2024 08:34:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=wzV26z7YgJQzszDx1eRAXs+vyQpNVuxBYlz8pkUB8Os=; b=dbLdTkfRgaje H3gzOX0CO4FB9uJFj7vSy2I3n3mri4l8+fVGTTNG7dyWyTKyFzuvkiWIIo89FHz6nfVuuXTxpM/az EO4ImFKWfIBS2XtEQkiF6kGr6sdzZ9p+wQ+GPvfA/0X/RiNU13gGJpIeFcDlMShbSe+f84CNxII2t D9Nm0d1026N9IbpFzUITaO7/fv9MEyprivE5ZyexzZ45j2n9EYGHp1hKFDkTLrQm0dVYLfgceGKfg eauMu1xw4sibfbxAzM0vP0xGqgC39MLB0/n1L4EW+rzMO851S6dW7bj5BAqY2B/saW9p33k+KLkRT tpg5zxSymvCuMmT/Yu0E4Q==; Date: Tue, 16 Apr 2024 15:34:46 +0300 Message-Id: <86bk69jxjt.fsf@gnu.org> From: Eli Zaretskii To: Yuan Fu In-Reply-To: <6EA4DADC-BD27-48F9-A65B-29BE0EF7DB92@gmail.com> (message from Yuan Fu on Mon, 15 Apr 2024 22:58:39 -0700) Subject: Re: bug#70361: [PATCH] Add font-locking for operators in go-ts-mode. References: <6EA4DADC-BD27-48F9-A65B-29BE0EF7DB92@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70361 Cc: 70361@debbugs.gnu.org, dev@rjt.dev, noah.v.peart@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 70361@debbugs.gnu.org, noah.v.peart@gmail.com > From: Yuan Fu > Date: Mon, 15 Apr 2024 22:58:39 -0700 > > > Randy Taylor writes: > > > Thanks for working on this. > > > > It looks good to me, would someone be able to install it? Thanks in advance. > > Done. Thanks. Should this bug be closed now? From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 16 22:48:12 2024 Received: (at 70361-done) by debbugs.gnu.org; 17 Apr 2024 02:48:12 +0000 Received: from localhost ([127.0.0.1]:45447 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwvLH-0004Y3-O0 for submit@debbugs.gnu.org; Tue, 16 Apr 2024 22:48:12 -0400 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]:56453) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwvLE-0004XG-EM for 70361-done@debbugs.gnu.org; Tue, 16 Apr 2024 22:48:10 -0400 Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-1e3e84a302eso34713495ad.0 for <70361-done@debbugs.gnu.org>; Tue, 16 Apr 2024 19:47:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713322070; x=1713926870; darn=debbugs.gnu.org; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=mYnCcvuhxyZJn6fa6FgrOQaXEU5RtpvVIf1Cyzt9Duk=; b=IBHpdwYyEEiZJh8L3vLG+x+N13/4j4W3bUkPfa6rRrg2U+8FAx7PUUhaIVv+LYHyvg GELnhpLvX7VNf/eMoV9diI4pfnk5X8xJ4onLxk6xvDnW5FCiTJrr956ABznQjgfjEEju eLwyuJeDQAPBEGygXHwX+OItnd8r69/ovkTm+RBNavH7tL91hFWtA/Xw4PJl+GB0Gtob n74RRR/m2k9mpeWiYUnLQBgkneHTUPyCNrJGGJjms1bPuMlrFvlY8McSlpCcG2hx/ran xOuc1iArrf0nbzcV1e/i1Gjxg4vLEFffMbGrLzkYANVq1zt0e2x+D1aiaYVKIzkDU6G7 EUUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713322070; x=1713926870; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mYnCcvuhxyZJn6fa6FgrOQaXEU5RtpvVIf1Cyzt9Duk=; b=mCt1m5/IqsBJxTtKSRLrd0ARnW7C7+yWbbKVf7SgQaTHG/eNxYHDOi1FstjjxSqYnT 7k208dTK4Ld66OhRTgMtmz0p8KqtZnrluSDzSy2cXerC7ekmCS17Edu9Fj6WRSc+vqnO GLA0xIb4u12mfs1VPYQEXsAsHIS5aXpHv/V7urKW6iW2FGm2egWtdc8UEnVe2PH4Fld2 6hpYF3Af4ZIViUufCQanY78+bWQiFGU77T4vLPLadiFE6ptutYE9PC1qGQRBNfBIeIkt ajFBaipmD39PzrP+dDmqJ9/0s7/3GXNQNYYu35hjLDUpse6Lsmd6zCTi/HrRp6JDPz2/ nhng== X-Gm-Message-State: AOJu0Yy11I/ZwGIIbVgKIntRNKF+4exRb7yovr4b7/HmETnV8GiKP8s1 AyDDWH5Y578NCWjRwFdTK5sHYykQqvob239A08I6i7flr5mbxrZ5 X-Google-Smtp-Source: AGHT+IFVi6oq7UQSyUI6/NN3jpF6vh8otR6t6Nz3py50lME67toUr+8tTi3P5hfpEg+ijaVPpDDM7A== X-Received: by 2002:a17:903:2302:b0:1e3:e563:57ed with SMTP id d2-20020a170903230200b001e3e56357edmr17352800plh.36.1713322069884; Tue, 16 Apr 2024 19:47:49 -0700 (PDT) Received: from smtpclient.apple ([2601:641:300:4910:b0d6:b334:a9ae:40be]) by smtp.gmail.com with ESMTPSA id w10-20020a170902e88a00b001e3e0a8b32asm10456436plg.45.2024.04.16.19.47.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Apr 2024 19:47:49 -0700 (PDT) From: Yuan Fu Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Re: bug#70361: [PATCH] Add font-locking for operators in go-ts-mode. Message-Id: <9A94D19C-45EB-4B90-8A3F-5B13E22D03AB@gmail.com> Date: Tue, 16 Apr 2024 19:47:37 -0700 To: Eli Zaretskii X-Mailer: Apple Mail (2.3731.700.6) X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 70361-done Cc: 70361-done@debbugs.gnu.org, dev@rjt.dev, noah.v.peart@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> Cc: 70361@debbugs.gnu.org, noah.v.peart@gmail.com >> From: Yuan Fu >> Date: Mon, 15 Apr 2024 22:58:39 -0700 >>=20 >>=20 >> Randy Taylor writes: >>=20 >> > Thanks for working on this. >> > >> > It looks good to me, would someone be able to install it? Thanks in = advance. >>=20 >> Done. > > Thanks. Should this bug be closed now? Yeah we can continue the discussion but close the bug. Yuan From unknown Tue Jun 17 22:27:33 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 15 May 2024 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator